Re: [Qemu-devel] [PULL 0/5] s390x: Fixes and features

2015-10-07 Thread Christian Borntraeger
Am 07.10.2015 um 22:55 schrieb Peter Maydell: > On 6 October 2015 at 11:41, Christian Borntraeger > wrote: >> Peter, >> >> here are some fixes (and a small feature) for s390x. >> >> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14: >> >> Merge

Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

2015-10-07 Thread Richard Henderson
On 10/07/2015 09:34 PM, James Hogan wrote: { INDEX_op_brcond_i32, { "rZ", "rZ" } }, +#if !use_mips32r6_instructions { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "0" } }, +#else +{ INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "rZ" } }, +#endif The only thing I'd change is

[Qemu-devel] [PATCH v2 0/5] Connect the SPI devices to ZynqMP

2015-10-07 Thread Alistair Francis
Connect the SPI devices to Xilinx's ZynqMP. I also need to make some changes to the actual SPI device to imporove the fuctionality, but for the time being this works. V2: - Connect the SPI flash in the board code - Update git patches to properly indicate rename - Add sst25wf080 as a SPI flash

[Qemu-devel] [PATCH v2 5/5] xlnx-ep108: Connect the SPI Flash

2015-10-07 Thread Alistair Francis
Connect the sst25wf080 SPI flash to the EP108 board. Signed-off-by: Alistair Francis --- V2: - Use sst25wf080 instead of m25p80 hw/arm/xlnx-ep108.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c

Re: [Qemu-devel] [PATCH v3 3/9] target-arm: Add support for S2 page-table protection bits

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 17:19, Alex Bennée wrote: > > Edgar E. Iglesias writes: > >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >> target-arm/helper.c | 41

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 11:50, Pavel Fedin wrote: > Hello! > >> Nudge -- have you reported this as a kernel bug against the >> PCI generic driver yet? > > Sorry, stopped tracking this topic after option upstreaming. Just > sent out patches, cc'ed to you. Yes, just saw those,

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 17:32, Nutan Shinde wrote: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c| 9 ++--- > hw/audio/sb16.c | 15 +--

Re: [Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the SPI devices

2015-10-07 Thread Alistair Francis
On Wed, Sep 30, 2015 at 2:15 PM, Peter Crosthwaite wrote: > On Tue, Sep 29, 2015 at 4:03 PM, Alistair Francis > wrote: >> Connect the Xilinx SPI device to the ZynqMP model. >> >> Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 14:05, Andreas Färber wrote: > my "make test" patch (which Peter keeps refusing to apply for two > releases now) For what it's worth, I am not currently aware of a patch from you that I am refusing to apply. There's a lot of traffic on the list, and it's

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 14:31, Andreas Färber wrote: > It is non-technical and called plagiarism. I don't think the text g_strdup_printf("-device ivshmem,shm=%s,size=1M", (yes, even the final argument differs between your version and Marc-André) counts as plagiarism. > The common denominator is

Re: [Qemu-devel] [PULL 0/5] s390x: Fixes and features

2015-10-07 Thread Peter Maydell
On 6 October 2015 at 11:41, Christian Borntraeger wrote: > Peter, > > here are some fixes (and a small feature) for s390x. > > The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v2 3/3] exec.c: Collect AddressSpace related fields into a CPUAddressSpace struct

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 10:57, Richard Henderson wrote: > On 10/02/2015 12:29 AM, Peter Maydell wrote: >> >> +cpu->cpu_ases = g_new0(CPUAddressSpace, 1); >> +cpu->cpu_ases[0].cpu = cpu; >> +cpu->cpu_ases[0].as = as; >> +cpu->cpu_ases[0].tcg_as_listener.commit =

[Qemu-devel] [PATCH v2 2/5] ssi: Move ssi.h into a separate directory

2015-10-07 Thread Alistair Francis
Move the ssi.h include file into the ssi directory. Signed-off-by: Alistair Francis --- V2: - Change git patch to indicate rename hw/arm/pxa2xx.c | 2 +- hw/arm/spitz.c | 2 +- hw/arm/stellaris.c | 2 +-

[Qemu-devel] [PATCH v2 1/5] m25p80.c: Add sst25wf080 SPI flash device

2015-10-07 Thread Alistair Francis
Add the sst25wf080 SPI flash device. Signed-off-by: Alistair Francis --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index efc43dd..7b9f97c 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 12:51, Alex Bennée wrote: > > Edgar E. Iglesias writes: > >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >> target-arm/cpu.h| 1 + >>

[Qemu-devel] [PATCH v2 3/5] xilinx_spips: Seperate the state struct into a header

2015-10-07 Thread Alistair Francis
Seperate out the XilinxSPIPS struct into a seperate header file. Signed-off-by: Alistair Francis --- V2: - Only split out required #defines - Prefix XLNX_SPIPS_ hw/ssi/xilinx_spips.c | 54 --- include/hw/ssi/xilinx_spips.h | 74

[Qemu-devel] [PATCH 7/8] migration: new migration test mode

2015-10-07 Thread Denis V. Lunev
From: Igor Redko In this patch the ability to start a migration with test-only capability was added. It allows to gather the guest VM’s memory usage statistics avoiding time and memory overheads and real data transmission. New MIGRATION_STATUS_TEST_COMPLETED was added to

[Qemu-devel] [PATCH 8/8] migration: add output of gathered statistics

2015-10-07 Thread Denis V. Lunev
From: Igor Redko In this patch the output of the test results was added. If the test was successfully completed, it would be displayed in info migrate. Signed-off-by: Igor Redko Reviewed-by: Anna Melekhova Signed-off-by: Denis

Re: [Qemu-devel] How to build the latest Qemu on Mac OS X 10.11 (El Capitan ) ?

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 05:23, Aaron Elkins wrote: > Hi all, > > I am currently working on Mac OS X 10.11 (El Capitan), and > I want to know if I can build Qemu on it? and how? Haven't tested 10.11, but it should work (10.10 definitely does). Check the 'how to build'

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > It is not clear what separates REPLAY_ASYNC_EVENT_BH from other async > events. It seems to be an ordering issue, but then why do input events > not have to be looked up in the queue? It would be much

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Stefan Hajnoczi
On Tue, Oct 6, 2015 at 6:42 PM, Nutan Shinde wrote: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 28 +++ > hw/audio/es1370.c | 60 +- > hw/audio/gus.c| 26

Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:49, Daniel Fahlgren wrote: > Hi, > > On Mon, 2015-09-14 at 22:07 +0200, Daniel Fahlgren wrote: >> This patch adds support to emulate the watchdog functionality on the >> Winbond w83627thf chip. The other features of the chip are not emulated. >> It has been tested with Ubuntu

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Peter Krempa
On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currenly VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:54 hat John Snow geschrieben: > > > On 10/06/2015 04:57 AM, Kevin Wolf wrote: > > Am 05.10.2015 um 23:15 hat John Snow geschrieben: > >> > >> > >> On 09/21/2015 08:25 AM, Peter Lieven wrote: > >>> PIO read requests on the ATAPI interface used to be sync blk requests. > >>>

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Christoffer Dall
On Wed, Oct 07, 2015 at 09:02:47AM +0100, Peter Maydell wrote: > On 7 October 2015 at 08:57, Pavel Fedin wrote: > > Knock-knock! > > > > PM: I remember we had a talk that we should settle down on migration data > > format. Isn't it right > > time? > > I think Christoffer

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-07 Thread Aneesh Kumar K.V
Stefan Hajnoczi writes: > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: >> If the user tries to hot unplug a virtio-9p device, it seems to succeed but >> in fact: >> - virtio-9p coroutines thread pool and async queue are leaked >> - QEMU crashes in

[Qemu-devel] [PATCH 4/8] migration: add function for reseting migration bitmap

2015-10-07 Thread Denis V. Lunev
From: Igor Redko Adds function ram_migration_bitmap_reset(), which resets migration_bitmap and sends a number of dirtied bytes since the last call. During estimation of dirty bytes rate and migration downtime we must avoid any copying and transferring data, but we also

[Qemu-devel] [PATCH 3/8] migration: add new capability test-only

2015-10-07 Thread Denis V. Lunev
From: Igor Redko This patch declares a new migration capability that allows to distinguish between true migration and the test. An alternative is using a custom URI but in this case the following problems should be solved: 1/ QEMUFile abstraction hides the real transport

[Qemu-devel] [PATCH 5/8] migration: add draft of new transport

2015-10-07 Thread Denis V. Lunev
From: Igor Redko In this patch transport test is added. It can be used to estimate the possibility of live migration given downtime and bandwidth. In this patch basic functionality is implemented to meet the QEMUFile interface requirements. This transport is write-only.

Re: [Qemu-devel] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:49 hat Alberto Garcia geschrieben: > On Tue 06 Oct 2015 05:30:07 PM CEST, Kevin Wolf wrote: > >> -options = qdict_new(); > >> -if (has_snapshot_node_name) { > >> -qdict_put(options, "node-name", > >> - qstring_from_str(snapshot_node_name)); > >>

[Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Pavel Fedin
Knock-knock! PM: I remember we had a talk that we should settle down on migration data format. Isn't it right time? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 3/4] why is runstate_is_running needed? > > It doesn't seem correct to call it for all

Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf

2015-10-07 Thread Daniel Fahlgren
Hi, On Mon, 2015-09-14 at 22:07 +0200, Daniel Fahlgren wrote: > This patch adds support to emulate the watchdog functionality on the > Winbond w83627thf chip. The other features of the chip are not emulated. > It has been tested with Ubuntu 6.06, 14.04 and 15.04 as guests using the > w83627hf_wdt

Re: [Qemu-devel] Debugging Migration

2015-10-07 Thread Denis V. Lunev
On 10/07/2015 02:02 AM, John Snow wrote: On 10/06/2015 06:40 PM, Denis V. Lunev wrote: On 10/06/2015 09:46 PM, John Snow wrote: Is there a convenient way of "pausing" or stalling a live migration to allow methodical testing of race conditions? I'd like to instrument something along the lines

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Nutan Shinde
> > Hi, > The change was to remove macros defined as IT_WRITE_PROTO and > IT_READ_PROTO. These macros were used for function definitions. So, I have > replaced these macros with actual function definitions. >

[Qemu-devel] [RFC 0/8] QEMUFile-way to gather VM's memory statistics

2015-10-07 Thread Denis V. Lunev
This code is not ready to be merged. It is sent in the hope that it could be useful and we could invent better architectural approach for the feature if possible. +tch set summary: - we added a feature that allows to gather VM's memory usage statistics with minimum interference with VM’s work

[Qemu-devel] [PATCH 2/8] qemu-file: new hook in qemu-file

2015-10-07 Thread Denis V. Lunev
From: Igor Redko This patch adds hook_ram_sync() to QEMUFile abstraction. This hook can be used for passing information about dirty memory. An alternative is using existing hook_ram_load(). But this hook is designed for incoming VM migration, so using it for outcoming VM

[Qemu-devel] [PATCH 1/8] migration: fix expected_downtime

2015-10-07 Thread Denis V. Lunev
From: Igor Redko To get this estimation we must divide pending_size by bandwidth according to description of expected-downtime ("qmp-commands.hx:3246"): "expected-downtime": only present while migration is active total amount in ms for downtime that was

[Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync

2015-10-07 Thread Denis V. Lunev
From: Igor Redko The key feature of the test transport is receiving information about dirty memory. The qemu_test_sync_hook() allows to use the migration infrastructure(code) for this purpose. All calls of this hook will be from ram_save_pending(). At the first call of

Re: [Qemu-devel] [PATCH v10 00/10] Block replication for continuous checkpoints

2015-10-07 Thread Wen Congyang
Ping... On 09/25/2015 02:17 PM, Wen Congyang wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > You can the detailed information about block replication from here: > http://wiki.qemu.org/Features/BlockReplication > > Usage:

Re: [Qemu-devel] [PATCH v5 0/4] qapi: child add/delete support

2015-10-07 Thread Wen Congyang
Ping... On 09/22/2015 03:44 PM, Wen Congyang wrote: > If quorum's child is broken, we can use mirror job to replace it. > But sometimes, the user only need to remove the broken child, and > add it later when the problem is fixed. > > It is based on the following patch: >

Re: [Qemu-devel] [PATCH 1/4] replay: generalize ptimer event to bottom halves

2015-10-07 Thread Pavel Dovgaluk
This one is ok. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 1/4] replay: generalize ptimer

Re: [Qemu-devel] [PATCH] qobject: Replace property list with GHashTable

2015-10-07 Thread Pavel Fedin
Hello! > Hmm.. modifying a child object internally should be fine, shouldn't > it? IIUC only trying to remove it, change the key or the pointer to > the value should be problematic. The glib documentation says that "Modifying the hash table after calling this function invalidates the

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 08:57, Pavel Fedin wrote: > Knock-knock! > > PM: I remember we had a talk that we should settle down on migration data > format. Isn't it right > time? I think Christoffer has a patchset which specifies the userspace API for KVM for this, which is

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Pavel Fedin
> I think Christoffer has a patchset which specifies the > userspace API for KVM for this, which is probably the > right place to start. Christoffer? I haven't seen anything from him, BTW, i also posted already 4 versions of this... http://www.spinics.net/lists/kvm-arm/msg16219.html

Re: [Qemu-devel] [PATCH 2/4] more replay fixes

2015-10-07 Thread Pavel Dovgaluk
This one is ok too. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 2/4] more replay fixes >

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:21, Pavel Dovgaluk wrote: > There are two kinds of events: > - read from the log and injected immediately (user input, network input) > - read from the log and wait for corresponding event in the queue (BH) > > We cannot inject BH event immediately because we do not have any

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Markus Armbruster
No trace of IO_READ_PROTO and IO_WRITE_PROTO in the patch. Did you mean to send this patch with this subject? Nutan Shinde writes: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 28 +++ > hw/audio/es1370.c |

Re: [Qemu-devel] How to get started with the source code of Qemu?

2015-10-07 Thread Thomas Huth
On 06/10/15 16:17, Aaron Elkins wrote: > Hi all, > > I am new to Qemu, and I’m extremely interested in understanding how the > source code of Qemu work. But after > I downloaded the whole project, I just lost in it, the project is too large > for me to get started. A very rough survey: - The

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:14, Pavel Dovgaluk wrote: > > It doesn't seem correct to call it for all checkpoints, but why > > is it right for timerlist_run_timers? > > Because replaying shouldn't proceed when machine is stopped. Right, but VIRTUAL and VIRTUAL_RT do not proceed when the machine is

[Qemu-devel] [PATCH v6 00/15] post-introspection cleanups, subset C

2015-10-07 Thread Eric Blake
Pending prerequisite: Markus' qapi-next branch (which has my subset A patches): git://repo.or.cz/qemu/armbru.git qapi-next http://thread.gmane.org/gmane.comp.emulators.qemu/365827/focus=366351 as well as my subset B patches (currently at v7):

[Qemu-devel] [PATCH v6 12/15] qapi: Simplify error testing in test-qmp-*

2015-10-07 Thread Eric Blake
By using _abort, we can avoid a local err variable in situations where we expect success. By moving err into data, we can let test teardown take care of cleaning up any collected error (and allowing for fewer lines of code between repeated tests where init runs teardown on our behalf).

Re: [Qemu-devel] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Wen Congyang
On 10/07/2015 10:12 PM, Alberto Garcia wrote: > On Tue 22 Sep 2015 09:44:20 AM CEST, Wen Congyang wrote: > >> +++ b/block/quorum.c >> @@ -66,6 +66,9 @@ typedef struct QuorumVotes { >> typedef struct BDRVQuorumState { >> BlockDriverState **bs; /* children BlockDriverStates */ >> int

[Qemu-devel] [PATCH v6 14/15] qapi: More tests of input arrays

2015-10-07 Thread Eric Blake
Our testsuite had no coverage of empty arrays, nor of what happens when the input does not match the expected type. Useful to have, especially if we start changing the visitor contracts. Signed-off-by: Eric Blake --- v6: new patch --- tests/test-qmp-input-visitor.c | 51

Re: [Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/07/2015 09:35 PM, Alberto Garcia wrote: > On Tue 22 Sep 2015 09:44:19 AM CEST, Wen Congyang > wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. >> >> Signed-off-by: Wen Congyang >> Signed-off-by:

[Qemu-devel] [PATCH v6 10/15] qapi: Remove dead visitor code

2015-10-07 Thread Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(), but forgot got remove their declarations. Commit 4e27e819 introduced optional visitor callbacks for all sorts of int types, but except for type_uint64 and type_size, none of them have ever been supplied (the generic implementation

[Qemu-devel] [PATCH v6 04/15] qapi: Use generated TestStruct machinery in tests

2015-10-07 Thread Eric Blake
Commit d88f5fd and friends first introduced the various test-qmp-* tests in 2011, with duplicated hand-rolled TestStruct machinery, to make sure the qapi visitor interface was tested. Later, commit 4f193e3 in 2013 added a .json file for further testing use by the files, but without consolidating

[Qemu-devel] [PATCH v6 05/15] qapi: Provide nicer array names in introspection

2015-10-07 Thread Eric Blake
For the sake of humans reading introspection output, it is nice to have the name of implicit array types be recognizable as arrays of the underlying type. However, while this patch allows humans to skip from a command with return type "[123]" straight to the definition of type "123" without

[Qemu-devel] [PATCH v6 01/15] qapi: Move empty-enum to compile-time test

2015-10-07 Thread Eric Blake
Rather than just asserting that we can parse an empty enum, let's also make sure we can compile it, by including it in qapi-schema-test. Signed-off-by: Eric Blake --- v6: new patch; could be hoisted earlier alongside subset B v7 3/14 --- tests/Makefile

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/08/2015 02:33 AM, Max Reitz wrote: > On 22.09.2015 09:44, Wen Congyang wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang

[Qemu-devel] [PATCH v6 02/15] qapi: Drop redundant returns-int test

2015-10-07 Thread Eric Blake
qapi-schema-test was already testing that we could have a command returning int, but burned a command name in the whitelist. Merge the redundant positive test returns-int, and pick a name that reduces the whitelist size. Signed-off-by: Eric Blake --- v6: new patch; could be

[Qemu-devel] [PATCH v6 07/15] qapi: Change alternate layout to use 'type'

2015-10-07 Thread Eric Blake
Prepare to simplify alternate layout by creating a dedicated subclass for the generated tag type. QMP does not transmit the tag name, so we can name it whatever we want in C. But since the tag is closely tied to a qtype_code, this commit renames the tag from 'kind' to 'type', so the next commit

[Qemu-devel] [PATCH v6 13/15] qapi: Test failure in middle of array parse

2015-10-07 Thread Eric Blake
Our generated list visitors have the same problem as has been mentioned elsewhere (see commit 2f52e20): they allocate data even on failure. An upcoming patch will correct things to provide saner guarantees, but first we need to expose the behavior in the testsuite to ensure we aren't introducing

[Qemu-devel] [PATCH v6 11/15] qapi: Plug leaks in test-qmp-*

2015-10-07 Thread Eric Blake
Make valgrind happy with the current state of the tests, so that it is easier to see if future patches introduce new memory problems without being drowned in noise. Many of the leaks were due to calling a second init without tearing down the data from an earlier visit. But since teardown is

[Qemu-devel] [PATCH v6 08/15] qapi: Simplify visiting of alternate types

2015-10-07 Thread Eric Blake
Previously, working with alternates required two enums, and some indirection: for type Foo, we created Foo_qtypes[] which maps each qtype to a member of FooKind_lookup[], then use FooKind_lookup[] like we do for other union types. This has a subtle bug: since the values of FooKind_lookup start at

[Qemu-devel] [PATCH v6 06/15] qapi-introspect: Guarantee particular sorting

2015-10-07 Thread Eric Blake
Sorting the values of an enum makes it easier to look up whether a particular value is present by binary rather than linear search (probably most visible with QKeyCode, which has grown over several releases). Additionally, QMP clients need not know which C value is associated with an enum name,

Re: [Qemu-devel] [PULL 12/22] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE

2015-10-07 Thread Yuanhan Liu
On Sat, Oct 03, 2015 at 07:33:16PM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 02, 2015 at 06:18:51PM +0200, Paolo Bonzini wrote: > > > > > > On 24/09/2015 15:20, Michael S. Tsirkin wrote: > > > From: Yuanhan Liu > > > > > > Quote from Michael: > > > > > >

[Qemu-devel] [PATCH v6 03/15] qapi: Drop redundant flat-union-reverse-define test

2015-10-07 Thread Eric Blake
As of commit 8c3f8e77, we test compilation of forward references for a struct base type (UserDefOne), flat union base type (UserDefUnionBase), and flat union branch type (UserDefFlatUnion2). The only remaining forward reference being tested for parsing in flat-union-reverse-define was a forward

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

2015-10-07 Thread Laurent Desnogues
Hello, On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 1 + > target-arm/helper.c | 12 > 2

Re: [Qemu-devel] [PATCH v2 5/5] xlnx-ep108: Connect the SPI Flash

2015-10-07 Thread Peter Crosthwaite
On Wed, Oct 7, 2015 at 2:34 PM, Alistair Francis wrote: > Connect the sst25wf080 SPI flash to the EP108 board. > > Signed-off-by: Alistair Francis > --- > V2: > - Use sst25wf080 instead of m25p80 > > hw/arm/xlnx-ep108.c | 20

Re: [Qemu-devel] [PATCH v2 3/3] exec.c: Collect AddressSpace related fields into a CPUAddressSpace struct

2015-10-07 Thread Richard Henderson
On 10/08/2015 08:13 AM, Peter Maydell wrote: On 7 October 2015 at 10:57, Richard Henderson wrote: On 10/02/2015 12:29 AM, Peter Maydell wrote: +cpu->cpu_ases = g_new0(CPUAddressSpace, 1); +cpu->cpu_ases[0].cpu = cpu; +cpu->cpu_ases[0].as = as; +

[Qemu-devel] [PATCH v6 09/15] qapi: Fix alternates that accept 'number' but not 'int'

2015-10-07 Thread Eric Blake
The QMP input visitor allows integral values to be assigned by promotion to a QTYPE_QFLOAT. However, when parsing an alternate, we did not take this into account, such that an alternate that accepts 'number' but not 'int' would reject integral values. With this patch, we now have the following

[Qemu-devel] [PATCH v6 15/15] qapi: Simplify visits of optional fields

2015-10-07 Thread Eric Blake
None of the visitor callbacks would set an error when testing if an optional field was present; make this part of the interface contract by eliminating the errp argument. Then, for less code, reflect the determined boolean value back to the caller instead of making the caller read the boolean

Re: [Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/08/2015 03:00 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. > > Hi, > Have you checked the output of 'info block' after adding/deleting a child? > I'm using one

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Markus Armbruster
Copying maintainer. Please use scripts/get_maintainer.pl to find them yourself. Nutan Shinde writes: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c|

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-07 Thread Max Reitz
On 22.09.2015 09:44, Wen Congyang wrote: > The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. > It justs for adding/removing quorum's child now, and don't support all > kinds of children, It does support all kinds of children for quorum, doesn't it? >

Re: [Qemu-devel] [PATCH v6] target-tilegx: Support iret instruction and related special registers

2015-10-07 Thread Richard Henderson
On 10/07/2015 10:21 AM, Chen Gang wrote: From fa0950e403bbb98989117f632215ae0e698457d7 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 4 Oct 2015 17:41:14 +0800 Subject: [PATCH v6] target-tilegx: Support iret instruction and related special registers

[Qemu-devel] [PULL 00/19] Collected tilegx patches

2015-10-07 Thread Richard Henderson
: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-10-06 13:42:33 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tile-20151007 for you to fetch changes up to fec7daab3d63b7b2ca61581fffc40142b22b2bd5: target

[Qemu-devel] [PULL 03/19] target-tilegx: Implement v*add and v*sub instructions

2015-10-07 Thread Richard Henderson
From: Chen Gang [rth: Implement everything inline; handle v1addi and v2addi as well.] Signed-off-by: Chen Gang Message-Id: <1442873918-3394-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 14/19] target-tilegx: Handle nofault prefetch instructions

2015-10-07 Thread Richard Henderson
These are mapped onto some of the normal load instructions, when the destination is the zero register. Other load insns do fault even when targeting the zero register. Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 40 ++--

[Qemu-devel] [PULL 00/26] Do away with TB retranslation

2015-10-07 Thread Richard Henderson
) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20151007 for you to fetch changes up to 126d89e8cdfa3be15d51f76906eaccbcd0023f98: tcg: Adjust CODE_GEN_AVG_BLOCK_SIZE (2015-10-07 20:40:00 +1100

[Qemu-devel] [PULL 14/26] target-sparc: Remove gen_opc_jump_pc

2015-10-07 Thread Richard Henderson
Since jump_pc[1] is always npc + 4, we can infer after incrementing that jump_pc[1] == pc + 4. Because of that, we can encode the branch destination into a single word, and store that in npc. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 02/26] target-*: Unconditionally emit tcg_gen_insn_start

2015-10-07 Thread Richard Henderson
While we're at it, emit the opcode adjacent to where we currently record data for search_pc. This puts gen_io_start et al on the "correct" side of the marker. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 11/26] target-cris: Mirror gen_opc_pc into insn_start

2015-10-07 Thread Richard Henderson
This perhaps isn't ideal in terms of (ab)using the "pc" field to encode both pc and ppc + delay branch state, as one has to be aware of this when examining opcode dumps. But it preserves existing logic, which will be good for bisection, and it certainly does save storage space. Reviewed-by:

[Qemu-devel] [PULL 10/26] target-sh4: Add flags state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sh4/cpu.h | 1 + target-sh4/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 07/26] target-i386: Add cc_op state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/cpu.h | 1 + target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 08:20, Denis V. Lunev wrote: > +if (migrate_is_test()) { > +/* since no data is transfered during estimation all > + all measurements below will be incorrect. > + as well no need for delays. */ > +continue; > +}

Re: [Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-10-07 Thread Cornelia Huck
On Thu, 17 Sep 2015 18:42:57 +0200 Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > Reviewed-by: Greg Kurz > --- > v1->v2: make copyright explicit > --- >

[Qemu-devel] [PATCH 2/5] qga: guest exec functionality

2015-10-07 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Guest-exec rewriten in platform-independant style with glib spawn. Child process is spawn asynchroneously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Peter Krempa
[ trimmed the CC list for this ] On Wed, Oct 07, 2015 at 06:15:59 -0400, Prasanna Kalever wrote: > Hi Peter & Kevin, > > Thanks for your detailed review comments. I shall try to incorporate these > changes as a next patch-set. > > - Prasanna Kumar Kalever > > Please don't top post on

Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

2015-10-07 Thread James Hogan
On Wed, Oct 07, 2015 at 08:46:30PM +1100, Richard Henderson wrote: > On 10/02/2015 10:24 PM, James Hogan wrote: > > Extend MIPS movcond implementation to support the SELNEZ/SELEQZ > > instructions introduced in MIPS r6 (where MOVN/MOVZ have been removed). > > > > Whereas the "MOVN/MOVZ rd, rs, rt"

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
I checked this patch. Let's leave it without runstate_is_running() call. If it will be needed later, we'll find it out. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM >

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Kevin Wolf
Am 07.10.2015 um 11:09 hat Peter Krempa geschrieben: > On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > >driver => 'gluster' (protocol name) > >volname => name of gluster volume where our VM image resides > >image-path => is the absolute path of

[Qemu-devel] [PULL 08/19] target-tilegx: Let x1 pipe process bpt instruction only

2015-10-07 Thread Richard Henderson
From: Chen Gang According to the related document, bpt can be only in x1 pipe. Signed-off-by: Chen Gang Message-Id: <1443224574-2718-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test

2015-10-07 Thread Richard Henderson
Reduce the boilerplate required for each target. At the same time, move the test for breakpoint after calling tcg_gen_insn_start. Note that arm and aarch64 do not use cpu_breakpoint_test, but still move the inline test down after tcg_gen_insn_start. Reviewed-by: Aurelien Jarno

[Qemu-devel] [PULL 03/26] target-*: Increment num_insns immediately after tcg_gen_insn_start

2015-10-07 Thread Richard Henderson
This does tidy the icount test common to all targets. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 ++-- target-arm/translate-a64.c| 6 +++---

[Qemu-devel] [PULL 17/19] target-tilegx: Implement v2mults instruction

2015-10-07 Thread Richard Henderson
From: Chen Gang Signed-off-by: Chen Gang Message-Id: <1443956491-26850-3-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 15

[Qemu-devel] [PULL 08/26] target-mips: Add delayed branch state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-mips/cpu.h | 1 + target-mips/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 21/26] tcg: Remove gen_intermediate_code_pc

2015-10-07 Thread Richard Henderson
It is no longer used, so tidy up everything reached by it. This includes the gen_opc_* arrays, the search_pc parameter and the inline gen_intermediate_code_internal functions. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PULL 15/26] target-sparc: Add npc state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/cpu.h | 1 + target-sparc/translate.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

  1   2   3   >