Re: [Qemu-devel] [PULL 00/17] linux-user queque

2016-01-11 Thread Peter Maydell
xes-2015-12-23-1' into staging > (2015-12-23 13:53:32 +) > > are available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git > tags/pull-linux-user-20160111 > > for you to fetch changes up to 530c003252e07f1ea9df7f8a9adb1082d3a2eb08

Re: [Qemu-devel] [PATCH] ivshmem: remove redundant assignment, fix crash with msi=off

2016-01-11 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in > this case) > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v2 24/34] scripts/kvm/kvm_stat: Cleanup of Event class

2016-01-11 Thread Janosch Frank
Added additional newlines for readability. Factored out attribute and event setup code into own methods. Exchanged file() with preferred open(). Signed-off-by: Janosch Frank --- scripts/kvm/kvm_stat | 67 +--- 1 file

[Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup

2016-01-11 Thread Janosch Frank
Kvm_stat is a very helpful script for checking the state of VMs, but when I tried to introduce new features it broke every few lines. This patch series aims to make the script more readable and durable, so future additions to it will break it less likely. It also fixes input/output problems for

[Qemu-devel] [PATCH v2 14/34] scripts/kvm/kvm_stat: Set sensible no. files rlimit

2016-01-11 Thread Janosch Frank
As num cpus * 1000 is NOT a sensible rlimit, we need to calculate a more accurate rlimit. The number of open files is directly dependent on the cpu count and on the number of trace points per cpu. A additional constant works as a buffer for files that are needed by python or do get opened when

[Qemu-devel] [PATCH v2 10/34] scripts/kvm/kvm_stat: Fix spaces around keyword assignments

2016-01-11 Thread Janosch Frank
Keyword assignments should not not have spaces around the equal character according to PEP8. Reviewed-by: Jason J. Herne Signed-off-by: Janosch Frank --- scripts/kvm/kvm_stat | 62 ++-- 1

Re: [Qemu-devel] [PATCH v2 0/3] Use QCryptoSecret for block device passwords

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 04:12:12PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The RBD, Curl and iSCSI block device drivers all need the ability > > to accept a password to authenticate with the remote network storage > > server. Currently RBD and

Re: [Qemu-devel] [PATCH v2] qom: change object property iterator API contract

2016-01-11 Thread Andreas Färber
Am 17.12.2015 um 09:54 schrieb Markus Armbruster: > "Daniel P. Berrange" writes: > >> Currently the object property iterator API works as follows >> >> ObjectPropertyIterator *iter; >> >> iter = object_property_iter_init(obj); >> while ((prop =

Re: [Qemu-devel] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-11 Thread Vladimir Sementsov-Ogievskiy
On 04.01.2016 13:27, Fam Zheng wrote: Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 8 +++ util/hbitmap.c | 61 +- 2 files

Re: [Qemu-devel] [PATCH v3] PXB: convert to realize()

2016-01-11 Thread Markus Armbruster
Cao jin writes: > Hi, > The patch has been reviewed by: Marcel Apfelbaum > , but still not seeing it in upstream, is it > missed? Copying the maintainer you forgot :)

Re: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-11 Thread Thomas Huth
On 15.12.2015 09:35, Thomas Huth wrote: > We don't want to support the legacy -tftp, -bootp, -smb and > -net channel options forever. So let's start telling the users > that they will go away in a future version. > > Signed-off-by: Thomas Huth > --- > net/slirp.c | 3 +++ >

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

2016-01-11 Thread Prem (Premachandra) Mallappa
Hi, > You seem to have sent three copies of this in the last few hours. Is there any > difference between them? Nope, my apologies for spamming your inbox, Previous ones failed to post to _qemu-devel_, due to my office SMTP adding some incompatible bits. Cheers, /Prem

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2016-01-11 Thread Peter Maydell
gt; > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20160111 > > for you to fetch changes up to fe84fe5e2a59d5e83f043226114153bd3ccb1c51: > > hw/arm/virt: Support legacy -nic command line syntax (2016-01-11 14:23:03 > +) > > --

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 05:47:06PM +0100, Kevin Wolf wrote: > Am 24.12.2015 um 06:41 hat Denis V. Lunev geschrieben: > > On 12/24/2015 02:19 AM, Max Reitz wrote: > > >So the benefits of a qcow2 flag are only minor ones. However, I > > >personally believe that automatic unlock on crash is a very

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Andreas Färber
Am 11.01.2016 um 18:37 schrieb Markus Armbruster: > Paolo Bonzini writes: >> On 07/01/2016 10:53, Cao jin wrote: >>> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: These functions are called in the data path; changes to use

[Qemu-devel] [PATCH] block: Fix .bdrv_open flags

2016-01-11 Thread Kevin Wolf
bdrv_common_open() modified bs->open_flags after inferring the set of options to pass to the driver's .bdrv_open callback. This means that the cache options were correctly set in bs->open_flags (and therefore correctly displayed in 'info block'), but the image would actually be opened with the

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 08:44 PM, Laszlo Ersek wrote: On 01/11/16 19:01, Marcel Apfelbaum wrote: On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel Apfelbaum wrote: On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: Two reasons: - PCI Spec

Re: [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 06:14:15PM +0100, Kevin Wolf wrote: > Am 23.12.2015 um 11:47 hat Daniel P. Berrange geschrieben: > > On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: > > > On Tue, 12/22 17:46, Kevin Wolf wrote: > > > > Enough innocent images have died because users called

Re: [Qemu-devel] [RFC 12/13] migration/ram: Fix some helper functions' parameter to use PageSearchStatus

2016-01-11 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Some helper functions use parameters 'RAMBlock *block' and 'ram_addr_t > *offset', > We can use 'PageSearchStatus *pss' directly instead, with this change, we > can reduce the number of parameters for these helper function, also > it is

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel Apfelbaum wrote: On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: Two reasons: - PCI Spec indicates that while the bit is not set the memory sizing is not finished. -

Re: [Qemu-devel] [PATCH v2 1/5] virtio-net: use the backend cross-endian capabilities

2016-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2016 17:12:21 +0100 Greg Kurz wrote: > When running a fully emulated device in cross-endian conditions, including > a virtio 1.0 device offered to a big endian guest, we need to fix the vnet > headers. This is currently handled by the

Re: [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

2016-01-11 Thread Markus Armbruster
Peter Maydell writes: > On 7 January 2016 at 22:43, Max Reitz wrote: >> I hope that the above explanation helped you understand why it bled into >> tray-less devices, from a technical perspective. > > Yes, thanks, that was definitely a helpful

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-11 Thread Kevin Wolf
Am 11.01.2016 um 18:58 hat Daniel P. Berrange geschrieben: > On Mon, Jan 11, 2016 at 06:31:06PM +0100, Kevin Wolf wrote: > > Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben: > > > From: Olga Krishtal > > > > > > While opening the image we want to be sure that we

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Laszlo Ersek
On 01/11/16 19:01, Marcel Apfelbaum wrote: > On 01/11/2016 07:15 PM, Laszlo Ersek wrote: >> On 01/11/16 17:34, Marcel Apfelbaum wrote: >>> On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: > Two reasons: >- PCI Spec indicates that while the bit

Re: [Qemu-devel] [PATCH v2 0/2] change type of pci_bridge_initfn()

2016-01-11 Thread Markus Armbruster
Cao jin writes: > V2 changelog > 1. make "dec convert to realize" the 1st patch, so these two could be >independent from each other. Series Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-11 Thread Peter Maydell
On 11 January 2016 at 18:52, 陳威伯 wrote: > ping!! This is on my list to look at. It's a long-standing bug, because -L was never designed to be pointed at an arbitrary directory tree: it's supposed to point to a fairly small set of libraries in a 'system root' generated for

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 06:31:06PM +0100, Kevin Wolf wrote: > Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben: > > From: Olga Krishtal > > > > While opening the image we want to be sure that we are the > > one who works with image, anf if it is not true - > >

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-11 Thread 陳威伯
ping!!

Re: [Qemu-devel] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-11 Thread John Snow
On 01/11/2016 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: > On 04.01.2016 13:27, Fam Zheng wrote: >> Upon each bit toggle, the corresponding bit in the meta bitmap will be >> set. >> >> Signed-off-by: Fam Zheng >> --- >> include/qemu/hbitmap.h | 8 +++ >>

Re: [Qemu-devel] [PATCH v2 1/2] dec: convert to realize()

2016-01-11 Thread Markus Armbruster
Cao jin writes: > Signed-off-by: Cao jin > --- > hw/pci-bridge/dec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c > index 28d0ff9..be0fc46 100644 > ---

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Peter Maydell
On 11 January 2016 at 17:37, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 07/01/2016 10:53, Cao jin wrote: >>> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: These functions are called in the data

Re: [Qemu-devel] [PATCH v2 5/5] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2016-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2016 17:18:06 +0100 Greg Kurz wrote: > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro > and the virtio_access_is_big_endian() helper to have a branchless fast path > in the virtio memory accessors for targets that don't

Re: [Qemu-devel] [PATCH v2 3/9] s390x: remove s390-virtio devices

2016-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2016 18:12:27 +0100 Thomas Huth wrote: > Happy new year! To you as well :) > > On 07.01.2016 14:36, Cornelia Huck wrote: > > From: Pierre Morel > > > > The s390-virtio machine has been removed; remove the associated devices > > as

Re: [Qemu-devel] live migration between different qemu versions

2016-01-11 Thread Dr. David Alan Gilbert
* Alexey (aluka...@alukardd.org) wrote: > Hello. Hi, > I have two servers between which I need have live migration. > > First server have QEMU emulator version 2.3.0 > Second server have QEMU emulator version 2.5.0 > > Migration command look like this: > /usr/bin/virsh migrate --live

[Qemu-devel] [PATCH v4 3/8] dump: allow target to set the page size

2016-01-11 Thread Andrew Jones
This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by:

[Qemu-devel] [PATCH v4 7/8] elf: add arm note types

2016-01-11 Thread Andrew Jones
Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- include/elf.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/elf.h b/include/elf.h index 66add810df144..1098d217ec7ff 100644 --- a/include/elf.h +++ b/include/elf.h @@

Re: [Qemu-devel] [Bug 1529449] [NEW] serial is required for -device nvme

2016-01-11 Thread Keith Busch
On Mon, Jan 11, 2016 at 05:35:50PM +0100, Markus Armbruster wrote: > Tom Yan writes: > > Public bug reported: > > > > I am not exactly sure if this is a bug, but I don't see why the option > > "serial" should be required for -device nvme like the option "drive". > > Truth is

Re: [Qemu-devel] [PATCH] ivshmem: Store file descriptor for vhost-user negotiation

2016-01-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Dec 4, 2015 at 3:55 PM, Tetsuya Mukawa wrote: >>> What's the use case or test case? >> >> One of example is userspace device driver like DPDK PMD. >> Actually, I've found this fd related behavior using

[Qemu-devel] [PULL v2 10/11] qtest/ahci: ATAPI data tests

2016-01-11 Thread John Snow
Simple I/O tests for DMA and PIO pathways in the AHCI HBA. I believe at this point in time all of the common, major IO pathways in BMDMA and AHCI are covered by qtests now. Signed-off-by: John Snow Message-id: 1452282920-21550-9-git-send-email-js...@redhat.com ---

[Qemu-devel] [PULL v2 04/11] libqos/ahci: ATAPI support

2016-01-11 Thread John Snow
Add pathways to tolerate ATAPI commands. Notably, unlike ATA, each SCSI command's layout is a little different, so support will have to be patched in for each command as we want to test them in e.g. ahci_command_set_sizes and ahci_command_set_offset. For now, I'm adding support for 0x28, READ

[Qemu-devel] [PULL v2 03/11] ahci-test: fix memory leak

2016-01-11 Thread John Snow
Use the proper free command to detroy an AHCICommand. Signed-off-by: John Snow Message-id: 1452282920-21550-2-git-send-email-js...@redhat.com --- tests/ahci-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c

[Qemu-devel] [PULL v2 09/11] libqos/ahci: add ahci_exec

2016-01-11 Thread John Snow
add ahci_exec, which is a standard purpose flexible command dispatcher and tester for the AHCI device. The intent is to eventually cut down on the absurd amount of boilerplate inside of the AHCI qtest. Signed-off-by: John Snow Message-id:

[Qemu-devel] [PULL v2 02/11] ide: ahci: reset ncq object to unused on error

2016-01-11 Thread John Snow
From: Prasad J Pandit When processing NCQ commands, AHCI device emulation prepares a NCQ transfer object; To which an aio control block(aiocb) object is assigned in 'execute_ncq_command'. In case, when the NCQ command is invalid, the 'aiocb' object is not assigned, and

[Qemu-devel] [PULL v2 11/11] libqos/ahci: organize header

2016-01-11 Thread John Snow
Organize the prototypes into nice little sections. Signed-off-by: John Snow Message-id: 1452282920-21550-10-git-send-email-js...@redhat.com --- tests/libqos/ahci.h | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PULL v2 06/11] libqos/ahci: Switch to mutable properties

2016-01-11 Thread John Snow
ATAPI commands are, unfortunately, weird in that they can be either DMA or PIO depending on a header bit. In order to accommodate them, I'll need to make AHCI command properties mutable so we can toggle between which "flavor" of ATAPI command we want to test. The default ATAPI transfer mechanism

[Qemu-devel] [PATCH v4 1/8] qapi-schema: dump-guest-memory: Improve text

2016-01-11 Thread Andrew Jones
dump-guest-memory is supported by more than just x86, however the paging option is not. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 5/8] target-arm: support QMP dump-guest-memory

2016-01-11 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 230 +++ target-arm/cpu-qom.h |

[Qemu-devel] [PATCH v4 2/8] dump: qemunotes aren't commonly needed

2016-01-11 Thread Andrew Jones
Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by:

[Qemu-devel] [PATCH v4 0/8] target-arm: enable qmp-dump-guest-memory

2016-01-11 Thread Andrew Jones
This series brings qmp-dump-guest-memory to arm and aarch64 targets. I've detailed my testing and the results in the following table. v4: - drop aarch64_compat_sp in favor of fixing crash[*] [Peter] - added more Peter r-b's (fix 1 nit and 1 typo) [*] new crash fix: commit 4641ea1f6

[Qemu-devel] [PULL v2 00/11] Ide patches

2016-01-11 Thread John Snow
The following changes since commit 7b8a354d4716ab2c201fad04c22b8d4a16a1b8c6: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160111-1' into staging (2016-01-11 16:09:50 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull

[Qemu-devel] [PATCH v4 4/8] dump: allow target to set the physical base

2016-01-11 Thread Andrew Jones
crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v4 6/8] target-arm: dump-guest-memory: add prfpreg notes for aarch64

2016-01-11 Thread Andrew Jones
Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- target-arm/arch_dump.c | 79 +- 1 file changed, 71 insertions(+), 8 deletions(-) diff --git a/target-arm/arch_dump.c b/target-arm/arch_dump.c

Re: [Qemu-devel] [RFC 03/13] migration: Allow -incoming to work on file: urls

2016-01-11 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Usage: > -incoming file:/path/to/vm_statefile > > Signed-off-by: zhanghailiang > Signed-off-by: Benoit Canet This could again be split out of this series; however I have some

[Qemu-devel] [PULL v2 08/11] libqos/ahci: allow nondata commands for ahci_io variants

2016-01-11 Thread John Snow
These variants try to set a data offset, even if you don't specify one. In the cases where the offset is zero and it's a nondata command, just ignore the instruction. Signed-off-by: John Snow Message-id: 1452282920-21550-7-git-send-email-js...@redhat.com --- tests/ahci-test.c

[Qemu-devel] [PULL v2 01/11] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-11 Thread John Snow
From: Mark Cave-Ayland As the IDEState lba field is an int32_t, make sure we cast to int64_t before shifting to calculate the offset. Otherwise we end up with an overflow when trying to access sectors beyond 2GB as can occur when using DVD images. [Maintainer

[Qemu-devel] [PULL v2 05/11] libqos/ahci: ATAPI identify

2016-01-11 Thread John Snow
We need to say "hello!" to our ATAPI friends in a slightly different manner. Signed-off-by: John Snow Message-id: 1452282920-21550-4-git-send-email-js...@redhat.com --- tests/ahci-test.c | 8 +++- tests/libqos/ahci.c | 5 + tests/libqos/ahci.h | 1 + 3 files changed,

[Qemu-devel] [PULL v2 07/11] libqos: allow zero-size allocations

2016-01-11 Thread John Snow
As part of streamlining the AHCI tests interface, it'd be nice if specying a size of zero could be handled without special branches and the allocator could handle this special case gracefully. This lets me use the "ahci_io" macros for non-data commands, too, which moves me forward towards

[Qemu-devel] [PATCH v4 8/8] target-arm: dump-guest-memory: add vfp notes for arm

2016-01-11 Thread Andrew Jones
gdb won't actually dump these with 'info all-registers' since it first tries to confirm that it should by checking the VFP hwcap in the .auxv note. Well, we don't generate an .auxv note. Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell ---

<    1   2   3   4   5