Re: [Qemu-devel] [PATCH v4 2/4] blockdev: Fix 'change' for slot devices

2016-01-29 Thread Eric Blake
On 01/29/2016 12:49 PM, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required it to

[Qemu-devel] [PATCH v4 4/4] block/qapi: Emit tray_open only if there is a tray

2016-01-29 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block/qapi.c | 2 +- qapi/block-core.json | 4 ++-- tests/qemu-iotests/067.out | 4 3 files changed, 3 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH v4 3/4] Revert "hw/block/fdc: Implement tray status"

2016-01-29 Thread Max Reitz
This reverts the changes that commit 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c; also, an additional case of drv->media_inserted use has crept in since, which is replaced by a call to blk_is_inserted(). That commit changed tests/fdc-test.c, too, because after it, one less

[Qemu-devel] [PATCH v4 2/4] blockdev: Fix 'change' for slot devices

2016-01-29 Thread Max Reitz
'change' and related operations did not work when used on guest devices featuring removable media but no actual tray, because blk_dev_is_tray_open() always returned false for them and the blockdev-{insert,remove}-medium commands required it to return true. Fix this by making

Re: [Qemu-devel] [PATCH v4 3/4] Revert "hw/block/fdc: Implement tray status"

2016-01-29 Thread Eric Blake
On 01/29/2016 12:49 PM, Max Reitz wrote: > This reverts the changes that commit > 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c; > also, an additional case of drv->media_inserted use has crept in since, > which is replaced by a call to blk_is_inserted(). > > That commit

<    1   2   3   4