[Qemu-devel] [PATCH 2/3] mptsas: fix memory leak

2016-02-16 Thread Paolo Bonzini
Reported by Coverity. Signed-off-by: Paolo Bonzini --- hw/scsi/mptsas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 333cc1f..1ce3226 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -504,6 +504,7 @@ reply_maybe_async:

[Qemu-devel] [PATCH 1/3] mptsas: add missing va_end

2016-02-16 Thread Paolo Bonzini
Reported by Coverity. Signed-off-by: Paolo Bonzini --- hw/scsi/mptconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/mptconfig.c b/hw/scsi/mptconfig.c index d049825..7071854 100644 --- a/hw/scsi/mptconfig.c +++ b/hw/scsi/mptconfig.c @@ -123,6 +123,7 @@

[Qemu-devel] [PATCH 0/3] mptsas Coverity fixes

2016-02-16 Thread Paolo Bonzini
Adding 3000 lines of code and not having Coverity complain would be quite an achievement. Three one-line fixes suffice, though. Paolo Paolo Bonzini (3): mptsas: add missing va_end mptsas: fix memory leak mptsas: fix wrong formula hw/scsi/mptconfig.c | 1 + hw/scsi/mptsas.c| 3 ++- 2

[Qemu-devel] [PATCH 3/3] mptsas: fix wrong formula

2016-02-16 Thread Paolo Bonzini
MPI_DOORBELL_WHO_INIT_SHIFT is being repeated twice. Reported by Coverity. Signed-off-by: Paolo Bonzini --- hw/scsi/mptsas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 1ce3226..499c146 100644 ---

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-16 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Tuesday, February 16, 2016 3:53 PM > > On Tue, Feb 16, 2016 at 07:40:47AM +, Tian, Kevin wrote: > > > From: Neo Jia [mailto:c...@nvidia.com] > > > Sent: Tuesday, February 16, 2016 3:37 PM > > > > > > On Tue, Feb 16, 2016 at 07:27:09AM +,

Re: [Qemu-devel] [PULL v2 22/45] ipmi: introduce a struct ipmi_sdr_compact

2016-02-16 Thread Cédric Le Goater
On 02/16/2016 08:45 AM, Paolo Bonzini wrote: > > > On 06/02/2016 20:13, Michael S. Tsirkin wrote: >> >> -if (sdr[7] > MAX_SENSORS) { >> +if (sdr->sensor_owner_number > MAX_SENSORS) { > > This is another off-by-one, it should have been >=. Same for all these > occurrences

Re: [Qemu-devel] [PATCH 6/8] virtio-blk: do not use vring in dataplane

2016-02-16 Thread Fam Zheng
On Sun, 02/14 18:17, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/block/dataplane/virtio-blk.c | 112 > +--- > hw/block/dataplane/virtio-blk.h | 1 + > hw/block/virtio-blk.c | 49 +++--- >

Re: [Qemu-devel] [PATCH 04/12] docker: Add test runner

2016-02-16 Thread Alex Bennée
Fam Zheng writes: > On Mon, 02/15 14:10, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Mon, 02/15 12:45, Alex Bennée wrote: >> >> >> >> Alex Bennée writes: >> >> >> >> > Fam Zheng writes: >> >> > >> >> >> It's

Re: [Qemu-devel] [PATCH 7/8] virtio-scsi: do not use vring in dataplane

2016-02-16 Thread Fam Zheng
On Sun, 02/14 18:17, Paolo Bonzini wrote: > typedef struct VirtIOSCSICommon { <...> > bool dataplane_disabled; This was only set by virtio_scsi_migration_state_changed and should be replaced by dataplane_started and dataplane_fenced now. Fam

Re: [Qemu-devel] [PATCH 8/8] vring: remove

2016-02-16 Thread Fam Zheng
On Sun, 02/14 18:17, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/virtio/Makefile.objs | 1 - > hw/virtio/dataplane/Makefile.objs | 1 - > hw/virtio/dataplane/vring.c | 548 >

Re: [Qemu-devel] [PATCH v7 09/11] Dump: add qmp command "query-dump"

2016-02-16 Thread Fam Zheng
On Tue, 02/16 15:50, Peter Xu wrote: > When dump-guest-memory is requested with detach flag, after its > return, user could query its status using "query-dump" command (with > no argument). The result contains: > > - status: current dump status > - completed: bytes written in the latest dump > -

Re: [Qemu-devel] [PATCH v7 10/11] Dump: add hmp command "info dump"

2016-02-16 Thread Fam Zheng
On Tue, 02/16 15:51, Peter Xu wrote: > It will calculate percentage of finished work from completed and > total. > > Signed-off-by: Peter Xu > --- > hmp-commands-info.hx | 14 ++ > hmp.c| 17 + > hmp.h| 1 + > 3

Re: [Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-16 Thread Christian Borntraeger
On 02/16/2016 08:06 AM, Thomas Huth wrote: > On 16.02.2016 07:07, Thomas Huth wrote: >> On 10.02.2016 12:35, Christian Borntraeger wrote: >>> On 02/10/2016 12:06 PM, Michael Tokarev wrote: This is an s390 boot rom which was used in s390-virtio machine. but since commit

Re: [Qemu-devel] [PATCH 6/8] ipmi: provide support for FRUs

2016-02-16 Thread Cédric Le Goater
On 02/16/2016 04:38 AM, Corey Minyard wrote: > On 02/15/2016 12:40 PM, Marcel Apfelbaum wrote: >> On 02/15/2016 07:17 PM, Cédric Le Goater wrote: >>> On 02/14/2016 10:25 AM, Marcel Apfelbaum wrote: On 02/09/2016 02:13 PM, Cédric Le Goater wrote: > This patch provides a simple FRU support

[Qemu-devel] [PATCH] slirp: Add IPv6 support to the TFTP code

2016-02-16 Thread Thomas Huth
Add the handler code for incoming TFTP packets to udp6_input(), and make sure that the TFTP code can send packets with both, udp_output() and udp6_output() by introducing a wrapper function called tftp_udp_output(). Signed-off-by: Thomas Huth --- This patch has to be applied

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-16 Thread Neo Jia
On Tue, Feb 16, 2016 at 08:10:42AM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Tuesday, February 16, 2016 3:53 PM > > > > On Tue, Feb 16, 2016 at 07:40:47AM +, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:c...@nvidia.com] > > > > Sent: Tuesday, February

Re: [Qemu-devel] [PATCH] s390: remove misleading comment

2016-02-16 Thread Thomas Huth
On 16.02.2016 07:30, Michael Tokarev wrote: > The comment talks about a non-ELF object while the > example gives ELF object. > > Signed-off-by: Michael Tokarev > --- > hw/s390x/ipl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/ipl.c

Re: [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane

2016-02-16 Thread Christian Borntraeger
On 02/14/2016 06:17 PM, Paolo Bonzini wrote: > Currently, dataplane threads are shut down during migration because > vring.c is not able to track dirty memory. However, all the relevant > parts of QEMU have been made thread-safe now, so we can drop vring.c > completely. With these patches,

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

2016-02-16 Thread Greg Kurz
On Mon, 15 Feb 2016 15:49:17 +0100 Laurent Vivier wrote: > On 15/02/2016 13:58, Greg Kurz wrote: > > On Mon, 15 Feb 2016 12:23:39 +0100 > > Laurent Vivier wrote: > > > >> On 15/02/2016 11:15, Greg Kurz wrote: > >>> Since QEMU 2.4, the migration

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

2016-02-16 Thread Laurent Vivier
On 16/02/2016 10:09, Greg Kurz wrote: > On Mon, 15 Feb 2016 15:49:17 +0100 > Laurent Vivier wrote: > >> On 15/02/2016 13:58, Greg Kurz wrote: >>> On Mon, 15 Feb 2016 12:23:39 +0100 >>> Laurent Vivier wrote: >>> On 15/02/2016 11:15, Greg Kurz

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-16 Thread Kevin Wolf
In short: VHD is a mess and Microsoft isn't compatible with itself. That's the root cause of all the trouble we have with it. When the qemu VHD driver was written, it was designed to be compatible with Virtual PC, which used the disk geometry as the definite source for the image size. In order to

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread hitmoon
在 2016年02月16日 02:14, Peter Maydell 写道: On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >* split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and milkymist_sysctl_realize I think the "info" in this function name is wrong ? I can not understand ,

[Qemu-devel] [PATCH v10 0/3] qapi: child add/delete support

2016-02-16 Thread Changlong Xie
ChangLog: v9~v10: 1. Rebase to the newest codes 2. Address comments from Berto and Max, update the documents in block-core.json and qmp-commands.hx 3. Remove redundant codes in quorum_add_child() and quorum_del_child() v8: 1. Rebase to the newest codes 2. Address the comments from Eric Blake

[Qemu-devel] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

2016-02-16 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-devel] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

2016-02-16 Thread Changlong Xie
From: Wen Congyang The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-02-16 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread Peter Maydell
On 16 February 2016 at 09:34, hitmoon wrote: > > > 在 2016年02月16日 02:14, Peter Maydell 写道: >> >> On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >>> >>> >* split milkymist_sysctl_init into milkymist_sysctl_info.instance_init >>> > and

Re: [Qemu-devel] [PATCH 3/8] virtio: add AioContext-specific function for host notifiers

2016-02-16 Thread Cornelia Huck
On Tue, 16 Feb 2016 15:20:17 +0800 Fam Zheng wrote: > On Sun, 02/14 18:17, Paolo Bonzini wrote: > > +void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext > > *ctx, > > +bool assign, bool > > set_handler) > >

Re: [Qemu-devel] [PATCH] s390: remove misleading comment

2016-02-16 Thread Cornelia Huck
On Tue, 16 Feb 2016 09:30:35 +0300 Michael Tokarev wrote: > The comment talks about a non-ELF object while the > example gives ELF object. > > Signed-off-by: Michael Tokarev > --- > hw/s390x/ipl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread hitmoon
在 2016年02月16日 17:41, Peter Maydell 写道: On 16 February 2016 at 09:34, hitmoon wrote: 在 2016年02月16日 02:14, Peter Maydell 写道: On 27 January 2016 at 02:54, xiaoqiang zhao wrote: * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-16 Thread Greg Kurz
On Wed, 10 Feb 2016 11:22:20 +0100 Laurent Vivier wrote: > On 05/02/2016 11:39, Greg Kurz wrote: > > This series brings some improvements to the cross-endian support in the > > virtio and vhost code: > > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net,

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2016 10:44:00 -0700 Eric Blake wrote: > On 02/15/2016 10:10 AM, Igor Mammedov wrote: > > it will allow mgmt to query present and possible to hotplug CPUs > > it is required from a target platform that wish to support > > command to set board specific

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-16 Thread Kevin Wolf
Am 16.02.2016 um 07:25 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 15.02.2016 um 15:24 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > > > There could be asynchronous events that occur in non-cpu threads. >

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread David Gibson
On Mon, Feb 15, 2016 at 08:43:41PM +0100, Markus Armbruster wrote: > Igor Mammedov writes: > > > it will allow mgmt to query present and possible to hotplug CPUs > > it is required from a target platform that wish to support > > command to set board specific

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-16 Thread Michael S. Tsirkin
On Tue, Feb 16, 2016 at 10:57:19AM +0100, Greg Kurz wrote: > On Wed, 10 Feb 2016 11:22:20 +0100 > Laurent Vivier wrote: > > On 05/02/2016 11:39, Greg Kurz wrote: > > > This series brings some improvements to the cross-endian support in the > > > virtio and vhost code: > > > -

[Qemu-devel] [PATCH] usb: ohci avoid multiple eof timers

2016-02-16 Thread P J P
From: Prasad J Pandit When transitioning an OHCI controller to the OHCI_USB_OPERATIONAL state, it creates an eof timer object in 'ohci_bus_start'. It does not check if one already exists. This results in memory leakage and null dereference issue. Add a check to avoid it.

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-16 Thread Marcel Apfelbaum
On 02/11/2016 06:30 PM, Michael S. Tsirkin wrote: On Thu, Feb 11, 2016 at 04:16:05PM +0100, Igor Mammedov wrote: On Tue, 9 Feb 2016 14:17:44 +0200 "Michael S. Tsirkin" wrote: On Tue, Feb 09, 2016 at 11:46:08AM +0100, Igor Mammedov wrote: So the linker interface solves this

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-16 Thread Greg Kurz
On Tue, 16 Feb 2016 12:04:21 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 16, 2016 at 10:57:19AM +0100, Greg Kurz wrote: > > On Wed, 10 Feb 2016 11:22:20 +0100 > > Laurent Vivier wrote: > > > On 05/02/2016 11:39, Greg Kurz wrote: > > > > This series

Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Markus Armbruster
Peter Maydell writes: > On 15 February 2016 at 20:18, Andrew Jones wrote: >> On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: >>> How would the command line look like? >>> >> >> Here is what is available today >> >> # select gicv2

Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Daniel P. Berrange
On Tue, Feb 16, 2016 at 11:10:55AM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On 15 February 2016 at 20:18, Andrew Jones wrote: > >> On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: > >>> How would the command

Re: [Qemu-devel] [PATCH 0/3] mptsas Coverity fixes

2016-02-16 Thread Markus Armbruster
Paolo Bonzini writes: > Adding 3000 lines of code and not having Coverity complain would be > quite an achievement. Three one-line fixes suffice, though. Series Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] slirp: Add IPv6 support to the TFTP code

2016-02-16 Thread Samuel Thibault
Hello, Thanks for working on it :) Thomas Huth, on Tue 16 Feb 2016 09:47:38 +0100, wrote: > -static int tftp_session_allocate(Slirp *slirp, struct tftp_t *tp) > +static int tftp_session_allocate(struct sockaddr_storage *srcsas, Slirp > *slirp, > + struct tftp_t

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2016 20:43:41 +0100 Markus Armbruster wrote: > Igor Mammedov writes: > > > it will allow mgmt to query present and possible to hotplug CPUs > > it is required from a target platform that wish to support > > command to set board specific

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

2016-02-16 Thread Greg Kurz
On Tue, 16 Feb 2016 10:31:35 +0100 Laurent Vivier wrote: > On 16/02/2016 10:09, Greg Kurz wrote: > > On Mon, 15 Feb 2016 15:49:17 +0100 > > Laurent Vivier wrote: > > > >> On 15/02/2016 13:58, Greg Kurz wrote: > >>> On Mon, 15 Feb 2016 12:23:39 +0100

Re: [Qemu-devel] [PATCH 08/13] throttle: Add support for burst periods

2016-02-16 Thread Kevin Wolf
Am 05.02.2016 um 11:59 hat Alberto Garcia geschrieben: > This patch adds support for burst periods to the throttling code. > With this feature the user can keep performing bursts as defined by > the LeakyBucket.max rate for a configurable period of time. > > Signed-off-by: Alberto Garcia

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2016-02-16 Thread Colin Watson
We're now building armhf/arm64 packages on real arm64 hardware in Launchpad, so, while this problem may well still exist in qemu, it no longer applies to Launchpad builds. ** Changed in: launchpad-buildd Status: Triaged => Won't Fix -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

2016-02-16 Thread Peter Maydell
On 11 January 2016 at 14:16, wrote: > From: Prem Mallappa > > Implementation Notes: > > - SMMUv3 model, as per ARM SMMUv3 11.0 spec I haven't reviewed any of this yet, but 11.0 is not the current revision of the SMMUv3 spec, so you should

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Igor Mammedov
On Tue, 16 Feb 2016 16:48:34 +1100 David Gibson wrote: > On Mon, Feb 15, 2016 at 08:43:41PM +0100, Markus Armbruster wrote: > > Igor Mammedov writes: > > > > > it will allow mgmt to query present and possible to hotplug CPUs > > > it is

Re: [Qemu-devel] [PATCH] usb: ohci avoid multiple eof timers

2016-02-16 Thread Laurent Vivier
On 16/02/2016 11:04, P J P wrote: > From: Prasad J Pandit > > When transitioning an OHCI controller to the OHCI_USB_OPERATIONAL > state, it creates an eof timer object in 'ohci_bus_start'. > It does not check if one already exists. This results in memory > leakage and

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-16 Thread Igor Mammedov
On Tue, 16 Feb 2016 02:35:41 +0800 Xiao Guangrong wrote: > On 02/16/2016 01:24 AM, Igor Mammedov wrote: > > On Mon, 15 Feb 2016 23:53:13 +0800 > > Xiao Guangrong wrote: > > > >> On 02/15/2016 09:32 PM, Igor Mammedov wrote: >

[Qemu-devel] [PATCH v3 02/16] hw/timer: QOM'ify arm_timer (pass 2)

2016-02-16 Thread xiaoqiang zhao
assign DeviceClass::vmsd instead of using vmstate_register function Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/arm_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/arm_timer.c

Re: [Qemu-devel] [PATCH] pseries: Include missing pseries-2.5 compat properties in pseries-2.4

2016-02-16 Thread Laurent Vivier
On 16/02/2016 03:20, David Gibson wrote: > Commit 4b23699 "pseries: Add pseries-2.6 machine type" added a new > SPAPR_COMPAT_2_5 macro in the usual way. However, it didn't add this > macro to the existing SPAPR_COMPAT_2_4 macro so that pseries-2.4 > inherits newer compatibility properties which

[Qemu-devel] [PATCH v3 11/16] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/milkymist-sysctl.c | 21

[Qemu-devel] [PATCH v3 01/16] hw/timer: QOM'ify arm_timer (pass 1)

2016-02-16 Thread xiaoqiang zhao
* assign icp_pit_init to icp_pit_info.instance_init * split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao

[Qemu-devel] [PATCH v3 04/16] hw/timer: QOM'ify exynos4210_mct

2016-02-16 Thread xiaoqiang zhao
assign exynos4210_mct_init to exynos4210_mct_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/exynos4210_mct.c | 12 +--- 1 file changed, 5 insertions(+), 7

[Qemu-devel] [PATCH v3 07/16] hw/timer: QOM'ify grlib_gptimer

2016-02-16 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/grlib_gptimer.c | 30

[Qemu-devel] [PATCH v3 03/16] hw/timer: QOM'ify etraxfs_timer

2016-02-16 Thread xiaoqiang zhao
assign etraxfs_timer_init to etraxfs_timer_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/etraxfs_timer.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[Qemu-devel] [PATCH v3 05/16] hw/timer: QOM'ify exynos4210_pwm

2016-02-16 Thread xiaoqiang zhao
assign exynos4210_pwm_init to exynos4210_pwm_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/exynos4210_pwm.c | 12 +--- 1 file changed, 5 insertions(+), 7

[Qemu-devel] [PATCH v3 12/16] hw/timer: QOM'ify pl031

2016-02-16 Thread xiaoqiang zhao
assign pl031_init to pl031_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/pl031.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v3 00/16] QOM'ify hw/timer/*

2016-02-16 Thread xiaoqiang zhao
This patch series QOM'ify timer code under hw/timer directory. Main idea is to split the initfn's work, some to TypeInfo.instance_init and some is placed in DeviceClass::realize. Drop the use of SysBusDeviceClass::init if possible. changes in v3: * remove unnecessary OBJECT cast * refine some

[Qemu-devel] [PATCH v3 08/16] hw/timer: QOM'ify lm32_timer

2016-02-16 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/lm32_timer.c | 19

[Qemu-devel] [PATCH v3 13/16] hw/timer: QOM'ify puv3_ost

2016-02-16 Thread xiaoqiang zhao
assign puv3_ost_init to puv3_ost_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/puv3_ost.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH v3 14/16] hw/timer: QOM'ify pxa2xx_timer

2016-02-16 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/pxa2xx_timer.c | 36

[Qemu-devel] [PATCH v3 15/16] hw/timer: QOM'ify slavio_timer

2016-02-16 Thread xiaoqiang zhao
rename slavio_timer_init1 to slavio_timer_init and assign it to slavio_timer_info.instance_init, then we drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/slavio_timer.c | 12 +--- 1 file

[Qemu-devel] [PATCH v3 09/16] hw/timer: QOM'ify m48txx_sysbus (pass 1)

2016-02-16 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 35

[Qemu-devel] [PATCH v3 10/16] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-16 Thread xiaoqiang zhao
assign DeviceClass::vmsd instead of using vmstate_register function Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/m48t59.c

[Qemu-devel] [PATCH v3 06/16] hw/timer: QOM'ify exynos4210_rtc

2016-02-16 Thread xiaoqiang zhao
assign exynos4210_rtc_init to exynos4210_rtc_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/exynos4210_rtc.c | 12 +--- 1 file changed, 5 insertions(+), 7

[Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-16 Thread xiaoqiang zhao
assign tusb6010_init to tusb6010_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/tusb6010.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-16 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 16.02.2016 um 07:25 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 15.02.2016 um 15:24 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > Here is the current

Re: [Qemu-devel] [PATCH v3 03/16] hw/timer: QOM'ify etraxfs_timer

2016-02-16 Thread Edgar E. Iglesias
On Tue, Feb 16, 2016 at 07:09:35PM +0800, xiaoqiang zhao wrote: > assign etraxfs_timer_init to etraxfs_timer_info.instance_init > and drop the SysBusDeviceClass::init > > Reviewed-by: Peter Maydell Reviewed-by: Edgar E. Iglesias >

Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-02-16 Thread Thomas Huth
On 14.02.2016 18:47, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch adds the functions needed to handle IPv6 packets. ICMPv6 and > NDP headers are implemented. > > Slirp is now able to send NDP Router or Neighbor Advertisement when it > receives Router or

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

2016-02-16 Thread Peter Maydell
On 15 February 2016 at 20:35, Peter Maydell wrote: > We should give it a try with Eric's "stop overriding > 'inline' to mean 'always inline', but as you say > with only one caller it's probably going to go ahead > and inline it anyway. ...and indeed Eric's patch has no

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

2016-02-16 Thread Peter Maydell
On 15 February 2016 at 20:57, Richard Henderson wrote: > On 02/16/2016 07:35 AM, Peter Maydell wrote: >> On 15 February 2016 at 20:29, Richard Henderson wrote: >>> I couldn't reproduce this quickly with a freshly built gcc 4.8 branch on >>> i686-linux. Could

[Qemu-devel] [PATCH v1 1/1] etraxfs_dma: Dont forward zero-length payload to clients

2016-02-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/dma/etraxfs_dma.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index 9cbb165..d5650eb 100644

Re: [Qemu-devel] KVM call for agenda for 2016-02-16

2016-02-16 Thread Christian Borntraeger
So my quick and dirty summary of CPU as _I_ understand it (and I only have some part time bandwidth at the moment for that) x86 has cpu hotplug. Some history qemu-kvm had cpu_set in the past qemu has cpu_add for a while now libvirt code uses cpu_add cross-platform out of the box proposal to use

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Andrea Bolognani
On Tue, 2016-02-16 at 10:15 +, Daniel P. Berrange wrote: > > Back to GIV.  Recognized values of gic-version are fixed at compile > > time: 2, 3, host.  Once again, QOM does things in code rather than data: > > the set of values is defined in the setter function > > virt_set_gic_version(). > > 

Re: [Qemu-devel] [PATCH] slirp: Add IPv6 support to the TFTP code

2016-02-16 Thread Thomas Huth
On 16.02.2016 11:30, Samuel Thibault wrote: > Hello, > > Thanks for working on it :) > > Thomas Huth, on Tue 16 Feb 2016 09:47:38 +0100, wrote: >> -static int tftp_session_allocate(Slirp *slirp, struct tftp_t *tp) >> +static int tftp_session_allocate(struct sockaddr_storage *srcsas, Slirp >>

Re: [Qemu-devel] [RFC PATCH v3 3/3] fw/pci: Allocate IGD stolen memory

2016-02-16 Thread Gerd Hoffmann
Hi, > I don't mind the allocation of guest memory issue, the fact that guest > memory is consumed by built-in devices is exactly what happens on bare > metal. And following in qemu what happens on bare metal usually works best long-term. > to pre-populate it, we could. It at least puts QEMU

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Peter Maydell
On 16 February 2016 at 12:05, Andrea Bolognani wrote: > The idea is to add this information to domain capabilities, which > already have virtualization type, architecture and machine type as > inputs. > > Since GIC is only available for the virt machine type on ARM hosts, >

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Daniel P. Berrange
On Tue, Feb 16, 2016 at 01:05:45PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-16 at 10:15 +, Daniel P. Berrange wrote: > > > Back to GIV.  Recognized values of gic-version are fixed at compile > > > time: 2, 3, host.  Once again, QOM does things in code rather than data: > > > the set of

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-16 Thread Igor Mammedov
On Tue, 16 Feb 2016 12:05:33 +0200 Marcel Apfelbaum wrote: > On 02/11/2016 06:30 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 11, 2016 at 04:16:05PM +0100, Igor Mammedov wrote: > >> On Tue, 9 Feb 2016 14:17:44 +0200 > >> "Michael S. Tsirkin" wrote: > >>

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Andrea Bolognani
On Tue, 2016-02-16 at 12:09 +, Peter Maydell wrote: > On 16 February 2016 at 12:05, Andrea Bolognani wrote: > > The idea is to add this information to domain capabilities, which > > already have virtualization type, architecture and machine type as > > inputs. > >  > >

Re: [Qemu-devel] [PATCHv7 2/9] slirp: Adding ICMPv6 error sending

2016-02-16 Thread Thomas Huth
On 14.02.2016 18:47, Samuel Thibault wrote: > From: Yann Bordenave > > Disambiguation : icmp_error is renamed into icmp_send_error, since it > doesn't manage errors, but only sends ICMP Error messages. > > Adding icmp6_send_error to send ICMPv6 Error messages. This function

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Andrea Bolognani
On Tue, 2016-02-16 at 12:15 +, Daniel P. Berrange wrote: > On Tue, Feb 16, 2016 at 01:05:45PM +0100, Andrea Bolognani wrote: > > On Tue, 2016-02-16 at 10:15 +, Daniel P. Berrange wrote: > > > > Back to GIV.  Recognized values of gic-version are fixed at compile > > > > time: 2, 3, host.  

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-16 Thread Thomas Huth
On 14.02.2016 18:47, Samuel Thibault wrote: > From: Guillaume Subiron > > This adds the sin6 case in the fhost and lhost unions and related macros. > It adds udp6_input() and udp6_output(). > It adds the IPv6 case in sorecvfrom(). > Finally, udp_input() is called by

Re: [Qemu-devel] [PATCH v7 03/11] dump-guest-memory: using static DumpState, add DumpStatus

2016-02-16 Thread Andrew Jones
On Tue, Feb 16, 2016 at 03:50:53PM +0800, Peter Xu wrote: > Instead of malloc/free each time for DumpState, make it > static. Added DumpStatus to show status for dump. I see that the motivation for making DumpState static is for dump_in_progress(). DumpState isn't massive, but it isn't tiny

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Markus Armbruster
Igor Mammedov writes: > On Mon, 15 Feb 2016 20:43:41 +0100 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > it will allow mgmt to query present and possible to hotplug CPUs >> > it is required from a target platform

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-16 Thread Marcel Apfelbaum
On 02/16/2016 02:17 PM, Igor Mammedov wrote: On Tue, 16 Feb 2016 12:05:33 +0200 Marcel Apfelbaum wrote: On 02/11/2016 06:30 PM, Michael S. Tsirkin wrote: On Thu, Feb 11, 2016 at 04:16:05PM +0100, Igor Mammedov wrote: On Tue, 9 Feb 2016 14:17:44 +0200 "Michael S. Tsirkin"

Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Daniel P. Berrange
On Tue, Feb 16, 2016 at 01:27:55PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-16 at 12:15 +, Daniel P. Berrange wrote: > > On Tue, Feb 16, 2016 at 01:05:45PM +0100, Andrea Bolognani wrote: > > > On Tue, 2016-02-16 at 10:15 +, Daniel P. Berrange wrote: > > > > > Back to GIV.  

Re: [Qemu-devel] [PATCH v7 08/11] DumpState: adding total_size and written_size fields

2016-02-16 Thread Andrew Jones
On Tue, Feb 16, 2016 at 03:50:58PM +0800, Peter Xu wrote: > Here, total_size is the size in bytes to be dumped (raw data, which > means before compression), while written_size are bytes handled (raw > size too). > > Signed-off-by: Peter Xu > Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH v2 00/15] tests: Introducing docker tests

2016-02-16 Thread Fam Zheng
v2: - Fix a few coding style warnings of shellcheck and pylint. [Marc-André Lureau] - Rename make targets: docker-run => docker-test docker-build => docker-image docker-run-$TEST.sh@$IMAGE => docker-$TEST@$IMAGE - In help, document the magic makefile vars which are

[Qemu-devel] [PATCH v2 02/15] Makefile: Rules for docker testing

2016-02-16 Thread Fam Zheng
This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown by "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make,

[Qemu-devel] [PATCH v2 05/15] docker: Add common.rc

2016-02-16 Thread Fam Zheng
"requires" checks the "FEATURE" environment for specified prerequisits, and skip the execution of test if not found. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 29 + 1 file changed, 29 insertions(+) create mode 100755

[Qemu-devel] [PATCH v2 04/15] docker: Add test runner

2016-02-16 Thread Fam Zheng
It's better to have a launcher for all tests, to make it easier to initialize and manage the environment. Signed-off-by: Fam Zheng --- tests/docker/run | 26 ++ 1 file changed, 26 insertions(+) create mode 100755 tests/docker/run diff --git

[Qemu-devel] [PATCH v2 01/15] tests: Add utilities for docker testing

2016-02-16 Thread Fam Zheng
docker_run: A wrapper for "docker run" (or "sudo -n docker run" if necessary), which takes care of killing and removing the running container at SIGINT. docker_clean: A tool to tear down all the containers including inactive ones that are started by docker_run. docker_build: A tool to compare an

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Andreas Färber
Am 16.02.2016 um 13:35 schrieb Markus Armbruster: > Igor Mammedov writes: > >> On Mon, 15 Feb 2016 20:43:41 +0100 >> Markus Armbruster wrote: >> >>> Igor Mammedov writes: >>> it will allow mgmt to query present and possible to

[Qemu-devel] [PATCH v2 09/15] docker: Add mingw test

2016-02-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-mingw | 36 1 file changed, 36 insertions(+) create mode 100755 tests/docker/test-mingw diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw new file mode 100755 index

[Qemu-devel] [PATCH v2 03/15] docker: Add images

2016-02-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 5 + tests/docker/dockerfiles/fedora.docker | 7 +++ tests/docker/dockerfiles/ubuntu.docker | 9 + 3 files changed, 21 insertions(+) create mode 100644

[Qemu-devel] [PATCH v2 10/15] docker: Add travis tool

2016-02-16 Thread Fam Zheng
The script is not named test-travis.sh so it won't run with "make docker-run", because it can take too long. Run it with "make docker-run-travis.sh@ubuntu". Signed-off-by: Fam Zheng --- tests/docker/travis| 23 +++ tests/docker/travis.py | 48

[Qemu-devel] [PATCH v2 06/15] docker: Add quick test

2016-02-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-quick | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 tests/docker/test-quick diff --git a/tests/docker/test-quick b/tests/docker/test-quick new file mode 100755 index 000..ce3cc99 ---

  1   2   3   4   >