[Qemu-devel] [PATCH v7 4/6] s390x/cpu: Add CPU property links

2016-03-01 Thread Matthew Rosato
Link each CPUState as property machine/cpu[n] during initialization. Add a hotplug handler to s390-virtio-ccw machine and set the state during plug. Additionally, maintain an array of state pointers indexed by CPU id for fast lookup during interrupt handling. Signed-off-by: Matthew Rosato

[Qemu-devel] [PATCH v7 3/6] s390x/cpu: Move some CPU initialization into realize

2016-03-01 Thread Matthew Rosato
In preparation for hotplug, defer some CPU initialization until the device is actually being realized. Signed-off-by: Matthew Rosato Reviewed-by: Andreas Färber --- target-s390x/cpu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH] MacKeys.h: initial commit

2016-03-01 Thread Programmingkid
This patch adds the file MacKeys.h. It is a file that contains all the constants for the Macintosh keyboard keycodes. Signed-off-by: John Arbuckle --- Note to Peter Maydell: I know you wanted me to use the constants from the file HIToolbox/Events.h, but I can't. It

[Qemu-devel] [PATCH v3 00/12] Add i.MX6 (Single/Dual/Quad) support

2016-03-01 Thread Jean-Christophe Dubois
This patch series adds support for the Freescale i.MX6 processor. For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 7 GPIO controllers * 6 SDHC controllers * 5 SPI controllers * 1 CCM device * 1 SRC

[Qemu-devel] [PATCH v3 02/12] i.MX: Rename CCM NOCLK to CLK_NONE for naming consistency.

2016-03-01 Thread Jean-Christophe Dubois
This way all CCM clock defines/enums are named CLK_XXX Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 Changes since V2: * None hw/misc/imx25_ccm.c | 2 +- hw/misc/imx31_ccm.c

[Qemu-devel] [PATCH v3 03/12] i.MX: Remove CCM useless clock computation handling.

2016-03-01 Thread Jean-Christophe Dubois
Most clocks supported by the CCM are useless to the qemu framework. Only clocks related to timers (EPIT, GPT, PWM, WATCHDOG, ...) are usefull to QEMU code. Therefore this patch removes clock computation handling for all clocks but: * CLK_NONE, * CLK_IPG, * CLK_32k Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller

2016-03-01 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Access SPI slave only at a byte level. * rework the CS activation to avoid to reset access to SPI slaves. Changes since v2: * Added #include "qemu/osdep.h" * remove previous_level from state struct * save

[Qemu-devel] [PATCH v3 09/12] FIFO: Add a FIFO32 implementation

2016-03-01 Thread Jean-Christophe Dubois
This one is build on top of the existing FIFO8 Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * None Changes since v2: * Added copyright * define Fifo32 as a struct containing Fifo8 * remove fifo32_pop_buf() include/qemu/fifo32.h | 186

[Qemu-devel] [PATCH v3 08/12] i.MX: Add missing descriptions in devices.

2016-03-01 Thread Jean-Christophe Dubois
Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on V1 Changes since v2: * None hw/arm/fsl-imx25.c | 1 + hw/arm/fsl-imx31.c | 1 + hw/i2c/imx_i2c.c | 1 + hw/net/imx_fec.c | 1 + 4

Re: [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support

2016-03-01 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 1 March 2016 10:44 AM > > On Mon, Feb 29, 2016 at 9:27 PM, Stefan Weil wrote: > > Am 18.01.2016 um 08:12 schrieb Peter Crosthwaite: > >> Hi All, > >> > >> This patch series adds system-mode

[Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Programmingkid
Add kp_equals and power keys support to the QKeyCode enum of keys. Signed-off-by: John Arbuckle --- qapi-schema.json |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8d04897..d63b17a 100644 ---

[Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Programmingkid
The pc_to_adb_keycode array was not very easy to work with. The replacement array number_to_adb_keycode list all the element indexes on the left and its value on the right. This makes finding a particular index or the meaning for that index very easy. Signed-off-by: John Arbuckle

Re: [Qemu-devel] [PATCH] MacKeys.h: initial commit

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 22:07, Programmingkid wrote: > This patch adds the file MacKeys.h. It is a file that contains all the > constants > for the Macintosh keyboard keycodes. > > Signed-off-by: John Arbuckle > > --- > Note to Peter Maydell: > I

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote: > On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote: >> Add kp_equals and power keys support to the QKeyCode enum of keys. > > Please update the documentation in the comment too, so we keep track of > which keys where added in which release.

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 19:45, Huaicheng Li wrote: > > * Is it safe to call `qemu_paio_submit` from one worker thread? Since > all request_access accesses are protected by lock, I think this is > OK. No, it's not possible. The "all" list in thread-pool.c is protected with the AioContext lock, not with

[Qemu-devel] [PATCH v7 0/6] Allow hotplug of s390 CPUs

2016-03-01 Thread Matthew Rosato
Changes from v6->v7: * Patch 1 - Cannot move cpu_model default setting to machine instance_init, as vl.c can overwrite it again with a NULL during startup. Left check in s390_init_cpus. * Drop cpu_last patch (Andreas) * Patch 4 - merged with patch that adds hotplug handler / set cpu

Re: [Qemu-devel] [V6 0/4] AMD IOMMU

2016-03-01 Thread Jan Kiszka
On 2016-03-01 21:39, Michael S. Tsirkin wrote: > On Tue, Mar 01, 2016 at 09:17:58PM +0100, Jan Kiszka wrote: >> On 2016-03-01 21:11, Michael S. Tsirkin wrote: >>> >>> What this seems to call for is a new kind of protection >>> where yes PTE is write protected, but instead of >>> making PTE

Re: [Qemu-devel] How to make changes to qapi-types.h

2016-03-01 Thread Programmingkid
On Feb 29, 2016, at 9:51 PM, Fam Zheng wrote: > On Mon, 02/29 21:38, Programmingkid wrote: >> >> On Feb 29, 2016, at 8:59 PM, Fam Zheng wrote: >> >>> On Mon, 02/29 20:26, Programmingkid wrote: I need to add a variable to the QKeyCode enum in the file qapi-types.h. This file is

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Gerd Hoffmann
On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote: > Add kp_equals and power keys support to the QKeyCode enum of keys. Please update the documentation in the comment too, so we keep track of which keys where added in which release. Otherwise it's fine. thanks, Gerd

[Qemu-devel] [PATCH v3 06/12] ARM: Factor out ARM on/off PSCI control functions

2016-03-01 Thread Jean-Christophe Dubois
Split ARM on/off function from PSCI support code. This will allow to reuse these functions in other code. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 Changes since V2: * Not present on V2 target-arm/Makefile.objs | 1 +

[Qemu-devel] [PATCH v3 07/12] i.MX: Add i.MX6 System Reset Controller device.

2016-03-01 Thread Jean-Christophe Dubois
This controller is also present in i.MX5X devices but they are not yet emulated by QEMU. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Change "reset" sematic to mean full power cyvle. Changes since V2: * use arm-powerctl API * Added #include

Re: [Qemu-devel] [QEMU] Windows XP / Windows 95 / MS-DOS 6 regressions

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 21:03, Hervé Poussineau wrote: > I also tested Windows 98. The first part setup correctly work, but > doesn't work just after the reboot (for the first boot). > The message is very similar to Windows 95. Indeed I stopped it after it got to the graphical part. I'll test again

[Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation

2016-03-01 Thread Matthew Rosato
Check for and propogate errors during s390 cpu creation. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 30 + hw/s390x/s390-virtio.c | 2 +- hw/s390x/s390-virtio.h | 1 + target-s390x/cpu-qom.h | 3 +++

[Qemu-devel] [PATCH v7 1/6] s390x/cpu: Cleanup init in preparation for hotplug

2016-03-01 Thread Matthew Rosato
Ensure a valid cpu_model is set upfront by setting the default value directly into the MachineState when none is specified. This is needed to ensure hotplugged CPUs share the same cpu_model. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand

[Qemu-devel] [PATCH v7 6/6] s390x/cpu: Allow hotplug of CPUs

2016-03-01 Thread Matthew Rosato
Implement cpu hotplug routine and add the machine hook. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 13 + target-s390x/cpu.c | 7 +++ 2 files changed, 20 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: Can't guest trigger this? If yes, don't put such code in production please: this will fill up disk on the host. Okay, the evil guest can read the IO port freely. I will use nvdimm_debug() instead. static void

Re: [Qemu-devel] [V6 1/4] hw/i386: Introduce AMD IOMMU

2016-03-01 Thread David Kiarie
On Wed, Mar 2, 2016 at 7:00 AM, David Kiarie wrote: > On Fri, Feb 26, 2016 at 9:23 AM, David Kiarie wrote: >> On Thu, Feb 25, 2016 at 6:43 PM, Marcel Apfelbaum wrote: >>> On 02/21/2016 08:10 PM, David Kiarie wrote: Add

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Gerd Hoffmann
> > Please update the documentation in the comment too, so we keep track of > > which keys where added in which release. > > > > Otherwise it's fine. > > > > thanks, > > Gerd > > > > Is this what you mean: > > # 'unmapped' and 'pause' since 2.0 > # 'ro' and 'kp_comma' since 2.4 > #

Re: [Qemu-devel] [patch qemu v2 0/4] rocker: prepare for easy addition of other worlds

2016-03-01 Thread Jason Wang
On 02/25/2016 10:31 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset does couple of small changes in order to prepare for smooth > addition of other worlds, like P4 and BPF. qemu user will be able to request > desired rocker world by "world=worldname" property. > >

Re: [Qemu-devel] [QEMU] Windows XP / Windows 95 / MS-DOS 6 regressions

2016-03-01 Thread Richard Henderson
On 03/01/2016 12:03 PM, Hervé Poussineau wrote: Windows 95 still doesn't work, even with your two patches applied. The message is: "A fatal exception 0E has occurred at 0137:FD512607. The current application will be terminated. * Press any key to terminate the current application. * Press

Re: [Qemu-devel] [PATCH V2 2/3] net/filter-redirector:Add filter-redirector

2016-03-01 Thread Jason Wang
On 02/29/2016 08:23 PM, Zhang Chen wrote: > Filter-redirector is a netfilter plugin. > It gives qemu the ability to redirect net packet. > redirector can redirect filter's net packet to outdev. > and redirect indev's packet to filter. > > filter >

Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-03-01 Thread Peter Xu
On Tue, Mar 01, 2016 at 03:20:59PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-23 at 18:52 +0800, Peter Xu wrote: > > +{ 'enum': 'GICType', 'data': [ 'gicv2', 'gicv3', 'gicv2-kvm', 'gicv3-kvm' > > ] } > > Wouldn't this conflate the use of accel= and kernel_irqchip= options? AFAIU, it's not

Re: [Qemu-devel] [V6 1/4] hw/i386: Introduce AMD IOMMU

2016-03-01 Thread David Kiarie
On Fri, Feb 26, 2016 at 9:23 AM, David Kiarie wrote: > On Thu, Feb 25, 2016 at 6:43 PM, Marcel Apfelbaum wrote: >> On 02/21/2016 08:10 PM, David Kiarie wrote: >>> >>> Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU >>> The IOMMU does basic

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 01:12 AM, Michael S. Tsirkin wrote: On Tue, Mar 01, 2016 at 06:56:10PM +0800, Xiao Guangrong wrote: Emulate dsm method after IO VM-exit Currently, we only introduce the framework and no function is actually supported Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Eric Blake
On 03/01/2016 06:20 PM, Programmingkid wrote: >> You weren't the original cause of the bug, so it is not necessarily this >> patch's job to fix the bug. Therefore, "pre-existing". But since the >> bug was observed during review of your patch, you may want to fix it >> anyways, probably as a

Re: [Qemu-devel] [PATCH v2 1/2] net: check packet payload length

2016-03-01 Thread Jason Wang
On 03/01/2016 02:48 PM, P J P wrote: > Hello Jason, > > +-- On Fri, 26 Feb 2016, Jason Wang wrote --+ > | Should we count mac header here? Did "plen + hlen >= length" imply "14 + > | hlen + csum_offset + 1" < length? > | > | Looks not. Consider a TCP packet can report evil plen (e.g 20) but

Re: [Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: > Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: >> I do think this patch is ready to be added to QEMU. I have listened to what >> you said and implemented your changes. >> >> https://patchwork.ozlabs.org/patch/579325/ >> >> Mac OS X can

Re: [Qemu-devel] [PATCH v3 0/2] Introduce 'status' property for netfilter

2016-03-01 Thread Jason Wang
On 03/01/2016 01:37 PM, zhanghailiang wrote: > This is picked from COLO series, which is to realize the new 'status' > property for filter. > > With this property, users can control if the filter is enabled or > disabled. > > ChangeLog: > v3: > - Use 'bool on' instead of member 'char *status'

Re: [Qemu-devel] [PATCH v4 0/9] NVDIMM ACPI: introduce the framework of QEMU emulated

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 12:36 AM, Michael S. Tsirkin wrote: On Tue, Mar 01, 2016 at 06:56:02PM +0800, Xiao Guangrong wrote: This patchset is against commit 2212ef27b342b98b220fe9 (fw-cfg: support writeable blobs) on pci branch of Michael's git tree and can be found at:

Re: [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support

2016-03-01 Thread Peter Crosthwaite
On Tue, Mar 1, 2016 at 1:34 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Tuesday, 1 March 2016 10:44 AM >> >> On Mon, Feb 29, 2016 at 9:27 PM, Stefan Weil wrote: >> > Am 18.01.2016 um 08:12

Re: [Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-03-01 Thread Jason Wang
On 02/29/2016 08:33 PM, Zhang Chen wrote: > > > On 02/29/2016 03:11 PM, Jason Wang wrote: >> >> On 02/24/2016 05:03 PM, Zhang Chen wrote: >>> If queue=rx, filter-redirector will get the packet that guest send, >>> then redirect >>> to outdev(if none, do nothing). but queue=rx/tx/all not related

Re: [Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add filter-traffic.h

2016-03-01 Thread Jason Wang
On 02/29/2016 08:23 PM, Zhang Chen wrote: > We can reuse filter-traffic by filter-mirror, > filter-redirector and so on. I think we could share more than this. E.g just use filter-mirror.c to implement both mirror and redirector. > > Signed-off-by: Zhang Chen >

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 12:00:42PM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 01:12 AM, Michael S. Tsirkin wrote: > >On Tue, Mar 01, 2016 at 06:56:10PM +0800, Xiao Guangrong wrote: > >>Emulate dsm method after IO VM-exit > >> > >>Currently, we only introduce the framework and no function

Re: [Qemu-devel] [PATCH v2 03/15] docker: Add images

2016-03-01 Thread Fam Zheng
On Tue, 03/01 09:52, Alex Bennée wrote: > > Fam Zheng writes: > > > On Mon, 02/29 17:18, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > Signed-off-by: Fam Zheng > >> > >> I think we need to include the dtc libs in here unless we

Re: [Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-03-01 Thread Fam Zheng
On Tue, 03/01 10:42, Paolo Bonzini wrote: > > > On 01/03/2016 07:18, Fam Zheng wrote: > > +/* Memory topology clips a memory region to 2^64, size.hi >= 0 means > > the > > + * section must cover any addr. */ > > Small improvement: > > /* Memory topology clips a memory region to

[Qemu-devel] Making Qemu/KVM more undetectable to malwares

2016-03-01 Thread Yang Luo
Hi list, I'm a phd student, majoring in System Security. I'm looking for a research idea about Qemu/KVM security. What do think are the most important security problems for Qemu/KVM needed to be addressed or studied? And how about this idea. I found out that lots of malware will detect the

Re: [Qemu-devel] [PATCH v2 15/15] tests/docker/Makefile.include: snapshot the src for docker

2016-03-01 Thread Fam Zheng
On Tue, 03/01 20:16, Alex Bennée wrote: > > Fam Zheng writes: > > > From: Alex Bennée > > > > Instead of providing a live version of the source tree to the docker > > container we snapshot it with git-archive. This ensure the tree is in a > > pristine

Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-03-01 Thread Peter Xu
On Tue, Mar 01, 2016 at 09:46:07AM -0700, Eric Blake wrote: > On 02/23/2016 03:52 AM, Peter Xu wrote: > > A new enum type is added to define ARM GIC types. > > > > Signed-off-by: Peter Xu > > --- > > qapi-schema.json | 17 + > > 1 file changed, 17

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 11:30:10AM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: > > > > >Can't guest trigger this? > >If yes, don't put such code in production please: > >this will fill up disk on the host. > > > > Okay, the evil guest can read the IO

[Qemu-devel] [PATCH 5/9] acpi: add build_append_named_dword, returning an offset in buffer

2016-03-01 Thread Xiao Guangrong
From: "Michael S. Tsirkin" This is a very limited form of support for runtime patching - similar in functionality to what we can do with ACPI_EXTRACT macros in python, but implemented in C. This is to allow ACPI code direct access to data tables - which is exactly what

[Qemu-devel] [PATCH 2/9] acpi: add aml_concatenate()

2016-03-01 Thread Xiao Guangrong
It will be used by nvdimm acpi Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 7 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 45b7f0a..bb0cf52 100644 ---

Re: [Qemu-devel] [PATCH 05/38] ivshmem-test: Improve test case /ivshmem/single

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Test state of registers after reset. > > Test reading Interrupt Status clears it. > > Test (invalid) read of Doorbell. > > Add more comments. > > Signed-off-by: Markus Armbruster Reviewed-by:

[Qemu-devel] [PATCH v3 1/5] replay: character devices

2016-03-01 Thread Pavel Dovgalyuk
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through

[Qemu-devel] [PATCH v3 5/5] replay: introduce block devices record/replay

2016-03-01 Thread Pavel Dovgalyuk
This patch introduces block driver that implement recording and replaying of block devices' operations. All block completion operations are added to the queue. Queue is flushed at checkpoints and information about processed requests is recorded to the log. In replay phase the queue is matched with

[Qemu-devel] [PULL 08/14] s390x/pci: fix reg/dereg irq functions

2016-03-01 Thread Cornelia Huck
From: Yi Min Zhao Indicator refcounting interfaces are introduced. This patch fixes introducing unneeded indicator mappings and failure to release AISB mappings on deregistration. Signed-off-by: Yi Min Zhao Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 07/14] s390x/css: introduce indicator refcounting interfaces

2016-03-01 Thread Cornelia Huck
From: Yi Min Zhao Currently, virtio-ccw uses its own interfaces to keep indicators mapped just once even if the same address has been registered multiple times. These interfaces fit the PCI use case as well. Therefore, move them to css and make them generic interfaces.

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Stefan Weil
Am 01.03.2016 um 10:59 schrieb Peter Maydell: > On 1 March 2016 at 05:07, Stefan Weil wrote: >> The rest of the code can use longjmp with stack unwinding. >> >> Signed-off-by: Stefan Weil >> --- >> >> This is a bug fix needed for 64 bit Windows. >> >> QEMU for

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 12:58, Daniel P. Berrange wrote: > > > means that QEMU will never close stderr anymore, so libvirt things > > > QEMU is still starting upforever. > > > > > > Given current libvirt behaviour / expectations, I think the only > > > option is to revert this change. > > > > Why

Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization

2016-03-01 Thread Christian Borntraeger
On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote: > On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote: >> we should call trace_init_backends() before trace_init_file() for >> CONFIG_TRACE_SIMPLE There is no difference for other cases. >> >> This problem was introduced by the commit >>

Re: [Qemu-devel] [PATCH 03/38] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD

2016-03-01 Thread Marc-André Lureau
Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Event notifiers are designed for eventfd(2). They can fall back to > pipes, but according to Paolo, event_notifier_init_fd() really > requires the real thing, and should therefore be under #ifdef > CONFIG_EVENTFD.

[Qemu-devel] [PATCH v3 4/5] block: add flush callback

2016-03-01 Thread Pavel Dovgalyuk
This patch adds callback for flush request. This callback is responsible for flushing whole block devices stack. bdrv_flush function does not proceed to underlying devices. It should be performed by this callback function, if needed. Signed-off-by: Pavel Dovgalyuk ---

Re: [Qemu-devel] [PATCH 07/38] ivshmem-test: Improve test cases /ivshmem/server-*

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Document missing test: behavior with MSI-X present but not enabled. > > For MSI-X, we test and clear the interrupt pending bit before testing > the interrupt. For INTx, we only clear. Change to test and clear for >

[Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D

2016-03-01 Thread Paolo Bonzini
Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized", 2016-02-22) wanted to move stderr of a daemonized QEMU to the file specified with -D. However, if -D was not passed, the patch had the side effect of not redirecting stderr to /dev/null. This happened because qemu_logfile was set

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 12:47, Daniel P. Berrange wrote: > means that QEMU will never close stderr anymore, so libvirt things > QEMU is still starting upforever. > > Given current libvirt behaviour / expectations, I think the only > option is to revert this change. Why not fix it instead? :) Paolo

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 12:15, Gerd Hoffmann wrote: > On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: >> In case of daemonize, use the logfile passed with the -D option in >> order to redirect stderr to it instead of /dev/null. >> >> Also remove some unused code in log.h. > > Patch breaks

[Qemu-devel] [PULL 01/14] linux-headers: update against kvm/next

2016-03-01 Thread Cornelia Huck
Update against commit efef127c, but keep userfaultd.h. Signed-off-by: Cornelia Huck --- linux-headers/asm-arm/unistd.h | 2 ++ linux-headers/asm-powerpc/unistd.h | 13 + linux-headers/asm-s390/kvm.h | 11 +--

Re: [Qemu-devel] [PATCH 09/38] ivshmem: Add missing newlines to debug printfs

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Reviewed-by: Marc-André Lureau > hw/misc/ivshmem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [Qemu-devel] [PULL 00/12] Block patches

2016-03-01 Thread Peter Maydell
On 29 February 2016 at 20:08, Jeff Cody wrote: > The following changes since commit 071608b519adf62bc29c914343a21c5407ab1ac9: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160229-1' into > staging (2016-02-29 12:24:26 +) > > are available in the git

[Qemu-devel] [PATCH 3/9] acpi: allow using object as offset for OperationRegion

2016-03-01 Thread Xiao Guangrong
Extend aml_operation_region() to use object as offset Reviewed-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 4 ++-- hw/i386/acpi-build.c| 31 ---

[Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
Emulate dsm method after IO VM-exit Currently, we only introduce the framework and no function is actually supported Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 2 +- hw/acpi/nvdimm.c| 44

[Qemu-devel] [PATCH] balloon: fix segfault and harden the stats queue

2016-03-01 Thread Ladi Prosek
The segfault here is triggered by the driver notifying the stats queue twice after adding a buffer to it. This effectively resets stats_vq_elem back to NULL and QEMU crashes on the next stats timer tick in balloon_stats_poll_cb. This is a regression introduced in 51b19ebe4320f3dc, although

Re: [Qemu-devel] [PULL 0/2] vga: minor cirrus/qxl bugfixes.

2016-03-01 Thread Peter Maydell
mote-tracking branch 'remotes/kraxel/tags/pull-usb-20160229-1' into > staging (2016-02-29 12:24:26 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-vga-20160301-1 > > for you to fetch changes up to 05fa1c742fd6f66978

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

2016-03-01 Thread Gerd Hoffmann
On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: > In case of daemonize, use the logfile passed with the -D option in > order to redirect stderr to it instead of /dev/null. > > Also remove some unused code in log.h. Patch breaks interaction with libvirt. libvirt hangs on startup,

Re: [Qemu-devel] [PATCH 08/38] ivshmem: Rewrite specification document

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > This started as an attempt to update ivshmem_device_spec.txt for > clarity, accuracy and completeness while working on its code, and > quickly became a full rewrite. Since the diff would be useless > anyway, I'm using

Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR 2 (shared memory)

2016-03-01 Thread Paolo Bonzini
On 29/02/2016 19:40, Markus Armbruster wrote: > ivshmem_realize() puts the shared memory region in a container region. > Used to be necessary to permit delayed mapping of the shared memory. > Now we don't do that anymore, the container is redundant. Drop it. Can you explain why we don't do

[Qemu-devel] [PULL 06/14] s390x/virtio: old machine leftovers

2016-03-01 Thread Cornelia Huck
Remove some now unused #defines. Reviewed-By: Sascha Silbe Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/s390x/s390-virtio.c

[Qemu-devel] [PULL 09/14] s390x/css: Allocate channel_subsys statically

2016-03-01 Thread Cornelia Huck
From: Eduardo Habkost There's no need to use g_malloc0() to allocate the channel_subsys struct, just use a static variable. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc: Alexander

Re: [Qemu-devel] [PATCH 01/38] exec: Fix memory allocation when memory path names new file

2016-03-01 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/02/2016 19:40, Markus Armbruster wrote: >> -if (!stat(path, ) && S_ISDIR(st.st_mode)) { >> +ret = stat(path, ); >> +if (!ret && S_ISDIR(st.st_mode)) { >> +/* path names a directory -> create a temporary file there */ >>

Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D

2016-03-01 Thread Cornelia Huck
On Tue, 1 Mar 2016 12:50:53 +0100 Paolo Bonzini wrote: > Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized", > 2016-02-22) wanted to move stderr of a daemonized QEMU to the file > specified with -D. > > However, if -D was not passed, the patch had the side

Re: [Qemu-devel] [PATCH 04/38] tests/libqos/pci-pc: Fix qpci_pc_iomap() to map BARs aligned

2016-03-01 Thread Markus Armbruster
Marc-André Lureau writes: > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> qpci_pc_iomap() maps BARs one after the other, without padding. This >> is wrong. PCI Local Bus Specification Revision 3.0, 6.2.5.1. Address >> Maps: "all

Re: [Qemu-devel] [PATCH 10/38] ivshmem: Compile debug prints unconditionally to prevent bit-rot

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Reviewed-by: Marc-André Lureau (apparently, there are other places in qemu where this conversion could be done) >

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 11:54, Stefan Weil wrote: > Am 01.03.2016 um 10:59 schrieb Peter Maydell: >> I don't understand this patch. Why doesn't it work to have >> sigsetjmp() be implemented the same way for every use that >> QEMU makes of it? > It does, as long as the "same way" is

Re: [Qemu-devel] [PATCH 02/38] qemu-doc: Fix ivshmem huge page example

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Option parameter "share" is missing. Without it, you get a *private* > mmap(), which defeats ivshmem's purpose pretty thoroughly ;) > > While there, switch to the conventional mountpoint of hugetlbfs > /dev/hugepages.

[Qemu-devel] [PATCH 9/9] nvdimm acpi: add _CRS

2016-03-01 Thread Xiao Guangrong
As Igor suggested that we can report the BIOS patched operation region so that OSPM could see that particular range is in use and be able to notice conflicts if it happens some day Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 27

[Qemu-devel] [PATCH 6/9] nvdimm acpi: introduce patched dsm memory

2016-03-01 Thread Xiao Guangrong
The dsm memory is used to save the input parameters and store the dsm result which is filled by QEMU. The address of dsm memory is decided by bios and patched into int32 object named "MEMA" Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 20

[Qemu-devel] [PATCH 7/9] nvdimm acpi: let qemu handle _DSM method

2016-03-01 Thread Xiao Guangrong
If dsm memory is successfully patched, we let qemu fully emulate the dsm method This patch saves _DSM input parameters into dsm memory, tell dsm memory address to QEMU, then fetch the result from the dsm memory Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c

Re: [Qemu-devel] [PATCH 1/2] hw/mips: add initial Cluster Power Controller support

2016-03-01 Thread Leon Alrae
On 26/02/16 16:49, Peter Maydell wrote: > On 26 February 2016 at 16:19, Leon Alrae wrote: >> Cluster Power Controller (CPC) is responsible for power management in >> multiprocessing system. It provides registers to control the power and the >> clock frequency of the

[Qemu-devel] [PATCH v3 3/5] replay: introduce new checkpoint for icount warp

2016-03-01 Thread Pavel Dovgalyuk
qemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode. Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include

Re: [Qemu-devel] [PATCH 06/38] ivshmem-test: Clean up wait for devices to become operational

2016-03-01 Thread Marc-André Lureau
On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > test_ivshmem_server() waits until the first byte in BAR 2 contains the > 0x42 we put into shared memory. Works because the byte reads zero > until the device maps the shared memory gotten from the server. > > Check

Re: [Qemu-devel] [PATCH v9 0/7] trace: Show vCPU info in guest code events

2016-03-01 Thread Lluís Vilanova
Lluís Vilanova writes: > NOTE: This series should complete the framework for guest code tracing. From > here on, other series can concurrently add actual events and improve the > guest code tracing features and performance (e.g., control tracing > independently on each vCPU). >

Re: [Qemu-devel] [PATCH 29/38] ivshmem: Implement shm=... with a memory backend

2016-03-01 Thread Paolo Bonzini
On 29/02/2016 19:40, Markus Armbruster wrote: > ivshmem has its very own code to create and map shared memory. > Replace that with an implicitly created memory backend. Reduces the > number of ways we create BAR 2 from three to two. > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [Qemu-discuss] golang on linux-user

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 09:38, Hunter Laux wrote: > I was having trouble running golang on linux-user with an aarch64 target. > > It turns out that snappy is written in Go. When I tried the xenial aarch64 > preinstall image in qemu, Snappy was broken. > > For some reason, it

[Qemu-devel] [PATCH] log: use strtok_r

2016-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/sysemu/os-win32.h | 1 + util/log.c| 30 -- util/oslib-win32.c| 35 +++ 3 files changed, 44 insertions(+), 22 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

2016-03-01 Thread Daniel P. Berrange
On Tue, Mar 01, 2016 at 12:15:21PM +0100, Gerd Hoffmann wrote: > On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: > > In case of daemonize, use the logfile passed with the -D option in > > order to redirect stderr to it instead of /dev/null. > > > > Also remove some unused code in

[Qemu-devel] [PULL 11/14] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-03-01 Thread Cornelia Huck
From: Wei Yang Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang CC: Cornelia Huck

[Qemu-devel] [PULL 00/14] s390x patches

2016-03-01 Thread Cornelia Huck
The following changes since commit 9c74a853048f14fd9a3e2efa1e3a6935d00e7495: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2016-03-01 09:54:53 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20160301 for you

[Qemu-devel] [PULL 05/14] watchdog/diag288: avoid race condition on expired watchdog

2016-03-01 Thread Cornelia Huck
From: Sascha Silbe When configured to inject an NMI, watchdog_perform_action() may cause the BQL to be temporarily relinquished (inject_nmi() → ... → s390_nmi() → s390_cpu_restart() → run_on_cpu()). When the guest issues diag 288 again in response to the NMI, the diag

[Qemu-devel] [PULL 13/14] MAINTAINERS: Remove entry for hw/s390x/s390-virtio-bus.[ch]

2016-03-01 Thread Cornelia Huck
From: Thomas Huth The files have been deleted recently, no need to keep these entries anymore. Signed-off-by: Thomas Huth Message-Id: <1456397100-22746-1-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck ---

Re: [Qemu-devel] [PATCH 03/38] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD

2016-03-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> Event notifiers are designed for eventfd(2). They can fall back to >> pipes, but according to Paolo, event_notifier_init_fd() really >> requires the

[Qemu-devel] [PULL 10/14] s390x/css: Use static initialization for channel_subsys fields

2016-03-01 Thread Cornelia Huck
From: Eduardo Habkost machine_init() will be gone, but we don't need it if we just initialize the channel_subsys fields statically. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc:

<    1   2   3   4   >