This patch set fixes bugs in the IDE DMA and the IDE ATAPI on operations to
save/restore the state.
>From the user point of view this results in IDE timeouts in the guest
when the user reads from the DVD like the following:
[424332.169229] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action
From: Pavel Butsykin
Restart of ATAPI DMA used to be unreachable, because the request to do
so wasn't indicated in bus->error_status due to the lack of spare bits, and
ide_restart_bh() would return early doing nothing.
This patch makes use of the observation that not
From: Pavel Butsykin
If the migration occurs after the IDE DMA has been set up but before it
has been initiated, the state gets lost upon save/restore. Specifically,
->dma_cb callback gets cleared, so, when the guest eventually starts bus
mastering, the DMA never
On Fri, Apr 01, 2016 at 12:49:47PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 01:32:51PM +0200, Gerd Hoffmann wrote:
> > > I think we were working on the same thing ... Attached is my
> > > version.
> > >
> > > Note that you must enable at least CONFIG_MPTABLE else virtio-scsi
>
Indeed building the kilo package from source gives me the same hang. So
something else (seabios maybe)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1563887
Title:
qemu-system-ppc64 freezes on
On 01/04/2016 16:50, Max Reitz wrote:
> Signed-off-by: Max Reitz
Du hast zu viel freie Zeit.
Paolo
ps: given the latest news about AI, I hope Google Translate is not
insulting any family member of yours, or worse.
pps: the LibreOffice is looking for people translating
From: Pavel Butsykin
ide_atapi_dma_restart() used to just complete the DMA with an error,
under the assumption that there isn't enough information to restart it.
However, as the contents of the ->io_buffer is preserved, it looks safe to
just re-evaluate it and dispatch
On 01.04.2016 11:56, Fam Zheng wrote:
> Do the same as other scripts, to pick the correct interpreter between
> python2 and python3 from the environment.
>
> Signed-off-by: Fam Zheng
> ---
> tests/qemu-iotests/149 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
The following changes since commit de1d099a448beb2ec39af4bd9ce4dd6452a18cb5:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault-2' into
staging (2016-04-01 11:15:20 +0100)
are available in the git repository at:
http://people.debian.org/~sthibault/qemu.git
Using the nested aio_poll() in coroutine is a bad idea. This patch
replaces the aio_poll loop in bdrv_drain with a BH, if called in
coroutine.
For example, the bdrv_drain() in mirror.c can hang when a guest issued
request is pending on it in qemu_co_mutex_lock().
Mirror coroutine in this case
On Fri, 1 Apr 2016 15:19:45 +0200
Paolo Bonzini wrote:
> This version fixes some commit messages, is based on qemu.git master
> and adds Cornelia's Reviewed-by tags. There are no code changes apart
> from context.
>
> Michael S. Tsirkin (2):
> virtio: add aio handler
>
On Fri, 1 Apr 2016 16:14:22 +0200
Christian Borntraeger wrote:
> On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> > Reentrancy cannot happen while the BQL is being held.
> >
> > Reviewed-by: Cornelia Huck
> > Signed-off-by: Paolo Bonzini
On Fri, Apr 01, 2016 at 01:07:55PM +0200, Gerd Hoffmann wrote:
> On Fr, 2016-04-01 at 11:17 +0100, Richard W.M. Jones wrote:
> > On Fri, Apr 01, 2016 at 11:18:30AM +0200, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > I wonder how we can make use of this in qemu and downstream distros?
> > > >
On 04/01/2016 09:00 AM, Alex Bligh wrote:
>>
>> Or rather than a flag bit, what about this strawman:
>>
>> NBD_FLAG_SEND_FUA: If set, the server understands the NBD_CMD_FLAG_FUA
>> bit. Except where more specific mandatory or optional behavior is
>> documented on a given request, the server MUST
On 31.03.2016 11:49, Stefan Hajnoczi wrote:
> On Thu, Mar 24, 2016 at 08:07:17PM +0100, Max Reitz wrote:
>> As I responded to:
>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html
>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.html
>>
>> I think a
On 04/01/2016 09:13 AM, Alex Bligh wrote:
>
> On 1 Apr 2016, at 16:12, Alex Bligh wrote:
>
>> as qemu doesn't use FUA on write and the kernel doesn't use FUA
>
> "as qemu doesn't use FUA other than on write" - sorry
qemu's block/nbd-client.c currently sends NBD_CMD_FLAG_FUA
Alex Bennée writes:
> To be safely portable no atomic access should be trying to do more than
> the natural word width of the host. The most common abuse is trying to
> atomically access 64 bit values on a 32 bit host.
>
> This patch adds some QEMU_BUILD_BUG_ON to the
Now with enable-debug and better call traces
(gdb)
(gdb) thread apply all bt
Thread 5 (Thread 0x3ffa0e7f910 (LWP 29839)):
#0 0x03ffa530334a in ioctl () at /lib64/libc.so.6
#1 0x80081c84 in kvm_vcpu_ioctl (cpu=0x80e8c170, type=44672) at
/home/cborntra/REPOS/qemu/kvm-all.c:1984
#2
On Fri, 1 Apr 2016 15:19:51 +0200
Paolo Bonzini wrote:
> From: "Michael S. Tsirkin"
>
> In addition to handling IO in vcpu thread and in io thread, dataplane
> introduces yet another mode: handling it by aio.
>
> This reuses the same handler as previous
On Fri, 1 Apr 2016 15:19:50 +0200
Paolo Bonzini wrote:
> From: "Michael S. Tsirkin"
>
> In addition to handling IO in vcpu thread and
> in io thread, blk dataplane introduces yet another mode:
> handling it by aio.
>
> This reuses the same handler as
Hi Alex,
On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote:
> The __atomic primitives have been available since GCC 4.7 and provide
> a richer interface for describing memory ordering requirements. As a
> bonus by using the primitives instead of hand-rolled functions we can
> use tools
On Fri, Apr 01, 2016 at 10:18:02AM +0200, Paolo Bonzini wrote:
> Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever
> we want in the Hyper-V vendor signature, let's show some love too!
>
> Cc: Andreas Färber
> Cc: Alex Williamson
On Wed, 30 Mar 2016, Juergen Gross wrote:
> Add a Xenstore directory for each supported pv backend. This will allow
> Xen tools to decide which backend type to use in case there are
> multiple possibilities.
>
> The information is added under
> /local/domain//device-model//backends
> before the
On Fri, Apr 01, Peter Maydell wrote:
> On 1 April 2016 at 13:00, Olaf Hering wrote:
> > Building on powerpc-linux fails with undefined reference to __atomic_load_8
> > in
> > icount_warp_rt(). Force linking to -latomic.
>
> We should instead be fixing this by not doing atomic
Quoting Paolo Bonzini (2016-04-01 03:18:02)
> Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever
> we want in the Hyper-V vendor signature, let's show some love too!
This might actually fix GPU passthrough for Nvidia cards when Hyper-V is
enabled.
Cc'ing
On 1 April 2016 at 15:30, James Hogan wrote:
> Hi Alex,
>
> On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote:
>> The __atomic primitives have been available since GCC 4.7 and provide
>> a richer interface for describing memory ordering requirements. As a
>>
On Fri, Apr 01, 2016 at 10:58:19AM -0400, Kevin O'Connor wrote:
> On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote:
> > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote:
> > > On 01/04/2016 10:14, Richard W.M. Jones wrote:
> > > > Found it: only CONFIG_MPTABLE=y was
On 1 Apr 2016, at 16:12, Alex Bligh wrote:
> as qemu doesn't use FUA on write and the kernel doesn't use FUA
"as qemu doesn't use FUA other than on write" - sorry
> at all; I realise that is not an exhaustive list.
--
Alex Bligh
signature.asc
Description: Message
On 31.03.2016 13:42, Alberto Garcia wrote:
> On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote:
>>> I also have another (not directly related) question: why not simply
>>> use the node name when removing children? I understood that the idea
>>> was that it's possible to have the same node
On 1 Apr 2016, at 16:31, Eric Blake wrote:
> When qemu client is talking to a qemu server, there is no
> incompatibility between the two - all client commands that set FUA are
> sanely handled by the recipient server code. But the same is not true
> if you pair a current
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> > Hi,
> > I'm seeing a breakage on q35 migration on head (and possibly older
> > but certainly head; it's also on a 2.5.0 world I've got with a bunch
> > of patches but I've not tried
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and
IPv6-only network environments.
Signed-off-by: Samuel Thibault
Reviewed-by: Thomas Huth
---
net/slirp.c | 36 ++--
qapi-schema.json | 8
On 04/01/2016 02:27 AM, Wouter Verhelst wrote:
> That's what I'm mostly worried about. Yes, we have FUA, and yes, some
> clients may send it on commands that aren't WRITE, but it is not very
> well defined what happens then:
>
> - Currently-released versions of nbd-server will accept the flag on
>
> Or rather than a flag bit, what about this strawman:
>
> NBD_FLAG_SEND_FUA: If set, the server understands the NBD_CMD_FLAG_FUA
> bit. Except where more specific mandatory or optional behavior is
> documented on a given request, the server MUST ignore NBD_CMD_FLAG_FUA
> if it advertised
On Fri, Apr 01, 2016 at 04:06:23PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 10:58:19AM -0400, Kevin O'Connor wrote:
> > On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote:
> > > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote:
> > > > On 01/04/2016
Commit 7836857 introduced a memory leak due to invalid use of
Error vs. visit_type_end(). If visiting the intermediate
members fails, we clear the error and unconditionally use
visit_end_struct() on the same error object; but if that
cleanup succeeds, we then skip the qapi_free call.
Until a
The MIPS TCG backend is the only one to have
tcg_target_reg_alloc_order[] elements of type TCGReg rather than int.
This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
temporaries in a different order") breaking the build on MIPS since the
type differed from
On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote:
> > On 01/04/2016 10:14, Richard W.M. Jones wrote:
> > > Found it: only CONFIG_MPTABLE=y was necessary. It boots with:
> > >
> > > # CONFIG_PIRTABLE is not set
> >
On 1 Apr 2016, at 16:08, Eric Blake wrote:
> But yes, I'm favoring a) as well, for the simplicity factor. There's
> still the issue that if we document a behavior, a new client talking to
> an older server can't reliably tell if the behavior will be guaranteed.
Existing
On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> This version fixes some commit messages, is based on qemu.git master
> and adds Cornelia's Reviewed-by tags. There are no code changes apart
> from context.
>
> Michael S. Tsirkin (2):
> virtio: add aio handler
> virtio-blk: use aio handler for
On Fri, 1 Apr 2016 15:19:46 +0200
Paolo Bonzini wrote:
> There is no need to run the handler one last time; the device is
> being reset and it is okay to drop requests that are pending in
> the virtqueue. Even in the case of migration, the requests would
> be processed
On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> Reentrancy cannot happen while the BQL is being held.
>
> Reviewed-by: Cornelia Huck
> Signed-off-by: Paolo Bonzini
Reverting this patch makes the segfaults go away.
> ---
>
On 01/04/2016 15:57, Fam Zheng wrote:
> Using the nested aio_poll() in coroutine is a bad idea. This patch
> replaces the aio_poll loop in bdrv_drain with a BH, if called in
> coroutine.
>
> For example, the bdrv_drain() in mirror.c can hang when a guest issued
> request is pending on it in
Quoting Peter Lieven (2016-04-01 02:43:31)
> Am 30.03.2016 um 02:11 schrieb Michael Roth:
> > Hi everyone,
> >
> > I am pleased to announce that the QEMU v2.5.1 stable release is now
> > available at:
> >
> > http://wiki.qemu.org/download/qemu-2.5.1.tar.bz2
> >
> > v2.5.1 is now tagged in the
On 01/04/2016 17:35, Kevin O'Connor wrote:
> It's possible to build a third binary, but that seems like it would be
> a bit annoying for distributions.
I don't think that would be a problem. Fedora is already building 4
binaries (128k, 256k, CSM, coreboot), adding a fifth is not a big deal.
* Marcel Apfelbaum (mar...@redhat.com) wrote:
> On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote:
> >* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> >>* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> >>>Hi,
> >>> I'm seeing a breakage on q35 migration on head (and possibly
Hi,
I've redeployed my test box with 14.04 with kilo-staging archive, but i
get a core dump when i try to run kvm the same way you did.
Can you show your /etc/apt/sources.list and /etc/apt/sources.list.d, as
well as output for
uname -a
dpkg -l | egrep -e '(qemu|linux|bios)'
--
You received
Hello all,
Long time no see, at usual ;)
AMD IOMMU patches fixing a few issues mentioned in previous version, formatting
errors and commit messages
David Kiarie (4):
hw/i386: Introduce AMD IOMMU
hw/i386: ACPI table for AMD IOMMU
hw/core: Add AMD IOMMU to machine properties
hw/pci-host:
On 03/31/2016 10:07 AM, Igor Mammedov wrote:
On Thu, 31 Mar 2016 00:03:57 -0400
Stefan Berger wrote:
On 03/30/2016 09:33 AM, Igor Mammedov wrote:
On Mon, 21 Mar 2016 10:21:11 -0400
Stefan Berger wrote:
This patch addresses BZ 1281413.
Fix
On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote:
> > +# general stuff
> > +CONFIG_QEMU=y
> > +CONFIG_ROM_SIZE=128
>
> Why force a size of 128K - I would think 64K would be fine.
Agreed. Setting this to =0 seems the best thing, and it does fit fine
inside 64K.
> > +# no input, no
The NBD protocol does not clearly document what will happen
if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH.
Historically, both the qemu and upstream NBD servers silently
ignored that flag, but that feels a bit risky. Meanwhile, the
qemu NBD client unconditionally sends the flag (without even
On 04/01/2016 04:50 PM, Max Reitz wrote:
> In its organizational structure, the qemu project is rather
> decentralized: Many different maintainers manage their own more or less
> secluded subsystems. However, regarding languages, it is still rather
> anglo-centric.
>
> This issue has been brought
On 01.04.2016 17:57, Eric Blake wrote:
> Commit 7836857 introduced a memory leak due to invalid use of
> Error vs. visit_type_end(). If visiting the intermediate
> members fails, we clear the error and unconditionally use
> visit_end_struct() on the same error object; but if that
> cleanup
On 04/01/2016 08:01 PM, Dr. David Alan Gilbert wrote:
* Marcel Apfelbaum (mar...@redhat.com) wrote:
On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote:
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
Hi,
I'm seeing a breakage
> Am 01.04.2016 um 16:53 schrieb Michael Roth :
>
> Quoting Peter Lieven (2016-04-01 02:43:31)
>>> Am 30.03.2016 um 02:11 schrieb Michael Roth:
>>> Hi everyone,
>>>
>>> I am pleased to announce that the QEMU v2.5.1 stable release is now
>>> available at:
>>>
>>>
On Fri, Apr 01, Max Reitz wrote:
> In any case, do you have a test case where a guest was able to submit a
> request that led to the overflow error you described in the commit message?
mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing device.
When I added discard support to libxl I
Add AMD IOMMU emulation support to q35 chipset
Signed-off-by: David Kiarie
---
hw/pci-host/q35.c | 21 +++--
include/hw/i386/intel_iommu.h | 1 +
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/q35.c
Add IVRS table for AMD IOMMU. Generate IVRS or DMAR
depending on emulated IOMMU
Signed-off-by: David Kiarie
---
hw/i386/acpi-build.c | 98 ++-
include/hw/acpi/acpi-defs.h | 55
James Hogan writes:
> Hi Alex,
>
> On Thu, Jan 28, 2016 at 10:15:17AM +, Alex Bennée wrote:
>> The __atomic primitives have been available since GCC 4.7 and provide
>> a richer interface for describing memory ordering requirements. As a
>> bonus by using the
On 04/01/2016 06:54 PM, Dr. David Alan Gilbert wrote:
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
Hi,
I'm seeing a breakage on q35 migration on head (and possibly older
but certainly head; it's also on a 2.5.0 world I've got
On 01.04.2016 14:22, Olaf Hering wrote:
> Large discard requests lead to sign expansion errors in qemu.
> Since there is no API to tell a guest about the limitations qmeu
> has to split a large request itself.
>
> Signed-off-by: Olaf Hering
> Cc: Stefan Hajnoczi
In the continuing journeys of trying to migrate a q35 guest with ovmf,
I've just hit this assert:
qemu-system-x86_64: /root/git/qemu/block/io.c:1297: bdrv_co_do_pwritev:
Assertion `!(bs->open_flags & 0x0800)' failed.
This is just ahead of rc0 - 1458317c8ada834cf39287f6d11a8cb8a37360d6 from
Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU
The IOMMU does basic translation, error checking and has a
minimal IOTLB implementation
Signed-off-by: David Kiarie
---
hw/i386/Makefile.objs |1 +
hw/i386/amd_iommu.c | 1426
Added a bool, subject to review to machine properties which
it used to override iommu emulated from Intel to AMD.
Signed-off-by: David Kiarie
---
hw/core/machine.c | 32 +---
include/hw/boards.h | 1 +
qemu-options.hx | 7 +--
On Fri, Apr 01, 2016 at 07:59:02PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote:
> > Below are some benchmarks of the other things you mentioned. These
> > are complete appliance boot-to-shutdown times [*not* just SeaBIOS].
> > All
A couple of typos, odd formatting, and missing words made it into
the structured read spec, and several potential ambiguous situations
were worth rewording for clarity.
Signed-off-by: Eric Blake
Signed-off-by: Alex Bligh
---
doc/proto.md | 112
On 04/01/2016 02:37 AM, Wouter Verhelst wrote:
> Hi,
>
> Thanks, applied.
>
> On Thu, Mar 31, 2016 at 04:02:05PM +0300, Denis V. Lunev wrote:
>> From: Pavel Borzenkov
>>
>> There exist some cases when a client knows that the data it is going to
>> write is all zeroes.
On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote:
> Below are some benchmarks of the other things you mentioned. These
> are complete appliance boot-to-shutdown times [*not* just SeaBIOS].
> All debugging has been disabled, and I'm using a slightly different
> kernel version, so
On 04/01/2016 10:32 AM, Denis V. Lunev wrote:
> From: Pavel Butsykin
>
> ide_atapi_dma_restart() used to just complete the DMA with an error,
> under the assumption that there isn't enough information to restart it.
>
> However, as the contents of the ->io_buffer is
On 04/01/2016 10:50 AM, Max Reitz wrote:
> In its organizational structure, the qemu project is rather
> decentralized: Many different maintainers manage their own more or less
> secluded subsystems. However, regarding languages, it is still rather
> anglo-centric.
>
> This issue has been
Rather than requiring allocation by default and allowing trims
only on request during WRITE_ZEROES, it seems like a better
default is to allow server optimizations by default and require
full allocation by specific request. Since WRITE_ZEROES is
experimental and has not yet been implemented, we
On Fri, Apr 01, 2016 at 08:10:48PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote:
> > Otherwise, it doesn't make
> > sense that disabling CONFIG_BOOTORDER=n would change the boot time.
>
> Could it be explained by it avoiding slow access to qemu
Hi Alex,
I have one question inline below.
Alex Bennée writes:
> The __atomic primitives have been available since GCC 4.7 and provide
> a richer interface for describing memory ordering requirements. As a
> bonus by using the primitives instead of hand-rolled functions we can
> use tools such
On Fri, Apr 01, 2016 at 04:05:46PM -0400, Kevin O'Connor wrote:
> On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote:
> > On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote:
> > > > +# general stuff
> > > > +CONFIG_QEMU=y
> > > > +CONFIG_ROM_SIZE=128
> > >
> > > Why
On 25/03/16 12:50, Aleksandar Markovic wrote:
>
> /*
> | The pattern for a default generated single-precision NaN.
>
> **/
> +float32
The previous version was posted and discussed on this thread:
https://lists.nongnu.org/archive/html/qemu-devel/2016-04/threads.html#00013
Since v3:
- CONFIG_ROM_SIZE=0 (it chooses 64K automatically)
- CONFIG_RELOCATE_INIT=n
- CONFIG_BOOTORDER=n
Knocks another 10ms off the boot time.
This commit adds a fast variant of SeaBIOS called 'bios-fast.bin'.
It's designed to be the fastest (also the smallest, but that's not the
main aim) SeaBIOS that is just enough to boot a Linux kernel using the
-kernel option on i686 and x86_64.
This commit does not modify the -kernel option to
On 25/03/16 12:50, Aleksandar Markovic wrote:
> +#define MSA_CLASS_SIGNALING_NAN 0x001
> +#define MSA_CLASS_QUIET_NAN 0x002
> +#define MSA_CLASS_NEGATIVE_INFINITY 0x004
> +#define MSA_CLASS_NEGATIVE_NORMAL0x008
> +#define MSA_CLASS_NEGATIVE_SUBNORMAL 0x010
> +#define
On 04/01/2016 05:16 AM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Do not overwrite x86-64 tests, re-enable vhost-user-test.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1
On 04/01/2016 07:49 AM, James Hogan wrote:
The MIPS TCG backend is the only one to have
tcg_target_reg_alloc_order[] elements of type TCGReg rather than int.
This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
temporaries in a different order") breaking the build on MIPS since the
On 1 Apr 2016, at 20:39, Eric Blake wrote:
> A couple of typos, odd formatting, and missing words made it into
> the structured read spec, and several potential ambiguous situations
> were worth rewording for clarity.
>
> Signed-off-by: Eric Blake
>
On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote:
> On Fri, Apr 01, 2016 at 07:59:02PM +0100, Richard W.M. Jones wrote:
> > On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote:
> > > Below are some benchmarks of the other things you mentioned. These
> > > are complete
On 04/01/2016 07:30 AM, Eric Blake wrote:
> On 04/01/2016 04:34 AM, Alex Bligh wrote:
>> Restore formatting and correct name of 'length'
>>
>> Signed-off-by: Alex Bligh
>> ---
>> doc/proto.md | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric
On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote:
> > > +# general stuff
> > > +CONFIG_QEMU=y
> > > +CONFIG_ROM_SIZE=128
> >
> > Why force a size of 128K - I would think 64K would be fine.
>
> Agreed. Setting
On Fri, Apr 01, 2016 at 03:44:14PM -0400, Kevin O'Connor wrote:
[...]
I ran all the tests again, but this time I ran the test program 3
times (so 30 passes for each setting). As you can see from the
results below the test is not very stable, so that could easily have
accounted for the variation
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Friday, April 1, 2016 1:18 AM
> To: qemu-devel@nongnu.org
> Cc: Andreas Färber ; Alex Williamson
> ; Denis V. Lunev
On 2016-04-01 15:49, James Hogan wrote:
> The MIPS TCG backend is the only one to have
> tcg_target_reg_alloc_order[] elements of type TCGReg rather than int.
> This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
> temporaries in a different order") breaking the build on MIPS since
On Fri, Apr 01, 2016 at 08:15:29PM +0100, Richard W.M. Jones wrote:
> On Fri, Apr 01, 2016 at 08:10:48PM +0100, Richard W.M. Jones wrote:
> > On Fri, Apr 01, 2016 at 03:04:15PM -0400, Kevin O'Connor wrote:
> > > Otherwise, it doesn't make
> > > sense that disabling CONFIG_BOOTORDER=n would change
On 04/01/2016 05:16 AM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Learn to give a socket to the slave to let him make requests to the
> master.
>
> Signed-off-by: Marc-André Lureau
> ---
>
On 31/03/2016 22:17, Alex Bligh wrote:
>> > In qemu, read+FUA just triggers blk_co_flush() prior to reading; but
>> > that's the same function it calls for write+FUA.
> That's harmless, but unnecessary in the sense that current documented
> behaviour doesn't require it. Perhaps it should?
>
> I
On Thu, Mar 31, 2016 at 06:44:32PM -0400, Kevin O'Connor wrote:
> On Thu, Mar 31, 2016 at 11:17:30PM +0100, Richard W.M. Jones wrote:
> > I'd dearly love to get rid of the sgabios option ROM. It looks like
> > SeaBIOS nearly supports a full serial console now?
>
> Last I checked, one could
On 01/04/2016 10:02, Richard W.M. Jones wrote:
>> > echo -e
>> > 'CONFIG_USB=n\nCONFIG_DRIVES=n\nCONFIG_KEYBOARD=n\nCONFIG_MOUSE=n\nCONFIG_WRITABLE_UPPERMEMORY=y\nCONFIG_TCGBIOS=n\nCONFIG_PIRTABLE=n\nCONFIG_MPTABLE=n\nCONFIG_SMBIOS=n\nCONFIG_ACPI=n\nCONFIG_DEBUG_LEVEL=0'
>> > > .config
>> >
On 2016/4/1 15:39, Jason Wang wrote:
On 04/01/2016 03:08 PM, zhanghailiang wrote:
After commit 338d3f, we support 'status' property for filter object.
The segfault can be triggered by starting qemu with 'status=off' property
for filter, when the s->incoming_queue is NULL, we reference it
On Thu, Mar 31, 2016 at 02:34:24PM -0600, Eric Blake wrote:
> On 03/31/2016 02:17 PM, Alex Bligh wrote:
> >> even if we aren't quite sure
> >> what to document of those flags. And that means qemu is correct, and
> >> the NBD protocol has a bug. Since you contributed the FUA flag, is that
> >>
On Thu, Mar 31, 2016 at 07:15:32PM +0100, Alex Bligh wrote:
> NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but
> 1<<16 in nbd.h. It is not used anywhere within the code.
Yes it is:
wouter@gangtai:~/code/c/nbd$ grep -rl CMD_FLAG_FUA *
doc/proto.md
make-integrityhuge.c
nbd.h
Thanks, applied.
On Fri, Apr 01, 2016 at 12:16:48AM +0100, Alex Bligh wrote:
> Clarify that
>
> * The name is not NUL terminated (not just that the length
> 'does not include NUL termination' which might be taken to mean
> there is NUL termination but the length doesn't include it.
>
> *
On Fri, Apr 01, 2016 at 12:03:19AM +0100, Alex Bligh wrote:
> Improve the documentation of NBD_CMD_FLUSH and NBD_CMD_FLAG_FUA. Specifically
> the latter may be set on any command, and its semantics on commands other
> than NBD_CMD_WRITE need explaining. Further, explain how these relate to
>
On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote:
> On 01/04/2016 10:14, Richard W.M. Jones wrote:
> > Found it: only CONFIG_MPTABLE=y was necessary. It boots with:
> >
> > # CONFIG_PIRTABLE is not set
> > CONFIG_MPTABLE=y
> > # CONFIG_SMBIOS is not set
> > # CONFIG_ACPI is not set
On 01/04/2016 10:47, Richard W.M. Jones wrote:
> It's so we can handle error reports. When someone reports that
> libguestfs "hangs", it's sometimes useful to know if the BIOS was
> entered or not, since it points the finger at either qemu, BIOS or
> kernel. (Remember we have to be able to run
On Fri, Apr 01, 2016 at 10:51:31AM +0200, Paolo Bonzini wrote:
>
>
> On 01/04/2016 10:47, Richard W.M. Jones wrote:
> > It's so we can handle error reports. When someone reports that
> > libguestfs "hangs", it's sometimes useful to know if the BIOS was
> > entered or not, since it points the
1 - 100 of 223 matches
Mail list logo