[Qemu-devel] [PATCH v7 13/19] sd: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). Greatly simplifies the code, now that we let the block layer take care of alignment and read-modify-write on our behalf :) In fact, we no longer need to include 'buf' in the migration stream

[Qemu-devel] [PATCH v7 00/19] block: kill sector-based blk_write/read

2.7 material, depends on Kevin's block-next: git://repo.or.cz/qemu/kevin.git block-next Previously posted as part of a larger NBD series [1] and as v6 [3]. Mostly orthogonal to Kevin's recent work to also kill sector interfaces from the driver. [1]

[Qemu-devel] [PATCH v7 18/19] qemu-io: Switch to byte-based block access

qemu-io is the last user of several sector-based interfaces. This patch upgrades to the new interfaces under the hood, then deletes the resulting dead code. Note that for maximum back-compat, while the -p option is no longer required to get blk_pread(), it is still needed to allow for unaligned

Re: [Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction

On 05/04/2016 10:11 AM, Laurent Vivier wrote: +INSN(bkpt, 4848, fff8, M68000); Do we care that this comes in with 68010 not 68000? Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 08/52] target-m68k: define operand sizes

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 8 target-m68k/translate.c | 46 ++ 2 files changed, 22 insertions(+), 32 deletions(-) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 21/52] target-m68k: Reorg flags handling

On 05/04/2016 10:12 AM, Laurent Vivier wrote: From: Richard Henderson Separate all ccr bits. Continue to batch updates via cc_op. Signed-off-by: Richard Henderson Fix gen_logic_cc() to really extend the size of the result. Fix gen_get_ccr(): update cc_op

Re: [Qemu-devel] [PATCH 30/52] target-m68k: add scc/dbcc

Richard Henderson writes: > On 05/04/2016 10:12 AM, Laurent Vivier wrote: >> +DEST_EA(env, insn, OS_BYTE, dest, NULL); >> +tcg_temp_free(dest); >> +} >> + >> +DISAS_INSN(dbcc) >> +{ >> +TCGLabel *l1; >> +TCGv reg; >> +TCGv tmp; >> +int16_t offset; >> +

[Qemu-devel] [PATCH 03/10] configure: build SDL if only SDL2 available

Right now if SDL2 is installed but not SDL1, default configure will entirely disable SDL. Check upfront for SDL2 using pkg-config, but still prefer SDL1 if both versions are installed. Signed-off-by: Cole Robinson --- configure | 12 +++- 1 file changed, 11

[Qemu-devel] [PATCH 00/10] ui: gtk and sdl2 fixes

gtk and sdl2 are nearly unusable on Fedora 24 at the moment. The first two patches fix the worst issues. The remaining patches are just extra bits that came about while I was digging into this. Thanks, Cole Cole Robinson (10): ui: gtk: fix crash when terminal inner-border is NULL ui: sdl2:

[Qemu-devel] [PATCH 05/10] configure: add echo_version helper

Simplifies printing library versions, dependent on if the library was even found Signed-off-by: Cole Robinson --- configure | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 8e25a24..76600f4 100755 ---

[Qemu-devel] [PATCH 07/10] configure: report SDL version

Signed-off-by: Cole Robinson --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 55bd354..22cf55c 100755 --- a/configure +++ b/configure @@ -2448,10 +2448,10 @@ fi if $pkg_config $sdlname --exists; then

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

On 05/06/2016 07:31 AM, Kevin Wolf wrote: >> >> Maybe I need to take that back. Using e.g. blockdev-backup, you can >> indeed see the target in query-block. >> >> Where mnt is a file system and test.qcow2 is large enough such that an >> ENOSPC will occur. > > Hm... Let's pretend we didn't

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 13.04.2016 10:33, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie

[Qemu-devel] [PATCH v7 12/19] pflash: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). Signed-off-by: Eric Blake --- hw/block/pflash_cfi01.c | 12 ++-- hw/block/pflash_cfi02.c | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH v7 10/19] nand: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). This file is doing some complex computations to map various flash page sizes (256, 512, and 2048) atop generic uses of 512-byte sector operations. Perhaps someone will want to tidy up the

Re: [Qemu-devel] [PATCH 01/52] target-m68k: fix DEBUG_DISPATCH

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v7 05/19] ide: Switch to byte-based aio block access

Sector-based blk_aio_readv() and blk_aio_writev() should die; switch to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. The patch had to touch multiple files at once, because dma_blk_io() takes pointers to the functions, and ide_issue_trim() piggybacks on the same interface (while

Re: [Qemu-devel] [PATCH 02/52] target-m68k: Build the opcode table only once to avoid multithreading issues

On 05/04/2016 10:11 AM, Laurent Vivier wrote: From: John Paul Adrian Glaubitz Signed-off-by: John Paul Adrian Glaubitz Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 5 + 1 file changed, 5

Re: [Qemu-devel] [PATCH 09/52] target-m68k: set PAGE_BITS to 12 for m68k

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 16/52] target-m68k: update CPU flags management

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Copied from target-i386 Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 5 +- target-m68k/translate.c | 121 +--- 2 files changed, 86 insertions(+), 40 deletions(-)

Re: [Qemu-devel] [PATCH 31/52] target-m68k: some bit ops cleanup

On 05/04/2016 10:12 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v7 02/19] block: Switch blk_read_unthrottled() to byte interface

Sector-based blk_read() should die; convert the one-off variant blk_read_unthrottled(). Signed-off-by: Eric Blake --- include/sysemu/block-backend.h | 4 ++-- block/block-backend.c | 8 hw/block/hd-geometry.c | 2 +- 3 files changed, 7 insertions(+),

[Qemu-devel] [PATCH 02/10] ui: sdl2: Release grab before opening console window

sdl 2.0.4 currently has a bug which causes our UI shortcuts to fire rapidly in succession: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 It's a toss up whether ctrl+alt+f or ctrl+alt+2 will fire an odd or even number of times, thus determining whether the action succeeds or fails. Opening

[Qemu-devel] [PATCH 10/10] ui: gtk: Fix some deprecation warnings

All device manager APIs are deprecated now. Much of our usage is just to get the current pointer, so centralize that logic and use the new seat APIs Signed-off-by: Cole Robinson --- The remaining warnings look like they'll take a bit more effort ui/gtk.c | 20

[Qemu-devel] [PATCH 06/10] configure: report GTK version

Signed-off-by: Cole Robinson --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 76600f4..55bd354 100755 --- a/configure +++ b/configure @@ -2157,6 +2157,7 @@ if test "$gtk" != "no"; then if $pkg_config

[Qemu-devel] [PATCH 2/9] target-i386: Move TCG initialization to realize time

QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

[Qemu-devel] [PATCH 1/9] target-i386: Move TCG initialization check to tcg_x86_init()

Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2

[Qemu-devel] [PATCH v7 09/19] fdc: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). Signed-off-by: Eric Blake --- hw/block/fdc.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/hw/block/fdc.c

Re: [Qemu-devel] [PATCH 04/52] target-m68k: manage scaled index

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Scaled index is not supported by 68000, 68008, and 68010. EA = (bd + PC) + Xn.SIZE*SCALE + od Ignore it: M68000 FAMILY PROGRAMMER’S REFERENCE MANUAL 2.4 BRIEF EXTENSION WORD FORMAT COMPATIBILITY "If the MC68000 were to execute an instruction

Re: [Qemu-devel] [PATCH 10/52] target-m68k: REG() macro cleanup

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 19/52] target-m68k: terminate cpu dump with newline

On 05/04/2016 10:11 AM, Laurent Vivier wrote: From: Andreas Schwab Signed-off-by: Andreas Schwab Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [Qemu-devel] [PATCH 13/52] target-m68k: update CPU flags management

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Copied from target-i386 Signed-off-by: Laurent Vivier --- cpu-exec.c | 6 -- target-m68k/cpu-qom.h | 4 target-m68k/cpu.c | 2 -- target-m68k/cpu.h | 1 + target-m68k/helper.c| 20

[Qemu-devel] [PATCH v7 15/19] atapi: Switch to byte-based block access

Sector-based blk_read() should die; switch to byte-based blk_pread() instead. Add new defines ATAPI_SECTOR_BITS and ATAPI_SECTOR_SIZE to use anywhere we were previously scaling BDRV_SECTOR_* by 4, for better legibility. Signed-off-by: Eric Blake --- v4: add new defines for

Re: [Qemu-devel] [PATCH v9 05/11] block: allow block jobs in any arbitrary node

On 05/06/2016 06:00 AM, Alberto Garcia wrote: > On Fri 29 Apr 2016 05:00:57 PM CEST, Kevin Wolf wrote: > >>> - Block jobs can now be identified by the node name of their >>> BlockDriverState in addition to the device name. Since both device >>> and node names live in the same namespace there's

[Qemu-devel] [PATCH v7 03/19] block: Switch blk_*write_zeroes() to byte interface

Sector-based blk_write() should die; convert the one-off variant blk_write_zeroes() to use an offset/count interface instead. Likewise for blk_co_write_zeroes() and blk_aio_write_zeroes(). Signed-off-by: Eric Blake --- include/sysemu/block-backend.h | 12 ++--

Re: [Qemu-devel] [PATCH 11/52] target-m68k: allow to update flags with operation on words and bytes

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 14 - target-m68k/helper.c| 139 ++-- target-m68k/translate.c | 82 ++-- 3 files changed,

Re: [Qemu-devel] [PATCH 14/52] target-m68k: update move to/from ccr/sr

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 53 - 1 file changed, 22 insertions(+), 31 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 15/52] target-m68k: don't update cc_dest in helpers

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 1 - target-m68k/helper.c| 28 ++-- target-m68k/helper.h| 2 +- target-m68k/translate.c | 4 ++-- 4 files changed, 17 insertions(+),

Re: [Qemu-devel] [PATCH 26/52] target-m68k: Inline shifts

On 05/04/2016 10:12 AM, Laurent Vivier wrote: From: Richard Henderson Signed-off-by: Richard Henderson fix arithmetical/logical switch Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 52 ---

Re: [Qemu-devel] [PATCH 29/52] target-m68k: factorize flags computing

On 05/04/2016 10:12 AM, Laurent Vivier wrote: + +#define COMPUTE_CCR(op, x, n, z, v, c) { \ +switch (op) { \ +case CC_OP_FLAGS: \ Please do

[Qemu-devel] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done

[Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

This makes the feature name tables in feature_word_info all match the actual QOM property names we use. This will make the command-line interface more consistent, allowing the QOM property names to be used as "-cpu" arguments directly. Add extra feat2prop() calls to x86_cpu_parse_featurestr() to

[Qemu-devel] [PATCH 0/9] Add runnability info to query-cpu-definitions

This series extends query-cpu-definitions to include two extra fields: "runnable", and "unavailable-features". This will return information based on the current machine and accelerator only. In the future we may extend these mechanisms to allow querying other machines and other accelerators

[Qemu-devel] [PATCH 08/10] configure: support vte-2.91

vte >= 0.37 expores API version 2.91, which is where all the active development is. qemu builds and runs fine with that version, so use it if it's available. Signed-off-by: Cole Robinson --- configure | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 4/9] target-i386: List CPU models using subclass list

Instead of using the builtin_x86_defs array, use the QOM subclass list to list CPU models on "-cpu ?" and "query-cpu-definitions". Signed-off-by: Andreas Färber [ehabkost: copied code from a patch by Andreas: "target-i386: QOM'ify CPU", from March 2012] Signed-off-by: Eduardo

[Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

Enable EL2 by default for the A53s and A57s. Signed-off-by: Alistair Francis --- target-arm/cpu64.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 1635deb..59a2042 100644 --- a/target-arm/cpu64.c +++

[Qemu-devel] [PATCH 9/9] target-i386: Return runnability information on query-cpu-definitions

Fill the "runnable" and "unavailable-features" fields on the x86 implementation of query-cpu-definitions. Example command output: { "return": [ { "runnable": true, "name": "host"}, { "runnable": true, "name": "qemu64"}, { "runnable": true, "name": "qemu32"},

[Qemu-devel] [PATCH 5/9] target-i386: Move warning code outside x86_cpu_filter_features()

x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 28

[Qemu-devel] [PATCH v7 04/19] block: Introduce byte-based aio read/write

blk_aio_readv() and blk_aio_writev() are annoying in that they can't access sub-sector granularity, and cannot pass flags. Also, they require the caller to pass redundant information about the size of the I/O (qiov->size in bytes must match nb_sectors in sectors). Add new blk_aio_preadv() and

[Qemu-devel] [PATCH v7 08/19] xen_disk: Switch to byte-based aio block access

Sector-based blk_aio_readv() and blk_aio_writev() should die; switch to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. Signed-off-by: Eric Blake --- hw/block/xen_disk.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

Sector-based blk_aio_readv() and blk_aio_writev() should die; switch to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. As part of the cleanup, scsi_init_iovec() no longer needs to return a value, and reword a comment. Signed-off-by: Eric Blake --- v7: remove more

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

On Fri, 6 May 2016 09:38:41 +0800 Chen Fan wrote: > On 04/26/2016 10:48 PM, Alex Williamson wrote: > > On Tue, 26 Apr 2016 11:39:02 +0800 > > Chen Fan wrote: > > > >> On 04/14/2016 09:02 AM, Chen Fan wrote: > >>> On 04/12/2016

Re: [Qemu-devel] [PATCH 06/52] target-m68k: set disassembler mode to 680x0 or coldfire

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/cpu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 18/52] target-m68k: Some fixes to SR and flags management

On 05/04/2016 10:11 AM, Laurent Vivier wrote: -uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) +static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) { int flags; uint32_t src; @@ -271,6 +271,18 @@ set_x: return flags; } +uint32_t

Re: [Qemu-devel] TCP Segementation Offloading

On Fri, May 06, 2016 at 06:34:33AM +0200, Ingo Krabbe wrote: > > On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: > >> Good Mayday Qemu Developers, > >> > >> today I tried to find a reference to a networking problem, that seems to > >> be of quite general nature: TCP Segmentation

Re: [Qemu-devel] [PATCH 28/52] target-m68k: add addx/subx/negx ops

On 05/04/2016 10:12 AM, Laurent Vivier wrote: +tcg_gen_or_i32(QREG_CC_Z, QREG_CC_Z, QREG_CC_N); /* !Z is sticky */ +gen_ext(QREG_CC_Z, QREG_CC_Z, opsize, 0); Extending Z after the OR is a bug. The (old) high bits of Z might be set from a previous word operation (i.e. !Z) which is

Re: [Qemu-devel] [PATCH 19/52] target-m68k: terminate cpu dump with newline

Laurent Vivier writes: > From: Andreas Schwab > > Signed-off-by: Andreas Schwab > Signed-off-by: Laurent Vivier > --- > target-m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Qemu-devel] [PATCH v7 19/19] block: Kill unused sector-based blk_* functions

Now that there are no remaining clients, we can drop the sector-based blk_read(), blk_write(), blk_aio_readv(), and blk_aio_writev(). Sadly, there are still remaining sector-based interfaces, such as blk_*discard(), or blk_write_compressed(); those will have to wait for another day.

[Qemu-devel] [PATCH v7 11/19] onenand: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). This particular device picks its size during onenand_initfn(), and can be at most 0x8000 bytes; therefore, shifting an 'int sec' request to get back to a byte offset should never overflow

[Qemu-devel] [PATCH v7 17/19] qemu-img: Switch to byte-based block access

Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). Signed-off-by: Eric Blake --- qemu-img.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[Qemu-devel] [PATCH v7 07/19] virtio: Switch to byte-based aio block access

Sector-based blk_aio_readv() and blk_aio_writev() should die; switch to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. The trace is modified at the same time, and nb_sectors is now unused. Fix a comment typo while in the vicinity. Signed-off-by: Eric Blake ---

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

On Fri, May 06, 2016 at 10:44:41AM +0530, Vikhyat Umrao wrote: > On Fri, May 6, 2016 at 6:14 AM, Fam Zheng wrote: > > > On Thu, 05/05 15:06, Jeff Cody wrote: > > > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > > > On Mon, May 02, 2016 at 09:55:17PM +0530,

[Qemu-devel] [PATCH v7 14/19] m25p80: Switch to byte-based block access

Sector-based blk_read() should die; switch to byte-based blk_pread() instead. Likewise for blk_aio_readv() and blk_aio_writev(). Signed-off-by: Eric Blake --- hw/block/m25p80.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 03/52] target-m68k: define m680x0 CPUs and features

On 05/04/2016 10:11 AM, Laurent Vivier wrote: This patch defines seven new features: - M68K_FEATURE_SCALED_INDEX, scaled address index register - M68K_FEATURE_LONG_MULDIV, 32bit multiply/divide - M68K_FEATURE_QUAD_MULDIV, 64bit multiply/divide - M68K_FEATURE_BCCL, long

[Qemu-devel] [PATCH v7 01/19] block: Allow BDRV_REQ_FUA through blk_pwrite()

We have several block drivers that understand BDRV_REQ_FUA, and emulate it in the block layer for the rest by a full flush. But without a way to actually request BDRV_REQ_FUA during a pass-through blk_pwrite(), FUA-aware block drivers like NBD are forced to repeat the emulation logic of a full

Re: [Qemu-devel] [PATCH 05/52] target-m68k: introduce read_imXX() functions

On 05/04/2016 10:11 AM, Laurent Vivier wrote: Read a 8, 16 or 32bit immediat constant. An immediate constant is stored in the instruction opcode and can be in one or two extension words. Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 91

[Qemu-devel] [Bug 1578192] Re: GTK+ interface doesn't translate keycodes properly with Wayland backend

So here's my admittedly quick and dirty solution. This patch adds support for evdev keycodes using translate_evdev_keycode when GDK_WINDOWING_WAYLAND is defined. Affected functions: ui/gtk.c:gd_set_keycode_type ui/gtk.c:gd_map_keycode The caveat with this patch is that I don't see any good way

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On 01.04.2016 19:49, Olaf Hering wrote: > On Fri, Apr 01, Max Reitz wrote: > >> In any case, do you have a test case where a guest was able to submit a >> request that led to the overflow error you described in the commit message? > > mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing

Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNMAP after the fact

On 05/06/2016 10:21 AM, Eric Blake wrote: > On 05/06/2016 10:08 AM, Max Reitz wrote: >> On 05.05.2016 05:42, Eric Blake wrote: >>> When opening a file from the command line, qemu-io defaults >>> to BDRV_O_UNMAP but allows -d to give full control to disable >>> unmaps. But when opening via the

Re: [Qemu-devel] [PATCH 30/52] target-m68k: add scc/dbcc

On 05/04/2016 10:12 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

On Fri, May 6, 2016 at 2:05 PM, Kevin Wolf wrote: >> >> Reviewed-by: Fam Zheng > > Thanks, applied to block-next. Great, thanks everyone! -- Janne

[Qemu-devel] [PATCH 01/10] ui: gtk: fix crash when terminal inner-border is NULL

VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90) code checks for the condition too so I assume it's not just a bug Fixes a crash on Fedora 24 with gtk 3.20 Signed-off-by: Cole Robinson --- ui/gtk.c | 10 ++ 1 file changed, 6 insertions(+), 4

[Qemu-devel] [PATCH 09/10] ui: gtk: Fix a runtime warning on vte >= 0.37

inner-border was dropped in vte API 2.91, in favor of the standard padding style Signed-off-by: Cole Robinson --- ui/gtk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 9876d89..d156c8a 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@

[Qemu-devel] [PATCH 04/10] configure: error on unknown --with-sdlabi value

I accidentally tried --with-sdlabi="1.0", and it failed much later in a weird way. Instead, throw an error if the value isn't in our whitelist. Signed-off-by: Cole Robinson --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure

[Qemu-devel] [PATCH 6/9] target-i386: Define CPUID filtering functions before x86_cpu_list()

Just move code to another place so the it can be reused by the query-cpu-definitions code. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git

[Qemu-devel] [PATCH v1 1/2] target-arm: Add the HSTR_EL2 register

Add the Hypervisor System Trap Register for EL2. This register is used early in the Linux boot and without it the kernel aborts with a "Synchronous Abort" error. Signed-off-by: Alistair Francis --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+)

[Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Extend query-cpu-definitions schema to allow it to return two new optional fields: "runnable" and "unavailable-features". "runnable" will tell if the CPU model can be run in the current host. "unavailable-features" will contain a list of CPU properties that are preventing the CPU model from

[Qemu-devel] [PATCH v1 0/2] target-arm: Add support for HSTR_EL2

Now that EL3 is enabled by default for the A53s and A57s I see this error when booting Linux on the ZynqMP board: "Synchronous Abort" handler, esr 0x0200 By adding the HSTR_EL2 register (and EL2 support) the Linux boot progresses much further. Alistair Francis (2): target-arm: Add the

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

On 05/06/2016 06:31 AM, Markus Armbruster wrote: >> So all that's left are the two output functions. Can we get rid >> of those, and make Visitor* the only public interface, rather than >> making every caller have to do upcasts? > > The two output functions are > > QObject

Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNMAP after the fact

On 05.05.2016 05:42, Eric Blake wrote: > When opening a file from the command line, qemu-io defaults > to BDRV_O_UNMAP but allows -d to give full control to disable > unmaps. But when opening via the 'open' command, qemu-io did > not set BDRV_O_UNMAP, and had no way to allow it. > > Make it at

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

On 5/6/2016 5:44 PM, Jike Song wrote: > On 05/05/2016 05:06 PM, Tian, Kevin wrote: >>> From: Kirti Wankhede >>> >>> >> + * @validate_map_request: Validate remap pfn request >>> >> + * @vdev: vgpu device structure >>> >> + *

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

Laurent Vivier writes: > What is the version of gcc? It doesn't matter, any version. > what are your configure parameters? Nothing special. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: > +static void replication_close(BlockDriverState *bs) > +{ > +BDRVReplicationState *s = bs->opaque; > + > +if (s->mode == REPLICATION_MODE_SECONDARY) { > +g_free(s->top_id); > +} > + > +if (s->replication_state

Re: [Qemu-devel] [PATCH v6 05/20] block: Introduce byte-based aio read/write

On 05/06/2016 06:31 AM, Kevin Wolf wrote: >> +++ b/include/sysemu/block-backend.h >> @@ -110,9 +110,15 @@ int64_t blk_nb_sectors(BlockBackend *blk); >> BlockAIOCB *blk_aio_readv(BlockBackend *blk, int64_t sector_num, >>QEMUIOVector *iov, int nb_sectors, >>

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

Am 06.05.2016 um 15:40 hat Max Reitz geschrieben: > On 06.05.2016 15:31, Kevin Wolf wrote: > > Am 06.05.2016 um 14:32 hat Max Reitz geschrieben: > >> On 06.05.2016 14:01, Max Reitz wrote: > >>> On 27.04.2016 15:20, Kevin Wolf wrote: > When block job errors were introduced, we assigned the

[Qemu-devel] [PATCH] nbd: fix trim/discard commands with a length bigger than NBD_MAX_BUFFER_SIZE

When running fstrim on a filesystem mounted through qemu-nbd with --discard=on, fstrim would fail with I/O errors: $ fstrim /k/spl/ice/ fstrim: /k/spl/ice/: FITRIM ioctl failed: Input/output error and qemu-nbd was spitting these: nbd.c:nbd_co_receive_request():L1232: len (94621696) is

Re: [Qemu-devel] [PATCH v6 00/20] block: kill sector-based blk_write/read

On 05/06/2016 07:11 AM, Kevin Wolf wrote: > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: >> 2.7 material, depends on Kevin's block-next: >> git://repo.or.cz/qemu/kevin.git block-next >> >> Previously posted as part of a larger NBD series [1] and as v5 [2]. >> Mostly orthogonal to Kevin's

Re: [Qemu-devel] [PATCH v4 2/6] qemu-io: Use bool for command line flags

On 05.05.2016 05:42, Eric Blake wrote: > We require a C99 compiler; let's use it to express what we > really mean. > > Signed-off-by: Eric Blake > --- > qemu-io-cmds.c | 94 > +- > 1 file changed, 47 insertions(+), 47

Re: [Qemu-devel] [PATCH v4 1/6] qemu-io: Add missing option documentation

On 05.05.2016 05:42, Eric Blake wrote: > Commit 499afa2 added --image-opts, but forgot to document it in > --help. Likewise for commit 9e8f183 and -d/--discard. > > Finally, commit 10d9d75 removed -g/--growable, but forgot to > cull it from the valid short options. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v4 4/6] qemu-io: Add 'write -f' to test FUA flag

On 05.05.2016 05:42, Eric Blake wrote: > Make it easier to test block drivers with BDRV_REQ_FUA in > .supported_write_flags, by adding the '-f' flag to qemu-io to > conditionally pass the flag through to specific writes ('write', > 'write -z', 'writev', 'aio_write', 'aio_write -z'). You'll want >

Re: [Qemu-devel] [PATCH v4 4/6] qemu-io: Add 'write -f' to test FUA flag

On 05/06/2016 10:05 AM, Max Reitz wrote: > On 05.05.2016 05:42, Eric Blake wrote: >> Make it easier to test block drivers with BDRV_REQ_FUA in >> .supported_write_flags, by adding the '-f' flag to qemu-io to >> conditionally pass the flag through to specific writes ('write', >> 'write -z',

Re: [Qemu-devel] [PATCH v2 08/13] block: Introduce BdrvChild.opaque

On Fri 22 Apr 2016 07:42:37 PM CEST, Kevin Wolf wrote: > BlockBackends use it to get a back pointer from BdrvChild to > BlockBackend in any BdrvChildRole callbacks. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 09/13] block: Drain throttling queue with BdrvChild callback

On Fri 22 Apr 2016 07:42:38 PM CEST, Kevin Wolf wrote: > This removes the last part of I/O throttling from block/io.c and moves > it to the BlockBackend. > > Instead of having knowledge about throttling inside io.c, we can call a > BdrvChild callback .drained_begin/end, which happens to drain the

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

Here is a testcase: when compiling tlink.c from the gcc sources with gcc-6 r234449 (which was bootstrapped in aranym): $ g++ -fno-PIE -c -fomit-frame-pointer -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual

Re: [Qemu-devel] [PATCH v6 07/20] scsi-disk: Switch to byte-based aio block access

Am 06.05.2016 um 16:18 hat Eric Blake geschrieben: > On 05/06/2016 06:50 AM, Kevin Wolf wrote: > > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > >> @@ -1730,13 +1730,11 @@ static void scsi_write_same_complete(void *opaque, > >> int ret) > >> if (data->iov.iov_len) { > >>

Re: [Qemu-devel] [Qemu-block] [PATCH v18 0/8] Block replication for continuous checkpoints

On Fri, Apr 15, 2016 at 04:10:30PM +0800, Changlong Xie wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > You can get the detailed information about block replication from here: >

Re: [Qemu-devel] [PATCH v4 6/6] qemu-io: Add 'write -z -u' to test MAY_UNMAP flag

On 05.05.2016 05:42, Eric Blake wrote: > Make it easier to control whether the BDRV_REQ_MAY_UNMAP flag > can be passed through a write_zeroes command, by adding the '-u' > flag to qemu-io 'write -z' and 'aio_write -z'. To be useful, > the device has to be opened with 'qemu-io -d unmap' (or the >

Re: [Qemu-devel] [PATCH v4 3/6] qemu-io: Allow unaligned access by default

On 05/06/2016 09:59 AM, Max Reitz wrote: > On 05.05.2016 05:42, Eric Blake wrote: >> There's no reason to require the user to specify a flag just so >> they can pass in unaligned numbers. Keep 'read -p' and 'write -p' >> as no-ops so that I don't have to hunt down and update all users >> of

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

Andreas Schwab writes: > Here is a testcase: > > when compiling tlink.c from the gcc sources with gcc-6 r234449 (which > was bootstrapped in aranym): > > $ g++ -fno-PIE -c -fomit-frame-pointer -O2 -DIN_GCC -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W

Re: [Qemu-devel] [PATCH] ipack: Update e-mail address

23.02.2016 11:44, Alberto Garcia wrote: > I'm not really using the old one anymore. > > Signed-off-by: Alberto Garcia Applied to -trivial, finally. I'm sorry this took so long. Thank you for the patience! /mjt

  1   2   3   >