Re: [Qemu-devel] [RFC v2 PATCH 11/13] target-arm: Generate fences in ARMv7 frontend

2016-06-02 Thread Sergey Fedorov
On 31/05/16 21:39, Pranith Kumar wrote: > Signed-off-by: Pranith Kumar > Signed-off-by: Richard Henderson > --- > target-arm/translate.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/target-arm/translate.c

[Qemu-devel] [PATCH 07/10] target-avr: adding instruction decoder

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/decode.c | 724 1 file changed, 724 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/decode.c b/target-avr/decode.c new file mode 100644 index

[Qemu-devel] [PATCH 01/10] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 1 + disas/Makefile.objs | 1 + disas/avr.c | 10 ++ include/disas/bfd.h | 7

[Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2443 +++ target-avr/translate.h | 123 +++ 2 files changed, 2566 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644

[Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index aec37af..ed22b37 100644 --- a/target-avr/helper.c +++

Re: [Qemu-devel] [PATCH 2/4] 9p: introduce the V9fsDir type

2016-06-02 Thread Eric Blake
On 06/02/2016 02:52 AM, Greg Kurz wrote: > If we are to switch back to readdir(), we need a more complex type than > DIR * to be able to serialize concurrent accesses to the directory stream. > > This patch introduces a placeholder type and fixes all users. > > Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH v2 2/3] hw/iommu: enable iommu with -device

2016-06-02 Thread Marcel Apfelbaum
Use the standard '-device iommu' instead of '-machine,iommu=on' to create the IOMMU device. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 20 hw/i386/intel_iommu.c | 17 + hw/pci-host/q35.c | 28

Re: [Qemu-devel] [PATCH RFC 0/2] enable iommu with -device

2016-06-02 Thread Marcel Apfelbaum
On 05/31/2016 04:44 AM, Peter Xu wrote: On Mon, May 30, 2016 at 05:14:15PM +0300, Marcel Apfelbaum wrote: On 05/30/2016 04:43 PM, Peter Xu wrote: On Mon, May 23, 2016 at 05:01:28PM +0300, Marcel Apfelbaum wrote: This is a proposal on how to create the iommu with '-device intel-iommu' instead

Re: [Qemu-devel] [PATCH 3/4] 9p: add locking to V9fsDir

2016-06-02 Thread Eric Blake
On 06/02/2016 02:52 AM, Greg Kurz wrote: > If several threads call concurrently readdir() with the same directory s/call concurrently/concurrently call/ > stream pointer, it is possible that they all get a pointer to the same > dirent structure, whose content is overwritten each time readdir()

Re: [Qemu-devel] [RFC v2 PATCH 08/13] tcg/s390: Add support for fence

2016-06-02 Thread Sergey Fedorov
On 31/05/16 21:39, Pranith Kumar wrote: > Cc: Alexander Graf > Signed-off-by: Richard Henderson > Signed-off-by: Pranith Kumar > --- > tcg/s390/tcg-target.inc.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH] net: mipsnet: check transmit buffer size before sending

2016-06-02 Thread P J P
+-- On Thu, 2 Jun 2016, Peter Maydell wrote --+ | > case MIPSNET_TX_DATA_COUNT: | > - s->tx_count = (val <= MAX_ETH_FRAME_SIZE) ? val : 0; | > +s->tx_count = (val < MAX_ETH_FRAME_SIZE) ? val : MAX_ETH_FRAME_SIZE; | > s->tx_written = 0; | | This is a behaviour change

Re: [Qemu-devel] [RFC v1 04/12] atomic: introduce atomic_dec_fetch.

2016-06-02 Thread Sergey Fedorov
On 15/04/16 17:23, Alex Bennée wrote: > Useful for counting down. > > Signed-off-by: Alex Bennée Reviewed-by: Sergey Fedorov > --- > include/qemu/atomic.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/qemu/atomic.h

Re: [Qemu-devel] [PATCH RFC 0/8] cpus: make "-cpu cpux, features" global properties

2016-06-02 Thread David Hildenbrand
> Current CLI option -cpu cpux,features serves as template > for all created cpus of type: cpux. However QEMU parses > "features" every time it creates a cpu instance and applies > them to it while doing parsing. > > That doesn't work well with -device/device_add infrastructure > as it has no

[Qemu-devel] [Bug 1568356] Re: ERROR:ui/sdl2-2d.c:120:sdl2_2d_switch:

2016-06-02 Thread T. Huth
You've apparently added it to console-gl.c ... your original description was about sdl2-2d.c, so please add the code there. In console-gl.c, you could use this statement instead: printf("gl Surface format is: %x\n", surface->format); -- You received this bug notification because you are a

[Qemu-devel] [PATCH 04/10] target-avr: adding instructions encodings

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 838 1 file changed, 838 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file

[Qemu-devel] [PATCH 08/10] target-avr: adding instruction translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2443 +++ target-avr/translate.h | 123 +++ 2 files changed, 2566 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644

[Qemu-devel] [PATCH v2 1/3] hw/pci: delay bus_master_enable_region initialization

2016-06-02 Thread Marcel Apfelbaum
Skip bus_master_enable region creation on PCI device init in order to be sure the IOMMU device (if present) would be created in advance. Add this memory region at machine_done time. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 46

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Richard Henderson
On 06/02/2016 09:30 AM, Sergey Fedorov wrote: I think we need to extend TCG load/store instruction attributes to provide information about guest ordering requirements and leave this TCG operation only for explicit barrier instruction translation. I do not agree. I think separate barriers are

[Qemu-devel] [PATCH] linux-user: check if NETLINK_ROUTE is available

2016-06-02 Thread Laurent Vivier
Some IFLA_* symbols can be missing in the host linux/if_link.h, but as they are enums and not "#defines", check in "configure" if last known (IFLA_PROTO_DOWN) is available and if not, disable management of NETLINK_ROUTE protocol. Signed-off-by: Laurent Vivier --- Note:

Re: [Qemu-devel] [RFC v2 PATCH 08/13] tcg/s390: Add support for fence

2016-06-02 Thread Richard Henderson
On 06/02/2016 12:31 PM, Sergey Fedorov wrote: On 31/05/16 21:39, Pranith Kumar wrote: Cc: Alexander Graf Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/s390/tcg-target.inc.c | 9 + 1 file changed, 9

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-02 Thread Mark Cave-Ayland
That basically looks like it should work. The only time I've seen random segfaults similar to this is with a corrupted disk, so the first question to ask is whether you've verified the ISO image you are using? Unfortunately this isn't an image I currently have access to, but I can report my

Re: [Qemu-devel] [libvirt] [PATCH] target-i386: Remove xlevel & hv-spinlocks option fixups

2016-06-02 Thread Eric Blake
On 06/02/2016 10:55 AM, Eduardo Habkost wrote: > The "fixup will be removed in future versions" warnings are > present since QEMU 1.7.0, at least, so users should have fixed > their scripts and configurations, already. > > In the case of libvirt users, libvirt doesn't use the "xlevel" > option,

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Sergey Fedorov
On 03/06/16 00:18, Richard Henderson wrote: > On 06/02/2016 01:38 PM, Sergey Fedorov wrote: >> On 02/06/16 23:36, Richard Henderson wrote: >>> On 06/02/2016 09:30 AM, Sergey Fedorov wrote: I think we need to extend TCG load/store instruction attributes to provide information about guest

Re: [Qemu-devel] [PATCH 1/4] 9p: drop useless out: label

2016-06-02 Thread Eric Blake
On 06/02/2016 02:52 AM, Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > hw/9pfs/9p.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

[Qemu-devel] [PATCH 01/10] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 1 + disas/Makefile.objs | 1 + disas/avr.c | 10 ++ include/disas/bfd.h | 7

[Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdbstub.c| 10 +

[Qemu-devel] [PATCH 03/10] target-avr: adding a sample AVR board

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- hw/Makefile.objs | 1 + hw/avr/Makefile.objs | 1 + hw/avr/sample-io.c | 246 +++ hw/avr/sample.c | 120 + 4 files changed, 368 insertions(+) create mode

[Qemu-devel] [PATCH 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 103 target-avr/helper.h | 5 +++ 2 files changed, 108 insertions(+) diff --git a/target-avr/helper.c b/target-avr/helper.c index ed22b37..450f598 100644 ---

[Qemu-devel] [PATCH 07/10] target-avr: adding instruction decoder

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/decode.c | 724 1 file changed, 724 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/decode.c b/target-avr/decode.c new file mode 100644 index

[Qemu-devel] [PATCH 03/10] target-avr: adding a sample AVR board

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- hw/Makefile.objs | 1 + hw/avr/Makefile.objs | 1 + hw/avr/sample-io.c | 246 +++ hw/avr/sample.c | 120 + 4 files changed, 368 insertions(+) create mode

[Qemu-devel] [PATCH 09/10] target-avr: updating translate.c to use instructions translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 4 +- target-avr/translate.c | 148 ++- 2 files changed, 72 insertions(+), 80 deletions(-) diff --git a/target-avr/Makefile.objs b/target-avr/Makefile.objs index

[Qemu-devel] [PATCH v2 3/3] q35: allow dynamic sysbus

2016-06-02 Thread Marcel Apfelbaum
Allow adding sysbus devices with -device on Q35. At first Q35 will support only intel-iommu to be added this way, however the command line will support all sysbus devices. Mark with 'cannot_instantiate_with_device_add_yet' the ones causing immediate problems (e.g. crashes). Signed-off-by:

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Sergey Fedorov
On 02/06/16 23:36, Richard Henderson wrote: > On 06/02/2016 09:30 AM, Sergey Fedorov wrote: >> I think we need to extend TCG load/store instruction attributes to >> provide information about guest ordering requirements and leave this TCG >> operation only for explicit barrier instruction

[Qemu-devel] Channel paths (was: Re: [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket)

2016-06-02 Thread Sascha Silbe
Dear Daniel, "Daniel P. Berrange" writes: > On Thu, Jun 02, 2016 at 09:41:56AM +0200, Michal Privoznik wrote: >> On 01.06.2016 18:16, Wei Xu wrote: >> > On 2016年06月01日 00:44, Daniel P. Berrange wrote: > There are plenty of other places where we allow arbitrary paths in the

[Qemu-devel] [PATCH v2 0/3] enable iommu with -device

2016-06-02 Thread Marcel Apfelbaum
Create the iommu device with '-device intel-iommu' instead of '-machine,iommu=on'. The device is part of the machine properties because we wanted to ensure it is created before any other PCI device. The alternative is to skip the bus_master_enable_region at the time the device is created. We

[Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdbstub.c| 10 +

[Qemu-devel] [PATCH 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 103 target-avr/helper.h | 5 +++ 2 files changed, 108 insertions(+) diff --git a/target-avr/helper.c b/target-avr/helper.c index ed22b37..450f598 100644 ---

[Qemu-devel] [PATCH 02/10] target-avr: adding AVR CPU features/flavors

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 326 ++- target-avr/cpu.h | 59 ++ 2 files changed, 383 insertions(+), 2 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index ff26018..9be0a1d

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Richard Henderson
On 06/02/2016 11:42 AM, Pranith Kumar wrote: Yes, I am working on adding flag argument to the TCG MemOp which indicates this. Please don't. I don't think this is the right way to go. r~

Re: [Qemu-devel] [PATCH 4/4] 9p: switch back to readdir()

2016-06-02 Thread Eric Blake
On 06/02/2016 02:52 AM, Greg Kurz wrote: > This patch changes the 9p code to use readdir() again instead of > readdir_r(), which is deprecated in glibc 2.24. > > All the locking was put in place by a previous patch. > > Signed-off-by: Greg Kurz > --- > +++

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Richard Henderson
On 06/02/2016 01:38 PM, Sergey Fedorov wrote: On 02/06/16 23:36, Richard Henderson wrote: On 06/02/2016 09:30 AM, Sergey Fedorov wrote: I think we need to extend TCG load/store instruction attributes to provide information about guest ordering requirements and leave this TCG operation only for

Re: [Qemu-devel] [PULL V4 00/31] Net patches

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 19:38, Dmitry Fleytman wrote: > From lttng/tracepoint.h: > > … > > /* > * TP_ARGS takes tuples of type, argument separated by a comma. > * It can take up to 10 tuples (which means that less than 10 tuples is > * fine too). > * Each tuple is also separated

[Qemu-devel] [PATCH 04/10] target-avr: adding instructions encodings

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 838 1 file changed, 838 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file

[Qemu-devel] [PATCH 02/10] target-avr: adding AVR CPU features/flavors

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 326 ++- target-avr/cpu.h | 59 ++ 2 files changed, 383 insertions(+), 2 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index ff26018..9be0a1d

[Qemu-devel] [PATCH 09/10] target-avr: updating translate.c to use instructions translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 4 +- target-avr/translate.c | 148 ++- 2 files changed, 72 insertions(+), 80 deletions(-) diff --git a/target-avr/Makefile.objs b/target-avr/Makefile.objs index

Re: [Qemu-devel] [PATCH] tests: start a /qga/guest-exec test

2016-06-02 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2016-05-24 08:48:41) > From: Marc-André Lureau > > Test a few guest-exec guest agent commands, added in qemu 2.5. > > Signed-off-by: Marc-André Lureau > --- > tests/test-qga.c | 70 >

[Qemu-devel] [PATCH 05/10] target-avr: adding AVR interrupt handling

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index aec37af..ed22b37 100644 --- a/target-avr/helper.c +++

Re: [Qemu-devel] [PATCH] sdl2: skip init without outputs

2016-06-02 Thread Cole Robinson
On 06/01/2016 10:08 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/sdl2.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index 909038f..30d2a3c 100644 > --- a/ui/sdl2.c > +++ b/ui/sdl2.c > @@ -794,6 +794,9 @@ void

[Qemu-devel] [PATCH 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 117 +++- target-avr/helper.h | 5 +++ 2 files changed, 111 insertions(+), 11 deletions(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index bb47a87..b93589a

[Qemu-devel] [PATCH 9/9] target-avr: updating translate.c to use instructions translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 4 +- target-avr/translate.c | 132 --- 2 files changed, 59 insertions(+), 77 deletions(-) diff --git a/target-avr/Makefile.objs b/target-avr/Makefile.objs index

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-06-02 Thread David Gibson
On Thu, Jun 02, 2016 at 06:04:37PM +0200, Greg Kurz wrote: > On Wed, 1 Jun 2016 12:33:28 +1000 > David Gibson wrote: > > > On Tue, May 31, 2016 at 03:15:21PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 31/05/2016 15:10, Greg Kurz wrote: > > > >>> > > +#if

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-02 Thread Fam Zheng
On Thu, 06/02 16:13, Eduardo Habkost wrote: > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > [...] > > + > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > > +# Makes the definition constant after the first expansion > > +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > >

[Qemu-devel] [PATCH 4/9] target-avr: adding instructions encodings

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 838 1 file changed, 838 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file

Re: [Qemu-devel] [RFC PATCH v0 0/2] Increase max memslots to 512 for PowerPC

2016-06-02 Thread David Gibson
On Thu, Jun 02, 2016 at 07:37:37PM +0530, Bharata B Rao wrote: > On Thu, Jun 02, 2016 at 09:03:15AM +0200, Thomas Huth wrote: > > On 02.06.2016 06:39, Bharata B Rao wrote: > > ... > > > Agreed. Here is the updated patch: > > > > > > spapr: Increase hotpluggable memory slots to 256 > > > > > >

Re: [Qemu-devel] [QEMU RFC PATCH v3 1/6] Migration: Defined VMStateDescription struct for spapr_drc

2016-06-02 Thread David Gibson
On Thu, Jun 02, 2016 at 05:28:45PM -0700, Jianjun Duan wrote: > > > On 06/01/2016 09:07 PM, David Gibson wrote: > > On Tue, May 31, 2016 at 11:02:39AM -0700, Jianjun Duan wrote: > >> To manage hotplug/unplug of dynamic resources such as PCI cards, > >> memory, and CPU on sPAPR guests, a firmware

[Qemu-devel] [PATCH v2] raw-posix: Fetch max sectors for host block device

2016-06-02 Thread Fam Zheng
This is sometimes a useful value we should count in. Signed-off-by: Fam Zheng --- block/raw-posix.c | 24 1 file changed, 24 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index a4f5a1b..32f9596 100644 --- a/block/raw-posix.c +++

Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work

2016-06-02 Thread Fam Zheng
On Thu, 06/02 18:49, John Snow wrote: > > > On 06/02/2016 07:43 AM, Vladimir Sementsov-Ogievskiy wrote: > > Hi, what are the plans? > > > > I'm not sure. Fam, part of this series was merged, wasn't it? > > Do you have outstanding work that you'd like me to take over and push > through for

Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
On 06/02/2016 11:14 PM, Anthony PERARD wrote: On Thu, Jun 02, 2016 at 06:36:46PM +0800, Changlong Xie wrote: +void qmp_xen_load_devices_state(const char *filename, Error **errp) +{ +QEMUFile *f; +QIOChannelFile *ioc; +int ret; + +/* Guest must be paused before loading the device

Re: [Qemu-devel] [PATCH v4 08/15] tests: Add test code for meta bitmap

2016-06-02 Thread Fam Zheng
On Fri, 03/11 15:58, Max Reitz wrote: > > +/* Test "unset" -> "set" will update meta */ > > +hbitmap_set(data->hb, start, count); > > +hbitmap_check_meta(data, check_start, check_count); > > + > > +/* Test "set" -> "set" will not update meta */ > > +

Re: [Qemu-devel] [PATCH v2 0/2] AVX2 configure fixes

2016-06-02 Thread Li, Liang Z
> Cc: amit.s...@redhat.com > Subject: [PATCH v2 0/2] AVX2 configure fixes > > From: "Dr. David Alan Gilbert" > > Hi, > This pair of patches fixes a couple of issues that we found during test. > The first is that the configure test is pessimistic when compiled with -O2, >

[Qemu-devel] [Bug 1588591] [NEW] Qemu 2.6 Solaris 8 Sparc telnet terminate itself

2016-06-02 Thread Zhen Ning Lim
Public bug reported: With Qemu 2.6, Solaris 8 can be installed and run. However, it sometimes terminate itself with I/O thread spun for 1000 iterations. qemu-system-sparc -nographic -monitor null -serial mon:telnet:0.0.0.0:3000,server -hda ./Sparc8.disk -m 256 -boot c -net

[Qemu-devel] [PATCH 2/9] target-avr: adding AVR CPU features/flavors

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 311 ++- target-avr/cpu.h | 59 +++ 2 files changed, 368 insertions(+), 2 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index cfc1aee..97653c5

Re: [Qemu-devel] [PULL V4 00/31] Net patches

2016-06-02 Thread Fam Zheng
On Thu, 06/02 13:05, Eric Blake wrote: > On 06/02/2016 12:09 PM, Dmitry Fleytman wrote: > > > > > The build did not pass because of tracepoint e1000e_rx_rss_ip6 which failed > > to compile. > > > > This tracepoint has 11 parameters, when 1 parameter is removed build > > succeeds. > > Could it

[Qemu-devel] AVR cores

2016-06-02 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[Qemu-devel] [PATCH 8/9] target-avr: adding instruction translation

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2511 +++ target-avr/translate.h | 123 +++ 2 files changed, 2634 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644

Re: [Qemu-devel] [PATCH 4/7] scsi-disk: introduce dma_readv and dma_writev

2016-06-02 Thread xiaoqiang zhao
在 2016年06月02日 03:07, Mark Cave-Ayland 写道: On 23/05/16 13:54, Paolo Bonzini wrote: >These are replacements for blk_aio_preadv and blk_aio_pwritev that allow >customization of the data path. They reuse the DMA helpers' DMAIOFunc >callback type, so that the same function can be used in either

Re: [Qemu-devel] [PATCH v2 0/8] virtio-blk: multiqueue support

2016-06-02 Thread Stefan Hajnoczi
On Mon, May 30, 2016 at 06:25:58PM -0700, Stefan Hajnoczi wrote: > v2: > * Simplify s->rq live migration [Paolo] > * Use more efficient bitmap ops for batch notification [Paolo] > * Fix perf regression due to batch notify BH in wrong AioContext [Christian] > > The virtio_blk guest driver has

[Qemu-devel] [PATCH 3/9] target-avr: adding a sample AVR board

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- hw/Makefile.objs | 1 + hw/avr/Makefile.objs | 1 + hw/avr/sample-io.c | 217 +++ hw/avr/sample.c | 118 4 files changed, 337 insertions(+) create

[Qemu-devel] [PATCH 7/9] target-avr: adding instruction decoder

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/decode.c | 724 1 file changed, 724 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/decode.c b/target-avr/decode.c new file mode 100644 index

Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
On 06/02/2016 11:14 PM, Anthony PERARD wrote: On Thu, Jun 02, 2016 at 06:36:46PM +0800, Changlong Xie wrote: +void qmp_xen_load_devices_state(const char *filename, Error **errp) +{ +QEMUFile *f; +QIOChannelFile *ioc; +int ret; + +/* Guest must be paused before loading the device

[Qemu-devel] [PATCH 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 1 + disas/Makefile.objs | 1 + disas/avr.c | 10 ++ include/disas/bfd.h | 7

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-06-02 Thread Richard Henderson
On 06/02/2016 02:37 PM, Sergey Fedorov wrote: On 03/06/16 00:18, Richard Henderson wrote: On 06/02/2016 01:38 PM, Sergey Fedorov wrote: On 02/06/16 23:36, Richard Henderson wrote: On 06/02/2016 09:30 AM, Sergey Fedorov wrote: I think we need to extend TCG load/store instruction attributes to

Re: [Qemu-devel] [PATCH RFC 0/8] cpus: make "-cpu cpux, features" global properties

2016-06-02 Thread Eduardo Habkost
On Thu, Jun 02, 2016 at 10:44:49PM +0200, David Hildenbrand wrote: > > Current CLI option -cpu cpux,features serves as template > > for all created cpus of type: cpux. However QEMU parses > > "features" every time it creates a cpu instance and applies > > them to it while doing parsing. > > > >

[Qemu-devel] [PATCH 5/9] target-avr: adding AVR interrupt handling

2016-06-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index fbab91d..bb47a87 100644 --- a/target-avr/helper.c +++

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fetch max sectors for host block device from sysfs

2016-06-02 Thread Fam Zheng
On Thu, 06/02 14:54, Kevin Wolf wrote: > Also a quick search on the internet suggests that the BLKSECTGET ioctl > is what we're looking for, so hopefully using sysfs is unnecessary > anyway. Oops! Looks like something went terribly wrong with my "quick search", will post v2. Thanks! Fam

Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Eric Blake
On 06/02/2016 07:26 PM, Changlong Xie wrote: >>> + >>> +ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT, >>> 0660, errp); >> >> This does not look right, it looks like it's going to open the file >> to write to it. You probably want O_RDONLY, also I don't think the >> O_CREAT

Re: [Qemu-devel] [PATCH v2] raw-posix: Fetch max sectors for host block device

2016-06-02 Thread Eric Blake
On 06/02/2016 08:07 PM, Fam Zheng wrote: > This is sometimes a useful value we should count in. > > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 24 > 1 file changed, 24 insertions(+) > Will conflict with patches I'm about to post to rework

Re: [Qemu-devel] [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model

2016-06-02 Thread Xiao Guangrong
On 05/23/2016 09:46 PM, Paolo Bonzini wrote: On 20/05/2016 23:39, Eduardo Habkost wrote: Introduce Skylake-Client CPU model, which inherits the features from Broadwell and supports some additional features that are: MPX, XSAVEC, and XGETBV1. Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work

2016-06-02 Thread John Snow
On 06/02/2016 07:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi, what are the plans? > I'm not sure. Fam, part of this series was merged, wasn't it? Do you have outstanding work that you'd like me to take over and push through for you? --js > On 26.05.2016 03:47, Fam Zheng wrote: >> On

Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 21:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-avr/cpu-qom.h| 38 + > target-avr/cpu.c| 100 > +--- > target-avr/cpu.h|

Re: [Qemu-devel] [QEMU RFC PATCH v3 1/6] Migration: Defined VMStateDescription struct for spapr_drc

2016-06-02 Thread Jianjun Duan
On 06/01/2016 09:07 PM, David Gibson wrote: > On Tue, May 31, 2016 at 11:02:39AM -0700, Jianjun Duan wrote: >> To manage hotplug/unplug of dynamic resources such as PCI cards, >> memory, and CPU on sPAPR guests, a firmware abstraction known as >> a Dynamic Resource Connector (DRC) is used to

Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
On 06/03/2016 09:45 AM, Eric Blake wrote: On 06/02/2016 07:26 PM, Changlong Xie wrote: + +ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT, 0660, errp); This does not look right, it looks like it's going to open the file to write to it. You probably want O_RDONLY, also I

Re: [Qemu-devel] [PATCH v4 09/15] block: Support meta dirty bitmap

2016-06-02 Thread Fam Zheng
On Fri, 03/11 16:17, Max Reitz wrote: > On 08.03.2016 05:45, Fam Zheng wrote: > > The added group of operations enables tracking of the changed bits in > > the dirty bitmap. > > > > Signed-off-by: Fam Zheng > > --- > > block/dirty-bitmap.c | 52 > >

Re: [Qemu-devel] [PATCH v2] raw-posix: Fetch max sectors for host block device

2016-06-02 Thread Fam Zheng
On Thu, 06/02 20:42, Eric Blake wrote: > On 06/02/2016 08:07 PM, Fam Zheng wrote: > > This is sometimes a useful value we should count in. > > > > Signed-off-by: Fam Zheng > > --- > > block/raw-posix.c | 24 > > 1 file changed, 24 insertions(+) > > >

Re: [Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
On 06/03/2016 10:13 AM, Changlong Xie wrote: On 06/03/2016 09:45 AM, Eric Blake wrote: On 06/02/2016 07:26 PM, Changlong Xie wrote: + +ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT, 0660, errp); This does not look right, it looks like it's going to open the file to write

[Qemu-devel] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes

2016-06-02 Thread Fam Zheng
Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/dirty-bitmap.c | 2 +- include/qemu/hbitmap.h | 17 + util/hbitmap.c | 69

[Qemu-devel] [PATCH v5 08/10] block: BdrvDirtyBitmap serialization interface

2016-06-02 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy [Add the "finish" parameters. - Fam] Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v5 07/10] hbitmap: serialization

2016-06-02 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions

[Qemu-devel] [RFC PATCH v1 1/3] spapr: Introduce pseries-2.7 machine type

2016-06-02 Thread Bharata B Rao
Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 44e401a..30b9731 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2344,18 +2344,36 @@

[Qemu-devel] [PATCH v5 10/10] block: More operations for meta dirty bitmap

2016-06-02 Thread Fam Zheng
Callers can create an iterator of meta bitmap with bdrv_dirty_meta_iter_new(), then use the bdrv_dirty_iter_* operations on it. Meta iterators are also counted by bitmap->active_iterators. Also add a couple of functions to retrieve granularity and count. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v5 05/10] block: Add two dirty bitmap getters

2016-06-02 Thread Fam Zheng
For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/dirty-bitmap.c | 10 ++ include/block/dirty-bitmap.h | 2 ++ 2 files changed, 12 insertions(+) diff --git

Re: [Qemu-devel] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices

2016-06-02 Thread David Gibson
On Thu, May 12, 2016 at 09:18:18AM +0530, Bharata B Rao wrote: > Introduce sPAPRMachineClass.dr_cpu_enabled to indicate support for > CPU core hotplug. Initialize boot time CPUs as core deivces and prevent > topologies that result in partially filled cores. Both of these are done > only if CPU

Re: [Qemu-devel] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices

2016-06-02 Thread David Gibson
On Thu, May 12, 2016 at 09:18:17AM +0530, Bharata B Rao wrote: > Add sPAPR specific abastract CPU core device that is based on generic > CPU core device. Use this as base type to create sPAPR CPU specific core > devices. > > TODO: > - Add core types for other remaining CPU types > - Handle CPU

[Qemu-devel] [RFC PATCH v1 0/3] spapr: Work around the memory hotplug failure with DDW

2016-06-02 Thread Bharata B Rao
Memory hotplug can fail when upcoming, yet-to-be-upstreamed, 2.7 feature DDW is enabled. This happens due to a guest kernel bug which results in DDW code in QEMU obtaining incorrect value of max possible memory address. This incorrect max mem value results in incorrect DDW size which later causes

[Qemu-devel] [RFC PATCH v1 3/3] spapr: spapr: Work around the memory hotplug failure with DDW

2016-06-02 Thread Bharata B Rao
Memory hotplug can fail for some combinations of RAM and maxmem when DDW is enabled in the presence of devices like nec-usb-xhci. DDW depends on maximum addressable memory returned by guest and this value is currently being calculated wrongly by the guest kernel routine memory_hotplug_max(). While

[Qemu-devel] [PATCH v5 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded

2016-06-02 Thread Fam Zheng
We use a loop over bs->dirty_bitmaps to make sure the caller is only releasing a bitmap owned by bs. Let's also assert that in this case the caller is releasing a bitmap that does exist. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 3 +++ 1 file changed, 3 insertions(+)

[Qemu-devel] [PATCH] scsi-disk: fix reads from scsi-disk devices

2016-06-02 Thread Mark Cave-Ayland
Commit fcaafb1001b9c42817714dd3b2aadcfdb997b53d accidentally broke reads from scsi-disk devices when being updated from its original form to use the new byte-based block functions. Add the extra missing sector to offset conversion in order to restore read functionality. Signed-off-by: Mark

[Qemu-devel] [PATCH v5 03/10] tests: Add test code for meta bitmap

2016-06-02 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/test-hbitmap.c | 116 +++ 1 file changed, 116 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index abe1427..c00c2b5 100644 ---

[Qemu-devel] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work

2016-06-02 Thread Fam Zheng
v5: Rebase: first 5 patches from last revision are already merged. Addressed Max's comments: 01: - "block.c" -> "block/dirty-bitmap.c" in commit message. - "an BdrvDirtyBitmapIter" -> "an BdrvDirtyBitmapIter" in code comment. - hbitmap_next => next_dirty as variable name.

[Qemu-devel] [PATCH v5 09/10] tests: Add test code for hbitmap serialization

2016-06-02 Thread Fam Zheng
Acked-by: John Snow Signed-off-by: Fam Zheng --- tests/test-hbitmap.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index c00c2b5..8f64941 100644 ---

  1   2   3   4   >