[Qemu-devel] [PULL 00/17] Block patches

The following changes since commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf: Merge remote-tracking branch 'remotes/famz/tags/docker-pull-request' into staging (2016-09-09 12:49:41 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [Bug 905095] Re: qemu-img can't convert vmdk file: Operation not permitted

I did the same task on totally different images recently and it worked fine. Thanks for bumping that old bug so we can close it. ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [Qemu-block] [PATCH v24 11/12] support replication driver in blockdev-add

On Mon, Aug 15, 2016 at 05:32:19PM +0800, Changlong Xie wrote: > On 08/15/2016 04:37 PM, Kevin Wolf wrote: > > Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben: > > > On 08/09/2016 05:08 PM, Kevin Wolf wrote: > > > > Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: > > > > > From: Wen

Re: [Qemu-devel] [PATCH 1/3] vfio/pci: conversion to realize

Hi Markus, On 12/09/2016 14:45, Markus Armbruster wrote: > Eric Auger writes: > >> This patch converts VFIO PCI to realize function. >> >> Also original initfn errors now are propagated using QEMU >> error objects. All errors are formatted with the same pattern: >> "vfio:

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

On 30.08.2016 13:31, Markus Armbruster wrote: > Markus Armbruster writes: > >> Paolo asked for an update. > > Another update; HEAD is commit e00da55. [...] >>> Full list of unmaintained files now: [...] > default-configs/aarch64-linux-user.mak >

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson > > +/* Probe for a

Re: [Qemu-devel] [PATCH v2 3/5] pci: Convert msix_init() to Error and fix callers to check it

Cao jin writes: > msix_init() reports errors with error_report(), which is wrong when > it's used in realize(). The same issue was fixed for msi_init() in > commit 1108b2f. > > For some devices like e1000e & vmxnet3 who won't fail because of > msi_init's failure,

[Qemu-devel] QEMU Summit 2016 minutes

Hi all; these are the minutes from the QEMU Summit 2016, which was the usual informal gathering of submaintainers at KVM Forum this year. As usual, none of this is set-in-stone decisions; further input and discussion on-list is welcome. * release process + I'm away November, which will be in

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

Cao jin writes: > The input parameters is used for creating the msix capable device, so > they must obey the PCI spec, or else, it should be programming error. True when the the parameters come from a device model attempting to define a PCI device violating the spec.

[Qemu-devel] [PATCH] configure: Always compile with -fwrapv

QEMU's code relies on left shifts of signed integers always being defined behaviour with the obvious 2s-complement semantics. The only way to tell the compiler (and any associated undefined-behaviour sanitizer) that we require a C dialect with these semantics is to use the -fwrapv option. This is

Re: [Qemu-devel] [PATCH] scsi: mptsas: use g_new0 to allocate MPTSASRequest object

On 12/09/2016 14:44, P J P wrote: > From: Li Qiang > > When processing IO request in mptsas, it uses g_new to allocate > a 'req' object. If an error occurs before 'req->sreq' is > allocated, It could lead to an OOB write in mptsas_free_request > function. Use g_new0 to avoid

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: pass an error object to vfio_msix_early_setup

Eric Auger writes: > Let's expand the usage of QEMU Error objects to vfio_msix_early_setup. > > Signed-off-by: Eric Auger > --- > hw/vfio/pci.c | 28 > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 2/3] vfio/pci: pass an error object to vfio_populate_device

Eric Auger writes: > Let's expand the usage of QEMU Error objects to vfio_populate_device. > > Signed-off-by: Eric Auger > --- > hw/vfio/pci.c | 45 - > 1 file changed, 20 insertions(+), 25 deletions(-) >

Re: [Qemu-devel] Change the condition that permits to use device_del QOM-path on device? was (spapr: Gracefully fail CPU thread unplug)

On Thu, 18 Aug 2016 15:50:45 +0530 Bharata B Rao wrote: > On Thu, Aug 18, 2016 at 10:57:04AM +1000, David Gibson wrote: > > On Wed, Aug 17, 2016 at 07:31:38PM +0530, Bharata B Rao wrote: > > > sPAPR supports only Core level CPU plug and unplug, but nothing > > >

Re: [Qemu-devel] [v4 4/6] hw/iommu: AMD IOMMU interrupt remapping

On Mon, Sep 12, 2016 at 3:11 PM, Peter Xu wrote: > On Mon, Sep 12, 2016 at 02:51:27PM +0300, David Kiarie wrote: > > On Mon, Sep 12, 2016 at 2:34 PM, Peter Xu wrote: > > > > > On Mon, Sep 12, 2016 at 01:08:07PM +0300, David Kiarie wrote: > > > > > > [...] >

Re: [Qemu-devel] [PATCH 1/3] vfio/pci: conversion to realize

Eric Auger writes: > This patch converts VFIO PCI to realize function. > > Also original initfn errors now are propagated using QEMU > error objects. All errors are formatted with the same pattern: > "vfio: %s: the error description" Example: $ upstream-qemu -device

[Qemu-devel] [PATCH] scsi: mptsas: use g_new0 to allocate MPTSASRequest object

From: Li Qiang When processing IO request in mptsas, it uses g_new to allocate a 'req' object. If an error occurs before 'req->sreq' is allocated, It could lead to an OOB write in mptsas_free_request function. Use g_new0 to avoid it. Reported-by: Li Qiang

Re: [Qemu-devel] [PATCH v2 1/2] virtio: Add function to check whether backend supports VIRTIO_1

On Fri, 9 Sep 2016 15:10:06 +0200 Maxime Coquelin wrote: > This patch adds virtio_test_backend_virtio_1() function to > check whether backend supports VIRTIO_F_VERSION_1 before the > negociation takes place. s/negociation/negotiation/ > > Cc: Cornelia Huck

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

On Mon, 12 Sep 2016 15:33:53 +0800 Xiao Guangrong wrote: > On 08/12/2016 11:13 PM, Igor Mammedov wrote: > > >> > >> Reviewed-by: Stefan Hajnoczi > > I'd like to review it but I need to read NVDIMM/ACPI specs first > > to make sensible

[Qemu-devel] [Bug 1622547] Re: qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

Thanks a lot Artyom. -cpu "TI SuperSparc 50" does the job… This bug can be closed (sorry for the noise). ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [v4 4/6] hw/iommu: AMD IOMMU interrupt remapping

On Mon, Sep 12, 2016 at 02:51:27PM +0300, David Kiarie wrote: > On Mon, Sep 12, 2016 at 2:34 PM, Peter Xu wrote: > > > On Mon, Sep 12, 2016 at 01:08:07PM +0300, David Kiarie wrote: > > > > [...] > > > > > /* configure MMIO registers at startup/reset */ > > > static void

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

On Mon, 12 Sep 2016 11:18:52 +0200 Maxime Coquelin wrote: > On 09/12/2016 10:51 AM, Cornelia Huck wrote: > > On Sat, 10 Sep 2016 10:23:37 +0200 > > Maxime Coquelin wrote: > >> diff --git a/include/hw/virtio/virtio-bus.h > >>

Re: [Qemu-devel] [v4 1/6] hw/msi: Allow platform devices to use explicit SID

On Mon, Sep 12, 2016 at 02:26:14PM +0300, David Kiarie wrote: [...] > > > -int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev) > > > +int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev, > > uint16_t requester_id) > > > { > > > struct

Re: [Qemu-devel] [v4 4/6] hw/iommu: AMD IOMMU interrupt remapping

On Mon, Sep 12, 2016 at 2:34 PM, Peter Xu wrote: > On Mon, Sep 12, 2016 at 01:08:07PM +0300, David Kiarie wrote: > > [...] > > > /* configure MMIO registers at startup/reset */ > > static void amdvi_set_quad(AMDVIState *s, hwaddr addr, uint64_t val, > >

Re: [Qemu-devel] [PATCH v6 00/18] qapi: remove the 'middle' mode

Marc-André Lureau writes: > Hi, > > Although some QMP commands are still not fully qapi'fied, it is > possible to use more qapi common and generated code by dropping the > 'middle' mode and use qmp_dispatch(). Applied to qapi-next, thanks!

Re: [Qemu-devel] [PULL v2 00/14] virtio, vhost, pc: fixes and updates

On 9 September 2016 at 22:47, Michael S. Tsirkin wrote: > The following changes since commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf: > > Merge remote-tracking branch 'remotes/famz/tags/docker-pull-request' into > staging (2016-09-09 12:49:41 +0100) > > are available in the

Re: [Qemu-devel] [Bug 1622547] [NEW] qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

On Mon, Sep 12, 2016 at 12:13 PM, Mathieu Clabaut <1622...@bugs.launchpad.net> wrote: > Public bug reported: > > When trying to install Solaris 2.6 from original CDROM, qemu fail with > the following error : > > qemu: fatal: Trap 0x29 while interrupts disabled, Error state > pc: f0041280 npc:

Re: [Qemu-devel] [v4 4/6] hw/iommu: AMD IOMMU interrupt remapping

On Mon, Sep 12, 2016 at 01:08:07PM +0300, David Kiarie wrote: [...] > /* configure MMIO registers at startup/reset */ > static void amdvi_set_quad(AMDVIState *s, hwaddr addr, uint64_t val, > uint64_t romask, uint64_t w1cmask) > @@ -641,6 +667,11 @@ static void

Re: [Qemu-devel] [PATCH v6 14/18] tests: add a test to check invalid args

Marc-André Lureau writes: > Check that invalid args on commands without arguments returns an error. > > Signed-off-by: Marc-André Lureau > --- > tests/test-qga.c | 21 + > 1 file changed, 21 insertions(+) > > diff

[Qemu-devel] [PATCH 12/16] cpus-common: remove redundant call to exclusive_idle()

No need to call exclusive_idle() from cpu_exec_end since it is done immediately afterwards in cpu_exec_start. Any exclusive section could run as soon as cpu_exec_end leaves, because cpu->running is false and the mutex is not taken, so the call does not add any protection either. Signed-off-by:

[Qemu-devel] [PATCH 07/16] cpus-common: move CPU work item management to common code

From: Sergey Fedorov Make CPU work core functions common between system and user-mode emulation. User-mode does not use run_on_cpu, so do not implement it. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH 09/16] cpus-common: move exclusive work infrastructure from linux-user

This will serve as the base for async_safe_run_on_cpu. Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 17 --- cpus-common.c | 82 +++ cpus.c| 2

[Qemu-devel] [PATCH 06/16] cpus-common: move CPU list management to common code

Add a mutex for the CPU list to system emulation, as it will be used to manage safe work. Abstract manipulation of the CPU list in new functions cpu_list_add and cpu_list_remove. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- bsd-user/main.c

[Qemu-devel] [PULL] Update OpenBIOS images

Hi Peter, This update to OpenBIOS brings in several PPC updates, but more importantly brings in the CPU context rework code which I'd like to get in at the start of the 2.8 cycle to shake out any issues as early as possible. Please pull. ATB, Mark. The following changes since commit

[Qemu-devel] [PATCH 13/16] cpus-common: simplify locking for start_exclusive/end_exclusive

It is not necessary to hold qemu_cpu_list_mutex throughout the exclusive section, because no other exclusive section can run while pending_cpus != 0. exclusive_idle() is called in cpu_exec_start(), and that prevents any CPUs created after start_exclusive() from entering cpu_exec() during an

[Qemu-devel] [PATCH 01/16] cpus: pass CPUState to run_on_cpu helpers

From: Alex Bennée CPUState is a fairly common pointer to pass to these helpers. This means if you need other arguments for the async_run_on_cpu case you end up having to do a g_malloc to stuff additional data into the routine. For the current users this isn't a massive

Re: [Qemu-devel] [PATCH 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

On 09.09.2016 15:31, Denis V. Lunev wrote: They should work very similar, covering same areas if backing store is shorter than the image. This change is necessary for the followup patch switching to bdrv_get_block_status_above() in mirror to avoid assert in check_block. Signed-off-by: Denis V.

Re: [Qemu-devel] [v4 1/6] hw/msi: Allow platform devices to use explicit SID

On Mon, Sep 12, 2016 at 2:02 PM, Peter Xu wrote: > On Mon, Sep 12, 2016 at 01:08:04PM +0300, David Kiarie wrote: > > When using IOMMU platform devices like IOAPIC are required to make > > interrupt remapping requests using explicit SID.We affiliate an MSI > > route with a

[Qemu-devel] [PATCH 05/16] linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()

From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id:

[Qemu-devel] [PATCH 11/16] cpus-common: always defer async_run_on_cpu work items

async_run_on_cpu is only called from the I/O thread, not from CPU threads, so it doesn't make any difference. It will make a difference however for async_safe_run_on_cpu. Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini --- cpus-common.c | 5

[Qemu-devel] [PATCH 10/16] docs: include formal model for TCG exclusive sections

Signed-off-by: Paolo Bonzini --- docs/tcg-exclusive.promela | 176 + 1 file changed, 176 insertions(+) create mode 100644 docs/tcg-exclusive.promela diff --git a/docs/tcg-exclusive.promela b/docs/tcg-exclusive.promela new file

[Qemu-devel] [PATCH 14/16] cpus-common: Introduce async_safe_run_on_cpu()

Signed-off-by: Paolo Bonzini --- cpus-common.c | 25 +++-- include/qom/cpu.h | 11 +++ 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index 12c8e69..50a92dd 100644 --- a/cpus-common.c +++

[Qemu-devel] [PATCH 04/16] linux-user: Use QemuMutex and QemuCond

From: Sergey Fedorov Convert pthread_mutex_t and pthread_cond_t to QemuMutex and QemuCond. This will allow to make some locks and conditional variables common between user and system mode emulation. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey

[Qemu-devel] [PATCH 03/16] cpus: Rename flush_queued_work()

From: Sergey Fedorov To avoid possible confusion, rename flush_queued_work() to process_queued_cpu_work(). Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée

[Qemu-devel] [PATCH 15/16] tcg: Make tb_flush() thread safe

From: Sergey Fedorov Use async_safe_run_on_cpu() to make tb_flush() thread safe. This is possible now that code generation does not happen in the middle of execution. It can happen that multiple threads schedule a safe work to flush the translation buffer. To keep

[Qemu-devel] [PATCH 08/16] cpus-common: fix uninitialized variable use in run_on_cpu

Signed-off-by: Paolo Bonzini --- cpus-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus-common.c b/cpus-common.c index b98f548..cdfdb14 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -88,8 +88,7 @@ struct qemu_work_item { struct

[Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state

In addition to fixing some of the issues found by Alex, safe work items need not run anymore with a mutex taken. Of course, cpu_exec_start/end and start_exclusive/end_exclusive are essentially the read and write side of a specialized rwlock, so there is still a lock in disguise looming to cause

[Qemu-devel] [PATCH 02/16] cpus: Move common code out of {async_, }run_on_cpu()

From: Sergey Fedorov Move the code common between run_on_cpu() and async_run_on_cpu() into a new function queue_work_on_cpu(). Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée

Re: [Qemu-devel] [v4 2/6] hw/i386: enforce SID verification

On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote: [...] > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void *opaque, > hwaddr addr, > { > int ret = 0; > MSIMessage from = {}, to = {}; > -uint16_t sid = X86_IOMMU_SID_INVALID; > +VTDAddressSpace *as =

[Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

Set cpu->running without taking the cpu_list lock, only look at it if there is a concurrent exclusive section. This requires adding a new field to CPUState, which records whether a running CPU is being counted in pending_cpus. When an exclusive section is started concurrently with

Re: [Qemu-devel] [v4 2/6] hw/i386: enforce SID verification

On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote: > Platform devices are now able to make interrupt request with > explicit SIDs hence we can safely expect triggered AddressSpace ID > to match the requesting ID > > Signed-off-by: David Kiarie > --- >

Re: [Qemu-devel] [v4 2/6] hw/i386: enforce SID verification

On Mon, Sep 12, 2016 at 2:09 PM, Peter Xu wrote: > On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote: > > [...] > > > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void > *opaque, hwaddr addr, > > { > > int ret = 0; > > MSIMessage from = {},

[Qemu-devel] [PULL v1 1/3] crypto: ensure XTS is only used with ciphers with 16 byte blocks

The XTS cipher mode needs to be used with a cipher which has a block size of 16 bytes. If a mis-matching block size is used, the code will either corrupt memory beyond the IV array, or not fully encrypt/decrypt the IV. This fixes a memory corruption crash when attempting to use cast5-128 with

[Qemu-devel] [PULL v1 3/3] crypto: report enum strings instead of values in errors

Several error messages print out the raw enum value, which is less than helpful to users, as these values are not documented, nor stable across QEMU releases. Switch to use the enum string instead. The nettle impl also had two typos where it mistakenly said "algorithm" instead of "mode", and

[Qemu-devel] [PULL v1 2/3] crypto: fix building complaint

From: Gonglei gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to GNUTLS_VERSION_NUMBER. If using gnutls before that verion, we'll get the below warning: crypto/tlscredsx509.c:618:5: warning: "GNUTLS_VERSION_NUMBER" is not defined Because gnutls 3.x still

[Qemu-devel] [PULL v1 0/3] Merge qcrypto 2016/09/12

The following changes since commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf: Merge remote-tracking branch 'remotes/famz/tags/docker-pull-request' into staging (2016-09-09 12:49:41 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2016-09-12-1

[Qemu-devel] [PATCH 2/5] MAINTAINERS: update s390 machine file patterns

From: Sascha Silbe Some files used by s390 KVM code were missing in MAINTAINERS. Add them. Reported-by: Markus Armbruster Signed-off-by: Sascha Silbe Signed-off-by: Cornelia Huck --- MAINTAINERS

[Qemu-devel] [PATCH 3/5] virtio-ccw: respond to READ_STATUS command

From: Pierre Morel This patch adds the response to the READ_STATUS CCW command. Signed-off-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 20 hw/s390x/virtio-ccw.h

Re: [Qemu-devel] [v4 1/6] hw/msi: Allow platform devices to use explicit SID

On Mon, Sep 12, 2016 at 01:08:04PM +0300, David Kiarie wrote: > When using IOMMU platform devices like IOAPIC are required to make > interrupt remapping requests using explicit SID.We affiliate an MSI > route with a requester ID and a PCI device if present which ensures > that platform devices can

[Qemu-devel] [PATCH 5/5] QMP: fixup typos and whitespace damage

From: Christian Borntraeger Fixup some typos and whitespace damage introduced by the CPU model patches for s390. Reported-by: Eric Blake Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck

[Qemu-devel] [PATCH 4/5] virtio-ccw: set revision 2 as maximal revision number

From: Pierre Morel We have everything needed for virtio-ccw revision 2 wired up now. Bump the maximum supported revision reported on a device basis to the guest so they can make use of it. Signed-off-by: Pierre Morel Signed-off-by: Cornelia

[Qemu-devel] [PATCH 1/5] s390x/kvm: disable cpu model for the 2.7 machine

From: Christian Borntraeger cpu model was merged with 2.8, it is wrong to abuse ri_allowed which was enabled with 2.7. Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c

[Qemu-devel] [PATCH 0/5] s390x enhancements and fixes

Here are some s390x patches that have accumulated at my end: - fixup for the cpu model patches - support for READ_STATUS, which has been accepted into the upcoming virtio 1.1 standard - update MAINTAINERS file pattern Christian Borntraeger (2): s390x/kvm: disable cpu model for the 2.7 machine

[Qemu-devel] [Bug 1622547] [NEW] qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

Public bug reported: When trying to install Solaris 2.6 from original CDROM, qemu fail with the following error : qemu: fatal: Trap 0x29 while interrupts disabled, Error state pc: f0041280 npc: f0041284 %g0-7: f0281800 0800 f0243b88 0001 f0244020 %o0-7:

[Qemu-devel] [v4 2/6] hw/i386: enforce SID verification

Platform devices are now able to make interrupt request with explicit SIDs hence we can safely expect triggered AddressSpace ID to match the requesting ID Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 77 ++- 1

[Qemu-devel] [v4 4/6] hw/iommu: AMD IOMMU interrupt remapping

Introduce AMD IOMMU interrupt remapping and hook it onto the existing interrupt remapping infrastructure Signed-off-by: David Kiarie --- hw/i386/amd_iommu.c | 240 +++- hw/i386/amd_iommu.h | 4 +- hw/intc/ioapic.c|

[Qemu-devel] [v4 1/6] hw/msi: Allow platform devices to use explicit SID

When using IOMMU platform devices like IOAPIC are required to make interrupt remapping requests using explicit SID.We affiliate an MSI route with a requester ID and a PCI device if present which ensures that platform devices can call IOMMU interrupt remapping code with explicit SID while

[Qemu-devel] [v4 5/6] hw/acpi: report IOAPIC on IVRS

Report IOAPIC via IVRS which effectively allows linux AMD-Vi driver to enable interrupt remapping Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index c20bc71..c9bee8f

[Qemu-devel] [v4 6/6] hw/iommu: share common code between IOMMUs

Enabling interrupt remapping with kernel_irqchip=on should result in an error for both VT-d and AMD-Vi Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 9 - hw/i386/x86-iommu.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [v4 0/6] AMD IOMMU Interrupt remapping

Hello, This patchset adds AMD IOMMU interrupt remapping logic to Qemu. I have made some changes to the way X86 Qemu manages MSI routes. The current code assumes that MSI routes are affiliated to a PCI device which will not always be the case with split irqchip. With split irqchip platform

[Qemu-devel] [v4 3/6] hw/iommu: Prepare for AMD IOMMU interrupt remapping

Introduce macros and trace events for use in AMD IOMMU interrupt remapping Signed-off-by: David Kiarie --- hw/i386/amd_iommu.h | 80 hw/i386/trace-events | 7 + 2 files changed, 87 insertions(+) diff --git

Re: [Qemu-devel] KVM call for agenda for 2016-09-13

Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. Hi Kindly remind if you have any topic for Tomorrow. Thanks, Juan. > >

[Qemu-devel] [PATCH v6 17/18] qmp-commands.hx: fix some styling

Add some missing lines, remove superflous @ in command name, remove trailing spaces. Signed-off-by: Marc-André Lureau --- qmp-commands.hx | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/qmp-commands.hx

[Qemu-devel] [PATCHv2 1/8] tests: cris: force inlining

From: Rabin Vincent The CRIS tests expect that functions marked inline are always inline. With newer versions of GCC, building them results warnings like the following and spurious failures when they are run. In file included from tests/tcg/cris/check_moveq.c:5:0:

[Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch()

Replace the old manual dispatch and validation code by the generic one provided by qapi common code. Note that it is now possible to call the following commands that used to be disabled by compile-time conditionals: - dump-skeys - query-spice - rtc-reset-reinjection - query-gic-capabilities

Re: [Qemu-devel] [PATCH 2/3] virtio: add virtqueue_rewind()

On Thu, Sep 08, 2016 at 09:30:13AM +0200, Ladi Prosek wrote: > On Thu, Sep 8, 2016 at 8:44 AM, Roman Kagan wrote: > > On Wed, Sep 07, 2016 at 05:20:48PM +0200, Ladi Prosek wrote: > >> From: Stefan Hajnoczi > >> > >> virtqueue_discard() requires a

[Qemu-devel] [PATCH v6 13/18] qapi: check invalid arguments on no-args commands

The generated marshal functions do not visit arguments from commands that take no arguments. Thus they fail to catch invalid members. Visit the arguments, if provided, to throw an error in case of invalid members. Currently, qmp_check_client_args() checks for invalid arguments and correctly

[Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt

The only remaining function of qmp-commands.hx is to let us generate qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt. We intend to move the documentation into the QAPI schema and generate qapi-commands.txt from it, but not right now. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v6 14/18] tests: add a test to check invalid args

Check that invalid args on commands without arguments returns an error. Signed-off-by: Marc-André Lureau --- tests/test-qga.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index 21f44f8..40af649 100644

[Qemu-devel] [PATCH v6 10/18] monitor: implement 'qmp_query_commands' without qmp_cmds

One step towards getting rid of the static qmp_cmds table. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- monitor.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH v6 11/18] monitor: remove mhandler.cmd_new

This is no longer necessary now that we aren't using middle mode anymore. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- monitor.c | 13 +-- docs/writing-qmp-commands.txt | 4 +- hmp-commands-info.hx

[Qemu-devel] issues about igd-passthrough using vfio-pci

Hello， I have realized the IGD passthrough with Intel(R) Core(TM) i7-4770 CPU，but when I change the platform with the Intel Core i3-6100U，it doesn’t have any VGA output and windows7 refuses to boot with black screen. This problem has been bothering me for a long time,someone can help me?

[Qemu-devel] [PATCH v6 12/18] qapi: remove the "middle" mode

Now that the register function is always generated, we can remove the so-called "middle" mode from the generator script. Signed-off-by: Marc-André Lureau --- scripts/qapi-commands.py | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v6 07/18] qmp: Hack to keep commands configuration-specific

We currently define QMP commands in two places: the QAPI schema and qmp-commands.hx. The latter is preprocessed, the former is not. We use the preprocessor to suppress configuration-specific commands. For instance, query-spice is only available #ifdef CONFIG_SPICE. QMP command dispatch and

[Qemu-devel] [PATCH v6 06/18] qapi: Support unregistering QMP commands

From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- qapi/qmp-registry.c | 8 include/qapi/qmp/dispatch.h | 1 + 2 files changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH v6 16/18] build-sys: remove qmp-commands-old.h

Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- Makefile.target | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Makefile.target b/Makefile.target index 8c7a072..19cc49c 100644 --- a/Makefile.target +++

[Qemu-devel] [PATCH v6 08/18] qapi: export the marshallers

Make it possible to call marshallers manually, without going through qmp_dispatch(). (this is currently only possible in middle-mode, but it's also useful in general) Signed-off-by: Marc-André Lureau --- scripts/qapi-commands.py | 8 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v6 09/18] monitor: use qmp_find_command() (using generated qapi code)

Stop using the so-called 'middle' mode. Instead, use qmp_find_command() from generated qapi commands registry. Update and fix the documentation too. Signed-off-by: Marc-André Lureau --- monitor.c | 14 ++-- vl.c | 1 +

[Qemu-devel] [PATCH v6 04/18] monitor: simplify invalid_qmp_mode()

handle_qmp_command() will switch to use qmp_dispatch(). It won't have a pointer to the marshaller function anymore, but only the name of the command to invoke. Simplify invalid_qmp_mode() so it can just be called with the command name. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v6 05/18] monitor: register gen:false commands manually

Since a few commands are using 'gen': false, they are not registered automatically by the generator. Register manually instead. This is in preparation for removal of qapi 'middle' mode generation. Note that qmp_init_marshal() function isn't run yet, so the commands aren't actually registered,

[Qemu-devel] [PATCH v6 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

There are better chances to find what went wrong at build time than a later assert in qmp_query_version Signed-off-by: Marc-André Lureau --- qmp.c | 16 +++- scripts/create_config | 6 ++ 2 files changed, 9 insertions(+), 13

[Qemu-devel] [PATCH v6 02/18] qapi-schema: use generated marshaller for 'qmp_capabilities'

qapi'fy the 'qmp_capabilities' command, makes the command visible in query-qmp-schema. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- monitor.c| 4 ++-- qapi-schema.json |

[Qemu-devel] [PATCH v6 00/18] qapi: remove the 'middle' mode

Hi, Although some QMP commands are still not fully qapi'fied, it is possible to use more qapi common and generated code by dropping the 'middle' mode and use qmp_dispatch(). v6: - get back to v4 approach, and unregister commands at run-time. (Markus Armbruster) - comments and commit messages

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

On 09/12/2016 10:51 AM, Cornelia Huck wrote: On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings.

[Qemu-devel] [PATCH v6 03/18] qapi-schema: add 'device_add'

Even though device_add is not fully qapi'fied, we may add it to the json schema with 'gen': false, so registration and documentation can be generated. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qapi-schema.json | 40

Re: [Qemu-devel] [PATCH RFC 3/4] target-ppc: use atomic_cmpxchg for ld/st reservation

On Mon, 2016-09-12 at 09:39 +0100, Alex Bennée wrote: >  > They are now in Richard's tcg-next queue > > Message-Id: <1473282648-23487-1-git-send-email-...@twiddle.net> > Subject: [Qemu-devel] [PULL 00/18] tcg queued patches > > All the backends support the new fence op, so far only ARM, Alpha

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > need to rewind some settings. > > This is the case for CCW, for which a

Re: [Qemu-devel] [PATCH RFC 3/4] target-ppc: use atomic_cmpxchg for ld/st reservation

David Gibson writes: > On Wed, Sep 07, 2016 at 08:13:31AM +0100, Alex Bennée wrote: >> >> David Gibson writes: >> >> > On Wed, Sep 07, 2016 at 10:17:42AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

On Mon, 12 Sep 2016 11:27:57 +1000 David Gibson wrote: > On Fri, Sep 09, 2016 at 02:31:55PM +0200, Laurent Vivier wrote: > > > > > > On 09/09/2016 14:25, Greg Kurz wrote: > > > On Thu, 8 Sep 2016 09:50:31 +0200 > > > Laurent Vivier wrote: > >

Re: [Qemu-devel] [PATCH v4 0/4] Introduce error_report_{fatal|abort}

"Daniel P. Berrange" writes: > On Fri, Sep 09, 2016 at 07:05:04PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > v4 changes: >> > - remove two standard headers since they are included in osdep.h >> > already [Fam] >> > - make sure it

<    1   2   3   4   >