[Qemu-devel] [PATCH 7/7] block: rename "read-only" to BDRV_OPT_READ_ONLY

2016-09-14 Thread Alberto Garcia
There were a few instances left. After this patch we're using the macro in all places. Signed-off-by: Alberto Garcia --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 3036af4..6db2c53 100644 ---

Re: [Qemu-devel] [PATCH v3 25/34] tests: add atomic_add-bench

2016-09-14 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > With this microbenchmark we can measure the overhead of emulating atomic > instructions with a configurable degree of contention. > > The benchmark spawns $n threads, each performing $o atomic ops

[Qemu-devel] [PATCH 2/2] aio: improve aio_poll performance by checking epoll only once

2016-09-14 Thread Yaowei Bai
As epoll whether enabled or not is a global setting, we can just check it only once rather than checking it with every node iteration. Through this we can avoid a lot of checks when epoll is not enabled. Signed-off-by: Yaowei Bai Reviewed-by: Xiubo Li

Re: [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps

2016-09-14 Thread Hans-Peter Nilsson
> Date: Tue, 13 Sep 2016 00:59:51 +0200 > From: "Edgar E. Iglesias" > > @@ -3336,12 +3336,20 @@ void cris_cpu_dump_state(CPUState *cs, FILE *f, > > fprintf_function cpu_fprintf, > > { > > CRISCPU *cpu = CRIS_CPU(cs); > > CPUCRISState *env = >env; > > +

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-14 Thread Daniel P. Berrange
On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 14, 2016 at 04:32:44PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 14, 2016 at 02:23:14PM +0100, Daniel P. Berrange wrote: > > > > On

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 16:08, Eduardo Habkost wrote: >> > If attacker can trigger things, IOW execute code in hypervisor, >> > then encrypting memory is not useful anyway. > I believe the whole point of SEV attestation and key management > is to make "if attacker can executed code in hypervisor, >

[Qemu-devel] [Bug 1536487] Re: Unable to migrate pc-i440fx-2.4 KVM guest from QEMU 2.5.0 to QEMU 2.4.1

2016-09-14 Thread Paolo Bonzini
> Especially I found that the "created on Trusty, migrated to xenial > (works), but later migrated back to trusty (fails)" seems affected by > it as well. The first migration of the t->x->t sequence does not really matter (if anything it could introduce _more_ bugs!), so if x->t is not supported

Re: [Qemu-devel] [PATCH V2 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-14 Thread Wei Huang
On 09/14/2016 03:17 AM, Andrew Jones wrote: > On Wed, Sep 14, 2016 at 02:09:02AM -0400, Wei Huang wrote: >> This patch adds a pmu=[on/off] option to enable/disable vPMU support >> in guest VM. The pmu option is available only for cortex-a57/cortex-53/ >> host under both TCG and KVM modes.

[Qemu-devel] [PATCH v4 07/11] linux-user: Fix syslog() syscall support

2016-09-14 Thread Aleksandar Markovic
From: Aleksandar Markovic There are currently several problems related to syslog() support. For example, if the second argument "bufp" of target syslog() syscall is NULL, the current implementation always returns error code EFAULT. However, NULL is a perfectly

[Qemu-devel] [PATCH v4 09/11] linux-user: Improve braces-related formatting in linux-user/main.c

2016-09-14 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch removes all braces-related errors (reported by checkpatch.pl) from linux-user/main.c. Signed-off-by: Aleksandar Markovic --- linux-user/main.c | 188

[Qemu-devel] [PATCH 4/7] block: Add "read-only" to the options QDict

2016-09-14 Thread Alberto Garcia
This adds the "read-only" option to the QDict. One important effect of this change is that when a child inherits options from its parent, the existing "read-only" mode can be preserved if it was explicitly set previously. This addresses scenarios like this: [E] <- [D] <- [C] <- [B] <- [A] In

[Qemu-devel] [PATCH 0/7] Add "read-only" to the options QDict

2016-09-14 Thread Alberto Garcia
This series adds "read-only" to the options QDict, fixing a long-standing problem with the reopening code. [E] <- [D] <- [C] <- [B] <- [A] In a normal scenario, the active layer [A] is in read-write mode and everything else is read-only. If we reopen [D] in read-write mode and later reopen

Re: [Qemu-devel] [PATCH v11 1/6] qdict: implement a qdict_crumple method for un-flattening a dict

2016-09-14 Thread Kevin Wolf
Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > The qdict_flatten() method will take a dict whose elements are > further nested dicts/lists and flatten them by concatenating > keys. > > The qdict_crumple() method aims to do the reverse, taking a flat > qdict, and turning it into a

Re: [Qemu-devel] [PATCH v4 0/3] block: Fix libbz2 library dependency regresssion

2016-09-14 Thread Stefan Hajnoczi
On Mon, Sep 05, 2016 at 10:50:42AM +0800, Fam Zheng wrote: > v4: Remove unused variable in patch 1 and unwanted warning in patch 2. [Max] > > v3: Fix typo in copyright header. [Max] > Fix pre-existing type casting. [Max] > > v2: Rebase on top of Max's block-next tree, which has Colin's

Re: [Qemu-devel] [PATCH STABLE 2.5] vnc: fix VNC websockets TLS handshake

2016-09-14 Thread Daniel P. Berrange
ping Is qemu-stable dead for the 2.5 branch or was this just missed ? On Tue, Jun 07, 2016 at 03:17:33PM +0100, Daniel P. Berrange wrote: > If the VNC websockets TLS handshake blocked, we register a > callback to continue it after the socket signals data is > available. Unfortunately we were

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-14 Thread Daniel P. Berrange
On Wed, Sep 14, 2016 at 05:48:17PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 03:15:07PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 14, 2016 at 04:50:51PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 14, 2016 at 02:37:49PM +0100, Daniel P. Berrange wrote: > > > > On

[Qemu-devel] [PATCH v4 02/11] linux-user: Add support for clock_adjtime() syscall

2016-09-14 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch implements Qemu user mode clock_adjtime() syscall support. The implementation is based on invocation of host's clock_adjtime(), and is very similar to the implementation of adjtimex() syscall support. The main difference is

[Qemu-devel] [PATCH v4 06/11] linux-user: Fix socketcall() syscall support

2016-09-14 Thread Aleksandar Markovic
From: Aleksandar Markovic do_socketcall() function in Qemu's syscalls.c is implemented to mirror corespondant implementation of socketcall() in Linux kernel. (see kernel source file net/socket.c, definition of socketcall). However, error codes are wrong for the

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-14 Thread Michael S. Tsirkin
On Wed, Sep 14, 2016 at 10:51:59AM -0300, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 04:14:58PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 14, 2016 at 03:01:51PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 14/09/2016 14:09, Eduardo Habkost wrote: > > > > On Wed, Sep 14, 2016 at

[Qemu-devel] [PULL v5 02/18] tcg: Merge GETPC and GETRA

2016-09-14 Thread Richard Henderson
The return address argument to the softmmu template helpers was confused. In the legacy case, we wanted to indicate that there is no return address, and so passed in NULL. However, we then immediately subtracted GETPC_ADJ from NULL, resulting in a non-zero value, indicating the presence of an

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-14 Thread Daniel P. Berrange
On Wed, Sep 14, 2016 at 11:10:54AM -0500, Brijesh Singh wrote: > > I am open to idea and need direction on which way to go. I will work on > documenting the parameters and usages. Should I consider implementing your > below approach in v2 ? > > -object >

Re: [Qemu-devel] [RFC PATCH v1 21/22] hw: add pre and post system reset callback

2016-09-14 Thread Brijesh Singh
Hi Paolo, On 09/13/2016 05:47 PM, Paolo Bonzini wrote: On 13/09/2016 16:50, Brijesh Singh wrote: This patch adds methods to register a callback in qemu_system_reset(). - qemu_register_pre_reset() : function will be called just after entering into qemu_system_reset(). -

[Qemu-devel] [PULL v5 14/18] target-alpha: Generate fence op

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-13-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL v5 17/18] target-i386: Generate fences for x86

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-15-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- target-i386/translate.c | 8 1 file changed, 8 insertions(+) diff --git

[Qemu-devel] [PULL v5 04/18] Introduce TCGOpcode for memory barrier

2016-09-14 Thread Richard Henderson
From: Pranith Kumar This commit introduces the TCGOpcode for memory barrier instruction. This opcode takes an argument which is the type of memory barrier which should be generated. Signed-off-by: Pranith Kumar Message-Id:

[Qemu-devel] [PULL 01/18] block: Hide HBitmap in block dirty bitmap interface

2016-09-14 Thread Max Reitz
From: Fam Zheng HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the

[Qemu-devel] [PULL 10/18] block: More operations for meta dirty bitmap

2016-09-14 Thread Max Reitz
From: Fam Zheng Callers can create an iterator of meta bitmap with bdrv_dirty_meta_iter_new(), then use the bdrv_dirty_iter_* operations on it. Meta iterators are also counted by bitmap->active_iterators. Also add a couple of functions to retrieve granularity and count.

[Qemu-devel] [PULL 14/18] blockdev: Add dynamic generation of module_block.h

2016-09-14 Thread Max Reitz
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí

[Qemu-devel] [PULL 16/18] blockdev: Modularize nfs block driver

2016-09-14 Thread Max Reitz
From: Colin Lord Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi Message-id: 1471008424-16465-5-git-send-email-cl...@redhat.com Reviewed-by: Max Reitz

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 17:02, Michael S. Tsirkin wrote: > If you believe there are attackers that have access to the > monitor and nothing else, then a feature to disable debugging > is a generally useful one. But once we merge sev patchset then of course > sev people disappear and it will be up to

Re: [Qemu-devel] [PATCH v1] log: fix parsing of multiple trace:PATTERN log args

2016-09-14 Thread Paolo Bonzini
On 06/09/2016 20:25, Daniel P. Berrange wrote: > If giving QEMU a log arg which asks to enable multiple > different trace event patterns such as > > $QEMU -d trace:qio*,trace:qcrypto* > > the parser will then invoke > > trace_enable_events("qio*,trace:qcrypto*") >

[Qemu-devel] [PATCH v2 6/6] trace: use -1 instead of TRACE_VCPU_EVENT_COUNT as magic value

2016-09-14 Thread Daniel P. Berrange
The TraceEvent struct vcpu_id field uses the constant TRACE_VCPU_EVENT_COUNT as a magic value to indicate this is not a per-VCPU event. The max count value will be different for each event group though, so this is no longer suitable. Instead use the value (size_t)-1 which is guaranteed to be

[Qemu-devel] [PATCH 0/4] Move some trace events to the correct files

2016-09-14 Thread Daniel P. Berrange
When I split up the monolithic trace-events file, a few events ended up in incorrect files, partly due to incorrect file name annotations against the events, partly due to my mistakes. These patches were previously posted as part of my giant series, but since they're trivial I figure they can be

[Qemu-devel] [PATCH v2 0/6] Prep changes for modular trace-events build

2016-09-14 Thread Daniel P. Berrange
These patches were previously posted as part of my giant trace events modular build series https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg01714.html I'm not ready to repost the entire series, but I figure these 6 preparatory changes can be usefully reviewed and potentially merged on

[Qemu-devel] [PULL v5 08/18] tcg/ia64: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Cc: Aurelien Jarno Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-6-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.inc.c | 5 + 1 file

[Qemu-devel] [PULL v5 13/18] tcg/tci: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Cc: Stefan Weil Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-11-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.inc.c | 3 +++ tci.c

[Qemu-devel] [PULL v5 09/18] tcg/mips: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-7-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.inc.c | 30 ++ 1 file changed, 30

[Qemu-devel] [PULL v5 01/18] tcg: Support arbitrary size + alignment

2016-09-14 Thread Richard Henderson
Previously we allowed fully unaligned operations, but not operations that are aligned but with less alignment than the operation size. In addition, arm32, ia64, mips, and sparc had been omitted from the previous overalignment patch, which would have led to that alignment being enforced.

[Qemu-devel] [PULL 03/18] tests: Add test code for meta bitmap

2016-09-14 Thread Max Reitz
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id: 1470096763-14033-4-git-send-email-js...@redhat.com Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH v3 27/34] target-arm: emulate LL/SC using cmpxchg helpers

2016-09-14 Thread Richard Henderson
On 09/14/2016 09:03 AM, Alex Bennée wrote: >> > -/* Load/Store exclusive instructions are implemented by remembering >> > - the value/address loaded, and seeing if these are the same >> > - when the store is performed. This should be sufficient to implement >> > - the architecturally

[Qemu-devel] [PULL 08/18] block: BdrvDirtyBitmap serialization interface

2016-09-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy [Add the "finish" parameters. - Fam] Signed-off-by: Fam Zheng

[Qemu-devel] [PULL 17/18] commit: get the overlay node before manipulating the backing chain

2016-09-14 Thread Max Reitz
From: Alberto Garcia The 'block-commit' command has a 'top' parameter to specify the topmost node from which the data is going to be copied. [E] <- [D] <- [C] <- [B] <- [A] In this case if [C] is the top node then this is the result: [E] <- [B] <- [A] [B] must be

[Qemu-devel] [PATCH v2 3/6] trace: remove some now unused functions

2016-09-14 Thread Daniel P. Berrange
The trace_event_count, trace_event_id and trace_event_pattern methods are no longer required now that everything is using the iterator APIs The trace_event_set_state and trace_event_set_vcpu_state macros were also unused. Signed-off-by: Daniel P. Berrange ---

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-14 Thread Eduardo Habkost
On Wed, Sep 14, 2016 at 06:46:20PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2016 at 04:06:33PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 14, 2016 at 05:48:17PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 14, 2016 at 03:15:07PM +0100, Daniel P. Berrange wrote: > > > > On

[Qemu-devel] [PATCH 5/7] block: Don't queue the same BDS twice in bdrv_reopen_queue_child()

2016-09-14 Thread Alberto Garcia
bdrv_reopen_queue_child() assumes that a BlockDriverState is never added twice to BlockReopenQueue. That's however not the case: commit_start() adds 'base' (and its children) to a new reopen queue, and then 'overlay_bs' (and its children, which include 'base') to the same queue. The effect of

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-14 Thread Michael S. Tsirkin
On Wed, Sep 14, 2016 at 11:10:54AM -0500, Brijesh Singh wrote: > > > > Various commands and parameters are documented [1] > > > > > > [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf > > > > If I understand correctly, the docs describe the firmware > > interface. The interface

[Qemu-devel] [PULL v5 05/18] tcg/i386: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Generate a 'lock orl $0,0(%esp)' instruction for ordering instead of mfence which has similar ordering semantics. Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-3-bobby.pr...@gmail.com> Signed-off-by: Richard

[Qemu-devel] [PULL v5 03/18] cpu-exec: Check -dfilter for -d cpu

2016-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpu-exec.c b/cpu-exec.c index 5d9710a..e7f851c 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -147,7 +147,8 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState

[Qemu-devel] [PULL v5 06/18] tcg/aarch64: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Cc: Claudio Fontana Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-4-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 22

[Qemu-devel] [PULL 07/18] hbitmap: serialization

2016-09-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions

[Qemu-devel] [PULL 11/18] qemu-img: add the 'dd' subcommand

2016-09-14 Thread Max Reitz
From: Reda Sallahi This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The

[Qemu-devel] [PULL 15/18] blockdev: Add dynamic module loading for block drivers

2016-09-14 Thread Max Reitz
From: Marc Mari Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition,

Re: [Qemu-devel] [PATCH 1/7] block: Remove bdrv_is_snapshot

2016-09-14 Thread Kevin Wolf
Am 14.09.2016 um 17:52 hat Alberto Garcia geschrieben: > This is unnecessary and has been unused since 5433c24f0f9306c82ad9bcc. > > Signed-off-by: Alberto Garcia Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL 18/18] iotest 055: refactor and speed up

2016-09-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. Test disk filling patterns are merged into one pattern. Also TestSetSpeed used different image_len for source and

[Qemu-devel] [PATCH 2/4] trace: move util/qemu-coroutine*.c trace points into correct file

2016-09-14 Thread Daniel P. Berrange
The trace points for util/qemu-coroutine*.c were mistakenly left in the top level trace-events file, instead of util/trace-events in commit 492bb2dd651e780c0723580880acbedb5661e5ad Author: Daniel P. Berrange Date: Thu Jun 16 09:39:48 2016 +0100 trace: split out

Re: [Qemu-devel] [PATCH 1/7] block: Remove bdrv_is_snapshot

2016-09-14 Thread Eric Blake
On 09/14/2016 10:52 AM, Alberto Garcia wrote: > This is unnecessary and has been unused since 5433c24f0f9306c82ad9bcc. > > Signed-off-by: Alberto Garcia > --- > block.c | 5 - > include/block/block.h | 1 - > 2 files changed, 6 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state

2016-09-14 Thread Richard Henderson
On 09/12/2016 04:12 AM, Paolo Bonzini wrote: > In addition to fixing some of the issues found by Alex, safe work items > need not run anymore with a mutex taken. Of course, cpu_exec_start/end > and start_exclusive/end_exclusive are essentially the read and write > side of a specialized rwlock, so

Re: [Qemu-devel] [PATCH v3 28/34] target-arm: emulate SWP with atomic_xchg helper

2016-09-14 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > Message-Id: <1467054136-10430-25-git-send-email-c...@braap.org> > Signed-off-by: Richard Henderson > --- > target-arm/translate.c | 25

[Qemu-devel] [PULL v5 10/18] tcg/ppc: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-8-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 21 + 1 file changed, 21 insertions(+)

[Qemu-devel] [PULL v5 11/18] tcg/s390: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Cc: Alexander Graf Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-9-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 11 +++ 1 file

[Qemu-devel] [PULL v5 12/18] tcg/sparc: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-10-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.inc.c | 13 + 1 file changed, 13 insertions(+)

[Qemu-devel] [PULL 04/18] block: Support meta dirty bitmap

2016-09-14 Thread Max Reitz
From: Fam Zheng The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id:

[Qemu-devel] [PULL 13/18] blockdev: prepare iSCSI block driver for dynamic loading

2016-09-14 Thread Max Reitz
From: Colin Lord This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng Reviewed-by:

[Qemu-devel] [PULL 12/18] qemu-img: add skip option to dd

2016-09-14 Thread Max Reitz
From: Reda Sallahi This adds the skip option which allows qemu-img dd to skip a number of blocks before copying the input. A test case was added to test the skip option. Signed-off-by: Reda Sallahi Message-id:

Re: [Qemu-devel] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common()

2016-09-14 Thread Kevin Wolf
Am 14.09.2016 um 17:52 hat Alberto Garcia geschrieben: > We're only doing this immediately before opening the image, but > bs->open_flags is used earlier in the function. At the moment this is > not causing problems because none of the checked flags are modified by > update_flags_from_options(),

[Qemu-devel] [PATCH v2 1/6] trace: add trace event iterator APIs

2016-09-14 Thread Daniel P. Berrange
Currently methods which want to iterate over trace events, do so using the trace_event_count() and trace_event_id() methods. This leaks the concept of a single ID enum to the callers. There is an alternative trace_event_pattern() method which can be used in an iteration context, but its design is

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-14 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: >> +## vCPU >> + >> +# Create a new virtual (guest) CPU >> +# >> +# Targets: all >> +guest_cpu_init(void *cpu) "cpu=%p" > This isn't a vcpu trace event. Please add keep it with the other > non-vcpu trace

Re: [Qemu-devel] [PATCH v3 27/34] target-arm: emulate LL/SC using cmpxchg helpers

2016-09-14 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Emulating LL/SC with cmpxchg is not correct, since it can > suffer from the ABA problem. Portable parallel code, however, > is written assuming only cmpxchg--and not LL/SC--is available. > This means that

[Qemu-devel] [PULL v5 18/18] tcg: Optimize fence instructions

2016-09-14 Thread Richard Henderson
From: Pranith Kumar This commit optimizes fence instructions. Two optimizations are currently implemented: (1) unnecessary duplicate fence instructions, and (2) merging weaker fences into a stronger fence. [rth: Merge tcg_optimize_mb back into tcg_optimize, so that we

Re: [Qemu-devel] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

2016-09-14 Thread Kevin Wolf
Am 14.09.2016 um 17:52 hat Alberto Garcia geschrieben: > If an image is opened with snapshot=on, its flags are modified by > bdrv_backing_options() and then bs->open_flags is updated accordingly. > This last step is unnecessary if we calculate the new flags before > setting bs->open_flags. > >

[Qemu-devel] [PULL 06/18] block: Assert that bdrv_release_dirty_bitmap succeeded

2016-09-14 Thread Max Reitz
From: Fam Zheng We use a loop over bs->dirty_bitmaps to make sure the caller is only releasing a bitmap owned by bs. Let's also assert that in this case the caller is releasing a bitmap that does exist. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 2/2] aio: improve aio_poll performance by checking epoll only once

2016-09-14 Thread Stefan Hajnoczi
On Wed, Sep 14, 2016 at 07:03:39AM -0400, Yaowei Bai wrote: > As epoll whether enabled or not is a global setting, we can just > check it only once rather than checking it with every node iteration. > Through this we can avoid a lot of checks when epoll is not enabled. > > Signed-off-by: Yaowei

[Qemu-devel] [PULL 02/18] HBitmap: Introduce "meta" bitmap to track bit changes

2016-09-14 Thread Max Reitz
From: Fam Zheng Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng [Amended text inline. --js] Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id:

[Qemu-devel] [PATCH 3/4] trace: move hw/mem/pc-dimm.c trace points into correct file

2016-09-14 Thread Daniel P. Berrange
The trace points for hw/mem/pc-dimm.c were mistakenly put in the hw/i386/trace-events file, instead of hw/mem/trace-events in commit 5eb76e480b42206d3640c1aab8a376ba350f70bb Author: Daniel P. Berrange Date: Thu Jun 16 09:40:10 2016 +0100 trace: split out trace

[Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-14 Thread Daniel P. Berrange
Since there will shortly be multiple event groups allowed, we can no longer use the TraceEventID and TraceEventVCPUID enums in the trace control APIs. There will in fact be multiple distinct enums, and the enum values will only be required to be unique per group. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH 1/4] trace: move util/buffer.c trace points into correct file

2016-09-14 Thread Daniel P. Berrange
The trace points for util/buffer.c were mistakenly put in the io/trace-events file, instead of util/trace-events in commit 892bd32ea38bbe9709ff0b6db3053bdf06eec9fb Author: Daniel P. Berrange Date: Thu Jun 16 09:39:50 2016 +0100 trace: split out trace events for

[Qemu-devel] [Bug 1615823] Re: Windows 10 reports no compatible TPM found yet device manager shows it?

2016-09-14 Thread Markus Heberling
I have the same problem with Windows 10 Enterprise running under qemu-2.5.0-9.fc23.1.tpmfix (which is the qemu version containing the fix you mentioned above.) on fedora 23. The same qemu version runs windows 7 enterprise with TPM just fine. So there seems to be some change in the way Windows uses

[Qemu-devel] [PATCH 4/4] trace: move hw/virtio/virtio-balloon.c trace points into correct file

2016-09-14 Thread Daniel P. Berrange
The trace points for hw/virtio/virtio-balloon.c were mistakenly put in the top level trace-events file, instead of util/trace-events in commit 270ab88f7c1112389a02cee0e3e03b20fcc7547e Author: Daniel P. Berrange Date: Thu Jun 16 09:39:57 2016 +0100 trace: split

[Qemu-devel] [PATCH v2 4/6] trace: remove global 'uint16 dstate[]' array

2016-09-14 Thread Daniel P. Berrange
Instead of having a global dstate array, declare a single 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each trace event. Record a pointer to this variable in the TraceEvent struct too. By turning trace_event_get_state_dynamic_by_id into a macro, this still hits the fast path, and cache

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-14 Thread Brijesh Singh
Various commands and parameters are documented [1] [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf If I understand correctly, the docs describe the firmware interface. The interface provided by QEMU is not the same thing, and needs to be documented as well (even if it

[Qemu-devel] [PULL v5 07/18] tcg/arm: Add support for fence

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-5-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson

[Qemu-devel] [PULL v5 00/18] tcg queued patches

2016-09-14 Thread Richard Henderson
ches-fetch' into staging (2016-09-13 17:55:35 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20160914 for you to fetch changes up to ff95d7e000739149237d201037d5918439e69626: tcg: Optimize fence instructions (2016-09-13 19:1

[Qemu-devel] [PULL v5 15/18] target-arm: Generate fences in ARMv7 frontend

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-12-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- target-arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL v5 16/18] target-aarch64: Generate fences for aarch64

2016-09-14 Thread Richard Henderson
From: Pranith Kumar Signed-off-by: Pranith Kumar Message-Id: <20160714202026.9727-14-bobby.pr...@gmail.com> Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 27 ++- 1 file changed, 26

[Qemu-devel] [PULL 09/18] tests: Add test code for hbitmap serialization

2016-09-14 Thread Max Reitz
From: Fam Zheng Signed-off-by: Fam Zheng [Fixed minor constant issue. --js] Signed-off-by: John Snow Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id:

Re: [Qemu-devel] [PATCH 1/2] block: mirror: fix wrong comment of mirror_start

2016-09-14 Thread Eric Blake
On 09/14/2016 06:03 AM, Yaowei Bai wrote: > Obviously, we should write to '@target'. > > Signed-off-by: Yaowei Bai > Reviewed-by: Xiubo Li > --- > include/block/block_int.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Qemu-devel] [PATCH v2 2/6] trace: convert code to use event iterators

2016-09-14 Thread Daniel P. Berrange
This converts the HMP/QMP monitor API implementations and some internal trace control methods to use the new trace event iterator APIs. Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- monitor.c | 16 ++ trace/control.c

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-14 Thread Eduardo Habkost
On Wed, Sep 14, 2016 at 07:10:50PM +0300, Michael S. Tsirkin wrote: [...] > > > > >> Frankly I don't understand why do you need to mess with boot at all. > > > > >> Quoting the cover letter: > > > > >> > > > > >> SEV is designed to protect guest VMs from a benign but > > > > >> vulnerable >

Re: [Qemu-devel] [PATCH 0/4] Move some trace events to the correct files

2016-09-14 Thread Eric Blake
On 09/14/2016 12:03 PM, Daniel P. Berrange wrote: > When I split up the monolithic trace-events file, a few > events ended up in incorrect files, partly due to incorrect > file name annotations against the events, partly due to my > mistakes. > > These patches were previously posted as part of my

Re: [Qemu-devel] [RFC PATCH v1 13/22] hmp: update 'info kvm' to display SEV status

2016-09-14 Thread Brijesh Singh
Hi Eric, Thanks for feedback. # @present: true if KVM acceleration is built into this executable # +# @sev: true if SEV is active Worth expanding what the acronym stands for. Also needs a '(since 2.8)' designator. will fix in v2. +# # Since: 0.14.0 ## -{ 'struct': 'KvmInfo', 'data':

[Qemu-devel] [PULL 00/18] Block layer patches

2016-09-14 Thread Max Reitz
The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2016-09-13 17:55:35 +0100) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2016-09-14

[Qemu-devel] [PULL 05/18] block: Add two dirty bitmap getters

2016-09-14 Thread Max Reitz
From: Fam Zheng For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: John Snow Message-id:

[Qemu-devel] [PATCH v6] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-14 Thread Ashijeet Acharya
Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as deprecated. Move max-bandwidth and downtime-limit into migrate-set-parameters for setting maximum migration speed and expected downtime limit parameters respectively. Change downtime units to milliseconds (only for

[Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF

2016-09-14 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- hw/scsi/spapr_vscsi.c | 89 +-- hw/scsi/trace-events | 27 2 files changed, 63 insertions(+), 53 deletions(-) diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index

Re: [Qemu-devel] [PATCH v4 00/11] linux user: Fix assorted Qemu user mode issues

2016-09-14 Thread Peter Maydell
On 14 September 2016 at 16:21, Aleksandar Markovic wrote: > This series fix certain Qemu user mode issues. The fixes mainly originate > from observation of LTP tests failures for execution in Qemu user mode > on various platforms. The series also contains four

[Qemu-devel] [Bug 1310324] Re: Commit 0f842f8a introduces regression when using tcg-interpreter

2016-09-14 Thread T. Huth
The fix mentioned in comment #4 has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7e4e88656c1e6192e9e47 ==> Setting status to "Fix released". ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of

Re: [Qemu-devel] [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

2016-09-14 Thread Jeff Cody
On Wed, Sep 14, 2016 at 06:52:15PM +0300, Alberto Garcia wrote: > If an image is opened with snapshot=on, its flags are modified by > bdrv_backing_options() and then bs->open_flags is updated accordingly. > This last step is unnecessary if we calculate the new flags before > setting

Re: [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF

2016-09-14 Thread Eric Blake
On 09/14/2016 01:48 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > hw/ppc/spapr_drc.c | 54 > - > hw/ppc/trace-events | 22 ++ > 2 files changed, 42 insertions(+), 34 deletions(-) >

Re: [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF

2016-09-14 Thread Eric Blake
On 09/14/2016 01:48 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > hw/ppc/spapr_rtas.c | 30 -- > hw/ppc/trace-events | 9 + > 2 files changed, 17 insertions(+), 22 deletions(-) > > +++ b/hw/ppc/trace-events > @@ -57,6

[Qemu-devel] [PATCH v7 1/2] libs/gnttab: introduce grant copy interface

2016-09-14 Thread Paulina Szubarczyk
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is invoked. In mini-os the operation is yet not implemented. For the OSs that does not implement gnttab the call of the grant copy operation causes abort. Signed-off-by: Paulina Szubarczyk

<    1   2   3   4   5   >