[Qemu-devel] [PATCH] qemu-char: avoid segfault if user lacks of permisson of a given logfile

2016-09-14 Thread Lin Ma
Function qemu_chr_alloc returns NULL if it failed to open logfile by any reason, says no write permission. For backends tty, stdio and msmouse, They need to check this return value to avoid segfault in this case. Signed-off-by: Lin Ma --- backends/msmouse.c | 3 +++ qemu-char.c

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-14 Thread Peter Xu
On Wed, Sep 14, 2016 at 03:55:28PM +1000, David Gibson wrote: [...] > > -static void vtd_iommu_notify_started(MemoryRegion *iommu) > > +static void vtd_iommu_notify_flag_changed(MemoryRegion *iommu, > > + IOMMUNotifierFlag old, > > +

Re: [Qemu-devel] [PATCH v2] curl: Operate on zero-length file

2016-09-14 Thread Michael Tokarev
08.07.2016 14:18, Tomáš Golembiovský wrote: Another attempt to fix the bug 1596870. When creating new disk backed by remote file accessed via HTTPS and the backing file has zero length, qemu-img terminates with uniformative error message: qemu-img: disk.qcow2: CURL: Error opening file:

Re: [Qemu-devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-09-14 Thread Michael Tokarev
23.03.2016 21:32, Md Haris Iqbal wrote: Signed-off-by: Md Haris Iqbal --- linux-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 26b0ba2..3c3fd15 100644 --- a/linux-user/qemu.h +++

[Qemu-devel] [PATCH V2 0/2] Add option to configure guest vPMU

2016-09-14 Thread Wei Huang
This patchset adds a pmu=[on/off] option to enable/disable vPMU support for guest VM. There are several reasons to justify this option. First, vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an option to

[Qemu-devel] [PATCH V2 2/2] arm: virt: add PMU property to machvirt machine type

2016-09-14 Thread Wei Huang
CPU vPMU is now turned off by default, but it was ON in virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned on in virt-2.7 machine type to make sure it

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-14 Thread Michael Tokarev
29.07.2016 14:05, Cao jin wrote: Cc: Paolo Bonzini Cc: Peter Maydell Cc Peter Crosthwaite Cc: Richard Henderson Cao jin (3): timer: update comments cpus: rename local variable to meaningful

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-14 Thread Cao jin
Hi Michael, I saw Paolo already queued these 3 into his branch and sent the pull request. Cao jin On 09/14/2016 02:47 PM, Michael Tokarev wrote: 29.07.2016 14:05, Cao jin wrote: Cc: Paolo Bonzini Cc: Peter Maydell Cc Peter Crosthwaite

Re: [Qemu-devel] [PATCH 0/7] Remove useless casts

2016-09-14 Thread Michael Tokarev
15.06.2016 19:14, Laurent Vivier wrote: This series is the result of the following coccinelle script: @@ type T; T v; @@ - (T *) + This script removes the cast of a variable when the variable is already of the casting type. The script is added in

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-14 Thread David Gibson
On Wed, Sep 14, 2016 at 03:12:43PM +0800, Peter Xu wrote: > On Wed, Sep 14, 2016 at 03:55:28PM +1000, David Gibson wrote: > > [...] > > > > -static void vtd_iommu_notify_started(MemoryRegion *iommu) > > > +static void vtd_iommu_notify_flag_changed(MemoryRegion *iommu, > > > +

Re: [Qemu-devel] [PATCH v4 3/3] intel_iommu: allow UNMAP notifiers

2016-09-14 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:44AM +0800, Peter Xu wrote: > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > Before that is achieved, let's open a door for vhost DMAR support, which > only requires cache invalidations (UNMAP operations). > > Meanwhile, converting hw_error()

[Qemu-devel] [PATCH v4 3/3] target-ppc: tlbie/tlbivax should have global effect

2016-09-14 Thread Nikunj A Dadhania
tlbie (BookS) and tlbivax (BookE) plus the H_CALLs(pseries) should have a global effect. Introduces TLB_NEED_GLOBAL_FLUSH flag. During lazy tlb flush, after taking care of pending local flushes, check broadcast flush(at context synchronizing event ptesync/tlbsync, etc) is needed. Depending on the

[Qemu-devel] [PATCH V2 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-14 Thread Wei Huang
This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest VM. The pmu option is available only for cortex-a57/cortex-53/ host under both TCG and KVM modes. Additionally pmu can only be turned on under KVM mode, otherwise a warning message will be printed out (e.g. "-M

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-14 Thread Michael Tokarev
14.09.2016 09:54, Cao jin wrote: Hi Michael, I saw Paolo already queued these 3 into his branch and sent the pull request. That's okay, git figure it out. Thank you for notifying me. /mjt

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-14 Thread David Gibson
On Wed, Sep 14, 2016 at 03:48:32PM +1000, David Gibson wrote: > On Fri, Sep 09, 2016 at 10:57:42AM +0800, Peter Xu wrote: > > IOMMU Notifier list is used for notifying IO address mapping changes. > > Currently VFIO is the only user. > > > > However it is possible that future consumer like vhost

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-14 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:42AM +0800, Peter Xu wrote: > IOMMU Notifier list is used for notifying IO address mapping changes. > Currently VFIO is the only user. > > However it is possible that future consumer like vhost would like to > only listen to part of its notifications (e.g., cache

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-14 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:43AM +0800, Peter Xu wrote: > The new interface can be used to replace the old notify_started() and > notify_stopped(). Meanwhile it provides explicit flags so that IOMMUs > can know what kind of notifications it is requested for. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v3] help: Update help to remove misleading display information

2016-09-14 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH trivial] Remove unused function declarations

2016-09-14 Thread Michael Tokarev
13.06.2016 17:20, Ladi Prosek wrote: Unused function declarations were found using a simple gcc plugin and manually verified by grepping the sources. Applied to -trivial, thank you! Verified it all, too. /mjt

Re: [Qemu-devel] [PATCH] win32: don't run subprocess tests on Mingw32 platform

2016-09-14 Thread Michael Tokarev
14.06.2016 19:00, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 04:44:57PM +0100, Daniel P. Berrange wrote: The g_test_trap_subprocess() method does not work on the Mingw32 platform, causing the test-qdev-global-props test case to abort (test-logging.exe:230): GLib-ERROR **:

Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-09-14 Thread Michael Tokarev
03.05.2016 04:10, Christopher Friedt wrote: Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build for a few reasons. One of those reasons is that Apple's ld (at least ld64) does not properly process archive files created with ar (even Apple's ar). After some RTFM'ing, I

[Qemu-devel] [PULL 5/5] usb-mtp: added object properties

2016-09-14 Thread Gerd Hoffmann
From: Isaac Lozano <109loza...@gmail.com> Windows uses object properties to determine the size of a file, so to add object properties, we must also add a minimum set of new commands and object properties. Most object properties are data that we already have, except for the unique persistant

[Qemu-devel] [PULL 0/5] usb: large file support for mtp, bugfixes.

2016-09-14 Thread Gerd Hoffmann
/tags/qemu-openbios-signed' into staging (2016-09-12 15:09:47 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20160914-1 for you to fetch changes up to 67f3ef0c7a149a4e92b877375f771e065ae58651: usb-mtp: added object properties (2016-09-14 11:17:06 +0200

[Qemu-devel] [PULL 1/5] xhci: Fix remainder field for TR_SETUP completion event.

2016-09-14 Thread Gerd Hoffmann
From: Hans Petter Selasky Previously the code would incorrectly report the remainder as 8 bytes. A remainder of 0 bytes should be reported when the SETUP packet is successfully transferred. Found using FreeBSD's XHCI driver. Signed-off-by: Hans Petter Selasky

[Qemu-devel] [PULL 2/5] usb-host: fix streams detection in usb_host_speed_compat

2016-09-14 Thread Gerd Hoffmann
The companion descriptor is present on all usb3 devices, not only those with streams support. We need to check attributes to see whenever the device uses streams or not. Signed-off-by: Gerd Hoffmann Message-id: 1473406890-30164-1-git-send-email-kra...@redhat.com ---

[Qemu-devel] [PULL 3/5] usb:xhci:fix memory leak in usb_xhci_exit

2016-09-14 Thread Gerd Hoffmann
From: Li Qiang If the xhci uses msix, it doesn't free the corresponding memory, thus leading a memory leak. This patch avoid this. Signed-off-by: Li Qiang Message-id: 57d7d2e0.d4301c0a.d13e9.9...@mx.google.com Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

2016-09-14 Thread Alexey Kardashevskiy
On 14/09/16 09:29, Michael Roth wrote: > Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) >> This adds a numa id property to a PHB to allow linking passed PCI device >> to CPU/memory. It is up to the management stack to do CPU/memory pinning >> to the node with the actual PCI device. > > It

[Qemu-devel] [PULL 4/5] usb-mtp: fix sending files larger than 4gb

2016-09-14 Thread Gerd Hoffmann
From: Isaac Lozano <109loza...@gmail.com> MTP requires that if a file is larger than 4gb or if sending data larger than 4gb, that the length field be set to 0x. Also widened a couple variables to prevent overflow errors. Signed-off-by: Isaac Lozano <109loza...@gmail.com> Message-id:

[Qemu-devel] [Bug 1536487] Re: Unable to migrate pc-i440fx-2.4 KVM guest from QEMU 2.5.0 to QEMU 2.4.1

2016-09-14 Thread ChristianEhrhardt
** Also affects: qemu (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu Xenial) Status: New => Triaged ** Changed in: qemu (Ubuntu Xenial) Importance: Undecided => High ** Changed in: qemu (Ubuntu) Status: Triaged => Fix Released -- You

[Qemu-devel] [PATCH v2] scsi: pvscsi: limit process IO loop to ring size

2016-09-14 Thread P J P
From: Prasad J Pandit Vmware Paravirtual SCSI emulator while processing IO requests could run into an infinite loop if 'pvscsi_ring_pop_req_descr' always returned positive value. Limit IO loop to the ring size. Reported-by: Li Qiang Signed-off-by:

[Qemu-devel] [PATCH] target-i386: fix ordering of fields in CPUX86State

2016-09-14 Thread Paolo Bonzini
Make sure reset zeroes TSC_AUX, XCR0, PKRU. Move XSTATE_BV from the "vmstate only" section to the "KVM only" section. Signed-off-by: Paolo Bonzini --- target-i386/cpu.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.h

[Qemu-devel] [PATCH 3/3] target-arm: cache most tbflags

2016-09-14 Thread Paolo Bonzini
Finally, this patch makes most flags static. The only remaining dynamic flags (only used in aarch32 mode) are for Thumb mode and conditional execution. These are modified more often than the others, and are cheap therefore they are looked up directly from env on every TB lookup. Signed-off-by:

[Qemu-devel] [PATCH 1/3] target-arm: introduce cpu_dynamic_tb_cpu_flags

2016-09-14 Thread Paolo Bonzini
For now, this just moves computation of the TranslationBlock flags to a separate function. Later on, dynamic flags will be distinct from static flags in that static flags need not be recomputed on every TranslationBlock lookup; hence the name of the function. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 0/3] target-arm: cache tbflags in CPUARMState

2016-09-14 Thread Paolo Bonzini
Computing TranslationBlock flags is pretty expensive on ARM, especially 32-bit. Because tbflags are computed on every tb lookup, it is not unlikely to see cpu_get_tb_cpu_state close to the top of the profile now that QHT makes the hash table much more efficient. However, most tbflags only change

Re: [Qemu-devel] [PATCH v2] scsi: pvscsi: limit process IO loop to ring size

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 11:39, P J P wrote: > From: Prasad J Pandit > > Vmware Paravirtual SCSI emulator while processing IO requests > could run into an infinite loop if 'pvscsi_ring_pop_req_descr' > always returned positive value. Limit IO loop to the ring size. > >

[Qemu-devel] [PATCH 0/2] pc: fixes broken compat logic

2016-09-14 Thread Igor Mammedov
fixes mistakes made by: targte-i386: Add virtual L3 cache support https://www.mail-archive.com/qemu-devel@nongnu.org/msg395418.html Igor Mammedov (2): pc: fix regression introduced by adding 2.8 machine target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

[Qemu-devel] [PATCH 2/3] target-arm: add env->tbflags

2016-09-14 Thread Paolo Bonzini
Computing TranslationBlock flags is pretty expensive on ARM, especially 32-bit. In order to limit the cost we want to cache as many of them as possible. Therefore, the flags are split in two parts. Static flags come directly from a new CPUARMState field env->tbflags, and are updated whenever EL

[Qemu-devel] [PATCH] bt-hci-csr: drop unused argument

2016-09-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/nseries.c | 3 +-- hw/bt/hci-csr.c | 2 +- include/hw/bt.h | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index fea911e..c86cf80 100644 --- a/hw/arm/nseries.c +++

[Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-14 Thread Igor Mammedov
commit (a4d3c834 pc: Add 2.8 machine) didn't ammend PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in {\ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value= "on",\ }, and {\ .driver = TYPE_X86_CPU,\ .property =

[Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

2016-09-14 Thread Igor Mammedov
commit (14c985cff target-i386: present virtual L3 cache info for vcpus) misplaced compat property putting it in new 2.8 machine type which would effectively to disable feature until 2.9 is released. Intent of commit probably should be to disable feature for 2.7 and older while allowing not yet

Re: [Qemu-devel] [PATCH] memory: remove memory_region_destructor_rom_device

2016-09-14 Thread Igor Mammedov
On Wed, 14 Sep 2016 11:06:34 +0200 Paolo Bonzini wrote: > It is equivalent to memory_region_destructor_ram, use that one. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > memory.c | 6 +- > 1 file changed,

Re: [Qemu-devel] [PATCH v3 15/34] tcg: Add CONFIG_ATOMIC64

2016-09-14 Thread Alex Bennée
Richard Henderson writes: > Allow qemu to build on 32-bit hosts without 64-bit atomic ops. > > Even if we only allow 32-bit hosts to multi-thread emulate 32-bit > guests, we still need some way to handle the 32-bit guest using a > 64-bit atomic operation. Do so by dropping

Re: [Qemu-devel] [PATCH] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

2016-09-14 Thread Michael Tokarev
Is this (quite old) patch still relevant? Thanks, /mjt 05.03.2016 16:47, Wei Yang wrote: According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. This patch takes this change and also move them all in header

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-14 Thread Peter Xu
On Wed, Sep 14, 2016 at 05:22:40PM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 03:12:43PM +0800, Peter Xu wrote: > > On Wed, Sep 14, 2016 at 03:55:28PM +1000, David Gibson wrote: > > > > [...] > > > > > > -static void vtd_iommu_notify_started(MemoryRegion *iommu) > > > > +static void

[Qemu-devel] [PATCH v3 6/8] megasas: remove unnecessary megasas_use_msix()

2016-09-14 Thread Cao jin
CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/scsi/megasas.c | 21 +++--

[Qemu-devel] [PATCH v3 0/8] Convert msix_init() to error

2016-09-14 Thread Cao jin
v3 changelog: 1. withdraw the patch "msix_init: assert programming error", set error in the main patch "Convert msix_init to Error..." 2. separate 3 new from main patch as per comments: patch 2,4,5 3. a new patch 8 CC: Jiri Pirko CC: Gerd Hoffmann CC:

[Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-09-14 Thread Cao jin
The corresponding msi flag is already dropped in commit 1070048e. CC: Dmitry Fleytman CC: Jason Wang CC: Michael S. Tsirkin CC: Markus Armbruster CC: Marcel Apfelbaum Signed-off-by: Cao jin

[Qemu-devel] [PULL 18/27] curl: Operate on zero-length file

2016-09-14 Thread Michael Tokarev
From: Tomáš Golembiovský Another attempt to fix the bug 1596870. When creating new disk backed by remote file accessed via HTTPS and the backing file has zero length, qemu-img terminates with uniformative error message: qemu-img: disk.qcow2: CURL: Error opening file:

[Qemu-devel] [PULL 25/27] win32: don't run subprocess tests on Mingw32 platform

2016-09-14 Thread Michael Tokarev
From: Eduardo Habkost On Tue, Jun 14, 2016 at 04:44:57PM +0100, Daniel P. Berrange wrote: > The g_test_trap_subprocess() method does not work on the > Mingw32 platform, causing the test-qdev-global-props > test case to abort > > (test-logging.exe:230): GLib-ERROR **:

[Qemu-devel] [PULL 14/27] timer: update comments

2016-09-14 Thread Michael Tokarev
From: Cao jin The comments is outdated. The patch has following changes: 1. tense correction. 2. all clock time value is returned in nanoseconds, so, they are same in precision. 3. virtual clock doesn't use cpu cycles. Cc: Paolo Bonzini Cc: Peter

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-14 Thread Peter Xu
On Wed, Sep 14, 2016 at 05:15:03PM +1000, David Gibson wrote: [...] > Peter suggested commenting this next to the IOTLBEntry definition, and > I think that's probably ok for now. Looks like we have something already (just not that obvious): /** * memory_region_notify_iommu: notify a change in

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-14 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 08:36:25PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > I previously split the global trace-events file up into one file > >> > per-subdirectory to

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-14 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 07:00:44PM -0300, Eduardo Habkost wrote: > (CCing Daniel Berrange in case he has feedback on the > nonce/dh_pub_qx/dh_pub_qy loading/parsing at the end of this > message) > > On Tue, Sep 13, 2016 at 02:54:40PM -0500, Brijesh Singh wrote: > > Hi Eduardo, > > > > On

[Qemu-devel] [PATCH v5 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-14 Thread Peter Xu
IOMMU Notifier list is used for notifying IO address mapping changes. Currently VFIO is the only user. However it is possible that future consumer like vhost would like to only listen to part of its notifications (e.g., cache invalidations). This patch introduced IOMMUNotifier and

[Qemu-devel] [PULL 05/27] MAINTAINERS: Add include/hw/tricore/ to TriCore section

2016-09-14 Thread Michael Tokarev
From: Thomas Huth get_maintainer.pl now properly recognizes that the file in include/hw/tricore/ belongs to TriCore. Signed-off-by: Thomas Huth Reviewed-by: Bastian Koppelmann Signed-off-by: Michael Tokarev

[Qemu-devel] [PULL 16/27] cpus: update comments

2016-09-14 Thread Michael Tokarev
From: Cao jin The returned value of cpu_get_clock() is plused with the offset, so it is the time elapsed in virtual machine when vm is active. Cc: Paolo Bonzini Cc Peter Crosthwaite Cc: Richard Henderson

[Qemu-devel] [PULL 19/27] coccinelle: add a script to remove useless casts

2016-09-14 Thread Michael Tokarev
From: Laurent Vivier Script from LKML. Signed-off-by: Laurent Vivier Signed-off-by: Michael Tokarev --- scripts/coccinelle/typecast.cocci | 7 +++ 1 file changed, 7 insertions(+) create mode 100644

Re: [Qemu-devel] [RFC/PATCH] migration: SMRAM dirty bitmap not fetched from kvm-kmod and not send to destination

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 09:55, Herongguang (Stephen) wrote: > Hi, > We found a problem that when a redhat 6 VM reboots (in grub countdown > UI), migrating this VM will result in VM’s memory difference between > source and destination side. The difference always resides in GPA > 0xA~0xC, i.e. SMRAM

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 3/3] tests: add RTAS command in the protocol

2016-09-14 Thread Greg Kurz
On Wed, 14 Sep 2016 13:22:40 +1000 David Gibson wrote: > On Tue, Sep 13, 2016 at 02:52:45PM +0200, Laurent Vivier wrote: > > Add a first test to validate the protocol: > > > > - rtas/get-time-of-day compares the time > > from the guest with the time from the host.

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 0/3] tests: add RTAS protocol

2016-09-14 Thread Greg Kurz
On Wed, 14 Sep 2016 13:23:37 +1000 David Gibson wrote: > On Tue, Sep 13, 2016 at 02:52:42PM +0200, Laurent Vivier wrote: > > This series allows to call RTAS commands from the qtest framework, > > and defines a first test to call RTAS command "get-time-of-day" > > to

[Qemu-devel] [PATCH] memory: remove memory_region_destructor_rom_device

2016-09-14 Thread Paolo Bonzini
It is equivalent to memory_region_destructor_ram, use that one. Signed-off-by: Paolo Bonzini --- memory.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/memory.c b/memory.c index 0eb6895..5ed3872 100644 --- a/memory.c +++ b/memory.c @@ -943,10

Re: [Qemu-devel] [RFC PATCH v1 05/22] i386: add new option to enable SEV guest

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 10:41, Daniel P. Berrange wrote: >> > Any reason not to pass the sev options themselves through -sev? You can >> > then use "-readconfig sev-guest.cfg" where sev-guest.cfg contains >> > >> >[sev] >> >type="encrypted" >> >flags = "" >> >policy = "00"

[Qemu-devel] [PATCH RFC] pci: call PCIDeviceClass->exit on its .realize failure

2016-09-14 Thread Cao jin
It cannot guarantee all pci devices will free the allocated resource in its .realize function on realize failure. CC: Michael S. Tsirkin CC: Marcel Apfelbaum Signed-off-by: Cao jin --- I found not all the devices will free the

[Qemu-devel] [PULL 15/27] cpus: rename local variable to meaningful one

2016-09-14 Thread Michael Tokarev
From: Cao jin The function actually returns monotonic time value in nanosecond, the "ticks" is not suitable. Cc: Paolo Bonzini Cc Peter Crosthwaite Cc: Richard Henderson Signed-off-by: Cao jin

[Qemu-devel] [PULL 11/27] sh4: fix broken link to documentation

2016-09-14 Thread Michael Tokarev
From: Reda Sallahi The page that was previously linked in the source code and the README file is no longer available so it now returns a 404 error message. This puts a previous snapshot from archive.org instead. Signed-off-by: Reda Sallahi Acked-by:

[Qemu-devel] [PULL 12/27] help: Update help to remove misleading display information

2016-09-14 Thread Michael Tokarev
From: Colin Lord Updates the help messages to remove misleading information about SDL being the normal display used. Signed-off-by: Colin Lord Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev ---

[Qemu-devel] [PULL 17/27] Remove unused function declarations

2016-09-14 Thread Michael Tokarev
From: Ladi Prosek Unused function declarations were found using a simple gcc plugin and manually verified by grepping the sources. Signed-off-by: Ladi Prosek Signed-off-by: Michael Tokarev --- block/qcow2.h | 1 -

[Qemu-devel] [PULL 24/27] sheepdog: remove useless casts

2016-09-14 Thread Michael Tokarev
From: Laurent Vivier This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Hitoshi Mitake CC: qemu-bl...@nongnu.org Signed-off-by: Laurent Vivier Reviewed-by: Hitoshi Mitake

Re: [Qemu-devel] [Qemu-trivial] [PATCH 6/7] crypto: remove useless casts

2016-09-14 Thread Michael Tokarev
15.06.2016 19:14, Laurent Vivier пишет: This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Daniel P. Berrange Signed-off-by: Laurent Vivier --- crypto/cipher-builtin.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-14 Thread Peter Xu
On Wed, Sep 14, 2016 at 05:15:03PM +1000, David Gibson wrote: [...] > > > @@ -1564,8 +1569,22 @@ void > > > memory_region_unregister_iommu_notifier(MemoryRegion *mr, Notifier *n) > > > void memory_region_notify_iommu(MemoryRegion *mr, > > > IOMMUTLBEntry entry)

[Qemu-devel] [PATCH v3 7/8] megasas: undo the overwrites of msi user configuration

2016-09-14 Thread Cao jin
Commit afea4e14 seems forgetting to undo the overwrites, which is unsuitable. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao

[Qemu-devel] [PATCH v3 5/8] hcd-xhci: change behaviour of msix switch

2016-09-14 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. CC: Gerd Hoffmann CC: Michael S. Tsirkin CC: Markus Armbruster CC: Marcel Apfelbaum Signed-off-by: Cao

Re: [Qemu-devel] [PATCH v9 02/13] mptsas: change .realize function name

2016-09-14 Thread Michael Tokarev
20.06.2016 09:13, Cao jin wrote: All the other devices` .realize function name are xxx_realize, except this one. Applied to -trivial, thanks! /mjt cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Markus Armbruster

[Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error and fix callers to check it

2016-09-14 Thread Cao jin
msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. For some devices(like e1000e, vmxnet3) who won't fail because of msix_init's failure, suppress the error report by passing NULL error object.

[Qemu-devel] [PATCH v3 4/8] megasas: change behaviour of msix switch

2016-09-14 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. Also undo the overwrites of user configuration of msix. CC: Michael S. Tsirkin CC: Hannes Reinecke CC: Paolo Bonzini CC:

[Qemu-devel] [PULL 00/27] Trivial patches for 2016-09-14

2016-09-14 Thread Michael Tokarev
This is a backlog of all trivial patches accumulated since Jul this year. Not a huge amount for more than a month. Please consider applying. Thanks, /mjt The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: Merge remote-tracking branch

[Qemu-devel] [PULL 09/27] MAINTAINERS: Add some header files to the PC chipset section

2016-09-14 Thread Michael Tokarev
From: Thomas Huth These header files obviously belong to the PC chipset (since their names match the other .c files in this section). Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 4 1 file changed, 4

[Qemu-devel] [PULL 06/27] MAINTAINERS: Add include/hw/sh4/ to SH4 section

2016-09-14 Thread Michael Tokarev
From: Thomas Huth get_maintainer.pl now properly recognizes that the files in include/hw/sh4/ belong to SH4. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v3 2/8] hcd-xhci: check & correct param before using it

2016-09-14 Thread Cao jin
Param checking/correcting code of xchi->numintrs should be placed before it is used. Also move some resource-alloc code down, save the strenth to free them on msi_init's failure. CC: Gerd Hoffmann CC: Markus Armbruster CC: Marcel Apfelbaum

[Qemu-devel] [PULL 02/27] tcg: Remove duplicate header includes

2016-09-14 Thread Michael Tokarev
From: Thomas Huth host-utils.h and timer.h are included twice in tcg.c. One time should be enough. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- tcg/tcg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tcg/tcg.c

[Qemu-devel] [PULL 13/27] ivshmem: Delete duplicate debug message

2016-09-14 Thread Michael Tokarev
From: Stefano Dong (董兴水) Duplicated in commit ca0b756. Delete it. Signed-off-by: Stefano Dong (董兴水) Reviewed-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-14 Thread Ashijeet Acharya
On Wed, Sep 14, 2016 at 12:52 AM, Eric Blake wrote: > On 09/09/2016 02:02 PM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. > > Maybe s/old-commands for speed and downtime/the old commands > 'migrate_set_speed' and 'migrate_set_downtime'/ >

Re: [Qemu-devel] [PATCH V2 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-14 Thread Andrew Jones
On Wed, Sep 14, 2016 at 02:09:02AM -0400, Wei Huang wrote: > This patch adds a pmu=[on/off] option to enable/disable vPMU support > in guest VM. The pmu option is available only for cortex-a57/cortex-53/ > host under both TCG and KVM modes. Additionally pmu can only be turned > on under KVM mode,

[Qemu-devel] [PULL 03/27] ui/console: Fix non-working backspace key in monitor of gtk UI

2016-09-14 Thread Michael Tokarev
From: Thomas Huth In the QEMU monitor pane of the gtk user interface, the backspace key is not working at all. This happens because of a missing mapping of the key in the qcode_to_keysym[] table. Thus let's add an entry there to get the backspace key working again. Buglink:

[Qemu-devel] [PATCH v5 0/3] Introduce IOMMUNotifier struct

2016-09-14 Thread Peter Xu
(Note: we still have pending discussions on how IOMMU notifier interface should be, assuming that is not a blocker for posting v5 of this one) V5: - squash spapr_tce_notify_{started|stopped} into spapr_tce_notify_flag_changed [David] - in spapr_tce_notify_flag_changed: check flags against "!=

Re: [Qemu-devel] [RFC PATCH v1 05/22] i386: add new option to enable SEV guest

2016-09-14 Thread Daniel P. Berrange
On Wed, Sep 14, 2016 at 12:41:59AM +0200, Paolo Bonzini wrote: > > > On 13/09/2016 16:47, Brijesh Singh wrote: > > The patch adds '-sev' option to enable the Secure Encrypted > > Virtualization (SEV) guest. If this option is specified, Qemu > > assumes that user wants to launch this guest into

Re: [Qemu-devel] [PATCH V2 2/2] arm: virt: add PMU property to machvirt machine type

2016-09-14 Thread Andrew Jones
On Wed, Sep 14, 2016 at 02:09:03AM -0400, Wei Huang wrote: > CPU vPMU is now turned off by default, but it was ON in virt-2.7 > machine type. To solve this problem, this patch adds a PMU option > in machine state, which is used to control CPU's vPMU status. This > PMU option is not exposed to

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-14 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 10:47:47AM -0400, Brijesh Singh wrote: > This patch adds the initial support required to integrate Secure > Encrypted Virtualization feature, the patch include the following > changes: > > - adds sev.c and sev.h files: the file will contain SEV APIs implemention. > - add

Re: [Qemu-devel] [PATCH V2 2/2] arm: virt: add PMU property to machvirt machine type

2016-09-14 Thread Andrew Jones
On Wed, Sep 14, 2016 at 10:37:19AM +0200, Andrew Jones wrote: > On Wed, Sep 14, 2016 at 02:09:03AM -0400, Wei Huang wrote: > > CPU vPMU is now turned off by default, but it was ON in virt-2.7 > > machine type. To solve this problem, this patch adds a PMU option > > in machine state, which is used

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 03:11, Richard Henderson wrote: > On 09/13/2016 04:21 PM, Paolo Bonzini wrote: >> >> >> On 13/09/2016 22:57, Richard Henderson wrote: >>> -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && >>> defined(__SSE2__)) >>> -#include >>> - >>> +#if (defined(CONFIG_AVX2_OPT) &&

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 04:33, Michael S. Tsirkin wrote: > Frankly I don't understand why do you need to mess with boot at all. > Quoting the cover letter: > > SEV is designed to protect guest VMs from a benign but vulnerable > (i.e. not fully malicious) hypervisor. In particular, it reduces

Re: [Qemu-devel] [PATCH] hw/timer/imx_gpt: Properly mask control register on software reset

2016-09-14 Thread Michael Tokarev
07.08.2016 09:50, Donny Yang wrote: Signed-off-by: Donny Yang --- hw/timer/imx_gpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c index 82bc73c..02d875f 100644 --- a/hw/timer/imx_gpt.c +++ b/hw/timer/imx_gpt.c @@

[Qemu-devel] [PATCH v3 1/8] msix: Follow CODING_STYLE

2016-09-14 Thread Cao jin
CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/pci/msix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c

[Qemu-devel] [PULL 22/27] tricore: remove useless cast

2016-09-14 Thread Michael Tokarev
From: Laurent Vivier This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Bastian Koppelmann Signed-off-by: Laurent Vivier Reviewed-by: Bastian Koppelmann

[Qemu-devel] [RFC/PATCH] migration: SMRAM dirty bitmap not fetched from kvm-kmod and not send to destination

2016-09-14 Thread Herongguang (Stephen)
Hi, We found a problem that when a redhat 6 VM reboots (in grub countdown UI), migrating this VM will result in VM’s memory difference between source and destination side. The difference always resides in GPA 0xA~0xC, i.e. SMRAM area. Occasionally this result in VM instruction

[Qemu-devel] [PULL 01/27] Remove remainders of HPPA backend

2016-09-14 Thread Michael Tokarev
From: Thomas Huth The HPPA backend has been removed by the following commit: 802b5081233a6b643a8b135a5facaf14bafaa77d tcg-hppa: Remove tcg backend But some small pieces of the HPPA backend still survived until today. Since we also do not have support for a HPPA target

[Qemu-devel] [PULL 21/27] s390x: remove useless cast

2016-09-14 Thread Michael Tokarev
From: Laurent Vivier This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Cornelia Huck Signed-off-by: Laurent Vivier Signed-off-by: Michael Tokarev --- hw/s390x/sclp.c | 2 +-

[Qemu-devel] [PULL 27/27] mptsas: change .realize function name

2016-09-14 Thread Michael Tokarev
From: Cao jin All the other devices` .realize function name are xxx_realize, except this one. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Markus Armbruster

[Qemu-devel] [PULL 23/27] fw_cfg: remove useless casts

2016-09-14 Thread Michael Tokarev
From: Laurent Vivier This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Laszlo Ersek Signed-off-by: Laurent Vivier Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev

[Qemu-devel] [PULL 07/27] MAINTAINERS: Add include/sysemu/cpus.h

2016-09-14 Thread Michael Tokarev
From: Thomas Huth This header seems to belong to the guest CPU section since it contains prototypes for cpus.c. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

<    1   2   3   4   5   >