Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 05:59:55AM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Stefan Hajnoczi" > > To: "Fam Zheng" > > Cc: "Stefan Hajnoczi" , borntrae...@de.ibm.com, "Karl > > Rister"

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 06:25:49PM +0800, Fam Zheng wrote: > On Thu, 12/01 19:26, Stefan Hajnoczi wrote: > > One way to avoid the costly exit is to use polling instead of notification. > > Testing with fio on virtio-blk backed by NVMe device, I can see significant > performance improvement with

Re: [Qemu-devel] [PATCH for-2.9 22/30] aspeed/smc: handle dummy bytes when doing fast reads

2016-12-05 Thread Cédric Le Goater
On 12/04/2016 05:46 PM, mar.krzeminski wrote: > > > W dniu 29.11.2016 o 16:44, Cédric Le Goater pisze: >> When doing fast read, a certain amount of dummy bytes should be sent >> before the read. This number is configurable in the controler CE0 >> Control Register and needs to be modeled using

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread G 3
On Dec 5, 2016, at 9:15 AM, Paolo Bonzini wrote: On 05/12/2016 14:47, G 3 wrote: So now I have to figure out which commands to use. This script would have to work on all operating systems that QEMU is built on. This page has some pretty good information on how to do this:

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread G 3
On Dec 3, 2016, at 3:41 AM, Paolo Bonzini wrote: On 02/12/2016 23:59, Programmingkid wrote: I thought we could use a Hosts page to sort all the host documentation we have. It is located here: http://wiki.qemu.org/Hosts Here is what I have so far: AIX Darwin FreeBSD, NetBSD, OpenBSD

Re: [Qemu-devel] [PATCH for-2.9 17/30] aspeed/smc: handle SPI flash Command mode

2016-12-05 Thread Cédric Le Goater
On 12/04/2016 05:31 PM, mar.krzeminski wrote: > Hi Cedric, > > Since there is no public datasheet user guide for SMC I would ask some > question > regarding HW itself because I got impression that you are implementing in this > model a part functionality that is done by Bootrom. > > W dniu

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread Paolo Bonzini
On 05/12/2016 14:47, G 3 wrote: > > So now I have to figure out which commands to use. This script would > have to work on all operating systems that QEMU is built on. This page > has some pretty good information on how to do this: >

Re: [Qemu-devel] [PULL 0/3] Net patches

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 05:52:00PM +0800, Jason Wang wrote: > The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: > > Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into > staging (2016-12-01 13:39:29 +) > > are available in the git repository

Re: [Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

2016-12-05 Thread Cédric Le Goater
On 12/05/2016 10:57 AM, Marcin Krzemiński wrote: > > 2016-12-05 10:36 GMT+01:00 Cédric Le Goater >: > > Hello Marcin, > > On 12/04/2016 06:00 PM, mar.krzeminski wrote: > > Hi Cedric, > > > > it looks like good idea for now to handle

Re: [Qemu-devel] [PATCH v4 01/64] tcg: Add field extraction primitives

2016-12-05 Thread Richard Henderson
On 12/05/2016 05:17 AM, Alex Bennée wrote: >> +/* ??? Ideally we'd know what values are available for immediate AND. >> + Assume that 8 bits are available, plus the special case of 16, >> + so that we get ext8u, ext16u. */ >> +switch (len) { >> +case 1 ... 8: case 16: >> +

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

2016-12-05 Thread Eduardo Habkost
On Fri, Dec 02, 2016 at 08:30:35PM -0200, Marcelo Tosatti wrote: > On Fri, Dec 02, 2016 at 11:56:09AM -0200, Eduardo Habkost wrote: > > On Thu, Dec 01, 2016 at 12:39:03PM -0200, Marcelo Tosatti wrote: > > > On Wed, Nov 30, 2016 at 11:09:28AM -0200, Eduardo Habkost wrote: > > > > On Tue, Nov 29,

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-05 Thread Paolo Bonzini
> Anyway, I'm glad the polling series on its own is already showing good > performance results. I'd like to merge it at the beginning of QEMU 2.9 > so we can work on further improvements that build on top of it. Yes, it would be great if you can stage the infrastructure bits, so that I can

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-05 Thread Cornelia Huck
On Mon, 05 Dec 2016 16:21:22 +0100 Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent. So, if you have: > > -global virtio-pci.disable-modern=on > -global virtio-blk-pci.disable-modern=off > > Then the default value of

Re: [Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

2016-12-05 Thread mar.krzeminski
W dniu 05.12.2016 o 15:53, Cédric Le Goater pisze: On 12/05/2016 10:57 AM, Marcin Krzemiński wrote: 2016-12-05 10:36 GMT+01:00 Cédric Le Goater >: Hello Marcin, On 12/04/2016 06:00 PM, mar.krzeminski wrote: > Hi Cedric, > > it

Re: [Qemu-devel] [PATCH for-2.9 22/30] aspeed/smc: handle dummy bytes when doing fast reads

2016-12-05 Thread mar.krzeminski
W dniu 05.12.2016 o 15:14, Cédric Le Goater pisze: On 12/04/2016 05:46 PM, mar.krzeminski wrote: W dniu 29.11.2016 o 16:44, Cédric Le Goater pisze: When doing fast read, a certain amount of dummy bytes should be sent before the read. This number is configurable in the controler CE0 Control

Re: [Qemu-devel] [PATCH for-2.9 17/30] aspeed/smc: handle SPI flash Command mode

2016-12-05 Thread mar.krzeminski
W dniu 05.12.2016 o 15:07, Cédric Le Goater pisze: On 12/04/2016 05:31 PM, mar.krzeminski wrote: Hi Cedric, Since there is no public datasheet user guide for SMC I would ask some question regarding HW itself because I got impression that you are implementing in this model a part

Re: [Qemu-devel] [PATCH for-2.8] target-arm/translate-a64: fix gen_load_exclusive

2016-12-05 Thread Richard Henderson
On 12/05/2016 03:09 AM, Alex Bennée wrote: > > Alex Bennée writes: > >> While testing rth's latest TCG patches with risu I found ldaxp was >> broken. Investigating further I found it was broken by 1dd089d0 when >> the cmpxchg atomic work was merged. > > CC'ing

Re: [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread David Hildenbrand
Am 02.12.2016 um 22:17 schrieb Eduardo Habkost: This series implements query-cpu-model-expansion on target-i386. QAPI / interface changes When implementing this, I have noticed that the "host" CPU model in i386 includes some migration-unsafe features that can't be

[Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-05 Thread Greg Kurz
The current code recursively applies global properties from child up to parent. So, if you have: -global virtio-pci.disable-modern=on -global virtio-blk-pci.disable-modern=off Then the default value of disable-modern for a virtio-blk-pci device is on, which looks wrong from an OOP perspective.

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread Paolo Bonzini
> On Dec 5, 2016, at 9:15 AM, Paolo Bonzini wrote: > > On 05/12/2016 14:47, G 3 wrote: > > > So now I have to figure out which commands to use. This script would > > > have to work on all operating systems that QEMU is built on. This > > > page > > > has some pretty good information on how to do

Re: [Qemu-devel] [RFC 11/15] s390x: Initialize default bus lists

2016-12-05 Thread David Hildenbrand
Am 22.11.2016 um 02:12 schrieb Eduardo Habkost: Populate the default_bus_types list for the s390x machines. This will allow qmp-machine-info.py to run in strict mode for s390x. Signed-off-by: Eduardo Habkost --- hw/s390x/s390-virtio-ccw.c | 6 ++

[Qemu-devel] Slow qemu guest performance after host is resumed from suspended state

2016-12-05 Thread Ruslan Habalov
Hi everyone, I'm having the following qemu issue since about February on Xubuntu. Steps to reproduce: 1) Boot host and boot qemu guest - everything works perfect 2) Shutdown qemu guest 3) Suspend host and resume host 4) Boot qemu guest again - the guest is now extremely slow Current system

Re: [Qemu-devel] [PATCH for-2.8] qcow2: Don't strand clusters near 2G intervals during commit

2016-12-05 Thread Eric Blake
On 12/03/2016 11:34 AM, Eric Blake wrote: > The qcow2_make_empty() function is reached during 'qemu-img commit', > in order to clear out ALL clusters of an image. However, if the > image cannot use the fast code path (true if the image is format > 0.10, or if the image contains a snapshot), the

Re: [Qemu-devel] [RFC 11/15] s390x: Initialize default bus lists

2016-12-05 Thread Cornelia Huck
On Mon, 5 Dec 2016 16:24:00 +0100 David Hildenbrand wrote: > Am 22.11.2016 um 02:12 schrieb Eduardo Habkost: > > Populate the default_bus_types list for the s390x machines. This > > will allow qmp-machine-info.py to run in strict mode for s390x. > > > > Signed-off-by: Eduardo

[Qemu-devel] [PATCH for-2.8 v2] qcow2: Don't strand clusters near 2G intervals during commit

2016-12-05 Thread Eric Blake
The qcow2_make_empty() function is reached during 'qemu-img commit', in order to clear out ALL clusters of an image. However, if the image cannot use the fast code path (true if the image is format 0.10, or if the image contains a snapshot), the cluster size is larger than 512, and the image is

Re: [Qemu-devel] [PATCH for-2.8] target-arm/translate-a64: fix gen_load_exclusive

2016-12-05 Thread Peter Maydell
On 5 December 2016 at 15:42, Richard Henderson wrote: > We'll have to fix it properly eventually. But perhaps 2.9 is soon enough, > since that's when mttcg will go in. Could you provide a reviewed-by (or an explicit nak) for Alex's patch, please? I didn't look at this area of

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-05 Thread Cornelia Huck
On Mon, 5 Dec 2016 16:42:00 +0100 Cornelia Huck wrote: > On Mon, 05 Dec 2016 16:21:22 +0100 > Greg Kurz wrote: > > AFAIK, libvirt's XML doesn't know about modern/legacy modes for virtio > > devices. Early adopters of virtio 1.0 had to rely on the > >

Re: [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature

2016-12-05 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Wed, Nov 30, 2016 at 01:16:59PM +0100, Maxime Coquelin wrote: >> >> >> On 11/30/2016 12:23 PM, Jason Wang wrote: >> > >> > >> > On 2016年11月30日 18:10, Maxime Coquelin wrote: >> > > This series implements Virtio spec update from Aaron Conole

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-05 Thread Eric Blake
On 12/05/2016 04:24 AM, Laszlo Ersek wrote: > > I picked the below lines from Eric's feedback. > >>> +qapi-schema*.json >>> +qapi/*.json >>> +include/qapi/visitor.h >>> +include/qapi/visitor-impl.h >>> +scripts/qapi.py >>> +scripts/*.py >>> +*.h >>> +qapi/qapi-visit-core.c >> >> is the exact

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-05 Thread Richard Henderson
On 12/05/2016 01:41 AM, Jin Guojie wrote: > -- Original -- > From: "Richard Henderson";; > Send time: Thursday, Dec 1, 2016 11:52 PM > To: "Jin Guojie"; "qemu-devel"; > Cc: "Aurelien

Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options

2016-12-05 Thread Eric Blake
On 12/05/2016 02:35 AM, zhanghailiang wrote: > We use these two options to identify which disk is > shared > > Signed-off-by: zhanghailiang > Signed-off-by: Wen Congyang > Signed-off-by: Zhang Chen > --- > v2:

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-05 Thread Eric Blake
On 12/04/2016 11:33 AM, Michael S. Tsirkin wrote: >> +++ b/scripts/git.orderfile >> @@ -0,0 +1,20 @@ >> +# Apply this diff order to your git configuration with the command >> +# >> +# git config diff.orderFile scripts/git.orderfile >> + >> +docs/* > > do we need this now? .txt is just below. >

Re: [Qemu-devel] [RFC 11/15] s390x: Initialize default bus lists

2016-12-05 Thread Eduardo Habkost
On Mon, Dec 05, 2016 at 05:03:27PM +0100, Cornelia Huck wrote: > On Mon, 5 Dec 2016 16:24:00 +0100 > David Hildenbrand wrote: > > > Am 22.11.2016 um 02:12 schrieb Eduardo Habkost: > > > Populate the default_bus_types list for the s390x machines. This > > > will allow

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-05 Thread Karl Rister
On 12/05/2016 08:56 AM, Stefan Hajnoczi wrote: > Karl: do you have time to run a bigger suite of benchmarks to identify a > reasonable default poll-max-ns value? Both aio=native and aio=threads > are important. > > If there is a sweet spot that improves performance without pathological > cases

Re: [Qemu-devel] [RFC] target-ppc/fpu_helper.c: Use C99 code to speed up floating point unit

2016-12-05 Thread Eric Blake
On 12/03/2016 07:32 PM, Richard Henderson wrote: > On 12/03/2016 09:07 AM, Programmingkid wrote: >> Yes it would be. The commit message never stated why he wanted to switch >> to floating point softfloat routines. These are my guesses: > ... >> - Different hosts produced different results and

[Qemu-devel] [PULL 0/9] QAPI patches for 2016-12-05

2016-12-05 Thread Markus Armbruster
A set of fixes for MacOS from Eric, and a little documentation polishing from Marc-André. The diffstat for the .json may look scary, but the generated code is identical. The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: Merge remote-tracking branch

[Qemu-devel] [PULL 2/9] test-qga: Avoid qobject_from_jsonv("%"PRId64)

2016-12-05 Thread Markus Armbruster
From: Eric Blake The qobject_from_jsonv() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by -Wformat, and is not a straight synonym to bare printf(). In particular, any use of an

[Qemu-devel] [PULL 4/9] qga/schema: fix double-return in doc

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau guest-get-memory-block-info documentation should have only one "Returns:". Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 3/9] tests: Avoid qobject_from_jsonf("%"PRId64)

2016-12-05 Thread Markus Armbruster
From: Eric Blake The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by -Wformat, and is not a straight synonym to bare printf(). In particular, any use of an

[Qemu-devel] [PULL 1/9] qmp-event: Avoid qobject_from_jsonf("%"PRId64)

2016-12-05 Thread Markus Armbruster
From: Eric Blake The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by -Wformat, and is not a straight synonym to bare printf(). In particular, any use of an

[Qemu-devel] [PULL 5/9] qapi: fix schema symbol sections

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau According to docs/qapi-code-gen.txt, there needs to be '##' to start a and end a symbol section, that's also what the documentation parser expects. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake

[Qemu-devel] [PULL 7/9] qapi: fix various symbols mismatch in documentation

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau There are various mismatch: - invalid symbols - section and member symbols mismatch - enum or union values vs 'type' The documentation parser catches all these cases. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 6/9] qapi: fix missing symbol @prefix

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20161117155504.21843-6-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by:

[Qemu-devel] [PULL 9/9] qapi: add missing colon-ending for section name

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau The documentation parser we are going to add expects a section name to end with ':', otherwise the comment is treated as free-form text body. Signed-off-by: Marc-André Lureau Message-Id:

Re: [Qemu-devel] [PATCH v5 00/17] qapi doc generation (whole version, squashed)

2016-12-05 Thread Markus Armbruster
Marc-André Lureau writes: > Add a qapi2texi script to generate the documentation from the qapi > schemas. > > The 15th patch in this series is a squashed version of the > documentation move from qmp-commands.txt to the schemas. The whole > version (not sent on the ML

[Qemu-devel] [PULL 8/9] qapi: use one symbol per line

2016-12-05 Thread Markus Armbruster
From: Marc-André Lureau The documentation parser we are going to add only handles a single symbol per line. Signed-off-by: Marc-André Lureau Message-Id: <20161117155504.21843-8-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-05 Thread Eduardo Habkost
On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > On Mon, 05 Dec 2016 16:21:22 +0100 > Greg Kurz wrote: > > > The current code recursively applies global properties from child up to > > parent. So, if you have: > > > > -global virtio-pci.disable-modern=on > >

Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Eric Blake
On 12/05/2016 05:09 AM, Stefan Hajnoczi wrote: > On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: >> NBD client has not implemented callback for .bdrv_has_zero_init. So >> bdrv_has_zero_init always returns 0 when doing non-shared storage >> migration. >> This patch implemented

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-12-05 Thread Markus Armbruster
Eric Blake writes: > programmingk...@gmail.com[*] reported a runtime failure on a > 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". > Fortunately, we had very few spots that were relying on our > pseudo-printf JSON parsing of int64_t numbers, so it was > easier to

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 09:29:59AM +, Gonglei (Arei) wrote: > > > > > switch (alg) { > > > +case QCRYPTO_CIPHER_ALG_DES: > > > case QCRYPTO_CIPHER_ALG_DES_RFB: > > > case QCRYPTO_CIPHER_ALG_AES_128: > > > case QCRYPTO_CIPHER_ALG_AES_192: > > > @@ -256,11 +257,17 @@

<    1   2   3