Re: [Qemu-devel] [PATCH] sdl2: fix build failure on windows

2017-01-13 Thread Stefan Weil
Am 13.01.2017 um 09:14 schrieb Gerd Hoffmann: > Cc: Stefan Weil > Cc: Samuel Thibault > Signed-off-by: Gerd Hoffmann > --- > ui/sdl2.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index

[Qemu-devel] [Bug 1654271] Re: host machine freezes

2017-01-13 Thread Thomas Huth
Moving this to the Ubuntu-qemu bug tracker since you're apparently using Ubuntu's QEMU, not the upstream QEMU. ** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix()

2017-01-13 Thread Markus Armbruster
Cao jin writes: > Also move certain hunk above, to place msix init related code together. > > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC:

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not > >good, and we should end the day when we need to recompile the code > >before getting useful debugging information

[Qemu-devel] [PATCH v2 1/2] target-ppc: Add xvtstdc[sp, dp] instructions

2017-01-13 Thread Nikunj A Dadhania
xvtstdcsp: VSX Vector Test Data Class Single-Precision xvtstdcdp: VSX Vector Test Data Class Double-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 40 + target/ppc/helper.h | 2

[Qemu-devel] [Bug 886621] Re: Mac OS X Lion: segmentation fault

2017-01-13 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently version 2.8)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 917645] Re: [Feature request] ia64-softmmu wanted

2017-01-13 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/917645 Title: [Feature request] ia64-softmmu wanted Status in HelenOS branches: Confirmed

[Qemu-devel] [Bug 893068] Re: Spanish keys { and [ did not work

2017-01-13 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently version 2.8)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-13 Thread Gerd Hoffmann
Hi, > Sure, thanks for the pointers! > I suppose I can change later to msi-x in a follow up patch > to avoid introducing new bugs from the beginning :) I'd use msi-x right from start to avoid any backward compatibility issues. cheers, Gerd

Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h

2017-01-13 Thread Christian Borntraeger
On 01/11/2017 03:17 AM, Richard Henderson wrote: > This lets us expose facilities to TCG_TARGET_HAS_* defines > directly, rather than hiding behind function calls. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.h | 126 >

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Jason Wang
On 2017年01月13日 17:13, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Thomas Huth writes: > On 12.01.2017 17:22, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> When running certain HMP commands ("info registers", "info cpustats", >>> "nmi", "memsave" or dumping virtual memory) with the "none" machine, >>> QEMU crashes

Re: [Qemu-devel] [PATCH RFC v3 09/14] memory: introduce memory_region_notify_one()

2017-01-13 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Signed-off-by: Peter Xu --- include/exec/memory.h | 15 +++

[Qemu-devel] [Bug 894037] Re: With VNC, "-usbdevice tablet" no longer makes mouse pointers line up

2017-01-13 Thread Thomas Huth
According to comment #6 this has been fixed in version 1.0 ... is there still something left to do here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-13 Thread Xiao Guangrong
On 01/13/2017 11:02 AM, Li Qiang wrote: From: Li Qiang The spec doesn't say the namespace label can't be zero when read/write it. As this is no harmful, just allow it. WHY? The spec said that the label should be at least 128K.

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-13 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally bring a dead loop when guest starts. I think it just takes too much time instead of dead loop? The

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-13 Thread Li, Liang Z
> On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > Add a new feature which supports sending the page information with > > range array. The current implementation uses PFNs array, which is not > > very efficient. Using ranges can improve the performance of > > inflating/deflating

[Qemu-devel] [PATCH v2 2/2] target-ppc: Add xststdc[sp, dp, qp] instructions

2017-01-13 Thread Nikunj A Dadhania
xststdcsp: VSX Scalar Test Data Class Single-Precision xststdcdp: VSX Scalar Test Data Class Double-Precision xststdcqp: VSX Scalar Test Data Class Quad-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 66

Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11

2017-01-13 Thread Peter Maydell
On 11 January 2017 at 19:34, Paolo Bonzini wrote: > The following changes since commit 41a0e54756a9ae6b60be34bb33302a7e085fdb07: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-01-10 10:46:21 +) > > are available in the git

Re: [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error

2017-01-13 Thread Markus Armbruster
Cao jin writes: > Only a tiny modification in patch "megasas: remove unnecessary > megasas_use_msix()" to fix a megasas issue. Please have a look at Michael's review in Message-ID: <20170112163519-mutt-send-email-...@kernel.org> > v8 changelog: > 1. reorder: place the

[Qemu-devel] [Bug 1656234] [NEW] Qemu core dumped if using virtio-net

2017-01-13 Thread Robert Hu
Public bug reported: System Environment === Qemu commit/branch: e92fbc75 Host OS: RHEL7.2 ia32e Host Kernel: 4.9.0 Guest OS: RHEL7.2 ia32e Guest Kernel: 4.9.0 Bug detailed description === While create a kvm guest using virtio-net, the qemu will core dump with showing "Aborted (core

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:55:22PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >In this patch, IOMMUNotifier.{start|end} are introduced to store section > >information for a specific notifier. When notification occurs, we not > >only check the notification type

[Qemu-devel] [PATCH v2 0/2] POWER9 TCG enablements - part12

2017-01-13 Thread Nikunj A Dadhania
This series contains 5 new instructions for POWER9 ISA3.0 VSX Scalar Test Data Class VSX Vector Test Data Class Changelog: v1: * Zero the match variable in the element loops v0: * Concise logic for identifying data class in Scalar/Vector test data class instructions Nikunj A Dadhania

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Jason Wang
On 2017年01月13日 17:23, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:55:22PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 05:37:43PM +0800, Jason Wang wrote: [...] > >>>diff --git a/memory.c b/memory.c > >>>index 2bfc37f..e88bb54 100644 > >>>--- a/memory.c > >>>+++ b/memory.c > >>>@@ -1671,7 +1671,9 @@ void memory_region_notify_iommu(MemoryRegion *mr, > >>> } > >>>

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Markus Armbruster writes: > Thomas Huth writes: > >> On 12.01.2017 17:22, Markus Armbruster wrote: >>> Thomas Huth writes: >>> When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping

Re: [Qemu-devel] [PATCH RFC v3 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

2017-01-13 Thread Markus Armbruster
Dou Liyang writes: > In order to reduce the execution time, this patch optimize > the qmp_query_blockstats(): > Remove the next_query_bds function. > Remove the bdrv_query_stats function. > Remove some judgement sentence. > > The original qmp_query_blockstats calls

Re: [Qemu-devel] [PATCH v6 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-13 Thread Laszlo Ersek
On 01/13/17 11:15, Igor Mammedov wrote: > On Thu, 12 Jan 2017 19:24:44 +0100 > Laszlo Ersek wrote: > >> Introduce the following fw_cfg files: >> >> - "etc/smi/supported-features": a little endian uint64_t feature bitmap, >> presenting the features known by the host to the

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > > The virtio_queue_set_notification() nesting introduced for AioContext > > polling > > raised an assertion with virtio-net (even in non-polling mode). Converting > > virtio-net and

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-13 Thread Vladimir Sementsov-Ogievskiy
12.01.2017 16:11, Alex Bligh wrote: On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy wrote: Yes this is better. But is it actually needed to force contexts have some safe default? If context wants it may define such default without this requirement.. So,

[Qemu-devel] [PATCH] ahci: advertise HOST_CAP_64

2017-01-13 Thread Ladi Prosek
The AHCI emulation code supports 64-bit addressing and should advertise this fact in the Host Capabilities register. Both Linux and Windows drivers test this bit to decide if the upper 32 bits of various registers may be written to, and at least some versions of Windows have a bug where DMA is

Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112

2017-01-13 Thread Laurent Vivier
On 13/01/2017 11:54, Peter Maydell wrote: > Q: can we just enable these tests for PCI with > check-qtest-ppc64-y += $(check-qtest-pci-y) > gcov-files-ppc64-y += $(gcov-files-pci-y) > > the way we do for i386/x86_64 ? Or is that doing too much > unwanted extra testing? For most of the devices

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Thomas Huth
On 13.01.2017 08:59, Markus Armbruster wrote: > Thomas Huth writes: > >> On 12.01.2017 17:22, Markus Armbruster wrote: >>> Thomas Huth writes: >>> When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping

[Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Haozhong Zhang
The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. Reported-by: Stefan Hajnoczi Signed-off-by: Haozhong Zhang Message-Id:

Re: [Qemu-devel] [PATCH v6 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:44 +0100 Laszlo Ersek wrote: > Introduce the following fw_cfg files: > > - "etc/smi/supported-features": a little endian uint64_t feature bitmap, > presenting the features known by the host to the guest. Read-only for > the guest. > > The

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-13 Thread Alex Bligh
> On 13 Jan 2017, at 09:48, Vladimir Sementsov-Ogievskiy > wrote: > > 12.01.2017 16:11, Alex Bligh wrote: >>> On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> Yes this is better. But is it actually needed to force

Re: [Qemu-devel] [PATCH RFC v3 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-13 Thread Markus Armbruster
Dou Liyang writes: > Change log v2 -> v3: > 1. Remove the unnecessary code for the bdrv_next_node(). > 2. Remove the change of the locking rules. > Even if this change can improve the performance, but it may > effect the consistency. > > For the multi-disks

Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112

2017-01-13 Thread Peter Maydell
On 12 January 2017 at 02:02, David Gibson wrote: > The following changes since commit b44486dfb9447c88e4b216e730adcc780190852c: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20170110-1' into > staging (2017-01-10 14:52:34 +) > > are available in

Re: [Qemu-devel] [PATCH] virtio-ccw: fix ring sizing

2017-01-13 Thread Cornelia Huck
On Thu, 12 Jan 2017 23:26:22 +0200 "Michael S. Tsirkin" wrote: > Current code seems to assume ring size is > always decreased but this is not required by spec: > what spec says is just that size can not exceed > the maximum. Fix it up. > > Signed-off-by: Michael S. Tsirkin

[Qemu-devel] Data corruption in Qemu 2.7.1

2017-01-13 Thread Peter Lieven
Hi, i currently facing a problem in our testing environment where I see file system corruption with 2.7.1 on iSCSI and Local Storage (LVM). Trying to bisect, but has anyone observed this before? Thanks, Peter

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Xiao Guangrong
On 01/13/2017 07:56 PM, Haozhong Zhang wrote: The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. Thanks for your fix. Reviewed-by: Xiao Guangrong

[Qemu-devel] system_clock_scale unset in hw/intc/armv7m_nvic.c

2017-01-13 Thread James Hanley
How should system_clock_scale be set in hw/intc/armv7m_nvic.c - there is no API for the global, and I've defaulted the global to SYSTICK_SCALE which seems to work, but is not obvious. This was needed as this value was set to zero and the arm firmware was selecting the external clock source

Re: [Qemu-devel] [PATCH v4 0/2] Fixes/tests for hmp_object_del()

2017-01-13 Thread Markus Armbruster
Andreas, please have a look. Feel free to ask me to take it through my tree. Michael Roth writes: > hmp_object_del() followed by a subsequent hmp_object_add() can trigger a > duplicate ID error if the previous object shared the same ID and was added > via the

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:45 +0100 Laszlo Ersek wrote: > The generic edk2 SMM infrastructure prefers > EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If > Trigger() only brings the current processor into SMM, then edk2 handles it > in the following

[Qemu-devel] [PATCH 08/16] qed: introduce qed_aio_start_io and qed_aio_next_io_cb

2017-01-13 Thread Paolo Bonzini
qed_aio_start_io and qed_aio_next_io will not have to acquire/release the AioContext, while qed_aio_next_io_cb will. Split the functionality and gain a little type-safety in the process. Signed-off-by: Paolo Bonzini --- block/qed.c | 39

[Qemu-devel] [PATCH 13/16] block: explicitly acquire aiocontext in aio callbacks that need it

2017-01-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/archipelago.c| 3 --- block/block-backend.c | 7 --- block/curl.c | 2 +- block/io.c | 6 +- block/iscsi.c | 3 --- block/linux-aio.c | 5 + block/mirror.c | 12

[Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it

2017-01-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- aio-posix.c | 2 -- aio-win32.c | 2 -- block/curl.c| 2 ++ block/iscsi.c | 8 ++-- block/null.c| 4 block/qed.c | 12

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Haozhong Zhang
On 01/13/17 13:17 +, Stefan Hajnoczi wrote: On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration.

Re: [Qemu-devel] [PATCH v6 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:44 +0100 Laszlo Ersek wrote: [...] > +static void smi_features_ok_callback(void *opaque) > +{ > +ICH9LPCState *lpc = opaque; > +uint64_t guest_features; > + > +if (lpc->smi_features_ok) { > +/* negotiation already complete,

[Qemu-devel] [PATCH v4] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Thomas Huth
When running certain HMP commands ("info registers", "info cpustats", "info tlb", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes with a segmentation fault. This happens because the "none" machine does not have any CPUs by default, but these HMP commands did not

[Qemu-devel] [PATCH v2 2/5] target-m68k: fix gen_flush_flags()

2017-01-13 Thread Laurent Vivier
gen_flush_flags() is setting unconditionally cc_op_synced to 1 and s->cc_op to CC_OP_FLAGS, whereas env->cc_op can be set to something else by a previous tcg fragment. We fix that by not setting cc_op_synced to 1 (except for gen_helper_flush_flags() that updates env->cc_op) FIX:

[Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Laurent Vivier
M680x0 bit operations with an immediate value use 9 bits of the 16bit value, while coldfire ones use only 8 bits. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/5] Fixes for target/m68k

2017-01-13 Thread Laurent Vivier
This is a series of fixes for target/m68k found: - with RISU (bit operation with immediate) - while debugging package build under chroot (gen_flush_flags() and CAS address modes) - while I was working on the softmmu mode (CAS alignment and SP address modes) v2: - Don't align stack access on

[Qemu-devel] [PATCH 02/16] block-backend: allow blk_prw from coroutine context

2017-01-13 Thread Paolo Bonzini
qcow2_create2 calls this. Do not run a nested event loop, as that breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup list of the currently running one. Signed-off-by: Paolo Bonzini --- block/block-backend.c | 12 1 file changed, 8

[Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-13 Thread Paolo Bonzini
This is in preparation for making qio_channel_yield work on AioContexts other than the main one. Signed-off-by: Paolo Bonzini --- include/io/channel.h | 30 ++ io/channel-command.c | 13 + io/channel-file.c| 11 +++

[Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-13 Thread Paolo Bonzini
This series pushes down aio_context_acquire/release to the point where we can actually reason on using different fine-grained mutexes. The main infrastructure is introduced in patch 1. The new API aio_co_wake starts a coroutine with aio_context_acquire/release protection, which requires tracking

[Qemu-devel] [PATCH 03/16] test-thread-pool: use generic AioContext infrastructure

2017-01-13 Thread Paolo Bonzini
Once the thread pool starts using aio_co_wake, it will also need qemu_get_current_aio_context(). Make test-thread-pool create an AioContext with qemu_init_main_loop, so that stubs/iothread.c and tests/iothread.c can provide the rest. Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 09/16] aio: push aio_context_acquire/release down to dispatching

2017-01-13 Thread Paolo Bonzini
The AioContext data structures are now protected by list_lock and/or they are walked with FOREACH_RCU primitives. There is no need anymore to acquire the AioContext for the entire duration of aio_dispatch. Instead, just acquire it before and after invoking the callbacks. The next step is then to

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-13 Thread Artyom Tarasenko
On Fri, Jan 13, 2017 at 1:23 PM, Mark Cave-Ayland wrote: > On 12/01/17 12:57, Hervé Poussineau wrote: > >> Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >>> Hi Hervé, >>> >>> nice work! >>> >>> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >>>

Re: [Qemu-devel] [PATCH v5 00/10] aio_context_acquire/release pushdown, part 1

2017-01-13 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 07:07:50PM +0100, Paolo Bonzini wrote: > This is the first step of pushing down the AioContext lock. Bottom halves > are already protected by their own lock, use it also for walking_bh > and for the handlers list (including walking_handlers). The (lock, > walking_foo)

Re: [Qemu-devel] [PATCH] sdl2: fix build failure on windows

2017-01-13 Thread Peter Maydell
On 13 January 2017 at 08:27, Stefan Weil wrote: > Am 13.01.2017 um 09:14 schrieb Gerd Hoffmann: >> Cc: Stefan Weil >> Cc: Samuel Thibault >> Signed-off-by: Gerd Hoffmann >> --- >> ui/sdl2.c | 6 ++ >> 1 file

Re: [Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case

2017-01-13 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 04:34:59PM +0800, zhanghailiang wrote: > +Issue qmp command: > + { 'execute': 'blockdev-add', > +'arguments': { > +'driver': 'replication', > +'node-name': 'rep', > +'mode': 'primary', > +'shared-disk-id': 'primary_disk0', > +

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-13 Thread Mark Cave-Ayland
On 12/01/17 12:57, Hervé Poussineau wrote: > Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >> Hi Hervé, >> >> nice work! >> >> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >> wrote: >>> Hi, >>> >>> This patchset adds the emulation of the IBM RS/6000 7020 (40p).

Re: [Qemu-devel] [PATCH v4] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Thomas Huth writes: > When running certain HMP commands ("info registers", "info cpustats", > "info tlb", "nmi", "memsave" or dumping virtual memory) with the "none" > machine, QEMU crashes with a segmentation fault. This happens because the > "none" machine does not have any

[Qemu-devel] [PATCH v2 5/5] target-m68k: increment/decrement with SP

2017-01-13 Thread Laurent Vivier
On 680x0 family only. Address Register indirect With postincrement: When using the stack pointer (A7) with byte size data, the register is incremented by two. Address Register indirect With predecrement: When using the stack pointer (A7) with byte size data, the register is decremented by two.

Re: [Qemu-devel] [PATCH v2 5/5] target-m68k: increment/decrement with SP

2017-01-13 Thread Thomas Huth
On 13.01.2017 13:52, Laurent Vivier wrote: > On 680x0 family only. > > Address Register indirect With postincrement: > > When using the stack pointer (A7) with byte size data, the register > is incremented by two. > > Address Register indirect With predecrement: > > When using the stack

[Qemu-devel] [PATCH v2 3/5] target-m68k: manage pre-dec et post-inc in CAS

2017-01-13 Thread Laurent Vivier
In these cases we must update the address register after the operation. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 0e97900..23e2b06 100644 ---

[Qemu-devel] [PATCH v2 4/5] target-m68k: CAS doesn't need aligned access

2017-01-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 23e2b06..cf5d8dd 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1934,7 +1934,6 @@

[Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-13 Thread Paolo Bonzini
aio_co_wake provides the infrastructure to start a coroutine on a "home" AioContext. It will be used by CoMutex and CoQueue, so that coroutines don't jump from one context to another when they go to sleep on a mutex or waitqueue. However, it can also be used as a more efficient alternative to

[Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-13 Thread Paolo Bonzini
Support separate coroutines for reading and writing, and place the read/write handlers on the AioContext that the QIOChannel is registered with. Signed-off-by: Paolo Bonzini --- include/io/channel.h | 37 ++ io/channel.c | 86

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: > The missing of 'nvdimm' in the machine type option '-M' means NVDIMM > is disabled. QEMU should refuse to plug any NVDIMM device in this case > and report the misconfiguration. > > Reported-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 12/16] block: explicitly acquire aiocontext in bottom halves that need it

2017-01-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- async.c | 4 ++-- block/archipelago.c | 3 +++ block/blkdebug.c | 9 + block/blkreplay.c | 2 +- block/block-backend.c | 6 ++ block/curl.c | 26 ++ block/gluster.c

Re: [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:46 +0100 Laszlo Ersek wrote: > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Paolo Bonzini >

Re: [Qemu-devel] [PATCH v3 3/3] cputlb: drop flush_global flag from tlb_flush

2017-01-13 Thread Alex Bennée
Richard Henderson writes: > On 01/12/2017 08:03 AM, Alex Bennée wrote: >> And I immediately realise I missed out: >> >>> Signed-off-by: Alex Bennée >>> Reviewed-by: Richard Henderson >> [DG: ppc portions] >> Acked-by: David Gibson

Re: [Qemu-devel] [Qemu-discuss] system_clock_scale unset in hw/intc/armv7m_nvic.c

2017-01-13 Thread Peter Maydell
On 13 January 2017 at 12:35, James Hanley wrote: > How should system_clock_scale be set in hw/intc/armv7m_nvic.c - there is no > API for the global, and I've defaulted the global to SYSTICK_SCALE which > seems to work, but is not obvious. This was needed as this value was

[Qemu-devel] [PATCH 07/16] coroutine-lock: reschedule coroutine on the AioContext it was running on

2017-01-13 Thread Paolo Bonzini
As a small step towards the introduction of multiqueue, we want coroutines to remain on the same AioContext that started them, unless they are moved explicitly with e.g. aio_co_schedule. This patch avoids that coroutines switch AioContext when they use a CoMutex. For now it does not make much of

[Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks that need it

2017-01-13 Thread Paolo Bonzini
This covers both file descriptor callbacks and polling callbacks, since they execute related code. Signed-off-by: Paolo Bonzini --- aio-posix.c | 7 --- aio-win32.c | 6 -- block/curl.c | 16 +--- block/iscsi.c | 4

[Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads

2017-01-13 Thread Paolo Bonzini
Read the replies from a coroutine, switching the read side between the "read header" coroutine and the I/O coroutine that reads the body of the reply. qio_channel_yield is used so that the right coroutine is restarted automatically, eliminating the need for send_coroutine in NBDClientSession.

[Qemu-devel] [PATCH 15/16] async: remove unnecessary inc/dec pairs

2017-01-13 Thread Paolo Bonzini
Pull the increment/decrement pair out of aio_bh_poll and into the callers. Signed-off-by: Paolo Bonzini --- aio-posix.c | 8 +++- aio-win32.c | 8 async.c | 12 ++-- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/aio-posix.c

[Qemu-devel] [PATCH 14/16] aio-posix: partially inline aio_dispatch into aio_poll

2017-01-13 Thread Paolo Bonzini
This patch prepares for the removal of unnecessary lockcnt inc/dec pairs. Extract the dispatching loop for file descriptor handlers into a new function aio_dispatch_handlers, and then inline aio_dispatch into aio_poll. aio_dispatch can now become void. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 16/16] block: document fields protected by AioContext lock

2017-01-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/block/block_int.h | 64 +- include/sysemu/block-backend.h | 14 ++--- 2 files changed, 49 insertions(+), 29 deletions(-) diff --git a/include/block/block_int.h

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-13 Thread Thomas Huth
On 13.01.2017 13:23, Mark Cave-Ayland wrote: > On 12/01/17 12:57, Hervé Poussineau wrote: > >> Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >>> Hi Hervé, >>> >>> nice work! >>> >>> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >>> wrote: Hi, This

[Qemu-devel] [PATCH v8 18/21] build-sys: remove dvi doc generation

2017-01-13 Thread Marc-André Lureau
There is no clear reason to have rules to generate dvi format documentation, pdf is generally better supported nowadays. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- .gitignore | 1 - Makefile | 12 2 files

[Qemu-devel] [PATCH v8 16/21] docs: add qemu logo to pdf

2017-01-13 Thread Marc-André Lureau
Add a logo to texi2pdf output. Other formats (info/html) are left as future improvements. The PDF (needed by texi2pdf for vectorized images) was generated from pc-bios/qemu_logo.svg like this: inkscape --export-pdf=docs/qemu_logo.pdf pc-bios/qemu_logo.svg Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v8 19/21] build-sys: use a generic TEXI2MAN rule

2017-01-13 Thread Marc-André Lureau
The recipe for making a man page from .texi is duplicated several times over. Capture it in suitable pattern rules instead. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- Makefile | 24 rules.mak |

[Qemu-devel] [PULL 0/3] Common TLB reset changes

2017-01-13 Thread Alex Bennée
-common-tlb-reset-20170113-r1 for you to fetch changes up to d10eb08f5d8389c814b554d01aa2882ac58221bf: cputlb: drop flush_global flag from tlb_flush (2017-01-13 14:24:37 +) This is the same as the v3 posted except a re-base

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Marc-André Lureau
Hi - Original Message - > Currently, VQs are started as soon as a SET_VRING_KICK is received. That > is too early in the VQ setup process, as the backend might not yet have I think we may want to reconsider queue_set_started(), move it elsewhere, since kick/call fds aren't mandatory to

[Qemu-devel] [PATCH v8 20/21] build-sys: add txt documentation rules

2017-01-13 Thread Marc-André Lureau
Build plain text documentation, and install it. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- .gitignore | 1 + Makefile | 12 +--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.gitignore

[Qemu-devel] [PATCH v8 21/21] build-sys: add qapi doc generation targets

2017-01-13 Thread Marc-André Lureau
Generate and install the man, txt and html versions of QAPI documentation (generate and install qemu-doc.txt too). Add it also to optional pdf/info targets. Signed-off-by: Marc-André Lureau --- .gitignore | 9 + Makefile | 43

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Felipe Franciosi
Hi Marc-Andre, > On 13 Jan 2017, at 07:03, Marc-André Lureau wrote: > > Hi > > - Original Message - >> Currently, VQs are started as soon as a SET_VRING_KICK is received. That >> is too early in the VQ setup process, as the backend might not yet have > > I think we

[Qemu-devel] [PATCH v8 10/21] docs: add master qapi texi files

2017-01-13 Thread Marc-André Lureau
The qapi2texi script generates a file to be included in a texi file. Add "QEMU QMP Reference Manual" and "QEMU Guest Agent Protocol Reference" master texi files. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster ---

[Qemu-devel] [PATCH v8 17/21] build-sys: use --no-split for info

2017-01-13 Thread Marc-André Lureau
Splitting the info files doesn't bring much benefits these days. This fixes also untracked generated info files from git ignore. Let's use MAKEINFOFLAGS for common flags, --number-sections is already the default anyway, so adding it doesn't change the info output. Signed-off-by: Marc-André

[Qemu-devel] [PATCH v8 11/21] qapi: rework qapi Exception

2017-01-13 Thread Marc-André Lureau
Use a base class QAPIError, and QAPIParseError for parser errors and QAPISemError for semantic errors, suggested by Markus Armbruster. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- scripts/qapi.py | 334

[Qemu-devel] [PULL 3/3] cputlb: drop flush_global flag from tlb_flush

2017-01-13 Thread Alex Bennée
We have never has the concept of global TLB entries which would avoid the flush so we never actually use this flag. Drop it and make clear that tlb_flush is the sledge-hammer it has always been. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Doug Goldstein
On 1/12/17 2:05 PM, Michael S. Tsirkin wrote: > On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: >> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: >>> The virtio_queue_set_notification() nesting introduced for AioContext >>> polling >>> raised an assertion with virtio-net (even in

[Qemu-devel] [PULL 1/3] qom/cpu: move tlb_flush to cpu_common_reset

2017-01-13 Thread Alex Bennée
It is a common thing amongst the various cpu reset functions want to flush the SoftMMU's TLB entries. This is done either by calling tlb_flush directly or by way of a general memset of the CPU structure (sometimes both). This moves the tlb_flush call to the common reset function and additionally

Re: [Qemu-devel] [PATCH RFC v3 1/2] block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

2017-01-13 Thread Eric Blake
On 01/04/2017 12:58 AM, Dou Liyang wrote: > the bdrv_query_stats and bdrv_query_bds_stats functions need to call > each other, that increases the coupling. it also makes the program > complicated and makes some unnecessary judgements. s/judgements/judgments/ - although I wonder if 'tests' would

Re: [Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded

2017-01-13 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 11:46:11AM +, Stefan Hajnoczi wrote: > While AioContext is in polling mode virtqueue notifications are not > necessary. Some device virtqueue handlers enable notifications. Make > sure they stay disabled to avoid unnecessary vmexits. > > Signed-off-by: Stefan

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-13 Thread Michael S. Tsirkin
On Fri, Jan 13, 2017 at 02:54:29AM +, Gonglei (Arei) wrote: > > > > > On Thu, Jan 12, 2017 at 12:26:24PM +, Gonglei (Arei) wrote: > > > Hi, > > > > > > > > > > > > > > On 01/04/2017 11:10 AM, Gonglei (Arei) wrote: > > > > > Hi all, > > > > > > > > > > I attach the diff files between v14

Re: [Qemu-devel] [PATCH v8 03/21] qapi: make TODOs named-sections

2017-01-13 Thread Markus Armbruster
Marc-André Lureau writes: > Have the TODO in the TAG: format, so they will stand out in the > generated documentation. > > Signed-off-by: Marc-André Lureau As proposed in review of v7, I'm replacing commit message by qapi: Format

<    1   2   3   >