Re: [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties

Eric Blake writes: > On 01/24/2017 04:53 AM, Lin Ma wrote: >> Signed-off-by: Lin Ma >> --- > > The commit message is rather sparse; is there an easy formula for > triggering the error message, to give more context about the change? Try this: -> { "execute":

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

* David Dai (z...@linux.vnet.ibm.com) wrote: > Using libvirt to do live migration over RDMA via ip v6 address failed. > For example: > # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ > rhel73_host1_guest1 qemu+ssh://[deba::]/system --verbose > root@deba::'s

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

On Tue, Jan 24, 2017 at 09:44:33AM -0600, David Dai wrote: > Using libvirt to do live migration over RDMA via ip v6 address failed. > For example: > # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ > rhel73_host1_guest1 qemu+ssh://[deba::]/system --verbose >

[Qemu-devel] [PATCH 5/8] virtio: use MemoryRegionCache to access descriptors

Clear cache->mr so that address_space_cache_destroy does nothing the second time it is called. Signed-off-by: Paolo Bonzini --- v1->v2: rebased on new patch 3, rely on previous patch hw/virtio/virtio.c| 80 +--

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

On 24/01/2017 16:05, Michael S. Tsirkin wrote: >> >> So we have four cases: >> >> - assign with emulated irqfd + ISR >> - assign with emulated irqfd >> - assign with irqfd >> - deassign >> >> Currently we don't distinguish the first two, so (which I don't like) >> Shannon's patch ends up setting

Re: [Qemu-devel] [PATCH] cirrus: fix oob access issue

On 01/24/17 16:31, Wolfgang Bumiller wrote: > On Tue, Jan 24, 2017 at 01:29:58PM +0100, Gerd Hoffmann wrote: >> if (pitch < 0) { >> int64_t min = addr >> -+ ((int64_t)s->cirrus_blt_height-1) * pitch; >> ++ ((int64_t)s->cirrus_blt_height-1) *

Re: [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23)

Peter Maydell writes: > On 24 January 2017 at 13:24, Peter Maydell wrote: >> I get a failure in the docs on OSX: >> GEN qemu-doc.txt >> CC qapi/qapi-visit-core.o >> /Users/pm215/src/qemu-for-merges/qemu-doc.texi:7: warning: >>

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/6] armv7m: Replace armv7m.hack with unassigned_access handler

Peter Maydell writes: > From: Michael Davidsaver > > For v7m we need to catch attempts to execute from special > addresses at 0xfff0 and above. Previously we did this > with the aid of a hacky special purpose lump of memory > in the address

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/6] armv7m: Explicit error for bad vector table

Peter Maydell writes: > From: Michael Davidsaver > > Give an explicit error and abort when a load > from the vector table fails. Architecturally this > should HardFault (which will then immediately > fail to load the HardFault vector and go into

[Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

Hello, The following commit: commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 Author: Juergen Gross Date: Tue Nov 22 07:10:58 2016 +0100 xen: create qdev for each backend device Prevents me from running QEMU on FreeBSD/Xen, the following is printed on the QEMU log: char

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/6] armv7m: MRS/MSR: handle unprivileged access

On 24 January 2017 at 16:25, Alex Bennée wrote: > > Peter Maydell writes: > >> From: Michael Davidsaver >> >> The MRS and MSR instruction handling has a number of flaws: >> * unprivileged accesses should only be able to

Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24

On 24 January 2017 at 16:55, Peter Maydell wrote: > On 24 January 2017 at 09:39, Michael Tokarev wrote: >> Hi! >> This is a next trivial-patches pull request after a long while. >> We had a new release (2.8), new year holidays and other stuff. >> So

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

On Tue, 24 Jan 2017 15:22:15 +0800 Peter Xu wrote: > On Mon, Jan 23, 2017 at 11:03:08AM -0700, Alex Williamson wrote: > > On Mon, 23 Jan 2017 11:34:29 +0800 > > Peter Xu wrote: > > > > > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > >

Re: [Qemu-devel] [PATCH v5 03/18] vfio: allow to notify unmap for very large region

On Tue, 24 Jan 2017 18:25:56 +0800 Peter Xu wrote: > Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big > region. This can be leveraged by QEMU IOMMU implementation to cleanup > existing page mappings for an entire iova address space (by notifying > with an

Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24

On 24 January 2017 at 09:39, Michael Tokarev wrote: > Hi! > This is a next trivial-patches pull request after a long while. > We had a new release (2.8), new year holidays and other stuff. > So here we go now with whatever has been collected so far. > > Please consider applying.

Re: [Qemu-devel] [PATCH] vhost: skip ROM sections

On 24/01/2017 18:11, Michael S. Tsirkin wrote: > vhost does not support RO protections on memory at the moment - adding > ROMs would mean that e.g. a buggy guest might change them in-memory - a > condition from which guest reset does not recover. Not nice. > > We also definitely don't want to try

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

On 24 January 2017 at 17:40, Paolo Bonzini wrote: > But is really lsi53c895a the best we can provide for > versatilepb/versatileab/realview-eb/realview-eb-mpcore? Could virtio-pci > work well too?... I assume that people will still have legacy kernel images which include the

Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Introduce Generic PCI Express Root Port

On Mon, 2017-01-23 at 21:20 +0200, Marcel Apfelbaum wrote: > v2 -> v3: > - Keep only the root port base class code in pcie_root_port.c (Michael) > - Use msix for the generic root port implementation (Michael and Gerd) >- The task required some refactoring like having some common >

Re: [Qemu-devel] [PATCH V2] hw/pci: disable pci-bridge's shpc by default

On Tue, Jan 24, 2017 at 06:23:49PM +0200, Marcel Apfelbaum wrote: > On 01/11/2017 01:46 PM, Marcel Apfelbaum wrote: > > The shpc component is optional while ACPI hotplug is used > > for hot-plugging PCI devices into a PCI-PCI bridge. > > Disabling the shpc by default will make slot 0 usable at

Re: [Qemu-devel] [PATCH 0/7] virtio: use MemoryRegionCache for descriptors and rings

On Fri, Jan 20, 2017 at 06:07:50PM +0100, Paolo Bonzini wrote: > Patch posted during 2.8 hard freeze. Quick measurements give a 10% > performance improvement on various virtio-blk benchmarks, but the machine > I used seems to love my patches particularly today! > > Paolo Looks nice to me. I'll

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/6] hw/registerfields.h: Pull FIELD etc macros out of hw/register.h

Peter Maydell writes: > hw/register.h provides macros like FIELD which make it easy to define > shift, mask and length constants for the fields within a register. > Unfortunately register.h also includes a lot of other things, some > of which will only compile in the

[Qemu-devel] [PATCH] vhost: skip ROM sections

vhost does not support RO protections on memory at the moment - adding ROMs would mean that e.g. a buggy guest might change them in-memory - a condition from which guest reset does not recover. Not nice. We also definitely don't want to try logging writes into ROMs - in particular guests set very

[Qemu-devel] [PATCH v2 0/8] virtio: use MemoryRegionCache for descriptors and rings

Compared to v1, I have improved error recovery (thanks to Stefan for the great review!). Patch 3 is pretty much rewritten, making patch 4 also much easier to review hopefully. Paolo Paolo Bonzini (8): virtio: make virtio_should_notify static virtio: add virtio_*_phys_cached virtio: use

Re: [Qemu-devel] [PATCH 3/7] virtio: use address_space_map/unmap to access descriptors

On 24/01/2017 13:30, Stefan Hajnoczi wrote: > On Fri, Jan 20, 2017 at 06:07:53PM +0100, Paolo Bonzini wrote: >> @@ -455,10 +455,18 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned >> int *in_bytes, >> goto err; >> } >> >> -desc_pa = vq->vring.desc; >> -

Re: [Qemu-devel] [PATCH] pci: mark ROMs read-only

On 19/01/2017 22:00, Michael S. Tsirkin wrote: > Looks like we didn't mark PCI ROMs as RO allowing > mischief such as guests writing there. > Further, e.g. vhost gets confused trying to allocate > enough space to log writes there. Fix it up. > > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

On Tue, 24 Jan 2017 18:25:55 +0800 Peter Xu wrote: > A cleanup for vfio_iommu_map_notify(). Should have no functional change, > just to make the function shorter and easier to understand. > > Signed-off-by: Peter Xu > --- > hw/vfio/common.c | 58 >

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/6] armv7m: Fix reads of CONTROL register bit 1

Peter Maydell writes: > From: Michael Davidsaver > > The v7m CONTROL register bit 1 is SPSEL, which indicates > the stack being used. We were storing this information > not in v7m.control but in the separate v7m.other_sp > structure field.

Re: [Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties

On 01/24/2017 04:53 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- The commit message is rather sparse; is there an easy formula for triggering the error message, to give more context about the change? > qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [Qemu-arm] [PATCH 6/6] armv7m: Clear FAULTMASK on return from non-NMI exceptions

Peter Maydell writes: > From: Michael Davidsaver > > FAULTMASK must be cleared on return from all > exceptions other than NMI. > > Signed-off-by: Michael Davidsaver > Reviewed-by: Peter Maydell

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/6] armv7m: Fix reads of CONTROL register bit 1

On 24 January 2017 at 16:58, Alex Bennée wrote: > > Peter Maydell writes: >> --- a/target/arm/machine.c >> +++ b/target/arm/machine.c >> @@ -96,15 +96,13 @@ static bool m_needed(void *opaque) >> >> static const VMStateDescription vmstate_m = {

Re: [Qemu-devel] changeset b0cb0a66d broken - missing QEMU_OPTION_enable_hax

On Mon, Jan 23, 2017 at 07:41:48PM +, Peter Maydell wrote: > On 23 January 2017 at 19:32, James Hanley wrote: > > Changeset fails to compile: > > > > qemu/vl.c:3683:18: error: ‘QEMU_OPTION_enable_hax’ undeclared (first use in > > this function) > > case

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

On 24 January 2017 at 17:20, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 24/01/2017 13:56, Markus Armbruster wrote: >>> So, what do we want to deprecate? >>> >>> I think the onboard SCSI HBA adopting if=scsi drives should stay, >>> because it

Re: [Qemu-devel] changeset b0cb0a66d broken - missing QEMU_OPTION_enable_hax

On 24 January 2017 at 17:28, Michael S. Tsirkin wrote: > Maybe we should change the include order to always prefer > the build tree files if there? If we can do that it would be nice. > An alternative is to do what Linux does, create a > file in tree when doing a build, and

[Qemu-devel] [PATCH 1/8] virtio: make virtio_should_notify static

Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

[Qemu-devel] [PATCH 4/8] exec: make address_space_cache_destroy idempotent

Clear cache->mr so that address_space_cache_destroy does nothing the second time it is called. Signed-off-by: Paolo Bonzini --- exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index f2bed92..5de15cf 100644 --- a/exec.c +++ b/exec.c @@ -3165,6

Re: [Qemu-devel] [PATCH V2] hw/pci: disable pci-bridge's shpc by default

On 01/11/2017 01:46 PM, Marcel Apfelbaum wrote: The shpc component is optional while ACPI hotplug is used for hot-plugging PCI devices into a PCI-PCI bridge. Disabling the shpc by default will make slot 0 usable at boot time and not only for hot-plug, without loosing any functionality. Older

Re: [Qemu-devel] [PATCH v9 00/11] Convert msix_init() to error

On Tue, Jan 17, 2017 at 02:18:45PM +0800, Cao jin wrote: > v9 changelog: > 1. split previous patch 3 into two separate patches(3 & 4), per mst's review. So I merged 1-3, making progress here. I really don't like forcing all callers to check and assert on specific return status, IMO most callers

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

On 24/01/2017 18:24, Peter Maydell wrote: > On 24 January 2017 at 17:20, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 24/01/2017 13:56, Markus Armbruster wrote: So, what do we want to deprecate? I think the onboard SCSI HBA

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

On Tue, Jan 24, 2017 at 04:50:44PM +0100, Paolo Bonzini wrote: > > > On 24/01/2017 16:05, Michael S. Tsirkin wrote: > >> > >> So we have four cases: > >> > >> - assign with emulated irqfd + ISR > >> - assign with emulated irqfd > >> - assign with irqfd > >> - deassign > >> > >> Currently we

Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Introduce Generic PCI Express Root Port

On 01/24/2017 05:52 PM, Andrea Bolognani wrote: On Mon, 2017-01-23 at 21:20 +0200, Marcel Apfelbaum wrote: v2 -> v3: - Keep only the root port base class code in pcie_root_port.c (Michael) - Use msix for the generic root port implementation (Michael and Gerd) - The task required some

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/6] armv7m: MRS/MSR: handle unprivileged access

Peter Maydell writes: > From: Michael Davidsaver > > The MRS and MSR instruction handling has a number of flaws: > * unprivileged accesses should only be able to read >CONTROL and the xPSR subfields, and only write APSR >(others RAZ/WI)

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/6] armv7m: Replace armv7m.hack with unassigned_access handler

On 24 January 2017 at 16:31, Alex Bennée wrote: > > Peter Maydell writes: >> -/* Hack to map an additional page of ram at the top of the address >> - space. This stops qemu complaining about executing code outside RAM >> - when

Re: [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23)

On 23 January 2017 at 23:27, Eduardo Habkost wrote: > The following changes since commit 3879284d6517dc22529395bdb259f4183b589127: > > Merge remote-tracking branch 'remotes/berrange/tags/pull-qio-2017-01-23-2' > into staging (2017-01-23 15:59:09 +) > > are available in

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] ARMv7M: some simple bugfixes and cleanups

Peter Maydell writes: > This set of six patches is some simple bug fixes which > I've pulled out of Michael Davidsaver's old NVIC rewrite > patchset, as an initial start on getting it upstream. > None of them are particularly exciting, but they're > self-contained so

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

Paolo Bonzini writes: > On 24/01/2017 13:56, Markus Armbruster wrote: >> So, what do we want to deprecate? >> >> I think the onboard SCSI HBA adopting if=scsi drives should stay, >> because it matches what we do for other interface types. Unless we >> wanted to deprecate

Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24

On 24 January 2017 at 09:39, Michael Tokarev wrote: > Hi! > This is a next trivial-patches pull request after a long while. > We had a new release (2.8), new year holidays and other stuff. > So here we go now with whatever has been collected so far. > > Please consider applying.

[Qemu-devel] [PATCH 6/8] virtio: add MemoryListener to cache ring translations

The cached translations are RCU-protected to allow efficient use when processing virtqueues. Signed-off-by: Paolo Bonzini --- v1->v2: fix memory leak on error [Stefan] hw/virtio/virtio.c | 92 --

[Qemu-devel] [PATCH v2] migration: re-active images while migration been canceled after inactive them

commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case which migration aborted QEMU because it didn't regain the control of images while some errors happened. Actually, there are another two cases can trigger the same error reports: " bdrv_co_do_pwritev: Assertion `!(bs->open_flags &

Re: [Qemu-devel] [PATCH] vnc: fix overflow in vnc_update_stats

Hi - Original Message - > Commit "bea60dd ui/vnc: fix potential memory corruption issues" is > incomplete. vnc_update_stats must calculate width and height the same > way vnc_refresh_server_surface does it, to make sure we don't use width > and height values larger than the qemu vnc

[Qemu-devel] [PATCH] colo-compare: sort TCP packet queue by sequence number

Improve efficiency of TCP packet comparison. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian --- net/colo-compare.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c

Re: [Qemu-devel] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

24.01.2017 10:09, Fam Zheng wrote: On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 32

[Qemu-devel] [PATCH] vnc: fix overflow in vnc_update_stats

Commit "bea60dd ui/vnc: fix potential memory corruption issues" is incomplete. vnc_update_stats must calculate width and height the same way vnc_refresh_server_surface does it, to make sure we don't use width and height values larger than the qemu vnc server can handle. Commit "e22492d ui/vnc:

Re: [Qemu-devel] [PATCH 03/21] backup: improve non-dirty bits progress processing

24.01.2017 10:17, Fam Zheng wrote: On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: Set fake progress for non-dirty clusters in copy_bitmap initialization, to: 1. set progress in the same place where corresponding clusters are consumed from copy_bitmap (or not initialized, as here) 2.

Re: [Qemu-devel] [PATCH 08/21] backup: skip unallocated clusters for full mode

24.01.2017 10:59, Fam Zheng wrote: On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 index 1d3fd04..388b7b2 100755 --- a/tests/qemu-iotests/055 +++ b/tests/qemu-iotests/055 @@ -30,6 +30,7 @@ target_img =

Re: [Qemu-devel] [PATCH 08/21] backup: skip unallocated clusters for full mode

On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 > index 1d3fd04..388b7b2 100755 > --- a/tests/qemu-iotests/055 > +++ b/tests/qemu-iotests/055 > @@ -30,6 +30,7 @@ target_img = os.path.join(iotests.test_dir, 'target.img') >

[Qemu-devel] [PATCH] hw/vfio/pci-quirks: Set category of the "vfio-pci-igd-lpc-bridge" device

The device has "bridge" in its name, so it should obviously be in the category DEVICE_CATEGORY_BRIDGE. Signed-off-by: Thomas Huth --- hw/vfio/pci-quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index 811eecd..4891b37

Re: [Qemu-devel] [PATCH v6 2/5] migration: Add a new option to enable only-migratable

Ashijeet Acharya wrote: > Add a new option "--only-migratable" in qemu which will allow to add > only those devices which will not fail qemu after migration. Devices > set with the flag 'unmigratable' cannot be added when this option will > be used. > > Signed-off-by:

[Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS

Added Marc-André and Gerd to the CC list. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1658634 Title: Can't get correct display with latest QEMU and OVMF BIOS Status in QEMU: Confirmed Bug

[Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS

For reference, this is my script: ISO=ubuntu-16.04.1-desktop-amd64.iso CODE=OVMF_CODE.fd TMPL=OVMF_VARS.fd cp $TMPL vars.fd qemu-system-x86_64 \ -m 1024 \ -M pc,accel=kvm \ -device VGA \ -drive if=pflash,readonly,format=raw,file=$CODE \ -drive if=pflash,format=raw,file=vars.fd \

Re: [Qemu-devel] [PATCH 07/17] qapi: add dirty-bitmaps migration capability

Vladimir Sementsov-Ogievskiy wrote: > Reviewed-by: John Snow > Reviewed-by: Eric Blake > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela

Re: [Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

On Tue, Jan 24, 2017 at 1:52 AM, Rafael David Tinoco < rafael.tin...@canonical.com> wrote: > Christian, could you please move Xenial for me ? I have some > end users waiting for this. Thank you very much. > I can't - IIRC that is up to the SRU Team, I pinged the #ubuntu-release channel if one

Re: [Qemu-devel] [PATCH 1/2] niagara: fail if a firmware file is missing

Peter Maydell writes: > On 23 January 2017 at 22:17, Peter Maydell wrote: >> On 23 January 2017 at 21:21, Artyom Tarasenko wrote: >>> Suggested-by: Peter Maydell >>> Signed-off-by: Artyom

Re: [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available

Your series lacks threading: the patches don't carry In-Reply-To and References headers. The easiest way to fix that is sending them with git-send-email --thread. You should be able to omit --thread; it's the default unless configured otherwise. Artyom Tarasenko writes: >

Re: [Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --only-migratable

Ashijeet Acharya wrote: > migrate_add_blocker should rightly fail if the '--only-migratable' > option was specified and the device in use should not be able to > perform the action which results in an unmigratable VM. > > Make migrate_add_blocker return -EACCES in this

Re: [Qemu-devel] [PATCH 04/17] migration: introduce postcopy-only pending

Vladimir Sementsov-Ogievskiy wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS

I downloaded "ubuntu-16.04.1-desktop-amd64.iso" (MD5: 17643c29e3c4609818f26becf76d29a3), and I can reproduce the issue -- the grub2 display is corrupt. (I didn't even look further than that.) I also confirm that it works fine with the same firmware, but using QEMU 2.7. Here's the result of the

Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value

On 17/01/2017 17:01, Michael S. Tsirkin wrote: >>> Doesn't do it for megasas & hcd-xhci, later patches will fix them. >>> >>> Signed-off-by: Cao jin > I don't like this one, frankly. That's a bunch of code duplication. > I suspect vfio is the only one who might

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

Peter Maydell writes: > On 24 January 2017 at 17:40, Paolo Bonzini wrote: >> But is really lsi53c895a the best we can provide for >> versatilepb/versatileab/realview-eb/realview-eb-mpcore? Could virtio-pci >> work well too?... > > I assume that

[Qemu-devel] [PATCH 10/10] armv7m: R14 should reset to 0xffffffff

For M profile (unlike A profile) the reset value of R14 is specified as 0x. (The rationale is that this is an illegal exception return value, so if guest code tries to return to it it will result in a helpful exception.) Registers r0 to r12 and the flags are architecturally UNKNOWN on

[Qemu-devel] [PATCH 04/10] armv7m: implement CCR, CFSR, HFSR, DFSR, BFAR, and MMFAR

From: Michael Davidsaver Implement the v7M system registers CCR, CFSR, HFSR, DFSR, BFAR and MMFAR. For the moment these simply read as written (with some basic handling of RAZ/WI bits and W1C semantics). Signed-off-by: Michael Davidsaver [PMM:

[Qemu-devel] [PATCH 01/10] target/arm: Drop IS_M() macro

We only use the IS_M() macro in two places, and it's a bit of a namespace grab to put in cpu.h. Drop it in favour of just explicitly calling arm_feature() in the places where it was used. Signed-off-by: Peter Maydell --- target/arm/cpu.h| 6 --

Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value

On Tue, Jan 24, 2017 at 07:18:14PM +0100, Paolo Bonzini wrote: > > > On 17/01/2017 17:01, Michael S. Tsirkin wrote: > >>> Doesn't do it for megasas & hcd-xhci, later patches will fix them. > >>> > >>> Signed-off-by: Cao jin > > I don't like this one, frankly. That's a

Re: [Qemu-devel] [PATCH v2 0/8] virtio: use MemoryRegionCache for descriptors and rings

On Tue, Jan 24, 2017 at 10:26:27AM -0800, no-re...@patchew.org wrote: > qemu-system-x86_64: /tmp/qemu-test/src/exec.c:3180: > address_space_translate_cached: Assertion `addr < cache->len && *plen <= > cache->len - addr' failed. > make: *** [check-tests/test-qga] Error 1 > make: *** Waiting for

[Qemu-devel] [PATCH 2/8] virtio: add virtio_*_phys_cached

Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-access.h | 52 +++ 1 file changed, 52 insertions(+) diff --git a/include/hw/virtio/virtio-access.h

[Qemu-devel] [PATCH 7/8] virtio: use VRingMemoryRegionCaches for descriptor ring

Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 548a3c7..b664b6e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

On 01/24/2017 02:26 AM, Stafford Horne wrote: > If you are having problems booting, both mainline (4.10-rc5) and > linux-next (i.e. next-201701124) should be able to boot. i.e. > > export ARCH=openrisc > make defconfig # defconfig works fine on qemu > > # make any updates to

[Qemu-devel] [PATCH 07/10] armv7m: Report no-coprocessor faults correctly

For v7M attempts to access a nonexistent coprocessor are reported differently from plain undefined instructions (as UsageFaults of type NOCP rather than type UNDEFINSTR). Split them out into a new EXCP_NOCP so we can report the FSR value correctly. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 03/10] armv7m: add state for v7M CCR, CFSR, HFSR, DFSR, MMFAR, BFAR

Add the structure fields, VMState fields, reset code and macros for the v7M system control registers CCR, CFSR, HFSR, DFSR, MMFAR and BFAR. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 54 target/arm/cpu.c

[Qemu-devel] [PATCH 06/10] armv7m: set CFSR.UNDEFINSTR on undefined instructions

From: Michael Davidsaver When we take an exception for an undefined instruction, set the appropriate CFSR bit. Signed-off-by: Michael Davidsaver [PMM: tweaked commit message, comment] Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 01/15] MAINTAINERS: Add myself as a migration submaintainer

From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Reviewed-by: Juan Quintela Message-Id: <20170124100437.18200-1-dgilb...@redhat.com> Signed-off-by: Dr. David Alan

[Qemu-devel] [PULL 06/15] block/vvfat: Remove the undesirable comment

From: Ashijeet Acharya Remove the "// assert(is_consistent(s))" comment in block/vvfat.c Signed-off-by: Ashijeet Acharya Message-Id: <1484566314-3987-2-git-send-email-ashijeetacha...@gmail.com> Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v3 6/8] trace: switch to modular code generation for sub-directories

Daniel P Berrange writes: > Introduce rules in the top level Makefile that are able to generate > trace.[ch] files in every subdirectory which has a trace-events file. > The top level directory is handled specially, so instead of creating > trace.h, it creates trace-root.h. This allows

[Qemu-devel] [PATCH 05/10] armv7m: honour CCR.STACKALIGN on exception entry

From: Michael Davidsaver The CCR.STACKALIGN bit controls whether the CPU is supposed to force 8-alignment of the stack pointer on entry to the exception handler. Signed-off-by: Michael Davidsaver [PMM: commit message and comment tweaks]

Re: [Qemu-devel] [PATCH 05/10] armv7m: honour CCR.STACKALIGN on exception entry

On 01/24/2017 11:16 AM, Peter Maydell wrote: > The CCR.STACKALIGN bit controls whether the CPU is supposed to force > 8-alignment of the stack pointer on entry to the exception handler. 8... > +/* Align stack pointer if the guest wants that */ > +if ((env->regs[13] & 4) && (env->v7m.ccr

Re: [Qemu-devel] [PULL 0/2] s390x fixes

> > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20170124 > > for you to fetch changes up to 0cf4d747cb8d053e6a6161aadfd3531fa1a62be1: > > s390x/kvm: fix cmma reset for KVM (2017-01-24 15:47:31 +0100) > >

Re: [Qemu-devel] [PATCH 03/17] migration: split common postcopy out of ram postcopy

* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 24.01.2017 12:24, Juan Quintela wrote: > > Vladimir Sementsov-Ogievskiy wrote: > > > Split common postcopy staff from ram postcopy staff. > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v7 05/27] tcg: add options for enabling MTTCG

Richard Henderson writes: > On 01/19/2017 09:04 AM, Alex Bennée wrote: >> +void qemu_tcg_configure(QemuOpts *opts, Error **errp) >> +{ >> +const char *t = qemu_opt_get(opts, "thread"); >> +if (t) { >> +if (strcmp(t, "multi") == 0) { >> +if

[Qemu-devel] [PATCH 3/8] virtio: use address_space_map/unmap to access descriptors

This makes little difference, but it makes the code change smaller for the next patch that introduces MemoryRegionCache. This is because map/unmap are similar to MemoryRegionCache init/destroy. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 103

[Qemu-devel] [PULL 00/15] migration queue

From: "Dr. David Alan Gilbert" The following changes since commit a678502e4f7580a6f143f680404aaee57ac3f4b5: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-01-24 15:39:09 +) are available in the git repository

[Qemu-devel] [PATCHv2] vhost-user: delete chardev on cleanup

Remove the chardev implicitely when cleaning up the netdev. This prevents from reusing the chardev since it would be in an incorrect state with the slave. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1256618 Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH v2 7/8] util: add iterators for QemuOpts values

On 01/24/2017 03:53 AM, Daniel P. Berrange wrote: > To iterate over all QemuOpts currently requires using a callback > function which is inconvenient for control flow. Add support for > using iterator functions more directly > > QemuOptsIter iter; > QemuOpt *opt; > > qemu_opts_iter_init(,

Re: [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC listen addresses

On 01/24/2017 03:53 AM, Daniel P. Berrange wrote: > This change allows the listen address and websocket address > options for -vnc to be repeated. This causes the VNC server > to listen on multiple addresses. e.g. > > $ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\ >

[Qemu-devel] [PATCH 09/10] armv7m: FAULTMASK should be 0 on reset

From: Michael Davidsaver For M profile CPUs, FAULTMASK should be 0 on reset, like PRIMASK. QEMU stores FAULTMASK in the PSTATE F bit, so (as with PRIMASK in the I bit) we have to clear these to undo the A profile default of 1. Update the comment accordingly and move it so

Re: [Qemu-devel] [PATCHv2] vhost-user: delete chardev on cleanup

On 01/24/2017 01:02 PM, Marc-André Lureau wrote: > Remove the chardev implicitely when cleaning up the netdev. This s/implicitely/implicitly/ > prevents from reusing the chardev since it would be in an incorrect > state with the slave. > > Fixes: >

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

On Tue, 2017-01-24 at 17:36 +, Dr. David Alan Gilbert wrote: > * David Dai (z...@linux.vnet.ibm.com) wrote: > > Using libvirt to do live migration over RDMA via ip v6 address failed. > > For example: > > # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ > >

[Qemu-devel] [PULL 10/15] migration: Fail migration blocker for --only-migratable

From: Ashijeet Acharya migrate_add_blocker should rightly fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Make migrate_add_blocker return -EACCES in this case.

[Qemu-devel] [PULL 03/15] migration: migrate QTAILQ

From: Jianjun Duan Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be

[Qemu-devel] [PULL 14/15] migration: transform remaining DPRINTF into trace_

From: Juan Quintela So we can remove DPRINTF() macro Signed-off-by: Juan Quintela Message-Id: <1485207141-1941-2-git-send-email-quint...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 13/15] PCI/migration merge vmstate_pci_device and vmstate_pcie_device

From: "Dr. David Alan Gilbert" The vmstate_pci_device and vmstate_pcie_devices differ just in the size of one buffer; combine the two using a _TEST macro. I think this is safe as long as everywhere which currently uses either of these two uses the right type. One thing

[Qemu-devel] [PULL 07/15] migration: Add a new option to enable only-migratable

From: Ashijeet Acharya Add a new option "--only-migratable" in qemu which will allow to add only those devices which will not fail qemu after migration. Devices set with the flag 'unmigratable' cannot be added when this option will be used. Signed-off-by: Ashijeet

  1   2   3   4   5   >