[Qemu-devel] [PULL 3/4] cirrus: fix blit address mask handling

2017-02-02 Thread Gerd Hoffmann
Apply the cirrus_addr_mask to cirrus_blt_dstaddr and cirrus_blt_srcaddr right after assigning them, in cirrus_bitblt_start(), instead of having this all over the place in the cirrus code, and missing a few places. Reported-by: Wolfgang Bumiller Signed-off-by: Gerd Hoffmann Message-id: 1485338996

[Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615)

2017-02-02 Thread Gerd Hoffmann
From: Li Qiang When doing bitblt copy in backward mode, we should minus the blt width first just like the adding in the forward mode. This can avoid the oob access of the front of vga's vram. Signed-off-by: Li Qiang Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann Message-id: 1485938101

[Qemu-devel] [PULL 0/4] cirrus: multiple bugfixes, including CVE-2017-2615 fix.

2017-02-02 Thread Gerd Hoffmann
ailable in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20170202-1 for you to fetch changes up to 31b1a6bb0f8ead5c0b21f23daf3054e3ccbc215e: cirrus: fix oob access issue (CVE-2017-2615) (2017-02-01 14:43:10 +0100) -

[Qemu-devel] [PULL 2/4] cirrus: allow zero source pitch in pattern fill rops

2017-02-02 Thread Gerd Hoffmann
From: Wolfgang Bumiller The rops used by cirrus_bitblt_common_patterncopy only use the destination pitch, so the source pitch shoul allowed to be zero and the blit with used for the range check around the source address. Signed-off-by: Wolfgang Bumiller Message-id: 1485272138-23249-1-git-send-e

[Qemu-devel] [PULL 1/4] cirrus: handle negative pitch in cirrus_invalidate_region()

2017-02-02 Thread Gerd Hoffmann
From: Wolfgang Bumiller cirrus_invalidate_region() calls memory_region_set_dirty() on a per-line basis, always ranging from off_begin to off_begin+bytesperline. With a negative pitch off_begin marks the top most used address and thus we need to do an initial shift backwards by a line for negative

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-02 Thread Mark Cave-Ayland
On 02/02/17 05:14, David Gibson wrote: > From: Laurent Vivier > > This is a port to ppc of the i386 commit: > 00f4d64 kvmclock: clock should count only if vm is running > > We remove timebase_post_load function, and use the VM state > change handler to save and restore the guest_timebase (o

[Qemu-devel] [Bug 1661176] [NEW] [2.8.0] Under VNC CTRL-ALT-2 doesn't get to the monitor

2017-02-02 Thread Uqbar
Public bug reported: With version 2.6.2 I could access the monitor via VNC by pressing CTRL-ALT-2, while CTRL-ALT-3 brought me to the "serial0 console". CTRL-ALT-1 brought me back to the VGA console. Since 2.8.0 CTRL-ALT-2 brings me to the "serial0 console" and CTRL-ALT-3 to the "parallel0 cons

Re: [Qemu-devel] [PATCH 1/2] qemu-io: don't allow I/O operations larger than INT_MAX

2017-02-02 Thread Alberto Garcia
On Wed 01 Feb 2017 11:16:38 PM CET, Max Reitz wrote: > Thanks, applied to my block tree, with > %s/INT_MAX/BDRV_REQUEST_MAX_BYTES/g: I think you can use %d to print BDRV_REQUEST_MAX_BYTES, after all the definition guarantees that it won't be larger than MIN(SIZE_MAX,INT_MAX) But it's fine with

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-02 Thread Laurent Vivier
On 02/02/2017 09:37, Mark Cave-Ayland wrote: > On 02/02/17 05:14, David Gibson wrote: > ... > Hi David/Laurent, Hi Mark, > I just noticed this in your pull request today - this looks like it is > along similar lines to the prototype patch I proposed last year as part > of the decrementer migrati

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE

2017-02-02 Thread Denis V. Lunev
On 02/01/2017 04:53 PM, Daniel P. Berrange wrote: > On Wed, Feb 01, 2017 at 04:15:28PM +0300, Denis V. Lunev wrote: >> From: Anton Nefedov >> >> Socket backend read handler should normally perform a disconnect, however >> the read handler may not get a chance to run if the frontend is not ready >>

Re: [Qemu-devel] [PATCH RFC] mem-prealloc: Reduce large guest start-up and migration time.

2017-02-02 Thread Jitendra Kolhe
On 1/27/2017 6:56 PM, Daniel P. Berrange wrote: > On Thu, Jan 05, 2017 at 12:54:02PM +0530, Jitendra Kolhe wrote: >> Using "-mem-prealloc" option for a very large guest leads to huge guest >> start-up and migration time. This is because with "-mem-prealloc" option >> qemu tries to map every guest p

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 11:59:22AM +0300, Denis V. Lunev wrote: > On 02/01/2017 04:53 PM, Daniel P. Berrange wrote: > > On Wed, Feb 01, 2017 at 04:15:28PM +0300, Denis V. Lunev wrote: > >> From: Anton Nefedov > >> > >> Socket backend read handler should normally perform a disconnect, however > >>

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE

2017-02-02 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 04:54:28PM -0800, Paolo Bonzini wrote: > > > On 01/02/2017 05:53, Daniel P. Berrange wrote: > >> > >> +if (ret < 0 && errno == EPIPE) { > > IMHO you should just remove "&& errno == EPIPE" and it'd be fine. > > It should be errno != EAGAIN. Oh, yes, thats right.

Re: [Qemu-devel] [PULL v2 00/11] ui patch queue

2017-02-02 Thread Peter Maydell
On 31 January 2017 at 15:50, Gerd Hoffmann wrote: > Hi, > > Here comes the ui patch queue. Nothing outstanding here. Bugfixes and > small improvements all user interfaces. > > v2 updates: > * change "C.utf-8" locale to "C.UTF-8". > * add forgotten "fix console resize" patch. > > please pul

Re: [Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2017-02-02 Thread P J P
+-- On Thu, 26 Jan 2017, P J P wrote --+ | +-- On Mon, 26 Sep 2016, P J P wrote --+ | | +-- On Fri, 23 Sep 2016, Jason Wang wrote --+ | | | Actually the patch does not apply cleanly. Please fix and repost. | | | | The 'net: imx:...' patch is for v2.6 series. I missed to indicate that | | in Pat

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > Patch for secure implementation in libqnio is available for review here: > > https://github.com/VeritasHyperScale/libqnio/pull/12 IMHO, we really don't want libqnio to be doing the SSL handling itself. QEMU has a standardized API

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-02 Thread Stefan Hajnoczi
On Tue, Jan 31, 2017 at 05:55:47PM -0800, ashish mittal wrote: > Hi, > > There has been some work going on on the VxHS libvirt patches and we > are making good progress. > > A suggestion has been made on the libvirt community to check if we can > change the qemu VxHS device specification syntax a

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Stefan Hajnoczi
On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > Patch for secure implementation in libqnio is available for review here: > > https://github.com/VeritasHyperScale/libqnio/pull/12 > > libqnio client initialization now has an option to use X.509 certificates to > authenticate it

Re: [Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615)

2017-02-02 Thread Laszlo Ersek
On 02/02/17 09:23, Gerd Hoffmann wrote: > From: Li Qiang > > When doing bitblt copy in backward mode, we should minus the > blt width first just like the adding in the forward mode. This > can avoid the oob access of the front of vga's vram. > > Signed-off-by: Li Qiang > Reviewed-by: Laszlo Ers

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-02-02 Thread Stefan Hajnoczi
On Wed, Feb 01, 2017 at 08:25:10PM +, Marc-André Lureau wrote: > Hi > > On Wed, Feb 1, 2017 at 8:26 PM Stefan Hajnoczi wrote: > > > On Mon, Jan 30, 2017 at 01:18:16PM -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Tue, Jan 24, 2017 at 01:43:17PM

Re: [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1

2017-02-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/01/2017 22:49, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 31/01/2017 12:40, Markus Armbruster wrote: > > #define QEMU_NORETURN __attribute__ ((__noreturn__)) > > -#if QEMU_GNUC_PREREQ(3, 4) > #define QEMU_WARN_UNUSED_RESUL

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 10:07:28AM +, Stefan Hajnoczi wrote: > On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > > Patch for secure implementation in libqnio is available for review here: > > > > https://github.com/VeritasHyperScale/libqnio/pull/12 > > > > libqnio client ini

Re: [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

2017-02-02 Thread Stefan Hajnoczi
On Wed, Feb 01, 2017 at 12:29:22PM -0800, Paolo Bonzini wrote: > On 01/02/2017 08:40, Stefan Hajnoczi wrote: > >> +goto out_free_range; > >> +} > >> + > >> +if (dma_buf_write((uint8_t *)range, sizeof(range), &qsg)) { > > > > Did you mean sizeof(*range) * nr? > > Did you also mean

Re: [Qemu-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

2017-02-02 Thread Juergen Gross
On 01/02/17 21:20, Peter Maydell wrote: > On 1 February 2017 at 19:37, Stefano Stabellini > wrote: >> Hi Peter, >> >> do you think this is acceptable? > > The set of operations here is basically what I suggested > in review of v1, so I think it is the right thing. > OTOH this is a bit of an odd

Re: [Qemu-devel] WIKI account

2017-02-02 Thread Stefan Hajnoczi
On Wed, Feb 01, 2017 at 11:11:16PM +0530, Shubham Kumar wrote: > Can someone make an account for me on QEMU wiki ?? I would like to contribute > on QEMU wiki. Done, see private email. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
On Thu, 2017-02-02 at 08:49 +0100, Gerd Hoffmann wrote: > Oh yes, the wonderful confusing world of default devices ;) >  > So, if you run qemu with "-nodefaults" it will not add those two > devices. And I wouldn't have it any other way ;) > If you add a video card manually (via -device or config

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-02 Thread Mark Cave-Ayland
On 02/02/17 09:13, Laurent Vivier wrote: > On 02/02/2017 09:37, Mark Cave-Ayland wrote: >> On 02/02/17 05:14, David Gibson wrote: >> > ... >> Hi David/Laurent, > > Hi Mark, > >> I just noticed this in your pull request today - this looks like it is >> along similar lines to the prototype patch I

Re: [Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
01.02.2017 02:20, Max Reitz wrote: On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 +

[Qemu-devel] [PATCH v3] net: imx: limit buffer descriptor count

2017-02-02 Thread P J P
From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in bd.flags. Set an upper lim

Re: [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-02 Thread Alex Bennée
Peter Maydell writes: > On 27 January 2017 at 10:39, Alex Bennée wrote: >> Some helpers may trigger an immediate exit of the cpu_loop. If this >> happens the PC need to be rectified to ensure the restart will begin >> on the next instruction. >> >> Signed-off-by: Alex Bennée >> --- >> target/

Re: [Qemu-devel] [PATCH 10/17] migration: create ram_multifd_page

2017-02-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> The function still don't use multifd, but we have simplified > >> ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > >> counter and a new flag for

Re: [Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2017-02-02 Thread P J P
Hello Jason, +-- On Thu, 26 Jan 2017, P J P wrote --+ | This patch still isn't merged upstream it seems. Could you please check? -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00380.html I have sent a revised patch v3. Please consider this one. Thank you. -- Prasad J Pandit / R

Re: [Qemu-devel] [PULL 00/41] Chr split patches

2017-02-02 Thread Peter Maydell
On 31 January 2017 at 19:37, Marc-André Lureau wrote: > Hi > > On Tue, Jan 31, 2017 at 11:00 PM Eric Blake wrote: >> >> On 01/31/2017 12:55 PM, Marc-André Lureau wrote: >> >> >> 'make check' fails on a linux-user-targets-only build: >> >> >> >> tests/test-char.o: In function `char_stdio_test_subp

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-02 Thread Markus Armbruster
Ladi Prosek writes: > On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange > wrote: >> On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: >>> On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange >>> wrote: >>> > On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: >>> >> Analo

[Qemu-devel] [Bug 1656710] Re: Please support Ctrl-Alt-= to zoom in

2017-02-02 Thread Thomas Huth
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=66f6b82bf26cc15e33 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1656710 Title: Pleas

Re: [Qemu-devel] [PATCH 10/17] migration: create ram_multifd_page

2017-02-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter and a new flag for this type of pages. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [Bug 740895] Re: qemu freeze when loading msdos with EMM386.EXE NOEMS HIGHSCAN

2017-02-02 Thread Thomas Huth
Triaging old bug tickets ... QEMU 0.11 and 0.14 are pretty much outdated nowadays... can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-02 Thread Peter Maydell
On 2 February 2017 at 11:03, Alex Bennée wrote: > > Peter Maydell writes: >> Does single-stepping (of the emulated architectural >> debug step, and gdbstub singlestep) work across one of >> these instructions? > > I'll have to test but I don't see why not. The instruction is fully > executed we j

[Qemu-devel] [PATCH v2] xhci: guard xhci_kick_epctx against recursive calls

2017-02-02 Thread Gerd Hoffmann
Track xhci_kick_epctx processing being active in a variable. Check the variable before calling xhci_kick_epctx from xhci_kick_ep. Add an assert to make sure we don't call recursively into xhci_kick_epctx. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by:

[Qemu-devel] [PATCH] docs: update manpage for stderr->log rename

2017-02-02 Thread Philipp Gesang
With commit ed7f5f1d8db06fc31352a5ef4f54985e630c575a the name of this backend changed from “stderr” to “log”. Signed-off-by: Philipp Gesang --- qemu-option-trace.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option-trace.texi b/qemu-option-trace.texi index 693

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE

2017-02-02 Thread Denis V. Lunev
On 02/02/2017 12:47 PM, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 11:59:22AM +0300, Denis V. Lunev wrote: >> On 02/01/2017 04:53 PM, Daniel P. Berrange wrote: >>> On Wed, Feb 01, 2017 at 04:15:28PM +0300, Denis V. Lunev wrote: From: Anton Nefedov Socket backend read handle

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 02:43:18PM +0300, Denis V. Lunev wrote: > On 02/02/2017 12:47 PM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 11:59:22AM +0300, Denis V. Lunev wrote: > >> On 02/01/2017 04:53 PM, Daniel P. Berrange wrote: > >>> On Wed, Feb 01, 2017 at 04:15:28PM +0300, Denis V. Lun

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-02 Thread Gerd Hoffmann
Hi, > > If you add a video card manually (via -device or config file entry) qemu > > will not add the default video card. > > > > Likewise, if you add a NIC manually, qemu will not add the default > > ethernet device (and IIRC creating the default netdev will be skipped > > too). > > This has

Re: [Qemu-devel] [PATCH 11/17] migration: Create thread infrastructure for multifd send side

2017-02-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We make the locking and the transfer of information specific, even if we > are still transmiting things through the main thread. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 53 - > 1

Re: [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

2017-02-02 Thread Paolo Bonzini
> On Wed, Feb 01, 2017 at 12:29:22PM -0800, Paolo Bonzini wrote: > > On 01/02/2017 08:40, Stefan Hajnoczi wrote: > > >> +goto out_free_range; > > >> +} > > >> + > > >> +if (dma_buf_write((uint8_t *)range, sizeof(range), &qsg)) { > > > > > > Did you mean sizeof(*range) * nr? > > >

[Qemu-devel] TCG semantics

2017-02-02 Thread E . Robbins
Hello, I having been looking for prior work on a formalised semantics for the TCG language. I have seen passing references, and wondered if anyone can provide any pointers? If this is the wrong list for this question, apologies, please direct me elsewhere. Best, Ed

Re: [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-02 Thread Alex Bennée
Peter Maydell writes: > On 2 February 2017 at 11:03, Alex Bennée wrote: >> >> Peter Maydell writes: >>> Does single-stepping (of the emulated architectural >>> debug step, and gdbstub singlestep) work across one of >>> these instructions? >> >> I'll have to test but I don't see why not. The in

Re: [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-02 Thread Peter Maydell
On 2 February 2017 at 12:17, Alex Bennée wrote: > Peter Maydell writes: >> Your longjump is effectively skipping the normal "end of the TB" code, >> which is what usually does the set_condexec for you. At the end of a >> TB the expectation is that everything's been sync'd back to the CPU >> state

Re: [Qemu-devel] usb3 - xhci - Assertion `intr->er_full' failed

2017-02-02 Thread Martin Cerveny
Hello. On Thu, 2 Feb 2017, Gerd Hoffmann wrote: Hi, - usb with usbredir 0.7.1 What kind of device do you assign to the guest? Keyboard. Where is the verfied windows driver that is compatible/tested with xhci code ? Usually I test with the drivers shipped by the operating system, i.e. l

[Qemu-devel] [PATCH v2 1/3] vmstate_register_with_alias_id: Take an Error **

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I'll be adding an error to it in a subsequent patch. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- hw/core/qdev.c | 3 ++- hw/intc/apic_common.c | 2 +- include/migration/vmstate.h | 5 +++-- migration/savevm.c

[Qemu-devel] [PATCH v2 2/3] migration: Check for ID length

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The qdev id of a device can be huge if it's on the end of a chain of bridges; in reality such chains shouldn't occur but they can be made to by chaining PCIe bridges together. The migration format has a number of 256 character long format limits; check we don't hit

[Qemu-devel] [PATCH v2 0/3] Protect against long IDs

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" QEMU currently asserts if you try and create a PCI device on the end of a very long chain, because the ID string exceeds the maximum length, and ends up aliasing. Fail with a clean error in this common case; there's lots of other places that call the various regis

[Qemu-devel] [PATCH v2 3/3] vmstate registration: check return values

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Check qdev's call to vmstate_register_with_alias_id; that gets most of the common uses; there's hundreds of calls via vmstate_register which could get fixed over time. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- hw/core/qdev.c | 10 +

[Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-02 Thread Denis V. Lunev
From: Anton Nefedov Socket backend read handler should normally perform a disconnect, however the read handler may not get a chance to run if the frontend is not ready (qemu_chr_be_can_write() == 0). This means that in virtio-serial frontend case if - the host has disconnected (giving EPIPE on

[Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header'

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH 14/24] block: add bdrv_can_store_new_dirty_bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 22 ++ include/b

[Qemu-devel] [PATCH 05/24] block: fix bdrv_dirty_bitmap_granularity signature

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 10/24] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 16 block/qcow2-bitmap.c |

[Qemu-devel] [PATCH 08/24] block: introduce auto-loading bitmaps

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps stored in the disk image, which should be loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block.c | 14 +

[Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 01/24] specs/qcow2: fix bitmap granularity qemu-specific note

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0e91..dda53dd2a3 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt

[Qemu-devel] [PATCH 16/24] qmp: add persistent flag to block-dirty-bitmap-add

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c | 18 +- qapi/block-core.json | 8 +++- 2 files changed, 24 ins

[Qemu-devel] [PATCH 17/24] qmp: add autoload parameter to block-dirty-bitmap-add

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c | 18 -- qapi/block-core.json | 6 +- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev

[Qemu-devel] [PATCH 24/24] qmp: block-dirty-bitmap-remove: remove persistent

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from the storage on block-dirty-bitmap-remove. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockdev.c b/blockdev.c index c41b791289..a365cdf3ed 100644 --- a/blockdev.c +++ b/blockdev.c @@ -276

[Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 32 bl

[Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 41 + block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed, 45 insertions(+) diff --git a/block/qcow2-bit

[Qemu-devel] [PATCH 15/24] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 4 3 files changed, 45 insertions(+) diff --g

[Qemu-devel] [PATCH 07/24] qcow2: add bitmaps extension

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 127 +

[Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 488 +-- block/qcow2.c| 1 + block/qcow2.h| 1

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 19 +++ include/block/block_int.h| 3 +++ include/block/dirty-bitmap.h | 3 +++ 3 files changed, 25 insertions(+) diff --git a/block/di

[Qemu-devel] [PATCH 21/24] qcow2-bitmap: refcounts

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img check implementation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 76 ++ block/qcow2-refcount.c | 6 block/qcow2.h

[Qemu-devel] [PATCH v12 00/24] qcow2: persistent dirty bitmaps

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v12. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v12 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v12) v12: 07: do not update header in qcow2_read_extensions, instead do it in the

[Qemu-devel] [PATCH 12/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4d026df1bd..fe34d488aa 100644 --- a/block/dirty

[Qemu-devel] [PATCH 19/24] iotests: test qcow2 persistent dirty bitmap

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 89 ++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100755 tests/qemu-iotests/

[Qemu-devel] [PATCH 18/24] qmp: add x-debug-block-dirty-bitmap-sha256

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-core.json | 27 +++

[Qemu-devel] [PATCH 20/24] qcow2-refcount: rename inc_refcounts() and make it public

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-refcount.c | 53 ++ block/qcow2.h | 4 2 files cha

[Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/Make

[Qemu-devel] [PATCH 06/24] block/dirty-bitmap: add deserialize_ones func

2017-02-02 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

Re: [Qemu-devel] [PATCH v8 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-02 Thread Alex Bennée
Peter Maydell writes: > On 2 February 2017 at 12:17, Alex Bennée wrote: >> Peter Maydell writes: >>> Your longjump is effectively skipping the normal "end of the TB" code, >>> which is what usually does the set_condexec for you. At the end of a >>> TB the expectation is that everything's been

Re: [Qemu-devel] [PATCH v12 00/24] qcow2: persistent dirty bitmaps

2017-02-02 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v12 00/24] qcow2: persistent dirty bitmaps Message-id: 20170202132145.168790-1-vsement...@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL v5 00/22] virtio, vhost, pci: fixes, features

2017-02-02 Thread Peter Maydell
On 31 January 2017 at 20:18, Michael S. Tsirkin wrote: > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-30 10:23:20 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-02 Thread Laurent Vivier
On 02/02/2017 11:40, Mark Cave-Ayland wrote: > On 02/02/17 09:13, Laurent Vivier wrote: > >> On 02/02/2017 09:37, Mark Cave-Ayland wrote: >>> On 02/02/17 05:14, David Gibson wrote: >>> >> ... >>> Hi David/Laurent, >> >> Hi Mark, >> >>> I just noticed this in your pull request today - this looks li

[Qemu-devel] [PATCH v2 1/1] mirror: do not increase offset during initial zero_or_discard phase

2017-02-02 Thread Denis V. Lunev
From: Anton Nefedov If explicit zeroing out before mirroring is required for the target image, it moves the block job offset counter to EOF, then offset and len counters count the image size twice. There is no harm but stats are confusing, specifically the progress of the operation is always repo

[Qemu-devel] [PATCH v3 1/1] qemu-char: socket backend: disconnect on write error

2017-02-02 Thread Denis V. Lunev
From: Anton Nefedov Socket backend read handler should normally perform a disconnect, however the read handler may not get a chance to run if the frontend is not ready (qemu_chr_be_can_write() == 0). This means that in virtio-serial frontend case if - the host has disconnected (giving EPIPE on

[Qemu-devel] [PATCH v2.1 03/21] tcg: support representing vector type with smaller vector or scalar types

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- This is not as bad as I thought it would be. Only two cases: type == base_type and type != base_type. --- tcg/tcg.c | 136 +- 1 file changed, 91 insertions(+), 45 deletions(-) diff --git a/tcg/tcg.c b

[Qemu-devel] [PATCH v2.1 17/21] tcg: introduce qemu_ld_v128 and qemu_st_v128 opcodes

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- tcg/i386/tcg-target.inc.c | 5 + tcg/tcg-op.c | 24 tcg/tcg-op.h | 15 +++ tcg/tcg-opc.h | 4 4 files changed, 48 insertions(+) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i38

[Qemu-devel] [PATCH v2.1 04/21] tcg: add ld_v128, ld_v64, st_v128 and st_v64 opcodes

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- tcg/tcg-op.h | 38 ++ tcg/tcg-opc.h | 18 ++ 2 files changed, 56 insertions(+) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 517745e..250493b 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -501,6 +501,44 @@

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-02-02 Thread Stafford Horne
On Wed, Feb 01, 2017 at 10:15:54AM -0800, Richard Henderson wrote: > On 02/01/2017 02:04 AM, Stafford Horne wrote: > > On Thu, Jan 26, 2017 at 09:26:55AM -0800, Richard Henderson wrote: > >> On 01/26/2017 05:12 AM, Stafford Horne wrote: > >>> I just sent you a mail with a link to my kernel for down

[Qemu-devel] [PATCH v2.1 16/21] tcg: introduce new TCGMemOp - MO_128

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- tcg/tcg.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 5e0c6da..63a83f9 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -306,11 +306,12 @@ typedef enum TCGMemOp { MO_16= 1, MO_32= 2, MO_

[Qemu-devel] [PATCH v2.1 01/21] tcg: add support for 128bit vector type

2017-02-02 Thread Kirill Batuzov
Introduce TCG_TYPE_V128 and corresponding TCGv_v128 for TCG temps. Add helper functions that work with temps of this new type. Signed-off-by: Kirill Batuzov --- tcg/tcg-op.h | 24 tcg/tcg.c| 13 + tcg/tcg.h| 34 ++ 3 fi

[Qemu-devel] [PATCH v2.1 06/21] tcg: use results of alias analysis in liveness analysis

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- tcg/tcg.c | 61 + 1 file changed, 61 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 18d97ec..27e5944 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -564,6 +564,11 @@ static intptr_t tcg_type_size(TCG

[Qemu-devel] [PATCH v2.1 09/21] target/arm: support access to vector guest registers as globals

2017-02-02 Thread Kirill Batuzov
To support vector guest registers as globals we need to do two things: 1) create corresponding globals, 2) mark which globals can overlap, Signed-off-by: Kirill Batuzov --- For vector registers I used the same coding style as was used for scalar registers. Should I change braces placement for t

[Qemu-devel] [PATCH v2.1 13/21] tcg/i386: support remaining vector addition operations

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- I believe checkpatch warning here to be false-positive. --- tcg/i386/tcg-target.h | 10 + tcg/i386/tcg-target.inc.c | 54 +-- 2 files changed, 62 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-ta

[Qemu-devel] [PATCH v2.1 10/21] target/arm: use vector opcode to handle vadd. instruction

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- target/arm/translate.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index d7578e2..90e14df 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -5628,6 +5628,37

[Qemu-devel] [PATCH v2.1 12/21] tcg/i386: support 64-bit vector operations

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- tcg/i386/tcg-target.h | 1 + tcg/i386/tcg-target.inc.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index b0704e8..755ebaa 100644 --- a/tcg/i386/tcg-target.h +++ b/tcg/i386/tcg-tar

[Qemu-devel] [PATCH v2.1 07/21] tcg: allow globals to overlap

2017-02-02 Thread Kirill Batuzov
Sometimes the target architecture may allow some parts of a register to be accessed as a different register. If both of these registers are implemented as globals in QEMU, then their content will overlap and the change to one global will also change the value of the other. To handle such situation

[Qemu-devel] [PATCH v2.1 08/21] tcg: add vector addition operations

2017-02-02 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- Support for representing a v128 addition as two v64 additions have been added. As a result GEN_VECT_WRAPPER_HALVES macro was added. It is larger and more complicated than original GEN_VECT_WRAPPER (which is still used for v64 additions because they do not have h

[Qemu-devel] [PATCH v2.1 00/20] Emulate guest vector operations with host vector operations

2017-02-02 Thread Kirill Batuzov
The goal of these patch series is to set up an infrastructure to emulate guest vector operations using host vector operations. Preliminary experiments show that simply translating loads and stores increases performance of x264 video codec by 10%. The performance of a gcc vectorized for loop increas

[Qemu-devel] [PATCH v2.1 02/21] tcg: add support for 64bit vector type

2017-02-02 Thread Kirill Batuzov
Introduce TCG_TYPE_V64 and corresponding TCGv_v64 for TCG temps. Add helper functions that work with temps of this new type. Signed-off-by: Kirill Batuzov --- tcg/tcg-op.h | 23 +++ tcg/tcg.c| 13 + tcg/tcg.h| 34 ++ 3 files

  1   2   3   >