Re: [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info

2017-02-14 Thread Denis V. Lunev
On 02/14/2017 06:05 PM, Fam Zheng wrote: > On Tue, 02/14 17:48, Vladimir Sementsov-Ogievskiy wrote: >> Currently backup to nbd target is broken, as nbd doesn't have >> .bdrv_get_info realization. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> Hi all! >>

Re: [Qemu-devel] [PATCH v3 2/3] new: debian docker targets for cross-compiling

2017-02-14 Thread Alex Bennée
Peter Maydell writes: > On 14 February 2017 at 10:07, Alex Bennée wrote: >> This provides a basic Debian install with access to the emdebian cross >> compilers. The debian-armhf-cross and debian-arm64-cross targets build >> on the basic Debian

[Qemu-devel] [PATCH v4 3/4] sd: sdhci: conditionally invoke multi block transfer

2017-02-14 Thread P J P
From: Prasad J Pandit In sdhci_write invoke multi block transfer if it is enabled in the transfer mode register 's->trnmod'. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH V8] qqq: module for synchronizing with a simulation

2017-02-14 Thread James J. Nutaro
This patch adds an interface for pacing the execution of QEMU to match an external simulation clock. Its aim is to permit QEMU to be used as a module within a larger simulation system. v6 -> v7 Added a check for command line arguments that are consistent with -qqq and print an error message if

[Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

2017-02-14 Thread P J P
From: Prasad J Pandit Hello, In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode register is used to control 's->blkcnt' value. This bit is not relevant in single block transfers. Also, Transfer Mode register value could be set such that 's->blkcnt'

[Qemu-devel] [PATCH v4 1/4] sd: sdhci: mask transfer mode register value

2017-02-14 Thread P J P
From: Prasad J Pandit In SDHCI protocol, the transfer mode register is defined to be of 6 bits. Mask its value with '0x0037' so that an invalid value could not be assigned. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 3 ++- 1 file

[Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

2017-02-14 Thread P J P
From: Prasad J Pandit In the SDHCI protocol, the transfer mode register value is used during multi block transfer to check if block count register is enabled and should be updated. Transfer mode register could be set such that, block count register would not be updated,

[Qemu-devel] [PATCH v5 5/7] blkdebug: Simplify override logic

2017-02-14 Thread Eric Blake
Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-14 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hi David, > > Thank your, now it's clear. > > On Mon, Feb 13, 2017 at 06:16:02PM +, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > Hello David! > > > > Hi Alexey, > > > > > I have checked

Re: [Qemu-devel] [PATCH 2/9] armv7m: Implement reading and writing of PRIGROUP

2017-02-14 Thread Alex Bennée
Peter Maydell writes: > Add a state field for the v7M PRIGROUP register and implent > reading and writing it. The current NVIC doesn't honour > the values written, but the new version will. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-14 Thread ashish mittal
On Tue, Feb 14, 2017 at 10:12 AM, Jeff Cody wrote: > On Mon, Nov 07, 2016 at 04:59:45PM -0800, Ashish Mittal wrote: >> These changes use a vxhs test server that is a part of the following >> repository: >> https://github.com/MittalAshish/libqnio.git >> >> Signed-off-by: Ashish

Re: [Qemu-devel] [PATCH 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [PATCH v8 1/2] move vm_start to cpus.c

2017-02-14 Thread Claudio Imbrenda
This patch: * moves vm_start to cpus.c. * exports qemu_vmstop_requested, since it's needed by vm_start. * extracts vm_prepare_start from vm_start; it does what vm_start did, except restarting the cpus. * vm_start now calls vm_prepare_start and then restarts the cpus. Signed-off-by: Claudio

Re: [Qemu-devel] [PATCH v8 0/2] Qemu: gdbstub: fix vCont

2017-02-14 Thread Paolo Bonzini
Thanks, I hope to send a pull request this week, including this patch. Paolo On 14/02/2017 18:07, Claudio Imbrenda wrote: > This small patchset fixes the incorrect behaviour of the vCont command > in the gdb stub. > > The first patch, as suggested be Paolo, refactors some code. The most >

[Qemu-devel] [PATCH v5 7/7] tests: Add coverage for recent block geometry fixes

2017-02-14 Thread Eric Blake
Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries.

Re: [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work

2017-02-14 Thread Daniel P. Berrange
On Mon, Feb 13, 2017 at 06:19:43PM +0100, Juan Quintela wrote: > We create new channels for each new thread created. We only send through > them a character to be sure that we are creating the channels in the > right order. > > Signed-off-by: Juan Quintela > --- >

Re: [Qemu-devel] [PATCH v4] sd: sdhci: mask transfer mode register value

2017-02-14 Thread P J P
Hello Petr, +-- On Tue, 14 Feb 2017, Peter Maydell wrote --+ | Yes, exactly. (We document this in | http://wiki.qemu-project.org/Contribute/SubmitAPatch#Participating_in_Code_Review | but of course that page is huge...) Right, okay. I'll resend the patch set later today. Thank you. --

Re: [Qemu-devel] [PATCH 14/17] migration: Create thread infrastructure for multifd recv side

2017-02-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We make the locking and the transfer of information specific, even if we > >> are still receiving things through the main thread. > >> > >>

Re: [Qemu-devel] [PATCH v4] sd: sdhci: mask transfer mode register value

2017-02-14 Thread Peter Maydell
On 14 February 2017 at 11:02, P J P wrote: > Hello Peter, > > +-- On Tue, 14 Feb 2017, Peter Maydell wrote --+ > | Please keep sending them as a single series, though. Otherwise I > | won't be able to easily apply them in the right order and track > | their current status. >

Re: [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi()

2017-02-14 Thread Paolo Bonzini
On 14/02/2017 11:26, Markus Armbruster wrote: > With qemu_strtosz(), no suffix means mebibytes. It's used rarely. > I'm going to add a similar function where no suffix means bytes. > Rename qemu_strtosz() to qemu_strtosz_mebi() to make the name > qemu_strtosz() available for the new function.

[Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-14 Thread Markus Armbruster
Plenty of code relies on QemuOpt member @str not being null, including qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to qemu_opt_foreach(). Begs the question whether it can be null. Only opt_set() creates QemuOpt. It sets member @str to its argument @value. Passing null for

[Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz()

2017-02-14 Thread Markus Armbruster
Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster --- qemu-img.c | 58 +++--- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git

[Qemu-devel] VirtIO Windows Driver repository

2017-02-14 Thread Yan Vugenfirer
Hello All, The official upstream repository moved from https://github.com/YanVugenfirer/kvm-guest-drivers-windows to https://github.com/virtio-win/kvm-guest-drivers-windows Best regards, Yan Vugenfirer.

Re: [Qemu-devel] [PATCH 00/24] QemuOpts util/cutils: Fix and clean up number conversions

2017-02-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/24] QemuOpts util/cutils: Fix and clean up number conversions Message-id: 1487067971-10443-1-git-send-email-arm...@redhat.com Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 10/17] migration: create ram_multifd_page

2017-02-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> The function still don't use multifd, but we have simplified > >> ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > >>

Re: [Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
11.02.2017 02:20, John Snow wrote: On 02/03/2017 04:40 AM, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 01/18] block: move AioContext, QEMUTimer, main-loop to libqemuutil

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 03:48:31PM +0800, Fam Zheng wrote: > On Mon, 02/13 14:52, Paolo Bonzini wrote: > > --- /dev/null > > +++ b/util/aiocb.c > > @@ -0,0 +1,55 @@ > > +/* > > + * BlockAIOCB allocation > > + * > > + * Copyright (c) 2003-2017 Fabrice Bellard and the QEMU team > > Hmm, I'm not

Re: [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol()

2017-02-14 Thread Paolo Bonzini
On 14/02/2017 11:25, Markus Armbruster wrote: > * qemu_strtol()'s variable @err is *negative* errno, > check_strtox_error()'s parameter @err is *positive*. Rename the > latter to @eno. What about in_errno or libc_errno? No need to repost of course. Paolo

[Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately

2017-02-14 Thread Markus Armbruster
This makes qemu_strtosz(), qemu_strtosz_mebi() and qemu_strtosz_metric() similar to qemu_strtoi64(), except negative values are rejected. Cc: Dr. David Alan Gilbert Cc: Eduardo Habkost (maintainer:X86) Cc: Kevin Wolf (supporter:Block

Re: [Qemu-devel] [PATCH v4] sd: sdhci: mask transfer mode register value

2017-02-14 Thread Peter Maydell
On 14 February 2017 at 10:44, P J P wrote: > +-- On Tue, 14 Feb 2017, Peter Maydell wrote --+ > | What has happened to the other patches that were in this patchset in v3 ? > > v3 1/4 > -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02776.html > > v3 3/4 > ->

Re: [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work

2017-02-14 Thread Juan Quintela
Paolo Bonzini wrote: > On 14/02/2017 14:12, Juan Quintela wrote: >>> On 13/02/2017 18:19, Juan Quintela wrote: +qemu_sem_init(>init, 0); p->quit = false; +p->c = socket_send_channel_create(); +if (!p->c) { +

Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit

2017-02-14 Thread Peter Maydell
On 14 February 2017 at 12:58, Markus Armbruster wrote: > Peter Maydell writes: >> Doesn't this change the semantics? Previously, for the >> case of (eno == 0 && ep == nptr) we would both set >> *endptr to ep and return -EINVAL. Now we only return

Re: [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work

2017-02-14 Thread Juan Quintela
Paolo Bonzini wrote: > On 13/02/2017 18:19, Juan Quintela wrote: >> +qemu_sem_init(>init, 0); >> p->quit = false; >> +p->c = socket_send_channel_create(); >> +if (!p->c) { >> +error_report("Error creating a send channel"); >> +

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-14 Thread Stefan Hajnoczi
On Tue, Feb 07, 2017 at 05:29:33PM +0100, Greg Kurz wrote: > Cc'ing Stefan who reviewed patch 2/2. > > On Tue, 7 Feb 2017 09:56:08 -0600 > Eric Blake wrote: > > > On 02/07/2017 04:32 AM, Greg Kurz wrote: > > >> > > >> I'm not aware of anything related to fsdev in QMP... and

Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit

2017-02-14 Thread Markus Armbruster
Peter Maydell writes: > On 14 February 2017 at 10:25, Markus Armbruster wrote: >> Reorder check_strtox_error() to make it obvious that we always store >> through a non-null @endptr. >> >> Transform >> >> if (some error) { >> error case

Re: [Qemu-devel] [PULL 11/12] migration: Send the fd number which we are going to use for this page

2017-02-14 Thread Paolo Bonzini
On 13/02/2017 18:19, Juan Quintela wrote: > case RAM_SAVE_FLAG_MULTIFD_PAGE: > +fd_num = qemu_get_be16(f); > +multifd_recv_page(host, fd_num); > qemu_get_buffer(f, host, TARGET_PAGE_SIZE); > break; Why do you need

Re: [Qemu-devel] [PATCH 00/12] Multifd v4

2017-02-14 Thread Paolo Bonzini
On 13/02/2017 18:19, Juan Quintela wrote: > [v4] > > - Address reviews > - move synchronization to semaphores (faster). Paolo suggestion > - improvements overall (see invidiual patches) > - fix all the checkpatch warnings > - fix all [HACKS] except for one > > Please review. I think you can

[Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 18 ++ include/block/block_int.h| 3 +++

[Qemu-devel] How to upgrade QEMU?

2017-02-14 Thread Bob Chen
Hi folks, I am about to upgrade my QEMU version from an ancient 1.1.2 to the latest. My plan is to override all the installing files with the new ones. Since I used to rename all the qemu-xxx binaries under /usr/local/bin with a specified version suffix, so they are not my concern. Just

[Qemu-devel] [PATCH 03/25] hbitmap: improve dirty iter

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 --

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-14 Thread Jeff Cody
On Mon, Feb 13, 2017 at 11:43:17PM -0800, ashish mittal wrote: > On Mon, Feb 13, 2017 at 7:02 PM, Ketan Nilangekar > wrote: > > > > > > On 2/13/17, 3:23 PM, "Jeff Cody" wrote: > > > > On Mon, Feb 13, 2017 at 10:36:53PM +, Ketan Nilangekar

Re: [Qemu-devel] Fw: qemu integrator RAM size can't reach 128M when emulate the arm926

2017-02-14 Thread Peter Maydell
On 14 February 2017 at 13:45, heavybird <4345...@qq.com> wrote: > i tried use the integrator.c to emulate the arm926 which has 128M message but > found the RAM size can use is less than 32M. steps below. the qemu usding is > 2.8. > > 1 define the RAM from 0-128M in ld file. > 2 write the test

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-14 Thread Jeff Cody
On Tue, Feb 14, 2017 at 04:51:09PM +, Daniel P. Berrange wrote: > On Tue, Feb 14, 2017 at 11:35:17AM -0500, Jeff Cody wrote: > > From 7c135439fd0151860cb0f6ef1a857dfbee6e6317 Mon Sep 17 00:00:00 2001 > > From: Jeff Cody > > Date: Tue, 14 Feb 2017 09:51:42 -0500 > > Subject:

[Qemu-devel] [PATCH RFC v2 2/2] block: Crude initial implementation of -blockdev

2017-02-14 Thread Markus Armbruster
The new command line option -blockdev works like QMP command blockdev-add. The option argument may be given in JSON syntax, exactly as in QMP. Example usage: -blockdev '{"node-name": "foo", "driver": "raw", "file": {"driver": "file", "filename": "foo.img"} }' The JSON argument doesn't

[Qemu-devel] [PATCH 10/25] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [PATCH 15/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 4

[Qemu-devel] [PATCH 02/25] specs/qcow2: do not use wording 'bitmap header'

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir

[Qemu-devel] [PATCH 06/25] block/dirty-bitmap: add deserialize_ones func

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow

[Qemu-devel] [PATCH 11/25] block: introduce persistent dirty bitmaps

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [Bug 886255] Re: Qemu master branch - RHEL 6.1 guest fails to boot

2017-02-14 Thread Thomas Huth
Marking as fixed, according to comment #5 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/886255 Title: Qemu master branch - RHEL 6.1 guest

[Qemu-devel] [PATCH v14 00/24] qcow2: persistent dirty bitmaps

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v14. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v14 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v14) v14: 07: use '|=' to update need_update_header add John's r-b add

Re: [Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2017-02-14 Thread John Snow
On 02/14/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.02.2017 02:20, John Snow wrote: >> On 02/03/2017 04:40 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +void bdrv_store_persistent_dirty_bitmaps(BlockDriverState *bs, Error >>> **errp) >>> +{ >>> +BlockDriver *drv = bs->drv; >>> +

Re: [Qemu-devel] [PATCH 1/1] qemu-iotests: redirect nbd server stdout to /dev/null

2017-02-14 Thread Eric Blake
On 02/14/2017 12:15 PM, Jeff Cody wrote: > Some iotests (e.g. 174) try to filter the output of _make_test_image by > piping the stdout. Pipe the server stdout to /dev/null, so that filter > pipe does not need to wait until process completion. > > Signed-off-by: Jeff Cody > ---

[Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers

2017-02-14 Thread P J P
From: Prasad J Pandit In SDHCI protocol, the 'Block count enable' bit of the Transfer Mode register is relevant only in multi block transfers. We need not check it in single block transfers. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 6

Re: [Qemu-devel] [PATCH 09/24] QemuOpts: Fix to reject numbers that overflow uint64_t

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > parse_option_number() fails to check for overflow after strtoull(). > Has always been broken. Fix that. > > Signed-off-by: Markus Armbruster > --- > tests/test-qemu-opts.c | 14 ++ > util/qemu-option.c | 11

Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Plenty of code relies on QemuOpt member @str not being null, including > qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to > qemu_opt_foreach(). > > > Assert member @str isn't null, so that misuse is caught right away. > >

Re: [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Fixes the following documentation bugs: > > * Fails to document that null @nptr is safe. > > * Fails to document that we return -EINVAL when no conversion could be > performed (commit 47d4be1). > > * Confuses long long with int64_t, and

Re: [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol()

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Name same things the same, different things differently. > > * qemu_strtol()'s parameter @nptr is called @p in > check_strtox_error(). Rename the latter. > > * qemu_strtol()'s parameter @endptr is called @next in > check_strtox_error().

Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Use unsigned comparisons to check the result of qemu_strtoul() and > strtoull(). > > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 60 > ++--- > 1 file

Re: [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull()

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > The name qemu_strtoll() suggests conversion to long long, but it > actually converts to int64_t. Rename to qemu_strtoi64(). > > The name qemu_strtoull() suggests conversion to unsigned long long, > but it actually converts to uint64_t. Rename

Re: [Qemu-devel] [PATCH v14 00/24] qcow2: persistent dirty bitmaps

2017-02-14 Thread Eric Blake
On 02/14/2017 01:02 PM, John Snow wrote: > > > On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> > > Hi! :) > >> There is a new update of qcow2-bitmap series - v14. >> > > Having the cover letter be 00/24 but including 25 patches confuses the > patch scraping tool a

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-14 Thread Jeff Cody
On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >> From: Ashish Mittal > >> > >> Source code for the qnio library

Re: [Qemu-devel] [PATCH] vmstate-static-checker: update white list with spapr_pci

2017-02-14 Thread David Gibson
On Tue, Feb 14, 2017 at 02:33:31PM +0100, Laurent Vivier wrote: > To fix migration between 2.7 and 2.8, some fields have > been renamed and managed with the help of a PHB property > (pre_2_8_migration): > > 5c4537b spapr: Fix 2.7<->2.8 migration of PCI host bridge > > So we need to add them

Re: [Qemu-devel] [PATCH 15/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_can_store_new_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-bitmap.c | 40

Re: [Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Interface for removing persistent bitmap from its storage. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/dirty-bitmap.c | 18

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-14 Thread ashish mittal
On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish

Re: [Qemu-devel] [PATCH 10/24] tests/test-cutils: Add missing qemu_strtosz()... endptr checks

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 37 ++--- > 1 file changed, 26 insertions(+), 11 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-14 Thread Philippe Mathieu-Daudé
Hi Mike, I failed to apply your patch on master: error: patch failed: target/ppc/Makefile.objs:1 error: target/ppc/Makefile.objs: patch does not apply error: patch failed: target/ppc/arch_dump.c:1 error: target/ppc/arch_dump.c: patch does not apply error: patch failed: target/ppc/cpu.h:1225

Re: [Qemu-devel] [PATCH 16/25] qmp: add persistent flag to block-dirty-bitmap-add

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > Reviewed-by: Max

Re: [Qemu-devel] [PATCH 17/25] qmp: add autoload parameter to block-dirty-bitmap-add

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Optional. Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > Reviewed-by: Max Reitz > --- > blockdev.c | 18

Re: [Qemu-devel] [PATCH RFC v2 0/2] block: Crude initial implementation of -blockdev

2017-02-14 Thread Markus Armbruster
Markus Armbruster writes: > This is based on "[PATCH 00/24] QemuOpts util/cutils: Fix and clean up > number conversions". > > v2: Support KEY=VALUE,... syntax as well. Forgot to mention: the thing collapses when KEY has a type other than string. There's one reason this is

Re: [Qemu-devel] [PATCH 21/25] qcow2-bitmap: refcounts

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img > check implementation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- >

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-14 Thread Nawrocki, Michael
Hi Philippe, I rebased on the latest master, but the only difference between that patch and the emailed patch was the commit hash. I’m using master at git://git.qemu.org/qemu.git (latest commit 5dae13c). It seems to cleanly apply on my end… is there a different repo I should be working

Re: [Qemu-devel] [PATCH v3 3/3] .shippable.yml: new CI provider

2017-02-14 Thread Fam Zheng
On Tue, 02/14 15:56, Alex Bennée wrote: > > May I propose we merge 'docker testing' section of MAINTAINERS into 'build > > and > > test automation' section? I don't know as much about travis (and shippable) > > but > > I'm totally fine if you want to have docker tests under your umbrella, and >

[Qemu-devel] [PULL 4/5] net: imx: limit buffer descriptor count

2017-02-14 Thread Jason Wang
From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-14 Thread David Gibson
On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > On 02/14/2017 06:15 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: > > > On 02/13/2017 06:33 AM, David Gibson wrote: > > > > On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH 1/2] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

2017-02-14 Thread David Gibson
On Tue, Feb 14, 2017 at 03:52:09PM +0100, Cédric Le Goater wrote: > On 02/14/2017 08:04 AM, Cédric Le Goater wrote: > > On 02/14/2017 06:02 AM, David Gibson wrote: > >> On Mon, Feb 13, 2017 at 03:09:16PM +0100, Cédric Le Goater wrote: > >>> Today, the ICS (Interrupt Controller Source) object is

Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

2017-02-14 Thread Mike Frysinger
On 10 Feb 2017 09:04, Peter Maydell wrote: > I still think that it's a shame that glibc is breaking > compatibility with where these macros have always been > kept on every OS that's implemented them back to 2BSD... i don't think that characterization is accurate. if it were, autoconf wouldn't

Re: [Qemu-devel] [PATCH 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

2017-02-14 Thread John Snow
On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Add detailed error messages. > yay > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 63 > ++-- > 1 file changed, 41

[Qemu-devel] [PULL 0/5] Net patches

2017-02-14 Thread Jason Wang
The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into staging (2017-02-14 09:55:48 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you

Re: [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td

2017-02-14 Thread Li Qiang
Ping... 2017-02-07 19:15 GMT+08:00 Li Qiang : > From: Li Qiang > > It should return 1 if an error occurs when reading iso td. > This will avoid an infinite loop issue in ohci_service_ed_list. > > Signed-off-by: Li Qiang > --- >

Re: [Qemu-devel] [PATCH] usb: ohci: limit the number of link eds

2017-02-14 Thread Li Qiang
Hello Gerd, Ping... 2017-02-07 18:23 GMT+08:00 Li Qiang : > From: Li Qiang > > The guest may builds an infinite loop with link eds. This patch > limit the number of linked ed to avoid this. > > Signed-off-by: Li Qiang > --- >

Re: [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

2017-02-14 Thread P J P
Hello Alistair, +-- On Tue, 14 Feb 2017, Alistair Francis wrote --+ | On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: | > From: Prasad J Pandit | > | > In the SDHCI protocol, the transfer mode register value | > is used during multi block transfer to

[Qemu-devel] [PATCH v6 7/7] tests: Add unit tests for the VM Generation ID feature

2017-02-14 Thread ben
From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. * test that changing the GUID at runtime via the monitor is reflected in the guest. * test that the "auto" argument to the GUID generates a

[Qemu-devel] [PATCH v6 3/7] ACPI: Add vmgenid blob storage to the build tables

2017-02-14 Thread ben
From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() -> acpi_setup()

[Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-14 Thread ben
From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren

[Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-14 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

Re: [Qemu-devel] [PATCH v3 2/3] new: debian docker targets for cross-compiling

2017-02-14 Thread Peter Maydell
On 14 February 2017 at 10:07, Alex Bennée wrote: > This provides a basic Debian install with access to the emdebian cross > compilers. The debian-armhf-cross and debian-arm64-cross targets build > on the basic Debian image to allow cross compiling to those targets. Is

Re: [Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages

2017-02-14 Thread Dr. David Alan Gilbert
Hi Pavel, I was curious, having merged this, how you're using postcopy; do you switch into postcopy mode immediately or wait until the first sync or what? Do you find yourself in postcopy mode long enough that it's worth doing the release? If so on what size VMs are you working with? Dave *

Re: [Qemu-devel] [PATCH v3 3/3] .shippable.yml: new CI provider

2017-02-14 Thread Fam Zheng
On Tue, 02/14 10:07, Alex Bennée wrote: > Ostensibly Shippable offers a similar set of services as Travis. > However they are focused on Docker container based work-flows so we > can use our existing containers to run a few extra builds - in this > case a bunch of cross-compiled targets on a

[Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info

2017-02-14 Thread Vladimir Sementsov-Ogievskiy
Currently backup to nbd target is broken, as nbd doesn't have .bdrv_get_info realization. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! Since commit commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b Author: John Snow Date: Thu Feb 25