[Qemu-devel] [PATCH] xhci: properties cleanup

2017-02-20 Thread Gerd Hoffmann
Split xhci properties into common and nec specific. Move the backward compat flags to nec, so the new qemu-xhci devices doesn't carry on the compatibiity stuff. Move the msi/msix switches too and just enable msix for qemu-xhci. Also move the intrs and slots properties. Wasn't a great idea to

Re: [Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize

2017-02-20 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2017 at 7:38 AM Li Qiang wrote: > In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will > call 'char_spice_finalize'. But as the SpiceChardev is not inserted > in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault. > Add a detect to

Re: [Qemu-devel] [PATCH RFC v3 04/15] vfio: ccw: basic implementation for vfio_ccw driver

2017-02-20 Thread Dong Jia Shi
* Dong Jia Shi [2017-02-21 15:36:23 +0800]: [...] > > > +static int vfio_ccw_sch_probe(struct subchannel *sch) > > > +{ > > > + struct pmcw *pmcw = >schib.pmcw; > > > + struct vfio_ccw_private *private; > > > + int ret; > > > + > > > + if (pmcw->qf) { > > > +

Re: [Qemu-devel] [PATCH RFC v3 04/15] vfio: ccw: basic implementation for vfio_ccw driver

2017-02-20 Thread Dong Jia Shi
* Cornelia Huck [2017-02-20 19:31:13 +0100]: > On Fri, 17 Feb 2017 09:29:28 +0100 > Dong Jia Shi wrote: > > > To make vfio support subchannel devices, we need a css driver for > > the vfio subchannels. This patch adds a basic vfio-ccw

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-20 Thread Alexey Perevalov
Hello David, On Tue, Feb 14, 2017 at 07:34:26PM +, Dr. David Alan Gilbert wrote: > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > Hi David, > > > > Thank your, now it's clear. > > > > On Mon, Feb 13, 2017 at 06:16:02PM +, Dr. David Alan Gilbert wrote: > > > * Alexey Perevalov

[Qemu-devel] [PULL 09/11] usb-ccid: better bulk_out error handling

2017-02-20 Thread Gerd Hoffmann
Add err goto label where we can jump to from all error conditions. STALL request on all errors. Reset position on all errors. Normal request processing is not in a else branch any more, so this code is reintended, there are no code changes in that part of the code though. Signed-off-by: Gerd

[Qemu-devel] [PULL 05/11] xhci: drop ER_FULL_HACK workaround

2017-02-20 Thread Gerd Hoffmann
The nec/renesas driver problems have finally been debugged and root caused, see commit "7da76e1 xhci: fix event queue IRQ handling". It's pretty clear now that (a) The whole "driver can't handle ring full" story is most likely wrong. (b) The ER_FULL_HACK workaround based on the false

[Qemu-devel] [PULL 06/11] xhci: add qemu xhci controller

2017-02-20 Thread Gerd Hoffmann
Turn existing TYPE_XHCI into an abstract base class. Create two child classes, TYPE_NEC_XHCI (same name as old xhci controller) and TYPE_QEMU_XHCI (using an ID from our namespace). Signed-off-by: Gerd Hoffmann Reviewed-by: Marcel Apfelbaum Message-id:

[Qemu-devel] [PULL 07/11] xhci: fix nec vendor quirk handling

2017-02-20 Thread Gerd Hoffmann
Only the TYPE_NEC_XHCI controller will have the nec vendor quirks. Signed-off-by: Gerd Hoffmann Message-id: 1486382139-30630-4-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 44 +--- 1 file changed, 29 insertions(+), 15

[Qemu-devel] [PULL 01/11] usb: ehci: fix memory leak in ehci

2017-02-20 Thread Gerd Hoffmann
From: Li Qiang In usb_ehci_init function, it initializes 's->ipacket', but there is no corresponding function to free this. As the ehci can be hotplug and unplug, this will leak host memory leak. In order to make the hierarchy clean, we should add a ehci pci finalize function,

[Qemu-devel] [PULL 11/11] usb-ccid: add check message size checks

2017-02-20 Thread Gerd Hoffmann
Check message size too when figuring whenever we should expect more data. Fix debug message to show useful data, p->iov.size is fixed anyway if we land there, print how much we got meanwhile instead. Also check announced message size against actual message size. That is a more general fix for

[Qemu-devel] [PULL 08/11] xhci: drop via vendor command handling

2017-02-20 Thread Gerd Hoffmann
Seems pretty pointless, we don't emulate an via xhci controller. Signed-off-by: Gerd Hoffmann Message-id: 1486382139-30630-5-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 31 --- 1 file changed, 31 deletions(-) diff --git

[Qemu-devel] [PULL 00/11] usb patch queue

2017-02-20 Thread Gerd Hoffmann
Hi, Here is the usb patch queue, bringing the usual share of bugfixes. Also a generic xhci device variant (qemu-xhci). please pull, Gerd The following changes since commit 56f9e46b841c7be478ca038d8d4085d776ab4b0d: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-20'

[Qemu-devel] [PULL 10/11] usb-ccid: move header size check

2017-02-20 Thread Gerd Hoffmann
Move up header size check, so we can use header fields in sanity checks (in followup patches). Also reword the debug message. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id:

[Qemu-devel] [PULL 02/11] usb: ohci: fix error return code in servicing iso td

2017-02-20 Thread Gerd Hoffmann
From: Li Qiang It should return 1 if an error occurs when reading iso td. This will avoid an infinite loop issue in ohci_service_ed_list. Signed-off-by: Li Qiang Message-id: 5899ac3e.1033240a.944d5.9...@mx.google.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 04/11] xhci: apply limits to loops

2017-02-20 Thread Gerd Hoffmann
Limits should be big enough that normal guest should not hit it. Add a tracepoint to log them, just in case. Also, while being at it, log the existing link trb limit too. Reported-by: 李强 Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PULL 03/11] usb: ohci: limit the number of link eds

2017-02-20 Thread Gerd Hoffmann
From: Li Qiang The guest may builds an infinite loop with link eds. This patch limit the number of linked ed to avoid this. Signed-off-by: Li Qiang Message-id: 5899a02e.45ca240a.6c373.9...@mx.google.com Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH v8 0/8] Add support for VM Generation ID

2017-02-20 Thread Gerd Hoffmann
Hi, > Gerd - are you planning to backport this series to the stable branch? Yes. Unless we'll have a 1.11 release next week, which I doubt ;) cheers, Gerd

Re: [Qemu-devel] [PULL 0/2] QAPI patches for 2017-02-20

2017-02-20 Thread Zhang Chen
Hi~ Markus. This patch set has been reviewed for a long time, can you pick up it? [PATCH V7 0/2] Add new qmp commands to suppurt Xen COLO Thanks Zhang Chen On 02/20/2017 09:33 PM, Markus Armbruster wrote: The following changes since commit d514cfd763b271b4e97a9fc6adaabc8fd50084ab:

[Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-20 Thread jazeltq
From: tianqing Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing --- block/rbd.c | 80 ++--- 1 file

[Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive

2017-02-20 Thread Yongji Xie
At the moment ram device's memory regions are NATIVE_ENDIAN. This does not work on PPC64 because VFIO PCI device is little endian but PPC64 always defines static macro TARGET_WORDS_BIGENDIAN. This fixes endianness for ram device the same way as it is done for VFIO region in commit

Re: [Qemu-devel] [PATCH] vfio/pci-quirks.c: Disable stolen memory for igd VFIO

2017-02-20 Thread Zhang, Xiong Y
> On Mon, 20 Feb 2017 19:42:54 +0800 > Xiong Zhang wrote: > > > From: XiongZhang > > > > If IGD isn't assigned at 00:02.0 in UPT and host bios enable stolen > > memory, seabios won't reseave stolen memory in E820 for guest. Then > > both Intel

[Qemu-devel] Recall: [PATCH] vfio/pci-quirks.c: Disable stolen memory for igd VFIO

2017-02-20 Thread Zhang, Xiong Y
Zhang, Xiong Y would like to recall the message, "[Qemu-devel] [PATCH] vfio/pci-quirks.c: Disable stolen memory for igd VFIO".

Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-20 Thread Jeff Cody
On Tue, Feb 21, 2017 at 11:43:36AM +0800, jaze...@gmail.com wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- > block/rbd.c

Re: [Qemu-devel] [PATCH] vfio/pci-quirks.c: Disable stolen memory for igd VFIO

2017-02-20 Thread Zhang, Xiong Y
> > On Mon, 20 Feb 2017 19:42:54 +0800 > Xiong Zhang wrote: > > > From: XiongZhang > > > > If IGD isn't assigned at 00:02.0 in UPT and host bios enable stolen > > memory, seabios won't reseave stolen memory in E820 for guest. Then > > both

Re: [Qemu-devel] [PATCH v1 01/10] target/ppc: support for 32-bit carry and overflow

2017-02-20 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> +#ifndef TARGET_PPC64 >> static inline target_ulong cpu_read_xer(CPUPPCState *env) >> { >> return env->xer | (env->so << XER_SO) | (env->ov << XER_OV) | (env->ca >> << XER_CA); >> } >>

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 04/10] target/ppc/POWER9: Direct all instr and data storage interrupts to the hypv

2017-02-20 Thread Balbir Singh
On Mon, Feb 20, 2017 at 03:04:32PM +1100, Suraj Jitindar Singh wrote: > The vpm0 bit was removed from the LPCR in POWER9, this bit controlled > whether ISI and DSI interrupts were directed to the hypervisor or the > partition. These interrupts now go to the hypervisor irrespective, thus > it is no

Re: [Qemu-devel] [PATCH] mttcg: Set jmp_env to handle exit from tb_gen_code

2017-02-20 Thread Pranith Kumar
On Mon, Feb 20, 2017 at 7:35 PM, Alex Bennée wrote: > > Pranith Kumar writes: > >> Alex Bennée writes: >> >>> Pranith Kumar writes: >>> tb_gen_code() can exit execution using cpu_exit_loop() when it cannot allocate

Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-20 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd Message-id: 20170221034336.10097-1-jaze...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd Message-id: 20170221034336.10097-1-jaze...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-20 Thread jazeltq
From: tianqing Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing --- block/rbd.c | 79 ++--- 1 file

[Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize

2017-02-20 Thread Li Qiang
In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will call 'char_spice_finalize'. But as the SpiceChardev is not inserted in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault. Add a detect to avoid it. Signed-off-by: Li Qiang --- spice-qemu-char.c | 5

Re: [Qemu-devel] [PATCH] target/ppc: Fix serious bug in HPTE writeback

2017-02-20 Thread David Gibson
On Tue, Feb 21, 2017 at 01:52:11PM +1100, David Gibson wrote: > ppc_hash64_store_hpte() is used to update HPTEs in the hashed page table > (HPT) for 64-bit machines. This is used when the (emulated) CPU needs to > update the referenced (R) or changed (C) bits in the HPTE. > > Some time ago this

Re: [Qemu-devel] [PATCH 1/3] net/colo: fix memory double free error

2017-02-20 Thread Hailiang Zhang
On 2017/2/21 10:25, Zhang Chen wrote: On 02/20/2017 04:01 PM, zhanghailiang wrote: The 'primary_list' and 'secondary_list' members of struct Connection is not allocated through dynamically g_queue_new(), but we free it by using g_queue_free(), which will lead to a double-free bug.

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-20 Thread Eric Blake
On 02/19/2017 01:02 AM, Chad Joan wrote: > development work. There are no user accounts, just root. I have tried to > avoid putting any personal information on it. If I am on it, then I'm > editing files in /etc or installing system-wide software. I'm realizing > that I might have to change

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-20 Thread Eric Blake
On 02/17/2017 11:15 AM, Peter Maydell wrote: > The kernel docs have a longer list of mail clients with > notes about suitability: > https://kernel.org/doc/html/latest/process/email-clients.html > but the set of "just works" clients is very small. Currently fails with 403 Forbidden You don't have

[Qemu-devel] [PATCH] target/ppc: Fix serious bug in HPTE writeback

2017-02-20 Thread David Gibson
ppc_hash64_store_hpte() is used to update HPTEs in the hashed page table (HPT) for 64-bit machines. This is used when the (emulated) CPU needs to update the referenced (R) or changed (C) bits in the HPTE. Some time ago this was converted to take an HPTE index, instead of a raw offset to the HPTE

[Qemu-devel] [PATCH] net/colo-compare: Fix memory free error

2017-02-20 Thread Zhang Chen
We use g_queue_init() to init s->conn_list, so we should use g_queue_clear() to instead of g_queue_free(). Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c

Re: [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit

2017-02-20 Thread Eric Blake
On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Use qobject_to_qdict() instead of a type cast. > > Signed-off-by: Markus Armbruster > --- > tests/libqtest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Happens to be the same (because of our struct layout),

[Qemu-devel] [PATCH v4 8/8] nbd: Implement NBD_INFO_BLOCK_SIZE on client

2017-02-20 Thread Eric Blake
The upstream NBD Protocol has defined a new extension to allow the server to advertise block sizes to the client, as well as a way for the client to inform the server whether it intends to obey block sizes. When using the block layer as the client, we will obey block sizes; but when used as

[Qemu-devel] [PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server

2017-02-20 Thread Eric Blake
The upstream NBD Protocol has defined a new extension to allow the server to advertise block sizes to the client, as well as a way for the client to inform the server that it intends to obey block sizes. Thanks to a recent fix (commit df7b97ff), our real minimum transfer size is always 1 (the

[Qemu-devel] [PATCH v4 4/8] nbd: Expose and debug more NBD constants

2017-02-20 Thread Eric Blake
The NBD protocol has several constants defined in various extensions that we are about to implement. Expose them to the code, along with an easy way to map various constants to strings during diagnostic messages. Doing this points out a debug message in server.c that got parameters mixed up.

[Qemu-devel] [PATCH v4 2/8] nbd: Create struct for tracking export info

2017-02-20 Thread Eric Blake
The NBD Protocol is introducing some additional information about exports, such as minimum request size and alignment, as well as an advertised maximum request size. It will be easier to feed this information back to the block layer if we gather all the information into a struct, rather than

[Qemu-devel] [PATCH v4 1/8] nbd/client: fix drop_sync [CVE-2017-2630]

2017-02-20 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Comparison symbol is misused. It may lead to memory corruption. Introduced in commit 7d3123e. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170203154757.36140-6-vsement...@virtuozzo.com>

[Qemu-devel] [PATCH v4 3/8] block: Add blk_get_opt_transfer()

2017-02-20 Thread Eric Blake
The NBD protocol would like to advertise the optimal I/O size to the client; but it would be a layering violation to peek into blk_bs(blk)->bl, when we only have a BB. This copies the existing blk_get_max_transfer() in reading a value from the top BDS; where that value was picked via

[Qemu-devel] [PATCH v4 6/8] nbd: Implement NBD_OPT_GO on client

2017-02-20 Thread Eric Blake
NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure requires the server to close the connection rather than report an error to us. Therefore, upstream NBD recently added NBD_OPT_GO as the improved version of the option that does what we want [1]: it reports sane errors on failures,

[Qemu-devel] [PATCH v4 5/8] nbd: Implement NBD_OPT_GO on server

2017-02-20 Thread Eric Blake
NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure requires us to close the connection rather than report an error. Therefore, upstream NBD recently added NBD_OPT_GO as the improved version of the option that does what we want [1], along with NBD_OPT_INFO that returns the same

[Qemu-devel] [PATCH v4 0/8] Implement NBD_OPT_GO, block size advertisement

2017-02-20 Thread Eric Blake
A bit later than I planned, but still in time for soft freeze if we like it. The NBD protocol has a proposed extension that fixes several shortcomings with NBD_OPT_EXPORT_NAME (namely, no error reporting, no way for the server to advertise block sizes to the client):

Re: [Qemu-devel] [PATCH 1/3] net/colo: fix memory double free error

2017-02-20 Thread Zhang Chen
On 02/20/2017 04:01 PM, zhanghailiang wrote: The 'primary_list' and 'secondary_list' members of struct Connection is not allocated through dynamically g_queue_new(), but we free it by using g_queue_free(), which will lead to a double-free bug. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system

2017-02-20 Thread joserz
On Sat, Feb 18, 2017 at 10:41:41PM +, Peter Maydell wrote: > On 6 November 2016 at 17:15, Jose Ricardo Ziviani > wrote: > > Recognizes PPC64 as a valid architecture and setup the environment > > variables to compile code for that. > > > > Signed-off-by: Jose Ricardo

[Qemu-devel] [Bug 1653384] Re: Assertion failed with USB pass through with XHCI controller

2017-02-20 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1653384 Title: Assertion failed with USB pass through with XHCI controller Status in

[Qemu-devel] why it meets this error after putting windows-virtio-dirvers into win7x64ultimate.iso using waik when boot from the iso?

2017-02-20 Thread xiucai
Hi, BTW, I also had posted the Q @ http://stackoverflow.com/questions/42336175/why-meet-this-winload-exe-error-after-put-virtio-dirver-into-win7x64ultimate-iso. My aim is making windows-virtio-drivers within win7x64ultimate.iso, so it can be used directly upon qemu-kvm with virtio bus,

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: > On 02/20/17 21:45, Eric Blake wrote: > > On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: > >> * Eric Blake (ebl...@redhat.com) wrote: > >>> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > * Laszlo Ersek

[Qemu-devel] [Bug 1653384] Re: Assertion failed with USB pass through with XHCI controller

2017-02-20 Thread Alistair Phipps
** Bug watch added: Debian Bug tracker #855659 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855659 ** Also affects: qemu (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855659 Importance: Unknown Status: Unknown -- You received this bug notification because you

Re: [Qemu-devel] [PATCH] mttcg: Set jmp_env to handle exit from tb_gen_code

2017-02-20 Thread Alex Bennée
Pranith Kumar writes: > Alex Bennée writes: > >> Pranith Kumar writes: >> >>> tb_gen_code() can exit execution using cpu_exit_loop() when it cannot >>> allocate new tb's. To handle this, we need to properly set the jmp_env >>> pointer ahead of

[Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

2017-02-20 Thread Germano Veit Michel
qemu_announce_self() is triggered by qemu at the end of migrations to update the network regarding the path to the guest l2addr. however it is also useful when there is a network change such as an active bond slave swap. Essentially, it's the same as a migration from a network perspective - the

Re: [Qemu-devel] [PULL 0/8] target-mips queue

2017-02-20 Thread Yongbok Kim
Ok. I will fix the warning and isolate the file for mips64el only as it is only used for that. Regards, Yongbok On 20/02/2017 20:47, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Subject: [Qemu-devel] [PULL 0/8]

Re: [Qemu-devel] [PATCH] mttcg: Set jmp_env to handle exit from tb_gen_code

2017-02-20 Thread Pranith Kumar
Alex Bennée writes: > Pranith Kumar writes: > >> tb_gen_code() can exit execution using cpu_exit_loop() when it cannot >> allocate new tb's. To handle this, we need to properly set the jmp_env >> pointer ahead of calling tb_gen_code(). >> >> CC:Alex Bennée

Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union

2017-02-20 Thread Denis V. Lunev
On 02/20/2017 08:48 PM, Eric Blake wrote: > On 02/20/2017 12:21 PM, Denis V. Lunev wrote: >> From: Anton Nefedov >> >> Signed-off-by: Anton Nefedov >> Signed-off-by: Denis V. Lunev >> CC: Paolo Bonzini

Re: [Qemu-devel] [Resend RFC PATCH 1/4] VFIO: Set eventfd for IOMMU fault event via new vfio cmd

2017-02-20 Thread Alex Williamson
On Mon, 20 Feb 2017 09:28:04 +0800 Lan Tianyu wrote: > This patch is to assign an event fd to VFIO IOMMU type1 driver > in order to get notification when IOMMU driver reports fault event. > > Signed-off-by: Lan Tianyu > --- > hw/vfio/common.c

Re: [Qemu-devel] [Resend RFC PATCH 3/4] Intel iommu: Add Intel IOMMU fault event callback

2017-02-20 Thread Alex Williamson
On Mon, 20 Feb 2017 09:28:06 +0800 Lan Tianyu wrote: > This patch is to deal with fault event reported from IOMMU driver. > > Signed-off-by: Lan Tianyu > --- > hw/i386/intel_iommu.c | 25 + > 1 file changed, 25 insertions(+)

Re: [Qemu-devel] [Resend RFC PATCH 4/4] VFIO: Read IOMMU fault info from kernel space when get fault event

2017-02-20 Thread Alex Williamson
On Mon, 20 Feb 2017 09:28:07 +0800 Lan Tianyu wrote: > This patch is to implement fault event handler with new vfio cmd to > get fault info and notify vIOMMU device model. > > Signed-off-by: Lan Tianyu > --- > hw/vfio/common.c | 51 >

Re: [Qemu-devel] [PATCH v4 3/5] slirp: Common lhost/fhost union

2017-02-20 Thread Philippe Mathieu-Daudé
On 02/20/2017 03:50 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The socket structure has a pair of unions for lhost and fhost addresses; the unions are identical so split them out into a separate union declaration. Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 21:19, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: CC Dave >>> >>> This isn't an area I really understand; but if I'm >>> reading this right then >>>

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Laszlo Ersek
On 02/20/17 21:45, Eric Blake wrote: > On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: >> * Eric Blake (ebl...@redhat.com) wrote: >>> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: * Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave This isn't an area I really

[Qemu-devel] [PATCH V2 4/4] hw/virtio: fix Power Management Control Register for PCI Express virtio devices

2017-02-20 Thread Marcel Apfelbaum
Make Power Management State flag writable to conform with the PCI Express spec. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.c | 11 +++ hw/virtio/virtio-pci.h | 4 include/hw/compat.h| 4 include/hw/pci/pcie.h | 2 ++ 4 files changed, 21

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Eric Blake
On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: >>> * Laszlo Ersek (ler...@redhat.com) wrote: CC Dave >>> >>> This isn't an area I really understand; but if I'm >>> reading this right then

[Qemu-devel] [PATCH V2 2/4] hw/virtio: fix error enabling flags in Device Control register

2017-02-20 Thread Marcel Apfelbaum
When the virtio devices are PCI Express, make error-enabling flags writable to respect the PCIe spec. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.c | 12 hw/virtio/virtio-pci.h | 4 include/hw/compat.h| 4 3 files changed, 20

[Qemu-devel] [PATCH V2 3/4] hw/virtio: fix Link Control Register for PCI Express virtio devices

2017-02-20 Thread Marcel Apfelbaum
Make several Link Control Register flags writable to conform with the PCI Express spec. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 14 ++ hw/virtio/virtio-pci.c | 8 hw/virtio/virtio-pci.h | 4 include/hw/compat.h| 4

Re: [Qemu-devel] [PULL 0/8] target-mips queue

2017-02-20 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PULL 0/8] target-mips queue Message-id: 1487622662-62984-1-git-send-email-yongbok@imgtec.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

[Qemu-devel] [PATCH V2 1/4] hw/pcie: fix Extended Configuration Space for devices with no Extended Capabilities

2017-02-20 Thread Marcel Apfelbaum
Absence of any Extended Capabilities is required to be indicated by an Extended Capability header with a Capability ID of h, a Capability Version of 0h, and a Next Capability Offset of 000h. Instead of inserting a 'NULL' capability is simpler to mark the start of the Extended Configuration

[Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd

2017-02-20 Thread Hervé Poussineau
In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults". Make it the same for scsi-hd, so you can put one on scsi-id 2 without using -nodefaults. scsi-hd

[Qemu-devel] [PATCH V2 0/4] hw/virtio: fix several PCI Express compliance issues

2017-02-20 Thread Marcel Apfelbaum
v1 -> v2: - Added compat properties (Michael S. Tsirkin) - Rebased on latest master - Regarding the patch 1/4, we don't need to init the PCI "standard" config capabilities to 0 since they are "protected" by the Capabilities List bit (bit 4) to indicate that the Capabilities Pointer

[Qemu-devel] [PULL 7/8] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

2017-02-20 Thread Yongbok Kim
From: Paul Burton Add support for emulating the Xilinx AXI Root Port Bridge for PCI Express as described by Xilinx' PG055 document. This is a PCIe controller that can be used with certain series of Xilinx FPGAs, and is used on the MIPS Boston board which will make use of

[Qemu-devel] [PULL 3/8] hw/mips_gic: Update pin state on mask changes

2017-02-20 Thread Yongbok Kim
From: Paul Burton If the GIC interrupt mask is changed by a write to the smask (set mask) or rmask (reset mask) registers, we need to re-evaluate the state of the pins/IRQs fed to the CPU. Without doing so we risk leaving a pin high despite the interrupt that led to that

[Qemu-devel] [PULL 8/8] hw/mips: MIPS Boston board support

2017-02-20 Thread Yongbok Kim
From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs

[Qemu-devel] [PULL 1/8] hw/mips_cmgcr: allow GCR base to be moved

2017-02-20 Thread Yongbok Kim
From: Paul Burton Support moving the GCR base address & updating the CPU's CP0 CMGCRBase register appropriately. This is required if a platform needs to move its GCRs away from other memory, as the MIPS Boston development board does to avoid its flash memory.

[Qemu-devel] [PULL 0/8] target-mips queue

2017-02-20 Thread Yongbok Kim
at: git://github.com/yongbok/upstream-qemu.git tags/mips-20170220 for you to fetch changes up to 0a1fdcc94338ea12f7deba71e795c01989152752: hw/mips: MIPS Boston board support (2017-02-20 19:37:28 +) MIPS patches 2017-02-20 Changes

[Qemu-devel] [PULL 6/8] loader: Support Flattened Image Trees (FIT images)

2017-02-20 Thread Yongbok Kim
From: Paul Burton Introduce support for loading Flattened Image Trees, as used by modern U-Boot. FIT images are essentially flattened device tree files which contain binary images such as kernels, FDTs or ramdisks along with one or more configuration nodes describing boot

[Qemu-devel] [PULL 5/8] dtc: Update requirement to v1.4.2

2017-02-20 Thread Yongbok Kim
From: Paul Burton In order to obtain fdt_first_subnode & fdt_next_subnode symbols from libfdt for use by a later patch, bump the requirement for dtc to v1.4.2 & the submodule to that same version. Signed-off-by: Paul Burton Reviewed-by: Yongbok

[Qemu-devel] [PULL 4/8] target-mips: Provide function to test if a CPU supports an ISA

2017-02-20 Thread Yongbok Kim
From: Paul Burton Provide a new cpu_supports_isa function which allows callers to determine whether a CPU supports one of the ISA_ flags, by testing whether the associated struct mips_def_t sets the ISA flags in its insn_flags field. An example use of this is to allow

[Qemu-devel] [PULL 2/8] hw/mips_gictimer: provide API for retrieving frequency

2017-02-20 Thread Yongbok Kim
From: Paul Burton Provide a new function mips_gictimer_get_freq() which returns the frequency at which a GIC timer will count. This will be useful for boards which perform setup based upon this frequency. Signed-off-by: Paul Burton Reviewed-by:

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > > * Laszlo Ersek (ler...@redhat.com) wrote: > >> CC Dave > > > > This isn't an area I really understand; but if I'm > > reading this right then > >vmgenid is stored in fw_cfg? > >fw_cfg

Re: [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t

2017-02-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > This will permit its use in parse_option_size(). > > Cc: Dr. David Alan Gilbert > Cc: Eduardo Habkost (maintainer:X86) > Cc: Kevin Wolf (supporter:Block layer core) > Cc: Max Reitz

Re: [Qemu-devel] [PATCH] vfio/pci-quirks.c: Disable stolen memory for igd VFIO

2017-02-20 Thread Alex Williamson
On Mon, 20 Feb 2017 19:42:54 +0800 Xiong Zhang wrote: > From: XiongZhang > > If IGD isn't assigned at 00:02.0 in UPT and host bios enable stolen > memory, seabios won't reseave stolen memory in E820 for guest. Then > both Intel graphic driver

Re: [Qemu-devel] [PATCH v1 10/10] target/ppc: add mcrxrx instruction

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:12 PM, Nikunj A Dadhania wrote: mcrxrx: Move to CR from XER Extended Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 23 +++ 1 file changed, 23 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-20 Thread Eric Blake
On 02/20/2017 04:23 AM, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> CC Dave > > This isn't an area I really understand; but if I'm > reading this right then >vmgenid is stored in fw_cfg? >fw_cfg isn't migrated > > So why should any changes to it get

Re: [Qemu-devel] [PATCH v1 09/10] target/ppc: add ov32 flag in divide operations

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:12 PM, Nikunj A Dadhania wrote: Add helper_div_compute_ov() in the int_helper for updating the overflow flags. For Divide Word: SO, OV, and OV32 bits reflects overflow of the 32-bit result For Divide DoubleWord: SO, OV, and OV32 bits reflects overflow of the 64-bit result

Re: [Qemu-devel] [PATCH v1 08/10] target/ppc: add ov32 flag for multiply low insns

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: For Multiply Word: SO, OV, and OV32 bits reflects overflow of the 32-bit result For Multiply DoubleWord: SO, OV, and OV32 bits reflects overflow of the 64-bit result Signed-off-by: Nikunj A Dadhania ---

Re: [Qemu-devel] [PATCH v1 06/10] target/ppc: use tcg ops for neg instruction

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: static void gen_neg(DisasContext *ctx) { -gen_op_arith_neg(ctx, 0); +tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); } NACK. You're forgetting "neg.". r~

Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: For 64-bit mode if the register RA contains 0x8000___, OV and OV32 are set to 1. For 32-bit mode if the register RA contains 0x8000_, OV and OV32 are set to 1. Use the tcg-ops for negation (neg_tl) and drop gen_op_arith_neg() as

Re: [Qemu-devel] [PATCH] vl: disable default cdrom when using explicitely scsi-hd

2017-02-20 Thread John Snow
On 02/19/2017 08:00 PM, Markus Armbruster wrote: > Hervé Poussineau writes: > >> Hi, >> >> Le 09/01/2017 à 14:48, Paolo Bonzini a écrit : >>> >>> >>> On 09/01/2017 13:49, Markus Armbruster wrote: Hervé Poussineau writes: > 'ide-hd',

Re: [Qemu-devel] [PATCH v1 04/10] target/ppc: compute ca32 for arithmetic substract

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: For 64-bit mode use the compute ca32 routine. While for 32-bit mode, CA and CA32 will have same value. Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately

2017-02-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > This makes qemu_strtosz(), qemu_strtosz_mebi() and > qemu_strtosz_metric() similar to qemu_strtoi64(), except negative > values are rejected. > > Cc: Dr. David Alan Gilbert > Cc: Eduardo Habkost

Re: [Qemu-devel] [PATCH 3/3] qmp-events: fix GUEST_PANICKED description formatting

2017-02-20 Thread Eric Blake
On 02/20/2017 12:21 PM, Denis V. Lunev wrote: > From: Anton Nefedov > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Eric Blake > --- >

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-20 Thread Eric Blake
On 02/20/2017 12:12 PM, Denis V. Lunev wrote: >> But for 2.9, we only need to change the union. Eric, can you do that >> for us since my QAPI-fu is limited? >> >> Paolo >> > give me 5 minutes, I have patches for that, received them today. Yep, I've reviewed those patches. Thanks for the fast

Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union

2017-02-20 Thread Eric Blake
On 02/20/2017 12:21 PM, Denis V. Lunev wrote: > From: Anton Nefedov > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Eric Blake > --- >

Re: [Qemu-devel] [PATCH v1 05/10] target/ppc: update overflow flags for add/sub

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: tcg_temp_free(t0); +tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1); +tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1); if (NARROW_MODE(ctx)) { -tcg_gen_ext32s_tl(cpu_ov, cpu_ov); +tcg_gen_mov_tl(cpu_ov, cpu_ov32); } -

Re: [Qemu-devel] [PATCH 1/3] i386/cpu: release GuestPanicInformation memory

2017-02-20 Thread Eric Blake
On 02/20/2017 12:21 PM, Denis V. Lunev wrote: > From: Anton Nefedov > > Do not make some foreign function do it. > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini

Re: [Qemu-devel] [PATCH] qemu-options: explain disk I/O throttling options

2017-02-20 Thread Eric Blake
On 02/20/2017 10:52 AM, Stefan Hajnoczi wrote: > The disk I/O throttling options have been listed for a long time but > never explained on the QEMU man page. > > Suggested-by: Nini Gu > Cc: Alberto Garcia > Signed-off-by: Stefan Hajnoczi

  1   2   3   4   >