Re: [Qemu-devel] Dual userfaultfd behavior

2017-03-13 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hi, David, Andrea and Mike Hi Alexey, > The problem I want to discuss it's 1G hugepage based VM and post copy live > migration. > > I would like to know your opinion on following approach of avoiding such > problem: > Once we have mmap'ed

[Qemu-devel] [PATCH 12/16] migration: Send the fd number which we are going to use for this page

2017-03-13 Thread Juan Quintela
We are still sending the page through the main channel, that would change later in the series Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

Re: [Qemu-devel] [PATCH] qemu-img: show help for invalid global options

2017-03-13 Thread Eric Blake
On 03/13/2017 12:11 AM, Stefan Hajnoczi wrote: > The qemu-img sub-command executes regardless of invalid global options: > > $ qemu-img --foo info test.img > qemu-img: unrecognized option '--foo' > image: test.img > ... > > The unrecognized option warning may be missed by the user. This

Re: [Qemu-devel] Small patch for getdents syscall

2017-03-13 Thread Peter Maydell
On 8 March 2017 at 00:40, Henry Wertz wrote: > I have a trivial, 1-line patch for getdents function; due to use of > unsigned long, the struct on 64-bit and 32-bit systems is not the same. > qemu is aware of this, however it currently only checks for a 32-bit target > on

Re: [Qemu-devel] [PATCH v2 1/2] RAMBlocks: qemu_ram_is_shared

2017-03-13 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Provide a helper to say whether a RAMBlock was created as a > shared mapping. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 2/2] postcopy: Check for shared memory

2017-03-13 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Postcopy doesn't support migration of RAM shared with another process > yet (we've got a bunch of things to understand). > Check for the case and don't allow postcopy to be

Re: [Qemu-devel] Incorrect memory region address with large 64-bit PCI BARs

2017-03-13 Thread Michael S. Tsirkin
On Sun, Mar 12, 2017 at 11:16:44AM +, Mark Cave-Ayland wrote: > On 12/03/17 03:56, Michael S. Tsirkin wrote: > > > After looking at it some more, I think the issue is merely with how info > > mtree presents information, which confuses instead of helping when > > overlap triggers. Specifically

Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-13 Thread Halil Pasic
On 03/10/2017 10:08 PM, Halil Pasic wrote: > > > On 03/10/2017 05:47 PM, Paolo Bonzini wrote: >> >> On 07/03/2017 14:16, Halil Pasic wrote: >>> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and >>> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active"

Re: [Qemu-devel] [PATCH v7 kernel 3/5] virtio-balloon: implementation of VIRTIO_BALLOON_F_CHUNK_TRANSFER

2017-03-13 Thread Wang, Wei W
On Sunday, March 12, 2017 12:04 PM, Michael S. Tsirkin wrote: > On Sun, Mar 12, 2017 at 01:59:54AM +, Wang, Wei W wrote: > > On 03/11/2017 10:10 PM, Matthew Wilcox wrote: > > > On Sat, Mar 11, 2017 at 07:59:31PM +0800, Wei Wang wrote: > > > > I'm thinking what if the guest needs to transfer

[Qemu-devel] [PATCH 02/16] qio: create new qio_channel_read_all

2017-03-13 Thread Juan Quintela
It is the symmetric function from qio_channel_write_all Signed-off-by: Juan Quintela --- include/io/channel.h | 23 +++ io/channel.c | 37 + 2 files changed, 60 insertions(+) diff --git a/include/io/channel.h

[Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter

2017-03-13 Thread Juan Quintela
Indicates the number of threads that we would create. By default we create 2 threads. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- Catch inconsistent defaults. Thanks Eric Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 15/16] migration: Transfer pages over new channels

2017-03-13 Thread Juan Quintela
We switch for sending the page number to send real pages. Signed-off-by: Juan Quintela -- Remove the HACK bit, now we have the function that calculates the size of a page exported. Signed-off-by: Juan Quintela --- migration/migration.c | 14

Re: [Qemu-devel] [PATCH 04/21] qobject: add quint type

2017-03-13 Thread Eric Blake
On 03/13/2017 02:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/11/2017 07:22 AM, Marc-André Lureau wrote: >>> The type is not used at all yet. Add some tests to exercice it. >> >> s/exercice/exercise/ >> >> I wonder if we need this patch at all. >> >> I've

Re: [Qemu-devel] -rtc clock=vm with -icount 1, sleep=off introduces unexpected delays in device interactions

2017-03-13 Thread Alex Bennée
Pavel Dovgalyuk writes: > I also encountered icount problems with new MTTCG patches. > > Record/replay now cannot work, because iothread requests timers > without kicking the CPU. And cpu thread updates icount (that > are used for the clock). The interaction of kicking the

Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation

2017-03-13 Thread Marc-André Lureau
Hi On Mon, Mar 13, 2017 at 4:14 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster > > wrote: > > > >> I'm proposing this is 2.9 because it fixes a

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

2017-03-13 Thread Pavel Dovgalyuk
Hi, > From: mttcg-requ...@listserver.greensocs.com > [mailto:mttcg-requ...@listserver.greensocs.com] > > The next thing on my list it to look at the icount problems and review > Paolo's fixes for it. However those fixes should go in a separate > series and I assume via Paolo's tree. Do you

[Qemu-devel] [PATCH 01/16] qio: create new qio_channel_write_all

2017-03-13 Thread Juan Quintela
The function waits until it is able to write the full iov. Signed-off-by: Juan Quintela --- include/io/channel.h | 23 +++ io/channel.c | 39 +++ migration/qemu-file-channel.c | 29

[Qemu-devel] [PATCH 00/16] Multifd v4

2017-03-13 Thread Juan Quintela
Hi This is the 4th version of multifd. Changes: - XBZRLE don't need to be checked for - Documentation and defaults are consistent - split socketArgs - use iovec instead of creating something similar. - We use now the exported size of target page (another HACK removal) - created

[Qemu-devel] [PATCH 08/16] migration: Create multifd migration threads

2017-03-13 Thread Juan Quintela
Creation of the threads, nothing inside yet. Signed-off-by: Juan Quintela -- Use pointers instead of long array names Move to use semaphores instead of conditions as paolo suggestion Put all the state inside one struct. Use a counter for the number of threads created.

[Qemu-devel] [PATCH 03/16] migration: Test for disabled features on reception

2017-03-13 Thread Juan Quintela
Right now, if we receive a compressed page while this features are disabled, Bad Things (TM) can happen. Just add a test for them. Signed-off-by: Juan Quintela -- I had XBZRLE here also, but it don't need extra resources on destination, only on source. Additionally

Re: [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit

2017-03-13 Thread Mark Cave-Ayland
On 13/03/17 09:31, Nikunj A Dadhania wrote: > A bug was introduced in following commit: > > dc0ad84 target/ppc: update overflow flags for add/sub > > As for 32-bit ppc target extracting bit 63 for overflow is not correct. > Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS

[Qemu-devel] [PATCH 16/16] migration: Flush receive queue

2017-03-13 Thread Juan Quintela
Each time that we sync the bitmap, it is a possiblity that we receive a page that is being processed by a different thread. We fix this problem just making sure that we wait for all receiving threads to finish its work before we procedeed with the next stage. We are low on page flags, so we use

Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation

2017-03-13 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Mar 13, 2017 at 4:14 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster >> >

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

2017-03-13 Thread Alex Bennée
Pavel Dovgalyuk writes: > Hi, > >> From: mttcg-requ...@listserver.greensocs.com >> [mailto:mttcg-requ...@listserver.greensocs.com] >> >> The next thing on my list it to look at the icount problems and review >> Paolo's fixes for it. However those fixes should go in a

Re: [Qemu-devel] [PULL 0/2] Docker patches for 2.9

2017-03-13 Thread Peter Maydell
On 10 March 2017 at 08:20, Fam Zheng wrote: > The following changes since commit eba44e9339fc13c36e24c8c59e2b73ea231b46a1: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2017-03-06 15:13:23 +) > > are available in the git

Re: [Qemu-devel] [PATCH Risu v2 2/3] configure: Add initial support to PPC64 (big endian)

2017-03-13 Thread Peter Maydell
On 9 March 2017 at 19:38, Jose Ricardo Ziviani wrote: > This commit set Makefile to point to ppc64le source for both archs > (ppc64 and ppc64le) because they do the exact same thing. The > difference is in risugen and how the binary is build. If we're going to share a

[Qemu-devel] [PATCH 11/16] migration: Really use multiple pages at a time

2017-03-13 Thread Juan Quintela
We now send several pages at a time each time that we wakeup a thread. Signed-off-by: Juan Quintela -- Use iovec's insead of creating the equivalent. Signed-off-by: Juan Quintela --- migration/ram.c | 46

[Qemu-devel] [PATCH 14/16] migration: Test new fd infrastructure

2017-03-13 Thread Juan Quintela
We just send the address through the alternate channels and test that it is ok. Signed-off-by: Juan Quintela --- migration/ram.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

2017-03-13 Thread Juan Quintela
We make the locking and the transfer of information specific, even if we are still receiving things through the main thread. Signed-off-by: Juan Quintela --- migration/ram.c | 68 ++--- 1 file changed, 60 insertions(+), 8

Re: [Qemu-devel] Swap disks virtualization

2017-03-13 Thread Kevin Wolf
Am 13.03.2017 um 04:42 hat Christopher Pereira geschrieben: > We are currently providing Linux swap disks with QEMU driver, virtio > bus and qcow2 type. > > Do you know any alternatives that provide better performance? > > Considering that swap disks contain less critical data, QEMU could >

Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation

2017-03-13 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster > wrote: > >> I'm proposing this is 2.9 because it fixes a documentation regression. >> It affects only documentation; generated C code is unchanged except >> for

[Qemu-devel] [PATCH 10/16] migration: Create ram_multifd_page

2017-03-13 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter and a new flag for this type of pages. Signed-off-by: Juan Quintela --- hmp.c | 2 +

[Qemu-devel] [Bug 1672365] [NEW] nested 9pfs read fail

2017-03-13 Thread Leo Gaspard
Public bug reported: tl;dr: A virtfs read fails. The init being on this virtfs (mounted by the initrd), the linux kernel guest is unable to boot, and kernel panics. The fact that qemu still takes 100%cpu after the kernel panic makes me think it's a qemu bug. Here is the setup (some hashes

Re: [Qemu-devel] KVM call for 2017-03-14

2017-03-13 Thread Alex Bennée
Peter Maydell writes: > On 12 March 2017 at 21:45, Juan Quintela wrote: >> >> >> Hi >> >> Please, send any topic that you are interested in covering. >> >> So far the agenda is: >> >> - Direction of QEMU and toolstack in light of Google Cloud

Re: [Qemu-devel] [PATCH 04/21] qobject: add quint type

2017-03-13 Thread Marc-André Lureau
Hi - Original Message - > On 03/13/2017 02:15 AM, Markus Armbruster wrote: > > Eric Blake writes: > > > >> On 03/11/2017 07:22 AM, Marc-André Lureau wrote: > >>> The type is not used at all yet. Add some tests to exercice it. > >> > >> s/exercice/exercise/ > >> > >> I

Re: [Qemu-devel] [PATCH] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

2017-03-13 Thread Peter Maydell
On 9 March 2017 at 18:09, Ard Biesheuvel wrote: > The arm64 boot protocol stipulates that the kernel must be loaded > TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET > could be any 4 KB multiple between 0 and 2 MB, and whose value can be > found

[Qemu-devel] [PATCH 05/16] migration: Add multifd capability

2017-03-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 6 -- 3 files changed, 14 insertions(+), 2 deletions(-) diff

[Qemu-devel] [Bug 1672365] Re: nested 9pfs read fail

2017-03-13 Thread Leo Gaspard
Oh, I forgot to mention: it first worked for some time, then in the middle of a shell session running over a screen /var/lib/vm/consoles/nginx/screen from the outer VM (socat-linked to /var/lib/vm/consoles/nginx/socket.unix to provide a predictable pty link), the 9pfs stopped returning any data,

[Qemu-devel] [PATCH] fix :cirrus_vga fix OOB read case qemu Segmentation fault

2017-03-13 Thread hangaohuai
check the validity of parameters in cirrus_bitblt_rop_fwd_transp_xxx and cirrus_bitblt_rop_fwd_xxx to avoid the OOB read which causes qemu Segmentation fault. After the fix, we will touch the assert in cirrus_invalidate_region: assert(off_cur_end >= off_cur); Signed-off-by: fangying

Re: [Qemu-devel] [PULL 00/11] MTTCG Fix-ups for 2.9

2017-03-13 Thread Peter Maydell
On 9 March 2017 at 12:17, Alex Bennée wrote: > The following changes since commit b64842dee42d6b24d51283e4722140b73be1e222: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2017-03-08 09:47:52 +) > > are available in the git

Re: [Qemu-devel] [PATCH] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

2017-03-13 Thread Ard Biesheuvel
On 13 March 2017 at 11:22, Peter Maydell wrote: > On 9 March 2017 at 18:09, Ard Biesheuvel wrote: >> The arm64 boot protocol stipulates that the kernel must be loaded >> TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET

[Qemu-devel] [PATCH 07/16] migration: Create x-multifd-group parameter

2017-03-13 Thread Juan Quintela
Indicates how many pages we are going to send in each bach to a multifd thread. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- Be consistent with defaults and documentation Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 09/16] migration: Start of multiple fd work

2017-03-13 Thread Juan Quintela
We create new channels for each new thread created. We only send through them a character to be sure that we are creating the channels in the right order. Signed-off-by: Juan Quintela -- Split SocketArgs into incoming and outgoing args Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 04/16] migration: Don't create decompression threads if not enabled

2017-03-13 Thread Juan Quintela
Signed-off-by: Juan Quintela -- I removed the [HACK] part because previous patch just check that compression pages are not received. Signed-off-by: Juan Quintela --- migration/ram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [Bug 1672383] [NEW] Slow Windows XP load after commit a9353fe897ca2687e5b3385ed39e3db3927a90e0

2017-03-13 Thread Maskim Bakulin
Public bug reported: I've recently discovered, that in QEMU 2.8+ my Windows XP loading time has significantly worsened. In 2.7 it took 30-40 second to boot, but in 2.8 it became 2-2,5 minutes. I've used Git bisect, and found out that the change happened after commit

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

2017-03-13 Thread Laurent Vivier
Le 27/02/2017 à 15:38, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 24/02/2017 à 12:20, Alex Bennée a écrit : >>> There are a couple of changes that occur at the same time here: >>> >>> - introduce a single vCPU qemu_tcg_cpu_thread_fn >>> >>> One of these is

Re: [Qemu-devel] [PATCH] fix :cirrus_vga fix OOB read case qemu Segmentation fault

2017-03-13 Thread Gerd Hoffmann
Hi, > commit d16136d22af0fcf0d651de04c9e3cbc7137cc6f9 > Author: Benjamin Herrenschmidt > Date: Mon Jul 7 10:32:34 2014 +1000 > > cirrus: Fix host CPU blits > So does v2 is needed? Yes, otherwise we will end up with a regression similar to the one fixed by ben.

Re: [Qemu-devel] [PATCH] linux-user: Add TARGET_MAP_STACK and TARGET_MAP_HUGETLB for all remaining architectures

2017-03-13 Thread Helge Deller
On 11.03.2017 22:53, Richard Henderson wrote: > On 03/12/2017 04:30 AM, Helge Deller wrote: >> Add the missing defines and for TARGET_MAP_STACK and TARGET_MAP_HUGETLB >> for alpha, mips, ppc and x86, and fix the mmap_flags translation table >> to translate those flags between host and target

[Qemu-devel] [PATCH] vnc: replace hweight_long() with ctpopl()

2017-03-13 Thread Cédric Le Goater
ctpopl() has a better implementation than hweight_long() and ui/vnc.c being the last user of hweight_long(), we can simply remove it. Signed-off-by: Cédric Le Goater --- include/qemu/bitops.h | 10 -- ui/vnc.c | 6 +++--- 2 files changed, 3 insertions(+), 13

Re: [Qemu-devel] [PATCH] vnc: replace hweight_long() with ctpopl()

2017-03-13 Thread Peter Maydell
On 13 March 2017 at 15:33, Cédric Le Goater wrote: > ctpopl() has a better implementation than hweight_long() and ui/vnc.c > being the last user of hweight_long(), we can simply remove it. > > Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 08/12] block: Request block status from *file for BDRV_BLOCK_RAW

2017-03-13 Thread Kevin Wolf
This fixes bdrv_co_get_block_status() for the bdrv_mirror_top block driver, which must fall through to bs->backing instead of bs->file. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 2/5] target-mips: remove old & unuseful comments

2017-03-13 Thread Yongbok Kim
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/target/mips/translate.c b/target/mips/translate.c > index 8b4a072ecb..1fe0ff39f2 100644 > ---

[Qemu-devel] [PULL 11/12] mirror: Implement .bdrv_refresh_filename

2017-03-13 Thread Kevin Wolf
We want query-block to return the right filename, even if a mirror job put a bdrv_mirror_top on top of the actual image format driver. Let bdrv_mirror_top.bdrv_refresh_filename get the filename from its backing file. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/5] target-mips: fix compiler warnings (clang 5)

2017-03-13 Thread Yongbok Kim
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote: > static code analyzer complain: > > target/mips/helper.c:453:5: warning: Function call argument is an > uninitialized value > qemu_log_mask(CPU_LOG_MMU, > ^~ > > 'physical' and 'prot' are uninitialized if

Re: [Qemu-devel] KVM call for 2017-03-14

2017-03-13 Thread Juan Quintela
Peter Maydell wrote: > On 12 March 2017 at 21:45, Juan Quintela wrote: >> >> >> Hi >> >> Please, send any topic that you are interested in covering. >> >> So far the agenda is: >> >> - Direction of QEMU and toolstack in light of Google Cloud blog:

[Qemu-devel] [PULL 03/12] block: Drop unmaintained 'archipelago' driver

2017-03-13 Thread Kevin Wolf
From: Eric Blake The driver has failed to build since commit da34e65, in qemu 2.6, due to a missing include of qapi/error.h for error_setg(). Since no one has complained in three releases, it is easier to remove the dead code than to keep it around, especially since it is not

Re: [Qemu-devel] [PATCH 3/5] target-mips: log bad coprocessor0 register accesses with LOG_UNIMP

2017-03-13 Thread Yongbok Kim
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/target/mips/translate.c b/target/mips/translate.c > index

Re: [Qemu-devel] [PATCH v2 4/4] [RfC] stdvga: add xres and yres properties.

2017-03-13 Thread Gerd Hoffmann
On Do, 2017-03-09 at 22:03 +0100, Hervé Poussineau wrote: > Le 09/03/2017 à 09:38, Gerd Hoffmann a écrit : > > Add two new registers to the qemu extended register range, carrying the > > suggested width and height of the display device. In case the xres and > > yres properties are set, fill these

[Qemu-devel] about branch instruction

2017-03-13 Thread oussema ben khedher
hi i want to know where the translation of branch instruction (arm) to tcg code is located  thanks

[Qemu-devel] [PULL 02/12] file-posix: Consider max_segments for BlockLimits.max_transfer

2017-03-13 Thread Kevin Wolf
From: Fam Zheng BlockLimits.max_transfer can be too high without this fix, guest will encounter I/O error or even get paused with werror=stop or rerror=stop. The cause is explained below. Linux has a separate limit, /sys/block/.../queue/max_segments, which in the worst case can

[Qemu-devel] [PULL 06/12] migration: Document handling of bdrv_is_allocated() errors

2017-03-13 Thread Kevin Wolf
From: Eric Blake Migration is the only code left in the tree that does not react to bdrv_is_allocated() failures. But as there is no useful way to react to the failure, and we are merely skipping unallocated sectors on success, just document that our choice of handling is

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

2017-03-13 Thread fangying
Hi, Huang Kai After weeks of intensive testing, we think the problem is solved and this issue can be closed. On 2017/2/27 15:38, Huang, Kai wrote: On 2/25/2017 2:44 PM, Herongguang (Stephen) wrote: On 2017/2/24 23:14, Paolo Bonzini wrote: On 24/02/2017 16:10, Chris Friesen wrote: On

[Qemu-devel] [PATCH] MAINTAINERS: update for MIPS devices

2017-03-13 Thread Yongbok Kim
Add myself to MIPSSIM and new entry for Fulong 2E. Add an entry for Boston machine (Paul Burton). Signed-off-by: Yongbok Kim cc: Paul Burton --- MAINTAINERS | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 01/12] backup: allow target without .bdrv_get_info

2017-03-13 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Currently backup to nbd target is broken, as nbd doesn't have .bdrv_get_info realization. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 04/12] backup: React to bdrv_is_allocated() errors

2017-03-13 Thread Kevin Wolf
From: Eric Blake If bdrv_is_allocated() fails, we should immediately do the backup error action, rather than attempting backup_do_cow() (although that will likely fail too). Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 09/12] commit: Implement bdrv_commit_top.bdrv_co_get_block_status

2017-03-13 Thread Kevin Wolf
In some cases, bdrv_co_get_block_status() is called recursively for the whole backing chain. The automatically inserted bdrv_commit_top filter driver must not stop the recursion, so implement a callback that simply forwards the request to bs->backing. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 4/5] target-mips: replace break by goto cp0_unimplemented

2017-03-13 Thread Yongbok Kim
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote: > this fixes many warnings like: > > target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read > rn = "invalid sel"; > ^~ > > Reported-by: Clang Static Analyzer > Signed-off-by:

Re: [Qemu-devel] [PATCH] fix :cirrus_vga fix OOB read case qemu Segmentation fault

2017-03-13 Thread Gerd Hoffmann
> @@ -97,6 +97,11 @@ glue(glue(cirrus_bitblt_rop_fwd_transp_, > ROP_NAME),_8)(CirrusVGAState *s, > uint8_t p; > dstpitch -= bltwidth; > srcpitch -= bltwidth; > + > +if (dstpitch < 0 || srcpitch < 0) { > +return; > +} Shouldn't that be ... if (bltheight > 1 &&

[Qemu-devel] [PATCH v2] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

2017-03-13 Thread Ard Biesheuvel
The arm64 boot protocol stipulates that the kernel must be loaded TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET could be any 4 KB multiple between 0 and 2 MB, and whose value can be found in the header of the Image file. So after attempts to load the arm64 kernel image

Re: [Qemu-devel] KVM call for 2017-03-14

2017-03-13 Thread Peter Maydell
On 13 March 2017 at 15:12, Juan Quintela wrote: > Peter Maydell wrote: >> [Making QEMU more modular would help with defeating the legacy >> and back-compat dragons, though] > > That would be ideal, but where to start? Think of something as

Re: [Qemu-devel] Swap disks virtualization

2017-03-13 Thread Christopher Pereira
On 13-Mar-17 08:21, Kevin Wolf wrote: I think the state of the art is to give the VMs enough memory rather Thanks Kevin. This was the answer I expected, so here follows my second question: By increasing virtual RAM, I'm afraid that the guest OS may detect and use more memory, causing the

Re: [Qemu-devel] [PULL 0/3] x86: Haswell TSX blacklist fix for 2.9

2017-03-13 Thread Peter Maydell
On 10 March 2017 at 19:45, Eduardo Habkost wrote: > The following changes since commit dd4d2578215cd380f40a38028a9904e15b135ef3: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-fixes-20170309-1' > into staging (2017-03-09 13:16:05 +) > > are available in the

[Qemu-devel] [PATCH] target/openrisc: Fixes for memory debugging

2017-03-13 Thread Stafford Horne
When debugging in gdb you might want to inspect instructions in mapped pages or in exception vectors like 0x800 etc. This was previously not possible in qemu since the *get_phys_page_debug() routine only looked into the data tlb. Change to fall back to look into instruction tlb and plain

Re: [Qemu-devel] [PATCH 5/5] icount: process QEMU_CLOCK_VIRTUAL timers in vCPU thread

2017-03-13 Thread Paolo Bonzini
On 13/03/2017 17:53, Alex Bennée wrote: > > Paolo Bonzini writes: > >> icount has become much slower after tcg_cpu_exec has stopped >> using the BQL. There is also a latent bug that is masked by >> the slowness. >> >> The slowness happens because every occurrence of a

Re: [Qemu-devel] [PATCH 03/16] migration: Test for disabled features on reception

2017-03-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Right now, if we receive a compressed page while this features are > disabled, Bad Things (TM) can happen. Just add a test for them. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert >

Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-13 Thread Paolo Bonzini
On 13/03/2017 13:41, Halil Pasic wrote: > > > On 03/10/2017 10:08 PM, Halil Pasic wrote: >> >> >> On 03/10/2017 05:47 PM, Paolo Bonzini wrote: >>> >>> On 07/03/2017 14:16, Halil Pasic wrote: The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and 9ffe337c08

Re: [Qemu-devel] [PATCH 5/5] icount: process QEMU_CLOCK_VIRTUAL timers in vCPU thread

2017-03-13 Thread Alex Bennée
Paolo Bonzini writes: > icount has become much slower after tcg_cpu_exec has stopped > using the BQL. There is also a latent bug that is masked by > the slowness. > > The slowness happens because every occurrence of a QEMU_CLOCK_VIRTUAL > timer now has to wake up the I/O

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

2017-03-13 Thread Alex Bennée
Laurent Vivier writes: > Le 27/02/2017 à 15:38, Alex Bennée a écrit : >> >> Laurent Vivier writes: >> >>> Le 24/02/2017 à 12:20, Alex Bennée a écrit : There are a couple of changes that occur at the same time here: - introduce a single

Re: [Qemu-devel] [PATCH 09/16] migration: Start of multiple fd work

2017-03-13 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Mar 13, 2017 at 01:44:27PM +0100, Juan Quintela wrote: >> We create new channels for each new thread created. We only send through >> them a character to be sure that we are creating the channels in the >> right order. >> >>

Re: [Qemu-devel] [PATCH 07/16] migration: Create x-multifd-group parameter

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 05:49:59PM +0100, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Mon, Mar 13, 2017 at 01:44:25PM +0100, Juan Quintela wrote: > >> Indicates how many pages we are going to send in each bach to a multifd > >> thread. > > > > > >> diff --git

Re: [Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter

2017-03-13 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Mar 13, 2017 at 01:44:24PM +0100, Juan Quintela wrote: >> Indicates the number of threads that we would create. By default we >> create 2 threads. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PATCH 07/16] migration: Create x-multifd-group parameter

2017-03-13 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Mar 13, 2017 at 01:44:25PM +0100, Juan Quintela wrote: >> Indicates how many pages we are going to send in each bach to a multifd >> thread. > > >> diff --git a/qapi-schema.json b/qapi-schema.json >> index b7cb26d..33a6267 100644 >> ---

Re: [Qemu-devel] [PATCH 04/16] migration: Don't create decompression threads if not enabled

2017-03-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > > -- > > I removed the [HACK] part because previous patch just check that > compression pages are not received. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PATCH 07/16] migration: Create x-multifd-group parameter

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 01:44:25PM +0100, Juan Quintela wrote: > Indicates how many pages we are going to send in each bach to a multifd > thread. > diff --git a/qapi-schema.json b/qapi-schema.json > index b7cb26d..33a6267 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -988,6

Re: [Qemu-devel] [PATCH 4/5] main-loop: remove now unnecessary optimization

2017-03-13 Thread Alex Bennée
Paolo Bonzini writes: > This optimization is not necessary anymore, because the vCPU now drops > the I/O thread lock even with TCG. Drop it to simplify the code and > avoid the "I/O thread spun for 1000 iterations" warning. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 02/16] qio: create new qio_channel_read_all

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 01:44:20PM +0100, Juan Quintela wrote: > It is the symmetric function from qio_channel_write_all > > Signed-off-by: Juan Quintela > --- > include/io/channel.h | 23 +++ > io/channel.c | 37

Re: [Qemu-devel] [PATCH 01/16] qio: create new qio_channel_write_all

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 01:44:19PM +0100, Juan Quintela wrote: > The function waits until it is able to write the full iov. > > Signed-off-by: Juan Quintela > --- > include/io/channel.h | 23 +++ > io/channel.c | 39

Re: [Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 01:44:24PM +0100, Juan Quintela wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > diff --git

Re: [Qemu-devel] [PATCH 09/16] migration: Start of multiple fd work

2017-03-13 Thread Daniel P. Berrange
On Mon, Mar 13, 2017 at 01:44:27PM +0100, Juan Quintela wrote: > We create new channels for each new thread created. We only send through > them a character to be sure that we are creating the channels in the > right order. > > Signed-off-by: Juan Quintela > > -- > Split

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

2017-03-13 Thread Paolo Bonzini
On 13/03/2017 15:58, fangying wrote: > Hi, Huang Kai > > After weeks of intensive testing, we think the problem is solved and > this issue can be closed. Thanks for the update. We got to the same conclusion. Paolo

Re: [Qemu-devel] [PATCH v2 0/2] X86/HMP: Expose x86 model specific registers via human monitor

2017-03-13 Thread Eric Blake
On 03/13/2017 11:59 AM, Julian Kirsch wrote: > Provide read/write access to x86 model specific registers (MSRs) by means of > two new HMP commands "msr-get" and "msr-set". The rationale behind this > is to improve introspection capabilities for system virtualization mode. > For instance, many

Re: [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history

2017-03-13 Thread Markus Armbruster
Nir Soffer writes: > On Wed, Mar 8, 2017 at 8:29 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 03/07/2017 03:16 AM, Markus Armbruster wrote: John Snow writes: > On 03/06/2017 03:18 AM, Markus

Re: [Qemu-devel] [PATCHv2] hw/net: implement MIB counters in mcf_fec driver

2017-03-13 Thread Jason Wang
On 2017年03月13日 12:56, Greg Ungerer wrote: The FEC ethernet hardware module used on ColdFire SoC parts contains a block of RAM used to maintain hardware counters. This block is accessible via the usual FEC register address space. There is currently no support for this in the QEMU mcf_fec

[Qemu-devel] [PATCH for-2.9 05/47] qapi: Have each QAPI schema declare its returns white-list

2017-03-13 Thread Markus Armbruster
qapi.py has a hardcoded white-list of command names that may violate the rules on permitted return types. Add a new pragma directive 'returns-whitelist', and use it to replace the hard-coded white-list. Signed-off-by: Markus Armbruster --- docs/qapi-code-gen.txt

[Qemu-devel] [PATCH for-2.9 06/47] qapi: Have each QAPI schema declare its name rule violations

2017-03-13 Thread Markus Armbruster
qapi.py has a hardcoded white-list of type names that may violate the rule on use of upper and lower case. Add a new pragma directive 'name-case-whitelist', and use it to replace the hard-coded white-list. Signed-off-by: Markus Armbruster --- docs/qapi-code-gen.txt

[Qemu-devel] [PATCH for-2.9 07/47] qapi: Clean up build of generated documentation

2017-03-13 Thread Markus Armbruster
Rename intermediate qemu-qapi.texi to qemu-qmp-qapi.texi to match its user qemu-qmp-ref.texi, just like qemu-ga-qapi.texi matches qemu-ga-ref.texi. Build the intermediate .texi next to the sources and the final output in docs/ instead of dumping them into the build root. Fix version.texi

[Qemu-devel] [PATCH for-2.9 26/47] qapi2texi: Generate reference to base type members

2017-03-13 Thread Markus Armbruster
The generated documentation doesn't mention object type members inherited from a base type. Fix that. Example change (qemu-qmp-ref.txt): -- Struct: VncServerInfo The network connection information for server Members: 'auth' (optional) authentication method used

[Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-13 Thread Markus Armbruster
This reverts commit 3313b61's changes to tests/qapi-schema/, except for tests/qapi-schema/doc-*. Signed-off-by: Markus Armbruster --- tests/qapi-schema/alternate-any.err| 2 +- tests/qapi-schema/alternate-any.json | 4 -

[Qemu-devel] [PATCH for-2.9 39/47] qapi: Drop unused variable events

2017-03-13 Thread Markus Armbruster
Missed in commit e98859a Signed-off-by: Markus Armbruster --- scripts/qapi.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 0da426a..12b1bda 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -49,7 +49,6 @@

[Qemu-devel] [PATCH for-2.9 27/47] qapi2texi: Generate documentation for variant members

2017-03-13 Thread Markus Armbruster
A flat union's branch brings in the members of another type. Generate a suitable reference to that type. Example change (qemu-qmp-ref.txt): -- Flat Union: QCryptoBlockOpenOptions The options that are available for all encryption formats when opening an existing volume

  1   2   3   4   >