Re: [Qemu-devel] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

2017-04-27 Thread Eric Blake
On 04/27/2017 12:20 AM, Thomas Huth wrote: > If the user needs to specify the disk geometry, the corresponding > parameters of the "-device ide-hd" option should be used instead. > "-hdachs" is considered as deprecated and might be removed soon. > > Signed-off-by: Thomas Huth >

Re: [Qemu-devel] [PATCH v5 00/19] TCG cross-tb optimizations

2017-04-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/19] TCG cross-tb optimizations Message-id: 20170427120006.20564-1-...@twiddle.net Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 07:54:31 -0500 Eric Blake wrote: > On 04/26/2017 09:35 PM, He Chen wrote: > > This patch is going to add SLIT table support in QEMU, and provides > > additional option `dist` for command `-numa` to allow user set vNUMA > > distance by QEMU command. > > > >

Re: [Qemu-devel] [PATCH v5] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-04-27 Thread Michael Roth
Quoting ZhiPeng Lu (2017-04-27 04:25:03) > we can get the network interface statistics inside a virtual machine by > guest-network-get-interfaces command. it is very useful for us to monitor > and analyze network traffic. > > Signed-off-by: ZhiPeng Lu > Signed-off-by:

Re: [Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock trace events

2017-04-27 Thread Paolo Bonzini
- Original Message - > From: jos...@linux.vnet.ibm.com > To: "Paolo Bonzini" > Cc: f...@redhat.com, qemu-devel@nongnu.org, stefa...@redhat.com > Sent: Thursday, April 27, 2017 4:59:26 PM > Subject: Re: [Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock >

Re: [Qemu-devel] [PATCH 2/9] memory: add support getting and using a dirty bitmap copy.

2017-04-27 Thread Gerd Hoffmann
On Do, 2017-04-27 at 16:00 +0200, Kevin Wolf wrote: > Am 21.04.2017 um 11:16 hat Gerd Hoffmann geschrieben: > > +bool cpu_physical_memory_snapshot_get_dirty(DirtyBitmapSnapshot *snap, > > +ram_addr_t start, > > +

Re: [Qemu-devel] [PATCH 00/41] Migration cleanup

2017-04-27 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > High level question: > A lot of this is splitting migration.h which is a GPLv2 licensed file, and > you're > carefully copying the authorship (Anthony) to each new header file and > also the

Re: [Qemu-devel] [PATCH v2 1/2] numa: introduce numa_auto_assign_ram() function in MachineClass

2017-04-27 Thread Laurent Vivier
On 27/04/2017 16:09, Eduardo Habkost wrote: > On Thu, Apr 27, 2017 at 12:12:58PM +0200, Laurent Vivier wrote: >> We need to change the way we distribute the memory across >> the nodes. To keep compatibility between machine type version >> introduce a machine type dependent function. >> >>

Re: [Qemu-devel] [PATCH v2 3/3] qemu-img: Document backing options

2017-04-27 Thread Kevin Wolf
Am 26.04.2017 um 15:46 hat Max Reitz geschrieben: > The create and convert subcommands have shorthands to set the > backing_file and, in the case of create, the backing_fmt options for the > new image. However, they have not been documented so far, which is > remedied by this patch. > >

Re: [Qemu-devel] [PATCH v3] iotests: 109: Filter out "len" of failed jobs

2017-04-27 Thread Kevin Wolf
Am 20.04.2017 um 02:54 hat Fam Zheng geschrieben: > Mirror calculates job len from current I/O progress: > > s->common.len = s->common.offset + > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; > > The final "len" of a failed mirror job in iotests 109 depends on the >

[Qemu-devel] [Bug 1670377] Re: VNC: short read for zlre data/RDR EndOfStream

2017-04-27 Thread Daniel Berrange
It isn't 100% clear from the info provided, but this is almost certainly fixed in 2.9.0 by commit 537848ee62195fc06c328b1cd64f4218f404a7f1 Author: Michael Tokarev Date: Fri Feb 3 12:52:29 2017 +0300 vnc: do not disconnect on EAGAIN When qemu vnc server is trying

Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 16:05:42 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Thu, 27 Apr 2017 07:54:31 -0500 > > Eric Blake wrote: > > > >> On 04/26/2017 09:35 PM, He Chen wrote: > >> > This patch is going to add

[Qemu-devel] [Bug 1686390] Re: vnc server closed socket after arrow "down" keyevent

2017-04-27 Thread leon
Find the root reason: qio_channel_write is going to write 290124 data, but only wrote 238644, and for the next write 51489, it returned error, then trigger vnc_client_io_error and disconnect socket. ssize_t vnc_client_write_buf(VncState *vs, const uint8_t *data, size_t datalen) { Error *err

Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes

2017-04-27 Thread Markus Armbruster
Igor Mammedov writes: > On Thu, 27 Apr 2017 07:54:31 -0500 > Eric Blake wrote: > >> On 04/26/2017 09:35 PM, He Chen wrote: >> > This patch is going to add SLIT table support in QEMU, and provides >> > additional option `dist` for command `-numa` to allow

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-27 Thread Markus Armbruster
Zhang Chen writes: > On 04/27/2017 09:00 PM, Markus Armbruster wrote: >> Broken in commit daa33c5. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Markus Armbruster > > About this bug I remember have discussed with paolo. > >

Re: [Qemu-devel] [PATCH v2 1/2] numa: introduce numa_auto_assign_ram() function in MachineClass

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 12:12:58PM +0200, Laurent Vivier wrote: > We need to change the way we distribute the memory across > the nodes. To keep compatibility between machine type version > introduce a machine type dependent function. > > Signed-off-by: Laurent Vivier [...]

Re: [Qemu-devel] [PATCH for-2.10?] block: Do not unref bs->file on error in BD's open

2017-04-27 Thread Kevin Wolf
Am 13.04.2017 um 17:43 hat Max Reitz geschrieben: > The block layer takes care of removing the bs->file child if the block > driver's bdrv_open()/bdrv_file_open() implementation fails. The block > driver therefore does not need to do so, and indeed should not unless it > sets bs->file to NULL

[Qemu-devel] [Bug 1686390] Re: vnc server closed socket after arrow "down" keyevent

2017-04-27 Thread Daniel Berrange
> Wrote wire 0x5579e6bd2c60 51480 -> -2 That is QIO_CHANNEL_ERR_BLOCK, aka EAGAIN. This is fixed in the 2.9.0 release with commit 537848ee62195fc06c328b1cd64f4218f404a7f1 Author: Michael Tokarev Date: Fri Feb 3 12:52:29 2017 +0300 vnc: do not disconnect on EAGAIN

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: fix alignment calculations in bdrv_co_do_zero_pwritev

2017-04-27 Thread Kevin Wolf
Am 26.04.2017 um 10:40 hat Denis V. Lunev geschrieben: > tail_padding_bytes is calculated wrong. F.e. for > offset = 0 > bytes = 2048 > align = 512 > we will have tail_padding_bytes = 512 which is definitely wrong. The patch > fixes that arithmetics. > > Fortunately this problem is

Re: [Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock trace events

2017-04-27 Thread joserz
On Thu, Apr 27, 2017 at 10:55:04AM +0200, Paolo Bonzini wrote: > > > On 24/04/2017 19:19, Jose Ricardo Ziviani wrote: > > These trace events were very useful to help me to understand and find a > > reordering issue in vfio, for example: > > > > qemu_mutex_lock locked mutex 0x10905ad8 > >

Re: [Qemu-devel] [PATCH v2 0/3] qemu-img/convert: Some small fixes

2017-04-27 Thread Kevin Wolf
Am 26.04.2017 um 15:46 hat Max Reitz geschrieben: > This series fixes some small issues in qemu-img's convert subcommand. Thanks, applied to block-next. Kevin

Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-27 Thread Paolo Bonzini
On 25/04/2017 14:02, Jason Wang wrote: > > Thanks a lot for the fix. > > Two questions: > > - If virtio_net_set_status() is the only function that may access tx_bh, > it looks like setting tx_waiting to zero is sufficient? I think clearing tx_bh is better anyway, as leaving a dangling

Re: [Qemu-devel] [PATCH] virtio: allow broken device to notify guest

2017-04-27 Thread Michael S. Tsirkin
On Thu, Apr 27, 2017 at 09:03:37AM +0200, Greg Kurz wrote: > On Thu, 27 Apr 2017 02:42:56 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 26, 2017 at 03:29:46PM +0200, Greg Kurz wrote: > > > On Wed, 26 Apr 2017 15:15:48 +0200 > > > Cornelia Huck

Re: [Qemu-devel] [PATCH v2 3/3] qemu-img: Document backing options

2017-04-27 Thread Eric Blake
On 04/26/2017 08:46 AM, Max Reitz wrote: > The create and convert subcommands have shorthands to set the > backing_file and, in the case of create, the backing_fmt options for the > new image. However, they have not been documented so far, which is > remedied by this patch. > > +++

[Qemu-devel] [Bug 1064631] Re: Feature request: tls for chardev socket (telnet, tcp, udp)

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1064631 Title: Feature request: tls for chardev socket (telnet,tcp,udp) Status in QEMU:

[Qemu-devel] [Bug 1081416] Re: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots

2017-04-27 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1081416 Title: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots Status in QEMU:

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: > On Wed, 26 Apr 2017 13:07:02 -0600 > Bruce Rogers wrote: > >> Commit f0c9d64a exposed an issue with the code order in acpi_setup. >> As of that commit, a xenfv machine type guest will no longer start >>

[Qemu-devel] [Bug 1284090] Re: RFE: QMP: report error reason in BLOCK_IO_ERROR message

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1284090 Title: RFE: QMP: report error reason in BLOCK_IO_ERROR message Status in QEMU: New

[Qemu-devel] [Bug 1184089] Re: [Feature request] loadvm snapshot as read-only

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1184089 Title: [Feature request] loadvm snapshot as read-only Status in QEMU: New Bug

[Qemu-devel] [Bug 1090602] Re: RFE: Allow specifying usb-host device by serial number

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090602 Title: RFE: Allow specifying usb-host device by serial number Status in QEMU: New

[Qemu-devel] [Bug 1090615] Re: RFE: More info in qemu-img info/check

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090615 Title: RFE: More info in qemu-img info/check Status in QEMU: New Bug

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

2017-04-27 Thread Markus Armbruster
Mao Zhongyi writes: > Currently, socket connection in net is realized by an old > mechanism which is non-blocking. > > That old mechanism may cause net blocks on DNS lookups and > QEmu has already replaced it with QIOchannel in many features, > such as migration. > >

[Qemu-devel] [Bug 1090604] Re: RFE: Implement support for SMBIOS Type 41 structures

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090604 Title: RFE: Implement support for SMBIOS Type 41 structures Status in QEMU: New

[Qemu-devel] [Bug 1064631] Re: Feature request: tls for chardev socket (telnet, tcp, udp)

2017-04-27 Thread Daniel Berrange
This support was introduced in QEMU 2.6 last year. Some info here: https://www.berrange.com/posts/2016/08/16/improving-qemu-security-part-6 -tls-support-for-character-devices/ ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH v5 01/19] target/nios2: Fix 64-bit ilp32 compilation

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > Avoid a "cast from pointer to integer of different size" warning > by using the proper host type. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/nios2/translate.c | 2 +- >

[Qemu-devel] [Bug 1592351] Re: mouse pointer offset with gtk, gl=on

2017-04-27 Thread undefined
Mouse still doesn't work properly with 2.9.0 and Ubuntu 17.04 guest -smp 2 -enable-kvm -vga virtio -display gtk,gl=on -m 2048 -cdrom ubuntu-17.04-desktop-amd64.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v5 02/19] tcg/sparc: Use the proper compilation flags for 32-bit

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > We have required a v9 cpu since 9b9c37c36439ee0452632253dac7a31897f27f70. > However, the flags we were using did not reliably enable v8plus, which > meant that the compiler didn't know it could inline 64-bit atomics. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 09:44:31 -0600 "Bruce Rogers" wrote: > >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: > > On Wed, 26 Apr 2017 13:07:02 -0600 > > Bruce Rogers wrote: > > > >> Commit f0c9d64a exposed an issue with the code order

Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > We need to coordinate with the TCG_OVERSIZED_GUEST test in cputlb.c, > and allow 64-bit atomics even though sizeof(void *) == 4. Hmm you say this here but we never actually do it. But the other changes seem fine. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v2 1/2] numa: introduce numa_auto_assign_ram() function in MachineClass

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 05:09:26PM +0200, Laurent Vivier wrote: > On 27/04/2017 16:09, Eduardo Habkost wrote: > > On Thu, Apr 27, 2017 at 12:12:58PM +0200, Laurent Vivier wrote: > >> We need to change the way we distribute the memory across > >> the nodes. To keep compatibility between machine

Re: [Qemu-devel] [PATCH v2 2/4] net/socket: Improve -net socket error reporting

2017-04-27 Thread Markus Armbruster
Mao Zhongyi writes: > When -net socket fails, it first reports a specific error, then > a generic one, like this: > > $ qemu-system-x86_64 -net socket, > qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, > mcast= or udp= is required >

Re: [Qemu-devel] [PATCH v5 04/19] exec-all: export tb_htable_lookup

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > Message-Id: <1493263764-18657-2-git-send-email-c...@braap.org> > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-04-27 Thread Wei Wang
On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: On Wed, Apr 26, 2017 at 11:03:34AM +, Wang, Wei W wrote: Hi Michael, could you please give some feedback? I'm sorry, I'm not sure feedback on what you are requesting. Oh, just some trivial things (e.g. use a field in the header,

[Qemu-devel] [PATCH 2/2] ppc/xics: preserve P and Q bits for KVM IRQs

2017-04-27 Thread Sam Bobroff
Kernel commit 17d48610ae0f ("KVM: PPC: Book 3S: XICS: Implement ICS P/Q states") added new bits to the state used by KVM IRQs. Currently, QEMU does not preserve these bits, so migrating (or otherwise saving and restoring) the guest state causes the P and Q bits to be cleared. Clearing the P bit

[Qemu-devel] [PATCH 1/2] ppc/xics: Fix stale irq->status bits after get

2017-04-27 Thread Sam Bobroff
ics_get_kvm_state() "or"s set bits into irq->status but does not mask out clear bits. Correct this by initializing the IRQ status to zero before adding bits to it. Signed-off-by: Sam Bobroff --- hw/intc/xics_kvm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH] virtio: allow broken device to notify guest

2017-04-27 Thread Greg Kurz
On Thu, 27 Apr 2017 02:42:56 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 26, 2017 at 03:29:46PM +0200, Greg Kurz wrote: > > On Wed, 26 Apr 2017 15:15:48 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 26 Apr 2017 14:51:17 +0200 > > > Greg Kurz

Re: [Qemu-devel] qemu_savevm_state_header(s->to_dst_file)

2017-04-27 Thread Dr. David Alan Gilbert
* ali saeedi (ali.saeed...@gmail.com) wrote: > Hi > does 'qemu_savevm_state_header(s->to_dst_file)' function in migration.c > only stores header in qemu file and does not send it to destination? if it > sends to destination which function does that? No, it saves it on the file descriptor

Re: [Qemu-devel] [PATCH v3 1/2] ramblock: add RAMBLOCK_FOREACH()

2017-04-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > So that it can simplifies the iterators. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > exec.c | 22 +++--- > include/exec/ramlist.h | 5 + >

Re: [Qemu-devel] [PATCH 4/4] qobject-input-visitor: Catch misuse of end_struct vs. end_list

2017-04-27 Thread Markus Armbruster
Marc-André Lureau writes: > On Thu, Apr 27, 2017 at 12:41 PM Markus Armbruster > wrote: > >> Signed-off-by: Markus Armbruster >> > > It would be more obvious with a check for qobject_type(tos->obj), no? --verbose? > In any

[Qemu-devel] [PATCH v5 10/19] target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" This helper will be used by subsequent changes. Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-9-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target/i386/translate.c | 25

[Qemu-devel] [PATCH v5 11/19] target/i386: optimize cross-page direct jumps in softmmu

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the gen_jr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota

[Qemu-devel] [PATCH v5 17/19] tcg/aarch64: Implement goto_ptr

2017-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 22 -- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index b82eac4..55a46ac 100644

[Qemu-devel] [PATCH v5 02/19] tcg/sparc: Use the proper compilation flags for 32-bit

2017-04-27 Thread Richard Henderson
We have required a v9 cpu since 9b9c37c36439ee0452632253dac7a31897f27f70. However, the flags we were using did not reliably enable v8plus, which meant that the compiler didn't know it could inline 64-bit atomics. Signed-off-by: Richard Henderson --- configure | 6 +++--- 1

[Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts

2017-04-27 Thread Richard Henderson
We need to coordinate with the TCG_OVERSIZED_GUEST test in cputlb.c, and allow 64-bit atomics even though sizeof(void *) == 4. Signed-off-by: Richard Henderson --- include/qemu/atomic.h | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH v5 07/19] tcg: export tcg_gen_lookup_and_goto_ptr

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Instead of exporting goto_ptr directly to TCG frontends, export tcg_gen_lookup_and_goto_ptr(), which calls goto_ptr with the pointer returned by the lookup_tb_ptr() helper. This is the only use case we have for goto_ptr and lookup_tb_ptr, so having this

[Qemu-devel] [PATCH v5 08/19] target/arm: optimize cross-page direct jumps in softmmu

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the lookup_and_goto_ptr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota

[Qemu-devel] [PATCH v5 16/19] tcg/ppc: Implement goto_ptr

2017-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.h | 2 +- tcg/ppc/tcg-target.inc.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h index a9aa974..5f4a40a 100644 --- a/tcg/ppc/tcg-target.h +++

[Qemu-devel] [PATCH v5 04/19] exec-all: export tb_htable_lookup

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-2-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- cpu-exec.c | 6 ++ include/exec/exec-all.h | 2 ++ 2 files changed, 4

[Qemu-devel] [PATCH v5 15/19] tcg/i386: implement goto_ptr

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-6-git-send-email-c...@braap.org> [rth: Reuse goto_ptr epilogue for exit_tb 0.]

[Qemu-devel] [PATCH v5 13/19] tb-hash: improve tb_jmp_cache hash function in user mode

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Optimizations to cross-page chaining and indirect branches make performance more sensitive to the hit rate of tb_jmp_cache. The constraint of reserving some bits for the page number lowers the achievable quality of the hashing function. However, user-mode

[Qemu-devel] [PATCH] io: simplify qio_channel_attach_aio_context

2017-04-27 Thread Paolo Bonzini
If properly preceded by qio_channel_detach_aio_context, this function really has nothing to do except setting ioc->ctx. Signed-off-by: Paolo Bonzini --- io/channel.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/io/channel.c b/io/channel.c

Re: [Qemu-devel] [RFC PATCH 02/20] intel_iommu: exposed extended-context mode to guest

2017-04-27 Thread Peter Xu
On Wed, Apr 26, 2017 at 06:06:32PM +0800, Liu, Yi L wrote: > VT-d implementations reporting PASID or PRS fields as "Set", must also > report ecap.ECS as "Set". Extended-Context is required for SVM. > > When ECS is reported, intel iommu driver would initiate extended root entry > and extended

Re: [Qemu-devel] [RFC PATCH 12/20] Memory: Add func to fire pasidt_bind notifier

2017-04-27 Thread Peter Xu
On Thu, Apr 27, 2017 at 06:25:37PM +0800, Liu, Yi L wrote: > On Thu, Apr 27, 2017 at 02:14:27PM +0800, Peter Xu wrote: > > On Thu, Apr 27, 2017 at 10:37:19AM +0800, Liu, Yi L wrote: > > > On Wed, Apr 26, 2017 at 03:50:16PM +0200, Paolo Bonzini wrote: > > > > > > > > > > > > On 26/04/2017 12:06,

Re: [Qemu-devel] [PATCH 4/4] qobject-input-visitor: Catch misuse of end_struct vs. end_list

2017-04-27 Thread Marc-André Lureau
On Thu, Apr 27, 2017 at 2:49 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > On Thu, Apr 27, 2017 at 12:41 PM Markus Armbruster > > wrote: > > > >> Signed-off-by: Markus Armbruster > >> > > > >

Re: [Qemu-devel] qemu integrator hardware error: icp_control_write: Bad offset 789688

2017-04-27 Thread Peter Maydell
On 27 April 2017 at 04:23, heavybird <4345...@qq.com> wrote: > Hi Peter, > > I am using your qemu integrator to debug my application but it encouters the > exception below, i have no idea to figure out the message below. could you > give me some suggestion or show me some document to get out this

Re: [Qemu-devel] [PATCH 25/41] migration: Export rdma.c functions in its own file

2017-04-27 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 4 > migration/migration.c | 1 + > migration/rdma.c | 1 + > migration/rdma.h | 22 ++ > 4 files

[Qemu-devel] [PATCH v5 00/19] TCG cross-tb optimizations

2017-04-27 Thread Richard Henderson
Changes since Emilio's v4: * Fold tcg/i386 exit_tb 0 to the epilogue we created for goto_ptr. * Drop gen_jr in favor of DISAS_EXIT for target/arm. * Backend support for ppc, aarch64, sparc, s390. * Fix 3 build failures that appear on sparc v8plus (64-bit ilp32). I attempted to throw

[Qemu-devel] [PATCH v5 01/19] target/nios2: Fix 64-bit ilp32 compilation

2017-04-27 Thread Richard Henderson
Avoid a "cast from pointer to integer of different size" warning by using the proper host type. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c

[Qemu-devel] [PATCH v5 09/19] target/arm: optimize indirect branches

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Speed up indirect branches by jumping to the target if it is valid. Softmmu measurements (see later commit for user-mode results): Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0. - Impact on Boot time | setup | ARM debian jessie boot+shutdown time

[Qemu-devel] [PATCH v5 05/19] tcg-runtime: add lookup_tb_ptr helper

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" This paves the way for upcoming work. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-3-git-send-email-c...@braap.org>

[Qemu-devel] [PATCH v5 12/19] target/i386: optimize indirect branches

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Speed up indirect branches by jumping to the target if it is valid. Softmmu measurements (see later commit for user-mode numbers): Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0. - SPECint06 (test set), x86_64-softmmu (Ubuntu 16.04

[Qemu-devel] [PATCH v5 19/19] tcg/s390: Implement goto_ptr

2017-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 2 +- tcg/s390/tcg-target.inc.c | 24 +--- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.h index 6b7bcfb..957f0c0 100644 ---

[Qemu-devel] [PATCH v5 06/19] tcg: introduce goto_ptr opcode

2017-04-27 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-4-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 + tcg/arm/tcg-target.h | 1 + tcg/i386/tcg-target.h|

Re: [Qemu-devel] [PATCH 10/41] migration: Move postcopy-ram.h to migration/

2017-04-27 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It is internal to migration, not intended for other users. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > migration/postcopy-ram.c| 2 +- >

Re: [Qemu-devel] [PATCH v3 06/10] target/arm: optimize indirect branches

2017-04-27 Thread Aurelien Jarno
On 2017-04-26 23:20, Emilio G. Cota wrote: > On Wed, Apr 26, 2017 at 09:54:07 +0200, Richard Henderson wrote: > > On 04/26/2017 08:23 AM, Emilio G. Cota wrote: > > >+static bool gen_jr;... > > > case DISAS_JUMP: > > >+if (gen_jr) { > > > > Why the variable? Why not just try

Re: [Qemu-devel] [PATCH v15 21/21] qemu-iotests: Add test case 153 for image locking

2017-04-27 Thread Fam Zheng
On Thu, 04/27 11:05, Kevin Wolf wrote: > Am 27.04.2017 um 03:32 hat Fam Zheng geschrieben: > > On Wed, 04/26 16:49, Kevin Wolf wrote: > > > Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > > > > Signed-off-by: Fam Zheng > > > > > > I'll do the actual review of the test case

Re: [Qemu-devel] [RFC PATCH 12/20] Memory: Add func to fire pasidt_bind notifier

2017-04-27 Thread Liu, Yi L
On Thu, Apr 27, 2017 at 02:14:27PM +0800, Peter Xu wrote: > On Thu, Apr 27, 2017 at 10:37:19AM +0800, Liu, Yi L wrote: > > On Wed, Apr 26, 2017 at 03:50:16PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 26/04/2017 12:06, Liu, Yi L wrote: > > > > +void

Re: [Qemu-devel] [RFC PATCH 03/20] intel_iommu: add "svm" option

2017-04-27 Thread Peter Xu
On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote: > Expose "Shared Virtual Memory" to guest by using "svm" option. > Also use "svm" to expose SVM related capabilities to guest. > e.g. "-device intel-iommu, svm=on" > > Signed-off-by: Liu, Yi L > --- >

Re: [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors

2017-04-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors Message-id: 149328633283.30266.4224847428546759127.stgit@bahia Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 2/2] ramblock: add new hmp command "info ramblock"

2017-04-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > To dump information about ramblocks. It looks like: > > (qemu) info ramblock > Block NamePSize Offset Used > Total > /objects/mem 2M 0x 0x8000 >

Re: [Qemu-devel] [PATCH 4/4] qobject-input-visitor: Catch misuse of end_struct vs. end_list

2017-04-27 Thread Markus Armbruster
Marc-André Lureau writes: > On Thu, Apr 27, 2017 at 2:49 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > On Thu, Apr 27, 2017 at 12:41 PM Markus Armbruster >> > wrote: >> > >> >>

Re: [Qemu-devel] [PATCH 01/41] migration: Create migration/blocker.h

2017-04-27 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This allows us to remove lots of includes of migration/migration.h > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert if you need to regenerate it, I think the xvzrle.h move is out of

Re: [Qemu-devel] [PATCH 00/41] Migration cleanup

2017-04-27 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: High level question: A lot of this is splitting migration.h which is a GPLv2 licensed file, and you're carefully copying the authorship (Anthony) to each new header file and also the license. Can we fix the license while we're at it? The

Re: [Qemu-devel] [PATCH] io: simplify qio_channel_attach_aio_context

2017-04-27 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] io: simplify qio_channel_attach_aio_context Message-id:

[Qemu-devel] [PATCH v5 18/19] tcg/sparc: Implement goto_ptr

2017-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.h | 2 +- tcg/sparc/tcg-target.inc.c | 11 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h index 9348ddd..854a0af 100644 ---

[Qemu-devel] [PATCH v5 14/19] target/alpha: Use tcg_gen_goto_ptr

2017-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/translate.c | 49 +++- 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index df5d695..c1a5fbf 100644 ---

Re: [Qemu-devel] [RFC PATCH 5/8] VFIO: Add new IOTCL for PASID Table bind propagation

2017-04-27 Thread Liu, Yi L
On Wed, Apr 26, 2017 at 05:56:50PM +0100, Jean-Philippe Brucker wrote: > On 26/04/17 11:12, Liu, Yi L wrote: > > From: "Liu, Yi L" > > > > This patch adds VFIO_IOMMU_SVM_BIND_TASK for potential PASID table > > binding requests. > > > > On VT-d, this IOCTL cmd would be

[Qemu-devel] [PATCH 0/2] ppc/xics: preserve P and Q bits for KVM IRQs

2017-04-27 Thread Sam Bobroff
Hi QEMU, As explained in the notes for the second patch, this is a change to hook up some new bits that have been added to KVM's XICS IRQs along with a small fix for a problem I noticed along the way. I tested by instrumenting the code directly, better ideas are welcome! Cheers, Sam. Sam

Re: [Qemu-devel] [RFC v5 0/4] vITS save/restore

2017-04-27 Thread Auger Eric
Hi Brahmajyosyula, On 26/04/2017 13:18, Prakash B wrote: > Verified on Cavium ThunderX platform > Continousily migrated Guest more than 500 times b/w different hosts. > Please feel free to add Tested-by: Prakash, Brahmajyosyula > Many thanks for your

Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"

2017-04-27 Thread Markus Armbruster
Peter Xu writes: > On Wed, Apr 26, 2017 at 02:10:16PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > To dump information about ramblocks. It looks like: >> > >> > (qemu) info ramblock >> > Block NamePSize Offset

Re: [Qemu-devel] New function: Remot USB support in qemu

2017-04-27 Thread Gerd Hoffmann
On Do, 2017-04-27 at 14:30 +0800, yuan.zh...@zte.com.cn wrote: > Mr. Hoffmann, > > > Thank you for your time. > > > This email will describe a new module that I'd like to commit to the > qemu code source. > > We call it as remote usb, and this is features: > > 1. real usb device is aside on

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages

2017-04-27 Thread Christian Borntraeger
On 04/27/2017 05:20 AM, Peter Xu wrote: > On Wed, Apr 26, 2017 at 09:37:43PM +0200, Andrea Arcangeli wrote: >> Hello, >> >> On Wed, Apr 26, 2017 at 08:04:43PM +0100, Dr. David Alan Gilbert wrote: >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: On 04/26/2017 08:37 PM, Dr. David

Re: [Qemu-devel] [RFC PATCH 1/8] iommu: Introduce bind_pasid_table API function

2017-04-27 Thread Liu, Yi L
On Wed, Apr 26, 2017 at 05:56:45PM +0100, Jean-Philippe Brucker wrote: > Hi Yi, Jacob, > > On 26/04/17 11:11, Liu, Yi L wrote: > > From: Jacob Pan > > > > Virtual IOMMU was proposed to support Shared Virtual Memory (SVM) use > > case in the guest: > >

Re: [Qemu-devel] [PATCH 6/7] sockets: Limit SocketAddressLegacy except to external interfaces

2017-04-27 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 04/26/2017 02:36 AM, Markus Armbruster wrote: >> >> I think it reads fine if you shorten the subject via s/except // > > It doesn't unless. Will fix, thanks! > >>> SocketAddressLegacy is a simple

Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"

2017-04-27 Thread Paolo Bonzini
On 27/04/2017 09:07, Markus Armbruster wrote: > Example for "makes no sense in QMP": setting the current CPU[1], because > a QMP monitor doesn't have a current CPU. > > Examples for "is of use only for human users": HMP command "help", the > integrated pocket calculator[2]. This example is

Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"

2017-04-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/04/2017 09:07, Markus Armbruster wrote: >> Example for "makes no sense in QMP": setting the current CPU[1], because >> a QMP monitor doesn't have a current CPU. >> >> Examples for "is of use only for human users": HMP command "help", the >>

Re: [Qemu-devel] [PATCH v15 20/21] file-posix: Add image locking to perm operations

2017-04-27 Thread Fam Zheng
On Wed, 04/26 16:22, Kevin Wolf wrote: > > @@ -455,6 +473,21 @@ static int raw_open_common(BlockDriverState *bs, QDict > > *options, > > } > > s->fd = fd; > > > > +s->lock_fd = -1; > > +fd = qemu_open(filename, O_RDONLY); > > Note that with /dev/fdset there can be cases where

Re: [Qemu-devel] [RFC PATCH 12/20] Memory: Add func to fire pasidt_bind notifier

2017-04-27 Thread Peter Xu
On Thu, Apr 27, 2017 at 10:37:19AM +0800, Liu, Yi L wrote: > On Wed, Apr 26, 2017 at 03:50:16PM +0200, Paolo Bonzini wrote: > > > > > > On 26/04/2017 12:06, Liu, Yi L wrote: > > > +void memory_region_notify_iommu_svm_bind(MemoryRegion *mr, > > > + void

Re: [Qemu-devel] [PATCH v15 13/21] iotests: 091: Quit QEMU before checking image

2017-04-27 Thread Fam Zheng
On Wed, 04/26 14:34, Kevin Wolf wrote: > Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > Reviewed-by: Max Reitz > > --- > > tests/qemu-iotests/091 | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git

Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-27 Thread Ashijeet Acharya
On Thu, Apr 27, 2017 at 3:00 AM, John Snow wrote: > > > On 04/25/2017 03:59 PM, Ashijeet Acharya wrote: >> The size of the output buffer is limited to a maximum of 2MB so that >> QEMU doesn't end up allocating huge amounts of memory while >> decompressing compressed input

  1   2   3   >