On 05/06/2017 10:24 AM, Paolo Bonzini wrote:
>
>
> On 05/05/2017 18:12, Eric Farman wrote:
>>
>>
>> On 05/05/2017 11:13 AM, Paolo Bonzini wrote:
>>>
>>>
>>> On 05/05/2017 17:03, Eric Farman wrote:
We get a value of x3f when sending that to a scsi-disk from bios
code. That's fully e
On 08/05/2017 08:13, David Gibson wrote:
>>
>> Please start including Docker-based tests in your pre-pull-request
>> tests.
> Um.. is there some doco on how to execute these. I tried "make
> docker-test" and "make docker-image" and they both just seem to hang
> at:
>
> umbus:~/src/qemu (p
Hi
Please, send any topic that you are interested in covering.
At the end of Monday I will send an email with the agenda or the
cancellation of the call, so hurry up.
After discussions on the QEMU Summit, we are going to have always open a
KVM call where you can add topics.
Call details:
B
On Mon, May 08, 2017 at 04:07:44PM +1000, David Gibson wrote:
> On Mon, May 08, 2017 at 01:48:14PM +0800, Peter Xu wrote:
> > On Mon, May 01, 2017 at 02:58:22PM +1000, David Gibson wrote:
> > > On Thu, Apr 27, 2017 at 05:34:18PM +0800, Peter Xu wrote:
> > > > This is something similar to MemoryRegi
Replace malloc/free with g_malloc/g_free to get a program exit on
out of memory.
Replace g_malloc with g_new when allocating the MemoryRegion to
get more type safety.
Reported by Coverity.
Cc: Max Filippov
Cc: qemu-triv...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/xtensa/sim.c | 6 +++---
On Mon, May 08, 2017 at 12:09:42PM +0800, Xiao Guangrong wrote:
>
> Hi Liu Yi,
>
> I haven't started to read the code yet, however, could you
> detail more please? It emulates a SVM capable iommu device in
> a VM? Or It speeds up device's DMA access in a VM? Or it is a
> new facility introduced f
On Wed, May 03, 2017 at 02:57:18PM +0200, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: David Gibson
> ---
> tests/numa-test.c | 151
> ++
> 1 file changed, 151 insertions(+)
>
> diff --git a/tests/numa-test.c b/tests/num
On 08.05.2017 06:22, Carl Karsten wrote:
> neat. missed that.
>
> except it doesn't work.
>
> juser@gator:~/temp$ qemu-system-x86_64 -drive
> file=boot.img,format=raw,bootindex=1
> qemu-system-x86_64: -drive file=boot.img,format=raw,bootindex=1: Block
> format 'raw' does not support the option '
Public bug reported:
Steps to reproduce the issue:
1. Download the ovf from this place:
https://bintray.com/vmware/photon/download_file?file_path=photon-custom-hw10-1.0-62c543d.ova
2. Extract vmdk from ova file.
3. Convert from vmdk fromat to qcow2 via qeum-img
4. Launch the qcow2 image. The VM is
* ali saeedi (ali.saeed...@gmail.com) wrote:
> Hi
> what are 'blk' and 'shared' boolean variables in MigrationParams structure
> in migration.h?
Follow the code! They're the flags used in the migrate command when
doing block migration.
Dave
> thanks a lot
--
Dr. David Alan Gilbert / dgilb...@red
* ali saeedi (ali.saeed...@gmail.com) wrote:
> Hi
> what is the difference between functions "qemu_savevm_state_begin" and
> "qemu_savevm_state_header" in migration_thread?
qemu_savevm_state_header just saves the file header.
qemu_savevm_state_begin iterates through the list of devices
calling th
"Daniel P. Berrange" writes:
> On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote:
>> On Tue, May 02, 2017 at 01:54:22PM +0200, Thomas Huth wrote:
>> > '-no-kvm' was just a legacy convenience option for the users of
>> > qemu-kvm, it never made sense in the normal QEMU tree since TCG
* ali saeedi (ali.saeed...@gmail.com) wrote:
> what does "vmstate_save_state(f, &vmstate_configuration, &savevm_state, 0)"
> function call do in "qemu_savevm_state_header" function in savevm.c at line
> 968 ?
> why has "savevm_state" been passed to this function?
> thanks a lot
vmstate_save_state
Carl Karsten writes:
> juser@gator:~/temp$ qemu-system-x86_64 -m 256 -display curses -drive
> file=disk.cow -drive file=boot.img
> WARNING: Image format was not specified for 'boot.img' and probing guessed
> raw.
> Automatically detecting the format is dangerous for raw images,
> write
On Sun, May 7, 2017 at 4:26 PM, Doug Gale wrote:
> On Fri, May 5, 2017 at 10:45 AM, Stefan Hajnoczi wrote:
>> On Tue, May 02, 2017 at 10:32:40AM -0400, Doug Gale wrote:
>>> +} else {
>>> +/* decode repeat length */
>>> +int repeat = (unsigned char)ch -
On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote:
> On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey Perevalov wrote:
> > On 04/28/2017 01:00 PM, Peter Xu wrote:
> > >On Fri, Apr 28, 2017 at 09:57:37AM +0300, Alexey Perevalov wrote:
> > >>This patch provides downtime calculation per vCPU,
>
On Mon, 8 May 2017 13:29:27 +0800
Dong Jia Shi wrote:
> * Cornelia Huck [2017-05-05 14:20:14 +0200]:
>
> > On Fri, 5 May 2017 04:03:52 +0200
> > Dong Jia Shi wrote:
> >
> > > Add Cornelia Huck as the vfio-ccw maintainer.
> > >
> > > Signed-off-by: Dong Jia Shi
> > > ---
> > > MAINTAINERS
On 08.05.2017 10:42, Markus Armbruster wrote:
> "Daniel P. Berrange" writes:
>
>> On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote:
>>> On Tue, May 02, 2017 at 01:54:22PM +0200, Thomas Huth wrote:
'-no-kvm' was just a legacy convenience option for the users of
qemu-kvm, i
On Mon, May 08, 2017 at 11:14:00AM +0200, Thomas Huth wrote:
> On 08.05.2017 10:42, Markus Armbruster wrote:
> > "Daniel P. Berrange" writes:
> >
> >> On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote:
> >>> On Tue, May 02, 2017 at 01:54:22PM +0200, Thomas Huth wrote:
> '-no-kv
The flags used in h_register_process_table hcall are needed in spapr.c
and hence move them to a header file. While doing so, give them
slightly specific names.
Signed-off-by: Bharata B Rao
---
hw/ppc/spapr_hcall.c | 31 ++-
include/hw/ppc/spapr.h | 10 ++
2
Currently HTAB savevm handlers get registered by default and migration
of radix guest will fail.
- Ensure that HTAB savevm handlers are not registered for radix case.
- Ensure that we issue KVM_PPC_CONFIGURE_V3_MMU for radix case post
migration.
TODO: Right now I have delayed the HTAB savevm ha
On Fr, 2017-05-05 at 15:42 +0200, Philippe Voinov wrote:
> This depends on:
> [PATCH] ui: Support non-zero minimum values for absolute input axes
Better send patches as patch series then (next time).
Added patches to input patch queue.
thanks,
Gerd
On Mon, May 08, 2017 at 03:32:17PM +0800, Peter Xu wrote:
> On Mon, May 08, 2017 at 04:07:44PM +1000, David Gibson wrote:
> > On Mon, May 08, 2017 at 01:48:14PM +0800, Peter Xu wrote:
> > > On Mon, May 01, 2017 at 02:58:22PM +1000, David Gibson wrote:
> > > > On Thu, Apr 27, 2017 at 05:34:18PM +080
On 08.05.2017 11:40, Daniel P. Berrange wrote:
> On Mon, May 08, 2017 at 11:14:00AM +0200, Thomas Huth wrote:
>> On 08.05.2017 10:42, Markus Armbruster wrote:
>>> "Daniel P. Berrange" writes:
>>>
On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote:
> On Tue, May 02, 2017 at 01
Migrating radix guests fails with the following error on the target
side:
qemu-system-ppc64: htab_load() bad index 2113929216 (5378+0 entries) in htab
stream (htab_shift=0)
qemu-system-ppc64: error while loading state for instance 0x0 of device
'spapr/htab'
qemu-system-ppc64: load of migration f
Hi,
With ppc-for-2.10 branch of dwg's tree, starting a radix guest is currently
causing a host kernel oops like this:
Unable to handle kernel paging request for data at address 0xe64bb17da64ab078
Faulting instruction address: 0xc02c3ddc
Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR
On Thu, 27 Apr 2017 18:53:17 +0800
Peter Xu wrote:
> On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote:
> > Expose "Shared Virtual Memory" to guest by using "svm" option.
> > Also use "svm" to expose SVM related capabilities to guest.
> > e.g. "-device intel-iommu, svm=on"
> >
> > Signed-
I try this steps and meet the similar issue:
1. Deploy a VM in ESXi from
https://bintray.com/vmware/photon/download_file?file_path=photon-custom-hw10-1.0-62c543d.ova
2. Copy vmdk and flat.vmdk file
3. Convert from vmdk format to raw via qeum-img(qemu-img convert -f vmdk -O raw
Photon.vmdk Photon.
On Mon, 8 May 2017 13:18:22 +0800
Dong Jia Shi wrote:
> * Cornelia Huck [2017-05-05 14:11:53 +0200]:
>
> > On Fri, 5 May 2017 04:03:44 +0200
> > Dong Jia Shi wrote:
> > > -SubchDev *css_create_virtual_sch(CssDevId bus_id, Error **errp)
> > > +SubchDev *css_create_sch(CssDevId bus_id, bool is
On Fri, 5 May 2017 17:36:20 -0300
Eduardo Habkost wrote:
> Fixup will be included in v3, or can be applied by maintainer:
>
> Signed-off-by: Eduardo Habkost
> ---
> hw/core/sysbus.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/core/sysbus.c b/hw/core/sys
Philippe Mathieu-Daudé writes:
> remove this noise:
>
> perl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
> LANGUAGE = (unset),
> LC_ALL = "en_US.UTF-8",
> LC_CTYPE = "en_US.UTF-8",
> LANG = "en_US.UTF-8"
> are supported and instal
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .shippable.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.shippable.yml b/.shippable.yml
> index 231c29b620..5170486ff9 100644
> --- a/.shippable.yml
> +++ b/.shippable.yml
> @@ -20,4
On Fri, May 05, 2017 at 02:59:24PM -0300, Eduardo Habkost wrote:
> On Thu, May 04, 2017 at 12:16:38PM +0200, Kashyap Chamarthy wrote:
> > On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote:
> >
> > Hi,
> >
> > Yet to try this series, a small question in-line.
> >
> > > Introduce a n
Philippe Mathieu-Daudé writes:
> shippable logs:
> --
> git_sync
> - ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone
> https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu'
> Identity added: /tmp/ssh/01_deploy (rsa w/o comment)
> Cloning into '/root/src/githu
On 02.03.2017 03:41, Richard Henderson wrote:
> Herein find my 3 year old STFLE patch, two of the patches that were
> posted this week for LPP and LPD, and three patches to convert the
> atomic operations in the s390 frontend to actually be atomic.
Hi Richard,
since the STFLE (and the other patc
Philippe Mathieu-Daudé writes:
> - install common/basic tools at once
> - one-line Emdebian setup
> - use eatmydata and remove apt cache to save space
> - add bison and flex and git
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/dockerfiles/debian.docker | 22 --
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .shippable.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.shippable.yml b/.shippable.yml
> index b661e667b3..fa2d6a4e9b 100644
> --- a/.shippable.yml
> +++ b/.shippable.yml
> @@ -13,6 +13,8 @@ env:
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/Makefile.include | 3 ++-
> tests/docker/docker.py| 5 +
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> in
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/Makefile.include | 2 ++
> tests/docker/dockerfiles/debian-apt-fake.sh | 46
> +
> tests/docker/dockerfiles/debian.docker | 2 ++
> 3 files changed, 50
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/dockerfiles/debian-mipsel-cross.docker | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/debian-mipsel-cross.docker
> b/tests/docker/dockerfiles/debian-mipsel-cro
Philippe Mathieu-Daudé writes:
> do it in the 'ci' target when needed.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .shippable.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.shippable.yml b/.shippable.yml
> index fa2d6a4e9b..b3cbca458c 100644
> --- a/.shippable.yml
> +++
Philippe Mathieu-Daudé writes:
> shippable output:
>
> LINKmips64el-softmmu/qemu-system-mips64el
> ../hw/core/loader-fit.o: In function `load_fit':
> /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:278: undefined
> reference to `fdt_first_subnode'
> /root/src/github
On 05.05.2017 13:54, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> The preferred way of adding USB devices is via "-device" and
>> "device_add" nowadays, so let's start to get rid of "-usbdevice"
>> and "usb_add" in the documentation. While we're at it, also
>> add the new USB devices there
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/dockerfiles/debian-powerpc-cross.docker | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/debian-powerpc-cross.docker
> b/tests/docker/dockerfiles/debian-powerpc-
On Mon, May 08, 2017 at 10:38:09AM +, Liu, Yi L wrote:
> On Thu, 27 Apr 2017 18:53:17 +0800
> Peter Xu wrote:
>
> > On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote:
> > > Expose "Shared Virtual Memory" to guest by using "svm" option.
> > > Also use "svm" to expose SVM related capabi
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a1d2b3a4d3..9251f575d8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1833,6 +1833,7 @@ F: .travis.yml
>
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9251f575d8..c7520b76db 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1827,6 +1827,7 @@ Build and test aut
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .shippable.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.shippable.yml b/.shippable.yml
> index 6601243060..7e714991f9 100644
> --- a/.shippable.yml
> +++ b/.shippable.yml
> @@ -15,
Kamil Rytarowski writes:
> NetBSD ships with traditional BSD curses with compatibility with ncurses.
> qemu works nicely with the basesystem version of curses(3) from NetBSD.
>
> The only mismatch between curses(3) and ncurses is the lack of
> curses_version() in the NetBSD version. This functio
We can support stateless crypto request now.
The stateless cipher request componet is:
header + key + iv + src_data + dst_data
and The algorithm chainning stateless request
component is:
header + key + auth_key + iv + aad + src_data +
dst_data + hash_result
Signed-off-by: Gonglei
---
backends
Update the header based on the newset virtio
crypto spec, so that the virtio crypto can
support both session and stateless based
crypto services and keep compatibility with
the pre-existing code by introducing five feature bits.
Signed-off-by: Gonglei
---
include/standard-headers/linux/virtio_cr
We enable all feature bits acquiescently.
Signed-off-by: Gonglei
---
hw/virtio/virtio-crypto.c | 15 +++
include/hw/virtio/virtio-crypto.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c
index 5422f25..3dc0ff2 1006
So that the new function can be used by both seesion creation
and the following stateless crypto operation.
Signed-off-by: Gonglei
---
backends/cryptodev-builtin.c | 100 +--
1 file changed, 58 insertions(+), 42 deletions(-)
diff --git a/backends/cryptode
According to the new spec, we should use different
requst structure to store the data request based
on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit is
negotiated or not.
In this patch, we havn't supported stateless mode
yet. The device reportes an error if both
VIRTIO_CRYPTO_F_MUX_MODE and VIRTIO_
At this point, the stateless crypto operation for
cryptodev-builtin backend works.
Signed-off-by: Gonglei
---
backends/cryptodev-builtin.c | 71 +++-
1 file changed, 70 insertions(+), 1 deletion(-)
diff --git a/backends/cryptodev-builtin.c b/backends/cryp
In session mode, the process of create/close a session
makes we have a least one full round-trip cost from guest to host to guest
to be able to send any data for symmetric algorithms. It gets ourself into
synchronization troubles in some scenarios like a web server handling lots
of small requests w
We need the op_code to identify which of crypto
operations for stateless crypto operation.
Let's add it.
Signed-off-by: Gonglei
---
backends/cryptodev-builtin.c | 7 +++
include/sysemu/cryptodev.h | 3 +++
2 files changed, 10 insertions(+)
diff --git a/backends/cryptodev-builtin.c b/back
Because the current qtest framework do not support virtio-1
or latter devices. For experimental purpose,
let's emulate the virtio crypto device as a legacy virtio
device by default. Using 0x1014 as virtio crypto pci device ID
because virtio crypto ID is 20 (0x14).
Signed-off-by: Gonglei
virtio-c
On 05/08/2017 04:35 AM, Paolo Bonzini wrote:
Replace malloc/free with g_malloc/g_free to get a program exit on
out of memory.
Replace g_malloc with g_new when allocating the MemoryRegion to
get more type safety.
Reported by Coverity.
Cc: Max Filippov
Cc: qemu-triv...@nongnu.org
Signed-off-by:
Because a stateless crypto request include all
information about one crypto operation, we should
introduce a wrapper for it, and add a new crypto
operation callback to do statless crypto operation.
Signed-off-by: Gonglei
---
backends/cryptodev-builtin.c | 10 ++
backends/cryptodev.c
Triaging old bug tickets ... can you still reproduce this problem with
the latest version of QEMU (currently v2.9.0)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.l
Hi Alex,
On 05/08/2017 07:58 AM, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
shippable logs:
--
git_sync
- ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone
https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu'
Identity added: /tmp/ssh/01_deploy (rsa
Triaging old bug tickets ... can you still reproduce this problem with
the latest version of QEMU (currently v2.9.0)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.l
Right, only GETLINE_* states write to the linebuf, so line_buf_index <
1 is correct. Updated patch:
>From 2e6c45260cae60bbae446bffe43f948ab002c529 Mon Sep 17 00:00:00 2001
From: Doug Gale
Date: Mon, 1 May 2017 12:22:10 -0400
Subject: [PATCH] gdbstub: implement remote debugging protocol escapes fo
On Tue 18 Apr 2017 03:57:21 PM CEST, Stefan Hajnoczi wrote:
> The refcount metadata size calculation is inaccurate and can produce
> numbers that are too small. This is bad because we should calculate a
> conservative number - one that is guaranteed to be large enough.
>
> This patch switches the
On Tue 18 Apr 2017 03:57:25 PM CEST, Stefan Hajnoczi wrote:
> Some tests produce format-dependent output. Either the difference is
> filtered out and ignored, or the test case is format-specific so we
> don't need to worry about per-format output differences.
>
> There is a third case: the test sc
On Tue 18 Apr 2017 03:57:26 PM CEST, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
Berto
On Tue 18 Apr 2017 03:57:23 PM CEST, Stefan Hajnoczi wrote:
> Use qcow2_calc_prealloc_size() to get the required file size.
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
(I also think that I had already reviewed this one)
Berto
On 05/08/2017 07:55 AM, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.shippable.yml b/.shippable.yml
index 231c29b620..5170486ff9 100644
--- a/.shippable.yml
+++
Paolo Bonzini writes:
> Replace malloc/free with g_malloc/g_free to get a program exit on
> out of memory.
>
> Replace g_malloc with g_new when allocating the MemoryRegion to
> get more type safety.
>
> Reported by Coverity.
>
> Cc: Max Filippov
> Cc: qemu-triv...@nongnu.org
> Signed-off-by: Pa
Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging
I applied this patch manually because it was not formatted according
to the patch submission guidelines. Please take note of them for
future contributions:
1. "Send each new revision as a new top-level thread, r
From: "Daniel P. Berrange"
The UST trace backend can only cope with upto 10 arguments. To ensure we
don't exceed the limit when UST is not compiled in, disallow more than
10 arguments upfront.
This prevents the case where:
commit 0fc8aec7de64f2bf83a274a2a38b938ce03425d2
Author: Zhang Chen
The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d:
Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request' into
staging (2017-05-05 17:07:55 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-request
for
On Mon, May 08, 2017 at 09:39:07AM -0400, Stefan Hajnoczi wrote:
> The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d:
>
> Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request' into
> staging (2017-05-05 17:07:55 +0100)
>
> are available in the git reposit
These are a bunch of cleanups and patches extracted from the AioContext
lock removal series. As a general theme, the patches reorganize
blockjob.c to follow the blockjob.h/blockjob_int.h separation more
closely. For this reason, a lot of the patches are just moving functions
around.
The blockjob
This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus",
2016-05-19).
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
blockjob.c | 3 ---
include/block/blockjob_int.h | 3 ---
2 files
!job is always checked prior to the call, drop it from here.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index 6e489327ff..23022b3331 100644
--- a/blockjob.c
+++ b/blockjob.c
Outside blockjob.c, block_job_unref is only used when a block job fails
to start, and block_job_ref is not used at all. The reference counting
thus is pretty well hidden. Introduce a separate function to be used
by block jobs; because block_job_ref and block_job_unref now become
static, move them
This splits the part that touches job states from the part that invokes
callbacks. It will make the code simpler to understand once job states will
be protected by a different mutex than the AioContext lock.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
blockjob.c | 35
Remove use of block_job_pause/resume from outside blockjob.c, thus
making them static. The new functions are used by the block layer,
so place them in blockjob_int.h.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-off-by: Paolo Bonzini
---
block/io.c | 19 ++
The new functions helps respecting the invariant that the coroutine
is entered with false user_resume, zero pause count and no error
recorded in the iostatus.
Resetting the iostatus is now common to all of block_job_cancel_async,
block_job_user_resume and block_job_iostatus_reset, albeit with slig
v6:
* Change bdrv_measure() return type to BlockMeasureInfo * [Eric]
* Clarify that holes in sparse POSIX files are still counted [Eric]
v5:
* Use UINT64_MAX instead of ~0ULL [Berto]
* Document qemu-img measure ofmt, fmt, output_fmt, and snapshot_param
[Berto]
v4:
* Make qcow2 refcount ca
Outside blockjob.c, the block_job_iostatus_reset function is used once
in the monitor and once in BlockBackend. When we introduce the block
job mutex, block_job_iostatus_reset's client is going to be the block
layer (for which blockjob.c will take the block job mutex) rather than
the monitor (whic
We have two different headers for block job operations, blockjob.h
and blockjob_int.h. The former contains APIs called by the monitor,
the latter contains APIs called by the block job drivers and the
block layer itself.
Keep the two APIs separate in the blockjob.c file too. This will
be useful w
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
tests/qemu-iotests/178 | 168 +++
tests/qemu-iotests/178.out.qcow2 | 278 +++
tests/qemu-iotests/178.out.raw | 146
tests/qemu-iotests/group
The refcount metadata size calculation is inaccurate and can produce
numbers that are too small. This is bad because we should calculate a
conservative number - one that is guaranteed to be large enough.
This patch switches the approach to a fixed point calculation because
the existing equation i
Yet another pure code movement patch, preparing for the next change.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
blockjob.c | 128 ++---
1 file changed, 64 insertions(+), 64 deletions(-)
diff --git a/blockjob.c b/blockjo
Unlike test-blockjob-txn, QMP releases the reference to the transaction
before the jobs finish. Thus, qemu-iotest 124 showed a failure while
working on the next patch that the unit tests did not have. Make
the test a little nastier.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-of
The measure subcommand calculates the size required by a new image file.
This can be used by users or management tools that need to allocate
space on an LVM volume, SAN LUN, etc before creating or converting an
image file.
Suggested-by: Maor Lipchuk
Signed-off-by: Stefan Hajnoczi
---
v5:
* Use
All block jobs are using block_job_defer_to_main_loop as the final
step just before the coroutine terminates. At this point,
block_job_enter should do nothing, but currently it restarts
the freed coroutine.
Now, the job->co states should probably be changed to an enum
(e.g. BEFORE_START, STARTED,
Some tests produce format-dependent output. Either the difference is
filtered out and ignored, or the test case is format-specific so we
don't need to worry about per-format output differences.
There is a third case: the test script is the same for all image formats
and the format-dependent outpu
The image creation options parsed by qcow2_create() are also needed to
implement .bdrv_measure(). Extract the parsing code, including input
validation.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 109 +++---
bdrv_measure() provides a conservative maximum for the size of a new
image. This information is handy if storage needs to be allocated (e.g.
a SAN or an LVM volume) ahead of time.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
v6:
* Change bdrv_measure() return type to BlockMea
On Tue 18 Apr 2017 03:57:24 PM CEST, Stefan Hajnoczi wrote:
> The measure subcommand calculates the size required by a new image file.
> This can be used by users or management tools that need to allocate
> space on an LVM volume, SAN LUN, etc before creating or converting an
> image file.
>
> Sugg
Maximum size calculation is trivial for the raw format: it's just the
requested image size (because there is no metadata).
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
block/raw-format.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/block/raw-
The preferred way of adding USB devices is via "-device" and
"device_add" nowadays, so let's start to get rid of "-usbdevice"
and "usb_add" in the documentation. While we're at it, also
add the new USB devices there which have been added to QEMU
during the last years, and get rid of the old "vendor
Calculating the preallocated image size will be needed to implement
.bdrv_measure(). Extract the code out into a separate function.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 134 +-
1 file changed, 76
On Wed, May 03, 2017 at 02:57:14PM +0200, Igor Mammedov wrote:
> add machine_run_board_init() wrapper that calls machine
> init for now but in follow up patches it will be used
> to run generic machine code that should run before
> machine init.
>
> Signed-off-by: Igor Mammedov
Reviewed-by: Edua
On Mon, May 8, 2017 at 3:51 AM, Markus Armbruster wrote:
> Carl Karsten writes:
>
> > juser@gator:~/temp$ qemu-system-x86_64 -m 256 -display curses -drive
> > file=disk.cow -drive file=boot.img
> > WARNING: Image format was not specified for 'boot.img' and probing
> guessed
> > raw.
> >
On 05/08/2017 12:26 AM, David Gibson wrote:
> On Fri, May 05, 2017 at 02:38:08PM -0500, Eric Blake wrote:
>> Time to wire up all the call sites that request a shutdown or
>> reset to use the enum added in the previous patch.
>>
>> It would have been less churn to keep the common case with no
>> arg
1 - 100 of 329 matches
Mail list logo
