[Qemu-devel] [PULL 2/9] target/s390x: Implement LOAD PROGRAM PARAMETER

2017-05-12 Thread Richard Henderson
From: Miroslav Benes Linux arch/s390/kernel/head(64).S uses LPP instruction if it is available in facilities list provided by stfl/stfle instruction. This is the case of newer z/System generations and their qemu definition. The description of LPP is at

[Qemu-devel] [PULL 7/9] target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK

2017-05-12 Thread Richard Henderson
From: Aurelien Jarno For that move the definition from kvm.c to cpu.h Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2017 at 04:21:58PM +0200, Maxime Coquelin wrote: > > > On 05/11/2017 08:25 PM, Michael S. Tsirkin wrote: > > On Thu, May 11, 2017 at 02:32:46PM +0200, Maxime Coquelin wrote: > > > This patch specifies and implements the master/slave communication > > > to support device IOTLB in

Re: [Qemu-devel] [PATCH v4 2/6] target/alpha: optimize cvtlq() using extract op

2017-05-12 Thread Richard Henderson
On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH] tcg: optimize gen_extr_i64_i32()

2017-05-12 Thread Philippe Mathieu-Daudé
Inspired by Richard Henderson comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg02277.html Patch applied mechanically with this coccinelle semantic patch: @@ expression lo, hi,arg; @@ -tcg_gen_extrl_i64_i32(lo, arg); -tcg_gen_extrh_i64_i32(hi, arg);

Re: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

2017-05-12 Thread Richard Henderson
On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking

2017-05-12 Thread Kamil Rytarowski
ivshmem-server makes use of the POSIX shared memory object interfaces. This library is provided on NetBSD in -lrt (POSIX Real-time Library). Add ./configure check if there is needed -lrt linking for shm_open() and if so use it. Introduce new configure generated variable LIBS_SHMLIB. This fixes

[Qemu-devel] [PATCH RESEND v6] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-05-12 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu Signed-off-by: Daniel P. Berrange ---

Re: [Qemu-devel] [RFC v1 8/9] virtio-crypto: add host feature bits support

2017-05-12 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Friday, May 12, 2017 7:22 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C); > pa...@linux.vnet.ibm.com; stefa...@redhat.com; Luonengjun; Linqiangmin; > xin.z...@intel.com; Wubin (H) > Subject: Re:

[Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

2017-05-12 Thread Kamil Rytarowski
I volunteer to review NetBSD patches. Adding myself will help to not miss some of them. Restore NetBSD as a maintained host. All patches to make qemu/pkgsrc building have been emitted to review. Signed-off-by: Kamil Rytarowski --- MAINTAINERS | 6 ++ configure | 1 + 2

[Qemu-devel] QEMU seg-fault with intermediate image streaming -- bdrv_reopen() in stream_start()

2017-05-12 Thread Kashyap Chamarthy
Reproducer -- [Disk image chain: disk1.qcow2 <- b.qcow2 <- c.qcow2] $ qemu-system-x86_64 -display none -nodefconfig -nodefaults \ -m 512 -device virtio-scsi-pci,id=scsi \ -device virtio-serial-pci \ -drive driver=qcow2,file.driver=file,file.filename=./disk1.qcow2,id=virtio0

Re: [Qemu-devel] [PATCH v3 05/15] target/sh4: fix BS_STOP exit

2017-05-12 Thread Philippe Mathieu-Daudé
On 05/10/2017 03:26 PM, Aurelien Jarno wrote: When stopping the translation because the state has changed, goto_tb should not be used as it might link TB with different flags. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Reviewed-by:

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-12 Thread Kevin O'Connor
On Fri, May 12, 2017 at 11:19:00PM +, Xu, Anthony wrote: > > SeaBIOS defaults to enabling A20 and it's a rare beast that disables > > it. One could change x86.h:set_a20 and romlayout.S:transition32 to > > only issue the outb() if the inb() indicates a change is needed. That > > would likely

Re: [Qemu-devel] [RFC PATCH v4 0/6] optimize various tcg_gen() functions using extract op

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Philippe Mathieu-Daudé wrote: > * Changes from v3 > > Tried to fix wrong previous attempt... > After getting some nice/fast pieces of advice from Coccinelle folks, I tried > to > improved the script (not much inline documentation yet although). > - correctly check if this

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-12 Thread Gonglei (Arei)
> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 12, 2017 7:02 PM > > > On 05/08/2017 01:38 PM, Gonglei wrote: > > According to the new spec, we should use different > > requst structure to store the data request based > > on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit

[Qemu-devel] [PATCH v2 0/3] script for crash-testing -device

2017-05-12 Thread Eduardo Habkost
Changes v1 -> v2: * Use a simpler method to query QEMU exit code in qemu.py * Use only qemu.py module, instead of qtest.py * New whitelist entries: * "could not find stage1 bootloader" * Segfaults when using devices: a15mpcore_priv, sb16, cs4231a, arm-gicv3 * Format "success" line using

[Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown

2017-05-12 Thread Eduardo Habkost
Keep the Popen object around to we can query its exit code later. To keep the existing 'self._popen is None' checks working, add a is_running() method, that will check if the process is still running. Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 12 +++- 1

[Qemu-devel] [PATCH v2 2/3] qemu.py: Add QEMUMachine.exitcode() method

2017-05-12 Thread Eduardo Habkost
Allow the exit code of QEMU to be queried by scripts. Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 4 1 file changed, 4 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 16934f1e02..ebe1c4b919 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py

Re: [Qemu-devel] [RFC PATCH 4/8] iommu/vt-d: Add iommu do invalidate function

2017-05-12 Thread Alex Williamson
On Wed, 26 Apr 2017 18:12:01 +0800 "Liu, Yi L" wrote: > From: Jacob Pan > > This patch adds Intel VT-d specific function to implement > iommu_do_invalidate API. > > The use case is for supporting caching structure invalidation > of assigned

[Qemu-devel] [PATCH v4 2/6] target/alpha: optimize cvtlq() using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/translate.c | 3 +-- 1 file

[Qemu-devel] [PULL 0/9] Queued s390 patches

2017-05-12 Thread Richard Henderson
://github.com/rth7680/qemu.git tags/pull-s390-20170512 for you to fetch changes up to 538fad597d898f677f81cb4daacd37e7cdc18e6e: target/s390x: implement serialization in BRANCH CONDITION (2017-05-12 15:48:41 -0700) Queued target/s390

[Qemu-devel] [PATCH v4 4/6] target/m68k: optimize bcd_flags() using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé Acked-by: Laurent Vivier

[Qemu-devel] [PULL 3/9] target/s390x: Diagnose specification exception for atomics

2017-05-12 Thread Richard Henderson
All of the interlocked access facility instructions raise a specification exception for unaligned accesses. Do this by using the (previously unused) unaligned_access hook. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH v3 4/5] target/ppc: using various functions using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
This patch is also incorrect, please see v4. On 05/12/2017 12:35 AM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target

Re: [Qemu-devel] [PATCH] tcg: optimize gen_extr_i64_i32()

2017-05-12 Thread Richard Henderson
On 05/12/2017 05:29 PM, Philippe Mathieu-Daudé wrote: Inspired by Richard Henderson comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg02277.html Patch applied mechanically with this coccinelle semantic patch: @@ expression lo, hi,arg; @@

[Qemu-devel] [PULL 9/9] target/s390x: implement serialization in BRANCH CONDITION

2017-05-12 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170509082800.10756-4-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/translate.c | 15 +++ 1 file changed, 15 insertions(+) diff

[Qemu-devel] [PULL 6/9] target/s390x: Use atomic operations for LOAD AND OP

2017-05-12 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 20 ++-- target/s390x/translate.c | 78 +- 2 files changed, 60 insertions(+), 38 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 5/5] target/sparc: optimize various functions using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
This patch is incorrect, please see v4. On 05/12/2017 12:35 AM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target

Re: [Qemu-devel] [RFC PATCH 3/8] iommu: Introduce iommu do invalidate API function

2017-05-12 Thread Alex Williamson
On Wed, 26 Apr 2017 18:12:00 +0800 "Liu, Yi L" wrote: > From: "Liu, Yi L" > > When a SVM capable device is assigned to a guest, the first level page > tables are owned by the guest and the guest PASID table pointer is > linked to the device context

Re: [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function

2017-05-12 Thread Alex Williamson
On Wed, 26 Apr 2017 18:11:59 +0800 "Liu, Yi L" wrote: > From: Jacob Pan > > Add Intel VT-d ops to the generic iommu_bind_pasid_table API > functions. > > The primary use case is for direct assignment of SVM capable > device. Originated from

Re: [Qemu-devel] [PATCH v3 09/15] target/sh4: optimize gen_store_fpr64

2017-05-12 Thread Richard Henderson
On 05/10/2017 11:26 AM, Aurelien Jarno wrote: Using extr and avoiding intermediate temps. Signed-off-by: Aurelien Jarno --- target/sh4/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] multiple -append?

2017-05-12 Thread Laszlo Ersek
On 05/12/17 16:20, Rob Landley wrote: > When I feed a second -append to qemu-system-i386 they don't get > concatenated, the second replaces the first. Why is it called "append" then? This behavior dates back to commit a20dd508aa38 ("simplified invocation - added automatic IDE disk geometry

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-12 Thread Xu, Anthony
wrote: > > On 12/05/2017 20:55, Xu, Anthony wrote: > > > If that's the case, QEMU/TCG should work with SeaBios even with > ignoring A20. > > > > > > During SeaBios boot, there are >350 port 92 access, if we don't need to > handle A20, > > > we can make A20 configurable in Seabios, It may reduce

[Qemu-devel] [RFC PATCH v4 0/6] optimize various tcg_gen() functions using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
* Changes from v3 Tried to fix wrong previous attempt... After getting some nice/fast pieces of advice from Coccinelle folks, I tried to improved the script (not much inline documentation yet although). - correctly check if this optimizable? - document as Mersenne number instead of prime (Eric

[Qemu-devel] [PATCH 3/3] target/xtensa: support output to chardev console

2017-05-12 Thread Max Filippov
In semihosting mode QEMU allows guest to read and write host file descriptors directly, including descriptors 0..2, a.k.a. stdin, stdout and stderr. Sometimes it's desirable to have semihosting console controlled by -serial option, e.g. to connect it to network. Add semihosting console to

[Qemu-devel] [RFC PATCH v4 1/6] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread Philippe Mathieu-Daudé
If you have coccinelle installed you can apply this script using: $ spatch \ --macro-file scripts/cocci-macro-file.h \ --dir target --in-place You can also use directly Peter Senna Tschudin docker image (easier): $ docker run -v `pwd`:`pwd` -w `pwd` petersenna/coccinelle

[Qemu-devel] [PATCH v4 5/6] target/ppc: optimize various functions using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/translate.c | 21

Re: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
On 05/12/2017 01:50 PM, Richard Henderson wrote: On 05/11/2017 08:35 PM, Philippe Mathieu-Daudé wrote: -tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); -tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0x); +tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0x); So your new script didn't work then? This

[Qemu-devel] [PULL 8/9] target/s390x: fix SIGNAL PROCESSOR return value

2017-05-12 Thread Richard Henderson
From: Aurelien Jarno The SIGNAL PROCESSOR helper returns its value through the CC register. set_cc_static should be called just after the helper. Signed-off-by: Aurelien Jarno Message-Id: <20170509082800.10756-3-aurel...@aurel32.net> Signed-off-by:

Re: [Qemu-devel] [PATCH v4 4/6] target/m68k: optimize bcd_flags() using extract op

2017-05-12 Thread Richard Henderson
On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v4 5/6] target/ppc: optimize various functions using extract op

2017-05-12 Thread Richard Henderson
On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-12 Thread Xu, Anthony
> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Friday, May 12, 2017 5:02 PM > To: Xu, Anthony > Cc: Paolo Bonzini ; qemu-devel@nongnu.org > Subject: Re: [PATCH] target/i386: enable A20 automatically in system >

Re: [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror

2017-05-12 Thread Hailiang Zhang
Hi, On 2017/5/12 9:41, Zhang Chen wrote: We add the vnet_hdr option for filter-mirror, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0,vnet_hdr=on Is there any way to detect

Re: [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device

2017-05-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170513033316.22395-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 14/15] target/sh4: trap unaligned accesses

2017-05-12 Thread Richard Henderson
On 05/10/2017 11:26 AM, Aurelien Jarno wrote: SH4 requires that memory accesses are naturally aligned, except for the SH4-A movua.l instructions which can do unaligned loads. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno ---

Re: [Qemu-devel] [PATCH v3 15/15] target/sh4: use cpu_loop_exit_restore

2017-05-12 Thread Richard Henderson
On 05/10/2017 11:26 AM, Aurelien Jarno wrote: Use cpu_loop_exit_restore when using cpu_restore_state and cpu_loop_exit together. Signed-off-by: Aurelien Jarno --- target/sh4/op_helper.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-by:

[Qemu-devel] [PATCH 2/3] target/xtensa: fix return value of read/write simcalls

2017-05-12 Thread Max Filippov
Return value of read/write simcalls is not calculated correctly in case of operations crossing page boundary and in case of short reads/writes. Read and write simcalls should return the size of data actually read/written or -1 in case of error. Cc: qemu-sta...@nongnu.org Signed-off-by: Max

[Qemu-devel] [PATCH 0/3] target/xtensa semihosting fixes

2017-05-12 Thread Max Filippov
Hello, this series fixes two issues in xtensa semihosting read/write calls: incorrect direction flags used to map physical memory and incorrect return value for requests crossing page boundary, and allows using QEMU chardev for stdout and stderr output in semihosting mode. Max Filippov (3):

[Qemu-devel] [PATCH 1/3] target/xtensa: fix mapping direction in read/write simcalls

2017-05-12 Thread Max Filippov
Read and write simcalls map physical memory to access I/O buffers, but 'read' simcall need to map it for writing and 'write' simcall need to map it for reading, i.e. the opposite of what they do now. Fix that. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Filippov ---

[Qemu-devel] [PULL 5/9] target/s390x: Use atomic operations for COMPARE SWAP

2017-05-12 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 10 +++--- target/s390x/mem_helper.c | 40 ++ target/s390x/translate.c | 83

[Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/translate.c | 15

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-12 Thread Michael S. Tsirkin
On Sun, Apr 30, 2017 at 01:35:03PM +0800, Dongjiu Geng wrote: > This implements APEI GHES Table by passing the error cper info > to the guest via a fw_cfg_blob. After a CPER info is added, an > SEA/SEI exception will be injected into the guest OS. > > Below is the table layout, the max number of

Re: [Qemu-devel] [PATCH v3 08/15] target/sh4: fold ctx->bstate = BS_BRANCH into gen_conditional_jump

2017-05-12 Thread Philippe Mathieu-Daudé
On 05/10/2017 03:26 PM, Aurelien Jarno wrote: Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daudé --- target/sh4/translate.c | 9 +++-- 1 file changed, 3 insertions(+), 6

Re: [Qemu-devel] [PATCH v9 01/13] qcow2: Unallocate unmapped zero clusters if no backing file

2017-05-12 Thread John Snow
On 05/12/2017 12:06 PM, Max Reitz wrote: > On 2017-05-11 16:56, Eric Blake wrote: >> [revisiting this older patch version, even though the final version in >> today's pull request changed somewhat from this approach] >> >> On 04/12/2017 04:49 AM, Kevin Wolf wrote: >>> Am 11.04.2017 um 03:17 hat

[Qemu-devel] [PULL 1/9] target/s390x: Implement STORE FACILITIES LIST EXTENDED

2017-05-12 Thread Richard Henderson
At the same time, improve STORE FACILITIES LIST so that we don't hard-code the list for all cpus. Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/misc_helper.c | 59

[Qemu-devel] [PATCH v4 3/6] target/arm: optimize rev16() using extract op

2017-05-12 Thread Philippe Mathieu-Daudé
Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/arm/translate-a64.c | 6 ++ 1

[Qemu-devel] [PULL 4/9] target/s390x: Implement LOAD PAIR DISJOINT

2017-05-12 Thread Richard Henderson
From: Eric Bischoff Reviewed-by: Aurelien Jarno Signed-off-by: Eric Bischoff Message-Id: <20170228120134.7921-1-ebisch...@suse.com> [rth: Combine the two via insn->data; free the address temps.] Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-12 Thread Kamil Rytarowski
The __STDC_CONSTANT_MACROS symbol must be defined before including directly or indirectly in order to get support for macros for integer constants like INT8_C(). The vixl/globals.h headers defines __STDC_CONSTANT_MACROS and must be included before other system headers. This change fixes build

[Qemu-devel] [PATCH v2 3/3] scripts: Test script to look for -device crashes

2017-05-12 Thread Eduardo Habkost
Test code to check if we can crash QEMU using -device. It will test all accel/machine/device combinations by default, which may take a few hours (it's more than 90k test cases). There's a "-r" option that makes it test a random sample of combinations. The scripts contains a whitelist for: 1)

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

2017-05-12 Thread Thomas Huth
On 11.05.2017 17:10, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > >> On Wed, May 10, 2017 at 06:15:39PM +0200, Paolo Bonzini wrote: >>> >>> >>> On 10/05/2017 16:47, Thomas Huth wrote: > So while we can delete pc-0.12, we can't delete associated features

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/6] COLO block replication supports shared disk case

2017-05-12 Thread Hailiang Zhang
On 2017/5/12 3:17, Stefan Hajnoczi wrote: On Wed, Apr 12, 2017 at 10:05:15PM +0800, zhanghailiang wrote: COLO block replication doesn't support the shared disk case, Here we try to implement it and this is the 4th version. Please review and any commits are welcomed. Cc: Dr. David Alan Gilbert

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/4] Clean up compatibility mode handling

2017-05-12 Thread David Gibson
On Thu, May 04, 2017 at 09:22:37PM +0200, Greg Kurz wrote: > On Thu, 04 May 2017 16:32:59 +0200 > Andrea Bolognani wrote: > > > On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > > > This is a rebased and revised version of my patches revising CPU > > > compatiblity

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> Even for 6 functions, I would suggest to write out the function names in > the pattern matching code rather than using regular expressions. If the > names are explicit, then Coccinelle can do some filtering, either based on > an index made with idutils or glimpse (see the coccinelle scripts >

[Qemu-devel] [PATCH v2 10/16] vhost-pci-net: send the negotiated feature bits to the master

2017-05-12 Thread Wei Wang
The slave device actively sends the negotiated feature bits to the master. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 18 ++ hw/virtio/vhost-pci-slave.c | 22 ++ include/hw/virtio/vhost-pci-slave.h | 2 ++

Re: [Qemu-devel] [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-12 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1494578148-102868-1-git-send-email-wei.w.w...@intel.com Subject: [Qemu-devel] [PATCH v2 00/16] Vhost-pci for

Re: [Qemu-devel] [PATCH v8 2/3] utils: provide size_to_str()

2017-05-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Moving the algorithm from print_type_size() into size_to_str() so that > other component can also leverage it. With that, refactor > print_type_size(). > > The assert() in that logic is removed though, since even UINT64_MAX > would not overflow. > >

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> +print " candidate", "IS" if is_optimizable else "is NOT", > "optimizable" I suggest to increase your software development attention also for another detail here. This information display is using the channel “sys.stdout”. How do you think about to use the function “sys.stderr.write”

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-12 Thread Halil Pasic
On 05/08/2017 01:38 PM, Gonglei wrote: > According to the new spec, we should use different > requst structure to store the data request based > on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit is > negotiated or not. > > In this patch, we havn't supported stateless mode > yet. The device

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-12 Thread Maxime Coquelin
On 05/11/2017 07:33 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:43PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need to receive IOTLB entries for rings information early, but vhost-user need the same information earlier, before VHOST_USER_SET_VRING_ADDR is sent.

[Qemu-devel] [PATCH V4 7/9] migration: calculate vCPU blocktime on dst side

2017-05-12 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted

[Qemu-devel] [PATCH V4 3/9] migration: fix hardcoded function name in error report

2017-05-12 Thread Alexey Perevalov
Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index fbccc53..b6eccaf 100644 --- a/migration/postcopy-ram.c +++

[Qemu-devel] [Bug 1689003] Re: USB passthrough should not fail if SET CONFIGURATION fails

2017-05-12 Thread Manfred Härtel
The attached simple program, compiled as a library, loaded by LD_PRELOAD before starting QEMU, avoids the problem by faking success of libusb_set_configuration(), as a workaround. ** Attachment added: "usbnosetconf.c"

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-05-12 Thread Jean-Philippe Brucker
Hi Yi, On 26/04/17 11:12, Liu, Yi L wrote: > From: "Liu, Yi L" > > This patch adds VFIO_IOMMU_TLB_INVALIDATE to propagate IOMMU TLB > invalidate request from guest to host. > > In the case of SVM virtualization on VT-d, host IOMMU driver has > no knowledge of caching

[Qemu-devel] [PULL 5/6] xhci: relax link check

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek The strict td link limit added by commit "05f43d4 xhci: limit the number of link trbs we are willing to process" causes problems with Windows guests. Let's raise the limit. This change is analogous to: commit ab6b1105a2259c7072905887f71caa850ce63190

[Qemu-devel] [PULL 3/6] xhci: fix logging

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek slotid and epid were deleted from XHCITransfer in commit d6fcb29. Also deleting one unused forward declaration. Signed-off-by: Ladi Prosek Message-id: 20170511125314.24549-2-lpro...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 0/6] usb patch queue

2017-05-12 Thread Gerd Hoffmann
-0400) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20170512-1 for you to fetch changes up to aa612b364ecbe1dc034efcabb04526f24e56c145: hw/usb/dev-serial: Do not try to set vendorid or productid properties (2017-05-12 12:30:23 +0200

Re: [Qemu-devel] [PATCH v4] qemu-doc: Update to use the new way of attaching USB devices

2017-05-12 Thread Gerd Hoffmann
On Mo, 2017-05-08 at 17:13 +0200, Thomas Huth wrote: > The preferred way of adding USB devices is via "-device" and > "device_add" nowadays, so let's start to get rid of "-usbdevice" > and "usb_add" in the documentation. While we're at it, also > add the new USB devices there which have been added

[Qemu-devel] [PATCH] xhci: relax link check

2017-05-12 Thread Ladi Prosek
The strict td link limit added by commit "05f43d4 xhci: limit the number of link trbs we are willing to process" causes problems with Windows guests. Let's raise the limit. This change is analogous to: commit ab6b1105a2259c7072905887f71caa850ce63190 Author: Gerd Hoffmann

[Qemu-devel] [PATCH V4 1/9] userfault: add pid into uffd_msg & update UFFD_FEATURE_*

2017-05-12 Thread Alexey Perevalov
This commit duplicates header of "userfaultfd: provide pid in userfault msg" into linux kernel. Signed-off-by: Alexey Perevalov --- linux-headers/linux/userfaultfd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-headers/linux/userfaultfd.h

[Qemu-devel] [PULL 10/10] vnc: replace hweight_long() with ctpopl()

2017-05-12 Thread Gerd Hoffmann
From: Cédric Le Goater ctpopl() has a better implementation than hweight_long() and ui/vnc.c being the last user of hweight_long(), we can simply remove it. Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Message-id:

[Qemu-devel] [PULL 09/10] vnc: simple clean up

2017-05-12 Thread Gerd Hoffmann
From: Wei Qi It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment. Signed-off-by: Wei Qi Reviewed-by: Sahid Orentino Ferdjaoui Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 04/10] egl-helpers: drop support for gles and debug logging

2017-05-12 Thread Gerd Hoffmann
Leftover from the early opengl days. Unused now, so delete the dead code. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Message-id: 20170505104101.30589-3-kra...@redhat.com ---

[Qemu-devel] [PULL 03/10] virtio-gpu: move virtio_gpu_gl_block

2017-05-12 Thread Gerd Hoffmann
Move to virtio-gpu-3d.c where all the other virgl code lives too. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170505104101.30589-2-kra...@redhat.com --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-3d.c

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-12 Thread Paolo Bonzini
On 12/05/2017 01:55, Xu, Anthony wrote: > Hi Paolo, > > In KVM mode, seems A20 is ignored. > Do you see any potential issue here? No; recent processors don't have A20 at all. Paolo > > Anthony > > >> -Original Message- >> From: Kevin O'Connor [mailto:ke...@koconnor.net] >> Sent:

[Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-12 Thread Gerd Hoffmann
From: Thomas Huth When starting QEMU with the legacy USB serial device like this: qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio it currently aborts since the vendorid property does not exist anymore (it has been removed by commit f29783f72ea77dfbd7ea0c9):

[Qemu-devel] [PULL 1/6] qemu-doc: Update to use the new way of attaching USB devices

2017-05-12 Thread Gerd Hoffmann
From: Thomas Huth The preferred way of adding USB devices is via "-device" and "device_add" nowadays, so let's start to get rid of "-usbdevice" and "usb_add" in the documentation. While we're at it, also add the new USB devices there which have been added to QEMU during the

[Qemu-devel] [PATCH 4/4] virtio: implement VIRTIO_SCSI_F_TIMEOUT feature

2017-05-12 Thread Hannes Reinecke
Implement a handler for the VIRTIO_SCSI_F_TIMEOUT feature, which allows to pass in the assigned command timeout in seconds or minutes. This allows to specify a timeout up to 3 hours. Signed-off-by: Hannes Reinecke --- hw/scsi/virtio-scsi.c| 16

Re: [Qemu-devel] [RFC PATCH 5/8] VFIO: Add new IOTCL for PASID Table bind propagation

2017-05-12 Thread Liu, Yi L
On Wed, Apr 26, 2017 at 06:12:02PM +0800, Liu, Yi L wrote: > From: "Liu, Yi L" Hi Alex, In this patchset, I'm trying to add two new IOCTL cmd for Shared Virtual Memory virtualization. One for binding guest PASID Table and one for iommu tlb invalidation from guest. ARM

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-12 Thread Juan Quintela
Peter Xu wrote: > On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote: >> @@ -1214,9 +1218,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool >> blk, >> MigrationParams params; >> const char *p; >> >> -params.blk = has_blk && blk; >> -

Re: [Qemu-devel] [RFC v1 8/9] virtio-crypto: add host feature bits support

2017-05-12 Thread Cornelia Huck
On Fri, 12 May 2017 00:55:23 + "Gonglei (Arei)" wrote: > > > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > Sent: Thursday, May 11, 2017 11:05 PM > > Subject: Re: [RFC v1 8/9] virtio-crypto: add host feature bits support > > > > On Mon, 8 May 2017

[Qemu-devel] [PATCH V4 4/9] migration: split ufd_version_check onto receive/request features part

2017-05-12 Thread Alexey Perevalov
This modification is necessary for userfault fd features which are required to be requested from userspace. UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will be introduced in the next patch. QEMU need to use separate userfault file descriptor, due to userfault context has

[Qemu-devel] [PATCH V4 0/9] calculate blocktime for postcopy live migration

2017-05-12 Thread Alexey Perevalov
The rationale for that idea is following: vCPU could suspend during postcopy live migration until faulted page is not copied into kernel. Downtime on source side it's a value - time interval since source turn vCPU off, till destination start runnig vCPU. But that value was proper value for precopy

[Qemu-devel] [PULL 05/10] egl-helpers: fix display init for x11

2017-05-12 Thread Gerd Hoffmann
When running on gtk we need X11 platform not mesa platform. Create separate functions for mesa and x11 so we can keep the egl #ifdef mess local to egl-helpers.c Fixes: 0ea1523fb6703aa0dcd65e66b59e96fec028e60a Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PULL 08/10] opengl: add egl-headless display

2017-05-12 Thread Gerd Hoffmann
Add egl-headless user interface. It doesn't provide a real user interface, it only provides opengl support using drm render nodes. It will copy back the bits rendered by the guest using virgl back to a DisplaySurface and kick the usual display update code paths, so spice and vnc and screendump

[Qemu-devel] [PULL 01/10] ui: Support non-zero minimum values for absolute input axes

2017-05-12 Thread Gerd Hoffmann
From: Philippe Voinov This patch refactors ui/input.c to support absolute axis minimum values other than 0. All dependent calls to qemu_input_queue_abs have been updated to explicitly supply 0 as the axis minimum value. Signed-off-by: Philippe Voinov

[Qemu-devel] [PULL 2/6] usb-redir: fix stack overflow in usbredir_log_data

2017-05-12 Thread Gerd Hoffmann
Don't reinvent a broken wheel, just use the hexdump function we have. Impact: low, broken code doesn't run unless you have debug logging enabled. Reported-by: 李强 Signed-off-by: Gerd Hoffmann Message-id: 20170509110128.27261-1-kra...@redhat.com ---

[Qemu-devel] [PULL 4/6] usb-hub: clear PORT_STAT_SUSPEND on wakeup

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek The spec says: Suspend: (PORT_SUSPEND) This field indicates whether or not the device on this port is suspended. Setting this field causes the device to suspend by not propagating bus traffic downstream. This field may be reset by a request or by

[Qemu-devel] [PATCH 3/4] scsi: per-request timeouts

2017-05-12 Thread Hannes Reinecke
Add a 'timeout' value per request to allow to specify individual per-request timeouts. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 1 + hw/scsi/scsi-disk.c| 15 +++ hw/scsi/scsi-generic.c | 12 include/hw/scsi/scsi.h | 1 + 4 files

[Qemu-devel] [PATCH 2/4] scsi: use host default timeouts for SCSI commands

2017-05-12 Thread Hannes Reinecke
Instead of disabling command aborts by setting the command timeout to infinity we should be setting it to '0' per default, allowing the host to fall back to its default values. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c| 3 +-- hw/scsi/scsi-generic.c | 2 +- 2

Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: add checks for cmdline-created objects

2017-05-12 Thread Dr. David Alan Gilbert
I notice this pair of patches doesn't seem to have gone anywhere. WHile it's labelled as a monitor fix, it's all QOM stuff, so I don't think it should be going via me. Dave * Michael Roth (mdr...@linux.vnet.ibm.com) wrote: > check-qom-proplist originally added tests for verifying that >

  1   2   3   >