Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Pradeep Jagadeesh
On 5/10/2017 10:00 PM, Eric Blake wrote: On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device.

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-17 Thread Maxime Coquelin
On 05/13/2017 02:02 AM, Michael S. Tsirkin wrote: @@ -253,6 +271,31 @@ Once the source has finished migration, rings will be stopped by the source. No further update must be done before rings are restarted. +IOMMU support +- + +When the VIRTIO_F_IOMMU_PLATFORM feature has

Re: [Qemu-devel] [PATCH] xics_kvm: cache already enabled vCPU ids

2017-05-17 Thread Cédric Le Goater
On 05/17/2017 04:38 PM, Greg Kurz wrote: > Since commit a45863bda90d ("xics_kvm: Don't enable KVM_CAP_IRQ_XICS if > already enabled"), we were able to re-hotplug a vCPU that had been hot- > unplugged ealier, thanks to a boolean flag in ICPState that we set when > enabling KVM_CAP_IRQ_XICS. > >

Re: [Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-17 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-15 08:10:52) > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started. In this case the

[Qemu-devel] [PATCH 7/9] migration: Remove qemu-file.h from vmstate.h

2017-05-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- minor rearangements due to the rebase Signed-off-by: Juan Quintela --- include/hw/hw.h | 1 + include/migration/vmstate.h | 3 --- migration/block.c

[Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

2017-05-17 Thread Juan Quintela
Create an include for its exported functions. Signed-off-by: Juan Quintela --- include/migration/migration.h | 7 - migration/Makefile.objs | 2 +- migration/channel.c | 69 +++ migration/channel.h | 25

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-17 Thread Eric Blake
On 05/17/2017 10:38 AM, Juan Quintela wrote: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > > --- > > @@ -1207,6 +1242,26 @@ void qmp_migrate(const char *uri, bool has_blk, bool > blk, >

Re: [Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

2017-05-17 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > This files don't use any function from migration.h, so drop it. > > > > Signed-off-by: Juan Quintela > > Acked-by: Dr. David Alan Gilbert Oops, I

[Qemu-devel] [PATCH 1/2] exec: Create include for target_page_size()

2017-05-17 Thread Juan Quintela
That is the only function that we need from exec.c, and having to include the whole sysemu.h for this. Signed-off-by: Juan Quintela --- exec.c | 1 + include/exec/target_page.h | 20 include/sysemu/sysemu.h| 1 -

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-17 Thread Juan Quintela
Eric Blake wrote: > On 05/17/2017 10:38 AM, Juan Quintela wrote: >> We have change in the previous patch to use migration capabilities for >> it. Notice that we continue using the old command line flags from >> migrate command from the time being. Remove the set_params method

Re: [Qemu-devel] [PATCH v8 0/3] ramblock: add hmp command "info ramblock"

2017-05-17 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > v8: Queued for HMP > - patch 1: add r-b for Dave > - patch 2: use "uint64_t" for size_to_str() parameter, remove assert() > since it's useless now [Dave] > - drop patch 4 > > v7: > - patch 1: removed Dave's r-b since the patch conflicted during rebase

Re: [Qemu-devel] [Qemu-ppc] [RFC 2/2] pseries: Restore PVR negotiation logic for pre-2.9 machine types

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 16:35:47 +1000 David Gibson wrote: > "pseries" guests go through a hypervisor<->guest feature negotiation during > early boot. Part of this is finding a CPU compatibility mode which works > for both. > > In 152ef80 "pseries: Rewrite CAS PVR

Re: [Qemu-devel] [RFC PATCH] target/s390x/cpu_models: Set some additional feature bits for the "qemu" CPU

2017-05-17 Thread Aurelien Jarno
On 2017-05-17 17:35, Thomas Huth wrote: > Currently we only present the plain z900 feature bits to the guest, > but QEMU already emulates some additional features (but not all of > the next CPU generation, so we can not use the next CPU level as > default yet). Since newer Linux kernels are

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-17 Thread Michael S. Tsirkin
On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote: > > > On 05/11/2017 07:33 PM, Michael S. Tsirkin wrote: > > On Thu, May 11, 2017 at 02:32:43PM +0200, Maxime Coquelin wrote: > > > Vhost-kernel backend need to receive IOTLB entries for rings > > > information early, but vhost-user

Re: [Qemu-devel] [RFC PATCH] target/s390x/cpu_models: Set some additional feature bits for the "qemu" CPU

2017-05-17 Thread David Hildenbrand
On 17.05.2017 17:35, Thomas Huth wrote: > Currently we only present the plain z900 feature bits to the guest, > but QEMU already emulates some additional features (but not all of > the next CPU generation, so we can not use the next CPU level as > default yet). Since newer Linux kernels are

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Eric Blake
On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: >>> +#ifdef _WIN64 >>> + >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) >>> +{ >>> + return; >>> +} >>> + >>> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) >>> +{ >>> +abort(); >>> +} >>> + >>> +#endif >> >> I

[Qemu-devel] [RFC PATCH] target/s390x/cpu_models: Set some additional feature bits for the "qemu" CPU

2017-05-17 Thread Thomas Huth
Currently we only present the plain z900 feature bits to the guest, but QEMU already emulates some additional features (but not all of the next CPU generation, so we can not use the next CPU level as default yet). Since newer Linux kernels are checking the feature bits and refuse to work if a

Re: [Qemu-devel] [PATCH v2] block migration: Allow compile time disable

2017-05-17 Thread Juan Quintela
Jeff Cody wrote: > On Mon, May 15, 2017 at 03:05:29PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Many users now prefer to use drive_mirror over NBD as an >> alternative to the older migrate -b option; drive_mirror is

[Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-17 Thread Juan Quintela
Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela --- - address all Markus comments - use Markus and Eric text descriptions Signed-off-by: Juan Quintela --- hmp.c

[Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

2017-05-17 Thread Juan Quintela
This files don't use any function from migration.h, so drop it. Signed-off-by: Juan Quintela --- block/qed.c | 1 - hw/i386/pc_q35.c| 1 - hw/virtio/vhost-user.c | 1 - hw/virtio/vhost-vsock.c | 1 - hw/virtio/virtio.c | 1 - monitor.c

Re: [Qemu-devel] [Qemu-ppc] [RFC 1/2] pseries: Split CAS PVR negotiation out into a separate function

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 16:35:46 +1000 David Gibson wrote: > Guests of the qemu machine type go through a feature negotiation process > known as "client architecture support" (CAS) during early boot. This does > a number of things, one of which is finding a CPU

Re: [Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

2017-05-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This files don't use any function from migration.h, so drop it. > > Signed-off-by: Juan Quintela Acked-by: Dr. David Alan Gilbert > --- > block/qed.c | 1 - > hw/i386/pc_q35.c| 1 - >

[Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" It turns out that it's legal to create a VM with RAMBlocks that aren't a multiple of the pagesize in use; e.g. a 1025M main memory using 2M host pages. That breaks postcopy's atomic placement of pages, so disallow it. Signed-off-by: Dr. David

[Qemu-devel] [PATCH 1/2] migration: Fix non-multiple of page size migration

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Unfortunately it's legal to create a VM with a RAM size that's not a multiple of the underlying host page or huge page size. Recently I'd changed things to always send host sized pages, and that breaks if we have say a 1025MB guest on 2MB

[Qemu-devel] [PATCH 0/2] Migration+huge page fixes

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, The attached patch-pair fix migration in the case where you are using huge pages but you have a RAM size which is not a multiple of the huge page size. It's unfortunately legal so there might be VMs out there that already have it, and it

Re: [Qemu-devel] [PATCH] Memory: use memory address space for cpu-memory

2017-05-17 Thread Xu, Anthony
> > If cpu-memory address space is same as memory address space, > > use memory address space for cpu-memory address space. > > > > any memory region change causeaddress space to rebuild PhysPageMap, > > rebuilding PhysPageMap is very expensive. > > > > removing cpu-memory address space reduces

[Qemu-devel] [PATCH 2/3] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()

2017-05-17 Thread Stefan Hajnoczi
Calling aio_poll() directly may have been fine previously, but this is the future, man! The difference between an aio_poll() loop and BDRV_POLL_WHILE() is that BDRV_POLL_WHILE() releases the AioContext around aio_poll(). This allows the IOThread to run fd handlers or BHs to complete the request.

[Qemu-devel] [PATCH v2 5/6] cputlb: add trace events

2017-05-17 Thread Alex Bennée
Given the range of costs for various SoftMMU TLB operations from deferring work for the currently running vCPU to bring the whole emulated machine to a stop for synchronised updates simple counters are less useful. Instead we log events via the trace infrastructure and we can then post-process the

[Qemu-devel] [PATCH v2 1/6] scripts/replay-dump.py: replay log dumper

2017-05-17 Thread Alex Bennée
This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand. It currently understands two different log formats as the audio record/replay support was merged during since MTTCG. It was written

Re: [Qemu-devel] [PATCH v2] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-17 Thread Eric Blake
On 05/17/2017 07:40 AM, Stefan Hajnoczi wrote: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security

Re: [Qemu-devel] [PATCH] xics_kvm: cache already enabled vCPU ids

2017-05-17 Thread Laurent Vivier
On 17/05/2017 16:38, Greg Kurz wrote: > Since commit a45863bda90d ("xics_kvm: Don't enable KVM_CAP_IRQ_XICS if > already enabled"), we were able to re-hotplug a vCPU that had been hot- > unplugged ealier, thanks to a boolean flag in ICPState that we set when > enabling KVM_CAP_IRQ_XICS. > > This

[Qemu-devel] [PATCH 4/5] migration: Remove old MigrationParams

2017-05-17 Thread Juan Quintela
Not used anymore after moving block migration to use capabilities. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: zhanghailiang Reviewed-by: Peter Xu ---

[Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

2017-05-17 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the

[Qemu-devel] [PATCH 6/9] migration: Split vmstate-types.c from vmstate.c

2017-05-17 Thread Juan Quintela
Now one just has the interperter, and the other has the basic types. Once there, add copyright boilerplate. Signed-off-by: Juan Quintela -- Use GPL v2 or later. Detected by David. Signed-off-by: Juan Quintela --- migration/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-17 Thread Michael Roth
Quoting Michael Roth (2017-05-15 22:22:49) > Quoting Daniel Henrique Barboza (2017-05-15 08:10:52) > > From: Jianjun Duan > > > > In racing situations between hotplug events and migration operation, > > a rtas hotplug event could have not yet be delivered to the source

[Qemu-devel] [PATCH 3/3] migration: avoid recursive AioContext locking in save_vmstate()

2017-05-17 Thread Stefan Hajnoczi
AioContext was designed to allow nested acquire/release calls. It uses a recursive mutex so callers don't need to worry about nesting...or so we thought. BDRV_POLL_WHILE() is used to wait for block I/O requests. It releases the AioContext temporarily around aio_poll(). This gives IOThreads a

[Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread

2017-05-17 Thread Stefan Hajnoczi
The 'savevm' command hangs when -object iothread is used. See patches for details, but basically the vmstate read/write code didn't conform to the latest block layer locking rules. Stefan Hajnoczi (3): block: count bdrv_co_rw_vmstate() requests block: use BDRV_POLL_WHILE() in

[Qemu-devel] [PATCH v2 4/6] cputlb: remove tlb_flush_count

2017-05-17 Thread Alex Bennée
Flushing of the CPU TLB is no longer a simple count. The ratio of self-flushes to cross-flushes and if they need to synchronise across vCPUs has more of an impact. To correctly capture this we'll replace the simple count with trace points in a future patch. Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

2017-05-17 Thread Eric Blake
On 05/17/2017 10:38 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating

Re: [Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/

2017-05-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It is only used for migration code. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/qjson.c| 2 +- > {include/migration =>

[Qemu-devel] [PATCH 0/2] Make migration/ram.c target independent

2017-05-17 Thread Juan Quintela
Hi Only reason that ram.c is compiled by target is because it use TARGET_PAGE_BITS. As we already have a function to export TARGET_PAGE_SIZE, do the same. After this, we can make it target independent. Please, review. Later, Juan. Juan Quintela (2): exec: Create include for

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-17 Thread Juan Quintela
Eric Blake wrote: > On 05/17/2017 10:38 AM, Juan Quintela wrote: >> Create one capability for block migration and one parameter for >> incremental block migration. >> >> Signed-off-by: Juan Quintela >> >> --- >> >> @@ -1207,6 +1242,26 @@ void

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 4/6] hw/ppc/spapr.c: migrate pending_dimm_unplugs of spapr state

2017-05-17 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-12 14:54:57) > > > On 05/12/2017 03:12 AM, David Gibson wrote: > > On Fri, May 05, 2017 at 05:47:44PM -0300, Daniel Henrique Barboza wrote: > >> To allow for a DIMM unplug event to resume its work if a migration > >> occurs in the middle of it, this patch

Re: [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17

2017-05-17 Thread Stefan Hajnoczi
On Wed, May 17, 2017 at 10:39:41AM -0300, Eduardo Habkost wrote: > The following changes since commit 599c9cb641cc484876d5bb92189d09ba27bbfdfd: > > Merge remote-tracking branch 'sstabellini/tags/xen-20170516-tag' into > staging (2017-05-17 14:03:35 +0100) > > are available in the git

[Qemu-devel] [PATCH v4 0/9] Migration mini-cleanup

2017-05-17 Thread Juan Quintela
Hi Changes from v3 - dropped movement of colo*h headers they are used in other palaces in patches outside the tree - Change the license of vmstate*c files to GPL v2+ Dave noted that I was using the wrong text - page_cache.c movement was already reviewd and it has no conflicts, moved to

[Qemu-devel] [PATCH 1/9] migration: Create migration/xbzrle.h

2017-05-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/ram.c | 1 + migration/xbzrle.c| 2 +- migration/xbzrle.h| 21 + tests/test-xbzrle.c | 2 +- 5 files changed, 24

[Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/

2017-05-17 Thread Juan Quintela
It is only used for migration code. Signed-off-by: Juan Quintela --- migration/qjson.c| 2 +- {include/migration => migration}/qjson.h | 0 migration/vmstate.c | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename

Re: [Qemu-devel] [PATCH v1] target/s390x: Add support for the TEST BLOCK instruction

2017-05-17 Thread Thomas Huth
On 16.05.2017 21:06, Richard Henderson wrote: > On 05/16/2017 02:28 AM, Thomas Huth wrote: >> +void HELPER(testblock)(CPUS390XState *env, uint64_t addr) >> +{ >> +CPUState *cs = CPU(s390_env_get_cpu(env)); >> +int i; >> + >> +addr = get_address(env, 0, 0, addr) & ~0xfffULL; >> +for

[Qemu-devel] [PATCH 2/2] migration: Make savevm.c target independent

2017-05-17 Thread Juan Quintela
It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export them from exec.h Signed-off-by: Juan Quintela --- Makefile.target| 2 +- exec.c | 9 + include/exec/target_page.h | 2 ++ migration/Makefile.objs| 2 +-

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 10:28:33 -0500 Eric Blake wrote: > On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: > > >>> +#ifdef _WIN64 > >>> + > >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) > >>> +{ > >>> + return; > >>> +} > >>> + > >>> +IOThrottleList

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-17 Thread Michael S. Tsirkin
On Thu, May 11, 2017 at 02:32:46PM +0200, Maxime Coquelin wrote: > This patch specifies and implements the master/slave communication > to support device IOTLB in slave. > > The vhost_iotlb_msg structure introduced for kernel backends is > re-used, making the design close between the two

[Qemu-devel] [PATCH 1/3] block: count bdrv_co_rw_vmstate() requests

2017-05-17 Thread Stefan Hajnoczi
Call bdrv_inc/dec_in_flight() for vmstate reads/writes. This seems unnecessary at first glance because vmstate reads/writes are done synchronously while the guest is stopped. But we need the bdrv_wakeup() in bdrv_dec_in_flight() so the main loop sees request completion. Besides, it's cleaner to

[Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + include/migration/qemu-file.h | 4 migration/channel.c | 1 + migration/colo.c | 1 + migration/migration.c | 1 + migration/qemu-file-channel.c | 1 +

[Qemu-devel] [PATCH 4/9] migration: Remove migration.h from colo.h

2017-05-17 Thread Juan Quintela
migration.h is not included in any includes now. Signed-off-by: Juan Quintela --- include/migration/colo.h | 1 - migration/colo-comm.c| 3 ++- migration/colo.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/migration/colo.h

[Qemu-devel] [PATCH 8/9] migration: Remove vmstate.h from migration.h

2017-05-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- Minor rearrangements due to rebase Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 -

Re: [Qemu-devel] [PATCH] xics_kvm: cache already enabled vCPU ids

2017-05-17 Thread Laurent Vivier
On 17/05/2017 17:18, Laurent Vivier wrote: > On 17/05/2017 16:38, Greg Kurz wrote: >> Since commit a45863bda90d ("xics_kvm: Don't enable KVM_CAP_IRQ_XICS if >> already enabled"), we were able to re-hotplug a vCPU that had been hot- >> unplugged ealier, thanks to a boolean flag in ICPState that we

[Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-17 Thread Juan Quintela
We have change in the previous patch to use migration capabilities for it. Notice that we continue using the old command line flags from migrate command from the time being. Remove the set_params method as now it is empty. For savevm, one can't do a: savevm -b/-i foo but now one can do:

[Qemu-devel] [PATCH v5 0/5] Remove old MigrationParams

2017-05-17 Thread Juan Quintela
Hi changes from v4: - Address Markus review * better documentation messages (thanks) * reorganize error checking to have small data * Use g_new0 * Improve commints messages Please review. [v4] - patch 1 included again. We have a 'block' capability and a 'block_incremental' parameter

[Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter()

2017-05-17 Thread Juan Quintela
We only use it for int64 at this point, I am not able to find a way to parse an int with MiB units. Signed-off-by: Juan Quintela Reviewed-by: Markus Armbruster --- hmp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hmp.c

Re: [Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-17 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-15 08:10:52) > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started. In this case the

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-17 Thread Eric Blake
On 05/17/2017 10:38 AM, Juan Quintela wrote: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as > now it is empty. > > For savevm, one

Re: [Qemu-devel] [PATCH 08/17] qapi: update the qobject visitor to use QUInt

2017-05-17 Thread Markus Armbruster
Markus Armbruster writes: > On the subject: there is no such thing as "QUInt". I guess you mean > "uint type" (like in PATCH 06's subject). Could also say "QNUM_U64". > > Apropos subject: humor me, and start your subjects with a capital > letter, like this: > > qapi:

Re: [Qemu-devel] [PATCH v1] target/s390x: Add support for the TEST BLOCK instruction

2017-05-17 Thread David Hildenbrand
On 17.05.2017 18:05, Thomas Huth wrote: > On 16.05.2017 21:06, Richard Henderson wrote: >> On 05/16/2017 02:28 AM, Thomas Huth wrote: >>> +void HELPER(testblock)(CPUS390XState *env, uint64_t addr) >>> +{ >>> +CPUState *cs = CPU(s390_env_get_cpu(env)); >>> +int i; >>> + >>> +addr =

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Eric Blake
On 05/17/2017 11:29 AM, Greg Kurz wrote: >> >> First point: is fsdev a Linux-only feature, or can it be compiled on >> BSD? If it is Linux-only, then compiling a stub for Windows will still >> leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw >> is nice, but not the only

Re: [Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support

2017-05-17 Thread Philippe Mathieu-Daudé
On 05/17/2017 09:27 AM, Gerd Hoffmann wrote: Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- vl.c | 4 ++-- ui/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 3

[Qemu-devel] [PULL 2/3] utils: provide size_to_str()

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Moving the algorithm from print_type_size() into size_to_str() so that other component can also leverage it. With that, refactor print_type_size(). The assert() in that logic is removed though, since even UINT64_MAX would not overflow. Signed-off-by: Peter Xu

[Qemu-devel] [PULL 3/3] ramblock: add new hmp command "info ramblock"

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: Peter Xu To dump information about ramblocks. It looks like: (qemu) info ramblock Block NamePSize Offset Used Total /objects/mem2 MiB 0x 0x8000 0x8000

[Qemu-devel] [PULL 1/3] ramblock: add RAMBLOCK_FOREACH()

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: Peter Xu So that it can simplifies the iterators. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <1494562661-9063-2-git-send-email-pet...@redhat.com> Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 0/3] hmp queue

2017-05-17 Thread Dr. David Alan Gilbert (git)
it tags/pull-hmp-20170517 for you to fetch changes up to be9b23c4a539090da30b482015ee660850e8bb5f: ramblock: add new hmp command "info ramblock" (2017-05-17 17:31:16 +0100) ---

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread John Snow
On 05/17/2017 02:27 PM, Eric Blake wrote: > On 05/17/2017 01:09 PM, John Bradley via Qemu-devel wrote: >> Also available at >> >> https://www.dropbox.com/s/gwuquw0kirstw7a/0001-Add-Markus-Armbrusters-code-for-Broadcom-Perhiperals.patch?dl=0 > > This content belongs... > >> >> Following

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread Eric Blake
On 05/17/2017 01:34 PM, John Bradley wrote: > This is especial true as I meant Andrew Baumann 0xabu (Andrew Baumann) Top-posting is not nice on technical lists. > 0xabu (Andrew Baumann) > 0xabu has 3 repositories available. Follow their code on GitHub. | | Using github requires the use of

Re: [Qemu-devel] [PATCH 1/2] migration: Fix non-multiple of page size migration

2017-05-17 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Unfortunately it's legal to create a VM with a RAM size that's > not a multiple of the underlying host page or huge page size. > Recently I'd changed things to always send host

Re: [Qemu-devel] [Bug 1691379] [NEW] NetBSD evbmips64el port installation doesn't work with qemu-system-mips64el.

2017-05-17 Thread Kamil Rytarowski
On 17.05.2017 10:10, Thomas Huth wrote: > On 17.05.2017 09:52, Utkarsh Anand wrote: >> Public bug reported: >> >> I successfully installed the NetBSD evbmips64el port on gxemul but was >> unable to install it on qemu. Trying to boot it on qemu takes me to the >> 'db>' prompt. Here's the output and

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread John Bradley via Qemu-devel
This is especial true as I meant Andrew Baumann 0xabu (Andrew Baumann) | | | | || | | | || 0xabu (Andrew Baumann) 0xabu has 3 repositories available. Follow their code on GitHub. | | | |  John BradleyTel: 07896 839635Skype: flypie125 125B Grove

Re: [Qemu-devel] [PATCH 13/17] qdev: use appropriate getter/setters type

2017-05-17 Thread Markus Armbruster
Marc-André Lureau writes: > Based on underlying property type, use the appropriate getters/setters. How did you find the ones that need changing? > Signed-off-by: Marc-André Lureau > --- > hw/i386/acpi-build.c | 12 ++-- >

[Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread John Bradley via Qemu-devel
Also available at https://www.dropbox.com/s/gwuquw0kirstw7a/0001-Add-Markus-Armbrusters-code-for-Broadcom-Perhiperals.patch?dl=0 Following suggestions split my original patch up. This the largest monolithic chunk is additional BCM device support from Markus Armbruster. >From

Re: [Qemu-devel] [PATCH 1/3] block: count bdrv_co_rw_vmstate() requests

2017-05-17 Thread Eric Blake
On 05/17/2017 12:09 PM, Stefan Hajnoczi wrote: > Call bdrv_inc/dec_in_flight() for vmstate reads/writes. This seems > unnecessary at first glance because vmstate reads/writes are done > synchronously while the guest is stopped. But we need the bdrv_wakeup() > in bdrv_dec_in_flight() so the main

Re: [Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-17 Thread Philippe Mathieu-Daudé
Hi Mao, On 05/17/2017 08:12 AM, Mao Zhongyi wrote: pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: f4...@amsat.org Cc:

Re: [Qemu-devel] [PATCH v2] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-17 Thread Philippe Mathieu-Daudé
On 05/17/2017 09:40 AM, Stefan Hajnoczi wrote: The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit file so GDB either loads qemu-gdb.py automatically or prints a message informing the user how to enable them (some systems disable ./.gdbinit loading for security reasons).

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread Eric Blake
On 05/17/2017 01:09 PM, John Bradley via Qemu-devel wrote: > Also available at > > https://www.dropbox.com/s/gwuquw0kirstw7a/0001-Add-Markus-Armbrusters-code-for-Broadcom-Perhiperals.patch?dl=0 This content belongs... > > Following suggestions split my original patch up. This the largest

Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-17 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > It turns out that it's legal to create a VM with RAMBlocks that aren't > a multiple of the pagesize in use; e.g. a 1025M main memory using > 2M host pages. That breaks postcopy's

[Qemu-devel] [PULL 06/13] pc: add 2.10 machine type

2017-05-17 Thread Michael S. Tsirkin
From: Peter Xu CC: "Michael S. Tsirkin" CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost Signed-off-by: Peter Xu Reviewed-by: Eduardo Habkost

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-17 Thread Eduardo Habkost
On Wed, May 17, 2017 at 05:00:29PM -0500, Eric Blake wrote: > On 05/17/2017 04:25 PM, Eduardo Habkost wrote: > > Currently there's no way for QMP clients to get a list of device types > > that are really usable with -device. This information would be useful > > for management software and test

Re: [Qemu-devel] [PATCH 2/3] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()

2017-05-17 Thread Eric Blake
On 05/17/2017 12:09 PM, Stefan Hajnoczi wrote: > Calling aio_poll() directly may have been fine previously, but this is > the future, man! lol > The difference between an aio_poll() loop and > BDRV_POLL_WHILE() is that BDRV_POLL_WHILE() releases the AioContext > around aio_poll(). > > This

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-17 Thread Daniel Henrique Barboza
On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan In racing situations between hotplug events and migration operation, a

Re: [Qemu-devel] [PATCH 2/3] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()

2017-05-17 Thread Paolo Bonzini
> I'm surprised at how many separate hangs we actually had! Note that I have seen quite a few before, though I am not sure about the details and the reproducibility. The release/acquire was hidden behind RFifoLock contention callbacks instead of BDRV_POLL_WHILE. Paolo > > > > Signed-off-by:

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-17 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170517212547.4767-1-ehabk...@redhat.com Type: series Subject: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types === TEST SCRIPT BEGIN === #!/bin/bash # Testing

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread John Bradley via Qemu-devel
Well unfortunately Eric. I don't understand your "top posted" slang. As for his "intent", it is quite irrelevant as I have gone over the code line by line and what every he intended to do, he has succeed, as far as I can tell , in matching you standards, to such an extent that I am happy that

[Qemu-devel] [PULL 04/13] libvhost-user: fix crash when rings aren't ready

2017-05-17 Thread Michael S. Tsirkin
From: Marc-André Lureau Calling libvhost-user functions like vu_queue_get_avail_bytes() when the queue doesn't yet have addresses will result in the crashes like the following: Program received signal SIGSEGV, Segmentation fault. 0x55c414112ce4 in

[Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes

2017-05-17 Thread Michael S. Tsirkin
This includes the previous pull request which still does not appear to be in - not rebased so merging twice will not cause conflicts. Note that patch 08 makes checkpatch complain, patch 9 fixes that. The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: Merge

[Qemu-devel] [PULL 01/13] hw/acpi-defs: replace leading X with x_ in FADT field names

2017-05-17 Thread Michael S. Tsirkin
From: Ard Biesheuvel At the request of Michael, replace the leading capital X in the FADT field name Xfacs and Xdsdt with lower case x + underscore. Cc: Michael S. Tsirkin Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo

[Qemu-devel] [PULL 05/13] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-05-17 Thread Michael S. Tsirkin
From: Igor Mammedov Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) regressed migration during firmware exection time by abusing fwcfg.dma_enabled property to decide loading dma version of option rom AND by mistake disabling DMA for 2.6 and

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-17 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170517212547.4767-1-ehabk...@redhat.com Subject: [Qemu-devel] [RFC] qmp: Return 'user_creatable' &

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread Eric Blake
On 05/17/2017 04:25 PM, John Bradley wrote: > Well unfortunately Eric. I don't understand your "top posted" slang. To learn what top-posting is: http://lmgtfy.com/?q=what+is+top-posting and why we don't like it on technical lists: http://www.caliburn.nl/topposting.html Or more humorously: A:

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-17 Thread Eric Blake
On 05/17/2017 03:53 PM, John Bradley wrote: > Andrew Baumann has and others have release the code under GNU General Public > License version 2 (GPLv2), the same as QEMU that allows me to added it to > QEMU as it is under the same license, by signing it off this is what I am > certifying. See

Re: [Qemu-devel] [PULL 0/9] pci, virtio, vhost: fixes

2017-05-17 Thread Michael S. Tsirkin
On Mon, May 15, 2017 at 04:04:33PM +0300, Michael S. Tsirkin wrote: > On Mon, May 15, 2017 at 01:58:40PM +0100, Stefan Hajnoczi wrote: > > On Wed, May 10, 2017 at 10:07:58PM +0300, Michael S. Tsirkin wrote: > > > The following changes since commit > > > 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: >

[Qemu-devel] [PULL 11/13] virtio: allow broken device to notify guest

2017-05-17 Thread Michael S. Tsirkin
From: Greg Kurz According to section 2.1.2 of the virtio-1 specification: "The device SHOULD set DEVICE_NEEDS_RESET when it enters an error state that a reset is needed. If DRIVER_OK is set, after it sets DEVICE_NEEDS_RESET, the device MUST send a device configuration change

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 14:18:16 +1000 David Gibson wrote: > On Mon, May 15, 2017 at 06:11:27PM +0200, Cédric Le Goater wrote: > > >>> +int smt = kvmppc_smt_threads(); > > >>> +int nr_servers = DIV_ROUND_UP(max_cpus * smt, smp_threads); > > >> > > >> may

Re: [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread

2017-05-17 Thread Paolo Bonzini
- Original Message - > From: "Stefan Hajnoczi" > To: qemu-devel@nongnu.org > Cc: "Kevin Wolf" , "Paolo Bonzini" , > "Fam Zheng" , "Stefan > Hajnoczi" , qemu-bl...@nongnu.org > Sent:

[Qemu-devel] [PULL 03/13] hw/virtio: fix vhost user fails to startup when MQ

2017-05-17 Thread Michael S. Tsirkin
From: Zhiyong Yang Qemu2.7~2.9 and vhost user for dpdk 17.02 release work together to cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK

  1   2   3   >