[Qemu-devel] [PATCH v1] target/s390x: addressing exceptions are suppressing

We have to make the address in the old PSW point at the next instruction, as addressing exceptions are suppressing and not nullifying. I assume that there are a lot of other broken cases (as most instructions we care about are suppressing) - all trigger_pgm_exception() specifying and explicit

[Qemu-devel] [PULL 1/9] ehci: fix overflow in frame timer code

In case the frame timer doesn't run for a while due to the host being busy skipped_uframes can become big enough that UFRAME_TIMER_NS * skipped_uframes overflows. Which in turn throws off all subsequent ehci frame timer calculations. Reported-by: 李林 <8610...@163.com> Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v2 3/5] numa: make sure that all cpus in has has_node_id set if numa is enabled

On Mon, May 29, 2017 at 01:45:36PM +0200, Igor Mammedov wrote: > On Fri, 26 May 2017 13:06:30 -0300 > Eduardo Habkost wrote: > > > On Tue, May 23, 2017 at 04:38:48PM +0200, Igor Mammedov wrote: > > > It fixes/add missing _PXM object for non mapped CPU (x86) > > > and missing

Re: [Qemu-devel] [PATCH] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up

On Mon, 2017-05-22 at 14:33 +0200, Ladi Prosek wrote: > PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up, > i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not > work properly otherwise. > > Side note, since PORT_ENABLE looks similar and might appear to > have the same

[Qemu-devel] [PATCH] mirror: Drop permissions on s->target on completion

This fixes an assertion failure that was triggered by qemu-iotests 129 on some CI host, while the same test case didn't seem to fail on other hosts. Essentially the problem is that the blk_unref(s->target) in mirror_exit() doesn't necessarily mean that the BlockBackend goes away immediately. It

[Qemu-devel] [PULL 3/9] usb: Deprecate HMP commands usb_add and usb_del

From: Thomas Huth The commands 'device_add' and 'device_del' should be used nowadays instead. Signed-off-by: Thomas Huth Reviewed-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Message-id:

Re: [Qemu-devel] [PATCH] mirror: Drop permissions on s->target on completion

On 2017-05-29 14:18, Kevin Wolf wrote: > This fixes an assertion failure that was triggered by qemu-iotests 129 > on some CI host, while the same test case didn't seem to fail on other > hosts. > > Essentially the problem is that the blk_unref(s->target) in > mirror_exit() doesn't necessarily

Re: [Qemu-devel] [PATCH v3 06/18] numa: mirror cpu to node mapping in MachineState::possible_cpus

On Mon, May 29, 2017 at 03:12:45PM +0200, Igor Mammedov wrote: > On Fri, 26 May 2017 12:46:25 -0300 > Eduardo Habkost wrote: > > > On Wed, May 10, 2017 at 01:29:50PM +0200, Igor Mammedov wrote: > > [...] > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > > index

Re: [Qemu-devel] [PATCH 26/26] target/s390x: update maximum TCG model to z800

On 25.05.2017 23:05, Aurelien Jarno wrote: > Now that the extended-translation facility 2 has been fully implemented, > it's possible to emulated a most a z800 CPU with TCG. > > Signed-off-by: Aurelien Jarno > --- > target/s390x/cpu_models.c | 4 ++-- > 1 file changed, 2

Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown

Eduardo Habkost writes: > On Tue, May 23, 2017 at 04:23:08PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Keep the Popen object around to we can query its exit code later. >> > >> > To keep the existing 'self._popen is None'

Re: [Qemu-devel] [PATCH v2 5/5] numa: move numa_node from CPUState into target specific classes

On Fri, 26 May 2017 15:25:22 -0300 Eduardo Habkost wrote: > On Tue, May 23, 2017 at 04:38:50PM +0200, Igor Mammedov wrote: > > Move vcpu's assocciated numa_node field out of generic CPUState > > into inherited classes that actually care about cpu<->numa mapping, > > i.e:

[Qemu-devel] [PULL 2/9] usb: Deprecate the legacy -usbdevice option

From: Thomas Huth The '-usbdevice' option is considered as deprecated nowadays and we might want to remove these options in a future version of QEMU. So mark this options as deprecated in the documenation and print out a warning if it is used to tell the user what to use

[Qemu-devel] [PULL 8/9] usb: don't wakeup during coldplug

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1452512 Signed-off-by: Gerd Hoffmann Message-id: 20170523084635.20062-1-kra...@redhat.com --- hw/usb/core.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index 45fa00c517..241ae66b15

[Qemu-devel] [PULL 7/9] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up

From: Ladi Prosek PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up, i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not work properly otherwise. Side note, since PORT_ENABLE looks similar and might appear to have the same issue: According to

[Qemu-devel] [PULL 9/9] ehci: fix frame timer invocation.

ehci registers ehci_frame_timer as both timer and bottom half, which turned out to be a bad idea as it can be called as bottom half then while it is running as timer, and it isn't prepared to handle recursive calls. Change the timer func to just schedule the bottom half to avoid this. Fixes:

Re: [Qemu-devel] [PATCH v3 06/18] numa: mirror cpu to node mapping in MachineState::possible_cpus

On Fri, 26 May 2017 12:46:25 -0300 Eduardo Habkost wrote: > On Wed, May 10, 2017 at 01:29:50PM +0200, Igor Mammedov wrote: > [...] > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 2482c63..420c8c4 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c

Re: [Qemu-devel] [PATCH v3] kvmclock: update system_time_msr address forcibly

On Mon, May 29, 2017 at 01:49:04PM +0300, Denis Plotnikov wrote: > Do an update of system_time_msr address every time before reading > the value of tsc_timestamp from guest's kvmclock page. > > There is no other code paths which ensure that qemu has an up-to-date > value of system_time_msr. So,

Re: [Qemu-devel] [PATCH v7 20/20] docs: document encryption options for qcow, qcow2 and luks

On Thu 25 May 2017 06:38:51 PM CEST, "Daniel P. Berrange" wrote: > Expand the image format docs to cover the new options for > the qcow, qcow2 and luks disk image formats > > Signed-off-by: Daniel P. Berrange Reviewed-by: Alberto Garcia

[Qemu-devel] [PATCH v2 6/7] s390x/css: activate ChannelSubSys migration

Turn on migration for the channel subsystem for the next machine. For legacy machines we still have to do things the old way. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 5 + hw/s390x/s390-virtio-ccw.c | 9 - hw/s390x/virtio-ccw.c | 1

[Qemu-devel] [PATCH v2 1/7] s390x: vmstatify config migration for virtio-ccw

Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibility (extending using subsections) and for fun. To achieve this we need to hack the config_vector, which is VirtIODevice (that is common virtio) state, in the middle of the VirtioCcwDevice state representation. This

[Qemu-devel] [PATCH v2 2/7] s390x: add helper get_machine_class

We will need the machine class at machine initialization time, so the usual way via qdev won't do. Let's cache the machine class and also use the default values of the base machine for capability discovery. Signed-off-by: Halil Pasic --- hw/s390x/s390-virtio-ccw.c | 46

[Qemu-devel] [PATCH v2 4/7] s390x/css: add missing css state conditionally

Although we have recently vmstatified the migration of some css infrastructure, for some css entities there is still state to be migrated left, because the focus was keeping migration stream compatibility (that is basically everything as-is). Let us add vmstate helpers and extend existing

Re: [Qemu-devel] [PATCH v2 4/5] numa: fallback to default NUMA node instead of node 0

On Fri, 26 May 2017 11:58:14 -0300 Eduardo Habkost wrote: > On Tue, May 23, 2017 at 05:44:03PM +0200, Igor Mammedov wrote: > > On Tue, 23 May 2017 11:48:54 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, May 23, 2017 at 04:38:49PM +0200, Igor

Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

Peter Xu writes: > On Mon, May 29, 2017 at 11:42:35AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Mon, May 15, 2017 at 09:14:33PM +0800, Peter Xu wrote: >> >> MSI should be supported by all interrupt controllers. Switching the old >> >>

Re: [Qemu-devel] [PATCH] Improve Cocoa modifier key handling

On Fri, 2017-05-26 at 16:38 -0700, Ian McKellar wrote: > I had two problems with QEMU on macOS: >  1) Sometimes when alt-tabbing to QEMU it would act as if the 'a' key > was pressed so I'd get 'a'. >  2) Using Sikuli to programatically send keys to the QEMU window text > like

Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state

On Thu, 2017-05-25 at 12:50 +, Marc-André Lureau wrote: > > > On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma > wrote: > > Although the Qemu and spice flags currently have the same value, it > > seems more correct to pass the spice flag values to > >

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

On Fri, 26 May 2017 13:59:09 + Marc-André Lureau wrote: > Hi > > On Thu, May 4, 2017 at 5:41 PM Igor Mammedov wrote: > > > On Tue, 02 May 2017 19:03:15 + > > Marc-André Lureau wrote: > > > > > Hi > > > > >

Re: [Qemu-devel] [PATCH 16/26] target/s390x: implement COMPARE LOGICAL LONG

On 2017-05-26 08:32, Richard Henderson wrote: > On 05/25/2017 02:04 PM, Aurelien Jarno wrote: > > -if (srclen) { > > -v1 = cpu_ldub_data_ra(env, src, ra); > > +if (*srclen) { > > +v1 = cpu_ldub_data_ra(env, *src, ra); > > } > > -if

[Qemu-devel] [PULL 5/9] xhci: split into multiple files

Moved structs and defines to hcd-xhci.h. Move nec controller variant to hcd-xhci-nec.c. No functional changes. Signed-off-by: Gerd Hoffmann Message-id: 20170517103313.8459-1-kra...@redhat.com --- hw/usb/hcd-xhci.h | 226 +++

[Qemu-devel] [PULL 4/9] usb: Simplify the parameter parsing of the legacy usb serial device

From: Thomas Huth Coverity complains about the current code, so let's get rid of the now unneeded while loop and simply always emit "unrecognized serial USB option" for all unsupported options. Signed-off-by: Thomas Huth Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 06/18] numa: mirror cpu to node mapping in MachineState::possible_cpus

On Mon, 29 May 2017 10:36:47 -0300 Eduardo Habkost wrote: > On Mon, May 29, 2017 at 03:12:45PM +0200, Igor Mammedov wrote: > > On Fri, 26 May 2017 12:46:25 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, May 10, 2017 at 01:29:50PM +0200, Igor

[Qemu-devel] [PATCH v2 3/7] s390x: add css_migration_enabled to machine class

Currently the migration of the channel subsystem (css) is only partial and is done by the virtio ccw proxies -- the only migratable css devices existing at the moment. With the current work on emulated and passthrough devices we need to decouple the migration of the channel subsystem state from

[Qemu-devel] [PATCH v2 0/7] migration: s390x css migration

The scope of this patch series is now limited to decoupling channel subsystem migration from the migration of virtio-ccw proxies. The vmstatifying of virtio-ccw proxies is now done by another series currently consisting of a single patch running under the name 'vmstatify config migration for

[Qemu-devel] [PATCH v2 7/7] s390x/css: use SubchDev.orb

Instead of passing around a pointer to ORB let us simplify some functions signatures by using the previously introduced ORB saved at the subchannel (SubchDev). Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- hw/s390x/css.c | 19

[Qemu-devel] [PATCH v2 5/7] s390x/css: add ORB to SubchDev

Since we are going to need a migration compatibility breaking change to activate ChannelSubSys migration let us use the opportunity to introduce ORB to the SubchDev before that (otherwise we would need separate handling e.g. a compat property). The ORB will be useful for implementing IDA, or

Re: [Qemu-devel] [PATCH] pci-bridge/i82801b11: Convert to realize

Marcel Apfelbaum writes: > On 27/05/2017 9:58, Mao Zhongyi wrote: >> >> >> On 05/26/2017 10:08 PM, Marcel Apfelbaum wrote: >>> >>> >>> On 26/05/2017 15:15, Mao Zhongyi wrote: The pci-birdge device i82801b11 still implements the old PCIDeviceClass .init() through

Re: [Qemu-devel] [PATCH v2 3/5] numa: make sure that all cpus in has has_node_id set if numa is enabled

On Fri, 26 May 2017 13:06:30 -0300 Eduardo Habkost wrote: > On Tue, May 23, 2017 at 04:38:48PM +0200, Igor Mammedov wrote: > > It fixes/add missing _PXM object for non mapped CPU (x86) > > and missing fdt node (virt-arm). > > > > It ensures that possible_cpus contains

Re: [Qemu-devel] [PATCH] nbd: Fully initialize client in case of failed negotiation

On 05/26/2017 10:04 PM, Eric Blake wrote: > If a non-NBD client connects to qemu-nbd, we would end up with > a SIGSEGV in nbd_cilent_put() because we were trying to > unregister the client's association to the export, even though > we skipped inserting the client into that list. Easy trigger > in

Re: [Qemu-devel] [PATCH] mirror: Drop permissions on s->target on completion

On 29/05/2017 14:18, Kevin Wolf wrote: > This fixes an assertion failure that was triggered by qemu-iotests 129 > on some CI host, while the same test case didn't seem to fail on other > hosts. > > Essentially the problem is that the blk_unref(s->target) in > mirror_exit() doesn't necessarily

[Qemu-devel] [PULL 0/9] usb patch queue

branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20170529-1 for you to fetch changes up to 3bfecee2cb71f21cd39d6183f18b446c01917573: ehci: fix frame timer invocation. (2017-05-29

[Qemu-devel] [PULL 6/9] xhci: add CONFIG_USB_XHCI_NEC option

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451189 Signed-off-by: Gerd Hoffmann Message-id: 20170517103313.8459-2-kra...@redhat.com --- default-configs/pci.mak | 1 + hw/usb/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 1/1] s390x: vmstatify config migration for virtio-ccw

Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibility (extending using subsections) and for fun. To achieve this we need to hack the config_vector, which is VirtIODevice (that is common virtio) state, in the middle of the VirtioCcwDevice state representation. This

Re: [Qemu-devel] [PATCH v7 17/20] block: remove all encryption handling APIs

On Thu 25 May 2017 06:38:48 PM CEST, "Daniel P. Berrange" wrote: > Now that all encryption keys must be provided upfront via > the QCryptoSecret API and associated block driver properties > there is no need for any explicit encryption handling APIs > in the block layer.

[Qemu-devel] [PATCH] simpletrace: Improve the error message if event is not declared

Today, if we use a trace-event file which does not declare an event existing in the log file we'll get the following error: $ scripts/simpletrace.py trace-events trace-68508 Traceback (most recent call last): File "scripts/simpletrace.py", line 242, in run(Formatter()) File

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: Don't set _popen=None on error/shutdown

Eduardo Habkost writes: > Keep the Popen object around to we can query its exit code later. > > To keep the existing 'self._popen is None' checks working, add a > is_running() method, that will check if the process is still running. > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v3 2/3] qemu.py: Add QEMUMachine.exitcode() method

Eduardo Habkost writes: > Allow the exit code of QEMU to be queried by scripts. > > Signed-off-by: Eduardo Habkost > --- > scripts/qemu.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index

Re: [Qemu-devel] [PATCH 15/25] qcow2: add persistent dirty bitmaps support

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Store persistent dirty bitmaps in qcow2 image. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 475 > +++ > block/qcow2.c|

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

Hi, did you remove me from the To: / Cc: list intentionally, or was that an oversight? I caught your message in my list folders only by luck. Some followup below: On 05/29/17 17:27, gengdongjiu wrote: >> (46) What is "physical_addr" good for? Below I can only see an >> assignment to it, in

Re: [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

On 12.05.2017 12:33, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of this and can

Re: [Qemu-devel] [PATCH 10/25] qcow2: autoloading dirty bitmaps

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > >

Re: [Qemu-devel] [PATCH 12/25] block: bdrv_close: release bitmaps after drv->bdrv_close

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Release bitmaps after 'if (bs->drv) { ... }' block. This will allow > format driver to save persistent bitmaps, which will appear in following > commits. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

On 23/05/2017 04:23, Xiao Guangrong wrote: > > Ping... > > Sorry to disturb, just make this patchset not be missed. :) It won't. :) I'm going to look at it and the dirty page ring buffer this week. Paolo

Re: [Qemu-devel] [PATCH 13/25] block: introduce persistent dirty bitmaps

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > New field BdrvDirtyBitmap.persistent means, that bitmap should be saved > by format driver in .bdrv_close and .bdrv_inactivate. No format driver > supports it for now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 2/3] qemu.py: Add QEMUMachine.exitcode() method

On Mon, May 29, 2017 at 06:53:47PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Allow the exit code of QEMU to be queried by scripts. > > > > Signed-off-by: Eduardo Habkost > > --- > > scripts/qemu.py | 4 > > 1 file changed, 4

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

On 05/18/2017 03:21 PM, Gonglei (Arei) wrote: Besides if you look at +Stateless mode HASH service requests are as follows: + +\begin{lstlisting} +struct virtio_crypto_hash_para_statelesss { +struct { +/* See VIRTIO_CRYPTO_HASH_* above */ +

Re: [Qemu-devel] [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex

On Thu 25 May 2017 06:32:16 PM CEST, Paolo Bonzini wrote: > Another possibility is to use tg->lock, which we're holding anyway in > both schedule_next_request and throttle_group_co_io_limits_intercept. > This would require open-coding the CoQueue however, so I've chosen this > alternative. > >

[Qemu-devel] [PULL 00/15] Block layer patches

The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 05/15] mirror: Drop permissions on s->target on completion

This fixes an assertion failure that was triggered by qemu-iotests 129 on some CI host, while the same test case didn't seem to fail on other hosts. Essentially the problem is that the blk_unref(s->target) in mirror_exit() doesn't necessarily mean that the BlockBackend goes away immediately. It

[Qemu-devel] [PULL 01/15] stream: fix crash in stream_start() when block_job_create() fails

From: Alberto Garcia The code that tries to reopen a BlockDriverState in stream_start() when the creation of a new block job fails crashes because it attempts to dereference a pointer that is known to be NULL. This is a regression introduced in

[Qemu-devel] [PULL 04/15] nvme: Add support for Controller Memory Buffers

From: Stephen Bates Implement NVMe Controller Memory Buffers (CMBs) which were added in version 1.2 of the NVMe Specification. This patch adds an optional argument (cmb_size_mb) which indicates the size of the CMB (in MB). Currently only the Submission Queue Support (SQS) is

[Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID

[Qemu-devel] [PULL 14/15] block: Fix backing paths for filenames with colons

From: Max Reitz path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

Dear Laszlo, Thank your very much for your review and detailed comment. and very sorry for the late response due to recently debug the wholes RAS solution. On 2017/5/22 22:23, Laszlo Ersek wrote: > Keeping some context: > > On 05/12/17 23:00, Laszlo Ersek wrote: >> On 04/30/17 07:35, Dongjiu

Re: [Qemu-devel] [PATCH 08/25] qcow2: add bitmaps extension

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. Also, calculate refcounts for qcow2 bitmaps, to not break > qemu-img check. > > For now, disable

Re: [Qemu-devel] Throttling groups vs filter nodes

Am 27.05.2017 um 09:56 hat Stefan Hajnoczi geschrieben: > Throttling groups allow multiple drives to share the same throttling > state (i.e. budget) between them. Manos is working on moving the > throttling code into a block filter driver so it is no longer > hardcoded into the I/O code path. >

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 05/29/2017 10:46 AM, Max Reitz wrote: >> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"), >> you can add: > > I'd love to, but this is what type -p outputs for me: > > $ type -p qemu-img > qemu-img is /usr/bin/qemu-img Huh? That's plain 'type' output. Are you sure

[Qemu-devel] [PULL 06/15] qcow2: remove extra local_error variable

From: Alberto Garcia Commit d7086422b1c1e75e320519cfe26176db6ec97a37 added a local_err variable global to the qcow2_amend_options() function, so there's no need to have this other one. Signed-off-by: Alberto Garcia Message-id:

[Qemu-devel] [PATCH v3 2/2] iotests: Add test for colon handling

Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 105 + tests/qemu-iotests/126.out | 23 ++ tests/qemu-iotests/group | 1 + 3 files changed, 129 insertions(+) create

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 05/29/2017 10:23 AM, Max Reitz wrote: > A user may specify a relative path for accessing qemu, qemu-img, etc. > through environment variables ($QEMU_PROG and friends) or a symlink. > > If a test decides to change its working directory, relative paths will > cease to work, however. Work around

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 2017-05-29 17:55, Eric Blake wrote: > On 05/29/2017 10:46 AM, Max Reitz wrote: > >>> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"), >>> you can add: >> >> I'd love to, but this is what type -p outputs for me: >> >> $ type -p qemu-img >> qemu-img is /usr/bin/qemu-img >

Re: [Qemu-devel] Throttling groups vs filter nodes

On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > A quirk in the current implementation is that the throttling limits > for the group are overwritten by each -drive throttling.group=group0. > Limits for all but the last -drive in a group are ignored. > > There is no way to associate

[Qemu-devel] [PULL 02/15] qemu-iotests: Test streaming with missing job ID

This adds a small test for the image streaming error path for failing block_job_create(), which would have found the null pointer dereference in commit a170a91f. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Kashyap Chamarthy

[Qemu-devel] [PULL 08/15] qemu-img: add support for --object with 'dd' command

From: "Daniel P. Berrange" The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz

[Qemu-devel] [PULL 03/15] iotests: 147: Don't test inet6 if not available

From: Fam Zheng This is the case in our docker tests, as we use --net=none there. Skip this method. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/147 | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command

From: "Daniel P. Berrange" The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style

[Qemu-devel] [PULL 12/15] qemu-img: Fix leakage of options on error

From: Fam Zheng Reported by Coverity. Signed-off-by: Fam Zheng Message-id: 20170515141014.25793-1-f...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- qemu-img.c | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 15/15] block/file-*: *_parse_filename() and colons

From: Max Reitz The file drivers' *_parse_filename() implementations just strip the optional protocol prefix off the filename. However, for e.g. "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's filename which looks like it should be managed using the

[Qemu-devel] [PATCH v3 0/2] iotests: Add test for colon handling

This is a v3 for "block: Fix backing paths for filenames with colons". Kevin reported that the test added there does not work if the test programs are specified with relative paths (because the new test changes its working directory), so we/I dropped the test from the queue and here it is again.

[Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

A user may specify a relative path for accessing qemu, qemu-img, etc. through environment variables ($QEMU_PROG and friends) or a symlink. If a test decides to change its working directory, relative paths will cease to work, however. Work around this by making all of the paths to programs that

Re: [Qemu-devel] [PATCH v1] target/s390x: addressing exceptions are suppressing

On 29.05.2017 14:12, David Hildenbrand wrote: > We have to make the address in the old PSW point at the next > instruction, as addressing exceptions are suppressing and not > nullifying. According to "Figure 6-1. Interruption Action" in the PoP, they could also be terminating ... but anyway, not

[Qemu-devel] [PULL 13/15] block: Tweak error message related to qemu-img amend

From: Eric Blake When converting a 1.1 image down to 0.10, qemu-iotests 060 forces a contrived failure where allocating a cluster used to replace a zero cluster reads unaligned data. Since it is a zero cluster rather than a data cluster being converted, changing the error

[Qemu-devel] [PULL 11/15] qemu-img: copy *key-secret opts when opening newly created files

From: "Daniel P. Berrange" The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to

[Qemu-devel] [PULL 07/15] qemu-img: Fix documentation of convert

From: Fam Zheng It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U". Reported-by: Max Reitz Signed-off-by: Fam Zheng Message-id: 20170515103551.31313-1-f...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PULL 10/15] qemu-img: introduce --target-image-opts for 'convert' command

From: "Daniel P. Berrange" The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 2017-05-29 17:42, Eric Blake wrote: > On 05/29/2017 10:23 AM, Max Reitz wrote: >> A user may specify a relative path for accessing qemu, qemu-img, etc. >> through environment variables ($QEMU_PROG and friends) or a symlink. >> >> If a test decides to change its working directory, relative paths

Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Remove persistent bitmap from the storage on block-dirty-bitmap-remove. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > Reviewed-by: John Snow >

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: Vladimir

[Qemu-devel] [RFC] Making 'block-stream', and 'block-commit' accept node-name

Observe the following ('qmp-shell', for brevity) invocation of the four major types (stream, commit, mirror, backup) of live block operations: (QEMU) block-stream device=node-D base=a.qcow2 job-id=job-block-stream (QEMU) block-commit device=node-D base=a.qcow2 top=b.qcow2

[Qemu-devel] [PATCH v2 16/29] target/s390x: improve 24-bit and 31-bit lengths read/write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 47 +-- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 06/29] target/s390x: implement PACK

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 5 + target/s390x/mem_helper.c | 37 + target/s390x/translate.c | 8 4

[Qemu-devel] [PATCH v2 20/29] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 90

[Qemu-devel] [PATCH v2 00/29] target/s390x: fix, improve and implement some more instructions

This patchset tries to improve the s390x emulation by fixing and improving some instructions. It implement some more instructions, from the zArchitecture base and from the Extended-Translation Facility 2. The last patch updates the maximum TCG CPU to z800, as the ETF2 and Long-Displacement

[Qemu-devel] [PATCH v2 09/29] target/s390x: implement COMPARE AND SIGNAL

These functions differ from COMPARE by generating an exception for a QNaN input. Use the non quiet version of floatXX_compare. Signed-off-by: Aurelien Jarno --- target/s390x/fpu_helper.c | 27 +++ target/s390x/helper.h | 3 +++

[Qemu-devel] [PATCH v2 10/29] target/s390x: implement MOVE INVERSE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 8 4 files changed, 23

[Qemu-devel] [PATCH v2 15/29] target/s390x: improve 24-bit and 31-bit addresses write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c

Re: [Qemu-devel] [PATCH 21/25] iotests: test qcow2 persistent dirty bitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/165 | 105 > + > tests/qemu-iotests/165.out | 5 +++ > tests/qemu-iotests/group | 1 +

[Qemu-devel] [PATCH 1/2] hw/arm/virt-acpi-build: build SLIT when needed

Cc: Shannon Zhao Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index e5852067f5bd..2079828c22a4 100644 ---

[Qemu-devel] [PATCH 2/2] hw/arm/virt: fdt: generate distance-map when needed

This is based on patch Shannon Zhao originally posted. Cc: Shannon Zhao Signed-off-by: Andrew Jones --- hw/arm/virt.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[Qemu-devel] [PATCH 0/2] hw/arm/virt: numa: provide distance info when needed

Andrew Jones (2): hw/arm/virt-acpi-build: build SLIT when needed hw/arm/virt: fdt: generate distance-map when needed hw/arm/virt-acpi-build.c | 4 hw/arm/virt.c| 21 + 2 files changed, 25 insertions(+) -- 2.9.4

  1   2   3   >