On 07/06/2017 18:26, Juan Quintela wrote:
> Felipe Franciosi wrote:
>> Currently, the throttle_thread_scheduled flag is reset back to 0 before
>> sleeping (as part of the throttling logic). Given that throttle_timer
>> (well, any timer) may tick with a slight delay, it so happens that under
>> h
On 2017-06-01 19:27, Daniel P. Berrange wrote:
> This adds support for using LUKS as an encryption format
> with the qcow2 file, using the new encrypt.format parameter
> to request "luks" format. e.g.
>
> # qemu-img create --object secret,data=123456,id=sec0 \
>-f qcow2 -o encrypt.format
** Changed in: qemu
Status: Incomplete => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/893956
Title:
qemu-img bug with dynamic vhd
Status in QEMU:
Won't Fix
Bug description:
Hi
On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD
wrote:
> On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote:
> > Move all the fronted struct and methods to a seperate unit. This avoids
> > accidentally mixing backend and frontend calls, and helps with
> readibilty.
> >
> > Make q
On 07/06/2017 17:52, Lluís Vilanova wrote:
> Paolo Bonzini writes:
>
>> On 07/06/2017 14:07, Peter Maydell wrote:
My understanding was that adding a public instrumentation interface would
add
too much code maintenance overhead for a feature that is not in QEMU's core
target.
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>
>
> On 06/07/2017 02:01 PM, Dr. David Alan Gilbert wrote:
> > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> >>
> >>
> >> On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote:
> >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> Verbose
On 7 June 2017 at 17:13, Alex Bennée wrote:
>
> Peter Maydell writes:
>
>> If EL3 is not implemented (ie only one security state) then the
>> one and only ICC_BPR1 register behaves like the Non-secure
>> ICC_BPR1 in an EL3-present configuration. In particular, its
>> reset value is GIC_MIN_BPR_NS
On 07.06.2017 16:34, Paolo Bonzini wrote:
>
>
> On 07/06/2017 09:33, Thomas Huth wrote:
>> On 07.06.2017 09:07, David Gibson wrote:
>>> The pseries machine type doesn't usually use the 'pvpanic' device as such,
>>> because it has a firmware/hypervisor facility with roughly the same
>>> purpose.
Similarly to what was done to spapr with commit 249127d0dfeb, this patch
ensures that we don't keep an extra reference on the ICPState object. Also
since the object was just created and not reparented yet, the call to
object_property_add_child() should never fail: let's pass &error_abort to
make th
Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
sPAPRCPUCore") moved ICPState objects from the machine to CPU cores.
This is an improvement since we no longer allocate ICPState objects
that will never be used. But it has the side-effect of breaking
migration of older machine ty
On 06/07/2017 07:10 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 06/07/2017 02:01 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote:
> * H
+ more folks who made changes to hw/i386/multiboot.c
On Tue, Jun 6, 2017 at 9:41 PM, Anatol Pomozov wrote:
> It is possible to create a 64 bit elf image that has valid multiboot header.
> qemu should be able to boot such images.
>
> Tested with homemade 64bit OS - now it boots fine with 'qemu -ke
Peter Maydell writes:
> On 7 June 2017 at 14:09, Markus Armbruster wrote:
>> Peter Maydell writes:
>>> So how should I obtain those semantics with this cleanup in place ?
>>
>> Two ways come to mind:
>>
>> * Define a PropertyInfo like qdev_prop_uint32 with a null
>> set_default_value(), and u
On 2017-06-01 19:27, Daniel P. Berrange wrote:
> Currently 'qemu-img info' reports a simple "encrypted: yes"
> field. This is not very useful now that qcow2 can support
> multiple encryption formats. Users want to know which format
> is in use and some data related to it.
>
> Wire up usage of the
Peter Xu wrote:
> Put it into MigrationState then we can use the properties to specify
> whether to enable storing global state.
>
> Signed-off-by: Peter Xu
> ---
> include/migration/migration.h | 6 ++
> migration/migration.c | 21 +
> 2 files changed, 23 insert
On 2017-06-01 19:27, Daniel P. Berrange wrote:
> Previously posted:
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00201.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05147.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05671.html
>
Peter Xu wrote:
> Removing two callers of global_state_set_optional() since now we can use
> HW_COMPAT_2_3. However there is still one more caller (xen_init), so we
> still need to keep the function until it disappears.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Ah, you do it here,
On 06/07/2017 07:17 PM, Greg Kurz wrote:
> Taking into account that qemu_set_irq() returns immediatly if its first
> argument is NULL, icp_kvm_reset() largely duplicates icp_reset().
>
> This patch introduces a reset() handler, so that the common logic can
> be implemented in icp_reset() only.
>
Peter Xu wrote:
> It was in SaveState but now moved to MigrationState altogether. Again,
> using HW_COMPAT_2_3 for old PC/SPAPR machines but still we'll have to
> keep savevm_skip_configuration() since used by xen_init().
oops.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
On 06/07/2017 07:16 PM, Greg Kurz wrote:
> Similarly to what was done to spapr with commit 249127d0dfeb, this patch
> ensures that we don't keep an extra reference on the ICPState object. Also
> since the object was just created and not reparented yet, the call to
> object_property_add_child() shou
The following changes since commit b55a69fe5f0a504dac6359bb7e99a72b130c3661:
Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170607'
into staging (2017-06-07 15:06:42 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-ups
Block migration may still access the image during its
.save_live_complete_precopy() implementation, so we should only
inactivate the image afterwards.
Another reason for the change is that inactivating an image fails when
there is still a non-device BlockBackend using it, which includes the
BBs us
blk->name isn't an array, but a pointer that can be NULL. Checking for
an anonymous BB must involve a NULL check first, otherwise we get
crashes.
Signed-off-by: Kevin Wolf
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
---
block/block-backend
The final bdrv_set_backing_hd() could be working on already freed nodes
because the commit job drops its references (through BlockBackends) to
both overlay_bs and top already a bit earlier.
One way to trigger the bug is hot unplugging a disk for which
blockdev_mark_auto_del() cancels the block job
We need to release any block migrations BlockBackends on the source
before successfully completing the migration because otherwise
inactivating the images will fail (inactivation only tolerates device
BBs).
Signed-off-by: Kevin Wolf
Reviewed-by: Fam Zheng
Reviewed-by: Eric Blake
Reviewed-by: Je
Signed-off-by: Kevin Wolf
Reviewed-by: John Snow
---
tests/qemu-iotests/040 | 35 +--
tests/qemu-iotests/040.out | 4 ++--
2 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 5bdaf3d..9d381d9 1
From: Peter Maydell
Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.
Signed-off-by: Peter Maydell
Reviewed-by: Eric Blake
Reviewed-by: Phili
Peter Xu wrote:
> Move it into MigrationState, with a property binded to it.
>
> Same trick played with HW_COMPAT_2_3.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Kevin Wolf
Reviewed-by: Jeff Cody
Reviewed-by: Eric Blake
---
tests/qemu-iotests/183 | 140 +
tests/qemu-iotests/183.out | 46 +++
tests/qemu-iotests/group | 1 +
3 files changed, 187 insertions(+)
create mode 1007
From: Jeff Cody
In external_snapshot_abort(), we try to undo what was done in
external_snapshot_prepare() calling bdrv_replace_node() to swap the
nodes back. However, we receive a permissions error as writers are
blocked on the old node, which is now the new node backing file.
An easy fix (init
The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request'
into staging (2017-06-07 11:56:00 +0100)
are available in the git repository at:
git://github.com/berrange/qemu tags/pull-sockets-2017-0
When binding to an IPv6 socket we currently force the
IPV6_V6ONLY flag to off. This means that the IPv6 socket
will accept both IPv4 & IPv6 sockets when QEMU is launched
with something like
-vnc :::1
While this is good for that case, it is bad for other
cases. For example if an empty hostname i
Juan Quintela wrote:
> Hi
Hi Kevin and Stefan, I intended to cc you on this series.
Is this what you were asking for block layer migration?
Do you need anything else?
Thanks, Juan.
> This series make:
> - use of cleanup/save methods generic, not only for save_live methods
> - create the equi
The original InetSocketAddress struct may have has_ipv4 and
has_ipv6 fields set, which will control both the ai_family
used during DNS resolution, and later use of the V6ONLY
flag.
Currently the standalone DNS resolver code drops the
has_ipv4 & has_ipv6 flags after resolving, which means
the later
When inet_parse() parses the hostname, it is forcing the
has_ipv6 && ipv6 flags if the address contains a ":". This
means that if the user had set the ipv4=on flag, to try to
restrict the listener to just ipv4, an error would not have
been raised. eg
-incoming tcp:[::]:9000,ipv4
should have r
The semantics around handling ipv4=on|off & ipv6=on|off are quite
subtle to understand in combination with the various hostname addresses
and backend types. Introduce a massive test matrix that launches QEMU
and validates the ability to connect a client on each protocol as
appropriate.
The test re
Currently if you disable listening on IPv4 addresses, via the
CLI flag ipv4=off, we still mistakenly accept IPv4 clients via
the IPv6 listener socket due to IPV6_V6ONLY flag being unset.
We must ensure IPV6_V6ONLY is always set if ipv4=off
This fixes the following scenarios
-incoming tcp::9000
Halil Pasic wrote:
> On 06/01/2017 01:32 PM, Cornelia Huck wrote:
>> On Thu, 1 Jun 2017 11:35:27 +0200
>> Halil Pasic wrote:
>>
I was about to suggest to move css from pointer to an embedded struct,
and then noticed that MAX_CSSID is 65535. I guess that this is
>
> #define
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
scripts/coccinelle/return_directly.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/return_directly.cocci
b/scripts/coccin
From: Philippe Mathieu-Daudé
spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Blake
Reviewed-by: Laurent Vivier
Signed-off-by: Stefan Hajnoczi
---
util/oslib-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request'
into staging (2017-06-07 11:56:00 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/block-pull-requ
From: Roman Pen
Submission of requests on linux aio is a bit tricky and can lead to
requests completions on submission path:
44713c9e8547 ("linux-aio: Handle io_submit() failure gracefully")
0ed93d84edab ("linux-aio: process completions from ioq_submit()")
That means that any coroutine which ha
The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit
file so GDB either loads qemu-gdb.py automatically or prints a message
informing the user how to enable them (some systems disable ./.gdbinit
loading for security reasons).
Symlink .gdbinit and the scripts directory in order
From: Bruno Dominguez
There was no possibility to add specific cxx flags using the configure
file. So A new entrance has been created to support it.
Duplication of information in configure and rules.mak. Taking
QEMU_CFLAGS and add them to QEMU_CXXFLAGS, now the value of
QEMU_CXXFLAGS is stored i
Pranith Kumar writes:
> Can someone please pick this up?
It needs to be re-posted with the review tag and ping Paolo re: async
work for KVM.
>
> Thanks,
>
> On Fri, Feb 24, 2017 at 12:42 AM, Pranith Kumar wrote:
>> In mttcg, calling pause_all_vcpus() during execution from the
>> generated TBs
On 06/07/2017 07:17 PM, Greg Kurz wrote:
> Until recently, spapr used to allocate ICPState objects for the lifetime
> of the machine. They would only be associated to vCPUs in xics_cpu_setup()
> when plugging a CPU core.
>
> Now that ICPState objects have the same lifecycle as vCPUs, it is
> possi
On 06/07/2017 07:17 PM, Greg Kurz wrote:
> The ICPState objects are currently registered to vmstate as qdev objects.
> Their instance ids are hence computed automatically in the migration code,
> and thus depends on the order the CPU cores were plugged.
>
> If the destination had its CPU cores plu
> > How, since there is no synchronization point between the vhost-user
> > server on the source and the destination?
>
> The idea is that the backend should both stop picking up new requests and
> also quiesce outstanding requests upon a GET_VRING_BASE vhost message.
This could be documented, bu
Hi
On Wed, May 31, 2017 at 5:07 PM Stefan Hajnoczi wrote:
> On Tue, May 30, 2017 at 01:21:01PM +0200, Christian Borntraeger wrote:
> > On 05/30/2017 12:11 PM, Stefan Hajnoczi wrote:
> > > Here is a first stab at the next release schedule:
> > >
> > > Beginning of development phase: 2017-04-20
>
> On 7 Jun 2017, at 16:47, Peter Maydell wrote:
>
> On 7 June 2017 at 16:39, Felipe Franciosi wrote:
>>
>>> On 7 Jun 2017, at 16:37, Peter Maydell wrote:
>>>
>>> On 7 June 2017 at 16:28, Paolo Bonzini wrote:
From: Felipe Franciosi
This commit introduces a vhost-user device
On Wed, Jun 07, 2017 at 02:22:24PM -0400, Paolo Bonzini wrote:
> > > How, since there is no synchronization point between the vhost-user
> > > server on the source and the destination?
> >
> > The idea is that the backend should both stop picking up new requests and
> > also quiesce outstanding re
On Wed, Jun 7, 2017 at 2:09 PM, Alex Bennée wrote:
>
> Pranith Kumar writes:
>
>> Can someone please pick this up?
>
> It needs to be re-posted with the review tag and ping Paolo re: async
> work for KVM.
>
Will do.
Thanks,
--
Pranith
Hi,
The patch "char: move CharBackend handling in char-fe unit" broke
chardev aliases. Here is a small series to fix it, and add a simple
unit test to check the alias keep working.
Marc-André Lureau (3):
char: fix alias devices regression
chardev: don't use alias names in parse_compat()
tes
Fix regression from commit 4d43a603c71, where the serial and parallel
headers got removed from char.c, which broke the alias table.
Signed-off-by: Marc-André Lureau
---
chardev/char.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/chardev/char.c b/chardev/char.c
index 7aa0210765..f38fac5c
"parport" is considered "old" since commit 88a946d32d, when "parallel"
was added. Similarly for "tty" in commit d59044ef74d.
Signed-off-by: Marc-André Lureau
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index f38fac5c6
Quite limited test, to check that the chardev can be created with a
path and with the tty alias.
Signed-off-by: Marc-André Lureau
---
tests/test-char.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index dfe856cb85..ecc3
The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request'
into staging (2017-06-07 11:56:00 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-re
From: Jose Ricardo Ziviani
Today, if we use a trace-event file which does not declare an event
existing in the log file we'll get the following error:
$ scripts/simpletrace.py trace-events trace-68508
Traceback (most recent call last):
File "scripts/simpletrace.py", line 242, in
run(Forma
From: Jose Ricardo Ziviani
Today, if we use a trace-event file which does not declare an event
existing in the log file we'll get the following error:
$ scripts/simpletrace.py trace-events trace-68508
Traceback (most recent call last):
File "scripts/simpletrace.py", line 242, in
run(Forma
The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request'
into staging (2017-06-07 11:56:00 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-re
> > This could be documented,
>
> It is documented AFAIK. Pls take a look at the spec documentation.
Found it now. It's not under GET_VRING_BASE, it's under "starting
and stopping rings"---fair enough.
In the case of vhost-user-scsi, however, QEMU also must not proceed
until vhost-user-scsi ha
Hi, Michael, could you pick this patch?
thanks
On Fri, Jun 2, 2017 at 12:26 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> CC tests/vhost-user-bridge.o
> /home/dgilbert/git/qemu-world3/tests/vhost-user-bridge.c:228:23: warning:
> variables 'front' and 'iov' used in loop cond
In mttcg, calling pause_all_vcpus() during execution from the
generated TBs causes a deadlock if some vCPU is waiting for exclusive
execution in start_exclusive(). Fix this by using the aync_safe_*
framework instead of pausing vcpus for patching instructions.
CC: Paolo Bonzini
CC: Peter Maydell
When doing a "make -j10" in the vanilla QEMU source tree (without
running "configure first), the Makefile currently generates two
files already, qemu-version.h and qemu-options.def. This should not
happen, so let's make these targets depend on config-host.mak.
Also the python files can not be execu
* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote:
> The info registers command in the qemu monitor is used to dump register
> values.
>
> Currently this command uses the monitor cpu (which can be set by the
> user) as the cpu for whose registers will be dumped. Sometimes it is
> useful to s
Hi
On Tue, Jun 6, 2017 at 3:06 PM Gerd Hoffmann wrote:
> Add a collection of egl_fb_*() helper functions to manage and use opengl
> framebuffers, which is a common pattern in UI code with opengl support.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/egl-helpers.h | 14 ++
> ui/eg
Just upgraded to 2.9.0 and actually I see a different issue:
# qemu-img convert -O raw fedora.iso gluster://dalpinfglt04/virt0/fedora6.raw
[2017-06-07 16:52:43.300902] C
[rpc-clnt-ping.c:160:rpc_clnt_ping_timer_expired] 0-virt0-client-2: server
172.19.38.42:49152 has not responded in the last 42
On Tue, Jun 6, 2017 at 5:55 PM, Richard Henderson wrote:
> On 06/03/2017 02:19 AM, Max Filippov wrote:
>>
>> +memset(mem_buf, 0, reg->size);
>> +return reg->size;
>> return 0;
>
> Leaving a dead return.
Meh ): Thanks for the review. Will send a fix.
--
Thanks.
-- Max
Signed-off-by: Max Filippov
---
target/xtensa/gdbstub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c
index da131ae..d78a1b4 100644
--- a/target/xtensa/gdbstub.c
+++ b/target/xtensa/gdbstub.c
@@ -72,7 +72,6 @@ int xtensa_cpu_gdb_read_register
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding
translate
Type: series
Message-id: 20170607155536.119
** Changed in: qemu
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1696180
Title:
Issues with qemu-img, libgfapi, and encryption at rest
Status in QEMU:
Triag
On Thu, May 04, 2017 at 09:11:50 +0200, Markus Armbruster wrote:
> Thomas Huth writes:
(snip)
> > STEXI
> > @item -accel @var{name}[,prop=@var{value}[,...]]
> > @findex -accel
> > This is used to enable an accelerator. Depending on the target
> > architecture,
> > -kvm, xen, or tcg can be ava
On Wed, Jun 07, 2017 at 15:22:48 +0100, Alex Bennée wrote:
>
> Alex Bennée writes:
>
> > Richard Henderson writes:
> >
> >> From: "Emilio G. Cota"
> >>
> >> Measurements:
> >>
> >> [Baseline performance is that before applying this and the previous
> >> commit]
> >
> > Sadly this has regressed
On 06/07/2017 07:11 AM, Alex Bennée wrote:
Richard Henderson writes:
From: "Emilio G. Cota"
Measurements:
[Baseline performance is that before applying this and the previous
commit]
Sadly this has regressed my qemu-system-aarch64 EL2 run. It was slightly
masked by an unrelated assertion
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Subject: [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type
Message-id: 20170607163635.17635-1-marcandre.l
On Wed, 7 Jun 2017 20:11:38 +0200
Cédric Le Goater wrote:
> On 06/07/2017 07:17 PM, Greg Kurz wrote:
> > Until recently, spapr used to allocate ICPState objects for the lifetime
> > of the machine. They would only be associated to vCPUs in xics_cpu_setup()
> > when plugging a CPU core.
> >
> > N
On Wed, 7 Jun 2017 20:14:01 +0200
Cédric Le Goater wrote:
> On 06/07/2017 07:17 PM, Greg Kurz wrote:
> > The ICPState objects are currently registered to vmstate as qdev objects.
> > Their instance ids are hence computed automatically in the migration code,
> > and thus depends on the order the C
On 06/07/2017 02:11 PM, Thomas Huth wrote:
> When doing a "make -j10" in the vanilla QEMU source tree (without
> running "configure first), the Makefile currently generates two
s/"configure/"configure"/
> files already, qemu-version.h and qemu-options.def. This should not
> happen, so let's make
Hi
The patch looks good to me, but I tried to use egl-headless for the first
time, and I get a weird crash on virgl init:
(gdb) bt
#0 0x7fffd8cd935f in rawmemchr () at /lib64/libc.so.6
#1 0x7fffd8cc1832 in _IO_str_init_static_internal () at
/lib64/libc.so.6
#2 0x7fffd8cb37e7 in vssc
Instead of unconditionally exiting to the exec loop for indirect jumps
or cross-page direct jumps, use the lookup_and_goto_ptr helper to jump
to the target if it is valid.
Signed-off-by: Aurelien Jarno
---
target/sh4/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
On 06/07/2017 01:49 PM, Marc-André Lureau wrote:
> Hi,
>
> The patch "char: move CharBackend handling in char-fe unit" broke
> chardev aliases. Here is a small series to fix it, and add a simple
> unit test to check the alias keep working.
>
> Marc-André Lureau (3):
> char: fix alias devices re
On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote:
> On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
>> On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
>>> This is part of my work for my GSOC project this summer.
>>>
>>> I am not sure if the count parameter in bdrv_co_pwrite_zeros a
On 06/07/2017 09:08 AM, Alberto Garcia wrote:
> Instead of calling perform_cow() twice with a different COW region
> each time, call it just once and make perform_cow() handle both
> regions.
>
> This patch simply moves code around. The next one will do the actual
> reordering of the COW operation
On 06/07/2017 02:46 AM, Marc-André Lureau wrote:
> I used a the following coccinelle script:
>
> @@
> expression e1;
> @@
> - ((e1) + (3)) / (4) * (4)
> + ROUND_UP(e1,4)
Can't you also search for:
@@
expression e1, e2
@@
- ((e1) + (e2 - 1)) / (e2) * (e2)
+ ROUND_UP(e1, e2)
to catch cases where
On 06/07/2017 02:46 AM, Marc-André Lureau wrote:
> The coccinelle/round.cocci script doesn't catch hard coded values.
>
> I used the following script over qemu code base:
>
> (
> - ((e1) + 3) / (4)
> + DIV_ROUND_UP(e1,4)
As in 1/5, can't you also write a search for ((e1) + (e2) - 1) / e2, to
cov
On 06/07/2017 02:46 AM, Marc-André Lureau wrote:
> The g_new() familly of macros is simpler and safer than g_malloc().
s/familly/family/
>
> "The return pointer is cast to the given type... Care is taken to
> avoid overflow when calculating the size of the allocated block."
>
> I left out the c
On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote:
On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote:
On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
This is part of my work for my GSOC project this summer.
I am not sure
On Wed, Jun 07, 2017 at 08:55:30 -0700, Richard Henderson wrote:
(snip)
> +#elif defined(__APPLE__) \
> + || defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> +# include
> +# if defined(__APPLE__)
> +# define SYSCTL_CACHELINE_NAME "hw.cachelinesize"
> +# else
> +# define SYSCTL_CACHELIN
On 06/07/2017 05:08 PM, Manos Pitsidianakis wrote:
> On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote:
>> On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote:
>>> On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
> This i
Change the 'int count' parameter in bdrv_co_pwrite_zeros and
bdrv_co_pdiscard to 'int bytes', as they both refer to bytes.
This helps with code legibility.
Signed-off-by: Manos Pitsidianakis
---
include/block/block_int.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/inc
On Wed, Jun 07, 2017 at 18:45:10 +0300, Lluís Vilanova wrote:
> If there is such renewed interest, I will carve a bit more time to bring the
> patches up to date and send the instrumentation ones for further discussion.
I'm very interested and have time to spend on it -- I'm working on a
simulator
Signed-off-by: Pranith Kumar
---
tcg/aarch64/tcg-target.inc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index ab0a8caa03..e488aacadb 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-target.inc.c
@@ -269,6
This enables indirect jump on aarch64 hosts. Tested by booting an x86 guest on
aarch64 host.
Signed-off-by: Pranith Kumar
---
include/exec/exec-all.h | 6 +-
tcg/aarch64/tcg-target.inc.c | 25 ++---
translate-all.c | 2 --
3 files changed, 7 insertion
Hi,
The following patches apply on top of tcg-next of rth's branch. These
patches make use of LDR (literal) on aarch64 and enable us to remove
the 128MB code buffer size limitation.
Pranith Kumar (3):
tcg/aarch64: Introduce and use jump to register
tcg/aarch64: Introdue LDR (literal) generati
Signed-off-by: Pranith Kumar
---
tcg/aarch64/tcg-target.inc.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index 1fa3bccc89..ab0a8caa03 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-tar
Quoting David Gibson (2017-06-06 08:05:33)
> PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation
> state once the device is attached. This has been there from the initial
> implementation, and it's not clear why.
>
> The state diagram in PAPR 13.4 suggests PCI devices shoul
Quoting David Gibson (2017-06-06 20:33:07)
> On Tue, Jun 06, 2017 at 04:37:27PM -0500, Michael Roth wrote:
> > Quoting David Gibson (2017-06-06 08:05:32)
> > > This function is fairly short, and so is its only caller. There's no
> > > particular logical distinction between them, so fold them toget
Quoting David Gibson (2017-06-06 20:28:51)
> On Tue, Jun 06, 2017 at 04:04:33PM -0500, Michael Roth wrote:
> > Quoting David Gibson (2017-06-06 03:32:20)
> > > There are 3 types of "indicator" associated with hotplug in the PAPR spec
> > > the "allocation state", "isolation state" and "DR-indicator
Quoting David Gibson (2017-06-06 22:20:11)
> A third batch of cleanups to the DRC code. This continues to clear
> away relatively simple cruft, to get a clearer look at the fundamental
> state handling.
>
> Changes since v1:
> * Some comment updates suggested by Mike Roth
> * Changed approach
On Wed, Jun 07, 2017 at 08:55:29 -0700, Richard Henderson wrote:
> Then I've a few follow-up patches to take advantage of the new TB
> placement for arm platforms. I've had a look at the asm output for
> ppc64 and s390x, and don't see anything obvious that can be improved.
Nice! Just tested patch
301 - 400 of 453 matches
Mail list logo
