Re: [Qemu-devel] [PATCH 12/23] hyperv: make HvSintRoute reference-counted

2017-06-23 Thread Eduardo Habkost
On Wed, Jun 14, 2017 at 07:23:56PM +0300, Roman Kagan wrote: > On Wed, Jun 14, 2017 at 10:53:25AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 06, 2017 at 09:19:37PM +0300, Roman Kagan wrote: > > > Multiple entities (e.g. VMBus devices) can use the same SINT route. To > > > make their lives

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

2017-06-23 Thread Stefan Hajnoczi
On Wed, Jun 21, 2017 at 02:32:48PM +0200, David Hildenbrand wrote: > On 21.06.2017 13:08, Stefan Hajnoczi wrote: > > On Mon, Jun 19, 2017 at 12:26:52PM +0200, David Hildenbrand wrote: > >> On 19.06.2017 12:08, Stefan Hajnoczi wrote: > >>> On Fri, Jun 16, 2017 at 04:20:02PM +0200, David Hildenbrand

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 11:51 AM, Peter Maydell a écrit : On 15 June 2017 at 16:15, Edgar E. Iglesias wrote: On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: The difference here is that the clock objects themselves have internal state. That's not necessarily

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 12:54 PM, Peter Maydell a écrit : On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Hi, Paolo suggested offline that we send a pull request for this series. Here it is, I've run it through my

Re: [Qemu-devel] [PULL 0/7] Ui and input 20170623 patches

2017-06-23 Thread Peter Maydell
00) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-and-input-20170623-pull-request > > for you to fetch changes up to 6e24ee0c1e4b6c0c9c748acab77ecd113c942a4d: > > ps2: reset queue in

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 12:48, Markus Armbruster wrote: > "Daniel P. Berrange" writes: >> +The supported lifetime for machine types is 12 releases, which is >> +equivalent to 4 years worth of previous QEMU releases. >> + > > Do we have consensus on this?

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Daniel P. Berrange
On Fri, Jun 23, 2017 at 01:48:34PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > There is currently no explicit guidance on the duration of support > > for features such as versioned machine types, which have a finite > > useful lifespan. Thus apps /

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

2017-06-23 Thread Eduardo Habkost
On Fri, Jun 23, 2017 at 09:12:01AM +0100, Mark Cave-Ayland wrote: > On 21/06/17 14:23, Eduardo Habkost wrote: > > > I now have a v7 patchset ready to go (currently hosted at > > https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo, > > I've currently left off your

Re: [Qemu-devel] [PATCH v2 1/2] docs: document deprecated features in appendix

2017-06-23 Thread Daniel P. Berrange
On Fri, Jun 23, 2017 at 01:44:46PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The deprecation of features in QEMU is totally adhoc currently, > > with no way for the user to get a list of what is deprecated > > in each release. This adds an appendix

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > There is currently no explicit guidance on the duration of support > for features such as versioned machine types, which have a finite > useful lifespan. Thus apps / users cannot predict how much time > they might be able to use a feature for,

Re: [Qemu-devel] [PATCH v2 1/2] docs: document deprecated features in appendix

2017-06-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The deprecation of features in QEMU is totally adhoc currently, > with no way for the user to get a list of what is deprecated > in each release. This adds an appendix to the doc that records > when each deprecation[1] was made and provides

Re: [Qemu-devel] [PATCH v4 0/3] Add memfd memory backend

2017-06-23 Thread Eduardo Habkost
On Thu, Jun 22, 2017 at 11:58:14AM +0200, David Hildenbrand wrote: > On 21.06.2017 16:02, Marc-André Lureau wrote: > > Add a new Linux-specific memory backend, similar to hostmem-file, > > except that it doesn't need file path. It also try to enforce memory > > sealing if available. It is thus

Re: [Qemu-devel] [PATCH] target/i386: fix interrupt CPL error when using ist in x86-64

2017-06-23 Thread Paolo Bonzini
On 21/06/2017 16:21, Wu Xiang wrote: > In do_interrupt64(), when interrupt stack table(ist) is enabled > and the the target code segment is conforming(e2 & DESC_C_MASK), the > old implementation always set new CPL to 0, and SS.RPL to 0. > > This is incorrect for when CPL3 code access a CPL0

Re: [Qemu-devel] [PATCH v3 11/18] target/s390x: Mark STFLE_49 facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes execution-hint, load-and-trap, > miscellaneous-instruction-extensions and processor-assist. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH v3 12/18] target/s390x: Finish implementing ETF2-ENH

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Missed the proper alignment in TRTO/TRTT, and ignoring the M3 > field for all TRXX insns without ETF2-ENH. > > Signed-off-by: Richard Henderson > --- > target/s390x/mem_helper.c | 11 ++- > target/s390x/translate.c | 5

Re: [Qemu-devel] [PATCH v3 09/18] target/s390x: Implement execution-hint insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 9 + > target/s390x/translate.c | 5 - > 2 files changed, 13 insertions(+), 1 deletion(-) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v3 06/18] target/s390x: Implement load-on-condition-2 insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 9 + > target/s390x/insn-format.def | 1 + > target/s390x/translate.c | 18 +++--- > 3 files changed, 25 insertions(+), 3

Re: [Qemu-devel] [PATCH v3 10/18] target/s390x: Implement processor-assist insn

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 3 +++ > target/s390x/translate.c | 1 + > 2 files changed, 4 insertions(+) Reviewed-by: Aurelien Jarno -- Aurelien Jarno

Re: [Qemu-devel] [PATCH v3 08/18] target/s390x: Mark STFLE_53 facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes load-on-condition-2 and > load-and-zero-rightmost-byte. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v3 07/18] target/s390x: Implement load-and-zero-rightmost-byte insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 4 > target/s390x/translate.c | 7 +++ > 2 files changed, 11 insertions(+) > > diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def

Re: [Qemu-devel] [PATCH v3 05/18] target/s390x: Mark FPSEH facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes DFP-rounding, FPR-GR-transfer, > FPS-sign-handling, and IEEE-exception-simulation. We do > support all of these. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file

Re: [Qemu-devel] [PATCH v3 02/18] target/s390x: change PSW_SHIFT_KEY

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > From: David Hildenbrand > > Such shifts are usually used to easily extract the PSW KEY from the PSW > mask, so let's avoid the confusing offset of 4. > > Reviewed-by: Thomas Huth > Signed-off-by: David

Re: [Qemu-devel] [PULL 00/01] seccomp branch queue

2017-06-23 Thread Peter Maydell
On 22 June 2017 at 09:33, Eduardo Otubo wrote: > The following changes since commit 8dfaf23ae1f2273a9730a9b309cc8471269bb524: > > tcg/tci: fix tcg-interpreter build (2017-06-20 18:39:15 +0100) > > are available in the git repository at: > > https://github.com/otubo/qemu.git

Re: [Qemu-devel] [PATCH v3 01/18] target/s390x: Map existing FAC_* names to S390_FEAT_* names

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > The FAC_ names were placeholders prior to the introduction > of the current facility modeling. > > Signed-off-by: Richard Henderson > --- > target/s390x/translate.c | 59 > > 1

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread Peter Maydell
On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > Paolo suggested offline that we send a pull request for this series. > Here it is, I've run it through my testsuite + tested the LQSPI testcase > on

Re: [Qemu-devel] Commit 77af8a2b9 breaks (mac)OS X 10.11.6

2017-06-23 Thread Phil Dennis-Jordan
Hi, Apologies for the late reply, I've been away. On 20 June 2017 at 01:06, BALATON Zoltan wrote: >> I can (still) boot off my 10.11.0 installer iso image, and >> successfully upgraded from 10.11.4 to 10.11.6, with the latter >> continuing to boot without problems. > > I had

[Qemu-devel] [PULL 1/7] keymaps: add tracing

2017-06-23 Thread Gerd Hoffmann
Drop commented debug logging, add trace points instead. Also cleanup parser code a bit, the key name is copied into a new variable instead of patching the input line, that way we can log the unmodified line. Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PATCH] mips/malta: load the initrd at the end of the low memory

2017-06-23 Thread Aurelien Jarno
Currently the malta board is loading the initrd just after the kernel. This doesn't work for kaslr enabled kernels, as the initrd ends-up being overwritten. Move the initrd at the end of the low memory, that should leave a sufficient gap for kaslr. Signed-off-by: Aurelien Jarno

[Qemu-devel] [PULL 7/7] ps2: reset queue in ps2_reset_keyboard

2017-06-23 Thread Gerd Hoffmann
When the guest resets the keyboard also clear the queue. It is highly unlikely that the guest is still interested in the events stuck in the queue, and it avoids confusing the guest in case the queue is full and the ACK can't be queued up. Fixes:

[Qemu-devel] [PULL 2/7] input: Decrement queue count on kbd delay

2017-06-23 Thread Gerd Hoffmann
From: Alexander Graf Delays in the input layer are special cased input events. Every input event is accounted for in a global intput queue count. The special cased delays however did not get removed from the queue, leading to queue overruns and thus silent key drops after typing

[Qemu-devel] [PULL 3/7] hid: Reset kbd modifiers on reset

2017-06-23 Thread Gerd Hoffmann
From: Alexander Graf When resetting the keyboard, we need to reset not just the pending keystrokes, but also any pending modifiers. Otherwise there's a race when we're getting reset while running an escape sequence (modifier 0x100). Cc: qemu-sta...@nongnu.org Signed-off-by:

[Qemu-devel] [PULL 0/7] Ui and input 20170623 patches

2017-06-23 Thread Gerd Hoffmann
The following changes since commit e18a639164e162b3a4f078ab60606cd2f163d934: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170621-pull-request' into staging (2017-06-22 15:09:48 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-and-input-20170623

[Qemu-devel] [PULL 5/7] ps2: add and use PS2State typedef

2017-06-23 Thread Gerd Hoffmann
Cleanup: Create and use a typedef for PS2State and stop passing void pointers. No functional change. Signed-off-by: Gerd Hoffmann Message-id: 20170606112105.13331-2-kra...@redhat.com --- include/hw/input/ps2.h | 4 ++-- include/qemu/typedefs.h | 1 + hw/input/ps2.c

[Qemu-devel] [PULL 6/7] ps2: add ps2_reset_queue

2017-06-23 Thread Gerd Hoffmann
Factor out ps2 queue reset to a separate function. No functional change. Signed-off-by: Gerd Hoffmann Message-id: 20170606112105.13331-3-kra...@redhat.com --- hw/input/ps2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/input/ps2.c

[Qemu-devel] [PULL 4/7] sdl2: add assert to make coverity happy

2017-06-23 Thread Gerd Hoffmann
There is a loop a few lines up counting consoles and setting sdl2_num_outputs accordingly, so con ptr can't be NULL there. Signed-off-by: Gerd Hoffmann Message-id: 20170621122234.12751-1-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 + 1

[Qemu-devel] [PATCH v4 4/4] sockets: Handle race condition between binds to the same port

2017-06-23 Thread Knut Omang
If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid a failure. This

[Qemu-devel] [PATCH v4 0/4] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

2017-06-23 Thread Knut Omang
This series contains: * a unit test that exposes a race condition which causes QEMU to fail to find a port even when there is plenty of available ports. * a refactor of the qemu-sockets inet_listen_saddr() function to better handle this situation. Changes from v3: * Test changes: Add missing

[Qemu-devel] [PATCH v4 2/4] sockets: factor out create_fast_reuse_socket

2017-06-23 Thread Knut Omang
First refactoring step to prepare for fixing the problem exposed with the test-listen test in the previous commit Signed-off-by: Knut Omang --- util/qemu-sockets.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v4 3/4] sockets: factor out a new try_bind() function

2017-06-23 Thread Knut Omang
Another refactoring step to prepare for the problem exposed by the test-listen test. This time simplify and reorganize the IPv6 specific extra measures and move it out of the for loop to increase code readability. No semantic changes. Signed-off-by: Knut Omang ---

[Qemu-devel] [PATCH v4 1/4] tests: Add test-listen - a stress test for QEMU socket listen

2017-06-23 Thread Knut Omang
There's a potential race condition between multiple bind()'s attempting to bind to the same port, which occasionally allows more than one bind to succeed against the same port. When a subsequent listen() call is made with the same socket only one will succeed. The current QEMU code does however

Re: [Qemu-devel] [PATCH v3 3/3] migration: add bitmap for received page

2017-06-23 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch adds ability to track down already received > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shared memory

Re: [Qemu-devel] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

2017-06-23 Thread Daniel P. Berrange
On Tue, Jun 20, 2017 at 04:07:49PM +0200, Alberto Garcia wrote: > On Tue 20 Jun 2017 02:02:06 PM CEST, Daniel P. Berrange wrote: > >> > +if (encryptfmt) { > >> > +buf = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT); > >> > +if (buf != NULL) { > >> > +g_free(buf); > >>

Re: [Qemu-devel] [PATCH v9 09/20] qcow: convert QCow to use QCryptoBlock for encryption

2017-06-23 Thread Daniel P. Berrange
On Wed, Jun 21, 2017 at 04:29:02PM +0200, Max Reitz wrote: > On 2017-06-19 19:34, Daniel P. Berrange wrote: > > This converts the qcow driver to make use of the QCryptoBlock > > APIs for encrypting image content. This is only wired up to > > permit use of the legacy QCow encryption format. Users

Re: [Qemu-devel] [PATCH v9 13/20] qcow2: add support for LUKS encryption format

2017-06-23 Thread Daniel P. Berrange
On Wed, Jun 21, 2017 at 04:59:02PM +0200, Max Reitz wrote: > On 2017-06-21 16:46, Max Reitz wrote: > > On 2017-06-21 16:42, Max Reitz wrote: > >> On 2017-06-19 19:34, Daniel P. Berrange wrote: > >>> This adds support for using LUKS as an encryption format > >>> with the qcow2 file, using the new

Re: [Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-23 Thread Marcel Apfelbaum
On 22/06/2017 11:14, Mao Zhongyi wrote: In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- v7: *

Re: [Qemu-devel] [PATCH 07/31] dmg: use DIV_ROUND_UP

2017-06-23 Thread Stefan Hajnoczi
On Thu, Jun 22, 2017 at 02:41:40PM +0200, Marc-André Lureau wrote: > I used the clang-tidy qemu-round check to generate the fix: > https://github.com/elmarco/clang-tools-extra > > Signed-off-by: Marc-André Lureau > --- > block/dmg.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] NVDIMM live migration broken?

2017-06-23 Thread Stefan Hajnoczi
On Fri, Jun 23, 2017 at 08:13:13AM +0800, haozhong.zh...@intel.com wrote: > On 06/22/17 15:08 +0100, Stefan Hajnoczi wrote: > > I tried live migrating a guest with NVDIMM on qemu.git/master (edf8bc984): > > > > $ qemu -M accel=kvm,nvdimm=on -m 1G,slots=4,maxmem=8G -cpu host \ > >

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread Peter Maydell
On 15 June 2017 at 16:15, Edgar E. Iglesias wrote: > On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: >> The difference here is that the clock objects themselves have >> internal state. That's not necessarily a bad idea, but it does >> mean that

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-23 Thread Jean-Philippe Menil
On 06/23/2017 10:43 AM, Jason Wang wrote: On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22, 2017 at 08:15:58AM +0200, jean-philippe menil wrote: 2017-06-06 1:52 GMT+02:00 Michael S. Tsirkin : On Mon, Jun 05, 2017 at 05:08:25AM +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 31/31] eepro100: replace g_malloc()+memcpy() with g_memdup()

2017-06-23 Thread Jason Wang
On 2017年06月22日 21:09, Stefan Weil wrote: Am 22.06.2017 um 14:42 schrieb Marc-André Lureau: I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau --- hw/net/eepro100.c | 3 +-- 1 file

Re: [Qemu-devel] [PULL 0/5] M68k for 2.10 patches

2017-06-23 Thread Peter Maydell
On 21 June 2017 at 22:00, Laurent Vivier wrote: > The following changes since commit 8dfaf23ae1f2273a9730a9b309cc8471269bb524: > > tcg/tci: fix tcg-interpreter build (2017-06-20 18:39:15 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-23 Thread Jason Wang
On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22, 2017 at 08:15:58AM +0200, jean-philippe menil wrote: 2017-06-06 1:52 GMT+02:00 Michael S. Tsirkin : On Mon, Jun 05, 2017 at 05:08:25AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 05, 2017 at

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-23 Thread Jan Beulich
>>> On 22.06.17 at 20:52, wrote: > On Thu, 22 Jun 2017, Jan Beulich wrote: >> >>> On 21.06.17 at 20:46, wrote: >> > On Wed, 21 Jun 2017, Jan Beulich wrote: >> >> >>> On 20.06.17 at 23:48, wrote: >> >> > On Tue, 20 Jun 2017,

Re: [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it

2017-06-23 Thread Kashyap Chamarthy
On Thu, Jun 22, 2017 at 10:13:03AM -0400, John Snow wrote: > On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote: > > On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote: [...] > > Yes, I was thinking of this, too -- just link to the 'bitmaps' document. > > > > A quick side question here:

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

2017-06-23 Thread Mark Cave-Ayland
On 21/06/17 14:23, Eduardo Habkost wrote: > I now have a v7 patchset ready to go (currently hosted at > https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo, > I've currently left off your Tested-by tag since I'm not sure it's still > valid for less-than-trivial

Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h

2017-06-23 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2017 at 19:08, Thomas Huth wrote: >> On 22.06.2017 19:50, Dr. David Alan Gilbert wrote: >>> Could do; I'm just not finding tiny header files with one or >>> two entries each that useful. > > Well, it means that the

Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h

2017-06-23 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2017 at 18:03, Juan Quintela wrote: >> Greg Kurz wrote: >>> On Thu, 22 Jun 2017 17:14:08 +0100 >>> Peter Maydell wrote: >>> On 22 June 2017 at 17:06, Greg Kurz

[Qemu-devel] [PATCH v4 4/4] 9pfs: handle transport errors in pdu_complete()

2017-06-23 Thread Greg Kurz
Contrary to what is written in the comment, a buggy guest can misconfigure the transport buffers and pdu_marshal() may return an error. If this ever happens, it is up to the transport layer to handle the situation (9P is transport agnostic). This fixes Coverity issue CID1348518. Signed-off-by:

[Qemu-devel] [PATCH v4 3/4] virtio-9p: break device if buffers are misconfigured

2017-06-23 Thread Greg Kurz
The 9P protocol is transport agnostic: if the guest misconfigured the buffers, the best we can do is to set the broken flag on the device. Since virtio_pdu_vmarshal() may be called by several active PDUs, we check if the transport isn't broken already to avoid printing extra error messages.

[Qemu-devel] [PATCH v4 2/4] virtio-9p: message header is 7-byte long

2017-06-23 Thread Greg Kurz
The 9p spec at http://man.cat-v.org/plan_9/5/intro reads: "Each 9P message begins with a four-byte size field specify- ing the length in bytes of the complete message including the four bytes of the size field itself. The next byte is the message type, one of the constants in the

[Qemu-devel] [PATCH v4 1/4] virtio-9p: record element after sanity checks

2017-06-23 Thread Greg Kurz
If the guest sends a malformed request, we end up with a dangling pointer in V9fsVirtioState. This doesn't seem to cause any bug, but let's remove this side effect anyway. Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin --- hw/9pfs/virtio-9p-device.c |

[Qemu-devel] [PATCH v4 0/4] 9pfs: handle transport errors

2017-06-23 Thread Greg Kurz
The 9p protocol relies on a reliable transport, but the current code treats transport errors (ie, failure to marshal or unmarshal) as if they were coming from the backend. This doesn't make sense: if the transport failed, we should notify the guest that the transport is broken and needs to be

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-23 Thread Markus Armbruster
Vadim Galitsyn writes: > Hi Markus, > > Thank you for the input. > >> However, your query-memory looks like it could fail. > > With the latest version of a patch ( > http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg03475.html) > "query-memory" can fail

Re: [Qemu-devel] Guest unresponsive after Virtqueue size exceeded error

2017-06-23 Thread Fernando Casas Schössow
Hi Ladi, Small update. Memtest86+ was running on the host for more than 54 hours. 8 passes were completed and no memory errors found. For now I think we can assume that the host memory is ok. I just started all the guests one hour ago. I will monitor them and once one fails I will attach the

[Qemu-devel] [Bug 1047470] Re: qemu/kvm hangs reading from serial console

2017-06-23 Thread Thomas Huth
OK, thanks for your answer! ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1047470 Title: qemu/kvm hangs reading from serial console

<    1   2   3