[Qemu-devel] [PATCH 05/11] block-backup: add reqs_lock

2017-07-06 Thread Paolo Bonzini
Protect the list of inflight reqs and the CoQueues for dependent requests. Signed-off-by: Paolo Bonzini --- block/backup.c | 20 +++- block/replication.c | 2 +- include/block/block_backup.h | 2 +- 3 files changed, 17 insertions(+),

[Qemu-devel] [PATCH 08/11] block: drain I/O around key management

2017-07-06 Thread Paolo Bonzini
The resulting drained section is a replacement for the AioContext. Signed-off-by: Paolo Bonzini --- blockdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index f92dcf24bf..b2c305402d 100644 --- a/blockdev.c +++

[Qemu-devel] [PATCH 06/11] block: add a few more notes on locking

2017-07-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/block/block_int.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 173d9dcaf9..43c9f4fcae 100644 --- a/include/block/block_int.h +++

Re: [Qemu-devel] [PATCH 02/11] block: make write-threshold thread-safe

2017-07-06 Thread Eric Blake
On 07/06/2017 11:38 AM, Paolo Bonzini wrote: > For simplicity, use bdrv_drained_begin/end to avoid concurrent > writes to the write threshold, or reading it while it is being set. > qmp_block_set_write_threshold is protected by the BQL. > > Signed-off-by: Paolo Bonzini > ---

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 10:11 AM, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> >>> On Jul 6, 2017, at 9:56 AM, Paolo Bonzini wrote: >>> >>> >>> >>> On 06/07/2017 18:54, Harris, James R wrote: Hi Michael,

Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Dave Anderson
- Original Message - > Hi > > On Thu, Jul 6, 2017 at 7:13 PM, Laszlo Ersek wrote: > > On 07/06/17 12:16, Marc-André Lureau wrote: > >> kdump header provides offset and size of the vmcoreinfo ELF note, > >> append it if available. > >> > >> Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH 0/3] Add new utility function memory_region_allocate_aux_memory()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 18:26, Peter Maydell wrote: > > I think that to avoid getting tangled up in trying to fix > or deal with these handful of oddball cases at the same time > as doing a global change to the easy cases, we should: > > * globally rename memory_region_init_ram to

Re: [Qemu-devel] [PATCH v4 20/21] block: Minimize raw use of bds->total_sectors

2017-07-06 Thread Eric Blake
On 07/06/2017 11:48 AM, Kevin Wolf wrote: > Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: >> bdrv_is_allocated_above() was relying on intermediate->total_sectors, >> which is a field that can have stale contents depending on the value >> of intermediate->has_variable_length. An audit shows

Re: [Qemu-devel] [PATCH 0/3] Add new utility function memory_region_allocate_aux_memory()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 19:13, Peter Maydell wrote: > Slightly awkward because owner is an Object but vmstate_register_ram() > needs a DeviceState. Is this OK, or too much magic? > > DeviceState *owner_dev; > Error *err = NULL; > > memory_region_init_ram(mr, owner, name, ram_size, ); >

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Alistair Francis
On Thu, Jul 6, 2017 at 7:44 AM, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > >> On Thu, Jul 06, 2017 at 02:20:51PM +0200, Markus Armbruster wrote: >>> "Daniel P. Berrange" writes: >>> >>> > On Thu, Jul 06, 2017 at

[Qemu-devel] [PATCH 04/11] block: make before-write notifiers thread-safe

2017-07-06 Thread Paolo Bonzini
Reads access the list in RCU style, so be careful to avoid use-after-free scenarios in the backup block job. Apart from this, all that's needed is protecting updates with a mutex. Signed-off-by: Paolo Bonzini --- block/backup.c| 17 + block/io.c

[Qemu-devel] [PATCH 01/11] block: prepare write threshold code for thread safety

2017-07-06 Thread Paolo Bonzini
Code refactoring only. Signed-off-by: Paolo Bonzini --- block/write-threshold.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/write-threshold.c b/block/write-threshold.c index 0bd1a01c86..c8ebc32b4d 100644 ---

Re: [Qemu-devel] [PATCH 01/11] block: prepare write threshold code for thread safety

2017-07-06 Thread Eric Blake
On 07/06/2017 11:38 AM, Paolo Bonzini wrote: > Code refactoring only. > > Signed-off-by: Paolo Bonzini > --- > block/write-threshold.c | 28 > 1 file changed, 16 insertions(+), 12 deletions(-) > Reviewed-by: Eric Blake --

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Marc-André Lureau
Hi - Original Message - > > > On Jul 6, 2017, at 9:56 AM, Paolo Bonzini wrote: > > > > > > > > On 06/07/2017 18:54, Harris, James R wrote: > >> Hi Michael, > >> > >> Yes - we (SPDK team at Intel) have this on our TODO list, in addition > >> to a polled mode

Re: [Qemu-devel] [PATCH v5 2/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-06 Thread Kashyap Chamarthy
On Thu, Jul 06, 2017 at 04:36:46PM +0200, Kashyap Chamarthy wrote: > This patch documents (including their QMP invocations) all the four > major kinds of live block operations: [...] > (cherry picked from commit aef3e734f2d30b97e29345943d9e1cab794d0846) Oops, the above "cherry picked" line is

Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch introduces hmp interfaces for the fsdev > devices. > > Signed-off-by: Pradeep Jagadeesh Fails to compile, first error: /work/armbru/qemu/hmp.c: In function ‘hmp_fsdev_set_io_throttle’:

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-07-06 Thread Eduardo Habkost
On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > This series adds a new "persistent" option to > memory-backend-file. The new option it will be useful if > somebody is sharing RAM contents on a file using share=on, but > don't need it to be flushed to disk when QEMU exits. > >

[Qemu-devel] [PATCH v2] Python3 Support for qmp.py

2017-07-06 Thread Ishani Chugh
This patch intends to make qmp.py compatible with both python2 and python3. * Python 3 does not have dict.has_key(key), use key in dict instead * Avoid line-based I/O since Python 2/3 have different character encoding behavior. Explicitly encode/decode JSON UTF-8. * Replace print by print

Re: [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG

2017-07-06 Thread Emilio G. Cota
On Tue, Jul 04, 2017 at 13:12:02 +0200, Paolo Bonzini wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Paolo Bonzini > --- > accel/tcg/translate-all.c | 5 + > hmp-commands-info.hx | 4 > monitor.c | 2 ++ > 3 files

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 6:41 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 21, 2017 at 02:53:33PM +, Felipe Franciosi wrote: >> >>> On 2 Mar 2017, at 21:47, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 02, 2017 at 10:25:49AM -0800, Felipe Franciosi wrote:

Re: [Qemu-devel] [PATCH v4 21/21] block: Make bdrv_is_allocated_above() byte-based

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. In the common case, allocation is unlikely to ever use > values that are not naturally sector-aligned, but it is possible > that byte-based values will let us be

Re: [Qemu-devel] [PATCH 0/3] Add new utility function memory_region_allocate_aux_memory()

2017-07-06 Thread Peter Maydell
On 5 July 2017 at 13:21, Paolo Bonzini wrote: > > > On 04/07/2017 19:02, Peter Maydell wrote: >> Many board models and several devices need to create auxiliary >> regions of RAM (in addition to the main lump of 'system' memory), >> to model static RAMs, video memory, ROMs,

Re: [Qemu-devel] [PATCH v2 7/7] MAINTAINERS: add Dump maintainers

2017-07-06 Thread Laszlo Ersek
On 07/06/17 12:16, Marc-André Lureau wrote: > Proposing myself, since I have some familiarity with the code now. > > Signed-off-by: Marc-André Lureau > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [Qemu-devel] [PATCH v2 6/7] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-06 Thread Laszlo Ersek
On 07/06/17 12:16, Marc-André Lureau wrote: > Add vmcoreinfo ELF note if vmcoreinfo device is ready. > > To help the python script, add a little global vmcoreinfo_gdb > structure, that is populated with vmcoreinfo_gdb_update(). > > Signed-off-by: Marc-André Lureau >

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 10:06 AM, Paolo Bonzini wrote: > > > > On 06/07/2017 19:03, Harris, James R wrote: >> >> vhost-user-blk: >> >> We have an initial implementation in our SPDK QEMU repo. Changpeng Liu >> (added) >> will be sending this to the QEMU mailing list

Re: [Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch introduces qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep

[Qemu-devel] [PATCH 07/11] block: do not acquire AioContext in check_to_replace_node

2017-07-06 Thread Paolo Bonzini
The only caller does it already. Signed-off-by: Paolo Bonzini --- block.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/block.c b/block.c index 694396281b..af0a9a1c22 100644 --- a/block.c +++ b/block.c @@ -4701,23 +4701,19 @@ bool

Re: [Qemu-devel] [PATCH v4 20/21] block: Minimize raw use of bds->total_sectors

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > bdrv_is_allocated_above() was relying on intermediate->total_sectors, > which is a field that can have stale contents depending on the value > of intermediate->has_variable_length. An audit shows that we are safe > (we were first calling

Re: [Qemu-devel] [PATCH v2 4/7] dump: add vmcoreinfo ELF note

2017-07-06 Thread Laszlo Ersek
On 07/06/17 12:16, Marc-André Lureau wrote: > Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo > device provides the location, and write it as an ELF note in the dump. > > There are now 2 possible sources of phys_base information. > > (1) arch guessed value from

Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Laszlo Ersek
On 07/06/17 12:16, Marc-André Lureau wrote: > kdump header provides offset and size of the vmcoreinfo ELF note, > append it if available. > > Signed-off-by: Marc-André Lureau > --- > dump.c | 20 > 1 file changed, 20 insertions(+) > > diff

Re: [Qemu-devel] [PATCH v4 20/21] block: Minimize raw use of bds->total_sectors

2017-07-06 Thread Kevin Wolf
Am 06.07.2017 um 19:03 hat Eric Blake geschrieben: > On 07/06/2017 11:48 AM, Kevin Wolf wrote: > > Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > >> bdrv_is_allocated_above() was relying on intermediate->total_sectors, > >> which is a field that can have stale contents depending on the value

[Qemu-devel] [PATCH v2 1/1] util/aio-win32: Only select on what we are actually waiting for

2017-07-06 Thread Alistair Francis
Signed-off-by: Alistair Francis Acked-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé --- Changes in V2: - Rebase on master Changes since RFC: - Include more bitmasks for the select call util/aio-win32.c | 13

[Qemu-devel] [PATCH 09/11] block/replication: do not acquire AioContext

2017-07-06 Thread Paolo Bonzini
Replication functions are mostly called when the BDS is quiescent and does not have any pending I/O. They do not need to synchronize on anything since BDS and BB are now thread-safe. Signed-off-by: Paolo Bonzini --- block/replication.c | 51

[Qemu-devel] [PATCH] chardev: block during sync read

2017-07-06 Thread Marc-André Lureau
A sync read should block until all requested data is available (instead of retrying in qemu_chr_fe_read_all). Change the channel to blocking during sync_read. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 9:56 AM, Paolo Bonzini wrote: > > > > On 06/07/2017 18:54, Harris, James R wrote: >> Hi Michael, >> >> Yes - we (SPDK team at Intel) have this on our TODO list, in addition >> to a polled mode virtio-scsi driver (akin to the DPDK virtio-net driver

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 19:03, Harris, James R wrote: > > vhost-user-blk: > > We have an initial implementation in our SPDK QEMU repo. Changpeng Liu > (added) > will be sending this to the QEMU mailing list shortly. If you are interested > in viewing it > before it hits the mailing list, you can

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep

Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Laszlo Ersek
On 07/06/17 20:09, Dave Anderson wrote: > > > - Original Message - >> Hi >> >> On Thu, Jul 6, 2017 at 7:13 PM, Laszlo Ersek wrote: >>> On 07/06/17 12:16, Marc-André Lureau wrote: kdump header provides offset and size of the vmcoreinfo ELF note, append it if

Re: [Qemu-devel] [PATCH 6/9] target-mips: Add an MMU mode for ERL

2017-07-06 Thread James Hogan
On Thu, Oct 13, 2016 at 02:18:31PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > The segmentation control feature allows a legacy memory segment to > > become unmapped uncached at error level (according to CP0_Status.ERL), > > and in fact the user segment is already

Re: [Qemu-devel] [PATCH 5/9] target-mips: Abstract mmu_idx from hflags

2017-07-06 Thread James Hogan
On Fri, Oct 07, 2016 at 05:08:46PM +0100, Yongbok Kim wrote: > On 06/09/2016 12:03, James Hogan wrote: > > The MIPS mmu_idx is sometimes calculated from hflags without an env > > pointer available as cpu_mmu_index() requires. > > > > Create a common hflags_mmu_index() for the purpose of this

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 23:37, John Snow wrote: > > On 06/07/2017 02:35 AM, Marc-André Lureau wrote: >> The function does the same initialization, and matches with >> scsi_free_scsi_task() usage, and qemu doesn't need to know the >> allocator details. >> > > Happy month-iversary for this patch! > > Yeah,

Re: [Qemu-devel] [PATCH 7/9] target-mips: Add segmentation control registers

2017-07-06 Thread James Hogan
On Mon, Oct 10, 2016 at 03:57:08PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > The optional segmentation control registers CP0_SegCtl0, CP0_SegCtl1 & > > CP0_SegCtl2 control the behaviour and required privilege of the legacy > > virtual memory segments. > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread Paolo Bonzini
> Drats, backwards compatibility gets me again. > > I guess it should become a comment in the code that explains why we > cannot use the lib function for it? Or take Marc-André's patch and copy the (fixed) function into QEMU. > Tch, just trying to keep backlogged qemu-block patches from

Re: [Qemu-devel] [PATCH 4/9] target-mips: Check memory permissions with mem_idx

2017-07-06 Thread James Hogan
On Fri, Oct 07, 2016 at 04:48:31PM +0100, Yongbok Kim wrote: > On 06/09/2016 12:03, James Hogan wrote: > > diff --git a/target-mips/helper.c b/target-mips/helper.c > > index 29ebf391cb94..2065fc3ec119 100644 > > --- a/target-mips/helper.c > > +++ b/target-mips/helper.c > > @@ -413,11 +413,12 @@

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Auger Eric
Hello Bharat, Jean-Philippe, On 06/07/2017 12:02, Jean-Philippe Brucker wrote: > On 05/07/17 09:49, Bharat Bhushan wrote:>>> Also when setup msi-route > kvm_irqchip_add_msi_route() we needed to >>> provide the translated address. According to my understanding this is required because kernel

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Auger Eric
Hi Bharat, On 06/07/2017 13:24, Bharat Bhushan wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] >> Sent: Thursday, July 06, 2017 3:33 PM >> To: Bharat Bhushan ; Auger Eric >> ;

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread John Snow
On 06/07/2017 02:35 AM, Marc-André Lureau wrote: > The function does the same initialization, and matches with > scsi_free_scsi_task() usage, and qemu doesn't need to know the > allocator details. > Happy month-iversary for this patch! Yeah, uh, we should probably not be reaching into this

[Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Wu, Jiaxin
Hello experts, We know QEMU has the capability to create the multiple network devices in one QEMU guest with the -device syntax. But I met the below failure when I'm trying to create more than 30 virtual devices with the each TAP backend: qemu-system-x86_64: -device e1000: PCI: no

[Qemu-devel] [PULL 4/8] s390x: fix realize inheritance for kvm-flic

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic Commit f6f4ce4211 ("s390x: add property adapter_routes_max_batch", 2016-12-09) introduces a common realize (intended to be common for all the subclasses) for flic, but fails to make sure the kvm-flic which had its own is actually calling this common

[Qemu-devel] [PULL 8/8] hw/s390x/ipl: Fix endianness problem with netboot_start_addr

2017-07-06 Thread Christian Borntraeger
From: Thomas Huth The start address has to be stored in big endian byte order in the iplb.ccw block for the guest. Signed-off-by: Thomas Huth Message-Id: <1499268345-12552-1-git-send-email-th...@redhat.com> Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 5/8] s390x/MAINTAINERS: Update my email address

2017-07-06 Thread Christian Borntraeger
From: Cornelia Huck Signed-off-by: Cornelia Huck Message-Id: <20170704092215.13742-2-coh...@redhat.com> Signed-off-by: Christian Borntraeger --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 3/8] s390x: fix error propagation in kvm-flic's realize

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic >From the moment it was introduced by commit a2875e6f98 ("s390x/kvm: implement floating-interrupt controller device", 2013-07-16) the kvm-flic is not making realize fail properly in case it's impossible to create the KVM device which basically serves

Re: [Qemu-devel] [PATCH v8 4/4] net/socket: Improve -net socket error reporting

2017-07-06 Thread Mao Zhongyi
Hi, Markus On 07/06/2017 03:24 PM, Markus Armbruster wrote: Mao Zhongyi writes: When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=,

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 08:15:54AM +0200, Markus Armbruster wrote: > Alistair Francis writes: > > > This patch converts the existing error_vreport() function into a generic > > qmesg_vreport() function that takes an enum describing the > > information to be reported.

Re: [Qemu-devel] [PATCH v1 0/3] Windows runtime improvements

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/3] Windows runtime improvements Type: series Message-id: cover.1498756113.git.alistair.fran...@xilinx.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information

2017-07-06 Thread Markus Armbruster
Thomas Huth writes: > On 05.07.2017 19:36, Alistair Francis wrote: >> When QEMU is waiting for a TCP socket connection it reports that message as >> an error. This isn't an error it is just information so let's change the >> report to use info_report() instead. >> >>

[Qemu-devel] [PULL 1/8] s390x: vmstatify config migration for virtio-ccw

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibility (extending using subsections) and for fun. To achieve this we need to hack the config_vector, which is VirtIODevice (that is common virtio) state, in the middle of the

[Qemu-devel] [PULL 6/8] s390x: return unavailable features via query-cpu-definitions

2017-07-06 Thread Christian Borntraeger
From: Viktor Mihajlovski The response for query-cpu-definitions didn't include the unavailable-features field, which is used by libvirt to figure out whether a certain cpu model is usable on the host. The unavailable features are now computed by obtaining the host

Re: [Qemu-devel] [PATCH v8 4/4] net/socket: Improve -net socket error reporting

2017-07-06 Thread Markus Armbruster
Mao Zhongyi writes: > When -net socket fails, it first reports a specific error, then > a generic one, like this: > > $ qemu-system-x86_64 -net socket, > qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, > mcast= or udp= is required >

Re: [Qemu-devel] [PATCH] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU

2017-07-06 Thread David Gibson
On Wed, Jul 05, 2017 at 10:49:52AM +0200, Greg Kurz wrote: > When running KVM on POWER, we allow the user to pass "-cpu POWERx" instead > of "-cpu host". This is achieved by patching the ppc_cpu_aliases[] array > so that "POWERx" points to the CPU class with the same PVR as the host CPU. > This

Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Greg Kurz
On Thu, 6 Jul 2017 10:08:41 +0800 Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > obsoletes this one). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that

Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file

2017-07-06 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 05:20:46PM +0100, Daniel P. Berrange wrote: > The content of the backends/trace-events file was entirely > removed in > > commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 > Author: Marc-André Lureau > Date: Mon May 29 12:39:42 2017

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Laszlo Ersek
Hi Jiaxin, it's nice to see a question from you on qemu-devel! :) On 07/06/17 08:20, Wu, Jiaxin wrote: > Hello experts, > > We know QEMU has the capability to create the multiple network devices > in one QEMU guest with the -device syntax. But I met the below failure > when I'm trying to create

Re: [Qemu-devel] [PATCH v8 2/4] net/socket: Convert several helper functions to Error

2017-07-06 Thread Markus Armbruster
Mao Zhongyi writes: > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > net_socket_fd_init() use the function such as fprintf(), perror() to > report an error message. > > Now, convert these functions to Error. > > Cc: jasow...@redhat.com > Cc:

Re: [Qemu-devel] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

2017-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2017 00:46, John Snow wrote: On 07/05/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: 16.02.2017 16:04, Fam Zheng wrote: +dbms->node_name = bdrv_get_node_name(bs); +if (!dbms->node_name || dbms->node_name[0] == '\0') { +dbms->node_name =

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
Hi! Wow, great to see that there is actually now support for handling gUSA in qemu-user on sh4. I wonder whether this will help resolve the lock-up issues on qemu-sh4-user when building Debian packages for sh4. The lockups occur fairly often when any process uses multi-threading. Would this help

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 06:20:54AM +, Wu, Jiaxin wrote: > Hello experts, > > We know QEMU has the capability to create the multiple network devices in one > QEMU guest with the -device syntax. But I met the below failure when I'm > trying to create more than 30 virtual devices with the each

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Laurent Vivier
Le 06/07/2017 à 10:10, John Paul Adrian Glaubitz a écrit : > Hi! > > Wow, great to see that there is actually now support for handling gUSA > in qemu-user on sh4. I wonder whether this will help resolve the > lock-up issues on qemu-sh4-user when building Debian packages for > sh4. > > The

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Markus Armbruster
Alistair Francis writes: > This patch converts the existing error_vreport() function into a generic > qmesg_vreport() function that takes an enum describing the > information to be reported. > > As part of this change a new qmesg_report() function is added as well

[Qemu-devel] [PULL 0/8] s390x/kvm/migration: fixes, enhancements and cleanups

2017-07-06 Thread Christian Borntraeger
/s390x-20170706 for you to fetch changes up to 1045e3cdafaf1218d9f771080ba5c9d4f64346e4: hw/s390x/ipl: Fix endianness problem with netboot_start_addr (2017-07-05 19:46:30 +0200) s390x/kvm/migration: fixes, enhancements

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 00:16, no-re...@patchew.org wrote: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c: In > function ‘virtio_crypto_instance_init’: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c:918:30: > error: passing argument 5 of

Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen()

2017-07-06 Thread Markus Armbruster
Marc-André Lureau writes: > Suggested by Markus Armbruster: Replacing the line above with ... > The gen_ prefix is awkward. Generated C should go through cgen() > exactly once (see commit 1f9a7a1). The common way to get this wrong is > passing a foo=gen_foo()

Re: [Qemu-devel] Managing architectural restrictions with -device and libvirt

2017-07-06 Thread Mark Cave-Ayland
On 05/07/17 19:05, Markus Armbruster wrote: >> It seems like limiting the size of the bus would solve the majority of >> the problem. I've had a quick look around pci.c and while I can see that >> the PCIBus creation functions take a devfn_min parameter, I can't see >> anything that limits the

Re: [Qemu-devel] [PATCH] vnc: Set default kbd delay to 10ms

2017-07-06 Thread Alexander Graf
On 05.07.17 10:42, Markus Armbruster wrote: Alexander Graf writes: The default keyboard delay time in the input layer is 10ms. I don't know Do you mean "is 1ms"? Yes, of course :). Sorry. Alex how that number came to be, but empirical tests on some OpenQA driven ARM

[Qemu-devel] [Bug 1702621] [NEW] colo: secondary vm crash during loadvm

2017-07-06 Thread pork-prince
Public bug reported: Following document 'COLO-FT.txt', I test colo feature on my hosts. It seems goes well. But after a while the secondary vm crash. The stack is as follows: #0 0x7f191456dc37 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x7f1914571028 in abort () from

[Qemu-devel] [PULL 2/8] s390x/3270: fix instruction interception handler

2017-07-06 Thread Christian Borntraeger
From: Dong Jia Shi Commit bab482d7405f ("s390x/css: ccw translation infrastructure") introduced instruction interception handler for different types of subchannels. For emulated 3270 devices, we should assign the virtual subchannel handler to them during device

[Qemu-devel] [PULL 7/8] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-06 Thread Christian Borntraeger
From: QingFeng Hao This patch is based on a similar patch from Stefan Hajnoczi - commit c324fd0a39c ("virtio-pci: use ioeventfd even when KVM is disabled") Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit

[Qemu-devel] [Bug 1702621] Re: colo: secondary vm crash during loadvm

2017-07-06 Thread pork-prince
The qemu version is 2.9.0 release. The 'irq_count' and 'irq_state' are sent by private vm, and loaded by secondary vm. When they sent by private vm, they maybe not in a consistent state. So sometimes 'bus->irq_count[i]' becomes '-1' on secondary vm. I deleted the assertions and then tested it

Re: [Qemu-devel] [PATCH] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU

2017-07-06 Thread Greg Kurz
On Thu, 6 Jul 2017 17:32:33 +1000 David Gibson wrote: > On Wed, Jul 05, 2017 at 10:49:52AM +0200, Greg Kurz wrote: > > When running KVM on POWER, we allow the user to pass "-cpu POWERx" instead > > of "-cpu host". This is achieved by patching the ppc_cpu_aliases[]

Re: [Qemu-devel] [PATCH] hmp: Update info vnc

2017-07-06 Thread Daniel P. Berrange
On Wed, Jul 05, 2017 at 05:33:24PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Jul 05, 2017 at 03:43:02PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The QMP

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-06 Thread Stefan Hajnoczi
On Mon, Jul 03, 2017 at 01:40:57PM -0500, Eric Blake wrote: > On 07/03/2017 10:56 AM, Eric Blake wrote: > > On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote: > >> The following functions fail if bs->drv does not implement them: > > One other suggestion: most patches in the tree use 'topic:

Re: [Qemu-devel] [PATCH 1/3] include/hw/boards.h: Document memory_region_allocate_system_memory()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 05:18, Philippe Mathieu-Daudé wrote: > Hi Peter, Paolo, > > On 07/04/2017 02:02 PM, Peter Maydell wrote: >> Add a documentation comment for memory_region_allocate_system_memory(). >> >> In particular, the reason for this function's existence and the >> requirement on board code to

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-06 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 09:43:18PM +0300, Manos Pitsidianakis wrote: > diff --git a/block.c b/block.c > index 69439628..9e8d34ad 100644 > --- a/block.c > +++ b/block.c > @@ -494,6 +494,8 @@ int bdrv_probe_blocksizes(BlockDriverState *bs, > BlockSizes *bsz) > > if (drv &&

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Jean-Philippe Brucker
On 05/07/17 09:49, Bharat Bhushan wrote:>>> Also when setup msi-route kvm_irqchip_add_msi_route() we needed to >> provide the translated address. >>> According to my understanding this is required because kernel does no go >> through viommu translation when generating interrupt, no? >> >> yes this

[Qemu-devel] [PATCH v2 2/7] acpi: add vmcoreinfo device

2017-07-06 Thread Marc-André Lureau
The VM coreinfo (vmcoreinfo) device is an emulated device which exposes a 4k memory range to the guest to store various informations useful to debug the guest OS. (it is greatly inspired by the VMGENID device implementation) This is an early-boot alternative to the qemu-ga VMDUMP_INFO event

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Daniel P. Berrange
On Wed, Jul 05, 2017 at 08:22:00PM +0800, Fam Zheng wrote: > On Wed, 07/05 13:58, Thomas Huth wrote: > > On 05.07.2017 13:44, Fam Zheng wrote: > > > On Wed, 07/05 12:04, Daniel P. Berrange wrote: > > >> While you can say people should just add '-M pc' that isn't a nice > > >> user experiance,

Re: [Qemu-devel] [PATCH v4 11/21] mirror: Switch mirror_cow_align() to byte-based

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > function (no semantic change), and add mirror_clip_bytes() as a > counterpart to mirror_clip_sectors().

Re: [Qemu-devel] Managing architectural restrictions with -device and libvirt

2017-07-06 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 05/07/2017 21:05, Markus Armbruster wrote: >> Mark Cave-Ayland writes: [...] >>> It seems like limiting the size of the bus would solve the majority of >>> the problem. I've had a quick look around pci.c and while I

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add location comment for generated types

2017-07-06 Thread Markus Armbruster
Marc-André Lureau writes: > This may help to find where the origin of the type was declared in the > json (when greping isn't easy enough). > > Generates the following kind of C comment before types: > > /* /home/elmarco/src/qemu/qapi/introspect.json:94 */ >

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
On Thu, Jul 06, 2017 at 10:35:15AM +0200, Laurent Vivier wrote: > I think it would be interesting if you generate a qemu binary with it > and use it in your buildds to test it. > > I guess the series can be pulled directly from Richard's branch: > > git://github.com/rth7680/qemu.git tgt-sh4

Re: [Qemu-devel] [PATCH 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Marc-André Lureau
Hi On Wed, Jul 5, 2017 at 2:07 AM, Laszlo Ersek wrote: > On 06/29/17 15:23, Marc-André Lureau wrote: >> kdump header provides offset and size of the vmcoreinfo ELF note, >> append it if available. >> >> Signed-off-by: Marc-André Lureau >> --- >>

Re: [Qemu-devel] [PATCH v2] hmp: Update info vnc

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 10:55:45AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The QMP query-vnc interfaces have gained a lot more information that > the HMP interfaces hasn't got yet. Update it. > > Note the output format has changed,

[Qemu-devel] [PATCH v2 3/7] tests: add simple vmcoreinfo test

2017-07-06 Thread Marc-André Lureau
This test is based off vmgenid test from Ben Warren . It simply checks the vmcoreinfo ACPI device is present and that the memory region associated can be read. Signed-off-by: Marc-André Lureau --- tests/vmcoreinfo-test.c | 130

Re: [Qemu-devel] [PATCH v4 04/21] stream: Drop reached_end for stream_complete()

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > stream_complete() skips the work of rewriting the backing file if > the job was cancelled, if data->reached_end is false, or if there > was an error detected (non-zero data->ret) during the streaming. > But note that in stream_run(),

Re: [Qemu-devel] [PULL 00/42] Misc changes for 2017-07-05

2017-07-06 Thread Peter Maydell
On 5 July 2017 at 08:14, Paolo Bonzini wrote: > The following changes since commit 0c7a8b9baa744ae4323bb46cb4fe942355beaa85: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-07-04 11:17:02 +0100) > > are available in the git repository

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 01:00:53PM +0200, Thomas Huth wrote: > On 06.07.2017 12:49, Daniel P. Berrange wrote: > [...] > > This avoids the user having problems with guest ABI silently changing > > behind their back, or migration suddenly failing to load vm state, > > For proper migration, you've

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Jul 06, 2017 at 01:00:53PM +0200, Thomas Huth wrote: > > On 06.07.2017 12:49, Daniel P. Berrange wrote: > > [...] > > > This avoids the user having problems with guest ABI silently changing > > > behind their back, or migration suddenly

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Bharat Bhushan
> -Original Message- > From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > Sent: Thursday, July 06, 2017 3:33 PM > To: Bharat Bhushan ; Auger Eric > ; eric.auger@gmail.com; > peter.mayd...@linaro.org;

Re: [Qemu-devel] Managing architectural restrictions with -device and libvirt

2017-07-06 Thread Marcel Apfelbaum
On 05/07/2017 21:05, Markus Armbruster wrote: Mark Cave-Ayland writes: On 05/07/17 16:46, Markus Armbruster wrote: I've been working on a patchset that brings the sun4u machine on qemu-system-sparc64 much closer to a real Ultra 5, however due to various design

Re: [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 10:45, Vladimir Sementsov-Ogievskiy wrote: >>> +do_nbd_trip_read(uint32_t len) "Read %" PRIu32" byte(s)" >> This one is good. > > why do you like this and do not like nbd_trip_write_zeros? I'm not sure I understand: this one is after blk_pread returns. It tells you that the

  1   2   3   4   >