Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vm startup

2017-07-25 Thread Paolo Bonzini
On 25/07/2017 06:14, peng.h...@zte.com.cn wrote: >> On 24/07/2017 20:35, Peng Hao wrote: > > > > > >>> When a windows vm starts, periodic timer of rtc will stop several times. >>> windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt >>> flags will not be cleared when

Re: [Qemu-devel] [PATCH for 2.10 27/35] syscall: fix dereference of undefined pointer

2017-07-25 Thread Laurent Vivier
Le 24/07/2017 à 23:26, Peter Maydell a écrit : > On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote: >> Clang's scan-build-5.0 reports: >> >> linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value >> if (*host_rt_dev_ptr != 0) { >>

Re: [Qemu-devel] [PATCH] migration: optimize the downtime

2017-07-25 Thread Jay Zhou
On 2017/7/25 0:33, Paolo Bonzini wrote: On 24/07/2017 17:35, Dr. David Alan Gilbert wrote: * Jay Zhou (jianjay.z...@huawei.com) wrote: Hi Dave, On 2017/7/21 17:49, Dr. David Alan Gilbert wrote: * Jay Zhou (jianjay.z...@huawei.com) wrote: Qemu_savevm_state_cleanup() takes about 300ms in my

[Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets

2017-07-25 Thread Philippe Mathieu-Daudé
Useful to build a whole set at once. Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5f18243d05..da899522e4 100644 --- a/Makefile +++ b/Makefile @@ -814,6 +814,11 @@ endif #

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-25 Thread Philippe Mathieu-Daudé
On Tue, Jul 25, 2017 at 3:13 AM, Lukáš Doktor wrote: > Dne 25.7.2017 v 08:04 Philippe Mathieu-Daudé napsal(a): >> Hi Lukáš, >> >> On 07/24/2017 09:36 AM, Lukáš Doktor wrote: >>> Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a): Hi Lukáš, Since

Re: [Qemu-devel] virtio-net-pci possible limitation on AArch64

2017-07-25 Thread Andrew Jones
On Tue, Jul 25, 2017 at 12:38:52AM +, Alexandru Avadanii wrote: > Hi, Andrew, > I tried rebuilding virtinst (1.3.2), but that made no difference. > > However, changing "model=virtio-net-pci" to simply "model=virtio" (and > letting the default kick in via libvirt) > made a whole lot of

Re: [Qemu-devel] [PATCH 3/4] target/s390x: Use unwind info in STSI

2017-07-25 Thread David Hildenbrand
On 25.07.2017 04:36, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/misc_helper.c | 3 ++- > target/s390x/translate.c | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/s390x/misc_helper.c

Re: [Qemu-devel] [PATCH for 2.10 14/35] vfio/ccw: fix incorrect malloc() size

2017-07-25 Thread Cornelia Huck
On Mon, 24 Jul 2017 15:27:30 -0300 Philippe Mathieu-Daudé wrote: > Since sizeof(struct vfio_irq_info) < sizeof(struct vfio_irq_set) a heap > overflow > never occured. Still, let's use the correct size. > > hw/vfio/ccw.c:170:16: warning: Cast a region whose size is not a

Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix ilen in IO instruction handlers

2017-07-25 Thread Cornelia Huck
On Mon, 24 Jul 2017 16:34:52 +0200 Halil Pasic wrote: > When initiating a program check interruption by calling program_interrupt > the instruction length (ilen) of the current instruction is supplied as > the third parameter. > > On s390x all the IO instructions are

Re: [Qemu-devel] [PATCH v6 8/8] tpm: Added support for TPM emulator

2017-07-25 Thread Stefan Berger
On 07/18/2017 04:49 AM, Amarnath Valluri wrote: diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs index 64cecc3..41f0b7a 100644 --- a/hw/tpm/Makefile.objs +++ b/hw/tpm/Makefile.objs @@ -1,2 +1,3 @@ common-obj-$(CONFIG_TPM_TIS) += tpm_tis.o common-obj-$(CONFIG_TPM_PASSTHROUGH) +=

Re: [Qemu-devel] Improving QMP test coverage

2017-07-25 Thread Cleber Rosa
On 07/24/2017 02:56 AM, Markus Armbruster wrote: > Test code language is orthogonal to verification method (with code > vs. with diff). Except verifying with shell code would be obviously > nuts[*]. > > The existing iotests written in Python verify with code, and the ones > written in shell

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
Hi Michael, On 07/25/2017 08:03 PM, Michael Roth wrote: Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubran:

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windowsvmstartup

2017-07-25 Thread peng.hao2
>On 25/07/2017 11:29, peng.h...@zte.com.cn wrote: >>>On 25/07/2017 06:14, peng.h...@zte.com.cn wrote: >> > On 24/07/2017 20:35, Peng Hao wrote: >> When a windows vm starts, periodic timer of rtc will stop several times. >> windows kernel will check whether REG_A_UIP

Re: [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled

2017-07-25 Thread Philippe Mathieu-Daudé
Hi Peter, I think this patch belongs to 2.10, as there is no time to fix TCI + MTTCG. Should I RESEND it alone with "for 2.10" subject? One other option might be disable TCI if MTTCG enabled, but there is no ./configure option for MTTCG while there is for TCI. Regards, Phil. On

Re: [Qemu-devel] [PATCH 2/4] rtc-test: introduce more update tests

2017-07-25 Thread Philippe Mathieu-Daudé
On 07/25/2017 10:48 AM, Paolo Bonzini wrote: Test divider reset and UIP behavior. Signed-off-by: Paolo Bonzini --- tests/rtc-test.c | 82 +++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/2] Introduce a new vhost-user-blk device and sample application

2017-07-25 Thread Changpeng Liu
Since vhost-user-scsi device has been part of Qemu, many users are still using old virtio_blk device in Guest OS, compared with vhost-user-scsi, vhost-user-blk can get better performance, because eliminate one SCSI_MOD kernel module. This patch provides another option for uses to implement their

[Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-25 Thread Changpeng Liu
This commit introduces a vhost-user device for block, it uses a chardev to connect to the backend, Same with virito_blk, Guest OS still uses the virtio_blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev

[Qemu-devel] [PATCH 2/2] vhost-user-blk: introduce a vhost-user-blk sample application

2017-07-25 Thread Changpeng Liu
This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s

[Qemu-devel] [PATCH for-2.10] qemu-img: Sort sub-command names in --help

2017-07-25 Thread Eric Blake
'amend' was the only sub-command not listed alphabetically; hoist it earlier, and separate the @end table block to make it easier to copy-and-paste the addition of future sub-commands. Signed-off-by: Eric Blake --- qemu-img-cmds.hx | 9 ++--- 1 file changed, 6

<    1   2   3   4   5