[Qemu-devel] [PATCH v2 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-08-09 Thread Changpeng Liu
Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration for vhost user devices, also vhost user devices can benifit from the messages to get/set virtio config space from/to the I/O target besides Qemu. For the purpose to support virtio config space change,

[Qemu-devel] [PATCH v2 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-08-09 Thread Changpeng Liu
This commit introduces a new vhost-user device for block, it uses a chardev to connect with the backend, same with Qemu virito-blk device, Guest OS still uses the virtio-blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev

[Qemu-devel] [PATCH v2 0/4] *** Introduce a new vhost-user-blk host device to Qemu ***

2017-08-09 Thread Changpeng Liu
Althrough virtio scsi specification was designed as a replacement for virtio_blk, there are still many users using virtio_blk. Qemu 2.9 introduced a new device vhost user scsi which can process I/O in user space for virtio_scsi, this commit introduces a new vhost user block host device, which can

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:47:18 +0100 Peter Maydell wrote: > On 9 August 2017 at 10:07, Thomas Huth wrote: > > While virtio-pci and virtio-ccw seem to require separate dedicated > > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Greg Kurz
On Wed, 9 Aug 2017 10:27:37 +0200 Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > > > On 09.08.2017 09:17, Cornelia Huck wrote: > > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > > on

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Peter Maydell
On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > virtio-mmio seems to work different. As far as I can see, there are no > dedicated

Re: [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-09 Thread Stefan Hajnoczi
On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote: > Both the throttling limits set with the throttling.iops-* and > throttling.bps-* options and their QMP equivalents defined in the > BlockIOThrottle struct are integer values. > > Those limits are also reported in the

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Peter Maydell
On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, You don't *have* to use the dedicated virtio-foo-pci device; if you like you can manually plug

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:24:13 +0100 "Daniel P. Berrange" wrote: > On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > > On 09.08.2017 10:27, Cornelia Huck wrote: > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > > Thomas Huth wrote: > > > > > >> On

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

2017-08-09 Thread Manos Pitsidianakis
On Tue, Aug 08, 2017 at 05:04:48PM +0200, Alberto Garcia wrote: On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote: So basically if we have anonymous groups, we accept limits in the driver options but only without a group-name. In the commit message you do however have limits and

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] IDE: test flush on empty CDROM

2017-08-09 Thread Stefan Hajnoczi
On Tue, Aug 08, 2017 at 01:57:09PM -0400, John Snow wrote: > From: Kevin Wolf > > Signed-off-by: Kevin Wolf > Signed-off-by: John Snow > --- > tests/ide-test.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by:

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] IDE: Do not flush empty CDROM drives

2017-08-09 Thread Stefan Hajnoczi
On Tue, Aug 08, 2017 at 01:57:08PM -0400, John Snow wrote: > The block backend changed in a way that flushing empty CDROM drives > is now an error. Amend IDE to avoid doing so until the root problem > can be addressed for 2.11. > > Reported-by: Kieron Shorrock >

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 11:18:33 +0200 Thomas Huth wrote: > On 09.08.2017 11:05, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 06:59:37 +0200 > > Thomas Huth wrote: > >> @@ -80,16 +81,26 @@ int boot_sector_init(char *fname) > >> return 1; > >> } > >>

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Daniel P. Berrange
On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-09 Thread Thomas Huth
On 09.08.2017 11:05, Cornelia Huck wrote: > On Wed, 9 Aug 2017 06:59:37 +0200 > Thomas Huth wrote: > >> Re-using the boot_sector code buffer from x86 for other architectures >> is not very nice, especially if we add more architectures later. It's >> also ugly that the test

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-09 Thread Stefan Hajnoczi
On Tue, Aug 08, 2017 at 05:39:31PM -0300, Eduardo Habkost wrote: > It makes command-line parsing and generation of help text much > simpler. > > The optparse module is deprecated since Python 2.7, but argparse > is not available in Python 2.6 (the minimum Python version > required for building

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-09 Thread Stefan Hajnoczi
On Tue, Aug 08, 2017 at 05:39:34PM -0300, Eduardo Habkost wrote: > This is useful for testing QMP commands in scripts. > > Example usage, combined with 'jq' for filtering the results: > > $ ./scripts/qmp/qmp-shell /tmp/qmp qom-list path=/ | jq -r .return[].name > machine > type >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 11:07:38 +0200 Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends

Re: [Qemu-devel] [PATCH 2/2] tests/pxe: Check virtio-net-ccw on s390x

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 06:59:38 +0200 Thomas Huth wrote: > Now that we've got a firmware that can do TFTP booting on s390x (i.e. > the pc-bios/s390-netboot.img), we can enable the PXE tester for this > architecture, too. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Thomas Huth
On 09.08.2017 10:27, Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > >> On 09.08.2017 09:17, Cornelia Huck wrote: >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend >>> on CONFIG_VIRTFS and on the presence of an appropriate

Re: [Qemu-devel] [PATCH v4 07/22] numa-test: Use hmp()

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > Don't open-code something that has a convenient helper available. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > We want -Wformat to catch blatant programming errors in format > strings that we pass to qobject_from_jsonf(). But if someone > were to pass a JSON string "'%s'" as the format string, gcc would > insist that it be paired with a char* argument, even though

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 06:59:37 +0200 Thomas Huth wrote: > Re-using the boot_sector code buffer from x86 for other architectures > is not very nice, especially if we add more architectures later. It's > also ugly that the test uses a huge pre-initialized array - the size > of the

Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Cédric Le Goater
On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > This is required to configure differences in behaviour between the > AST2400 and AST2500 watchdog IPs. > > Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater > --- > hw/arm/aspeed_soc.c | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

2017-08-09 Thread Cédric Le Goater
On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > The reset width register controls how the pulse on the SoC's WDTRST{1,2} > pins behaves. A pulse is emitted if the external reset bit is set in > WDT_CTRL. On the AST2500 WDT_RESET_WIDTH can consume magic bit patterns > to configure

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Thomas Huth
On 09.08.2017 09:17, Cornelia Huck wrote: > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > device. > > Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for > CONFIG_VIRTFS &&

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:23:04 +0200 Thomas Huth wrote: > On 09.08.2017 09:17, Cornelia Huck wrote: > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > > device. > > > > Let's

Re: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-09 Thread Jens Freimann
On Wed, Aug 09, 2017 at 04:17:05AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 08, 2017 at 04:59:02PM -0700, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Peter Xu
On Wed, Aug 09, 2017 at 10:05:19AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > >> Peter Xu wrote: > >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > >> > > >> > [...]

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-09 Thread Peter Xu
On Tue, Aug 08, 2017 at 11:19:35AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > > > > [...] > > > >> int multifd_load_setup(void) > >> { > >> int thread_count; > >> -uint8_t i; > >> > >> if

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Juan Quintela
Peter Xu wrote: > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: >> > >> > [...] >> > >> >> static int multifd_send_page(uint8_t *address) >> >> { >> >>

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > qobject_from_jsonv() was unusual in that it took a va_list*, instead > of the more typical va_list; this was so that callers could pass > NULL to avoid % interpolation. While this works under the hood, it > is awkward for callers, so move the magic into

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > > > > [...] > > > >> static int multifd_send_page(uint8_t *address) > >> { > >> -int i; > >> +int i, j; > >>

Re: [Qemu-devel] [PATCH v5 10/17] migration: Create ram_multifd_page

2017-08-09 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:04:54PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jul 19, 2017 at 08:02:39PM +0100, Dr. David Alan Gilbert wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > > >> > struct MultiFDSendParams { > >> > +/* not changed */ >

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-09 Thread Greg Kurz
On Tue, 8 Aug 2017 14:14:18 -0500 Eric Blake wrote: > On 08/08/2017 12:28 PM, Greg Kurz wrote: > > This function has to ensure it doesn't follow a symlink that could be used > > to escape the virtfs directory. This could be easily achieved if fchmodat() > > on linux honored

Re: [Qemu-devel] Qemu and 32 PCIe devices

2017-08-09 Thread Paolo Bonzini
On 09/08/2017 03:06, Laszlo Ersek wrote: >> 20.14% qemu-system-x86_64 [.] render_memory_region >> 17.14% qemu-system-x86_64 [.] subpage_register >> 10.31% qemu-system-x86_64 [.] int128_add >>7.86% qemu-system-x86_64

Re: [Qemu-devel] [PATCH for-2.11 0/4] ppc64: add e6500

2017-08-09 Thread David Gibson
On Mon, Aug 07, 2017 at 05:50:44PM +0200, KONRAD Frederic wrote: > Hi, > > Those are some patches to add basic e6500 support for the moment e5500 with a > correct MMU configuration and supported instructions. > Some (maybe a lot of) things are missing (ie: the thread support) but it is > enough

Re: [Qemu-devel] [PATCH v3 1/1] ppc: spapr: Make VCPU ID handling private to SPAPR

2017-08-09 Thread David Gibson
On Wed, Aug 09, 2017 at 03:38:56PM +1000, Sam Bobroff wrote: > The concept of a VCPU ID that differs from the CPU's index > (cpu->cpu_index) exists only within SPAPR machines so, move the > functions ppc_get_vcpu_id() and ppc_get_cpu_by_vcpu_id() into spapr.c > and rename them appropriately. > >

[Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend on CONFIG_VIRTFS and on the presence of an appropriate virtio transport device. Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for CONFIG_VIRTFS && (CONFIG_VIRTIO_PCI || CONFIG_VIRTIO_CCW). Signed-off-by: Cornelia

Re: [Qemu-devel] [PATCH v4 04/22] tests: Add assertion for no qmp("")

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > Now that the previous patches have fixed all callers to avoid an > empty message, we can tweak qmp_fd_sendv() to assert that we > don't introduce new callers, and reindent accordingly. The > additional assertions will also help verify that later

[Qemu-devel] [PULL 6/6] spapr: Fix bug in h_signal_sys_reset()

2017-08-09 Thread David Gibson
From: Sam Bobroff The unicast case in h_signal_sys_reset() seems to be broken: rather than selecting the target CPU, it looks like it will pick either the first CPU or fail to find one at all. Fix it by using the search function rather than open coding the search. This

[Qemu-devel] [PULL 5/6] spapr_drc: abort if object_property_add_child() fails

2017-08-09 Thread David Gibson
From: Greg Kurz object_property_add_child() can only fail in two cases: - the child already has a parent, which shouldn't happen since the DRC was allocated a few lines above - the parent already has a child with the same name, which would mean the caller tries to create a

[Qemu-devel] [PULL 1/6] booke206: fix MAS update on tlb miss

2017-08-09 Thread David Gibson
From: KONRAD Frederic When a tlb instruction miss happen, rw is set to 0 at the bottom of cpu_ppc_handle_mmu_fault which cause the MAS update function to miss the SAS and TS bit in MAS6, MAS1 in booke206_update_mas_tlb_miss. Just calling booke206_update_mas_tlb_miss

[Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-09 Thread David Gibson
The following changes since commit 54affb3a3623b1d36c95e34faa722a5831323a74: Update version for v2.10.0-rc2 release (2017-08-08 19:07:46 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170809 for you to fetch changes up

[Qemu-devel] [PULL 2/6] ppc: fix double-free in cpu_post_load()

2017-08-09 Thread David Gibson
From: Greg Kurz When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes because of "double free or corruption (!prev)". The crash happens because error_report_err() has already called error_free(). Signed-off-by: Greg Kurz Reviewed-by: Eric

[Qemu-devel] [PULL 3/6] target/ppc: Implement TIDR

2017-08-09 Thread David Gibson
This adds a trivial implementation of the TIDR register added in POWER9. This isn't particularly important to qemu directly - it's used by accelerator modules that we don't emulate. However, since qemu isn't aware of it, its state is not synchronized with KVM and therefore not migrated, which

[Qemu-devel] [PULL 4/6] target/ppc: Add stub implementation of the PSSCR

2017-08-09 Thread David Gibson
The PSSCR register added in POWER9 controls certain power saving mode behaviours. Mostly, it's not relevant to TCG, however because qemu doesn't know about it yet, it doesn't synchronize the state with KVM, and thus it doesn't get migrated. To fix that, this adds a minimal stub implementation of

[Qemu-devel] [Bug 1357175] Re: qemu fails to build on powerpc64

2017-08-09 Thread Thomas Huth
OK, thanks for checking! ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1357175 Title: qemu fails to build on powerpc64 Status in

Re: [Qemu-devel] [PATCH] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 07:12:51 +0200 Thomas Huth wrote: > On 08.08.2017 18:26, Greg Kurz wrote: > > On Tue, 8 Aug 2017 17:38:27 +0200 > > Cornelia Huck wrote: > > > >> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > >> on

Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Andrew Jeffery
Ugh, disregard this one; I changed the subject and reissued `git format-patch`, which naturally doesn't overwrite any existing patch in the output directory and so the old one got sent as well. Andrew On Wed, 2017-08-09 at 15:58 +0930, Andrew Jeffery wrote: > This is required to configure

[Qemu-devel] [PATCH for 2.11 v2 2/2] aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Andrew Jeffery
This is required to configure differences in behaviour between the AST2400 and AST2500 watchdog IPs. Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index

[Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

2017-08-09 Thread Andrew Jeffery
The reset width register controls how the pulse on the SoC's WDTRST{1,2} pins behaves. A pulse is emitted if the external reset bit is set in WDT_CTRL. On the AST2500 WDT_RESET_WIDTH can consume magic bit patterns to configure push-pull/open-drain and active-high/active-low behaviours and thus

[Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

2017-08-09 Thread Andrew Jeffery
This is required to configure differences in behaviour between the AST2400 and AST2500 watchdog IPs. Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index

[Qemu-devel] [PATCH for 2.11 v2 0/2] wdt_aspeed: Support reset width patterns

2017-08-09 Thread Andrew Jeffery
Hello, These two patches add support for the reset width configuration register in the Aspeed watchdog. Initially this was just one patch[1], but I've reworked it as two to explicitly support the varying capabilities between Aspeed SoC versions. Andrew [1]

Re: [Qemu-devel] [RFC PATCH 32/56] hmp: Make block_set_io_throttle's arguments unsigned

2017-08-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The previous commit made them unsigned in QMP. Switch HMP's args_type >> from 'l' to 'o'. Loses support for expressions (QEMU pocket >> calculator), gains support for unit suffixes.

Re: [Qemu-devel] [RFC PATCH 27/56] block/dirty-bitmap: Clean up signed vs. unsigned dirty counts

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > On 08/07/2017 09:45 AM, Markus Armbruster wrote: >> hbitmap_count() returns uint64_t. >> >> Clean up test-hbitmap.c to check its value with g_assert_cmpuint() >> instead of g_assert_cmpint(). >> >> bdrv_get_dirty_count() and bdrv_get_meta_dirty_count()

Re: [Qemu-devel] [RFC PATCH 10/56] hmp: Make balloon's argument unsigned

2017-08-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The previous commit made it unsigned in QMP. Switch HMP's args_type >> from 'M' to 'o'. Loses support for expressions (QEMU pocket >> calculator), gains support for units other than

Re: [Qemu-devel] [RFC PATCH 09/56] balloon: Make balloon size unsigned in QAPI/QMP

2017-08-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Sizes should use QAPI type 'size' (uint64_t). balloon parameter >> @value is 'int' (int64_t). qmp_balloon() implicitly converts to >> ram_addr_t, i.e. uint64_t. BALLOON_CHANGE parameter

Re: [Qemu-devel] [RFC PATCH 03/56] monitor: Rewrite comment describing HMP .args_type

2017-08-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> Signed-off-by: Markus Armbruster >> >> --- >> >>

<    1   2   3