Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > +Most of the commands require the Big QEMU Lock (BQL) be held during > > > +execution. However, there is a small subset of the commands that may > > > +not really

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > Each address_space_init() updates topology for _every_ address space. And finally, does this patch help with the above? diff --git a/memory.c b/memory.c index c0adc35..97c16cc 100644 --- a/memory.c +++ b/memory.c @@ -2607,10 +2607,16 @@ void

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > > Interestingly, mem_add() from exec.c is called twice: > as as->dispatch_listener.region_add() and > as as->dispatch_listener.region_nop() - I did not understand > the trick but it does not work if I remove the .region_nop() hook. > How does it

Re: [Qemu-devel] [PATCH v3 06/10] tests: Add NetBSD image

2017-08-25 Thread Fam Zheng
On Thu, 08/24 11:37, Cleber Rosa wrote: > > > On 08/22/2017 12:41 AM, Fam Zheng wrote: > > The image is prepared following instructions as in: > > > > https://wiki.qemu.org/Hosts/BSD > > > > Signed-off-by: Fam Zheng > > Reviewed-by: Kamil Rytarowski > > --- > >

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Paolo Bonzini
On 25/08/2017 10:31, Alexey Kardashevskiy wrote: > Otherwise old dispatch holds way too much memory before RCU gets > a chance to free old dispatches. > > Signed-off-by: Alexey Kardashevskiy > --- > > This is a follow-up to the "Memory use with >100 virtio devices" > thread. >

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-25 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 03:32:29PM +0800, Fam Zheng wrote: > On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > > Tests should declare resources upfront in a with statement. Resources

[Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-25 Thread Alexey Kardashevskiy
Otherwise old dispatch holds way too much memory before RCU gets a chance to free old dispatches. Signed-off-by: Alexey Kardashevskiy --- This is a follow-up to the "Memory use with >100 virtio devices" thread. I assume this is a dirty hack (which fixes the problem though) and

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Cornelia Huck
On Fri, 25 Aug 2017 10:21:58 +0200 Christian Borntraeger wrote: > On 08/25/2017 09:20 AM, Cornelia Huck wrote: > > OK, to recap: > > > > - the current pre-built bios seems fine > > - rebuilding the bios may yield a version that fails on some systems > > (different

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Christian Borntraeger
On 08/25/2017 09:20 AM, Cornelia Huck wrote: > On Thu, 24 Aug 2017 20:14:06 +0200 > Christian Borntraeger wrote: > >> On 08/24/2017 07:38 PM, Farhan Ali wrote: >>> >>> >>> On 08/24/2017 12:07 PM, Peter Maydell wrote: On 24 August 2017 at 16:53, Farhan Ali

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Thomas Huth
On 25.08.2017 08:31, Sam wrote: > Hi all, > > I'm starting vm using: > > kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 -cdrom >> CentOS-7-x86_64-DVD-1503-01.iso -boot d >> VNC server running on '127.0.0.1:5900' > > then I start vnc client in another PC to connect

Re: [Qemu-devel] [PATCH for-2.11 v3 01/25] qom: cpu: fix parsed feature string length

2017-08-25 Thread Igor Mammedov
On Thu, 24 Aug 2017 14:00:21 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 08/24/2017 01:31 PM, Igor Mammedov wrote: > > since commit ( 9262685b cpu: Factor out cpu_generic_init() ) > > features parsed by it were truncated only to the 1st feature > > after CPU name due

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:22:03 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > > Caching there practically doesn't give any benefits > > and that at slow path druring querying supported CPU list. > > But it introduces non

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
I use ssh to the host PC, so I think I could not use two screen. 2017-08-25 15:38 GMT+08:00 Sam : > Actually, I just want to install OS and use it, but I found I can't go > into guest OS (as vnc time out), so what should I do? > > 2017-08-25 14:45 GMT+08:00 Sam

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:16:44 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target/ppc/translate_init.c | 27 +++ > > 1 file

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
Actually, I just want to install OS and use it, but I found I can't go into guest OS (as vnc time out), so what should I do? 2017-08-25 14:45 GMT+08:00 Sam : > I follow this: > https://en.wikibooks.org/wiki/QEMU/QEMU_Hello_World:_ >

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc4 is now available

2017-08-25 Thread Paolo Bonzini
On 24/08/2017 21:06, Laszlo Ersek wrote: > On 08/24/17 20:53, Michael Roth wrote: >> Hello, >> >> On behalf of the QEMU Team, I'd like to announce the availability of the >> fifth release candidate for the QEMU 2.10 release. This release is meant >> for testing purposes and should not be used in

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 14:12:08 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > > previous patches cleaned up cpu model/alias naming which > > allows to simplify cpu model/alias to cpu type lookup a bit > > byt removing

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-25 Thread Fam Zheng
On Thu, 08/24 19:04, Stefan Hajnoczi wrote: > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: > > > Tests should declare resources upfront in a with statement. Resources are > > > automatically cleaned up whether the test passes or fails:

Re: [Qemu-devel] [PATCH for-2.11 1/6] ppc: use macros to make cpu type name from string literal

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 11:30:47 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:46AM +0200, Igor Mammedov wrote: > > Replace > > "-" TYPE_POWERPC_CPU > > when composing cpu type name from cpu model string literal > > and the same pattern in format strings

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-25 Thread Igor Mammedov
On Fri, 25 Aug 2017 11:38:19 +1000 David Gibson wrote: > On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > > PPC handles -cpu FOO rather incosistently, > > i.e. it does case-insensitive matching of FOO to > > a CPU type (see:

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-25 Thread Cornelia Huck
On Thu, 24 Aug 2017 20:14:06 +0200 Christian Borntraeger wrote: > On 08/24/2017 07:38 PM, Farhan Ali wrote: > > > > > > On 08/24/2017 12:07 PM, Peter Maydell wrote: > >> On 24 August 2017 at 16:53, Farhan Ali wrote: > >>> > >>> > >>> On

Re: [Qemu-devel] [PATCH] hw/ppc: CAS reset on early device hotplug

2017-08-25 Thread David Gibson
On Wed, Aug 23, 2017 at 05:57:31PM -0300, Daniel Henrique Barboza wrote: > This patch is a follow up on the discussions made in patch > "hw/ppc: disable hotplug before CAS is completed" that can be > found at [1]. > > At this moment, we do not support CPU/memory hotplug in early > boot stages,

Re: [Qemu-devel] [PATCH 09/14] qlit: replace assert(qnum_get_try_int)

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > qnum_get_int() will assert if underlying type isn't compatible. > > Signed-off-by: Marc-André Lureau > --- > qobject/qlit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 08/14] qlit: add QLIT_QNULL and QLIT_BOOL

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > As they are going to be used in the following patches. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h

Re: [Qemu-devel] [PATCH 06/14] qlit: make qlit_equal_qobject return a bool

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > Make it more obvious about the expected return values. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 18 +- > tests/check-qjson.c

Re: [Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
I follow this: https://en.wikibooks.org/wiki/QEMU/QEMU_Hello_World:_Installing_QEMU_and_getting_it_up_and_running 2017-08-25 14:31 GMT+08:00 Sam : > Hi all, > > I'm starting vm using: > > kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 >> -cdrom

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-25 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Use qlit_ prefix. > > Let's spell it out: > > qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() > > By the way, not only is your name shorter, it's also more precise: >

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > Use qlit_ prefix. Let's spell it out: qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() By the way, not only is your name shorter, it's also more precise: "compare" suggests -1, 0, +1 for less than, equal and greater

[Qemu-devel] Why got no response of vnc?

2017-08-25 Thread Sam
Hi all, I'm starting vm using: kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 -cdrom > CentOS-7-x86_64-DVD-1503-01.iso -boot d > VNC server running on '127.0.0.1:5900' then I start vnc client in another PC to connect 10.253.23.24:11800 and 10.253.23.24:5900, I got time

Re: [Qemu-devel] [PATCH qemu v4 2/3] vfio/spapr: Add a notifier for PPC64 HV/PR KVM about new group attached to LIOBN

2017-08-25 Thread David Gibson
On Thu, Jul 20, 2017 at 05:22:30PM +1000, Alexey Kardashevskiy wrote: > This implements a notification for a new IOMMU group attached to > sPAPR's logical IO bus (LIOBN) to enable in-kernel TCE acceleration. > > This extends the TYPE_SPAPR_IOMMU_MEMORY_REGION class with a get_fd() > callback

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > And misc code style fix. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h

Re: [Qemu-devel] [PATCH 03/14] qlit: use QLit prefix consistently

2017-08-25 Thread Markus Armbruster
Marc-André Lureau writes: > Rename from LiteralQ to QLit. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-25 Thread Markus Armbruster
Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on alternate conflict". Message-Id: <20170717180926.14924-1-ehabk...@redhat.com> Marc-André, could you have a look? You can rebase your fix on top of Eduardo's, or merge the two into one commit. Marc-André Lureau

<    1   2   3