Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-29 Thread Ram Pai
On Tue, Aug 29, 2017 at 11:40:30AM +1000, David Gibson wrote: > On Mon, Aug 28, 2017 at 10:53:56AM -0700, Ram Pai wrote: > > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > > > > > We could either have two u16 fields for the number of keys for data > > > and instruction, or we

Re: [Qemu-devel] [PATCH] crypto: fix test cert generation to not use SHA1 algorithm

2017-08-29 Thread Eric Blake
On 08/29/2017 11:34 AM, Daniel P. Berrange wrote: > On Tue, Aug 29, 2017 at 11:31:24AM -0500, Eric Blake wrote: >> On 08/29/2017 11:27 AM, Daniel P. Berrange wrote: >>> GNUTLS 3.6.0 marked SHA1 as untrusted for certificates. >>> Unfortunately the gnutls_x509_crt_sign() method we are >>> using to

Re: [Qemu-devel] [PATCH] crypto: fix test cert generation to not use SHA1 algorithm

2017-08-29 Thread Daniel P. Berrange
On Tue, Aug 29, 2017 at 11:31:24AM -0500, Eric Blake wrote: > On 08/29/2017 11:27 AM, Daniel P. Berrange wrote: > > GNUTLS 3.6.0 marked SHA1 as untrusted for certificates. > > Unfortunately the gnutls_x509_crt_sign() method we are > > using to create certificates in the test suite is fixed > > to

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 0/2] virtio-iommu: VFIO integration

2017-08-29 Thread Linu Cherian
Hi, On Mon Aug 21, 2017 at 04:18:52PM +0530, Bharat Bhushan wrote: > This V3 version is mainly about rebasing on v3 version on Virtio-iommu device > framework from Eric Augur and addresing review comments. > > This patch series allows PCI pass-through using virtio-iommu. > > This series is

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/28/2017 02:47 PM, Fam Zheng wrote: [...] +def __init__(self, debug=False, vcpus=None): +self._guest = None +self._tmpdir = tempfile.mkdtemp(prefix="qemu-vm-") +atexit.register(shutil.rmtree, self._tmpdir) + +self._ssh_key_file =

Re: [Qemu-devel] [PATCH 20/20] target/arm: Implement BXNS, and banked stack pointers

2017-08-29 Thread Richard Henderson
On 08/22/2017 08:08 AM, Peter Maydell wrote: > Implement the BXNS v8M instruction, which is like BX but will do a > jump-and-switch-to-NonSecure if the branch target address has bit 0 > clear. > > This is the first piece of code which implements "switch to the > other security state", so the

[Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

[Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

2017-08-29 Thread Ishani Chugh
This patch series is intended to introduce QEMU Backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action.

[Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-08-29 Thread Pranith Kumar
This patch increases the number of entries cached in the TLB. I went over a few architectures to see if increasing it is problematic. Only armv6 seems to have a limitation that only 8 bits can be used for indexing these entries. For other architectures, the number of TLB entries is increased to a

Re: [Qemu-devel] make check speed

2017-08-29 Thread Thomas Huth
On 23.08.2017 14:20, Cornelia Huck wrote: > On Wed, 23 Aug 2017 10:35:43 +0200 > Thomas Huth wrote: > >> True. And I just learned that you can also already set the SPEED >> variable to either "quick" or "slow" and that we're already using >> g_test_quick() and g_test_slow() in

Re: [Qemu-devel] make check speed

2017-08-29 Thread Thomas Huth
On 29.08.2017 18:34, Thomas Huth wrote: > On 23.08.2017 14:20, Cornelia Huck wrote: >> On Wed, 23 Aug 2017 10:35:43 +0200 >> Thomas Huth wrote: >> >>> True. And I just learned that you can also already set the SPEED >>> variable to either "quick" or "slow" and that we're already

[Qemu-devel] [PATCH] io: fix check for handshake completion in TLS test

2017-08-29 Thread Daniel P. Berrange
The TLS I/O channel test had mistakenly used && instead of || when checking for handshake completion. As a result it could terminate the handshake process before it had actually completed. This was harmless before but changes in GNUTLS 3.6.0 exposed this bug and caused the test suite to fail.

[Qemu-devel] [PATCH v2 2/3] Test for full Backup

2017-08-29 Thread Ishani Chugh
This patch is the test for full backup implementation in Backup tool. The test employs two basic substests: 1) Backing up an empty guest and comparing it with base image. 2) Writing a pattern to the guest, creating backup and comparing with the base image. Signed-off-by: Ishani Chugh

[Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning

2017-08-29 Thread Pranith Kumar
Fix the following warning: /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^ ~

Re: [Qemu-devel] [PATCH] add scripts/indent.sh

2017-08-29 Thread Marc-André Lureau
Hi On Mon, Jul 17, 2017 at 1:14 PM, Gerd Hoffmann wrote: > On Mon, 2017-07-17 at 10:58 +, Marc-André Lureau wrote: >> Hi >> >> On Mon, Jul 17, 2017 at 12:49 PM Gerd Hoffmann >> wrote: >> > On Mon, 2017-07-17 at 10:36 +, Marc-André Lureau wrote: >> >

Re: [Qemu-devel] [PATCH] io: fix check for handshake completion in TLS test

2017-08-29 Thread Eric Blake
On 08/29/2017 11:40 AM, Daniel P. Berrange wrote: > The TLS I/O channel test had mistakenly used && instead > of || when checking for handshake completion. As a > result it could terminate the handshake process before > it had actually completed. This was harmless before but > changes in GNUTLS

Re: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning

2017-08-29 Thread Pranith Kumar
I should have worded the subject better. The warning is pointing to an actual bug. On Tue, Aug 29, 2017 at 1:32 PM, Pranith Kumar wrote: > Fix the following warning: > > /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is > only applied to the left

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Eric Farman
On 08/29/2017 08:45 AM, Cornelia Huck wrote: On Tue, 29 Aug 2017 08:39:27 -0400 Farhan Ali wrote: On 08/29/2017 08:04 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: On 08/28/2017 10:19 AM, Halil Pasic

Re: [Qemu-devel] [PATCH v2 1/3] nbd-client: avoid read_reply_co entry if send failed

2017-08-29 Thread Eric Blake
On 08/29/2017 07:27 AM, Stefan Hajnoczi wrote: > The following segfault is encountered if the NBD server closes the UNIX > domain socket immediately after negotiation: > > > In the mean time blk_co_preadv() can be called and nbd_coroutine_end() > calls aio_wake() on read_reply_co. At this

Re: [Qemu-devel] [PATCH] crypto: fix test cert generation to not use SHA1 algorithm

2017-08-29 Thread Eric Blake
On 08/29/2017 11:27 AM, Daniel P. Berrange wrote: > GNUTLS 3.6.0 marked SHA1 as untrusted for certificates. > Unfortunately the gnutls_x509_crt_sign() method we are > using to create certificates in the test suite is fixed > to always use SHA1. We must switch to a different method > and explicitly

[Qemu-devel] [PATCH v2 3/3] Add manpage for QEMU Backup Tool

2017-08-29 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The following commit is an initial implementation of manpage

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 07:01 AM, Stefan Hajnoczi wrote: On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: On 08/25/2017 11:40 AM, Peter Maydell wrote: Our choices about our dependencies are generally driven by "what are the versions available on the oldest distros which we wish to support

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 0/2] virtio-iommu: VFIO integration

2017-08-29 Thread Auger Eric
Hi Linu, On 29/08/2017 19:06, Linu Cherian wrote: > Hi, > > On Mon Aug 21, 2017 at 04:18:52PM +0530, Bharat Bhushan wrote: >> This V3 version is mainly about rebasing on v3 version on Virtio-iommu device >> framework from Eric Augur and addresing review comments. >> >> This patch series allows

Re: [Qemu-devel] [PATCH v2 0/7] Misc throttle fixes

2017-08-29 Thread Stefan Hajnoczi
On Thu, Aug 24, 2017 at 04:24:42PM +0300, Alberto Garcia wrote: > Hi, > > here's the new version of my patch series with misc fixes for the > throttling code. > > Stefan, once this is reviewed, can you please remove the "Make > LeakyBucket.avg and LeakyBucket.max integer types" commit (id >

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +class BackupTool(object): > +"""BackupTool Class""" > +def __init__(self, config_file=os.path.expanduser('~') + > + '/.config/qemu/qemu-backup-config'): > +if "QEMU_BACKUP_CONFIG" in os.environ: > +

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +def _restore(self, guest_name): > +""" > +Prints Steps to perform restore operation > +""" > +if guest_name not in self.config.sections(): > +print("Cannot find specified guest", file=sys.stderr) > +

Re: [Qemu-devel] [PATCH v2 3/3] Add manpage for QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup developers > to see QEMU's backup features in action. The following

Re: [Qemu-devel] [RFC for-2.10 1/3] pci/pcie: Make a consistent helper for switching PCI/PCIe "hybrid" devices

2017-08-29 Thread David Gibson
On Tue, Aug 29, 2017 at 11:12:36AM -0300, Eduardo Habkost wrote: > On Tue, Aug 29, 2017 at 09:42:39PM +1000, David Gibson wrote: > > On Wed, Apr 26, 2017 at 06:23:58PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Mar 28, 2017 at 01:16:49PM +1100, David Gibson wrote: > > > > virtio-pci and XHCI

Re: [Qemu-devel] [RFC v2 22/32] vhost+postcopy: Add vhost waker

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:20PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Register a waker function in vhost-user code to be notified when > pages arrive or requests to previously mapped pages get requested. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup

Re: [Qemu-devel] [PATCH v4 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-29 Thread David Gibson
On Fri, Aug 18, 2017 at 03:50:22PM +1000, Sam Bobroff wrote: > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > read only. Doing so causes KVM to act, for that VM, as if the host's > SMT mode was the given value. This is particularly important on Power > 9 systems because

Re: [Qemu-devel] [RFC v2 17/32] vhost+postcopy: Stash RAMBlock and offset

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:15PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Stash the RAMBlock and offset for later use looking up > addresses. > > Signed-off-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Resolve fault addresses read off the clients UFD into RAMBlock > and offset, and call back to the postcopy code to ask for the page. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile

2017-08-29 Thread Eric Blake
On 08/28/2017 09:41 AM, Cédric Le Goater wrote: > On 08/23/2017 01:53 PM, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> Compiler gets confused with the size of the struct, so move form >>> g_new0() to g_malloc0(). >>> >>> I *think* that the problem is in gcc (or

[Qemu-devel] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Kashyap Chamarthy
This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Once migration completes, issue QMP `block-job-cancel` command on the source QEMU to gracefully complete

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Stefan Hajnoczi
On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy wrote: > This is the follow-up patch that was discussed[*] as part of feedback to > qemu-iotest 194. > > Changes in this patch: > > - Supply 'job-id' parameter to `drive-mirror` invocation. > > - Once migration completes,

Re: [Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-08-29 Thread Richard Henderson
On 08/29/2017 10:23 AM, Pranith Kumar wrote: > This patch increases the number of entries cached in the TLB. I went > over a few architectures to see if increasing it is problematic. Only > armv6 seems to have a limitation that only 8 bits can be used for > indexing these entries. For other

[Qemu-devel] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests

2017-08-29 Thread Thomas Huth
Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take opaque BAR handle") a while ago, but nobody noticed since the tests are only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized anymore if bir_pba has the same value as bir_table. With this fix, "make check

[Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-29 Thread John Snow
Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 17 ++--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 6 -- 4 files changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/ide/atapi.c

[Qemu-devel] [PATCH 4/8] tcg/s390: Merge add2i facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 38 ++ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index

[Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro

2017-08-29 Thread John Snow
Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 2e75f9b..57bb59d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -34,17 +34,8 @@ #include "hw/ide/pci.h" #include

[Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing

2017-08-29 Thread John Snow
Wherever possible, replace all printfs with proper tracing. In most places I've tried to do a straight replacement, but forthcoming patches may calibrate the tracing to be a little nicer. For now, it's nice to just remove the all-or-nothing tracing. For V2, I opted to leave in the nearly

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-29 Thread John Snow
On 08/29/2017 10:30 AM, Eric Blake wrote: > On 08/28/2017 08:18 PM, John Snow wrote: We'd have to develop a new syntax for specifying these resources that can be stored in a qcow2 file, >>> >>> It's called the json-pseudo-protocol and was developed exactly for this. >>> >> >> That's

Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements

2017-08-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170829204759.6853-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v2 3/7] throttle: Make throttle_is_valid() a bit less verbose

2017-08-29 Thread Eric Blake
On 08/24/2017 08:24 AM, Alberto Garcia wrote: > Use a pointer to the bucket instead of repeating cfg->buckets[i] all > the time. This makes the code more concise and will help us expand the > checks later and save a few line breaks. > > Signed-off-by: Alberto Garcia > --- >

[Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Eduardo Habkost
The errp argument is ignored by all implementations of the method, and user_creatable_del() would break if any implementation set an error (because it calls error_setg(errp) if the function returns false). Remove the unused parameter. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH 1/8] tcg/s390: Fully convert tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Use a switch instead of searching a table. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 278 +- 1 file changed, 154 insertions(+), 124 deletions(-) diff --git

[Qemu-devel] [PATCH 2/8] tcg/s390: Merge cmpi facilities check to tcg_target_op_def

2017-08-29 Thread Richard Henderson
From: Richard Henderson Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 68 +-- 1 file changed, 30 insertions(+), 38 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c

[Qemu-devel] [PATCH 0/8] tcg/s390 improvements

2017-08-29 Thread Richard Henderson
This finally converts s390 to the tcg_target_op_def function, which allows constraints to vary at runtime. Once we have that, we can (1) Perform some facilities checks once during startup instead of every time we evaluate the constraint, (2) Use the distinct-operands facility from z196. In

[Qemu-devel] [PATCH 7/8] tcg/s390: Use load-on-condition-2 facility

2017-08-29 Thread Richard Henderson
From: Richard Henderson This allows LOAD HALFWORD IMMEDIATE ON CONDITION, eliminating one insn in some common cases. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.inc.c | 79

[Qemu-devel] [PATCH v2 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-29 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow --- hw/ide/ahci.c | 157 +++- hw/ide/trace-events | 49 2 files changed, 117 insertions(+),

[Qemu-devel] [PATCH 2/3] vfio/pci: Add virtual capabilities quirk infrastructure

2017-08-29 Thread Alex Williamson
If the hypervisor needs to add purely virtual capabilties, give us a hook through quirks to do that. Note that we determine the maximum size for a capability based on the physical device, if we insert a virtual capability, that can change. Therefore if maximum size is smaller after added virt

Re: [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing

2017-08-29 Thread Eric Blake
On 08/25/2017 05:10 PM, Eric Blake wrote: > On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> A bit more refactoring and fixing before BLOCK_STATUS series. >> I've tried to make individual patches simple enough, so there are >> a lot of them. >> >> Vladimir Sementsov-Ogievskiy (17):

Re: [Qemu-devel] [PATCH v2 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 157

Re: [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 05:49 PM, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c

Re: [Qemu-devel] Make NVME device "migratable" (savevm)

2017-08-29 Thread Keith Busch
On Tue, Aug 29, 2017 at 11:09:36AM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 25, 2017 at 11:39:30AM +0300, Sergei Dyshel wrote: > > Hi all, > > From what I understand, I can't "savevm" a VM that uses NVME device because > > it has ".unmigratable = 1" in the code. What support must be implemented

[Qemu-devel] [PATCH 6/8] tcg/s390: Use distinct-operands facility

2017-08-29 Thread Richard Henderson
From: Richard Henderson This allows using a 3-operand insn form for some arithmetic, logicals and shifts. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.inc.c | 118 +++---

[Qemu-devel] [PATCH v2 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-29 Thread John Snow
Remove the DEBUG_IDE preprocessor definition with something more appropriately flexible, using the trace-events subsystem. This will be less prone to bitrot and will more effectively allow us to target just the functions we care about. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v2 3/9] IDE: add tracing for data ports

2017-08-29 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow --- hw/ide/core.c | 12 +++- hw/ide/trace-events | 5 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants

2017-08-29 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PATCH v2 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-08-29 Thread John Snow
Goodbye, printfs. Hello, fancy printfs. Signed-off-by: John Snow --- hw/ide/atapi.c| 64 +-- hw/ide/trace-events | 15 +++ include/hw/ide/internal.h | 1 - 3 files changed, 38 insertions(+), 42 deletions(-)

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread Daniel Henrique Barboza
On 08/29/2017 04:23 AM, David Gibson wrote: On Fri, Aug 25, 2017 at 06:11:18PM -0300, Daniel Henrique Barboza wrote: v2: - rebased with ppc-for-2.11 - function 'spapr_cas_completed' dropped - function 'spapr_drc_needed' made public and it's now used inside 'spapr_hotplugged_dev_before_cas'

Re: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing

2017-08-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170829204934.9039-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v4 06/10] tests: Add NetBSD image

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/29/2017 09:09 AM, Philippe Mathieu-Daudé wrote: [...]>> +if __name__ == "__main__": +    sys.exit(basevm.main(NetBSDVM)) This one is failing: DEBUG:root:ssh_cmd: ssh -q -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o ConnectTimeout=1 -p 34091 -i

[Qemu-devel] [PATCH 3/3] vfio/pci: Add NVIDIA GPUDirect Cliques support

2017-08-29 Thread Alex Williamson
NVIDIA has defined a specification for creating GPUDirect "cliques", where devices with the same clique ID support direct peer-to-peer DMA. When running on bare-metal, tools like NVIDIA's p2pBandwidthLatencyTest (part of cuda-samples) determine which GPUs can support peer-to-peer based on chipset

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-29 Thread Alexey Kardashevskiy
On 25/08/17 18:53, Paolo Bonzini wrote: > On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >> Otherwise old dispatch holds way too much memory before RCU gets >> a chance to free old dispatches. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> This is a follow-up to the

Re: [Qemu-devel] [PATCH 01/14] hvf: add support for Hypervisor.framework in the configure script

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:41PM -0500, Sergio Andres Gomez Del Real wrote: > @@ -3619,6 +3619,16 @@ applicable to MAC and Windows platform, and thus does > not conflict with > KVM. > ETEXI > > +DEF("enable-hvf", 0, QEMU_OPTION_enable_hvf, \ > +"-enable-hvf enable

Re: [Qemu-devel] [PATCH 06/14] hvf: add compilation rules to Makefile.objs

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:46PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. >

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:26:10 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:07, Cornelia Huck 写道: > > [Restored cc:s. Please remember to do reply-all.] > > > > On Tue, 29 Aug 2017 12:46:51 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/28

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 17:51:43 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午5:33, Cornelia Huck 写道: > > My question was whether virtio-pci works with your patches on top at > > all - last time I checked on master, virtio-pci devices failed to > > realize with a "msi-x is

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: > Hi, I have CCed the relevant mailing lists and people most recently involved in virtio-balloon discussions. Hopefully this will help get the right people to see your questions. > We'd like to include information about

Re: [Qemu-devel] Make NVME device "migratable" (savevm)

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 11:39:30AM +0300, Sergei Dyshel wrote: > Hi all, > From what I understand, I can't "savevm" a VM that uses NVME device because > it has ".unmigratable = 1" in the code. What support must be implemented in > order to make it "migratable"? CCing Keith Busch, the NVMe

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-29 Thread Daniel P. Berrange
On Wed, Aug 16, 2017 at 05:47:13PM +0800, Peter Xu wrote: > On Tue, Aug 15, 2017 at 05:47:08PM +0800, Peter Xu wrote: > > On Tue, Aug 15, 2017 at 10:27:07AM +0100, Daniel P. Berrange wrote: > > > On Tue, Aug 15, 2017 at 04:50:06PM +0800, Peter Xu wrote: > > > > On Tue, Aug 15, 2017 at 09:37:14AM

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-29 Thread Daniel P. Berrange
On Thu, Aug 17, 2017 at 09:04:38AM +0200, Markus Armbruster wrote: > Copying our resident VNC maintainer^Wodd fixer Gerd. > > Also copying Dan for QCryptoCipherAlgorithm. > > Gerd, Dan, this patch is about making VNC support visible in > query-qmp-schema, by having the QAPI generators generate

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-08-29 Thread Fam Zheng
On Tue, 08/29 11:15, Seeteena Thoufeek wrote: > ---Steps to Reproduce--- > > When passed a negative number to 'maxcpus' parameter, Qemu aborts > with a core dump. > > Run the following command with maxcpus argument as negative number > > ppc64-softmmu/qemu-system-ppc64 --nographic -vga none

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 04:34:26PM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 23:28:00 +1000 > David Gibson wrote: > > > On Fri, Aug 25, 2017 at 01:40:07PM +0200, Igor Mammedov wrote: > > > On Fri, 25 Aug 2017 19:45:38 +1000 > > > David Gibson

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-29 Thread Sameeh Jubran
Hi Sam, Thanks for reporting this, in order to debug this efficiently I need you to provide me with more info, if you can provide it that would be great. Can you reproduce the issue with ncat? You can use ncat to connect to the socket by running the following command: nc -U /tmp/qga.sock Which

Re: [Qemu-devel] [PULL 0/1] slirp updates

2017-08-29 Thread Samuel Thibault
Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote: > On 28 August 2017 at 00:05, Samuel Thibault > wrote: > > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > > The following changes since commit

Re: [Qemu-devel] [PATCH 04/14] hvf: add fields to CPUState and CPUX86State; add definitions

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:44PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds some fields specific to hvf in CPUState and > CPUX86State. It also adds some handy #defines. > > Signed-off-by: Sergio Andres Gomez Del Real > --- > include/qom/cpu.h |

Re: [Qemu-devel] [Qemu-discuss] changing from net to netdev with vde switches and double nics

2017-08-29 Thread Thomas Huth
Hi, On 28.08.2017 15:58, Paolo wrote: > Hello everyone, > > I'm at loss as to how to translate from net to netdev syntax the following > lines: > > NET0="-net vde,vlan=0,sock=/var/run/vde.ctl00 -net > nic,vlan=0,model=rtl8139,macaddr=$NIC0MAC -net >

Re: [Qemu-devel] [PATCH 00/14] add support for Hypervisor.framework in QEMU

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at >

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:33, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:26:10 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:07, Cornelia Huck 写道: [Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote:

Re: [Qemu-devel] [PATCH 00/14] add support for Hypervisor.framework in QEMU

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at >

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 09:24:36AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: scripts: add argparse module for Python 2.6 > compatibility... > ERROR: trailing whitespace > #115: FILE: COPYING.PYTHON:93: > +Reserved" are retained in Python alone or in any

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-29 Thread Bob Chen
The topology is already having all GPUs directly attached to root bus 0. In this situation you can't see the LnkSta attribute in any capabilities. The other way of using emulated switch would somehow show this attribute, at 8 GT/s, although the real bandwidth is low as usual. 2017-08-23 2:06

Re: [Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 06:11:18PM -0300, Daniel Henrique Barboza wrote: > v2: > - rebased with ppc-for-2.11 > - function 'spapr_cas_completed' dropped > - function 'spapr_drc_needed' made public and it's now used inside > 'spapr_hotplugged_dev_before_cas' > - 'spapr_drc_needed' was changed to

Re: [Qemu-devel] [PATCH v2] spapr: fallback to raw mode if best compat mode cannot be set during CAS

2017-08-29 Thread David Gibson
On Thu, Aug 17, 2017 at 01:23:50PM +0200, Greg Kurz wrote: > KVM PR doesn't allow to set a compat mode. This causes ppc_set_compat_all() > to fail and we return H_HARDWARE to the guest right away. > > This is excessive: even if we favor compat mode since commit 152ef803ceb19, > we should at least

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:00, Cornelia Huck 写道: > > On Tue, 29 Aug 2017 12:32:17 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/28 下午10:51, Cornelia Huck 写道: > >>> On Mon, 28 Aug 2017

[Qemu-devel] [PATCH v2] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Kashyap Chamarthy
This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Issue QMP `block-job-cancel` command on the source QEMU to gracefully complete `drive-mirror` operation. - Stop

Re: [Qemu-devel] [PATCH 03/14] hvf: add conditional macros around hvf code in cpus.c

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:43PM -0500, Sergio Andres Gomez Del Real wrote: > @@ -900,6 +904,11 @@ void cpu_synchronize_all_states(void) > > CPU_FOREACH(cpu) { > cpu_synchronize_state(cpu); > +#ifdef CONFIG_HVF > +if (hvf_enabled()) { > +

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 11:33:53 +0200 Cornelia Huck wrote: > My question was whether virtio-pci works with your patches on top at > all - last time I checked on master, virtio-pci devices failed to > realize with a "msi-x is mandatory" message. Just checked again, I still get

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:57, Cornelia Huck 写道: On Tue, 29 Aug 2017 17:51:43 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午5:33, Cornelia Huck 写道: My question was whether virtio-pci works with your patches on top at all - last time I checked on master, virtio-pci devices failed

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-29 Thread Christian Borntraeger
On 08/29/2017 11:35 AM, Thomas Huth wrote: > On 28.08.2017 09:18, Christian Borntraeger wrote: >> >> >> On 08/25/2017 10:29 AM, Cornelia Huck wrote: >>> On Fri, 25 Aug 2017 10:21:58 +0200 >>> Christian Borntraeger wrote: >>> On 08/25/2017 09:20 AM, Cornelia Huck

Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm tests

2017-08-29 Thread Fam Zheng
On Mon, 08/28 17:18, Philippe Mathieu-Daudé wrote: > On 08/28/2017 02:47 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > Reviewed-by: Stefan Hajnoczi > > --- > > Makefile | 2 ++ > > configure | 2 +- > >

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 09:49:48AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 14:22:03 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > > > Caching there practically doesn't give any benefits > > > and that at

Re: [Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 06:11:19PM -0300, Daniel Henrique Barboza wrote: > This patch is a follow up on the discussions made in patch > "hw/ppc: disable hotplug before CAS is completed" that can be > found at [1]. > > At this moment, we do not support CPU/memory hotplug in early > boot stages,

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

2017-08-29 Thread Jason Wang
On 2017年08月22日 15:16, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1503305719-2512-1-git-send-email-zhangchen.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH V4 0/3] Optimize

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update mail address for COLO Proxy

2017-08-29 Thread Jason Wang
On 2017年08月29日 13:31, Zhang Chen wrote: Hi~ No news for long time. Ping... Thanks Zhang Chen On 08/23/2017 04:51 PM, Zhang Chen wrote: My Fujitsu mail account will be disabled soon, update the mail info to my private mail. Signed-off-by: Zhang Chen ---

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-08-29 Thread Peter Maydell
On 26 August 2017 at 01:02, Emilio G. Cota wrote: > An additional "nice to have" would be: > > * Allow inlining of TCG code by the instrumenter. Example use case: > the instrumenter wants to increment a counter every time a > basic block is executed. Instead of calling a

Re: [Qemu-devel] [PATCH 10/14] hvf: refactor cpuid code

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:50PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds code to request the cpuid features supported by the > host and hvf; it calls hvf_get_supported_cpuid if hvf is compiled with > QEMU and enabled. > > Signed-off-by: Sergio Andres Gomez Del Real

  1   2   3   4   >