Re: [Qemu-devel] [PATCH v7 09/38] libqos: Track QTestState with QVirtioBus

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > When initializing a QVirtioDevice (which always has an associated > QVirtioBus), we want to track which QTestState to use for all > I/O processed through that bus and device. Copy the paradigm > used for QPCIBus, and track the test state at the bus level;

Re: [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 21:52, Alistair Francis wrote: > This series expands on my previous series by converting more existing > prints to use warn_report() instead of error_report() or fprintf(). > > As discussed with Paolo and Markus this series combines libqemustub.a into > libqemuutil.a to avoid

Re: [Qemu-devel] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-12 Thread Laurent Vivier
On 11/09/2017 18:40, Peter Maydell wrote: > On 11 September 2017 at 15:45, Thomas Huth wrote: >> On 11.09.2017 16:39, Peter Maydell wrote: >>> On 11 September 2017 at 15:20, Laurent Vivier wrote: Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault)

[Qemu-devel] [PATCH v7 RESEND] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-09-12 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu --- v1->v2: - correct some spelling mistake and add the stats data to

Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState for fw_cfg operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all fw_cfg test > functionality (invoked through alloc-pc) to pass in an explicit > QTestState, adjusting all callers. In particular, fw_cfg-test > had to reorder things to create the test state prior to

Re: [Qemu-devel] [PATCH v7 15/38] libqos: Use explicit QTestState for i2c operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all i2c test > functionality to pass in an explicit QTestState, adjusting all > callers. > > Signed-off-by: Eric Blake > --- > tests/libqos/i2c.h | 7 -- > tests/ds1338-test.c

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 08:40, Igor Mammedov wrote: > On Mon, 11 Sep 2017 14:33:03 +0100 > Peter Maydell wrote: >> It's not possible in all cases to set a CPU property from the >> top level board code. In quite a lot of cases the CPU >> object is

Re: [Qemu-devel] [PATCH v4 0/3] QEMU Backup Tool

2017-09-12 Thread Stefan Hajnoczi
On Fri, Sep 08, 2017 at 10:11:42PM +0530, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management

Re: [Qemu-devel] [PATCH v7 07/38] libqtest: Inline qtest_query_target_endianness()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > There was only one caller; it's easier to inline things. (It > trades one forward declaration for two others, but it's not > worth the additional churn of topological sorting, even though > that would be possible.) > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [RFC PATCH qemu 3/4] memory: Share flat views and dispatch trees between address spaces

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 07:55, Alexey Kardashevskiy wrote: > On 12/09/17 01:30, Paolo Bonzini wrote: >> On 11/09/2017 14:08, Alexey Kardashevskiy wrote: Ok, this makes sense. Maybe it should be a flatview rather than an AddressSpaceDispatch (a FlatView is essentially a list of

Re: [Qemu-devel] [PATCH v1 0/6] QEMU: kvm: cleanup kvm_slot handling

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 19:49, David Hildenbrand wrote: > We can heavily simplify the kvm_slot code. Flatview will make sure that we > don't have to deal with overlapping slots. E.g. when a memory section is > resized, we are first notified about the removal and then about the new > memory section. > > So

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 14:33:03 +0100 Peter Maydell wrote: > On 11 September 2017 at 13:10, Igor Mammedov wrote: > > On Tue, 5 Sep 2017 10:08:01 +0100 > > Peter Maydell wrote: > > > >> On 4 September 2017 at 20:38, Igor

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update git URLs for my trees

2017-09-12 Thread Paolo Bonzini
On 01/09/2017 17:47, Eduardo Habkost wrote: > On Fri, Sep 01, 2017 at 12:39:28PM -0300, Eduardo Habkost wrote: >> List the branches where I queue patches for Machine Core, NUMA, >> Memory Backends, and X86. Update the NUMA section to list the >> "numa-next" branch instead of "numa". >> >>

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 08:49, Ramy Sameh wrote: > Hello Peter, > > Any suggestions regarding this topic ? No, I think at this point you're into the stuff that you need to think about yourself, ie what exactly you want fault injection to do. PS: your emails would be

Re: [Qemu-devel] [PATCH v7 24/38] tests/acpi-utils: Drop dependence on global_qtest

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Adjust the helper code to > use explicit state instead, and update all callers. > >

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-12 Thread Ramy Sameh
Hello Peter, Any suggestions regarding this topic ? On Sun, Sep 10, 2017 at 8:33 PM, Ramy Sameh wrote: > Thanks Peter. > > I have made a program to read a string from the UART, then write it again > to the UART. > I made a function to manipulate values in the pl011

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 03:41, Gonglei (Arei) wrote: > >> -Original Message- >> From: Eduardo Habkost [mailto:ehabk...@redhat.com] >> Sent: Tuesday, September 12, 2017 2:38 AM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; >> r...@twiddle.net;

Re: [Qemu-devel] [PATCH 0/2] hyperv: own protocol header instead of kernel's

2017-09-12 Thread Paolo Bonzini
On 31/08/2017 18:37, Roman Kagan wrote: > On Thu, Jul 13, 2017 at 11:15:20PM +0300, Roman Kagan wrote: >> Supersede kernel's header for Hyper-V protocol definitions with our own. >> The reason is that, since this is a third-party protocol and not a >> kernel API, the kernel folks are not happy

[Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Viktor Mihajlovski
Hi, the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot is slightly outdated since proper DHCP based netboot support for s390x has been implemented by the series ending with commit 29d1221. As it is still desirable to provide some instructions on building network bootable

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-12 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 12:04:15PM -0700, Brandon Carpenter wrote: > On Mon, Sep 11, 2017 at 10:10 AM, Daniel P. Berrange > wrote: > > It feels like this is still dangerous - the client simply has to > > interleave each "ping" with a 1 byte binary frame to get around this > >

[Qemu-devel] [PATCH v7 RESEND] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-09-12 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu v1->v2: - correct some spelling mistake and add the stats data to the

Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > When initializing a QPCIBus, track which QTestState the bus is > associated with (so that a later patch can then explicitly use > that test state for all communication on the bus, rather than > blindly relying on global_qtest). Update the initialization >

Re: [Qemu-devel] [PATCH v7 12/38] libqos: Use explicit QTestState for virtio operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Now that QVirtioDevice and QVirtQueue point back to QVirtioBus, > we can reuse the explicit QTestState stored there rather than > relying on implicit global_qtest. We also have to pass QTestState > through a few functions that can't trace back through >

Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState for ahci operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Drop one more client of global_qtest by teaching all ahci test > functionality to pass in an explicit QTestState. The state was > already available, so no callers had to be adjusted. > > Signed-off-by: Eric Blake Reviewed-by: Thomas

Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Rather than have two similar shutdown functions, where one requires > the use of global_qtest in the header, it is better to have a single > shutdown function that still takes care of cleaning up global_qtest > if it is set. All callers are updated. > >

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-12 Thread Linu Cherian
Hi Eric, On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > This series implements the emulation code for ARM SMMUv3. > > Changes since v6: > - DPDK testpmd now running on guest with 2 assigned VFs > - Changed the instantiation method: add the following option to > the QEMU command

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-12 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 10:43:21AM -0700, Brandon Carpenter wrote: > On Mon, Sep 11, 2017 at 10:37 AM, Daniel P. Berrange > wrote: > > At the time qio_channel_websock_decode_header is run, 'encinput' is only > > guaranteed to contain enough data to decode the header. > >

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 05:23, Richard Henderson wrote: > On 09/11/2017 02:37 PM, Peter Maydell wrote: >> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé >> wrote: >>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >>> >>>

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-12 Thread Auger Eric
Hi Linu, On 12/09/2017 08:18, Linu Cherian wrote: > Hi Eric, > > On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: >> This series implements the emulation code for ARM SMMUv3. >> >> Changes since v6: >> - DPDK testpmd now running on guest with 2 assigned VFs >> - Changed the

[Qemu-devel] [PATCH v3] spapr_cpu_core: cleaning up qdev_get_machine() calls

2017-09-12 Thread Greg Kurz
This patch removes the qdev_get_machine() calls that are made in spapr_cpu_core.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. Credits to Daniel Henrique Barboza for the

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Stefan Weil
Am 12.09.2017 um 10:52 schrieb Stefan Weil: > Am 11.09.2017 um 20:24 schrieb Peter Maydell: >> I've also turned on a tci compile check on my pre-merge tests. >> (It doesn't pass "make check" for me, though...) thanks -- PMM > > "make check-qtest-ppc64" fails for me, too. > > Thomas, this seems

[Qemu-devel] [PATCH v2] trace: Immediately apply per-vCPU state changes if a vCPU is being created

2017-09-12 Thread Lluís Vilanova
Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables events in the case a vCPU is executing TCG code. If the vCPU is being created this makes some events like "guest_cpu_enter" to not be traced. Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G.

Re: [Qemu-devel] [Qemu devel v8 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

2017-09-12 Thread sundeep subbaraya
Hi Alistair, On Wed, Sep 13, 2017 at 5:20 AM, Alistair Francis wrote: > On Thu, Sep 7, 2017 at 12:24 PM, Subbaraya Sundeep > wrote: > > Modelled Microsemi's Smartfusion2 SPI controller. > > > > Signed-off-by: Subbaraya Sundeep

[Qemu-devel] [PATCH v7 02/13] qemu.py: Add "wait()" method

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 4d8ee10943..99963053a5 100644 ---

[Qemu-devel] [PATCH v7 03/13] scripts: Add archive-source.sh

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 33 + 1 file changed, 33 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index

[Qemu-devel] [PATCH v7 07/13] tests: Add FreeBSD image

2017-09-12 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git

Re: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-09-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) Message-id: 20170913030119.3957-1-f...@redhat.com Type: series === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v5 20/22] instrument: Add event 'guest_user_syscall'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- bsd-user/syscall.c |6 ++ instrument/control.c| 18 ++ instrument/events.h |7 +++ instrument/events.inc.h | 16 instrument/load.c

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread James Clarke
Ok, I was wrong, there's a whole load of code being included inside the function from a header. The issue seems to be the pread: 20771@1505254578.94:guest_user_syscall cpu=0x62850620 num=0x00b4 arg1=0x0003 arg2=0xf6fe6798 arg3=0x0020

Re: [Qemu-devel] [PATCH] mps2-an511: Fix wiring of UART overflow interrupt lines

2017-09-12 Thread Alistair Francis
On Tue, Sep 12, 2017 at 9:13 AM, Peter Maydell wrote: > Fix an error that meant we were wiring every UART's overflow > interrupts into the same inputs 0 and 1 of the OR gate, > rather than giving each its own input. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] spapr_events: use QTAILQ_FOREACH_SAFE() in spapr_clear_pending_events()

2017-09-12 Thread David Gibson
On Tue, Sep 12, 2017 at 08:48:05PM +0200, Greg Kurz wrote: > QTAILQ_FOREACH_SAFE() must be used when removing the current element > inside the loop block. > > This fixes a user-after-free error introduced by commit 56258174238eb > and reported by Coverity (CID 1381017). > > Signed-off-by: Greg

[Qemu-devel] [PATCH v7 12/13] tests: Add README for vm tests

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..7d2fe4ac8d ---

[Qemu-devel] [PATCH v7 04/13] tests: Add a test key pair

2017-09-12 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng --- tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 2 files changed, 28 insertions(+) create mode 100644 tests/keys/id_rsa create mode 100644 tests/keys/id_rsa.pub diff

[Qemu-devel] [PATCH v7 08/13] tests: Add NetBSD image

2017-09-12 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread James Clarke
(Currently regpairs_aligned gets checked, but this, rightly, returns false for SH; alignment is not a requirement of the SH ABI, but p{read,write}64 are an exception for it.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread James Clarke
Bah, and that's "read *from an offset of* 0x34 bytes"; I got confused between count and pos midway through that paragraph. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716767

[Qemu-devel] [PATCH v7 10/13] Makefile: Add rules to run vm tests

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/vm/Makefile.include diff

[Qemu-devel] [PATCH v7 13/13] docker: Use archive-source.py

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v2 0/2] spapr: fix migration with nested KVM PR

2017-09-12 Thread Greg Kurz
A guest running with KVM PR ends up irresponsive after migration most of the time. This happens because the HPT allocated by QEMU is likely to have a different address on the destination than it had on the source, but we push the source address to KVM. This v2 is a total rewrite. Cheers, --

Re: [Qemu-devel] [Qemu devel v8 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

2017-09-12 Thread Alistair Francis
On Thu, Sep 7, 2017 at 12:24 PM, Subbaraya Sundeep wrote: > Modelled Microsemi's Smartfusion2 SPI controller. > > Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Thanks, Alistair > --- >

[Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib

2017-09-12 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the

[Qemu-devel] [PATCH v7 11/13] MAINTAINERS: Add tests/vm entry

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..42f5454311 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1891,6 +1891,7 @@ S: Maintained

[Qemu-devel] [PATCH v7 09/13] tests: Add OpenBSD image

2017-09-12 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git

Re: [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address

2017-09-12 Thread Peter Xu
On Mon, Sep 11, 2017 at 12:58:15PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Aug 24, 2017 at 08:27:17PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Resolve fault addresses

[Qemu-devel] [PATCH v5 21/22] instrument: Add event 'guest_user_syscall_ret'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- bsd-user/syscall.c |3 +++ instrument/control.c| 15 +++ instrument/events.h |5 + instrument/events.inc.h | 13 + instrument/load.c |1 +

[Qemu-devel] [PATCH v2 2/2] spapr: preserve SDR1 during migration

2017-09-12 Thread Greg Kurz
When running with KVM PR, a pseries machine needs to allocate an HPT in userspace and pass its address and size too KVM. This is done at machine reset time by hijacking SDR1. It is very likely that the destination QEMU will allocate the HPT at a different address, ie, the SDR1 value we get from

[Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-09-12 Thread Fam Zheng
v7: Add Alex's rev-by to patch 2. GPLv2 => GPLv2+ for all new files. [Peter] Add more description in file header to archive-source.sh for the intended usage. [Peter] "output tarball" in usage. [Alex] Add quotes to "$1". [Peter] Put generated keys in separate files. [Alex]

[Qemu-devel] [PATCH v7 01/13] gitignore: Ignore vm test images

2017-09-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclient /vhost-user-scsi

Re: [Qemu-devel] [PATCH v2 1/2] spapr: introduce common helper to write HPT address to KVM PR

2017-09-12 Thread David Gibson
On Wed, Sep 13, 2017 at 12:24:53AM +0200, Greg Kurz wrote: > When running with KVM PR, if a new HPT is allocated we need to inform > KVM about the HPT address and size. This is currently done with a hack > which is open-coded in several places. > > This patch consolidate the code in a dedicated

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread David Gibson
On Tue, Sep 12, 2017 at 04:36:30PM +0100, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: > > On 12.09.2017 16:46, Greg Kurz wrote: > > > On Tue, 12 Sep 2017 16:01:46 +0200 > > > Laurent Vivier wrote: > > > > > >> Fix aarch64 and ppc when

Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-12 Thread David Gibson
On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote: > Running QEMU with > qemu-system-ppc64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is no CPU: > >

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-09-12 Thread Peter Xu
On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Aug 24, 2017 at 08:27:14PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > We need a better way, but

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-12 Thread Thomas Huth
On 12.09.2017 19:37, Eduardo Habkost wrote: > On Mon, Sep 11, 2017 at 08:13:21AM +0200, Thomas Huth wrote: >> On 09.09.2017 22:41, Eduardo Habkost wrote: >>> On Wed, Sep 06, 2017 at 08:59:32AM +0200, Markus Armbruster wrote: Thomas Huth writes: > On 05.09.2017

[Qemu-devel] [PATCH v5 22/22] instrument: Add API to manipulate guest memory

2017-09-12 Thread Lluís Vilanova
It includes access to the guest's memory and vCPU registers. Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs |1 instrument/qemu-instr/state.h | 104 + instrument/state.c| 73

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc: add CPU IRQ state to PPC VMStateDescription

2017-09-12 Thread Alexey Kardashevskiy
On 13/09/17 02:46, Mark Cave-Ayland wrote: > On 12/09/17 17:41, Mark Cave-Ayland wrote: > >> The commit message mentions that prior to the conversion some CPU state >> was missing but it doesn't mention anything about dropping existing >> fields as part of the conversion process so I suspect that

[Qemu-devel] [PATCH v7 06/13] tests: Add ubuntu.i386 image

2017-09-12 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755

[Qemu-devel] [PATCH v2 1/2] spapr: introduce common helper to write HPT address to KVM PR

2017-09-12 Thread Greg Kurz
When running with KVM PR, if a new HPT is allocated we need to inform KVM about the HPT address and size. This is currently done with a hack which is open-coded in several places. This patch consolidate the code in a dedicated helper that records the HPT address and size in the sPAPR context, and

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-12 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation Message-id:

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation Message-id: 150525010239.15988.8172586618197849619.st...@frigg.lan Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v4 19/21] s390x: get rid of cpu_s390x_create()

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 17:21:48 +0200 David Hildenbrand wrote: > Now that there is only one user of cpu_s390x_create() left, make cpu > creation look like on x86. > - Perform the model/properties split and checks in s390_init_cpus() > - Parse features only once without having to

Re: [Qemu-devel] question: I found a bug which will lead to qemu crash

2017-09-12 Thread Eric Blake
On 09/12/2017 06:37 AM, Kevin Wolf wrote: > Am 12.09.2017 um 13:17 hat WangJie (Captain) geschrieben: >> Hi, Kevin. >> >> I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 >> and current master is OK. >> So I git-bisect the master branch,and I found the patch you commited

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-09-12 Thread Kevin Wolf
The important difference between your -drive command line and my -blockdev example is that I used the node-name to reference the image. You can specify a node-name with -drive, too (having both id and node- name is one of the main things that I meant what I said mixing both styles can be

Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-12 Thread Thomas Huth
On 12.09.2017 16:01, Laurent Vivier wrote: > Running QEMU with > qemu-system-ppc64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is no CPU: > > (qemu)

Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-12 Thread Thomas Huth
On 12.09.2017 16:01, Laurent Vivier wrote: > Running QEMU with > qemu-system-aarch64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is no CPU: > > (qemu)

Re: [Qemu-devel] [PATCH v3 3/3] tests/hmp: test "none" machine with memory

2017-09-12 Thread Thomas Huth
On 12.09.2017 16:01, Laurent Vivier wrote: > and add a test case of dump-guest-memory without > "[begin length]" parameters. > > Signed-off-by: Laurent Vivier > Reviewed-by: Thomas Huth > --- > tests/test-hmp.c | 4 > 1 file changed, 4 insertions(+) >

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-09-12 Thread Tomáš Golembiovský
On Tue, 29 Aug 2017 20:01:53 +0800 Wei Wang wrote: > On 08/29/2017 05:57 PM, Stefan Hajnoczi wrote: > > On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: > >> Hi, > > I have CCed the relevant mailing lists and people most recently involved > > in

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 03:24:22PM +0100, Peter Maydell wrote: > On 12 September 2017 at 15:19, Daniel P. Berrange wrote: > > My POV is that we should a) never check generated files into GIT, and > > we should use the submodule in such a way that it is indistinguish > > from

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Thomas Huth
On 12.09.2017 11:20, Stefan Weil wrote: > Am 12.09.2017 um 10:52 schrieb Stefan Weil: >> Am 11.09.2017 um 20:24 schrieb Peter Maydell: >>> I've also turned on a tci compile check on my pre-merge tests. >>> (It doesn't pass "make check" for me, though...) thanks -- PMM >> >> "make

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 15:53, Sergey Smolov wrote: > Generally speaking, is it possible at "run time" to detect write accesses to > MIPS GPR registers? > If true, which parts of code should I look in? We don't currently support tracing at that level, I'm afraid. (There are

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 16:56, Thomas Huth wrote: > The problem is that the SLOF firmware just performs very badly with TCG > (it's fine on real hardware). It executes a lot of Forth code, and the > Forth interpreter uses things like computed gotos or other tricks that > basically prevent proper JIT

Re: [Qemu-devel] [PATCH] Add BSD systems to the download section

2017-09-12 Thread Kamil Rytarowski
ping On 30.08.2017 18:56, Kamil Rytarowski wrote: > Add basic notes about FreeBSD, NetBSD and OpenBSD. > > Add BSD link to source code subsection. > > Signed-off-by: Kamil Rytarowski > --- > _download/bsd.md | 19 +++ > _download/source.html | 1 + >

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Eduardo Habkost
On Tue, Sep 12, 2017 at 01:02:35PM +0200, Igor Mammedov wrote: > On Tue, 5 Sep 2017 14:47:52 -0700 > Alistair Francis wrote: > > > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov

Re: [Qemu-devel] [PATCH v3 5/7] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 12:28:53PM +0100, Daniel P. Berrange wrote: > Make the crypto driver implement the bdrv_co_preadv|pwritev > callbacks, and also use bdrv_co_preadv|pwritev for I/O > with the protocol driver beneath. > > Signed-off-by: Daniel P. Berrange > --- >

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 13:43 hat Richard W.M. Jones geschrieben: > On Tue, Sep 12, 2017 at 01:32:05PM +0200, Kevin Wolf wrote: > > Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > > > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > > > This command line fragment looks correct

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 12:31, Kevin Wolf wrote: > Hm, does this mean that instead of ./check failing when a binary is > missing, we try each test case now and each one fails with the same > error message? > > *tries it out* > > Okay, it's already broken today because the strings are never empty but >

[Qemu-devel] [PATCH v5 07/12] input: convert the adb device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +---

[Qemu-devel] [PATCH v5 08/12] char: convert the escc device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++--

[Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS

[Qemu-devel] [PATCH v5 06/12] input: convert ps2 device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN ->

Re: [Qemu-devel] [PATCH v4 12/21] target/s390x: set cpu->id for linux user when realizing

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 17:21:41 +0200 David Hildenbrand wrote: > scc->next_cpu_id is updated when realizing. Setting it just before that > point looks cleaner. > > Reviewed-by: Matthew Rosato > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v5 1/3] qapi: Rename WatchdogExpirationAction enum

2017-09-12 Thread Daniel P. Berrange
On Thu, Sep 07, 2017 at 10:05:24AM +0200, Michal Privoznik wrote: > The new name is WatchdogAction which is shorter, > > Signed-off-by: Michal Privoznik > --- > hw/watchdog/watchdog.c | 14 +++--- > monitor.c | 4 ++-- > qapi/run-state.json| 6

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 14:31 hat Paolo Bonzini geschrieben: > On 12/09/2017 12:40, Kevin Wolf wrote: > > Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: > >> Split "check" parts from tests part. > >> > >> For the directory setup, the actual computation of directories goes > >> in "check", while

Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum

2017-09-12 Thread Daniel P. Berrange
On Thu, Sep 07, 2017 at 10:05:25AM +0200, Michal Privoznik wrote: > We already have enum that enumerates all the actions that a > watchdog can take when hitting its timeout: WatchdogAction. > Use that instead of inventing our own. > > Signed-off-by: Michal Privoznik > --- >

Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 17:21:43 +0200 David Hildenbrand wrote: > Adapt to the new term "core_id". While at it, fix the type and drop the > initialization to 0 (which is superfluous). > > Reviewed-by: Matthew Rosato > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v4 13/21] target/s390x: use "core-id" for cpu number/address/id handling

2017-09-12 Thread David Hildenbrand
On 12.09.2017 15:07, Igor Mammedov wrote: > On Mon, 11 Sep 2017 17:21:42 +0200 > David Hildenbrand wrote: > >> Some time ago we discussed that using "id" as property name is not the >> right thing to do, as it is a reserved property for other devices and >> will not work with

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-09-12 Thread Scott Moser
Your example does work (using -blockdev), but I can't get it to work with -drive. $ qemu-system-x86_64 \ -drive id=d01,file=disk1.img,format=qcow2 \ -device drive=d01,serial=s01,driver=virtio-blk,index=1,share-rw=on \ -device drive=d01,serial=s01,driver=virtio-blk,index=2,share-rw=on

[Qemu-devel] [PATCH v4 1/3] io: send proper HTTP response for websocket errors

2017-09-12 Thread Daniel P. Berrange
When any error occurs while processing the websockets handshake, QEMU just terminates the connection abruptly. This is in violation of the HTTP specs and does not help the client understand what they did wrong. This is particularly bad when the client gives the wrong path, as a "404 Not Found"

[Qemu-devel] [RFC] vfio/pci: don't reset bar address when pci device no_soft_reset bit is set to "1"

2017-09-12 Thread Lifei (Louis)
Hi all In commit a52a4c471703e995ceb06f6157d70747823e8a0d said: The VFIO configuration space stays untouched, so the guest OS may choose to skip restoring the BAR addresses as they would seem intact. The PCI device may be left non-operational. While the guest OS choose to restore the

Re: [Qemu-devel] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

2017-09-12 Thread Eric Blake
On 09/12/2017 05:45 AM, Thomas Huth wrote: > On 11.09.2017 19:20, Eric Blake wrote: >> Maintaining two layers of libqtest APIs, one that takes an explicit >> QTestState object, and the other that uses the implicit global_qtest, >> is annoying. In the interest of getting rid of global implicit >>

Re: [Qemu-devel] [PATCH v7 27/38] libqtest: Swap order of qtest_init() and qtest_start()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > We already have another qtest_init() in the tree (namely, as part > of the device initialization of the qtest device at the top level > qtest.c), with a different signature; having two different > qtest_init() is confusing, so an upcoming patch will

  1   2   3   4   >