Re: [Qemu-devel] Converting host virtual addresses to guest physical

On Thu, Sep 07, 2017 at 01:02:59PM +, Padmanabhan S N via Qemu-devel wrote: > I'm developing a new block backend driver. Since my Guest RAM is coming out > of shared memory (memory-backend-file,mem-path=/dev/shmem/foo), while > performing the IO I would like to pass QEMUIOVector buffers

Re: [Qemu-devel] [PATCH v7 33/38] libqtest: Merge qtest_{in, out}[bwl]() with {in, out}[bwl]()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-devel] Suggested Wiki Update

On 12.09.2017 13:18, Cornelia Huck wrote: > On Tue, 12 Sep 2017 10:57:14 +0200 > Viktor Mihajlovski wrote: > >> Hi, >> >> the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot >> is slightly outdated since proper DHCP based netboot support for

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > This command line fragment looks correct to me. For me, it seems to > > work. I'm starting a first qemu in the background with default locking > > options: > > > > $

Re: [Qemu-devel] question： I found a bug which will lead to qemu crash

Am 12.09.2017 um 13:17 hat WangJie (Captain) geschrieben: > Hi, Kevin. > > I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and > current master is OK. > So I git-bisect the master branch，and I found the patch you commited (block: > Decouple throttling from

[Qemu-devel] [Bug 1135567] Re: QXL crashes a Windows 7 guest if host goes into screensaver

Hello, Obviously my hardware configuration and versions etc. have changed. Also, I have taken to not using screensavers in the virtual machines anymore i.e. disabled. BUT: I have set it up as similarly as possible and the crash/freeze/hang up with current versions of the drivers seems to be

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

Hi Peter On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: >> It does not really make sense to dump memory that is not there. >> >> Moreover, that fixes a segmentation fault when calling dump-guest-memory >> with

Re: [Qemu-devel] [PATCH v7 29/38] libqtest: Merge qtest_init() into qtest_start()

On 11.09.2017 19:20, Eric Blake wrote: > Remove the trivial wrapper qtest_init(), and change qtest_start() > to no longer implicitly set global_qtest, to make it obvious in the > rest of the testsuite where we are still relying on global_qtest. > Everything now uses qtest_start() (and friends) and

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Tue, 5 Sep 2017 19:12:26 -0300 Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: > > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost > > wrote: > [...] > > >> diff --git a/hw/arm/stm32f205_soc.c

[Qemu-devel] [PATCH v3 5/7] block: convert crypto driver to bdrv_co_preadv|pwritev

Make the crypto driver implement the bdrv_co_preadv|pwritev callbacks, and also use bdrv_co_preadv|pwritev for I/O with the protocol driver beneath. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 104 +++-- 1 file

[Qemu-devel] [PATCH v3 1/7] block: use 1 MB bounce buffers for crypto instead of 16KB

Using 16KB bounce buffers creates a significant performance penalty for I/O to encrypted volumes on storage which high I/O latency (rotating rust & network drives), because it triggers lots of fairly small I/O operations. On tests with rotating rust, and cache=none|directsync, write speed

Re: [Qemu-devel] [PATCH v3] spapr_cpu_core: cleaning up qdev_get_machine() calls

On Tue, Sep 12, 2017 at 08:51:21AM +0200, Greg Kurz wrote: > This patch removes the qdev_get_machine() calls that are made > in spapr_cpu_core.c in situations where we can get an existing > pointer for the MachineState by either passing it as an argument > to the function or by using other already

Re: [Qemu-devel] [PATCH v7 30/38] qtest: Avoid passing raw strings through hmp()

On 11.09.2017 19:20, Eric Blake wrote: > hmp() passes its string argument through the sprintf() family; > with a proper attribute, gcc -Wformat warns us when we do something > dangerous like passing a non-constant format string. Fortunately, > all our strings were safe, but checking whether the

[Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

Currently before submitting a series, devs should run checkpatch.pl across each patch to be submitted. This can be automated using a command such as: git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' This is rather long winded to type, so this patch introduces a new flag

Re: [Qemu-devel] [PATCH v7 32/38] libqtest: Merge qtest_irq*() with irq*()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-devel] Suggested Wiki Update

On Tue, 12 Sep 2017 10:57:14 +0200 Viktor Mihajlovski wrote: > Hi, > > the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot > is slightly outdated since proper DHCP based netboot support for s390x > has been implemented by the series ending with

[Qemu-devel] question： I found a bug which will lead to qemu crash

Hi, Kevin. I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and current master is OK. So I git-bisect the master branch，and I found the patch you commited (block: Decouple throttling from BlockDriverState) lead the bug into qemu. The patch which lead the bug into qemu:

[Qemu-devel] [PATCH v3 3/7] block: fix data type casting for crypto payload offset

The crypto APIs report the offset of the data payload as an uint64_t type, but the block driver is casting to size_t or ssize_t which will potentially truncate. Most of the block APIs use int64_t for offsets meanwhile, so even if using uint64_t in the crypto block driver we are still at risk of

[Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector size in APIs

While current encryption schemes all have a fixed sector size of 512 bytes, this is not guaranteed to be the case in future. Expose the sector size in the APIs so the block layer can remove assumptions about fixed 512 byte sectors. Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH v3 0/7] Misc improvements to crypto block driver

This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html This collection of patches first improves the performance of the crypto block driver and then does various cleanups to improve

[Qemu-devel] [PATCH v3 6/7] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

Instead of sector offset, take the bytes offset when encrypting or decrypting data. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 12 block/qcow.c | 7 +-- block/qcow2-cluster.c | 8 +++- block/qcow2.c | 4 ++--

Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot

On Mon, 11 Sep 2017 12:33:47 +0200 Viktor Mihajlovski wrote: > Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] > allows the DHCP server to return a s390-specific bootfile if wanted. > DHCP servers not configured for the option (or not yet

Re: [Qemu-devel] [PATCH v2] Replace round_page() with TARGET_PAGE_ALIGN()

On 11.09.2017 22:16, Kamil Rytarowski wrote: > This change fixes conflict with the DragonFly BSD headers. > > Signed-off-by: Kamil Rytarowski > --- > hw/ppc/mac_newworld.c | 11 +++ > hw/ppc/mac_oldworld.c | 11 +++ > 2 files changed, 6 insertions(+), 16

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

On Tue, 12 Sep 2017 10:11:32 +0100 Peter Maydell wrote: > On 12 September 2017 at 08:40, Igor Mammedov wrote: > > On Mon, 11 Sep 2017 14:33:03 +0100 > > Peter Maydell wrote: > >> It's not possible in all cases to set a

Re: [Qemu-devel] Suggested Wiki Update

Looks good to me. I somehow lost my wiki password, so maybe Conny can do the update until this is fixed On 09/12/2017 10:57 AM, Viktor Mihajlovski wrote: > Hi, > > the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot > is slightly outdated since proper DHCP based netboot

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Tue, 5 Sep 2017 14:47:52 -0700 Alistair Francis wrote: > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > >> there are 2 use cases to deal with: > >> 1: fixed CPU models

[Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as sector size in crypto driver

Use the qcrypto_block_get_sector_size() value in the block crypto driver instead of hardcoding 512 as the sector size. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH v3 7/7] block: support passthrough of BDRV_REQ_FUA in crypto driver

The BDRV_REQ_FUA flag can trivially be allowed in the crypt driver as a passthrough to the underlying block driver. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/crypto.c

Re: [Qemu-devel] loading bitmaps in invalidate_cache fails

Am 11.09.2017 um 18:51 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi Kevin! > > I'm confused with relations of permissions and invalidation, can you please > help? > > Now dirty bitmaps are loaded in invalidate_cache. Here is a problem with > migration: > > 1. destination starts (inactive)

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > This command line fragment looks correct to me. For me, it seems to > work. I'm starting a first qemu in the background with default locking > options: > > $ x86_64-softmmu/qemu-system-x86_64 -hda /tmp/test.qcow2 > > And then

Re: [Qemu-devel] [RFC PATCH qemu 3/4] memory: Share flat views and dispatch trees between address spaces

On 12/09/17 17:12, Paolo Bonzini wrote: > On 12/09/2017 07:55, Alexey Kardashevskiy wrote: >> On 12/09/17 01:30, Paolo Bonzini wrote: >>> On 11/09/2017 14:08, Alexey Kardashevskiy wrote: > Ok, this makes sense. Maybe it should be a flatview rather than an > AddressSpaceDispatch (a

Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code

Am 10.08.2017 um 00:43 hat Paolo Bonzini geschrieben: > > > - Original Message - > > From: "Eric Blake" > > To: "Paolo Bonzini" , qemu-devel@nongnu.org > > Cc: kw...@redhat.com, qemu-bl...@nongnu.org > > Sent: Thursday, August 10, 2017 12:18:54 AM

Re: [Qemu-devel] [PATCH v2 3/4] block: convert crypto driver to bdrv_co_preadv|pwritev

On Thu, Aug 31, 2017 at 10:08:00AM -0500, Eric Blake wrote: > On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > > Make the crypto driver implement the bdrv_co_preadv|pwritev > > callbacks, and also use bdrv_co_preadv|pwritev for I/O > > with the protocol driver beneath. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v7 28/38] libqtest: Add qtest_[v]startf()

On 11.09.2017 19:20, Eric Blake wrote: > We have several callers that were formatting the argument strings > themselves; consolidate this effort by adding new convenience > functions directly in libqtest, and update all call-sites that > can benefit from it. [...] > diff --git a/tests/libqtest.c

Re: [Qemu-devel] question: qemu will crash when attach and detach a disk which configured qos for a while

On Mon, Sep 11, 2017 at 09:24:23AM +0800, WangJie (Captain) wrote: > Hi, I maybe find a bug about qemu-kvm(version:2.8.1.1) Can you reproduce the segfault with qemu.git/master? > *Segmentation fault info:* > Program received signal SIGSEGV, Segmentation fault. > 0x7f5469220607 in

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: > ioh3420_interrupts_init() pass error message to local_err, then > propagate it to errp by error_propagate(), which is not necessary. > So eliminate it and pass errp directly instead of local_err. > > Cc: "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup

On Mon, Sep 11, 2017 at 12:13:56PM +0200, Greg Kurz wrote: > --- > > Greg Kurz (2): > spapr_pci: convert sprintf() to g_strdup_printf() > spapr_pci: don't create 64-bit MMIO window if we don't need to Applied to ppc-for-2.11. -- David Gibson| I'll have my music

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Sat, 9 Sep 2017 17:30:14 -0300 Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 03:46:07PM -0700, Alistair Francis wrote: > > On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost > > wrote: > > > On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: > These are never used by "check", with one exception that does not need > $QEMU_OPTIONS. Keep them in common.rc, which will be soon included only > by the tests. > > Signed-off-by: Paolo Bonzini > diff --git

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: > Split "check" parts from tests part. > > For the directory setup, the actual computation of directories goes > in "check", while the sanity checks go in the tests. > > Signed-off-by: Paolo Bonzini Same comment as for

Re: [Qemu-devel] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-devel] [PATCH v4 15/21] s390x: print CPU definitions in sorted order

On 09/11/2017 05:21 PM, David Hildenbrand wrote: > Other architectures provide nicely sorted lists, let's do it similarly on > s390x. > > While at it, clean up the code we have to touch either way. > > Signed-off-by: David Hildenbrand looks much nicer now, with the most

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

On Tue, Sep 12, 2017 at 01:32:05PM +0200, Kevin Wolf wrote: > Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > > This command line fragment looks correct to me. For me, it seems to > > > work. I'm starting a first qemu

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 05/20] hw/arm/smmuv3: Skeleton

On Fri Sep 08, 2017 at 05:18:19PM +0200, Auger Eric wrote: > Hi Linu, > > On 08/09/2017 12:52, Linu Cherian wrote: > > Hi Eric, > > > > On Fri Sep 01, 2017 at 07:21:08PM +0200, Eric Auger wrote: > >> From: Prem Mallappa > >> > >> This patch implements a skeleton for

Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c

On 11.09.2017 19:19, Eric Blake wrote: > Commit 2f8b2767 originally added qpci_plug_device_test() and > qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. > Later, commit cf716b31 moved one half of the pair to pci.c > when adding PPC64 support. Keep the implementations of the > two

Re: [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency

On 11/09/2017 23:01, Philippe Mathieu-Daudé wrote: > this fixes running 'make check-unit' without running 'make all' beforehand: > > $ make check-unit > ... > GTESTER tests/test-qga > ** > ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): > Failed to execute child

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

Am 11.09.2017 um 20:24 schrieb Peter Maydell: > I've also turned on a tci compile check on my pre-merge tests. > (It doesn't pass "make check" for me, though...) thanks -- PMM "make check-qtest-ppc64" fails for me, too. Thomas, this seems to be again the well known timing problem in

Re: [Qemu-devel] [PATCH v7 14/38] libqos: Use explicit QTestState for rtas operations

On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all rtas test > functionality to pass in an explicit QTestState, adjusting all > callers. > > Signed-off-by: Eric Blake > > --- > v7: catch a couple more operations, drop R-b > --- >

Re: [Qemu-devel] [PATCH 02/27] libvhost-user: drop dependency on glib

Hi Marc-André, On 08/23/2017 01:19 PM, Marc-André Lureau wrote: libvhost-user is meant to be free of glib dependency. Make sure it is by droping qemu/osdep.h (which included glib.h) This fixes a bad malloc()/g_free() pair. Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

On 12/09/2017 12:40, Kevin Wolf wrote: > Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: >> Split "check" parts from tests part. >> >> For the directory setup, the actual computation of directories goes >> in "check", while the sanity checks go in the tests. >> >> Signed-off-by: Paolo

[Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html v4:

[Qemu-devel] [PATCH v5 03/12] ui: convert key events to QKeyCodes immediately

Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index

[Qemu-devel] [PATCH v5 01/12] ui: add keycodemapdb repository as a GIT submodule

The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v5 10/12] ui: convert the SDL2 frontend to keycodemapdb

The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

[Qemu-devel] [PATCH v5 04/12] ui: don't export qemu_input_event_new_key

All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h

[Qemu-devel] [PATCH v5 09/12] ui: convert cocoa frontend to keycodemapdb

Replace the mac_to_qkeycode_map table with automatically generated table. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 3 + ui/Makefile.objs | 1 + ui/cocoa.m | 129 +

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

> > On 12/09/2017 03:41, Gonglei (Arei) wrote: > > > >> -Original Message- > >> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > >> Sent: Tuesday, September 12, 2017 2:38 AM > >> To: Gonglei (Arei) > >> Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; > >>

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb Type: series Message-id: 20170912123744.14730-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb Message-id:

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

On 12/09/2017 14:51, Kevin Wolf wrote: > Am 12.09.2017 um 14:28 hat Paolo Bonzini geschrieben: >> On 12/09/2017 12:31, Kevin Wolf wrote: >>> Hm, does this mean that instead of ./check failing when a binary is >>> missing, we try each test case now and each one fails with the same >>> error

Re: [Qemu-devel] [PATCH v4 13/21] target/s390x: use "core-id" for cpu number/address/id handling

On Mon, 11 Sep 2017 17:21:42 +0200 David Hildenbrand wrote: > Some time ago we discussed that using "id" as property name is not the > right thing to do, as it is a reserved property for other devices and > will not work with device_add. > > Switch to the term "core-id"

[Qemu-devel] [PATCH v4 0/3] Improve websock response / error handling

A followup of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01176.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01974.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02108.html Changed in v4: - Use time() instead of gettimeofday() to

[Qemu-devel] [PATCH v4 3/3] io: use case insensitive check for Connection & Upgrade websock headers

When checking the value of the Connection and Upgrade HTTP headers the websock RFC (6455) requires the comparison to be case insensitive. The Connection value should be an exact match not a substring. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] question： I found a bug which will lead to qemu crash

On Tue 12 Sep 2017 01:17:38 PM CEST, WangJie (Captain) wrote: > Hi, Kevin. > > I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and > current master is OK. > So I git-bisect the master branch，and I found the patch you commited (block: > Decouple throttling from

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 3/3] tests/hmp: test "none" machine with memory

On 09/11/2017 11:20 AM, Laurent Vivier wrote: and add a test case of dump-guest-memory without "[begin length]" parameters. Signed-off-by: Laurent Vivier --- tests/test-hmp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-hmp.c b/tests/test-hmp.c

Re: [Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

On Tue, Sep 12, 2017 at 01:37:37PM +0100, Daniel P. Berrange wrote: > Replace the keymap_qcode table with automatically generated > tables. > > Missing entries in keymap_qcode now fixed: > > Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK > Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK > Q_KEY_CODE_STOP

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

The share-rw=on option belongs to -device, not to -drive/-blockdev. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716028 Title: qemu 2.10 locks images with no feature flag Status in QEMU: New

Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG

On Mon, 11 Sep 2017 17:21:40 +0200 David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 is

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

On 12/09/2017 14:57, Kevin Wolf wrote: > Am 12.09.2017 um 14:31 hat Paolo Bonzini geschrieben: >> On 12/09/2017 12:40, Kevin Wolf wrote: >>> Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: Split "check" parts from tests part. For the directory setup, the actual computation of

Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id

On 12.09.2017 15:09, Igor Mammedov wrote: > On Mon, 11 Sep 2017 17:21:43 +0200 > David Hildenbrand wrote: > >> Adapt to the new term "core_id". While at it, fix the type and drop the >> initialization to 0 (which is superfluous). >> >> Reviewed-by: Matthew Rosato

[Qemu-devel] [PATCH v4 2/3] io: include full error message in websocket handshake trace

When the websocket handshake fails it is useful to log the real error message via the trace points for debugging purposes. Fixes bug: #1715186 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- io/channel-websock.c | 7 ---

Re: [Qemu-devel] [PATCH v15 1/5] lib/xbitmap: Introduce xbitmap

On 09/11/2017 08:54 PM, Matthew Wilcox wrote: On Mon, Aug 28, 2017 at 06:08:29PM +0800, Wei Wang wrote: From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned

Re: [Qemu-devel] [PATCH v7 28/38] libqtest: Add qtest_[v]startf()

On 09/12/2017 05:14 AM, Thomas Huth wrote: > On 11.09.2017 19:20, Eric Blake wrote: >> We have several callers that were formatting the argument strings >> themselves; consolidate this effort by adding new convenience >> functions directly in libqtest, and update all call-sites that >> can benefit

Re: [Qemu-devel] [PATCH v4 18/21] s390x: implement query-hotpluggable-cpus

On Mon, 11 Sep 2017 17:21:47 +0200 David Hildenbrand wrote: > CPU hotplug is only possible on a per core basis on s390x. > > As we now have ms->possible_cpus, we can get rid of the global variable > cpu_states. > > While rewriting s390_cpu_addr2state() completely to be based

Re: [Qemu-devel] Suggested Wiki Update

On 12.09.2017 13:25, Thomas Huth wrote: > On 12.09.2017 13:18, Cornelia Huck wrote: [...] >> >> Looks good. >> >> Can you perhaps add a sentence that the base support is available with >> 2.9 and netboot with 2.10? ('Overview' looks like a good place for >> that.) > > FWIW, I think it would also

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Tue, Sep 12, 2017 at 12:22:14PM +0200, Igor Mammedov wrote: > On Sat, 9 Sep 2017 17:30:14 -0300 > Eduardo Habkost wrote: > > > On Tue, Sep 05, 2017 at 03:46:07PM -0700, Alistair Francis wrote: > > > On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost >

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Tue, 5 Sep 2017 18:31:52 -0300 Eduardo Habkost wrote: > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > > there are 2 use cases to deal with: > > 1: fixed CPU models per board/soc > > 2: boards with user configurable cpu_model and fallback to > >

Re: [Qemu-devel] [PATCH 01/27] glib-compat: move G_SOURCE_CONTINUE/REMOVE there

On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Acked-by: Philippe Mathieu-Daudé --- include/glib-compat.h | 7 +++ contrib/vhost-user-scsi/vhost-user-scsi.c | 8 2 files

[Qemu-devel] [PATCH v5 12/12] display: convert XenInput keyboard to keycodemapdb

Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 133

[Qemu-devel] [PATCH v5 02/12] ui: convert common input code to keycodemapdb

Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

Am 12.09.2017 um 14:28 hat Paolo Bonzini geschrieben: > On 12/09/2017 12:31, Kevin Wolf wrote: > > Hm, does this mean that instead of ./check failing when a binary is > > missing, we try each test case now and each one fails with the same > > error message? > > > > *tries it out* > > > > Okay,

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

On Tue, Sep 12, 2017 at 02:11:59PM +0200, Igor Mammedov wrote: > On Tue, 5 Sep 2017 18:31:52 -0300 > Eduardo Habkost wrote: > > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > > > there are 2 use cases to deal with: > > > 1: fixed CPU models per

Re: [Qemu-devel] [PATCH v5 3/3] watchdog: Allow setting action on the fly

On Thu, Sep 07, 2017 at 10:05:26AM +0200, Michal Privoznik wrote: > Currently, the only time that users can set watchdog action is at > the start as all we expose is this -watchdog-action command line > argument. This is suboptimal when users want to plug the device > later via monitor.

Re: [Qemu-devel] [PATCH 02/27] libvhost-user: drop dependency on glib

Hi - Original Message - > Hi Marc-André, > > On 08/23/2017 01:19 PM, Marc-André Lureau wrote: > > libvhost-user is meant to be free of glib dependency. Make sure it is > > by droping qemu/osdep.h (which included glib.h) > > > > This fixes a bad malloc()/g_free() pair. > > > >

Re: [Qemu-devel] [PATCH 02/27] libvhost-user: drop dependency on glib

On 09/12/2017 10:13 AM, Marc-André Lureau wrote: Hi - Original Message - Hi Marc-André, On 08/23/2017 01:19 PM, Marc-André Lureau wrote: libvhost-user is meant to be free of glib dependency. Make sure it is by droping qemu/osdep.h (which included glib.h) This fixes a bad

Re: [Qemu-devel] [PATCH v7 09/38] libqos: Track QTestState with QVirtioBus

On 09/12/2017 02:21 AM, Thomas Huth wrote: > On 11.09.2017 19:19, Eric Blake wrote: >> When initializing a QVirtioDevice (which always has an associated >> QVirtioBus), we want to track which QTestState to use for all >> I/O processed through that bus and device. Copy the paradigm >> used for

Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c

On 09/12/2017 02:29 AM, Thomas Huth wrote: > On 11.09.2017 19:19, Eric Blake wrote: >> Commit 2f8b2767 originally added qpci_plug_device_test() and >> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. >> Later, commit cf716b31 moved one half of the pair to pci.c >> when adding PPC64

Re: [Qemu-devel] question： I found a bug which will lead to qemu crash

Hi, Eric I used git-bisect and fount the patch you commited（throttle: Remove block from group on hot-unplug） fixed the bug which I presented to Kevin the patch which fixed the bug is：

Re: [Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

On 09/12/2017 12:24 PM, Paolo Bonzini wrote: > On 12/09/2017 18:22, Daniel P. Berrange wrote: >> On Tue, Sep 12, 2017 at 06:14:57PM +0200, Paolo Bonzini wrote: >>> On 12/09/2017 18:12, Daniel P. Berrange wrote: On Tue, Sep 12, 2017 at 05:52:18PM +0200, Paolo Bonzini wrote: > On

[Qemu-devel] [PATCH 01/19] target/arm: Implement MSR/MRS access to NS banked registers

In v8M the MSR and MRS instructions have extra register value encodings to allow secure code to access the non-secure banked version of various special registers. (We don't implement the MSPLIM_NS or PSPLIM_NS aliases, because we don't currently implement the stack limit registers at all.)

[Qemu-devel] [PATCH 12/19] nvic: In escalation to HardFault, support HF not being priority -1

When escalating to HardFault, we must go into Lockup if we can't take the synchronous HardFault because the current execution priority is already at or below the priority of HardFault. In v7M HF is always priority -1 so a simple < 0 comparison sufficed; in v8M the priority of HardFault can vary

[Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete

Update armv7m_nvic_acknowledge_irq() and armv7m_nvic_complete_irq() to handle banked exceptions: * acknowledge needs to use the correct vector, which may be in sec_vectors[] * acknowledge needs to return to its caller whether the exception should be taken to secure or non-secure state *

Re: [Qemu-devel] Monitor socket will close after parse command error. Qemu-2.6.2

* Sam (batmanu...@gmail.com) wrote: > [gangyewei-3@yf-mos-test-net07 tests]$ telnet 127.0.0.1 55919 > Trying 127.0.0.1... > Connected to 127.0.0.1. > Escape character is '^]'. > QEMU 2.6.2 monitor - type 'help' for more information > (qemu) chardev-add >

[Qemu-devel] [PATCH 17/19] nvic: Make ICSR banked for v8M

The ICSR NVIC register is banked for v8M. This doesn't require any new state, but it does mean that some bits are controlled by BFHNFNMINS and some bits must work with the correct banked exception. There is also a new in v8M PENDNMICLR bit. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 07/16] target/arm: Align vector registers

On 12 September 2017 at 17:25, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index

Re: [Qemu-devel] [PATCH v4 1/8] hw/i386: Improve some of the warning messages

On Mon, Sep 11, 2017 at 12:52:43PM -0700, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Suggested-by: Eduardo Habkost > Cc: Eduardo Habkost > --- > V4: > - Fixup pc_q35.c message > V3: > - Improve the

Re: [Qemu-devel] [PATCH v2 07/16] target/arm: Align vector registers

Hi Richard, On 09/12/2017 01:25 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 98b9b26fd3..419f008277 100644 ---

[Qemu-devel] [PATCH 03/19] nvic: Add cached vectpending_is_s_banked state

With banked exceptions, just the exception number in s->vectpending is no longer sufficient to uniquely identify the pending exception. Add a vectpending_is_s_banked bool which is true if the exception is using the sec_vectors[] array. Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 05/19] nvic: Implement AIRCR changes for v8M

The Application Interrupt and Reset Control Register has some changes for v8M: * new bits SYSRESETREQS, BFHFNMINS and PRIS: these all have real state if the security extension is implemented and otherwise are constant * the PRIGROUP field is banked between security states * non-secure

[Qemu-devel] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter

Make the armv7m_nvic_set_pending() and armv7m_nvic_clear_pending() functions take a bool indicating whether to pend the secure or non-secure version of a banked interrupt, and update the callsites accordingly. In most callsites we can simply pass the correct security state in; in a couple of

<    1   2   3   4   >