[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread James Clarke
The "0 == 18446744073709551615 = 0" is actually fine, it's just printing "-1" as a 64-bit unsigned integer. Could you please upload the fill output of `file -d /bin/bash 2>&1`? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: get rid of $iam

2017-09-12 Thread Eric Blake
On 09/12/2017 09:44 AM, Paolo Bonzini wrote: > The variable is almost unused, and one of the two uses is actually > uninitialized. > > Signed-off-by: Paolo Bonzini > --- > tests/qemu-iotests/check | 5 + > tests/qemu-iotests/common.rc | 2 +- > 2 files changed, 2

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests: merge "check" and "common"

2017-09-12 Thread Eric Blake
On 09/12/2017 09:44 AM, Paolo Bonzini wrote: > "check" is full of qemu-iotests--specific details. Separating it > from "common" does not make much sense anymore. > > Signed-off-by: Paolo Bonzini > --- > tests/qemu-iotests/check | 533

[Qemu-devel] [PATCH v5 08/22] instrument: [hmp] Add library loader

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- hmp-commands.hx | 32 monitor.c | 39 +++ 2 files changed, 71 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1941e19932..2e8ebe8422 100644

Re: [Qemu-devel] [PATCH 04/10] qemu-iotests: cleanup and fix search for programs

2017-09-12 Thread Eric Blake
On 09/12/2017 04:26 PM, Paolo Bonzini wrote: > > >>> +then >>> +if [ -x "$build_iotests/qemu" ]; then >>> +export QEMU_PROG="$build_iotests/qemu" >>> +elif [ -x "$build_root/$arch-softmmu/qemu-system-$arch" ]; then >>> +export

[Qemu-devel] [PATCH v5 09/22] instrument: Add basic control interface

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile|4 +++ configure |1 + include/qemu/compiler.h | 19 instrument/Makefile.objs|1 + instrument/control.c| 28

[Qemu-devel] [PATCH v5 10/22] instrument: Add support for tracing events

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- .gitignore|1 Makefile |3 + instrument/Makefile.objs |1 instrument/error.h|6 ++ instrument/qemu-instr/types.h | 51 +++

[Qemu-devel] [PATCH v5 11/22] instrument: Track vCPUs

2017-09-12 Thread Lluís Vilanova
Keep a translation between instrumentation's QICPU and CPUState objects to avoid exposing QEMU's internals to instrumentation clients. Signed-off-by: Lluís Vilanova --- cpus-common.c|9 + instrument/control.c | 23 +++

[Qemu-devel] [PATCH v5 12/22] instrument: Add event 'guest_cpu_enter'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- instrument/control.c|9 instrument/events.h |5 instrument/events.inc.h | 11 + instrument/load.c |9 instrument/qemu-instr/control.h | 46

Re: [Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread John Paul Adrian Glaubitz
On 09/12/2017 11:18 PM, James Clarke wrote: > The "0 == 18446744073709551615 = 0" is actually fine, it's just printing > "-1" as a 64-bit unsigned integer. Yeah, I noticed that output was the same on amd64. > Could you please upload the fill > output of `file -d /bin/bash 2>&1`? >

[Qemu-devel] [PATCH v5 13/22] instrument: Support synchronous modification of vCPU state

2017-09-12 Thread Lluís Vilanova
Stops all vCPUs to allow performing management operations like TB invalidations. These are later necessary to ensure translated code does not reference unloaded instrumentation libraries. Signed-off-by: Lluís Vilanova --- instrument/control.c | 66

[Qemu-devel] [PATCH v5 14/22] exec: Add function to synchronously flush TB on a stopped vCPU

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- accel/stubs/tcg-stub.c|3 +++ accel/tcg/translate-all.c |7 +++ include/exec/exec-all.h |1 + 3 files changed, 11 insertions(+) diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index 5dd480b1a2..5226c4a8a4

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread James Clarke
I just ran it myself inside and outside the sh4 chroot. The logging output is the same, with the exception of the final line. Something is happening once it's decided it's elf; looking at file_tryelf, my guess is the fstat call is failing[0]. [0]

[Qemu-devel] [PATCH v5 15/22] instrument: Add event 'guest_cpu_exit'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- instrument/control.c|9 + instrument/events.h |3 +++ instrument/events.inc.h | 11 +++ instrument/load.c | 17 + instrument/qemu-instr/control.h |

[Qemu-devel] [PATCH v5 16/22] instrument: Add event 'guest_cpu_reset'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- instrument/control.c|9 + instrument/events.h |3 +++ instrument/events.inc.h | 11 +++ instrument/load.c |1 + instrument/qemu-instr/control.h |9 +

Re: [Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 22:47, James Clarke wrote: > I just ran it myself inside and outside the sh4 chroot. The logging > output is the same, with the exception of the final line. Something is > happening once it's decided it's elf; looking at file_tryelf, my guess > is the

[Qemu-devel] [PATCH v5 17/22] trace: Introduce a proper structure to describe memory accesses

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h | 15 ++ include/exec/cpu_ldst_useronly_template.h | 15 ++ tcg/tcg-op.c | 22 + trace/mem-internal.h

[Qemu-devel] [PATCH v5 18/22] instrument: Add event 'guest_mem_before_trans'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.target |1 + instrument/control.c| 15 + instrument/control.h| 36 +- instrument/control.inc.h| 16 +++--- instrument/events.h |

[Qemu-devel] [PATCH v5 19/22] instrument: Add event 'guest_mem_before_exec'

2017-09-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h |4 +++ include/exec/cpu_ldst_useronly_template.h |4 +++ include/exec/helper-gen.h |1 + include/exec/helper-proto.h |1 + include/exec/helper-tcg.h

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-09-12 Thread Scott Moser
I see the answer to my question above. 'format' is now driver=qcow2. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716028 Title: qemu 2.10 locks images with no feature flag Status in QEMU:

Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add

2017-09-12 Thread David Hildenbrand
On 12.09.2017 15:55, Igor Mammedov wrote: > On Mon, 11 Sep 2017 17:21:29 +0200 > David Hildenbrand wrote: > >> The first patches are a bunch of cleanups. I decided to go the >> extra mile and implement CPU hotplug via "device_add", as well as >> "query-hotpluggable-cpus". >> >>

Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 17:21:29 +0200 David Hildenbrand wrote: > The first patches are a bunch of cleanups. I decided to go the > extra mile and implement CPU hotplug via "device_add", as well as > "query-hotpluggable-cpus". > > On s390x, only complete cores can be plugged. CPU

[Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread Laurent Vivier
Fix aarch64 and ppc when dump-guest-memory is used with none machine type and no CPU. The other machine types don't have the problem. Update test-hmp, to test none machine type with (2 MB) and without memory, and add a test to test dump-quest-memory without filter parameters (it needs the fix

[Qemu-devel] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-12 Thread Laurent Vivier
Running QEMU with qemu-system-aarch64 -M none -nographic -m 256 and executing dump-guest-memory /dev/null 0 8192 results in segfault Fix by checking if we have CPU, and exit with error if there is no CPU: (qemu) dump-guest-memory /dev/null this feature or command is not currently

Re: [Qemu-devel] [PATCH v4 18/21] s390x: implement query-hotpluggable-cpus

2017-09-12 Thread David Hildenbrand
On 12.09.2017 15:43, Igor Mammedov wrote: > On Mon, 11 Sep 2017 17:21:47 +0200 > David Hildenbrand wrote: > >> CPU hotplug is only possible on a per core basis on s390x. >> >> As we now have ms->possible_cpus, we can get rid of the global variable >> cpu_states. >> >> While

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault Message-id:

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 03:46:34PM +0200, Gerd Hoffmann wrote: > Hi, > > > The keycodemapdb code is designed to be used as a git sub-module, it > > is > > not an external dependancy you need installed before use. In this > > version, > > however, the sub-module is not directly use. Instead all

[Qemu-devel] MIPS 'move' insn emulation

2017-09-12 Thread Sergey Smolov
Hello, List! I run MIPS assembler program on QEMU. The program is just a sample, here is the code: .text addiu $8, $zero, 0x7 move $9, $8 sll $8, $8, 3 add $8, $8, $9 The program finishes on QEMU with the following values for registers, and it's ok: $8 - 0x3f $9 - 0x7 Now

[Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion

2017-09-12 Thread Farhan Ali
Virtio GPU code currently only supports litte endian format, and so using the Virtio GPU device on a big endian machine does not work. Let's fix it by supporting the correct host cpu byte order. Signed-off-by: Farhan Ali --- hw/display/virtio-gpu.c | 53

[Qemu-devel] [PATCH v1 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-12 Thread Farhan Ali
Wire up the virtio-gpu device for the CCW bus. The virtio-gpu is a virtio-1 device, so disable revision 0. Signed-off-by: Farhan Ali Acked-by: Christian Borntraeger --- hw/s390x/virtio-ccw.c | 54

Re: [Qemu-devel] [PATCH 4/4] s390x/css: fix incorrect length indication

2017-09-12 Thread Cornelia Huck
On Mon, 11 Sep 2017 13:36:29 +0200 Halil Pasic wrote: > On 09/11/2017 12:07 PM, Cornelia Huck wrote: > > On Fri, 8 Sep 2017 17:24:46 +0200 > > Halil Pasic wrote: > > > >> We report incorrect length via SCSW program check instead of

[Qemu-devel] [PATCH 01/10] qemu-iotests: remove dead code

2017-09-12 Thread Paolo Bonzini
This includes shell function, shell variables and command line options (randomize.awk does not exist). Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 28 - tests/qemu-iotests/common| 23 --

[Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests

2017-09-12 Thread Paolo Bonzini
The purpose of this series is to separate the "check" sources from the tests. After these patches, common.config is reduced to simple shell initialization, and common.rc is only included by the tests. Along the way, a lot of dead code is removed too. In v2, the following patches:

[Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized variable

2017-09-12 Thread Paolo Bonzini
The variable is used in "common" but defined only after the file is sourced. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 2 -- tests/qemu-iotests/common | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/check

[Qemu-devel] [PATCH 09/10] qemu-iotests: get rid of $iam

2017-09-12 Thread Paolo Bonzini
The variable is almost unused, and one of the two uses is actually uninitialized. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 5 + tests/qemu-iotests/common.rc | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [QGA] Bug of qga?

2017-09-12 Thread Sameeh Jubran
Hi Sam, Can you share the whole python script you use in order to execute the commands? This wasn't clear from what you've sent earlier, however we already tried to reproduce the issue using ncat while manually inserting the JSON strings for the route -n and the ping commands. Here is the test

Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-12 Thread Greg Kurz
On Tue, 12 Sep 2017 16:01:48 +0200 Laurent Vivier wrote: > Running QEMU with > qemu-system-aarch64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there

Re: [Qemu-devel] [PATCH 8/8] tcg/i386: Add vector operations

2017-09-12 Thread Richard Henderson
On 09/11/2017 02:07 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 09/08/2017 06:10 AM, Alex Bennée wrote: >>> Also this commit breaks RISU: >>> >>> qemu-aarch64 build/aarch64-linux-gnu/risu >>>

Re: [Qemu-devel] question: I found a bug which will lead to qemu crash

2017-09-12 Thread Alberto Garcia
On Tue 12 Sep 2017 03:37:09 PM CEST, WangJie (Captain) wrote: > the patch which fixed the bug is: > https://github.com/qemu/qemu/commit/1606e4cf8a976513ecac70ad6642a7ec45744cf5#diff-7cb66df56045598b75a219eebc27efb6 Oh, now I remember. Here's the bug report:

Re: [Qemu-devel] [PATCH 3/4] s390x/css: remove dubious error handling branch

2017-09-12 Thread Cornelia Huck
On Mon, 11 Sep 2017 15:08:52 +0200 Halil Pasic wrote: > On 09/11/2017 11:48 AM, Cornelia Huck wrote: > > On Fri, 8 Sep 2017 17:24:45 +0200 > > Halil Pasic wrote: > >> The case in question actually never happens. Let us get rid of the dead >

[Qemu-devel] [PATCH v3 3/3] tests/hmp: test "none" machine with memory

2017-09-12 Thread Laurent Vivier
and add a test case of dump-guest-memory without "[begin length]" parameters. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- tests/test-hmp.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/test-hmp.c b/tests/test-hmp.c index

[Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-12 Thread Laurent Vivier
Running QEMU with qemu-system-ppc64 -M none -nographic -m 256 and executing dump-guest-memory /dev/null 0 8192 results in segfault Fix by checking if we have CPU, and exit with error if there is no CPU: (qemu) dump-guest-memory /dev/null this feature or command is not currently

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Igor Mammedov
On Tue, 12 Sep 2017 09:53:22 -0300 Eduardo Habkost wrote: > On Tue, Sep 12, 2017 at 02:11:59PM +0200, Igor Mammedov wrote: > > On Tue, 5 Sep 2017 18:31:52 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor

Re: [Qemu-devel] [PATCH v5 03/12] ui: convert key events to QKeyCodes immediately

2017-09-12 Thread Gerd Hoffmann
On Tue, 2017-09-12 at 13:37 +0100, Daniel P. Berrange wrote: > Always use QKeyCode in the InputKeyEvent struct, by converting key > numbers to QKeyCode at the time the event is created. > > Signed-off-by: Daniel P. Berrange qmp_input_send_event() must be handled too as

Re: [Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Gerd Hoffmann
Hi, > From what I can see the guest OS will read this bitmap when it first > probes the virtio device, and never updates it.  If so, then is it > actually a problem if we don't preserve the same map across save/ > restore/migrate ? virtio-input config space size isn't fixed, instead it'll take

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-12 Thread Gerd Hoffmann
Hi, > The keycodemapdb code is designed to be used as a git sub-module, it > is > not an external dependancy you need installed before use. In this > version, > however, the sub-module is not directly use. Instead all the > generated > files are checked into GIT. The downside to this is that we

Re: [Qemu-devel] [PATCH v4 18/21] s390x: implement query-hotpluggable-cpus

2017-09-12 Thread Thomas Huth
On 12.09.2017 16:03, David Hildenbrand wrote: > On 12.09.2017 15:43, Igor Mammedov wrote: >> On Mon, 11 Sep 2017 17:21:47 +0200 >> David Hildenbrand wrote: >> >>> CPU hotplug is only possible on a per core basis on s390x. >>> >>> As we now have ms->possible_cpus, we can get rid

[Qemu-devel] [PATCH] xen_disk: avoid use of g_malloc0_n()

2017-09-12 Thread Jan Beulich
Prefer g_new() / g_new0() to be farther backwards compatible with older glib versions. As there's no point in zeroing the allocation here (the loop right afterwards fully initializes the memory), use the former. Signed-off-by: Jan Beulich --- a/hw/block/xen_disk.c +++

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 15:19, Daniel P. Berrange wrote: > My POV is that we should a) never check generated files into GIT, and > we should use the submodule in such a way that it is indistinguish > from the content of the submodule being part of the main GIT repo. AFAICT

[Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390

2017-09-12 Thread Farhan Ali
These patches wire up the virtio-gpu device for CCW bus for S390. For the S390 architecture which does not natively support any graphics device, virtio gpu in 2D mode could be used to emulate a simple graphics card and use VNC as the display. eg: qemu-system-s390x ... -device

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 15:14, Sergey Smolov wrote: > I've the code I probably need to modify in target/mips/translate.c: > > [code] > > static void gen_logic(DisasContext *ctx, uint32_t opc, > int rd, int rs, int rt) > { > ... > } else if (rs != 0 && rt ==

Re: [Qemu-devel] [PATCH] xen_disk: avoid use of g_malloc0_n()

2017-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2017 07:24 > To: qemu-devel@nongnu.org > Cc: Paul Durrant ; Stefano Stabellini > ; xen-devel > Subject: [PATCH]

[Qemu-devel] [PATCH 02/10] qemu-iotests: get rid of AWK_PROG

2017-09-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 4 ++-- tests/qemu-iotests/common| 2 +- tests/qemu-iotests/common.config | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check

[Qemu-devel] [PATCH 04/10] qemu-iotests: cleanup and fix search for programs

2017-09-12 Thread Paolo Bonzini
Instead of ./check failing when a binary is missing, we try each test case now and each one fails with tons of test case diffs. Also, all the variables were initialized by "check" prior to "common" being sourced, and then (uselessly) checked for emptiness again in "check". Centralize the search

[Qemu-devel] [PATCH 03/10] qemu-iotests: move "check" code out of common.rc

2017-09-12 Thread Paolo Bonzini
Some functions in common.rc are never used by the tests. Move them out of that file and into common, which is already included only by "check". Code that actually *is* common to "check" and tests can be placed in common.config. Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config

2017-09-12 Thread Paolo Bonzini
Split "check" parts from tests part. For the directory setup, the actual computation of directories goes in "check", while the sanity checks go in the tests. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/common| 24

[Qemu-devel] [PATCH 05/10] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

2017-09-12 Thread Paolo Bonzini
These are never used by "check", with one exception that does not need $QEMU_OPTIONS. Keep them in common.rc, which will be soon included only by the tests. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/039.out | 10 +++--- tests/qemu-iotests/061.out | 4

[Qemu-devel] [PATCH 10/10] qemu-iotests: merge "check" and "common"

2017-09-12 Thread Paolo Bonzini
"check" is full of qemu-iotests--specific details. Separating it from "common" does not make much sense anymore. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 533 +++- tests/qemu-iotests/common | 552

[Qemu-devel] [PATCH 06/10] qemu-iotests: do not include common.rc in "check"

2017-09-12 Thread Paolo Bonzini
It only provides functions used by the test programs. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 6 -- tests/qemu-iotests/common.rc | 13 + 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/tests/qemu-iotests/check

Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-12 Thread Greg Kurz
On Tue, 12 Sep 2017 16:01:47 +0200 Laurent Vivier wrote: > Running QEMU with > qemu-system-ppc64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread Thomas Huth
On 12.09.2017 16:46, Greg Kurz wrote: > On Tue, 12 Sep 2017 16:01:46 +0200 > Laurent Vivier wrote: > >> Fix aarch64 and ppc when dump-guest-memory is >> used with none machine type and no CPU. >> >> The other machine types don't have the problem. >> >> Update test-hmp, to

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-12 Thread Sergey Smolov
On 12.09.2017 17:32, Peter Maydell wrote: On 12 September 2017 at 15:14, Sergey Smolov wrote: I've the code I probably need to modify in target/mips/translate.c: [code] static void gen_logic(DisasContext *ctx, uint32_t opc, int rd, int rs, int rt) {

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread Greg Kurz
On Tue, 12 Sep 2017 16:01:46 +0200 Laurent Vivier wrote: > Fix aarch64 and ppc when dump-guest-memory is > used with none machine type and no CPU. > > The other machine types don't have the problem. > > Update test-hmp, to test none machine type > with (2 MB) and without

[Qemu-devel] [PATCH v3 5/7] io: Ignore websocket PING and PONG frames

2017-09-12 Thread Brandon Carpenter
Keep pings and gratuitous pongs generated by web browsers from killing websocket connections. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v3 1/7] io: Always remove an old channel watch before adding a new one

2017-09-12 Thread Brandon Carpenter
Also set saved handle to zero when removing without adding a new watch. Signed-off-by: Brandon Carpenter Reviewed-by: Paolo Bonzini Reviewed-by: Daniel P. Berrange --- ui/vnc-auth-vencrypt.c | 3 +++ ui/vnc-ws.c

[Qemu-devel] [PATCH v3 3/7] io: Add support for fragmented websocket binary frames

2017-09-12 Thread Brandon Carpenter
Allows fragmented binary frames by saving the previous opcode. Handles the case where an intermediary (i.e., web proxy) fragments frames originally sent unfragmented by the client. Signed-off-by: Brandon Carpenter --- include/io/channel-websock.h | 1 +

[Qemu-devel] [PATCH v3 7/7] io: Attempt to send websocket close messages to client

2017-09-12 Thread Brandon Carpenter
Make a best effort attempt to close websocket connections according to the RFC. Sends the close message, as room permits in the socket buffer, and immediately closes the socket. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 65

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-12 Thread Brandon Carpenter
On Tue, Sep 12, 2017 at 2:01 AM, Daniel P. Berrange wrote: The problem is in the qio_channel_websock_read_wire method we refuse to read more than 4k into encinput. So if the ping payload is greater than 4k this will just loop forever. The RFC limits the payload length of

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread Greg Kurz
On Tue, 12 Sep 2017 16:51:46 +0200 Thomas Huth wrote: > On 12.09.2017 16:46, Greg Kurz wrote: > > On Tue, 12 Sep 2017 16:01:46 +0200 > > Laurent Vivier wrote: > > > >> Fix aarch64 and ppc when dump-guest-memory is > >> used with none machine type and no

Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault

2017-09-12 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 12.09.2017 16:46, Greg Kurz wrote: > > On Tue, 12 Sep 2017 16:01:46 +0200 > > Laurent Vivier wrote: > > > >> Fix aarch64 and ppc when dump-guest-memory is > >> used with none machine type and no CPU. > >> > >> The other machine

Re: [Qemu-devel] [PATCH] i386: Use designated initializers on feat_names arrays

2017-09-12 Thread Igor Mammedov
On Mon, 4 Sep 2017 15:56:22 -0300 Eduardo Habkost wrote: > Using designated initializers for feat_names allows us to omit > NULL entries, and makes mistakes easier to spot (especially when > cherry-picking or merging commits). > > Arrays that have very few entries were

Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG

2017-09-12 Thread David Hildenbrand
On 12.09.2017 14:43, Igor Mammedov wrote: > On Mon, 11 Sep 2017 17:21:40 +0200 > David Hildenbrand wrote: > >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x

Re: [Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 12:46, Daniel P. Berrange wrote: > Currently before submitting a series, devs should run checkpatch.pl > across each patch to be submitted. This can be automated using a > command such as: > > git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' > > This is rather long

Re: [Qemu-devel] [PATCH 4/4] s390x/css: fix incorrect length indication

2017-09-12 Thread Cornelia Huck
On Tue, 12 Sep 2017 17:43:03 +0200 Halil Pasic wrote: > On 09/12/2017 04:37 PM, Cornelia Huck wrote: > > On Mon, 11 Sep 2017 13:36:29 +0200 > > Halil Pasic wrote: > > > >> On 09/11/2017 12:07 PM, Cornelia Huck wrote: > >>> On Fri, 8 Sep

[Qemu-devel] [PATCH v2 01/16] tcg: Add expanders for out-of-line vector helpers

2017-09-12 Thread Richard Henderson
This is a minimum extraction from a full generic vector patchset in order to support simultaneous development in target/arm. Signed-off-by: Richard Henderson --- Makefile.target | 5 +-- tcg/tcg-gvec-desc.h | 49 tcg/tcg-op-gvec.h

[Qemu-devel] [PATCH v2 13/16] tcg: Remove tcg_regset_{or, and, andnot, not}

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 4 tcg/tcg.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index e168bd2c44..8b4208ea03 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -214,10 +214,6 @@ typedef enum

[Qemu-devel] [PATCH v2 07/16] target/arm: Align vector registers

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 98b9b26fd3..419f008277 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -486,7 +486,7 @@

[Qemu-devel] [PATCH v3 2/7] io: Small updates in preparation for websocket changes

2017-09-12 Thread Brandon Carpenter
Gets rid of unnecessary bit shifting and performs proper EOF checking to avoid a large number of repeated calls to recvmsg() when a client abruptly terminates a connection (bug fix). Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 62

[Qemu-devel] [PATCH v3 6/7] io: Reply to ping frames

2017-09-12 Thread Brandon Carpenter
Add an immediate ping reply (pong) to the outgoing stream when a ping is received. Unsolicited pongs are ignored. Signed-off-by: Brandon Carpenter --- include/io/channel-websock.h | 1 + io/channel-websock.c | 64

[Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC

2017-09-12 Thread Brandon Carpenter
We've been experiencing issues where the qemu websocket server closes connections from noVNC clients for no apparent reason. Debugging shows that certain web browsers are injecting ping and pong frames when the connection becomes idle. Some browsers send those frames without a payload, which also

[Qemu-devel] [PATCH v3 4/7] io: Allow empty websocket payload

2017-09-12 Thread Brandon Carpenter
Some browsers send pings/pongs with no payload, so allow empty payloads instead of closing the connection. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 62 +--- 1 file changed, 30 insertions(+), 32

Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-12 Thread Cornelia Huck
On Fri, 8 Sep 2017 17:55:29 +0200 Thomas Huth wrote: > On 08.09.2017 13:54, Kevin Wolf wrote: > > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: > >> On Fri, 8 Sep 2017 13:04:25 +0200 > >> Kevin Wolf wrote: > >> > >>> Am 05.09.2017 um 17:16 hat

Re: [Qemu-devel] [PULL 28/32] target/arm: [tcg] Port to generic translation framework

2017-09-12 Thread Laurent Desnogues
Hello, On Wed, Sep 6, 2017 at 6:06 PM, Richard Henderson wrote: > From: Lluís Vilanova > > Tested-by: Emilio G. Cota > Reviewed-by: Emilio G. Cota > Signed-off-by: Lluís Vilanova >

Re: [Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 18:12, Daniel P. Berrange wrote: > On Tue, Sep 12, 2017 at 05:52:18PM +0200, Paolo Bonzini wrote: >> On 12/09/2017 12:46, Daniel P. Berrange wrote: >>> Currently before submitting a series, devs should run checkpatch.pl >>> across each patch to be submitted. This can be automated

Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 18:05 hat Cornelia Huck geschrieben: > On Fri, 8 Sep 2017 17:55:29 +0200 > Thomas Huth wrote: > > > On 08.09.2017 13:54, Kevin Wolf wrote: > > > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: > > >> On Fri, 8 Sep 2017 13:04:25 +0200 > > >> Kevin Wolf

Re: [Qemu-devel] [PATCH] mps2-an511: Fix wiring of UART overflow interrupt lines

2017-09-12 Thread Philippe Mathieu-Daudé
(CC'ed qemu-arm) Hi Peter, On 09/12/2017 01:13 PM, Peter Maydell wrote: Fix an error that meant we were wiring every UART's overflow interrupts into the same inputs 0 and 1 of the OR gate, rather than giving each its own input. oops tricky to catch Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH v2 00/16] TCG vectorization and example conversion

2017-09-12 Thread Richard Henderson
I haven't gotten so far as the complex vector op issue that came up in conversation with Alex this week. But this is what I was targeting as v2: * Add documentation. Enough, or is it still lacking? * Fixed the bug in tcg/i386 that affected BIC. * Fill in the host vector ops for aarch64.

Re: [Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 18:22, Daniel P. Berrange wrote: > On Tue, Sep 12, 2017 at 06:14:57PM +0200, Paolo Bonzini wrote: >> On 12/09/2017 18:12, Daniel P. Berrange wrote: >>> On Tue, Sep 12, 2017 at 05:52:18PM +0200, Paolo Bonzini wrote: On 12/09/2017 12:46, Daniel P. Berrange wrote: > Currently

[Qemu-devel] [PATCH v2 06/16] tcg: Add vector infrastructure and ops for add/sub/logic

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- Makefile.target| 2 +- tcg/tcg-op-gvec.h | 61 ++ tcg/tcg-runtime.h | 16 ++ tcg/tcg.h | 2 + tcg/tcg-op-gvec.c | 489 +

[Qemu-devel] [PATCH v2 10/16] tcg/aarch64: Fully convert tcg_target_op_def

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 282 +++ 1 file changed, 151 insertions(+), 131 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index

[Qemu-devel] [PATCH v2 09/16] tcg/i386: Add vector operations

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 46 - tcg/i386/tcg-target.inc.c | 438 +- 2 files changed, 438 insertions(+), 46 deletions(-) diff --git a/tcg/i386/tcg-target.h

[Qemu-devel] [PATCH v2 08/16] target/arm: Use vector infrastructure for aa64 add/sub/logic

2017-09-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 137 - 1 file changed, 87 insertions(+), 50 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9017e30510..d01a180fba

Re: [Qemu-devel] [PATCH v2] scripts: let checkpatch.pl process an entire GIT branch

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 18:51, Daniel P. Berrange wrote: > Currently before submitting a series, devs should run checkpatch.pl > across each patch to be submitted. This can be automated using a > command such as: > > git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' > > This is rather long

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-09-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Aug 24, 2017 at 08:27:14PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > We need a better way, but at the moment we need the address of the > > mappings sent back to qemu so it can

Re: [Qemu-devel] [PATCH 4/4] s390x/css: fix incorrect length indication

2017-09-12 Thread Halil Pasic
On 09/12/2017 05:59 PM, Cornelia Huck wrote: > On Tue, 12 Sep 2017 17:43:03 +0200 > Halil Pasic wrote: > >> On 09/12/2017 04:37 PM, Cornelia Huck wrote: >>> On Mon, 11 Sep 2017 13:36:29 +0200 >>> Halil Pasic wrote: >>> On 09/11/2017

Re: [Qemu-devel] [PULL 02/40] hw/ppc: clear pending_events on machine reset

2017-09-12 Thread Peter Maydell
On 8 September 2017 at 11:35, David Gibson wrote: > From: Daniel Henrique Barboza > > The sPAPR machine isn't clearing up the pending events QTAILQ on > machine reboot. This allows for unprocessed hotplug/epow events > to persist in the

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-12 Thread Eduardo Habkost
On Mon, Sep 11, 2017 at 08:13:21AM +0200, Thomas Huth wrote: > On 09.09.2017 22:41, Eduardo Habkost wrote: > > On Wed, Sep 06, 2017 at 08:59:32AM +0200, Markus Armbruster wrote: > >> Thomas Huth writes: > >> > >>> On 05.09.2017 18:48, Dr. David Alan Gilbert wrote: > *

Re: [Qemu-devel] [PULL for-2.10 05/15] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()

2017-09-12 Thread Peter Maydell
On 31 August 2017 at 09:22, Stefan Hajnoczi wrote: > From: Alberto Garcia > > The throttling code can change internally the value of bkt->max if it > hasn't been set by the user. The problem with this is that if we want > to retrieve the original value we

Re: [Qemu-devel] [PATCH v3 49/50] qapi: make query-cpu-model-expansion depend on s390 or x86

2017-09-12 Thread Eduardo Habkost
On Mon, Sep 11, 2017 at 01:06:22PM +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost -- Eduardo

<    1   2   3   4