Re: [Qemu-devel] [PATCH 1/1] target/ppc: correct htab shift for hash on radix

2017-11-12 Thread David Gibson
On Mon, Nov 06, 2017 at 02:14:35PM +1100, Sam Bobroff wrote: > KVM HV will soon support running a guest in hash mode on a POWER9 host > running in radix mode (see [1]), however the guest currently fails to > boot. > > This is because the "htab_shift" value (the size of the MMU's hash > table) is

[Qemu-devel] [PATCH v2] highbank: validate register offset before access

2017-11-12 Thread P J P
From: Prasad J Pandit An 'offset' parameter sent to highbank register r/w functions could be greater than number(NUM_REGS=0x200) of hb registers, leading to an OOB access issue. Add check to avoid it. Reported-by: Moguofang (Dennis mo)

[Qemu-devel] [PATCH for 2.12] target/i386: Fix compiler warnings

2017-11-12 Thread Stefan Weil
These gcc warnings are fixed: target/i386/translate.c:4461:12: warning: variable ‘prefixes’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered] target/i386/translate.c:4466:9: warning: variable ‘rex_w’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered]

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-12 Thread Jason Wang
On 2017年11月06日 21:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-12 Thread gengdongjiu
On 2017/11/10 19:32, Paolo Bonzini wrote: > On 10/11/2017 20:19, Dongjiu Geng wrote: >> +typedef struct HWPoisonPage { >> +ram_addr_t ram_addr; >> +QLIST_ENTRY(HWPoisonPage) list; >> +} HWPoisonPage; >> + > > Is this actually needed outside accel/kvm/kvm-all.c? Paolo, Thanks for the

Re: [Qemu-devel] [PATCH for-2.12 v3 02/11] ppc/xics: remove useless if condition

2017-11-12 Thread David Gibson
On Fri, Nov 10, 2017 at 03:20:08PM +, Cédric Le Goater wrote: > The previous code section uses a 'first < 0' test and returns. Therefore, > there is no need to test the 'first' variable against '>= 0' afterwards. > > Signed-off-by: Cédric Le Goater > --- >

Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-12 Thread Gonglei (Arei)
Hi, > > > +The controlq request is composed of two parts: > > +\begin{lstlisting} > > +struct virtio_crypto_op_ctrl_req { > > +struct virtio_crypto_ctrl_header header; > > + > > +/* additional paramenter */ > > +u8 additional_para[addl_para_len]; > > What does additional paramenter

[Qemu-devel] [Bug 888016] Re: RHEL 6.1 guest fails to boot with vhost

2017-11-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/888016 Title: RHEL 6.1

[Qemu-devel] [Bug 1254940] Re: qemu-KVM guest OS occurs many ext3-fs errors after multiple forced shutdown

2017-11-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254940 Title: qemu-KVM

[Qemu-devel] [Bug 996798] Re: Incorrect order of task switching

2017-11-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/996798 Title: Incorrect

[Qemu-devel] QEMU 3.0 ? (was: [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type)

2017-11-12 Thread Thomas Huth
On 10.11.2017 16:20, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index d682f013d422..a2dcbee07214 100644 > ---

[Qemu-devel] [PATCH for 2.12] disas/hppa: Fix compiler errors

2017-11-12 Thread Stefan Weil
gcc (Debian 6.3.0-18) 6.3.0 20170516 reports these errors: disas/hppa.c:2702:20: error: left shift of negative value [-Werror=shift-negative-value] disas/hppa.c:2718:20: error: left shift of negative value [-Werror=shift-negative-value] Signed-off-by: Stefan Weil --- This

Re: [Qemu-devel] [v21 RESEND 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-12 Thread Longpeng (Mike)
Hi Stefan, On 2017/11/11 1:02, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 02:58:47PM +0800, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto

[Qemu-devel] [Qemu devel PATCH v2] MAINTAINERS: Add entries for Smartfusion2

2017-11-12 Thread Subbaraya Sundeep
Voluntarily add myself as maintainer for Smartfusion2 Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- v2: reframed commit message as per Alistair's comment.

Re: [Qemu-devel] [PATCH v5 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support

2017-11-12 Thread Hatayama, Daisuke
Marc-Andre, It looks to me that the 4th and 5th patches somehow has not been sent. Could you send them, too? I'd like them to actually build and run the kernel for testing. > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On

Re: [Qemu-devel] [PATCH v1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-12 Thread Peter Xu
On Fri, Nov 10, 2017 at 06:35:16PM -0200, Daniel Henrique Barboza wrote: > When migrating a VM with 'migrate_set_capability postcopy-ram on' > a postcopy_state is set during the process, ending up with the > state POSTCOPY_INCOMING_END when the migration is over. This > postcopy_state is taken

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-12 Thread David Gibson
On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > From: Peter Xu > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > spaces to store arch-specific hooks. > > The first hook I would like to introduce is iommu_get(). Return an > IOMMUObject

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2

2017-11-12 Thread sundeep subbaraya
Hi, On Fri, Nov 10, 2017 at 7:10 PM, Philippe Mathieu-Daudé wrote: > On 11/10/2017 09:56 AM, Peter Maydell wrote: > > On 10 November 2017 at 00:22, Philippe Mathieu-Daudé > wrote: > >> On 11/09/2017 08:55 PM, Peter Maydell wrote: > >>> I don't in general

Re: [Qemu-devel] [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type

2017-11-12 Thread David Gibson
On Fri, Nov 10, 2017 at 03:20:07PM +, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index d682f013d422..a2dcbee07214

Re: [Qemu-devel] [PATCH] hw/vfio: improve error message when cannot init vfio event notifiers

2017-11-12 Thread Markus Armbruster
Jim Quigley writes: > On 16/10/2017 19:07, Michael Tokarev wrote: >> 10.10.2017 13:22, Jim Quigley wrote: >>> More information is required to assist trouble-shooting when >>> QEMU fails to initialise the event notifications for devices >>> assigned with VFIO-PCI. Instead

Re: [Qemu-devel] [U-Boot] Support of latest qemux86-64

2017-11-12 Thread Bin Meng
Hi Anton, On Sat, Nov 11, 2017 at 1:34 AM, Anton Gerasimov wrote: > Hooray, changing SYS_CAR_ADDR to 0x1 in arch/x86/cpu/qemu/Kconfig > does the trick. Bin, what do you think about it? > Great! Would you please create a patch against U-Boot QEMU? > Best

Re: [Qemu-devel] [PATCH for 2.12] disas/hppa: Fix compiler errors

2017-11-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH for 2.12] disas/hppa: Fix compiler errors Type: series Message-id: 20171113072715.3443-1...@weilnetz.de === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH] SDL2 various fixes

2017-11-12 Thread Philippe Mathieu-Daudé
Hi Jindrich, On 11/12/2017 07:42 AM, Jindrich Makovicka wrote: > Hi, > > here is a revised patchset: Please increment the patchset version when you respin (this is v2). > > - sdl2: Do not hide the cursor on auxilliary windows > split into two > > - sdl2: Only accept the hotkeys on the

Re: [Qemu-devel] [PATCH v4 3/5] fw_cfg: do DMA read operation

2017-11-12 Thread Marc-André Lureau
- Original Message - > On Tue, Oct 31, 2017 at 04:19:36PM +0100, Marc-André Lureau wrote: > > Modify fw_cfg_read_blob() to use DMA if the device supports it. > > Return errors, because the operation may fail. > > > > To avoid polling with unbound amount of time, the DMA operation is > >

Re: [Qemu-devel] [PATCH] linux-user, s390x: ignore OS ABI value in ELF header

2017-11-12 Thread Philippe Mathieu-Daudé
On 11/12/2017 06:23 AM, Laurent Vivier wrote: > Le 12/11/2017 à 07:56, Thomas Huth a écrit : >> Am Fri, 10 Nov 2017 20:49:35 +0100 >> schrieb Laurent Vivier : >> >>> I have this error: >>> bash: /sbin/ldconfig: cannot execute binary file: Exec format error >>> >>> because

[Qemu-devel] [Bug 1086782] Re: HPET time drift windows 7 64bits guest

2017-11-12 Thread Carlos-velasco
Running from 6 days, here are my results. There is still some time drift but not critical. Windows 7 guest is behind around 30 seconds in 6 days. This can be corrected by using NTP. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] linux-user, s390x: ignore OS ABI value in ELF header

2017-11-12 Thread Laurent Vivier
Le 12/11/2017 à 07:56, Thomas Huth a écrit : > Am Fri, 10 Nov 2017 20:49:35 +0100 > schrieb Laurent Vivier : > >> I have this error: >> bash: /sbin/ldconfig: cannot execute binary file: Exec format error >> >> because /sbin/ldconfig is: >> ELF 64-bit MSB executable, IBM S/390,

[Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates

2017-11-12 Thread Jindrich Makovicka
This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. --- ui/sdl2.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 677c22282d..51721d764e 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@

[Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode

2017-11-12 Thread Jindrich Makovicka
Also use a proper enum parameter for SDL_ShowCursor --- ui/sdl2.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index dfbd0de791..9cf4b1772b 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -169,10 +169,10 @@ static void

[Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows

2017-11-12 Thread Jindrich Makovicka
--- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9cf4b1772b..677c22282d 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -465,6 +465,10 @@ static void handle_mousemotion(SDL_Event *ev) int max_x, max_y; struct sdl2_console *scon =

[Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-12 Thread Jindrich Makovicka
With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. Instead of trying to override the change, just update the scon->hidden flag. --- ui/sdl2.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c

[Qemu-devel] [PATCH] SDL2 various fixes

2017-11-12 Thread Jindrich Makovicka
Hi, here is a revised patchset: - sdl2: Do not hide the cursor on auxilliary windows split into two - sdl2: Only accept the hotkeys on the main window reworked, also with a more descriptive commit message - sdl2: Do not quit the emulator when an auxilliary window is closed added

[Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

2017-11-12 Thread Jindrich Makovicka
When SDL2 windows change focus while a key is held, the window that receives the focus also receives a new KeyDown event, without an autorepeat flag. This means that if a WM places the qemu console over the main window after Ctrl-Alt-2, the console closes immediately after opening. Then, the main

[Qemu-devel] [PATCH v3] virtio_balloon: include disk/file caches memory statistics

2017-11-12 Thread Tomáš Golembiovský
Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory statistics protocol. The value represents all disk/file caches. In this case it corresponds to the sum of values Buffers+Cached+SwapCached from /proc/meminfo. Signed-off-by: Tomáš Golembiovský ---

[Qemu-devel] Abnormal observation during migration: too many "write-not-dirty" pages

2017-11-12 Thread Chunguang Li
Hi all! I got a very abnormal observation for the VM migration. I found that many pages marked as dirty during migration are "not really dirty", which is, their content are the same as the old version. I did the migration experiment like this: During the setup phase of migration, first I

[Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen

2017-11-12 Thread Jindrich Makovicka
--- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 51721d764e..cdc599be48 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -418,6 +418,7 @@ static void handle_keyup(SDL_Event *ev) sdl2_reset_keys(scon); return; } +

[Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed

2017-11-12 Thread Jindrich Makovicka
--- ui/sdl2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 774904cbf2..dfbd0de791 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -566,9 +566,14 @@ static void handle_windowevent(SDL_Event *ev) update_displaychangelistener(>dcl,

Re: [Qemu-devel] [PATCH v4 5/5] fw_cfg: write vmcoreinfo details

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:38PM +0100, Marc-André Lureau wrote: > If the "etc/vmcoreinfo" fw_cfg file is present and we are not running > the kdump kernel, write the addr/size of the vmcoreinfo ELF note. > > Signed-off-by: Marc-André Lureau Same two questions as

Re: [Qemu-devel] [PATCH v4 1/5] fw_cfg: fix the command line module name

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:34PM +0100, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Acked-by: Gabriel Somlo > --- > drivers/firmware/qemu_fw_cfg.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v4 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:33PM +0100, Marc-André Lureau wrote: > Hi, > > This series adds DMA operations support to the qemu fw_cfg kernel > module and populates "etc/vmcoreinfo" with vmcoreinfo location > details. > > Note: the support for this entry handling has been merged for next > qemu

Re: [Qemu-devel] [PATCH v4 2/5] fw_cfg: add DMA register

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:35PM +0100, Marc-André Lureau wrote: > Add an optional kernel module (or command line) parameter > using the following syntax: > > [qemu_fw_cfg.]ioport=@[::[:]] > or > [qemu_fw_cfg.]mmio=@[::[:]] > > and initializes the register address using given or

[Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen

2017-11-12 Thread Jindrich Makovicka
Prevents displaying of a doubled mouse pointer when moving the pointer to the screen edges when fullscreen. --- ui/sdl2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index cdc599be48..6feb637739 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -451,8

Re: [Qemu-devel] [PATCH v4 4/5] crash: export paddr_vmcoreinfo_note()

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:37PM +0100, Marc-André Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module. > > Signed-off-by: Marc-André Lureau Acked-by: Gabriel Somlo > --- > kernel/crash_core.c | 1 + > 1 file

Re: [Qemu-devel] [PATCH v4 3/5] fw_cfg: do DMA read operation

2017-11-12 Thread Gabriel L. Somlo
On Tue, Oct 31, 2017 at 04:19:36PM +0100, Marc-André Lureau wrote: > Modify fw_cfg_read_blob() to use DMA if the device supports it. > Return errors, because the operation may fail. > > To avoid polling with unbound amount of time, the DMA operation is > expected to complete within 200ms, or will

Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-12 Thread Philippe Mathieu-Daudé
Hi Prasad, Thanks for updating this patch so quickly :) On 11/11/2017 05:11 AM, P J P wrote: > From: Prasad J Pandit > > An 'offset' parameter sent to highbank register r/w functions > could be greater than number(NUM_REGS=0x200) of hb registers, > leading to an OOB

Re: [Qemu-devel] [PATCH v4 3/5] fw_cfg: do DMA read operation

2017-11-12 Thread Gabriel L. Somlo
On Sun, Nov 12, 2017 at 09:36:33AM -0500, Marc-André Lureau wrote: > > > - Original Message - > > On Tue, Oct 31, 2017 at 04:19:36PM +0100, Marc-André Lureau wrote: > > > Modify fw_cfg_read_blob() to use DMA if the device supports it. > > > Return errors, because the operation may fail.

[Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen

2017-11-12 Thread Jindrich Makovicka
Prevents displaying of a doubled mouse pointer when moving the pointer to the screen edges when fullscreen. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index

[Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen

2017-11-12 Thread Jindrich Makovicka
Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 51721d764e..cdc599be48 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -418,6 +418,7 @@ static void handle_keyup(SDL_Event *ev)

[Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows

2017-11-12 Thread Jindrich Makovicka
Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9cf4b1772b..677c22282d 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -465,6 +465,10 @@ static void handle_mousemotion(SDL_Event *ev)

[Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode

2017-11-12 Thread Jindrich Makovicka
Also use a proper enum parameter for SDL_ShowCursor Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index dfbd0de791..9cf4b1772b 100644 --- a/ui/sdl2.c +++

[Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-12 Thread Jindrich Makovicka
With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. Instead of trying to override the change, just update the scon->hidden flag. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 8 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v3] SDL2 various fixes

2017-11-12 Thread Jindrich Makovicka
Hi, here is an identical patchset with Signed-off-by. Regards, Jindrich

[Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed

2017-11-12 Thread Jindrich Makovicka
Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 774904cbf2..dfbd0de791 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -566,9 +566,14 @@ static void

[Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates

2017-11-12 Thread Jindrich Makovicka
This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index

[Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

2017-11-12 Thread Jindrich Makovicka
When SDL2 windows change focus while a key is held, the window that receives the focus also receives a new KeyDown event, without an autorepeat flag. This means that if a WM places the qemu console over the main window after Ctrl-Alt-2, the console closes immediately after opening. Then, the main