[Qemu-devel] [Bug 1672383] Re: Slow Windows XP load after commit a9353fe897ca2687e5b3385ed39e3db3927a90e0

2017-11-28 Thread Maskim Bakulin
Supposedly fixed by commit 406bc339b0505fcfc2ffcbca1f05a3756e338a65 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1672383 Title: Slow

Re: [Qemu-devel] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:31 -0500 "Collin L. Walling" wrote: > These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. > The menu will only appear if the disk has been configured for IPL with the > zIPL tool and with the following QEMU command

Re: [Qemu-devel] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:32 -0500 "Collin L. Walling" wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > atoi > > Added non-C standard

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/25] spapr: move the IRQ allocation routines under the machine

2017-11-28 Thread Greg Kurz
On Thu, 23 Nov 2017 14:29:34 +0100 Cédric Le Goater wrote: > Also change the prototype to use a sPAPRMachineState and prefix them > with spapr_irq_. It will let us synchronise the IRQ allocation with > the XIVE interrupt mode when available. > > Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/25] spapr: introduce a spapr_icp_create() helper

2017-11-28 Thread Greg Kurz
On Fri, 24 Nov 2017 12:26:21 + Cédric Le Goater wrote: > On 11/24/2017 10:09 AM, Greg Kurz wrote: > > On Thu, 23 Nov 2017 14:29:33 +0100 > > Cédric Le Goater wrote: > > > >> On sPAPR, the creation of the interrupt presenter depends on some of > >> the

Re: [Qemu-devel] [PATCH 09/25] spapr: introduce handlers for XIVE interrupt sources

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:39PM +0100, Cédric Le Goater wrote: > These are very similar to the XICS handlers in a simpler form. They make > use of a status array for the LSI interrupts. The spapr_xive_irq() routine > in charge of triggering the CPU interrupt line will be filled later on. > >

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-11-28 Thread bzt bzt
Hi Andrew! [...] > > In that case, IIRC my high-level suggestion was to either parameterise > bcm2836 to take a CPU model string, or else move the CPU creation out of > bcm2836.c into the board file. From what I've understood thus far about > pi3, it does not seem necessary to have a separate

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2017-11-28 Thread Jeb E.
** Also affects: gnome-boxes Importance: Undecided Status: New ** Also affects: qemu Importance: Undecided Status: New ** Also affects: spice-packages Importance: Undecided Status: New ** Also affects: kvm Importance: Undecided Status: New ** Changed in:

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 12:49:04 +0100 Boris Fiuczynski wrote: > On 11/28/2017 11:22 AM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 09:53:15 +0100 > > Boris Fiuczynski wrote: > > > >> On 11/27/2017 05:56 PM, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 12:42 hat Kevin Wolf geschrieben: > Am 28.11.2017 um 06:43 hat Jeff Cody geschrieben: > > On Tue, Nov 28, 2017 at 12:29:09AM +0100, Kevin Wolf wrote: > > > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > > > > Jeff's block job patch made the latent drain bug visible, and I

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 13:36:38 +0100 Thomas Huth wrote: > On 27.11.2017 21:55, Collin L. Walling wrote: > > +static int zipl_boot_menu(block_number_t s1b_block_nr) > > +{ > > +void *stage2_data, *menu_offset; > > + > > +read_stage2(s1b_block_nr, _data); > > +

Re: [Qemu-devel] [PATCH v3 03/45] windbg: modified windbgkd.h

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added useful name arrays of some defines. Not used yet. Needs for the future. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: > On 11/27/2017 05:56 PM, Cornelia Huck wrote: > > Proposal 2: Export the default cssid as a machine property. If this > > property exists, it also implies that devices can be put into any css > > image

Re: [Qemu-devel] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

2017-11-28 Thread Cédric Le Goater
On 11/28/2017 05:40 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:38PM +0100, Cédric Le Goater wrote: >> The XIVE interrupt controller uses a set of tables to redirect exception >> from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) >> table, also known as Event

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:02 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng;

Re: [Qemu-devel] [PATCH for-2.11] pc: fix crash on attempted cpu unplug

2017-11-28 Thread Paolo Bonzini
On 20/11/2017 18:05, Eduardo Habkost wrote: > On Mon, Nov 20, 2017 at 03:59:51PM +0100, Igor Mammedov wrote: >> On Mon, 20 Nov 2017 12:44:54 -0200 >> Eduardo Habkost wrote: >> >>> On Mon, Nov 20, 2017 at 03:34:13PM +0100, Igor Mammedov wrote: when qemu is started with

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 16:57:34 +0530 (IST) P J P wrote: > +-- On Tue, 28 Nov 2017, Stefan Hajnoczi wrote --+ > | > This is conflating different things: > | > - vq does not exist (num == 0) > | > - vq is not setup by the guest (desc == 0) > | > - vq has no valid alignment (which

Re: [Qemu-devel] [PATCH 1/2] pci: removed the is_express field since a uniform interface was inserted

2017-11-28 Thread Yoni Bettan
On 11/28/2017 07:51 AM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Hi, please discard this series, i will

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Halil Pasic
On 11/28/2017 01:24 PM, Christian Borntraeger wrote: > > > On 11/28/2017 01:14 PM, Cornelia Huck wrote: >> On Tue, 28 Nov 2017 12:49:04 +0100 >> Boris Fiuczynski wrote: >> >>> On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 10:03, Gonglei wrote: > Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION > and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side > support crypto operation in cryptodev host-user backend. > > Signed-off-by: Gonglei >

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread P J P
+-- On Tue, 28 Nov 2017, Stefan Hajnoczi wrote --+ | > This is conflating different things: | > - vq does not exist (num == 0) | > - vq is not setup by the guest (desc == 0) | > - vq has no valid alignment (which is only relevant for legacy) | | I agree. Either case, vq would be unfit for use,

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 01:14 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 12:49:04 +0100 > Boris Fiuczynski wrote: > >> On 11/28/2017 11:22 AM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 09:53:15 +0100 >>> Boris Fiuczynski wrote: >>> On

Re: [Qemu-devel] [PATCH v3 45/45] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: [...] > diff --git a/windbgstub.c b/windbgstub.c > index 36372c0ea5..3bcf6a8cbb 100755 > --- a/windbgstub.c > +++ b/windbgstub.c > @@ -224,6 +224,14 @@ static void >

[Qemu-devel] [PULL 1/2] nbd/server: CVE-2017-15119 Reject options larger than 32M

2017-11-28 Thread Eric Blake
The NBD spec gives us permission to abruptly disconnect on clients that send outrageously large option requests, rather than having to spend the time reading to the end of the option. No real option request requires that much data anyways; and meanwhile, we already have the practice of abruptly

[Qemu-devel] [PULL 0/2] nbd patches for -rc3

2017-11-28 Thread Eric Blake
The following changes since commit c7e1f823aed63f49e559e7463da76d5b320be35b: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2017-11-28 10:03:26 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-11-28 for

[Qemu-devel] [PATCH 1/4] cryptodev: add vhost-user as a new cryptodev backend

2017-11-28 Thread Gonglei
Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike)

[Qemu-devel] [PATCH 2/4] cryptodev: add vhost support

2017-11-28 Thread Gonglei
Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the cryptdoev-vhost-user works. Signed-off-by:

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-28 Thread Stefan Hajnoczi
On Mon, Nov 27, 2017 at 12:58:32PM +0100, Kevin Wolf wrote: > Am 25.11.2017 um 08:08 hat Doug Gale geschrieben: > > Ping > > Stefan, do you expect this to go through a different tree than the > tracing one? Yes, patches that just add/remove/modify trace events go through the affected component's

Re: [Qemu-devel] [PULL] Net patches

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 04:01, Jason Wang wrote: > The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' > into staging (2017-11-27 11:16:20 +) > > are available in the

[Qemu-devel] [PULL (for 2.11) v1 1/1] sockets: avoid crash when cleaning up sockets for an invalid FD

2017-11-28 Thread Daniel P. Berrange
If socket_listen_cleanup is passed an invalid FD, then querying the socket local address will fail. We must thus be prepared for the returned addr to be NULL Reported-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel

[Qemu-devel] [PULL (for 2.11) v1 0/1] Merge io 2017/11/28

2017-11-28 Thread Daniel P. Berrange
The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' into staging (2017-11-27 11:16:20 +) are available in the Git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-11-28-1

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > atoi > > Added non-C standard function: > itostr > > Signed-off-by: Collin

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Boris Fiuczynski
On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: On 11/27/2017 05:56 PM, Cornelia Huck wrote: Proposal 2: Export the default cssid as a machine property. If this property exists, it also implies that devices

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 12:42, Marc-André Lureau wrote: > Hi > > On Tue, Nov 28, 2017 at 12:32 PM, Paolo Bonzini wrote: >> Recent glibc added memfd_create in sys/mman.h. This conflicts with >> the definition in util/memfd.c: >> >>

Re: [Qemu-devel] QEMU Summit 2017: minutes

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 09:33:52 +0100 Thomas Huth wrote: > On 27.11.2017 23:03, John Snow wrote: > > > > On 11/23/2017 11:31 AM, Peter Maydell wrote: > [...] > >> Continuous Integration: > >> * Christian Borntraeger: qemu-iotests have broken a lot, they should be > >>run

Re: [Qemu-devel] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:33 -0500 "Collin L. Walling" wrote: > ECKD DASDs have different IPL structures for CDL and LDL > formats. The current Ipl1 and Ipl2 structs follow the CDL > format, so we prepend "EckdCdl" to them. A new struct, > EckdLdlIpl1 is introduced

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:46 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng;

Re: [Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > Makefile.target |

[Qemu-devel] [PATCH 0/2] Rewrite TCP packet comparison in colo

2017-11-28 Thread Mao Zhongyi
In this series, rewrite the tcp packet comparison based on the tcp sequence number instead of original method that compare the packet based on the payload size. Mao Zhongyi (2): colo: compare the packet based on the tcp sequence number colo: add trace for the tcp packet comparison

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-28 Thread Dr. David Alan Gilbert
* fangying (fangyi...@huawei.com) wrote: > QEMU will abort when vhost-user process is restarted during migration > and vhost_log_global_start/stop is called. The reason is clear that > vhost_dev_set_log returns -1 because network connection is temporarily > lost. To handle this situation, let's

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 10:11:54AM +0100, Cornelia Huck wrote: > On Mon, 27 Nov 2017 23:25:28 +0530 (IST) > P J P wrote: > > +-- On Mon, 27 Nov 2017, Stefan Hajnoczi wrote --+ > > | > +if (!vdev->vq[n].vring.num || !desc || !vdev->vq[n].vring.align) { > > | ... > > |

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 11:43, Gonglei (Arei) wrote: >> As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as >> a result of sending a message on the control virtqueue. > > VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is a message type of control queue, > Means creating a session for next crypto

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:26, bzt bzt wrote: > (Although I have a question. I'm not sure what's the preferred > way to get MachineClass* object in bcm2836. Use a MachineState* cast on it's > Object* argument with MACHINE_GET_CLASS() or should I use the parameterless >

[Qemu-devel] [PATCH 2/2] colo: add trace for the tcp packet comparison

2017-11-28 Thread Mao Zhongyi
Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi --- net/colo-compare.c | 16 net/colo.c | 1 + net/colo.h | 1 + net/trace-events | 2

[Qemu-devel] [PATCH 1/2] colo: compare the packet based on the tcp sequence number

2017-11-28 Thread Mao Zhongyi
The primary and secondary guest has the same TCP stream, but the the packet sizes are different due to the different fragmentation. In the current impletation, compare the packet with the size of payload, but packets of the same size and payload are very few, so it triggers

[Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-11-28 Thread Denis V. Lunev
There are 2 cases I have spotted so far: 1) IDE ATAPI read processing. Actually this was reported from field 2) QEMU IO hmp command (found during evaluation of (1)) SCSI code checks during access that blk_is_available(). These patches add same checks on different code paths. Pls decide whether

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > When the boot menu options are present and the guest's > disk has been configured by the zipl tool, then the user > will be presented with an interactive boot menu with > labeled entries. An example of what the menu might look > like: > > zIPL

Re: [Qemu-devel] [PATCH] linux-user: Use *at functions instead of caching interp_prefix contents

2017-11-28 Thread Peter Maydell
On 12 January 2017 at 04:05, Richard Henderson wrote: > If the interp_prefix is a complete chroot, it may have a *lot* of files. > Setting up the cache for this is quite expensive. Instead, use the *at > versions of various syscalls to attempt the operation in the prefix. > >

Re: [Qemu-devel] [PATCH 11/25] spapr: describe the XIVE interrupt source flags

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:41PM +0100, Cédric Le Goater wrote: > The XIVE interrupt sources can have different characteristics depending > on their nature and the HW level in use. The sPAPR specs provide a set of > flags to describe them : > > - XIVE_SRC_H_INT_ESB the Event State Buffers are

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:40PM +0100, Cédric Le Goater wrote: > Each interrupt source is associated with a two bit state machine > called an Event State Buffer (ESB). The bits are named "P" (pending) > and "Q" (queued) and can be controlled by MMIO. It is used to trigger > events. See code for

Re: [Qemu-devel] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:38PM +0100, Cédric Le Goater wrote: > The XIVE interrupt controller uses a set of tables to redirect exception > from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) > table, also known as Event Assignment Structure (EAS), is one them. > > The

Re: [Qemu-devel] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:34 -0500 "Collin L. Walling" wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain

[Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Paolo Bonzini
Recent glibc added memfd_create in sys/mman.h. This conflicts with the definition in util/memfd.c: /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: static declaration of memfd_create follows non-static declaration Fix the configure test, and remove the sys/memfd.h inclusion

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Marc-André Lureau
Hi On Tue, Nov 28, 2017 at 12:32 PM, Paolo Bonzini wrote: > Recent glibc added memfd_create in sys/mman.h. This conflicts with > the definition in util/memfd.c: > > /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: static > declaration of memfd_create

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 06:43 hat Jeff Cody geschrieben: > On Tue, Nov 28, 2017 at 12:29:09AM +0100, Kevin Wolf wrote: > > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > > > Jeff's block job patch made the latent drain bug visible, and I find this > > > patch, which by itself also makes some sense,

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:49, Paolo Bonzini wrote: > On 28/11/2017 12:42, Marc-André Lureau wrote: >> It is introduced by this commit, right? >> https://sourceware.org/git/?p=glibc.git;a=commit;h=59d2cbb1fe4b8601d5cbd359c3806973eab6c62d >> >> (I added Florian Weimer in cc) >>

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Florian Weimer
On 11/28/2017 12:42 PM, Marc-André Lureau wrote: Couldn't the declarations be put in sys/memfd.h like the man claimed it would be for > 1y? We discussed it. It was a typo in the manual page. There never was a header file: https://marc.info/?l=linux-man=150988359906012=2 The UAPI

[Qemu-devel] [PULL 2/2] nbd/server: CVE-2017-15118 Stack smash on large export name

2017-11-28 Thread Eric Blake
Introduced in commit f37708f6b8 (2.10). The NBD spec says a client can request export names up to 4096 bytes in length, even though they should not expect success on names longer than 256. However, qemu hard-codes the limit of 256, and fails to filter out a client that probes for a longer name;

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 12:06, Gonglei (Arei) wrote: >>> You mean we can share control virtqueue to DPDK as well? Like data queues? >> I don't know :) but why not? >> > Current there are two main reasons for this design: > > 1) we should use another cpu to polling the control virtqueue, which is >

[Qemu-devel] [PATCH 1/2] hmp: block qemu-io command for device without media

2017-11-28 Thread Denis V. Lunev
In this case blk->bs == NULL and the code will just crash. Emulate error on that path. Signed-off-by: Denis V. Lunev CC: "Dr. David Alan Gilbert" CC: Kevin Wolf CC: Stefan Hajnoczi --- hmp.c | 3 +++ 1 file changed,

[Qemu-devel] [PATCH 2/2] ide: fix crash in IDE cdrom read

2017-11-28 Thread Denis V. Lunev
There is the following crash reported from the field in QEMU 2.9: bdrv_inc_in_flight (bs=bs@entry=0x0) blk_aio_prwv blk_aio_preadv ide_buffered_readv cd_read_sector ide_data_readw portio_read memory_region_read_accessor access_with_adjusted_size

[Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-28 Thread Halil Pasic
The default css 0xfe is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally don't do, the pain of the partitioned (cssid)

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 17:28, Kevin Wolf wrote: > To be honest, I just wasn't sure what to do with this case anyway. It > means that the coroutine is already running when someone else schedules > it. We don't really know whether we have to enter it a second time or > not. > > So if it can indeed happen in

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 18:09, Jeff Cody wrote: >> Yes, terminating a scheduled coroutine is a bug; same for scheduling a >> terminated coroutine, both orders are wrong. However, "unscheduling" is >> not the solution; you would just be papering over the issue. > > Maybe we should at least add an abort on

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> From: "Michael S. Tsirkin" > To: "Victor Kaplansky" > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" > Sent: Tuesday, November 28, 2017 6:16:32 PM > Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_base > > On

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com wrote: > From: Prasad Singamsetty > > The current implementation of Intel IOMMU code only supports 39 bits > iova address width. This patch provides a new parameter (x-aw-bits) > for

[Qemu-devel] [PATCH] linux-user/arm/nwfpe: Check coprocessor number for FPA emulation

2017-11-28 Thread Peter Maydell
Our copy of the nwfpe code for emulating of the old FPA11 floating point unit doesn't check the coprocessor number in the instruction when it emulates it. This means that we might treat some instructions which should really UNDEF as being FPA11 instructions by accident. The kernel's copy of the

Re: [Qemu-devel] [PATCH 11/25] spapr: describe the XIVE interrupt source flags

2017-11-28 Thread Cédric Le Goater
On 11/28/2017 06:40 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:41PM +0100, Cédric Le Goater wrote: >> The XIVE interrupt sources can have different characteristics depending >> on their nature and the HW level in use. The sPAPR specs provide a set of >> flags to describe them : >> >>

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

2017-11-28 Thread Cédric Le Goater
On 11/28/2017 06:38 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:40PM +0100, Cédric Le Goater wrote: >> Each interrupt source is associated with a two bit state machine >> called an Event State Buffer (ESB). The bits are named "P" (pending) >> and "Q" (queued) and can be controlled by

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Jeff Cody
On Tue, Nov 28, 2017 at 05:28:50PM +0100, Kevin Wolf wrote: > Am 28.11.2017 um 17:14 hat Paolo Bonzini geschrieben: > > On 28/11/2017 16:43, Kevin Wolf wrote: > > > +/* Make sure that a coroutine that can alternatively reentered from > > > two > > > + * different sources isn't reentered

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 10:42:30 -0500 "Collin L. Walling" wrote: > On 11/28/2017 05:48 AM, Cornelia Huck wrote: > > On Mon, 27 Nov 2017 15:55:33 -0500 > > "Collin L. Walling" wrote: > > > >> ECKD DASDs have different IPL structures for CDL

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Eric Blake
On 11/28/2017 09:43 AM, Kevin Wolf wrote: If a coroutine can be reentered from multiple possible sources, we need to be careful in the case that two sources try to reenter it at the same time. For this case, we'll cancel any pending aio_co_schedule() when the coroutine is actually entered.

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-11-28 Thread John Snow
On 11/28/2017 11:29 AM, Denis V. Lunev wrote: > On 11/28/2017 07:08 PM, Kevin Wolf wrote: >> Am 28.11.2017 um 13:10 hat Denis V. Lunev geschrieben: >>> There are 2 cases I have spotted so far: >>> 1) IDE ATAPI read processing. Actually this was reported from field >>> 2) QEMU IO hmp command

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 17:42 hat Jeff Cody geschrieben: > On Tue, Nov 28, 2017 at 05:28:50PM +0100, Kevin Wolf wrote: > > Am 28.11.2017 um 17:14 hat Paolo Bonzini geschrieben: > > > On 28/11/2017 16:43, Kevin Wolf wrote: > > > > +/* Make sure that a coroutine that can alternatively reentered > > >

Re: [Qemu-devel] [PATCH for-2.11 1/4] Revert "coroutine: abort if we try to schedule or enter a pending coroutine"

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 18:19, Kevin Wolf wrote: > Am 28.11.2017 um 18:01 hat Paolo Bonzini geschrieben: >> Basically, once you do aio_co_schedule or aio_co_wake the coroutine is >> not any more yours. It's owned by the context that will run it and you >> should not do anything with it. > > Well, but that

Re: [Qemu-devel] [PATCH 09/25] spapr: introduce handlers for XIVE interrupt sources

2017-11-28 Thread Cédric Le Goater
On 11/28/2017 05:45 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:39PM +0100, Cédric Le Goater wrote: >> These are very similar to the XICS handlers in a simpler form. They make >> use of a status array for the LSI interrupts. The spapr_xive_irq() routine >> in charge of triggering the

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 17:42, Jeff Cody wrote: > On Tue, Nov 28, 2017 at 05:28:50PM +0100, Kevin Wolf wrote: >> Am 28.11.2017 um 17:14 hat Paolo Bonzini geschrieben: >>> On 28/11/2017 16:43, Kevin Wolf wrote: +/* Make sure that a coroutine that can alternatively reentered from two +

Re: [Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Jeff Cody
On Tue, Nov 28, 2017 at 05:51:21PM +0100, Paolo Bonzini wrote: > On 28/11/2017 17:42, Jeff Cody wrote: > > On Tue, Nov 28, 2017 at 05:28:50PM +0100, Kevin Wolf wrote: > >> Am 28.11.2017 um 17:14 hat Paolo Bonzini geschrieben: > >>> On 28/11/2017 16:43, Kevin Wolf wrote: > +/* Make sure

Re: [Qemu-devel] [PATCH for-2.11 1/4] Revert "coroutine: abort if we try to schedule or enter a pending coroutine"

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 18:01 hat Paolo Bonzini geschrieben: > On 28/11/2017 17:37, Kevin Wolf wrote: > >> > >> It can also conflict badly with another aio_co_schedule(). Your patch > >> here removes the assertion in this case, and patch 3 makes it easier to > >> get into the situation where two

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 17:01, John Snow wrote: > It's not your fault, it's mine for letting this go for a release. It's > just unfortunate timing. I'm looking at (at least) the IDE portion of > this and the underlying cause in block-backend today. If it's not a regression, and

Re: [Qemu-devel] [PATCH for-2.11 1/4] Revert "coroutine: abort if we try to schedule or enter a pending coroutine"

2017-11-28 Thread Jeff Cody
On Tue, Nov 28, 2017 at 06:19:31PM +0100, Kevin Wolf wrote: > Am 28.11.2017 um 18:01 hat Paolo Bonzini geschrieben: > > On 28/11/2017 17:37, Kevin Wolf wrote: > > >> > > >> It can also conflict badly with another aio_co_schedule(). Your patch > > >> here removes the assertion in this case, and

Re: [Qemu-devel] QEMU Summit 2017: minutes

2017-11-28 Thread John Snow
On 11/28/2017 04:36 AM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 09:33:52 +0100 > Thomas Huth wrote: > >> On 27.11.2017 23:03, John Snow wrote: >>> >>> On 11/23/2017 11:31 AM, Peter Maydell wrote: >> [...] Continuous Integration: * Christian Borntraeger:

Re: [Qemu-devel] [PATCH] numa: fix missing '-numa cpu' in '-help' output

2017-11-28 Thread Eduardo Habkost
On Tue, Nov 28, 2017 at 10:59:57AM -0600, Eric Blake wrote: > On 11/28/2017 08:53 AM, Igor Mammedov wrote: > > commit 419fcdec3c (numa: add '-numa cpu,...' option for property based node > > mapping) > > added '-numa cpu' option but forgot to update appropriate section for > > '--help'. > > Add

Re: [Qemu-devel] [PATCH v3 15/45] windbg: sized data buffer

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macros for init and free. > > Signed-off-by: Mihail Abakumov >

Re: [Qemu-devel] [PULL (for 2.11) v1 0/1] Merge io 2017/11/28

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:23, Daniel P. Berrange wrote: > The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' > into staging (2017-11-27 11:16:20 +) > > are available

Re: [Qemu-devel] [PULL 0/2] nbd patches for -rc3

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 13:02, Eric Blake wrote: > The following changes since commit c7e1f823aed63f49e559e7463da76d5b320be35b: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2017-11-28 10:03:26 +) > > are available in the Git

[Qemu-devel] [PATCH 0/2] linux-user: Fix race between threads in page_unprotect()

2017-11-28 Thread Peter Maydell
If multiple guest threads in user-mode emulation write to a page which QEMU has marked read-only because of cached TCG translations, the threads can race in page_unprotect: * threads A & B both try to do a write to a page with code in it at the same time (ie which we've made non-writeable, so

[Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref()

2017-11-28 Thread Alberto Garcia
When destroying a block job in block_job_unref() we should remove it from the job list before calling block_job_remove_all_bdrv(). This is because removing the BDSs can trigger an aio_poll() and wake up other jobs that might attempt to use the block job list. If that happens the job we're

Re: [Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read

2017-11-28 Thread Igor Mammedov
On Thu, 5 Oct 2017 17:36:30 -0300 Eduardo Habkost wrote: > From: Dou Liyang > > It may be hard to read the assignment statement of "next_base", so > > S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; > /next_base = mem_base + mem_len; >

[Qemu-devel] [PATCH for-2.11 3/4] coroutine: Cancel aio_co_schedule() on direct entry

2017-11-28 Thread Kevin Wolf
If a coroutine can be reentered from multiple possible sources, we need to be careful in the case that two sources try to reenter it at the same time. There are two different cases where this can happen: 1. A coroutine spawns multiple asynchronous jobs and waits for all of them to complete.

[Qemu-devel] [PATCH for-2.11 1/4] Revert "coroutine: abort if we try to schedule or enter a pending coroutine"

2017-11-28 Thread Kevin Wolf
This reverts commit 6133b39f3c36623425a6ede9e89d93175fde15cd. The commit checked conditions that would expose a bug, but there is no real reason to forbid them apart from the bug, which we'll fix in a minute. In particular, reentering a coroutine during co_aio_sleep_ns() is fine; the function is

[Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full reset

2017-11-28 Thread Eric Auger
Voiding the ITS caches is not supposed to happen via individual register writes. So we introduced a dedicated ITS KVM device ioctl to perform a cold reset of the ITS: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_ITS_CTRL_RESET. Let's use this latter if the kernel supports it. Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH v9 00/13] Add support for the ZynqMP Generic QSPI

2017-11-28 Thread Peter Maydell
On 26 November 2017 at 23:16, Francisco Iglesias wrote: > Hi, > > This patch series is an attempt to add support for the ZynqMP QSPI (consisting > of the Generic QSPI and the legacy QSPI) to the xlnx-zcu102 board and connect > Numonyx n25q512a11 flashes to the QSPI.

Re: [Qemu-devel] [PATCH for-2.11 2/4] Revert "blockjob: do not allow coroutine double entry or entry-after-completion"

2017-11-28 Thread Jeff Cody
On Tue, Nov 28, 2017 at 04:43:48PM +0100, Kevin Wolf wrote: > This reverts commit 4afeffc8572f40d8844b946a30c00b10da4442b1. > > This fixed the symptom of a bug rather than the root cause. Waking up a > sleeping coroutine is generally fine, we just need to make it work > correctly across

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Collin L. Walling
On 11/28/2017 06:45 AM, Thomas Huth wrote: On 27.11.2017 21:55, Collin L. Walling wrote: [...] +static void s390_ipl_set_boot_menu(uint8_t *boot_menu_enabled, + uint16_t *boot_menu_timeout) +{ +QemuOptsList *plist = qemu_find_opts("boot-opts"); +

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-28 Thread Tan, Jianfeng
On 11/28/2017 1:01 AM, Aaron Conole wrote: "Tan, Jianfeng" writes: On 11/27/2017 10:27 PM, Yuanhan Liu wrote: On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full reset

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 15:41, Eric Auger wrote: > Voiding the ITS caches is not supposed to happen via > individual register writes. So we introduced a dedicated > ITS KVM device ioctl to perform a cold reset of the ITS: >

[Qemu-devel] [PATCH 2/2] qemu-options: document memory-backend-ram

2017-11-28 Thread Stefan Hajnoczi
The documentation should mention -object memory-backend-ram. Suggested-by: Yumei Huang Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-11-28 Thread Denis V. Lunev
On 11/28/2017 07:08 PM, Kevin Wolf wrote: > Am 28.11.2017 um 13:10 hat Denis V. Lunev geschrieben: >> There are 2 cases I have spotted so far: >> 1) IDE ATAPI read processing. Actually this was reported from field >> 2) QEMU IO hmp command (found during evaluation of (1)) >> >> SCSI code checks

  1   2   3   >