Re: [Qemu-devel] [PATCH v3 43/45] windbg: implemented kd_api_query_memory

On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH v3 00/45] Windbg supporting

On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > An update of: > > v1: > https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html > > We made the debugger module WinDbg (like GDB) for QEMU. This is the > replacement of the remote stub

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

* Halil Pasic [2017-11-28 14:07:58 +0100]: [...] > > The auto-generated bus ids are affected by both changes. We hope to not > encounter any auto-generated bus ids in production as Libvirt is always > explicit about the bus id. Since 8ed179c937 ("s390x/css: catch

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

* Dong Jia Shi [2017-11-29 16:17:35 +0800]: [...] > T6. squashing off + explicit given id > qemu-system-s390x: vmstate: get_nullptr expected VMS_NULLPTR_MARKER > qemu-system-s390x: Failed to load s390_css:css > qemu-system-s390x: error while loading state for

Re: [Qemu-devel] [PATCH v3 39/45] windbg: implemented kd_api_get_version

On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] QEMU Summit 2017: minutes

On Tue, 28 Nov 2017 13:30:23 -0500 John Snow wrote: > On 11/28/2017 04:36 AM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 09:33:52 +0100 > > Thomas Huth wrote: > > > >> On 27.11.2017 23:03, John Snow wrote: > >>> > >>> On 11/23/2017 11:31 AM, Peter

[Qemu-devel] NVME pass through in the guest VM

Hi Qemu Team i am new in qemu and trying for nvme pass through .. for that i used below git repo for nvme https://github.com/famz/qemu/tree/nvme and trying to launch the VM by below qemu command .. /usr/local/bin/qemu-system-x86_64 -name sl7.0 -m 1024 -object

[Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

Hello, I have been looking into this bug for a school project, and after reproducing the bug and tracing through the code, I have run into a wall trying to figure out the best way to approach this. If there is anyone who is familiar with qemu's fpu

[Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. Signed-off-by: David Gibson --- hw/acpi/pcihp.c | 1 - hw/i386/acpi-build.c| 1 - hw/i386/amd_iommu.h

[Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() are misleadingly named. They're not used for initializing *any* PCI bus, but only for a root PCI bus. Non-root buses - i.e. ones under a logical PCI to PCI bridge - are instead created with a direct qbus_create_inplace()

[Qemu-devel] [for-2.12 5/7] pci: Add pci_dev_bus_num() helper

A fair proportion of the users of pci_bus_num() want to get the bus number on a specific device, so first have to look up the bus from the device then call it. This adds a helper to do that (since we're going to make looking up the bus slightly more verbose). Signed-off-by: David Gibson

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] tests: ibm, configure-connector RTAS call implementation

On 11/28/2017 10:02 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-11-09 06:35:30) On 11/06/2017 03:46 PM, Laurent Vivier wrote: On 31/10/2017 21:43, Daniel Henrique Barboza wrote: 'ibm,configure-connector' hypercall is used by the guest OS to start the configuration of a

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

* Ying Fang (fangyi...@huawei.com) wrote: > > On 2017/11/28 18:18, Dr. David Alan Gilbert wrote: > > * fangying (fangyi...@huawei.com) wrote: > >> QEMU will abort when vhost-user process is restarted during migration > >> and vhost_log_global_start/stop is called. The reason is clear that > >>

Re: [Qemu-devel] [PATCH v5 0/8] aspeed: add a witherspoon-bmc machine

On 10/19/2017 05:12 PM, Cédric Le Goater wrote: > Hello, > > This series adds a new Aspeed machine to emulate the BMC of a > Witherspoon system. It also extends the other Aspeed machines with I2C > devices and adds a simple model for the pca9552 LED blinker present on > the witherspoon board. >

Re: [Qemu-devel] [PATCH v3 1/3] hostmem-file: add "align" option

On Wed, Nov 29, 2017 at 08:33:29AM +0800, Haozhong Zhang wrote: > On 11/27/17 23:07 -0200, Eduardo Habkost wrote: > > On Mon, Nov 27, 2017 at 12:35:15PM +0800, Haozhong Zhang wrote: > > > When mmap(2) the backend files, QEMU uses the host page size > > > (getpagesize(2)) by default as the

Re: [Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

On 29 November 2017 at 09:59, william lin wrote: > This bug has been around for 7+ years now. Qemu switched to softfloat and > it did not fix this. I think its most likely caused by Qemu's internal > representation not being accurate enough or accuracy lost during >

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

On 29/11/2017 10:46, David Gibson wrote: include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. I don't get the benefit from merging the header files. I would go the other way around and find stuff specific to pci_bus and

Re: [Qemu-devel] [for-2.12 5/7] pci: Add pci_dev_bus_num() helper

On 29/11/2017 10:46, David Gibson wrote: A fair proportion of the users of pci_bus_num() want to get the bus number on a specific device, so first have to look up the bus from the device then call it. This adds a helper to do that (since we're going to make looking up the bus slightly more

[Qemu-devel] [Bug 645662] Re: Python 3.1.2 math errors with Qemu 0.12.5

softfloat deals with doing the basic IEEE ops (add, subtract, multiply, etc) at the correct 80 bit precision, but it doesn't provide implementations of the x87's more complex operations (sin, cos, log, etc), so QEMU is still doing those by converting from 80 bit to host double and using the host C

Re: [Qemu-devel] QEMU Summit 2017: minutes

On Wed, 11/29 09:31, Cornelia Huck wrote: > On Tue, 28 Nov 2017 13:30:23 -0500 > John Snow wrote: > > > On 11/28/2017 04:36 AM, Cornelia Huck wrote: > > > On Tue, 28 Nov 2017 09:33:52 +0100 > > > Thomas Huth wrote: > > > > > >> On 27.11.2017 23:03, John

Re: [Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

Hi, The goal of the project is to fix the bug. Sorry I should have been more clear. This bug has been around for 7+ years now. Qemu switched to softfloat and it did not fix this. I think its most likely caused by Qemu's internal representation not being accurate enough or accuracy lost during

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

On Wed, 29 Nov 2017 15:41:45 +0530 (IST) P J P wrote: > Hello Cornelia, > > +-- On Tue, 28 Nov 2017, Cornelia Huck wrote --+ > | What is "unfit for use"? > > Unfit for use because we see checks like > > if (!virtio_queue_get_num(vdev, n)) { > continue; >

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

On Wed, 29 Nov 2017 16:17:35 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-11-28 14:07:58 +0100]: > > [...] > > > > The auto-generated bus ids are affected by both changes. We hope to not > > encounter any auto-generated bus ids in

[Qemu-devel] [for-2.12 7/7] pci: Eliminate pci_find_primary_bus()

pci_find_primary_bus() only has one user, in pc_xen_hvm_init(). That's inside the machine construction code, so it already has easy access to the machine's primary PCI bus. Get it directly, and thereby remove pci_find_primary_bus(). This removes one of only a handful of users of the ugly

Re: [Qemu-devel] [PATCH qemu-web v2] Suggest qemu-web prefix in the introductory post

On 29/11/2017 05:00, Fam Zheng wrote: > Chances are qemu-devel@nongnu.org patches only adding new files can be > picked up by patchew and treated like a qemu.git patch. Patchew already > ignores [qemu-web] patches, so suggest it in this article as well. (Are > there better places to document

Re: [Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

Hi, I have the same problem here with some of our math testsuites. It's about some precision issue with trigonometric tests. I didn't had time to figure out what happen neither what is really going wrong. eg: trigonometric function or? A quick workaround is to use KVM when possible. Fred On

Re: [Qemu-devel] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter model

On 11/29/2017 06:11 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:42PM +0100, Cédric Le Goater wrote: >> The XIVE interrupt presenter exposes a set of rings, also called >> Thread Interrupt Management Areas (TIMA), to handle priority >> management and interrupt acknowledgment among other

Re: [Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

I would write some more basic tests. eg: at instruction level and compare KVM vs TCG mode to find out which trigo instructions are differents (probably not only one). BTW I'm not floating point expert at all :). Fred On 11/29/2017 10:59 AM, william lin wrote: Hi, The goal of the project is

Re: [Qemu-devel] [for-2.12 2/7] pci: Move bridge data structures from pci_bus.h to pci_bridge.h

On 29/11/2017 10:46, David Gibson wrote: include/hw/pci/pci_bus.h contains several data structures related to PCI bridges that aren't needed by most users of pci_bus.h. We already have a pci_bridge.h, so move them there. Signed-off-by: David Gibson ---

Re: [Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root()

On 29/11/2017 10:46, David Gibson wrote: pci_bus_is_root() currently relies on a method in the PCIBusClass. But it's always known if a PCI bus is a root bus when we create it, so using a dynamic method is overkill. This replaces it with an IS_ROOT bit in a new flags field, which is set on root

Re: [Qemu-devel] [for-2.12 7/7] pci: Eliminate pci_find_primary_bus()

On 29/11/2017 10:46, David Gibson wrote: pci_find_primary_bus() only has one user, in pc_xen_hvm_init(). That's inside the machine construction code, so it already has easy access to the machine's primary PCI bus. Get it directly, and thereby remove pci_find_primary_bus(). This removes one of

[Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root()

pci_bus_is_root() currently relies on a method in the PCIBusClass. But it's always known if a PCI bus is a root bus when we create it, so using a dynamic method is overkill. This replaces it with an IS_ROOT bit in a new flags field, which is set on root buses and otherwise clear. As a bonus this

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zcu102: Specify the valid CPUs

On Thu, 26 Oct 2017 11:59:16 +0200 Alistair Francis wrote: > On Mon, Oct 23, 2017 at 1:14 PM, Philippe Mathieu-Daudé > wrote: > > On 10/17/2017 07:31 PM, Alistair Francis wrote: > >> List all possible valid CPU options. > >> > >> Signed-off-by:

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

On Wed, Nov 29, 2017 at 05:18:47PM +0800, Fam Zheng wrote: > On Wed, 11/29 01:02, no-re...@patchew.org wrote: > > /tmp/cc3Czn0R.s: Fatal error: can't write 3947 bytes to section .debug_str > > of hw/arm/virt-acpi-build.o because: 'No space left on device' > > Hmm, the host is shared and what I

[Qemu-devel] [PATCH 3/4] blockjob: introduce block_job_do_yield

Hide the clearing of job->busy in a single function, and set it in block_job_enter. This lets block_job_do_yield verify that qemu_coroutine_enter is not used while job->busy = false. Signed-off-by: Paolo Bonzini --- blockjob.c | 24 1 file changed,

[Qemu-devel] [PATCH 1/4] block: Expect graph changes in bdrv_parent_drained_begin/end

From: Kevin Wolf The .drained_begin/end callbacks can (directly or indirectly via aio_poll()) cause block nodes to be removed or the current BdrvChild to point to a different child node. Use QLIST_FOREACH_SAFE() to make sure we don't access invalid BlockDriverStates or

[Qemu-devel] [PATCH 2/4] blockjob: remove clock argument from block_job_sleep_ns

All callers are using QEMU_CLOCK_REALTIME, and it will not be possible to support more than one clock when block_job_sleep_ns switches to a single timer stored in the BlockJob struct. Signed-off-by: Paolo Bonzini --- block/backup.c | 4 ++-- block/commit.c

[Qemu-devel] [PATCH 0/4] blockjob: reinstate busy=false/busy=true in block_job_sleep_ns

In order to avoid reentering a scheduled coroutine this series uses a QEMUTimer outside co_aio_sleep_ns. The timer callback just calls block_job_enter, and can be easily cancelled with timer_del. This fixes the outstanding issues with block jobs, without reverting the new checks that Jeff added.

Re: [Qemu-devel] [for-2.12 6/7] pci: Eliminate redundant PCIDevice::bus pointer

On Wed, Nov 29, 2017 at 12:54:04PM +0200, Marcel Apfelbaum wrote: > On 29/11/2017 10:46, David Gibson wrote: > > The bus pointer in PCIDevice is basically redundant with QOM information. > > It's always initialized to the qdev_get_parent_bus(), the only difference > > is the type. > > > >

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

On Wed, 11/29 01:02, no-re...@patchew.org wrote: > /tmp/cc3Czn0R.s: Fatal error: can't write 3947 bytes to section .debug_str of > hw/arm/virt-acpi-build.o because: 'No space left on device' Hmm, the host is shared and what I have is a normal user account, so there is no control over disk space

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

Hello Cornelia, +-- On Tue, 28 Nov 2017, Cornelia Huck wrote --+ | What is "unfit for use"? Unfit for use because we see checks like if (!virtio_queue_get_num(vdev, n)) { continue; ... if (!vdev->vq[n].vring.num) { return; 'virtio_queue_set_rings' sets 'vring.desc' as

Re: [Qemu-devel] [PATCH v5 0/8] aspeed: add a witherspoon-bmc machine

On 29 November 2017 at 09:58, Cédric Le Goater wrote: > On 10/19/2017 05:12 PM, Cédric Le Goater wrote: >> - introduce a dummy ROM device to catch invalid writes >> - removed 'ignore_memory_transaction_failures' on all Aspeed machines > > So that was a bad idea because old

[Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

This reverts the effects of commit 4afeffc857 ("blockjob: do not allow coroutine double entry or entry-after-completion", 2017-11-21) This fixed the symptom of a bug rather than the root cause. Canceling the wait on a sleeping blockjob coroutine is generally fine, we just need to make it work

Re: [Qemu-devel] [PATCH] i386: turn off l3-cache property by default

On Wed, Nov 29, 2017 at 08:46:55AM +0300, Roman Kagan wrote: > On Tue, Nov 28, 2017 at 07:13:26PM -0200, Eduardo Habkost wrote: > > [CCing the people who were copied in the original patch that > > enabled l3cache] > > Thanks, and sorry to have forgotten to do so in the patch! > > > On Tue, Nov

Re: [Qemu-devel] [for-2.12 6/7] pci: Eliminate redundant PCIDevice::bus pointer

On 29/11/2017 10:46, David Gibson wrote: The bus pointer in PCIDevice is basically redundant with QOM information. It's always initialized to the qdev_get_parent_bus(), the only difference is the type. Therefore this patch eliminates the field, instead creating a pci_get_bus() helper to do the

[Qemu-devel] [for-2.12 6/7] pci: Eliminate redundant PCIDevice::bus pointer

The bus pointer in PCIDevice is basically redundant with QOM information. It's always initialized to the qdev_get_parent_bus(), the only difference is the type. Therefore this patch eliminates the field, instead creating a pci_get_bus() helper to do the type mangling to derive it conveniently

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

On 29/11/2017 05:10, Michael S. Tsirkin wrote: >> " Interrupt mode for vhost-user is still not supported in current >> implementation. But we are evaluating the necessity now. > > That's more or less a spec violation. Guest must get interrupts > if it does not disable them. And it must notify

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

On 11/29/2017 5:11 PM, Paolo Bonzini wrote: On 29/11/2017 05:10, Michael S. Tsirkin wrote: " Interrupt mode for vhost-user is still not supported in current implementation. But we are evaluating the necessity now. That's more or less a spec violation. Guest must get interrupts if it does not

Re: [Qemu-devel] [PATCH] i386: turn off l3-cache property by default

On Wed, Nov 29, 2017 at 01:20:38PM +0800, Longpeng (Mike) wrote: > On 2017/11/29 5:13, Eduardo Habkost wrote: > > [CCing the people who were copied in the original patch that > > enabled l3cache] > > > > On Tue, Nov 28, 2017 at 11:20:27PM +0300, Denis V. Lunev wrote: > >> On 11/28/2017 10:58 PM,

[Qemu-devel] [for-2.12 0/7] PCI cleanups

Here are a bunch of straightforward cleanups for the PCI code in qemu-2.12. These came up while I was looking at various other things. David Gibson (7): pci: Rename root bus initialization functions for clarity pci: Move bridge data structures from pci_bus.h to pci_bridge.h pci: Fold

[Qemu-devel] [for-2.12 2/7] pci: Move bridge data structures from pci_bus.h to pci_bridge.h

include/hw/pci/pci_bus.h contains several data structures related to PCI bridges that aren't needed by most users of pci_bus.h. We already have a pci_bridge.h, so move them there. Signed-off-by: David Gibson --- include/hw/pci-host/xilinx-pcie.h | 2 +-

Re: [Qemu-devel] [PATCH] linux-user/arm/nwfpe: Check coprocessor number for FPA emulation

On 11/28/2017 05:34 PM, Peter Maydell wrote: > Our copy of the nwfpe code for emulating of the old FPA11 floating > point unit doesn't check the coprocessor number in the instruction > when it emulates it. This means that we might treat some > instructions which should really UNDEF as being FPA11

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

Hi David, On 29/11/2017 10:46, David Gibson wrote: pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() are misleadingly named. They're not used for initializing *any* PCI bus, but only for a root PCI bus. Non-root buses - i.e. ones under a logical PCI to PCI bridge -

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

On Thu, 23 Nov 2017 14:29:38 +0100 Cédric Le Goater wrote: > The XIVE interrupt controller uses a set of tables to redirect exception > from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) > table, also known as Event Assignment Structure (EAS), is one them.

[Qemu-devel] [Bug 1715186] Re: websockets: Improve error messages

Will be included for 2.11 in commit 3a3f8705962c8c8a47a9b981ffd5aab7274ad508 Author: Daniel P. Berrange Date: Wed Sep 6 11:38:36 2017 +0100 io: include full error message in websocket handshake trace When the websocket handshake fails it is useful to log the

Re: [Qemu-devel] [PATCH v2 2/4] tests: adding 'set_indicator' RTAS call

Quoting Daniel Henrique Barboza (2017-10-31 15:43:28) > 'set_indicator' is a RTAS hypercall that is used to change > the state of both physical and logical devices DRCs by setting > allocation-state, isolation-state and dr-indicator. > > This patch implements the set_indicator RTAS call in >

[Qemu-devel] [PATCH RESEND 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

[Resending for the second time] Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and

Re: [Qemu-devel] [Bug 645662] x87 fpu emulation not accurate enough

On 11/29/2017 11:27 AM, Peter Maydell wrote: On 29 November 2017 at 09:59, william lin wrote: This bug has been around for 7+ years now. Qemu switched to softfloat and it did not fix this. I think its most likely caused by Qemu's internal representation not being accurate

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

Am 29.11.2017 um 11:25 hat Paolo Bonzini geschrieben: > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > coroutine double entry or entry-after-completion", 2017-11-21) > > This fixed the symptom of a bug rather than the root cause. Canceling the > wait on a sleeping

Re: [Qemu-devel] [PATCH 2/4] blockjob: remove clock argument from block_job_sleep_ns

On Wed, Nov 29, 2017 at 11:25:11AM +0100, Paolo Bonzini wrote: > All callers are using QEMU_CLOCK_REALTIME, and it will not be possible to > support more than one clock when block_job_sleep_ns switches to a single > timer stored in the BlockJob struct. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 3/4] blockjob: introduce block_job_do_yield

On Wed, Nov 29, 2017 at 11:25:12AM +0100, Paolo Bonzini wrote: > Hide the clearing of job->busy in a single function, and set it > in block_job_enter. This lets block_job_do_yield verify that > qemu_coroutine_enter is not used while job->busy = false. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

On Wed, Nov 29, 2017 at 01:54:39PM +0100, Kevin Wolf wrote: > Am 29.11.2017 um 11:25 hat Paolo Bonzini geschrieben: > > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > > coroutine double entry or entry-after-completion", 2017-11-21) > > > > This fixed the symptom of a bug

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] blockjob: remove clock argument from block_job_sleep_ns

On Wed, Nov 29, 2017 at 11:25:11AM +0100, Paolo Bonzini wrote: > All callers are using QEMU_CLOCK_REALTIME, and it will not be possible to > support more than one clock when block_job_sleep_ns switches to a single > timer stored in the BlockJob struct. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [Qemu-block] [PATCH 3/4] blockjob: introduce block_job_do_yield

On Wed, Nov 29, 2017 at 11:25:12AM +0100, Paolo Bonzini wrote: > Hide the clearing of job->busy in a single function, and set it > in block_job_enter. This lets block_job_do_yield verify that > qemu_coroutine_enter is not used while job->busy = false. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote: > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > coroutine double entry or entry-after-completion", 2017-11-21) > > This fixed the symptom of a bug rather than the root cause. Canceling the > wait on a

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote: > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > coroutine double entry or entry-after-completion", 2017-11-21) > > This fixed the symptom of a bug rather than the root cause. Canceling the > wait on a

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts

On 29.11.2017 14:51, Thomas Huth wrote: > On 28.11.2017 21:33, David Hildenbrand wrote: >> I have quite some patches on my queue for 2.12. (booting Fedora 26/27 >> guests, floating interrupts, machine checks, missing instructions ...) >> >> So let's start slowly :) This series gets rid of

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

On 29/11/2017 13:00, Stefan Hajnoczi wrote: > We are at a point where code review isn't finding certain bugs because > no single person knows all the assumptions. Previously the problem was > contained because maintainers spotted problems before patches were > merged. > > This is not primarily a

[Qemu-devel] [PATCH RESEND 2/2] x86_iommu: check if machine has PCI bus

Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not

Re: [Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root()

On Wed, Nov 29, 2017 at 12:45:28PM +0200, Marcel Apfelbaum wrote: > On 29/11/2017 10:46, David Gibson wrote: > > pci_bus_is_root() currently relies on a method in the PCIBusClass. > > But it's always known if a PCI bus is a root bus when we create it, so > > using a dynamic method is overkill. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

On 11/29/2017 12:49 PM, Greg Kurz wrote: > On Thu, 23 Nov 2017 14:29:38 +0100 > Cédric Le Goater wrote: > >> The XIVE interrupt controller uses a set of tables to redirect exception >> from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) >> table, also known

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

On 29 November 2017 at 13:42, Laurent Vivier wrote: > these functions come from: > > http://previous.alternative-system.com/ > > http://svn.code.sf.net/p/previous/code/trunk/src/softfloat/softfloat.c > > This is also a modified softfloat, release 2b > which is BSD license if

[Qemu-devel] [PATCH v18 04/10] xbitmap: potential improvement

This patch made some changes to the original xbitmap implementation from the linux-dax tree: - remove xb_fill() and xb_zero() from xbitmap.h since they are not implemented; - xb_test_bit: changed "ebit > BITS_PER_LONG" to "ebit >= BITS_PER_LONG", because bit 64 beyonds the "unsigned long"

[Qemu-devel] [PATCH v18 09/10] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the

[Qemu-devel] [PATCH v18 07/10] virtio-balloon: VIRTIO_BALLOON_F_SG

Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. A scatter-gather list is described by a vring desc. The implementation of the previous virtio-balloon is not very efficient, because the balloon

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

On Wed, Nov 29, 2017 at 03:21:37PM +0100, Kevin Wolf wrote: > Am 29.11.2017 um 14:56 hat Jeff Cody geschrieben: > > On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote: > > > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > > > coroutine double entry or

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

On Wed, Nov 29, 2017 at 11:55:02AM +0800, Fam Zheng wrote: > As we move forwards with new features in the block layer, the chances of > tricky > bugs happening have been increasing alongside - block jobs, coroutines, > throttling, AioContext, op blockers and image locking combined together make a

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] block: Expect graph changes in bdrv_parent_drained_begin/end

On Wed 29 Nov 2017 11:25:10 AM CET, Paolo Bonzini wrote: > From: Kevin Wolf > > The .drained_begin/end callbacks can (directly or indirectly via > aio_poll()) cause block nodes to be removed or the current BdrvChild to > point to a different child node. > > Use

[Qemu-devel] [Bug 645662] Re: QEMU x87 emulation of trig and other complex ops is only at 64-bit precision, not 80-bit

Laurent Vivier recently started to adapt some of function from the "Previous" NeXT emulator for m68k, see e.g. this patch series here: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04454.html Not sure, but I think that could help to fix at least some of the missing functions. --

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] blockjob: remove clock argument from block_job_sleep_ns

On Wed 29 Nov 2017 11:25:11 AM CET, Paolo Bonzini wrote: > All callers are using QEMU_CLOCK_REALTIME, and it will not be possible to > support more than one clock when block_job_sleep_ns switches to a single > timer stored in the BlockJob struct. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [Qemu-block] Block layer complexity: what to do to keep it under control?

On Wed, Nov 29, 2017 at 01:24:46PM +0100, Paolo Bonzini wrote: > On 29/11/2017 13:00, Stefan Hajnoczi wrote: > > We are at a point where code review isn't finding certain bugs because > > no single person knows all the assumptions. Previously the problem was > > contained because maintainers

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

+switch (offset) { +case 0: +spapr_xive_source_eoi(xive, lisn); >>> >>> Hrm. I don't love that you're dealing with clearing that LSI bit >>> here, but setting it at a different level. >>> >>> The state machines are doing my head in a bit, is there any way >>> you

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] block: Expect graph changes in bdrv_parent_drained_begin/end

Am 29.11.2017 um 14:44 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 29, 2017 at 11:25:10AM +0100, Paolo Bonzini wrote: > > From: Kevin Wolf > > > > The .drained_begin/end callbacks can (directly or indirectly via > > aio_poll()) cause block nodes to be removed or the current

[Qemu-devel] [PATCH v18 08/10] mm: support reporting free page blocks

This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of

[Qemu-devel] [PATCH v18 01/10] idr: add #include

The was removed from radix-tree.h by the following commit: f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. Since that commit, tools/testing/radix-tree/ couldn't pass compilation due to: tools/testing/radix-tree/idr.c:17: undefined reference to WARN_ON_ONCE. This patch adds the bug.h header to idr.h to

[Qemu-devel] [PATCH v18 06/10] virtio_ring: add a new API, virtqueue_add_one_desc

Current virtqueue_add API implementation is based on the scatterlist struct, which uses kaddr. This is inadequate to all the use case of vring. For example: - Some usages don't use IOMMU, in this case the user can directly pass in a physical address in hand, instead of going through the sg

[Qemu-devel] [PATCH v18 03/10] xbitmap: Introduce xbitmap

From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits, and this commit adds the bare bones -- xb_set_bit(), xb_clear_bit() and xb_test_bit().

[Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned free pages will trigger false positive when new pages are allocated and checked on the destination. This patch

Re: [Qemu-devel] [PATCH v17 2/6] radix tree test suite: add tests for xbitmap

On 11/07/2017 01:00 AM, Matthew Wilcox wrote: On Fri, Nov 03, 2017 at 04:13:02PM +0800, Wei Wang wrote: From: Matthew Wilcox Add the following tests for xbitmap: 1) single bit test: single bit set/clear/find; 2) bit range test: set/clear a range of bits and find a 0 or

[Qemu-devel] [Bug 1724477] Re: Build-in websocket broken since v2.9.0-rc0

Key fixes for client interoperability coming in 2.11 include 6d5d23b00709510d55711661c7ca41408fd9934e io: cope with websock 'Connection' header having multiple values 530ca60c16c83435d4becc9916d74fa43e003815 io: Attempt to send websocket close messages to client

Re: [Qemu-devel] [for-2.12 6/7] pci: Eliminate redundant PCIDevice::bus pointer

On Wed, Nov 29, 2017 at 09:41:09AM -0200, Eduardo Habkost wrote: > On Wed, Nov 29, 2017 at 12:54:04PM +0200, Marcel Apfelbaum wrote: > > On 29/11/2017 10:46, David Gibson wrote: > > > The bus pointer in PCIDevice is basically redundant with QOM information. > > > It's always initialized to the

Re: [Qemu-devel] [PATCH] i386: turn off l3-cache property by default

On Wed, Nov 29, 2017 at 07:58:19PM +0800, Longpeng (Mike) wrote: > On 2017/11/29 18:41, Eduardo Habkost wrote: > > On Wed, Nov 29, 2017 at 01:20:38PM +0800, Longpeng (Mike) wrote: > >> On 2017/11/29 5:13, Eduardo Habkost wrote: > >>> On Tue, Nov 28, 2017 at 11:20:27PM +0300, Denis V. Lunev wrote:

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] block: Expect graph changes in bdrv_parent_drained_begin/end

On Wed, Nov 29, 2017 at 11:25:10AM +0100, Paolo Bonzini wrote: > From: Kevin Wolf > > The .drained_begin/end callbacks can (directly or indirectly via > aio_poll()) cause block nodes to be removed or the current BdrvChild to > point to a different child node. > > Use

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts

On 28.11.2017 21:33, David Hildenbrand wrote: > I have quite some patches on my queue for 2.12. (booting Fedora 26/27 > guests, floating interrupts, machine checks, missing instructions ...) > > So let's start slowly :) This series gets rid of program_interrupt() and > potential_page_fault(). We

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

Le 29/11/2017 à 15:08, Thomas Huth a écrit : > On 29.11.2017 14:59, Peter Maydell wrote: >> On 29 November 2017 at 13:42, Laurent Vivier wrote: >>> these functions come from: >>> >>> http://previous.alternative-system.com/ >>> >>>

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

Am 29.11.2017 um 14:56 hat Jeff Cody geschrieben: > On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote: > > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow > > coroutine double entry or entry-after-completion", 2017-11-21) > > > > This fixed the symptom of a bug

Re: [Qemu-devel] [PATCH] i386: turn off l3-cache property by default

On 2017/11/29 18:41, Eduardo Habkost wrote: > On Wed, Nov 29, 2017 at 01:20:38PM +0800, Longpeng (Mike) wrote: >> On 2017/11/29 5:13, Eduardo Habkost wrote: >>> [CCing the people who were copied in the original patch that >>> enabled l3cache] >>> >>> On Tue, Nov 28, 2017 at 11:20:27PM +0300,

Re: [Qemu-devel] [PATCH v2 3/4] tests: ibm, configure-connector RTAS call implementation

Quoting Daniel Henrique Barboza (2017-10-31 15:43:29) > 'ibm,configure-connector' hypercall is used by the guest OS > to start the configuration of a given device, where the > machine configures the said device and all its sub-devices, > giving back FDTs to the caller for each sub-device. > >

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

On Wed, Nov 29, 2017 at 11:55:02AM +0800, Fam Zheng wrote: > So in principle, what should we do to make the block layer easy to understand, > develop with and debug? I think we have opportunities in these aspects: > > - Documentation > > There is no central developer doc about block layer,

[Qemu-devel] [PATCH RESEND 1/2] x86_iommu: Move machine check to x86_iommu_realize()

Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Reviewed-by: Peter Xu Reviewed-by: Eduardo Habkost Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c

  1   2   3   4   >