Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes

2017-12-14 Thread Michael S. Tsirkin
On Fri, Dec 15, 2017 at 02:38:35AM +, Zhoujian (jay) wrote: > Hi Dave, > > > -Original Message- > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Friday, December 15, 2017 3:49 AM > > To: Michael S. Tsirkin > > Cc: Zhoujian (jay)

Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes

2017-12-14 Thread Zhoujian (jay)
Hi Michael, > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, December 15, 2017 12:36 PM > To: Zhoujian (jay) > Cc: Dr. David Alan Gilbert ; qemu-devel@nongnu.org; > Huangweidong (C)

[Qemu-devel] [PULL 22/24] spapr: Rename machine init functions for clarity

2017-12-14 Thread David Gibson
Machine objects have two init functions - the generic QOM level instance_init which should only do static object initialization, and the Machine specific MachineClass::init which does the actual construction of the machine. In spapr the functions implementing these two have names -

[Qemu-devel] [PULL 19/24] spapr: fix LSI interrupt specifiers in the device tree

2017-12-14 Thread David Gibson
From: Greg Kurz LoPAPR 1.1 B.6.9.1.2 describes the "#interrupt-cells" property of the PowerPC External Interrupt Source Controller node as follows: “#interrupt-cells” Standard property name to define the number of cells in an interrupt- specifier within an interrupt domain.

[Qemu-devel] [PULL 14/24] ppc/xics: assign of the CPU 'intc' pointer under the core

2017-12-14 Thread David Gibson
From: Cédric Le Goater The 'intc' pointer of the CPU references the interrupt presenter in the XICS interrupt mode. When the XIVE interrupt mode is available and activated, the machine will need to reassign this pointer to reflect the change. Moving this assignment under the

Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64()

2017-12-14 Thread Philippe Mathieu-Daudé
good catch :) I'll respin with: case SDHC_ADMASYSADDR: s->admasysaddr = deposit64(s->admasysaddr, 0, 32, value) break; case SDHC_ADMASYSADDR + 4: s->admasysaddr = deposit64(s->admasysaddr, 32, 32, value); break; >>>

Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes

2017-12-14 Thread Zhoujian (jay)
Hi Dave, > -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, December 15, 2017 3:49 AM > To: Michael S. Tsirkin > Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; > Huangweidong (C)

[Qemu-devel] [PATCH v4 09/43] hw: use "qemu/osdep.h" as first #include in source files

2017-12-14 Thread Philippe Mathieu-Daudé
applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Acked-by: David Gibson Acked-by: Cornelia Huck --- hw/acpi/ipmi-stub.c | 1 +

[Qemu-devel] [PATCH v4 20/43] hw/input/vmmouse: remove unused #include

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/input/vmmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/input/vmmouse.c b/hw/input/vmmouse.c index b6d22086f4..65ef55329e 100644 --- a/hw/input/vmmouse.c +++ b/hw/input/vmmouse.c @@ -24,7 +24,6 @@ #include

[Qemu-devel] [PATCH v4 16/43] i386/hax: remove duplicated include

2017-12-14 Thread Philippe Mathieu-Daudé
this file in include in "target/i386/hax-i386.h": #ifdef CONFIG_WIN32 #include "target/i386/hax-windows.h" #endif which guaranties that sysemu/os-win32.h is previously included (CONFIG_WIN32) Suggested-by: Peter Maydell Signed-off-by: Philippe

[Qemu-devel] [PATCH v4 18/43] misc: avoid "include/" in include path

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/input/adb.c | 2 +- hw/ssi/aspeed_smc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/adb.c b/hw/input/adb.c index fcca3a8eb9..924a3f9fd5

[Qemu-devel] [PATCH v4 42/43] hw/i386/vmport: replace fprintf() by trace events

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/vmport.c | 8 +++- hw/i386/trace-events | 4 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index eb880c6def..b5585a009a 100644 --- a/hw/i386/vmport.c +++

[Qemu-devel] [PATCH v4 33/43] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch

2017-12-14 Thread Philippe Mathieu-Daudé
this allows to remove the old i386/pc dependency on acpi/core. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- include/hw/acpi/acpi.h | 11 +++ include/hw/i386/pc.h | 11 --- hw/acpi/core.c | 1 - 3 files

[Qemu-devel] [PATCH v4 23/43] amd_iommu: avoid needless includes in header file

2017-12-14 Thread Philippe Mathieu-Daudé
instead move them to the source file Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i386/amd_iommu.h | 5 - hw/i386/amd_iommu.c | 5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/amd_iommu.h

[Qemu-devel] [PULL 06/24] nvram: add AT24Cx i2c eeprom

2017-12-14 Thread David Gibson
From: Michael Davidsaver Signed-off-by: Michael Davidsaver Signed-off-by: David Gibson --- hw/nvram/Makefile.objs | 1 + hw/nvram/eeprom_at24c.c | 205 2 files

[Qemu-devel] [PULL 16/24] spapr: introduce a spapr_irq_set_lsi() helper

2017-12-14 Thread David Gibson
From: Cédric Le Goater It will make synchronisation easier with the XIVE interrupt mode when available. The 'irq' parameter refers to the global IRQ number space. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson

[Qemu-devel] [PULL 01/24] target/ppc: Use tcg_gen_lookup_and_goto_ptr

2017-12-14 Thread David Gibson
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: David Gibson --- target/ppc/translate.c | 23 --- 1 file changed, 8

Re: [Qemu-devel] [PATCH qemu v2] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

2017-12-14 Thread David Gibson
On Tue, Dec 12, 2017 at 04:16:19PM +1100, Alexey Kardashevskiy wrote: > The vfio_iommu_spapr_tce driver advertises kernel's support for > v1 and v2 IOMMU support, however it is not always possible to use > the requested IOMMU type. For example, a pseries host platform does not > support dynamic

[Qemu-devel] [PATCH] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency

2017-12-14 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 84 ++-- hw/ppc/pnv_core.c| 8 ++--- hw/ppc/pnv_lpc.c | 2 +- include/hw/ppc/pnv.h | 8 ++--- 4 files changed, 51 insertions(+), 51 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes

2017-12-14 Thread Zhoujian (jay)
Hi Michael, > -Original Message- > From: Zhoujian (jay) > Sent: Friday, December 15, 2017 12:52 PM > To: 'Michael S. Tsirkin' > Cc: Dr. David Alan Gilbert ; qemu-devel@nongnu.org; > Huangweidong (C) ; Gonglei (Arei) >

[Qemu-devel] [Bug 1704658] Re: O_CLOEXEC not handled in dup3 system call in user mode

2017-12-14 Thread Bruno Haible
The behaviour in qemu-2.11 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1704658 Title: O_CLOEXEC not handled in dup3 system call in user mode Status in QEMU: New

[Qemu-devel] [Bug 1704638] Re: weak symbol access makes qemu in user mode hang for mips, mips64

2017-12-14 Thread Bruno Haible
This is fixed in qemu-2.11: $ ~/inst-qemu/2.11.0/bin/qemu-mips testpthsigmask-mips qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped) $ ~/inst-qemu/2.11.0/bin/qemu-mips64 testpthsigmask-mips64 qemu: uncaught target signal 11 (Segmentation fault) -

[Qemu-devel] [Bug 1701974] Re: pwrite does not work right under qemu-sh4

2017-12-14 Thread Bruno Haible
Works fine in qemu-2.11: $ ~/inst-qemu/2.11.0/bin/qemu-sh4 test-pwrite buf = 01W3456789 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701974

[Qemu-devel] [PATCH v4 00/43] remove i386/pc dependency from non-PC world (part 1)

2017-12-14 Thread Philippe Mathieu-Daudé
Quite a bunch of patches and files modified, but the diffstat is not that big. Which Michael is willing to merge this? :) Regards, Phil. v4: - added R-b, A-b - rebased on 2.12 - fixed an english comment (Thomas) - replace fprintf() by trace events in hw/i386/vmport.c since v3: - addressed

[Qemu-devel] [PATCH v2 17/20] sdhci: add check_capab_readonly() qtest

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 4ebe1e349b..01373a69df 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -9,6

[Qemu-devel] [PATCH v4 37/43] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h"

2017-12-14 Thread Philippe Mathieu-Daudé
and remove the old i386/pc dependency. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/display/vga.h | 25 + include/hw/i386/pc.h | 12 hw/display/vga-isa-mm.c | 3 +--

[Qemu-devel] [PATCH v4 25/43] hw/ide: remove old i386 dependency

2017-12-14 Thread Philippe Mathieu-Daudé
and remove a duplicated include Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow --- hw/ide/ahci.c | 1 - hw/ide/cmd646.c | 1 - hw/ide/core.c | 3 +-- hw/ide/ich.c| 1 - hw/ide/isa.c| 1 - hw/ide/microdrive.c | 1 -

[Qemu-devel] [PATCH v4 17/43] nios2: remove duplicated includes (in code commented out)

2017-12-14 Thread Philippe Mathieu-Daudé
applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- target/nios2/cpu.h | 1 - disas/nios2.c| 3 --- hw/nios2/boot.c | 1 - target/nios2/helper.c| 5 +

Re: [Qemu-devel] [PATCH v4 42/43] hw/i386/vmport: replace fprintf() by trace events

2017-12-14 Thread Philippe Mathieu-Daudé
Oops I sent the wrong file :( On Fri, Dec 15, 2017 at 12:30 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/vmport.c | 8 +++- > hw/i386/trace-events | 4 > 2 files changed, 7 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v4 41/43] i386/pc: move vmmouse.c to hw/i386/

2017-12-14 Thread Philippe Mathieu-Daudé
It's a x86-only device, so it does not make sense to keep it in the shared misc folder. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/{input => i386}/vmmouse.c | 0 hw/i386/Makefile.objs| 1 + hw/input/Makefile.objs | 1 -

[Qemu-devel] [PULL 08/24] openpic: debug w/ info_report()

2017-12-14 Thread David Gibson
From: Michael Davidsaver Replace *printf() with *_report(). Remove trailing new lines. Signed-off-by: Michael Davidsaver Signed-off-by: David Gibson --- hw/intc/openpic.c | 102

[Qemu-devel] [PULL 10/24] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-12-14 Thread David Gibson
From: Cédric Le Goater When a CPU is stopped with the 'stop-self' RTAS call, its state 'halted' is switched to 1 and, in this case, the MSR is not taken into account anymore in the cpu_has_work() routine. Only the pending hardware interrupts are checked with their LPCR:PECE*

[Qemu-devel] [PULL 23/24] spapr: Assume msi_nonbroken

2017-12-14 Thread David Gibson
We conditionally adjust part of the guest device tree based on the global msi_nonbroken flag. However, the main machine type code initializes msi_nonbroken to true and there's nothing that would set it to false again. So replace the test with an assert(). Signed-off-by: David Gibson

[Qemu-devel] [PULL 05/24] e500: name openpic and pci host bridge

2017-12-14 Thread David Gibson
From: Michael Davidsaver Signed-off-by: Michael Davidsaver Signed-off-by: David Gibson --- hw/ppc/e500.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index

[Qemu-devel] [Bug 1701973] Re: pread does not work right under qemu-sh4

2017-12-14 Thread Bruno Haible
With qemu-2.11: $ ~/inst-qemu/2.11.0/bin/qemu-sh4 test-pread ret=1 errno=2 The value of errno is actually irrelevant here. So, the bug is fixed. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2017-12-14 Thread Bruno Haible
The behaviour in qemu-2.11 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701835 Title: floating-point operation bugs in qemu-alpha Status in QEMU: New Bug

[Qemu-devel] [PATCH v2 02/20] sdhci: use deposit64()

2017-12-14 Thread Philippe Mathieu-Daudé
This makes the code slightly safer, also easier to review. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index b7d2a20985..3c78033d49 100644 --- a/hw/sd/sdhci.c +++

[Qemu-devel] [PATCH v2 06/20] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init()

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index fc5bac5cb9..f574495b19 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1283,6 +1283,16 @@

[Qemu-devel] [PATCH v2 10/20] sdhci: add a GPIO for the access control LED

2017-12-14 Thread Philippe Mathieu-Daudé
It blinks to caution the user not to remove the card while the SD card is being accessed. So far it only emit a trace event. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 13 + hw/sd/trace-events| 1 + 3 files

[Qemu-devel] [PATCH v2 07/20] sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn()

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f574495b19..53c1f11855 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -31,6 +31,7 @@ #include

[Qemu-devel] [PATCH v4 06/43] MAINTAINERS: add an entry for input/pckbd.c

2017-12-14 Thread Philippe Mathieu-Daudé
and fix a typo in the "PC Chipset" section Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 00ce2931d9..27f190a70a

[Qemu-devel] [PATCH v4 12/43] misc: remove headers implicitly included

2017-12-14 Thread Philippe Mathieu-Daudé
applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi --- hw/audio/fmopl.h | 1 - bsd-user/main.c | 1 - chardev/wctablet.c

[Qemu-devel] [PATCH v4 01/43] MAINTAINERS: add entries for i2c/ppc4xx

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Corey Minyard --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45e2e2009b..8582c7d6b5 100644 ---

[Qemu-devel] [PATCH v4 02/43] MAINTAINERS: add an entry for the i82374 (southbridge)

2017-12-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Hervé Poussineau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8582c7d6b5..eb1646fbfe 100644 ---

[Qemu-devel] [PATCH v4 39/43] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h"

2017-12-14 Thread Philippe Mathieu-Daudé
and remove the old i386/pc dependency. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- include/hw/misc/pvpanic.h | 21 + hw/i386/acpi-build.c | 2 +- hw/misc/pvpanic.c | 9 - 4 files changed, 26

[Qemu-devel] [PATCH v4 38/43] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

2017-12-14 Thread Philippe Mathieu-Daudé
- add "hw/net/ne2000-isa.h" - remove the old i386 dependency Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau Acked-by: David Gibson [PPC] --- hw/net/ne2000.h | 3 +++ include/hw/i386/pc.h

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-14 Thread David Gibson
On Tue, Dec 12, 2017 at 04:21:31PM +1100, Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > This

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency

2017-12-14 Thread Alexey Kardashevskiy
On 15/12/17 17:17, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/ppc/pnv.c | 84 > ++-- > hw/ppc/pnv_core.c| 8 ++--- > hw/ppc/pnv_lpc.c | 2 +- > include/hw/ppc/pnv.h | 8 ++--- > 4 files

Re: [Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oob"

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:53PM +0800, Peter Xu wrote: > Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means > the command allows out-of-band execution. > > The "oob" idea is proposed by Markus Armbruster in following thread: > >

Re: [Qemu-devel] [RFC v5 23/26] qmp: add command "x-oob-test"

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:57PM +0800, Peter Xu wrote: > This command is only used to test OOB functionality. It should not be > used for any other purposes. > > Signed-off-by: Peter Xu > --- > qapi-schema.json | 18 ++ > qmp.c| 16

Re: [Qemu-devel] [RFC v5 22/26] monitor: enable IO thread for (qmp & !mux) typed

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:56PM +0800, Peter Xu wrote: > Start to use dedicate IO thread for QMP monitors that are not using > MUXed chardev. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu > --- > monitor.c | 3 ++- > 1 file

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2017-12-14 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307225 Title: Running a virtual machine on a Haswell system produces machine check events

Re: [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check

2017-12-14 Thread Igor Mammedov
On Wed, 13 Dec 2017 18:08:02 + "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Move the log_dirty check into vhost_section. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/trace-events

Re: [Qemu-devel] [RFC v5 24/26] docs: update QMP documents for OOB commands

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:58PM +0800, Peter Xu wrote: > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > index f04c63fe82..8597fdb087 100644 > --- a/docs/devel/qapi-code-gen.txt > +++ b/docs/devel/qapi-code-gen.txt > @@ -556,7 +556,8 @@ following example objects: >

Re: [Qemu-devel] [PATCH v3 41/50] qapi: add a 'unit' pragma

2017-12-14 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Dec 14, 2017 at 2:54 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Add a pragma that allows to tag the following expressions with a unit >>> name. By

[Qemu-devel] [PULL 5/6] xenfb: activate input handlers for raw pointer devices

2017-12-14 Thread Stefano Stabellini
From: Owen Smith If the frontend requests raw pointers, the input handlers must be activated to have the input events delivered to the xenfb backend. Without activation, the input events are delivered to handlers registered earlier, which would be the emulated USB tablet

[Qemu-devel] [PULL 0/6] xen-20171214-tag

2017-12-14 Thread Stefano Stabellini
The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20171214-tag for you to fetch changes up

[Qemu-devel] [PULL 2/6] ui: generate qcode to linux mappings

2017-12-14 Thread Stefano Stabellini
From: Owen Smith Use keycodedb to generate a qcode to linux mapping Signed-off-by: Owen Smith Reviewed-by: Gerd Hoffmann Signed-off-by: Stefano Stabellini --- Makefile | 1 +

[Qemu-devel] [PULL 6/6] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-14 Thread Stefano Stabellini
From: Simon Gaiser The passed-through device might be an express device. In this case the old code allocated a too small emulated config space in pci_config_alloc() since pci_config_size() returned the size for a non-express device. This leads to an out-of-bound write in

[Qemu-devel] [PULL 4/6] xenfb: Add [feature|request]-raw-pointer

2017-12-14 Thread Stefano Stabellini
From: Owen Smith Writes "feature-raw-pointer" during init to indicate the backend can pass raw unscaled values for absolute axes to the frontend. Frontends set "request-raw-pointer" to indicate the backend should not attempt to scale absolute values to console size.

[Qemu-devel] [PULL 1/6] xen-disk: use an IOThread per instance

2017-12-14 Thread Stefano Stabellini
From: Paul Durrant This patch allocates an IOThread object for each xen_disk instance and sets the AIO context appropriately on connect. This allows processing of I/O to proceed in parallel. The patch also adds tracepoints into xen_disk to make it possible to follow the

[Qemu-devel] [PULL 3/6] xenfb: Use Input Handlers directly

2017-12-14 Thread Stefano Stabellini
From: Owen Smith Avoid the unneccessary calls through the input-legacy.c file by using the qemu_input_handler_*() calls directly. This did require reworking the event and sync handlers to use the reverse mapping from qcode to linux using qemu_input_qcode_to_linux().

Re: [Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API

2017-12-14 Thread Philippe Mathieu-Daudé
> This is rewritten later, why bother setting this here? > >> >> >> -dma_memory_read(_space_memory, entry_addr + 2, >> -(uint8_t *)(>length), 2); >> -dscr->length = le16_to_cpu(dscr->length); >> +dscr->length = lduw_le_dma(_space_memory,

Re: [Qemu-devel] [PULL 0/2] hmp queue

2017-12-14 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Message-id: 20171214124817.2567-1-dgilb...@redhat.com Subject: [Qemu-devel] [PULL 0/2] hmp queue Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD

[Qemu-devel] [PATCH 0/2] virtio_net: allow hypervisor to indicate linkspeed and duplex setting

2017-12-14 Thread Jason Baron via Qemu-devel
We have found it useful to be able to set the linkspeed and duplex settings from the host-side for virtio_net. This obviates the need for guest changes and settings for these fields. The ability to set linkspeed and duplex was introduced by: 16032be virtio_net: add ethtool support for set and

[Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-14 Thread Jason Baron via Qemu-devel
Although they can be currently set in linux via 'ethtool -s', this requires guest changes, and thus it would be nice to extend this functionality such that it can be configured automatically from the host (as other network do). Linkspeed and duplex settings can be set as: '-device

[Qemu-devel] [PATCH net-next 1/2] virtio_net: allow hypervisor to indicate linkspeed and duplex setting

2017-12-14 Thread Jason Baron via Qemu-devel
If the hypervisor exports the link and duplex speed, let's use that instead of the default unknown speed. The user can still overwrite it later if desired via: 'ethtool -s'. This allows the hypervisor to set the default link speed and duplex setting without requiring guest changes and is

Re: [Qemu-devel] [PATCH 02/11] bcm2835_peripherals: move GPIO 'sdbus' property link from init() -> realize()

2017-12-14 Thread Alistair Francis
On Wed, Dec 13, 2017 at 12:44 PM, Philippe Mathieu-Daudé wrote: > We can then use dynamic sdbus creation (from realized HCI devices). > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- >

Re: [Qemu-devel] [PATCH 04/11] sdbus: add sdbus_create_bus() to replace qbus_create_inplace()

2017-12-14 Thread Alistair Francis
On Wed, Dec 13, 2017 at 12:44 PM, Philippe Mathieu-Daudé wrote: > A "bus-name" property can be use to change the default SDHCI "sd-bus" name. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/sd/sd.h | 1 + > include/hw/sd/sdhci.h|

Re: [Qemu-devel] [PATCH 05/11] sdbus: add sdbus_create_slave()

2017-12-14 Thread Alistair Francis
On Wed, Dec 13, 2017 at 12:44 PM, Philippe Mathieu-Daudé wrote: > The slave qdev is created connected to the parent SDBus. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/sd/sd.h | 2 ++ > hw/sd/core.c | 14 ++ > 2 files changed,

Re: [Qemu-devel] [PATCH 06/11] sdbus: rename SDCardClass -> SDSlaveClass

2017-12-14 Thread Alistair Francis
On Wed, Dec 13, 2017 at 12:44 PM, Philippe Mathieu-Daudé wrote: > By default a SD bus connect SD cards, however it may accept other SD devices > like a SDIO device. The current class is not restricted to a SD "Card" device. > To better reflect this is a SD bus slave, simply

Re: [Qemu-devel] [PATCH] vhost: fix crash on virtio_error while device stop

2017-12-14 Thread Maxime Coquelin
Hi Ilya, On 12/14/2017 08:06 AM, Ilya Maximets wrote: On 13.12.2017 22:48, Michael S. Tsirkin wrote: On Wed, Dec 13, 2017 at 04:45:20PM +0300, Ilya Maximets wrote: That looks very strange. Some of the functions gets 'old_status', others the 'new_status'. I'm a bit confused. OK, fair enough.

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/8] cputlb: Support generating CPU exceptions on memory transaction failures

2017-12-14 Thread Paolo Bonzini
On 13/12/2017 17:39, Peter Maydell wrote: > I was looking at a bug that involved stepping through this function, > and it turns out that the value in the variable "physaddr" here is > not in fact the physical address of the access. It's just the offset > into the memory region. > > This doesn't

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 10:06, Kevin Wolf wrote: > Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result >> in a 684 bytes payload. >> Since this command is intented for qtesting, this

Re: [Qemu-devel] [RFC PATCH 02/26] sdcard: add a Python qtest

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 00:20, Philippe Mathieu-Daudé wrote: > Use Python to write high-level SD commands. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/Makefile.include | 2 + > tests/sdcard_tests.py | 172 > + > 2 files

Re: [Qemu-devel] [PATCH] docs: update information for TLS certificate management

2017-12-14 Thread Thomas Huth
On 12.12.2017 15:17, Daniel P. Berrange wrote: > On Fri, Dec 08, 2017 at 10:16:50AM -0600, Eric Blake wrote: >> On 12/08/2017 05:58 AM, Daniel P. Berrange wrote: [...] >>> + >>> +@node tls_creds_setup >>> +@subsection TLS x509 credential configuration >>> + >>> +QEMU has a standard mechanism for

Re: [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed

2017-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2017 at 03:46:11PM -0500, John Snow wrote: > If users set an unreasonably low speed (like one byte per second), the > calculated delay may exceed many hours. While we like to punish users > for asking for stupid things, we do also like to allow users to correct > their wicked ways.

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-14 Thread Michal Privoznik
On 12/13/2017 10:21 PM, Paolo Bonzini wrote: > On 11/12/2017 13:14, Michal Privoznik wrote: qemu-system-x86_64 \ -boot menu=on,strict=on \ -device lsi,id=scsi0,bus=pci.0 \ -drive file=/var/lib/libvirt/images/fedora.qcow2,format=qcow2,if=none,id=drive-scsi0 \

Re: [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > They're all the same. If it actually becomes important to configure it, > it can become a job or driver property. > > Signed-off-by: John Snow > --- > block/backup.c | 1 - > block/commit.c | 2 -- >

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Kevin Wolf
Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: > Use Base64 to serialize the binary blobs in JSON. > So far at most 512 bytes will be transfered, which result > in a 684 bytes payload. > Since this command is intented for qtesting, this is acceptable. > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > qemu_coroutine_yield(); > +job->last_yield_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); This is not the time the job has yielded control, but the time the job has gotten it back. Is it intended? Thanks, Paolo

Re: [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > Instead of only sleeping for 0ms when we've hit a timeout, optionally > take a longer more explicit delay_ns that always forces the sleep. > > Signed-off-by: John Snow > --- > block/mirror.c | 4 ++-- > blockjob.c

Re: [Qemu-devel] [PATCH 5/7] block/commit: use block_job_throttle

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > Depending on the value of `speed` and how fast our backends are, > delay_ns might be 0 very, very often. This creates some warning > messages that spook users, but it's also pretty inefficient. > > Use block_job_throttle instead to yield a little more

Re: [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > + * Yield if it has been SLICE_TIME nanoseconds since the last yield. > + * Otherwise, check if we need to pause (and update the yield counter). What is the yield counter? Thanks, Paolo

Re: [Qemu-devel] [PATCH 7/7] block/backup: use block_job_throttle

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > Signed-off-by: John Snow > --- > block/backup.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/block/backup.c b/block/backup.c > index d71b25c017..a5ede5f643 100644 > --- a/block/backup.c > +++

Re: [Qemu-devel] [PATCH 6/7] block/stream: use block_job_throttle

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 01:59, John Snow wrote: > Signed-off-by: John Snow > --- > block/stream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/stream.c b/block/stream.c > index e85af18c54..3ad3190387 100644 > --- a/block/stream.c > +++ b/block/stream.c

Re: [Qemu-devel] [PATCH 0/6] QTests: use Python to run complex tests

2017-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2017 at 06:35:51PM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > With this series we can now write tests using Python rather than C. > For complex tests this can reduce the test development time, we can focus on > the test purposes instead of his implementation details. > > -

[Qemu-devel] [PATCH 3/4] virtio-scsi: Implement 'native LUN' feature

2017-12-14 Thread Hannes Reinecke
The 'native LUN' feature allows virtio-scsi to use the LUN numbers from the underlying storage directly, without having to modify the LUN number when sending over the wire. It works by shifting the existing LUN number down by 8 bytes, and add the virtio-specific 8-byte LUN steering header. With

[Qemu-devel] [PATCH 0/4] virtio-vfc implementation

2017-12-14 Thread Hannes Reinecke
Hi all, here's my attempt to implement a 'Virtual FC' emulation for virtio-scsi, based on the presentation at the KVM Forum in Prague. This doesn't so much implement the FC protocol per se, but rather enables virtio to pass in addition port information so that the guest can setup the FC

Re: [Qemu-devel] [PATCH v2 for-2.12] hmp-commands: Remove the deprecated usb_add and usb_del

2017-12-14 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > It's easy to use device_add and device_del as replacement instead. > The usb_add and usb_del commands are deprecated since QEMU 2.10, > and nobody complained that they are still needed, so let's get rid > of them now to make the HMP interface a little bit

Re: [Qemu-devel] [PATCH 0/2] Don't abort on writes to ROMs

2017-12-14 Thread Paolo Bonzini
On 13/12/2017 18:52, Peter Maydell wrote: > Currently we set up the io_mem_rom special memory region using the > unassigned_mem_ops structure; this is then used when a guest tries to > write to ROM. This is incorrect, because the behaviour of unassigned > memory may be different from that of ROM

Re: [Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped"

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:51PM +0800, Peter Xu wrote: > +## > +# @RequestDropReason: > +# > +# Reasons that caused one command to be dropped. > +# > +# @queue-full: the queue of request is full. Please add: This can only occur when the client sends a new non-oob command before the

Re: [Qemu-devel] [PATCH 0/6] QTests: use Python to run complex tests

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 10:39, Stefan Hajnoczi wrote: >> # verify Card ID >> data = self.bus.do_cmd(ALL_SEND_CID) >> oid, pnm, psn = struct.unpack(">x2s5sxLxxx", data) >> self.assertEqual(oid, "XY") # QEMU default >> self.assertEqual(pnm, "QEMU!")

[Qemu-devel] [PATCH 2/4] virtio-scsi: implement target rescan

2017-12-14 Thread Hannes Reinecke
Implement a new virtio-scsi command 'rescan' to return a list of attached targets. The guest is required to set the 'next_id' field to the next expected target id; the host will return either that or the next higher target id (if present), or -1 if no additional targets are found. Signed-off-by:

[Qemu-devel] [PATCH 4/4] scsi: support REPORT_LUNS for LUNs != 0

2017-12-14 Thread Hannes Reinecke
SPC doesn't restrict the use of REPORT LUNS to LUN 0, so we shouldn't be doing so, either. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index

Re: [Qemu-devel] [PATCH 4/4] tests: test-hmp: print command execution result

2017-12-14 Thread Dr. David Alan Gilbert
* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > Provide HMP monitor command execution result as it would be seen > by user who established an HMP monitor session. > > Currently many commands may silently fail without any sign of that. > This patch let this info to be printed once test

Re: [Qemu-devel] [RFC v5 0/2] virtio: introduce `info virtio' hmp command

2017-12-14 Thread Cornelia Huck
On Tue, 12 Dec 2017 16:54:50 +0300 Jan Dakinevich wrote: > I am going to reanimate works under this QMP/HMP. First of all, it > could be meaningful to settle what output would provide the QMP. I would > like to suggest the following description: > > ## > #

Re: [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all()

2017-12-14 Thread Stefan Hajnoczi
On Thu, Dec 07, 2017 at 08:13:14PM +, Stefan Hajnoczi wrote: > v2: > * Added docs/devel/multiple-iothreads.txt doc update [Kevin] > * Added qemu-iotests 203 test case [Kevin] > * Added iothread_stop() race fix to make 203 reliable > > Patch 1 is Paolo's recursive locking removal in

Re: [Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped"

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:51PM +0800, Peter Xu wrote: > +## > +# @RequestDropReason: > +# > +# Reasons that caused one command to be dropped. > +# > +# @queue-full: the queue of request is full. > +# > +# Since: 2.12 > +## > +{ 'enum': 'RequestDropReason', qapi-schema.json calls them

Re: [Qemu-devel] [PATCH] docs: Convert migration.txt to rst

2017-12-14 Thread Kashyap Chamarthy
On Wed, Dec 13, 2017 at 08:11:46PM +, Dr. David Alan Gilbert wrote: > * Kashyap Chamarthy (kcham...@redhat.com) wrote: > > On Tue, Dec 12, 2017 at 01:56:00PM +, Dr. David Alan Gilbert (git) > > wrote: [...] > > A good chunk of changes I suggest are pre-existing, so take it with a > >

<    1   2   3   4   5   >