[Qemu-devel] [PATCHv3 14/16] apb: replace OBIO interrupt numbers in pci_pbmA_map_irq() with constants

Following on from the previous commit, we can also do the same with with legacy OBIO interrupts in pci_pbmA_map_irq(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCHv3 11/16] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B

After the previous refactoring it is now possible to use separate functions to improve the clarity of the interrupt paths. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/apb.c | 45 - 1 file changed, 20 insertions(+),

Re: [Qemu-devel] STOP Re: [PULL 4/4] qmp: add nbd-server-remove

look at "[PATCH v2 0/6] nbd export qmp interface" 21.12.2017 12:07, Vladimir Sementsov-Ogievskiy wrote: no, I've updated it, we discussed with Kevin that this approach is bad 21.12.2017 04:36, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Add command for

Re: [Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

On 21/12/2017 01:51, Gonglei (Arei) wrote: > Sorry, Michael. This makes me confused. Because the Qemu part about > vhost-user crypto > doesn't do this assumption. The main controversial point is whether session > operations > should be added in the vhost-user protocol, raised by Paolo. And we

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 12/21/2017 01:12 AM, Benjamin Herrenschmidt wrote: > On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: >> >> As you've suggested in yourself, I think we might need to more >> explicitly model the different components of the XIVE system. As part >> of that, I think you need to be clearer

Re: [Qemu-devel] [PATCH] target/m68k: add monitor.c

On 21.12.2017 08:56, Laurent Vivier wrote: > Le 20/12/2017 à 22:22, Thomas Huth a écrit : >> Am Wed, 20 Dec 2017 21:35:28 +0100 >> schrieb Laurent Vivier : >> >>> This allows to use registers content in the monitor. >>> >>> Example: >>> >>> BEFORE: >>> (qemu) print $d0 >>>

[Qemu-devel] [PATCHv3 04/16] sun4u: remove pci_ebus_init() function

This is initialisation that should really take place in the ebus realize function. As part of this we also rework the ebus IRQ mapping so that instead of having to pass in the array of pbm_irqs, we obtain a reference to them by looking up the APB device during ebus realize. Signed-off-by: Mark

[Qemu-devel] [PATCHv3 00/16] sun4u: tidy-up CPU, APB and ebus

This patchset for 2.12 continues with tidying up the sun4u CPU, APB and ebus devices by encapsulating the ebus ISA bus within the ebus QOM device, allowing APB and ebus devices to be instantiated directly via QOM, and formally wiring up the device IRQs using qdev GPIOs rather than passing around

[Qemu-devel] [PATCHv3 03/16] sun4u: move ISABus inside of EBusState

Since the EBus is effectively a PCI-ISA bridge then the underlying ISA bus should be contained within the PCI bridge itself. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCHv3 06/16] apb: APB QOMify tidy-up

Use DeviceClass rather than SysBusDeviceClass in pbm_host_class_init() and adjust pci_pbm_init_device() accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/apb.c | 17 - 1 file changed,

[Qemu-devel] [PULL 41/41] chardev: convert the socket server to QIONetListener

From: "Daniel P. Berrange" Instead of creating a QIOChannelSocket directly for the chardev server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Signed-off-by: Daniel

[Qemu-devel] [PULL v2 00/41] First batch of misc patches for QEMU 2.12

The following changes since commit 200780a3a3ed067dfb2e0d2210b0ed09e748ba26: Merge remote-tracking branch 'remotes/armbru/tags/pull-cmdline-2017-12-18-v2' into staging (2017-12-20 13:20:48 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [PATCH v2] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

Le 21/12/2017 à 09:26, Mark Cave-Ayland a écrit : > On 20/12/17 12:14, Laurent Vivier wrote: > >> It makes the code clearer to separate the bus implementation >> from the devices one. >> >> Replace ADB_DPRINTF() with trace events (and adding new ones in >> adb-kbd.c). >> Some minor changes to

[Qemu-devel] [PATCH v2] target/m68k: add monitor.c

This allows to use registers content in the monitor. Example: BEFORE: (qemu) print $d0 unknown register AFTER: (qemu) print $d0 0 (qemu) print $sr 0x2000 (qemu) x/10i $pc 0x40010a2a: movew %sr,%d0 0x40010a2c: oril #1792,%d0 0x40010a32: movew %d0,%sr 0x40010a34: movel

[Qemu-devel] [PULL v2 00/19] Initial support for Hypervisor.framework

The following changes since commit 200780a3a3ed067dfb2e0d2210b0ed09e748ba26: Merge remote-tracking branch 'remotes/armbru/tags/pull-cmdline-2017-12-18-v2' into staging (2017-12-20 13:20:48 +) are available in the Git repository at: git://github.com/bonzini/qemu.git

[Qemu-devel] STOP Re: [PULL 4/4] qmp: add nbd-server-remove

no, I've updated it, we discussed with Kevin that this approach is bad 21.12.2017 04:36, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Add command for export removing. It is needed for cases when we don't want to keep export after the operation on it was

Re: [Qemu-devel] [PULL 00/14] ppc-for-2.12 queue 20171219

On Thu, Dec 21, 2017 at 12:45:50AM +1100, David Gibson wrote: > On Wed, Dec 20, 2017 at 11:29:36AM +, Peter Maydell wrote: > > On 19 December 2017 at 04:29, David Gibson > > wrote: > > > The following changes since commit > > >

Re: [Qemu-devel] [PATCH v2] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

On 20/12/17 12:14, Laurent Vivier wrote: It makes the code clearer to separate the bus implementation from the devices one. Replace ADB_DPRINTF() with trace events (and adding new ones in adb-kbd.c). Some minor changes to make checkpatch.pl happy. Signed-off-by: Laurent Vivier

[Qemu-devel] [PATCHv3 12/16] apb: remove busA property from PBMPCIBridge state

Since the previous commit the only remaining use of the qdev busA property is to configure the PCI bridge in front of the onboard ebus devices differently to allow early OpenBIOS serial console access. Instead we can now manually update the PCI configuration for bridge A in pci_pbm_reset() and

[Qemu-devel] [PATCHv3 01/16] apb: move QOM macros and typedefs from apb.c to apb.h

This also includes the related IOMMUState typedef and defines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/apb.c | 85

[Qemu-devel] [PATCHv3 16/16] sun4u: switch from EBUS_DPRINTF() macro to trace-events

Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/sparc64/sun4u.c | 12 ++-- hw/sparc64/trace-events | 3 +++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/sparc64/sun4u.c

[Qemu-devel] [PULL 02/41] qemu-thread: fix races on threads that exit very quickly

From: linzhecheng If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault with low probability. The backtrace is: #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f46c602a8c8 in

[Qemu-devel] [PATCHv3 09/16] apb: move the two secondary PCI bridges objects into APBState

This enables us to remove these parameters from pci_apb_init(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/apb.c | 14 +-

[Qemu-devel] [PATCHv3 08/16] apb: use gpios to wire up the apb device to the SPARC CPU IRQs

Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/apb.c | 6 ++ hw/sparc64/sparc64.c | 2 ++ hw/sparc64/sun4u.c | 12 include/hw/pci-host/apb.h | 6 --

[Qemu-devel] [PATCHv3 05/16] sun4u: move initialisation of all ISABus devices into ebus_realize()

This belongs in the PCI-ISA bridge rather than at the machine level. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/sparc64/sun4u.c | 78 -- 1 file changed, 46

[Qemu-devel] [PATCHv3 07/16] apb: return APBState from pci_apb_init() rather than PCIBus

This is a first step towards removing pci_apb_init() completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/apb.c | 8 hw/sparc64/sun4u.c| 6 -- include/hw/pci-host/apb.h | 6

[Qemu-devel] [PATCHv3 10/16] apb: remove pci_apb_init() and instantiate APB device using qdev

By making the special_base and mem_base values qdev properties, we can move the remaining parts of pci_apb_init() into the pbm init() and realize() functions. This finally allows us to instantiate the APB directly using standard qdev create/init functions in sun4u.c. Signed-off-by: Mark

[Qemu-devel] [PATCHv3 13/16] ebus: wire up OBIO interrupts to APB pbm via qdev GPIOs

This enables us to remove the static array mapping in the ISA IRQ handler (and the embedded reference to the APB device) by formalising the interrupt wiring via the qdev GPIO API. For more clarity we replace the APB OBIO interrupt numbers with constants designating the interrupt source, and

[Qemu-devel] [PATCHv3 02/16] sun4u: ebus QOMify tidy-up

The main change here is to introduce the proper TYPE_EBUS/EBUS QOM macros and remove the use of DO_UPCAST. Alongside this there are some a couple of minor cosmetic changes and a rename of pci_ebus_realize() to ebus_realize() since the ebus device is always what is effectively a PCI-ISA bridge.

[Qemu-devel] [PATCHv3 15/16] sparc64: introduce trace-events for hw/sparc64

This is in preparation for switching code in hw/sparc64 from DPRINTF over to trace events. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- Makefile.objs | 1 +

[Qemu-devel] [PULL 37/41] chardev: fix backend events regression with mux chardev

From: Marc-André Lureau Kirill noticied that on recent versions on QEMU he was not able to trigger SysRq to invoke debug capabilites of Linux Kernel. He tracked it down to qemu_chr_be_event() ignoring CHR_EVENT_BREAK due s->be being NULL. The bug was introduced in

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

On Wed, Dec 20, 2017 at 10:18:16PM +1100, David Gibson wrote: > On Wed, Dec 20, 2017 at 02:47:30PM +0800, Liu, Yi L wrote: > > On Mon, Dec 18, 2017 at 10:35:31PM +1100, David Gibson wrote: > > > On Wed, Nov 15, 2017 at 03:16:32PM +0800, Peter Xu wrote: > > > > On Tue, Nov 14, 2017 at 10:52:54PM

Re: [Qemu-devel] [PATCH v3 2/7] linux-user: Add separate aarch64_be uname

Le 20/12/2017 à 22:23, Michael Weiser a écrit : > Make big-endian aarch64 systems identify as aarch64_be as expected by > big-endian userland and toolchains. > > Signed-off-by: Michael Weiser > Reviewed-by: Richard Henderson > --- >

Re: [Qemu-devel] [PATCHv3 16/16] sun4u: switch from EBUS_DPRINTF() macro to trace-events

On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/sparc64/sun4u.c

Re: [Qemu-devel] [PATCHv3 05/16] sun4u: move initialisation of all ISABus devices into ebus_realize()

On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland wrote: > This belongs in the PCI-ISA bridge rather than at the machine level. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[Qemu-devel] [PATCH] char: don't silently skip tn3270 protocol init when TLS is enabled

Even if common tn3270 implementations do not support TLS, it is trivial to have them proxied over a proxy like stunnel which adds TLS at the sockets layer. We should thus not silently skip tn3270 protocol initialization when TLS is enabled. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

On Thu, Dec 21, 2017 at 10:49:44AM +0800, Wei Wang wrote: > On 12/21/2017 01:10 AM, Matthew Wilcox wrote: > One more question is about the return value, why would it be ambiguous? I > think it is the same as find_next_bit() which returns the found bit or size > if not found. Because find_next_bit

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

On Tue, 12/19 16:45, Peter Xu wrote: > For each Monitor, add one field "use_io_thr" to show whether it will be > using the dedicated monitor IO thread to handle input/output. When set, > monitor IO parsing work will be offloaded to dedicated monitor IO > thread, rather than the original main loop

Re: [Qemu-devel] [PATCH v3 5/7] linux-user: Add aarch64_be magic numbers to qemu-binfmt-conf.sh

Le 20/12/2017 à 22:23, Michael Weiser a écrit : > As we now have a linux-user aarch64_be target, we can add it to the list > of supported targets in qemu-binfmt-conf.sh > > Signed-off-by: Michael Weiser > --- > scripts/qemu-binfmt-conf.sh | 6 +- > 1 file changed, 5

Re: [Qemu-devel] [RFC v6 12/27] qmp: negotiate QMP capabilities

On Tue, 12/19 16:45, Peter Xu wrote: > After this patch, we will allow QMP clients to enable QMP capabilities > when sending the first "qmp_capabilities" command. Originally we are > starting QMP session with no arguments like: > > { "execute": "qmp_capabilities" } > > Now we can enable some

Re: [Qemu-devel] [PATCH v3 4/7] configure: Add aarch64_be-linux-user target

Le 20/12/2017 à 22:23, Michael Weiser a écrit : > Add target aarch64_be-linux-user. This allows a qemu-aarch64_be binary > to be built that will run big-endian aarch64 binaries. > > Signed-off-by: Michael Weiser > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v3 6/7] linux-user: Separate binfmt arm CPU families

Le 20/12/2017 à 22:23, Michael Weiser a écrit : > Give big-endian arm and aarch64 CPUs their own family in > qemu-binfmt-conf.sh to make sure we register qemu-user for binaries of > the opposite endianness on arm and aarch64. Apart from the family > assignments of the magic vales,

Re: [Qemu-devel] [PATCHv3 11/16] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B

On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland wrote: > After the previous refactoring it is now possible to use separate functions > to improve the clarity of the interrupt paths. > > Signed-off-by: Mark Cave-Ayland Reviewed-by:

Re: [Qemu-devel] [RFC v6 17/27] qmp: add new event "command-dropped"

On Tue, 12/19 16:45, Peter Xu wrote: > This event will be emitted if one QMP command is dropped. Along, > declare an enum for the reasons. > > Signed-off-by: Peter Xu Reviewed-by: Fam Zheng

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

On Tue, 12/19 16:45, Peter Xu wrote: > Set maximum QMP command queue length to 8. If queue full, instead of > queue the command, we directly return a "command-dropped" event, telling > client that specific command is dropped. > > Note that this flow control mechanism is only valid if OOB is

Re: [Qemu-devel] [RFC v6 20/27] qmp: export qmp_dispatch_check_obj and allow "id"

On Tue, 12/19 16:45, Peter Xu wrote: > We need this for earlier check for OOB, before reaching > do_qmp_dispatch(). Meanwhile, a small touch-up to allow "id" field, > after all we allow that for sure in the spec (in any form). > > Signed-off-by: Peter Xu Reviewed-by: Fam

[Qemu-devel] ping Re: [PATCH v2 0/6] nbd export qmp interface

Hi, what about this? 07.12.2017 18:50, Vladimir Sementsov-Ogievskiy wrote: Here: 1. separate export name from device name 1.1 several exports per device possible 2. add nbd-server-remove v2: 01: add r-bs by Max and Eric, add comment to code (hope you don't mind) 03: address

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

On Tue, 12/19 16:45, Peter Xu wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute":

Re: [Qemu-devel] [RFC v6 19/27] qapi: introduce new cmd option "allow-oob"

On Tue, 12/19 16:45, Peter Xu wrote: > Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means > the command allows out-of-band execution. > > The "oob" idea is proposed by Markus Armbruster in following thread: > >

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

On Tue, 12/19 16:45, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index 4b2bee773f..81fb0a42b4 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -3943,12 +3943,18 @@ void monitor_resume(Monitor *mon) > > static QObject *get_qmp_greeting(void) > { > +QList *cap_list = qlist_new(); >

Re: [Qemu-devel] [PATCH v7 1/4] vhost-user: add new vhost user messages to support virtio config space

Hi On Thu, Dec 21, 2017 at 1:21 AM, Michael S. Tsirkin wrote: > On Wed, Dec 20, 2017 at 04:47:13PM +0100, Marc-André Lureau wrote: >> Hi >> >> On Wed, Dec 13, 2017 at 3:29 AM, Changpeng Liu >> wrote: >> > Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG

Re: [Qemu-devel] vhost-user graceful connect/disconnect

Hi - Original Message - > Hi, > Vhost-user implementations assume the slave is already running before > the master starts. The slave is required during virtio device > initialization (e.g. feature bit negotiation) and so it is simplest to > assume that the master is already available and

Re: [Qemu-devel] [RFC v6 15/27] monitor: let suspend/resume work even with QMPs

On Tue, 12/19 16:45, Peter Xu wrote: > One thing to mention is that for QMPs that are using IOThreads, we need > an explicit kick for the IOThread in case it is sleeping. > > Since at it, add traces for the operations. > > Signed-off-by: Peter Xu > --- > monitor.c| 26

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 12/21/2017 10:16 AM, Cédric Le Goater wrote: > On 12/21/2017 01:12 AM, Benjamin Herrenschmidt wrote: >> On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: >>> >>> As you've suggested in yourself, I think we might need to more >>> explicitly model the different components of the XIVE system.

Re: [Qemu-devel] [PATCHv3 08/16] apb: use gpios to wire up the apb device to the SPARC CPU IRQs

On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/pci-host/apb.c

Re: [Qemu-devel] [PATCHv3 07/16] apb: return APBState from pci_apb_init() rather than PCIBus

On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland wrote: > This is a first step towards removing pci_apb_init() completely. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. If we use the old value, it will assert. qemu-kvm: hw/acpi/bios-linker-loader.c:214: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len'

Re: [Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, December 21, 2017 10:25 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangweidong (C); > stefa...@redhat.com; Zhoujian (jay); pa...@linux.vnet.ibm.com; longpeng; >

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

On 22/12/2017 0:30, Yuval Shaia wrote: On Thu, Dec 21, 2017 at 10:46:35PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: On 21/12/2017 16:22, Michael S. Tsirkin wrote: On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: What

[Qemu-devel] [RFC 1/3] vhost-user: support receiving file descriptors in slave_read

Signed-off-by: Tiwei Bie --- hw/virtio/vhost-user.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 093675ed98..e7108138fd 100644 --- a/hw/virtio/vhost-user.c

[Qemu-devel] [RFC 2/3] vhost-user: introduce shared vhost-user state

When multi-queue is enabled for virtio-net, each virtio queue pair will have a vhost_dev, and the only thing they share currently is the chardev. This patch introduces a vhost-user state structure which will be shared by all virtio queue pairs of the same virtio device. Signed-off-by: Tiwei Bie

[Qemu-devel] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

This RFC patch set does some small extensions to vhost-user protocol to support VFIO based accelerators, and makes it possible to get the similar performance of VFIO passthru while keeping the virtio device emulation in QEMU. When we have virtio ring compatible devices, it's possible to setup the

[Qemu-devel] [RFC 3/3] vhost-user: add VFIO based accelerators support

Signed-off-by: Tiwei Bie --- docs/interop/vhost-user.txt| 57 ++ hw/vfio/common.c | 2 +- hw/virtio/vhost-user.c | 381 - hw/virtio/vhost.c | 3 +- hw/virtio/virtio-pci.c | 8 -

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

On Wed, Dec 20, 2017 at 10:01:10PM +1100, David Gibson wrote: > On Wed, Dec 20, 2017 at 02:32:42PM +0800, Liu, Yi L wrote: > > On Mon, Dec 18, 2017 at 10:22:18PM +1100, David Gibson wrote: > > > On Mon, Dec 18, 2017 at 05:17:35PM +0800, Liu, Yi L wrote: > > > > On Mon, Dec 18, 2017 at 05:14:42PM

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

Eric Blake writes: > On 12/19/2017 08:20 AM, Max Reitz wrote: > >> So there are three things: >> >> (1) We probably should not allow snapshot names that could be IDs. >> Easiest way to solve this: Names have to start with a non-digit. > > Yes, that would be a nice change. It

Re: [Qemu-devel] [PATCH] target/ppc: more use of the PPC_*() macros

On 12/22/2017 01:39 AM, David Gibson wrote: > On Thu, Dec 21, 2017 at 05:54:56PM +0100, Cédric Le Goater wrote: >> Also introduce utilities to manipulate bitmasks (originaly from OPAL) >> which be will be used in the model of the XIVE interrupt controller. >> >> Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

ping http://patchwork.ozlabs.org/patch/849786/ 2017-12-18 14:00 GMT+09:00 Hikaru Nishida : > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert()

Re: [Qemu-devel] [PATCH] file-posix: refuse to open directories

On 12/21/2017 05:56 PM, no-re...@patchew.org wrote: > /tmp/qemu-test/src/hw/i386/vmport.c: In function 'vmport_ioport_read': > /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: implicit declaration of > function 'qemu_log_mask' [-Werror=implicit-function-declaration] >

Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

>> Fixes: 7299e1a411 >>("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP") >> Signed-off-by: Laurent Vivier > > Looks to me like it'll be a bug for anything not configured > using the 'log' trace backend, rather than win32 specific. Sorry my bad, it

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On Thu, 2017-12-21 at 10:16 +0100, Cédric Le Goater wrote: > On 12/21/2017 01:12 AM, Benjamin Herrenschmidt wrote: > > On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: > > > > > > As you've suggested in yourself, I think we might need to more > > > explicitly model the different components

Re: [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions

On 2017年12月20日 16:58, Mark Cave-Ayland wrote: Series looks good to me. A small question is that, is this better to keep compute_mcast_idx()? Thanks Hi Jason, I did think about this, however at the very minimum you'd need big-endian and little-endian variants of compute_mcast_idx(), and

Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

On 12/21/2017 06:11 PM, Jack Schwartz wrote: BLOCK_IO_ERROR events currently contain a "reason" string which is strerror(errno) of the error. This enhancement provides those events with the numeric errno value as well, since it is easier to parse for error type than a string. NACK. Numeric

[Qemu-devel] [PULL 09/18] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx()

From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang

[Qemu-devel] [PULL 06/18] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32()

From: Mark Cave-Ayland Instead of e100_compute_mcast_idx() using its own implementation, we can simply call net_crc32() directly and apply the bit shift inline. Signed-off-by: Mark Cave-Ayland Reviewed-by: Stefan Weil

[Qemu-devel] [PULL 00/18] Net patches

The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b: hw/i386/vmport: fix missing definitions with non-log trace backends (2017-12-21 22:52:28 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch

[Qemu-devel] [PULL 15/18] net: remove unused compute_mcast_idx() function

From: Mark Cave-Ayland Now that all of the callers have been converted to compute the multicast index inline using new net CRC functions, this function can now be dropped. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang

[Qemu-devel] qemu 2.9.0 qcow2 file failed to open after hard server reset

Hi! Today my server have forced reboot and one of my vm can't start with message: qcow2: Marking image as corrupt: L2 table offset 0x3f786d6c207600 unaligned (L1 index: 0); further corruption events will be suppressed i'm use debian jessie with hand builded qemu 2.9.0, i'm try to qemu-img check

Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

On 21 December 2017 at 21:11, Laurent Vivier wrote: > When compiled with x86_64-w64-mingw32, we have: > >error: implicit declaration of function 'qemu_log_mask' >error: 'LOG_UNIMP' undeclared (first use in this function) > > This patch adds the missing include. > >

Re: [Qemu-devel] qemu 2.9.0 qcow2 file failed to open after hard server reset

On 12/21/2017 05:13 PM, Vasiliy Tolstov wrote: > Hi! Today my server have forced reboot and one of my vm can't start > with message: > qcow2: Marking image as corrupt: L2 table offset 0x3f786d6c207600 > unaligned (L1 index: 0); further corruption events will be suppressed > > i'm use debian

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

Hi Peter, Michael, On Thu, Dec 21, 2017 at 5:37 PM, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 08:26:47PM +, Peter Maydell wrote: >> On 21 December 2017 at 14:27, Michael S. Tsirkin wrote: >> > The following changes since commit >> >

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

>> > Done and pushed - I dropped the conflicting patch. >> >> Have you also dropped the other one Philippe says depends on it? Now than I could take time to check, dropping this single patch was correct and inoffensive, since conflicting patch from Mao Zhongyi is doing exactly the same change

[Qemu-devel] [PULL 12/18] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx()

From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang

[Qemu-devel] [PULL 14/18] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx()

From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang

[Qemu-devel] [PATCH] file-posix: refuse to open directories

I don't think there's a legitimate reason to open directories as if they were files. This prevents QEMU from opening and attempting to probe a directory inode, which can break in exciting ways. One of those ways is lseek on ext4/xfs, which will return 0x7fff as the file size instead of

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

On Thu, Dec 21, 2017 at 11:05:01PM +, Peter Maydell wrote: > On 21 December 2017 at 20:37, Michael S. Tsirkin wrote: > > Done and pushed - I dropped the conflicting patch. > > Have you also dropped the other one Philippe says depends on it? > > thanks > -- PMM I did now

[Qemu-devel] [Bug 1728635] Re: qemu-io crashes with SIGSEGV when did -c aio_write 9233408 28160 on a image_fuzzer image

I can't reproduce this on commit a93ece47fd9edbd4558db24300056c9a57d3bcd4: # ./qemu-io copy.img -c "aio_write 9233408 28160" can't open device copy.img: Could not open backing file: Could not open 'backing_img.file': No such file or directory and on the latest commit, I get a different error

Re: [Qemu-devel] [PATCH] target/ppc: more use of the PPC_*() macros

On Thu, Dec 21, 2017 at 05:54:56PM +0100, Cédric Le Goater wrote: > Also introduce utilities to manipulate bitmasks (originaly from OPAL) > which be will be used in the model of the XIVE interrupt controller. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-2.12, thanks.

Re: [Qemu-devel] [PATCH 0/3] net: Remove "-net channel" and update "-net nic" docs

On 2017年12月19日 23:28, Thomas Huth wrote: Remove the deprecated (and even undocumented) "-net channel" parameter, and update our docs with regards to the possibility to use "netdev=..." together with the "-net nic" option for embedded NICs. Thomas Huth (3): net: Remove the legacy "-net

[Qemu-devel] [PULL 17/18] qemu-doc: The "-net nic" option can be used with "netdev=...", too

From: Thomas Huth Looks like we missed to document that it is also possible to specify a netdev with "-net nic" - which is very useful if you want to configure your on-board NIC to use a backend that has been specified with "-netdev". Signed-off-by: Thomas Huth

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

In the termbin: So the "good" one is on the left, and the "bad" one is on the right. The bad one is ... completely blank for the first 200+ MB? That's not great. so: .bin.apfs: broken raw file, made on apfs, no arguments(?) .bin.apfs2: broken raw file, made on apfs, `-S 0` ? .img.org: qcow2 file

Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes

On 12/07/2017 03:30 PM, miny...@acm.org wrote: These are some fixes I've had for a while (mostly). They are small fixes and additions for various things. It would be nice to be able to get at least some of these into the upcoming release, but it's probably too late. I also add myself as the

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

On 12/19/2017 08:20 AM, Max Reitz wrote: So there are three things: (1) We probably should not allow snapshot names that could be IDs. Easiest way to solve this: Names have to start with a non-digit. Yes, that would be a nice change. It is not strictly backwards compatible (so we'd still

Re: [Qemu-devel] [PATCH] file-posix: refuse to open directories

On 12/21/2017 04:44 PM, John Snow wrote: I don't think there's a legitimate reason to open directories as if they were files. This prevents QEMU from opening and attempting to probe a directory inode, which can break in exciting ways. One of those ways is lseek on ext4/xfs, which will return

[Qemu-devel] [PULL 03/18] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function

From: Mark Cave-Ayland Separate out the standard ethernet CRC32 calculation into a new net_crc32() function, renaming the constant POLYNOMIAL to POLYNOMIAL_BE to make it clear that this is a big-endian CRC32 calculation. As part of the constant rename, remove the

[Qemu-devel] [PULL 10/18] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx()

From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

On Thu, Dec 21, 2017 at 10:46:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: > > On 21/12/2017 16:22, Michael S. Tsirkin wrote: > > > On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: > > > > > > > > > > > > > What happens if

Re: [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up

On Thu, Dec 21, 2017 at 10:21:20PM +0100, Maxime Coquelin wrote: > Sorry, I missed to fixup the feature mask in patch 4, > this is the only change in this v3. > > The two changes in v2 are fixing the features mask > before the function rework, and reword of commit message > of patch

[Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

BLOCK_IO_ERROR events currently contain a "reason" string which is strerror(errno) of the error. This enhancement provides those events with the numeric errno value as well, since it is easier to parse for error type than a string. Signed-off-by: Jack Schwartz

[Qemu-devel] [PATCH v1 0/1] block: Add numeric errno field to BLOCK_IO_ERROR events

Currently, BLOCK_IO_ERROR events have a string error "reason" field which is derived from errno. The proposed change adds errno itself as a field to these events. Figuring out the error by comparing the (int) errno itself is easier than comparing a string. There is also a comment in the code

[Qemu-devel] [PULL 02/18] e1000: Separate TSO and non-TSO contexts, fixing UDP TX corruption

From: Ed Swierk via Qemu-devel The device is supposed to maintain two distinct contexts for transmit offloads: one has parameters for both segmentation and checksum offload, the other only for checksum offload. The guest driver can send two context descriptors, one for

  1   2   3   4   >