v2: Add Eric's r-b lines after making suggested tweaks to commit logs and error
messages.
Management and users are accustomed to "qemu-img info" to query status of
images even when they are used by guests. Since image locking was added, the -U
(--force-share) option is needed for that to work.
The error message we had didn't have a hint about "-U" when locking the
image failed, which is not friendly. Also it is imaginable that the
reaction to that error by the user would be a retry with '-U'.
So the reason we require "-U" for "qemu-img info" if the image is used
is to raise the awarenes
In the next patch one caller will have a special error handling logic
rather than reporting it. Add "Error **" parameters to functions and
give control back to callers, to make that possible.
Update iotests output accordingly.
Reviewed-by: Eric Blake
Signed-off-by: Fam Zheng
---
qemu-img.c
On Fri, 01/05 16:57, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the parallels driver accordingly. Note that
> the internal function block_status() is still sector-based, because
> it is still in use by other sector-based functions;
On Fri, 5 Jan 2018 17:22:31 -0800 (PST)
no-re...@patchew.org wrote:
> CC hw/acpi/bios-linker-loader.o
> In file included from /tmp/qemu-test/src/fsdev/qemu-fsdev.h:17,
> from /tmp/qemu-test/src/fsdev/qemu-fsdev-dummy.c:15:
> /tmp/qemu-test/src/fsdev/file-op-9p.h:98: error:
On Fri, 01/05 16:57, Eric Blake wrote:
> We are gradually converting to byte-based interfaces, as they are
> easier to reason about than sector-based. Convert all uses of
> the allocmap (no semantic change). Callers that already had bytes
> available are simpler, and callers that now scale to byt
On Fri, 01/05 16:57, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the iscsi driver accordingly. In this case,
> it is handy to teach iscsi_co_block_status() to handle a NULL map
> and file parameter, even though the block layer passes
On Fri, 01/05 16:57, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the vpc driver accordingly.
>
> Signed-off-by: Eric Blake
> Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam Zheng
> -Original Message-
> From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org]
> On Behalf Of Jason Wang
> Sent: Monday, January 8, 2018 11:24 AM
> To: Liang, Cunming ; Bie, Tiwei
>
> Cc: Tan, Jianfeng ; virtio-...@lists.oasis-open.org;
> m...@redhat.com; Daly, Dan
Greg Kurz writes:
> Aneesh has been working on other topics for some time now. Let's reflect
> that in the MAINTAINERS file, so that people stop Cc'ing him.
>
> Signed-off-by: Greg Kurz
Acked-by: Aneesh Kumar K.V
> ---
> MAINTAINERS |2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
On Wed, 03 Jan 2018 15:17:49 +0100
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > As were suggested at (1) and at bof session where we discussed subj,
> > I'm posting variant with late numa 'configuration' i.e. when QEMU is
> > started with '-S' option in paused state and numa is config
Greg Kurz writes:
> This backend raise some concerns:
>
> - doesn't support symlinks
> - fails +100 tests in the PJD POSIX file system test suite [1]
> - requires the QEMU process to run with the CAP_DAC_READ_SEARCH
> capability, which isn't recommended for security reasons
>
> For all these re
On 03/01/18 11:09, David Gibson wrote:
> On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote:
>> On 11/12/17 17:20, Alexey Kardashevskiy wrote:
>>> On 09/11/17 17:38, David Gibson wrote:
On Tue, Nov 07, 2017 at 06:14:04PM +1100, Alexey Kardashevskiy wrote:
> On 20/10/17 11
Stefano, ping ?
On Wed, 20 Dec 2017 13:59:41 +0100
Greg Kurz wrote:
> On Mon, 18 Dec 2017 11:41:23 +0100
> Greg Kurz wrote:
>
> > The 9p protocol mostly relies on a request/reply dialog between the
> > client and the server. A notable exception to this rule is request
> > cancellation (ie, flu
On 21 December 2017 at 23:43, Michael S. Tsirkin wrote:
>> you also need to drop "hw/pci: remove obsolete PCIDevice->init()"
>> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420)
>> else the not-yet-QOM'ified NVME won't work anymore.
>
> Done that too, thanks a lot
Hi. I'm afraid
On 8 January 2018 at 01:22, microsoft gaofei wrote:
> https://www.virtualbox.org/ticket/5810
>
> VirtualBox has a new feature to auto-install guest OSes.
> Could you develop such a feature to improve QEMU ?
I think this sort of feature is something we'd prefer to
see in the "management layer" sof
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We make the locking and the transfer of information specific, even if we
>> are still receiving things through the main thread.
>>
>> Signed-off-by: Juan Quintela
>>
>> --
>>
>> We split when we create the main c
Stefano, can you ack/nack this one ?
On Wed, 20 Dec 2017 20:42:54 +0100
Greg Kurz wrote:
> No good reasons to do this outside of v9fs_device_realize_common().
>
> Signed-off-by: Greg Kurz
> ---
> hw/9pfs/9p.c |6 +-
> hw/9pfs/9p.h | 10 ++
> hw/9p
Eric Blake writes:
> On 01/05/2018 12:47 AM, Michael Clark wrote:
>
>>>
+##
+{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } }
>>>
>>> Should this be 'uint64' or other specific type, rather than the generic
>>> 'int' (which happens to be 64 bits, but signed)? Other architectures
>>
Le 28/12/2017 à 20:34, Samuel Thibault a écrit :
> sched_get/setaffinity linux-user syscalls were missing conversions for
> little/big endian, which is hairy since longs may not be the same size
> either.
>
> For simplicity, this just introduces loops to convert bit by bit like is
> done for selec
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We switch for sending the page number to send real pages.
>>
>> Signed-off-by: Juan Quintela
>
> I think this is OK if squashed with the 'test' patch to remove
> the test stuff.
Done.
>
> Some minor comments belo
[...]
chip EMC for early classification. It gives a fast path for those throughput
sensitive(SLA) VNF to bypass the further table lookup. It co-exists other VNF
whose SLA level is best effort but requires more functions(e.g. stateful
conntrack, security check, even higher layer WAF support) sup
On Tue, 19 Dec 2017 13:41:12 +0800
sochin.jiang wrote:
> Hi, guys.
>
> I'm looking for the hot-plug/unplug features of virtio-9p device
> recently, and found there's a lack of support.
>
> I am wondering why ? Is there a reason. Actually, I write a qmp command
> to support fsdev_
On 22 December 2017 at 02:15, Jason Wang wrote:
> The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b:
>
> hw/i386/vmport: fix missing definitions with non-log trace backends
> (2017-12-21 22:52:28 +)
>
> are available in the git repository at:
>
> https://github.c
On Mon, Jan 01, 2018 at 09:16:00PM +0100, Jindřich Makovička wrote:
> On Fri, 17 Nov 2017 12:22:55 +0100
> Jindrich Makovicka wrote:
>
> > Hi,
> >
> > here is a respin of the three remaining patches, with checkpatch
> > errors corrected.
> >
> > Also added the Fixes: line for "sdl2 uses surface
On 20 December 2017 at 18:44, Dr. David Alan Gilbert
wrote:
> From a quick look my guess would be the wpgrps_size in sd_vmstate is
> different on the source and destination for some reason
Good guess: I added a pre_save hook to sdcard.c's vmstate,
which reports wpgrps_size as 201, but in the pre_
On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote:
> ping
>
> >
> > ping
> >
> > >
> > > ping the series
> > >
Was on sick leave for a few weeks, back now, will process asap but will
probably take a while nevertheless due to the big backlog I have now.
cheers,
Gerd
On Mon, Dec 18, 2017 at 07:12:16PM +, Daniel P. Berrange wrote:
> There is only one caller of vnc_update_client and that always passes false
> for the 'sync' parameter.
Unused since commit 50628d3479e4f9aa97e323506856e394fe7ad7a6.
Good catch.
What is the state of this series btw (/me busy wad
On 01/05/2018 11:49 PM, Stefan Hajnoczi wrote:
On Thu, Jan 04, 2018 at 07:15:38PM +0800, Wei Wang wrote:
On 01/04/2018 06:47 PM, Stefan Hajnoczi wrote:
On Thu, Dec 21, 2017 at 06:01:29AM -0500, Marc-André Lureau wrote:
I'm not going to prototype this yet, I'm working on virtio-vhost-user
first
On 22 December 2017 at 20:16, Stefan Berger wrote:
> The following series of patches most important parts add a caching layer
> to the TPM emulator backend for reducing the number of control commands sent
> to retrieve the TPMEstablished flag. They also simplify the TPM TIS internal
> usage of buf
On 20 December 2017 at 21:23, Michael Weiser wrote:
> Hello,
>
> below patches add support for big-endian aarch64 to linux-user. Almost
> everything is already in place. The patches just set up the CPU flags as
> required for big-endianness, add a distinction in uname and make sure the
> instructi
On 30 December 2017 at 22:56, Michael Weiser wrote:
> ldxp loads two consecutive doublewords from memory regardless of CPU
> endianness. On store, stlxp currently assumes to work with a 128bit
> value and consequently switches order in big-endian mode. With this
> change it packs the doublewords i
On 28 December 2017 at 08:20, Andrew Jones wrote:
> On Thu, Dec 28, 2017 at 09:14:40AM +0800, Shannon Zhao wrote:
>> From: Zhaoshenglong
>>
>> acpi_data_push uses g_array_set_size to resize the memory size. If there
>> is no enough contiguous memory, the address will be changed. If we use
>> the
I've confirmed with Seeteena and this bug was fixed by commit
https://git.qemu.org/?p=qemu.git;a=commit;h=c0dd10991903c552811d8cbe9231055b1b3a7ebd
commit c0dd10991903c552811d8cbe9231055b1b3a7ebd
Author: Seeteena Thoufeek
Date: Mon Sep 4 13:13:51 2017 +0530
vl: exit if maxcpus is negative
On Thu, 4 Jan 2018 17:22:03 -0200
Eduardo Habkost wrote:
> On Thu, Jan 04, 2018 at 11:40:40AM -0300, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > This RFC series is intended to simplify Flattened Device Tree support,
> > in particular the 'compatible' FDT entry, when Linux names mismatches
> >
On Thu, 4 Jan 2018 11:40:44 -0300
Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/xilinx_zynq.c | 1 +
> hw/arm/xlnx-zynqmp.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index 183
Alex Bennée writes:
> Richard Henderson writes:
>
>> On 12/11/2017 04:56 AM, Alex Bennée wrote:
>>> +static inline float16 float16_set_sign(float16 a, int sign)
>>> +{
>>> +return make_float16((float16_val(a) & 0x7fff) | (sign << 15));
>>> +}
>>> +
>>
>> 1) Do we use this anywhere?
>
> Yes
On 08.01.2018 13:54, Igor Mammedov wrote:
> On Thu, 4 Jan 2018 11:40:44 -0300
> Philippe Mathieu-Daudé wrote:
>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> hw/arm/xilinx_zynq.c | 1 +
>> hw/arm/xlnx-zynqmp.c | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/h
Am 08.01.2018 um 04:09 schrieb Fam Zheng:
After the out label there is a check on iTask.task but it is not
initialized yet.
Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8
Signed-off-by: Fam Zheng
---
block/iscsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/i
On Jan 8, 2018 02:16, "Peter Maydell" wrote:
On 22 December 2017 at 02:15, Jason Wang wrote:
> The following changes since commit 43ab9a5376c95c61ae898a222c4d04
bdf60e239b:
>
> hw/i386/vmport: fix missing definitions with non-log trace backends
(2017-12-21 22:52:28 +)
>
> are available in
On 23 December 2017 at 07:53, Paolo Bonzini wrote:
> The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b:
>
> hw/i386/vmport: fix missing definitions with non-log trace backends
> (2017-12-21 22:52:28 +)
>
> are available in the Git repository at:
>
> git://github.
On 01/08/2018 10:17 AM, Thomas Huth wrote:
> On 08.01.2018 13:54, Igor Mammedov wrote:
>> On Thu, 4 Jan 2018 11:40:44 -0300
>> Philippe Mathieu-Daudé wrote:
>>
>>> Signed-off-by: Philippe Mathieu-Daudé
>>> ---
>>> hw/arm/xilinx_zynq.c | 1 +
>>> hw/arm/xlnx-zynqmp.c | 2 +-
>>> 2 files changed,
On 01/07/2018 06:23 AM, Richard Palethorpe wrote:
> Add QAPI wrapper functions for the existing snapshot functionality. These
> functions behave the same way as the HMP savevm, loadvm and delvm
> commands. This will allow applications, such as OpenQA, to programmatically
> revert the VM to a previo
On 2 January 2018 at 19:36, Andrey Smirnov wrote:
> Make Tx frame assembly buffer to be a paort of IMXFECState structure
> to avoid a concern about having large data buffer on the stack.
>
> Cc: Peter Maydell
> Cc: Jason Wang
> Cc: Philippe Mathieu-Daudé
> Cc: qemu-devel@nongnu.org
> Cc: qemu-.
On 2 January 2018 at 19:36, Andrey Smirnov wrote:
> Frame truncation length, TRUNC_FL, is determined by the contents of
> ENET_FTRL register, so convert the code to use it instead of a
> hardcoded constant.
>
> To avoid the case where TRUNC_FL is greater that ENET_MAX_FRAME_SIZE,
> increase the va
On Mon, 8 Jan 2018 10:51:38 -0300
Philippe Mathieu-Daudé wrote:
> On 01/08/2018 10:17 AM, Thomas Huth wrote:
> > On 08.01.2018 13:54, Igor Mammedov wrote:
> >> On Thu, 4 Jan 2018 11:40:44 -0300
> >> Philippe Mathieu-Daudé wrote:
> >>
> >>> Signed-off-by: Philippe Mathieu-Daudé
> >>> ---
>
Hi Igor,
On 01/08/2018 09:51 AM, Igor Mammedov wrote:
[...]
> Though it seems easy and trivial, I'm a bit concerned about using
> QOM types for the task though.
> Also see commit 6acbe4c6f which labels aliases as a bad idea
> and says that they are there only for compatibility and shouldn't
> be u
On 08/01/2018 14:43, Peter Maydell wrote:
> Applied, thanks.
>
> (We should make sure we mention this in the changelog, and
> perhaps have a blog post about it at release time, if anybody
> would like to volunteer to write one.)
I can write one before the release, you can imagine what I'm busy wi
> The RISC-V QEMU port implements the following specifications:
> - RISC-V Instruction Set Manual Volume I: User-Level ISA Version 2.2
> - RISC-V Instruction Set Manual Volume II: Privileged ISA Version 1.9.1
> - RISC-V Instruction Set Manual Volume II: Privileged ISA Version 1.10
What is the reas
On 2 January 2018 at 19:36, Andrey Smirnov wrote:
> Hi everyone,
>
> This patchset is v3 of a spin-off from original i.MX7 support submission
> found here [1], containing all of the patchest that are more or less
> agreed upon and are ready (hopefully!) for inclusion.
Thanks for the respin -- I'v
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-handle.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
index 9875f1894cc5..65b12de230c1 100644
--- a/hw
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 6 +++---
hw/9pfs/9p.h | 12 ++--
hw/9pfs/virtio-9p-device.c | 2 +-
hw/9pfs/xen-9p-backend.c | 2 +-
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/9pf
The following changes since commit 8671016261cd5dfba1042aef0a632a77b0d387a2:
Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
staging (2018-01-08 09:15:42 +)
are available in the git repository at:
https://github.com/gkurz/qemu.git tags/for-upstream
for you to
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
fsdev/file-op-9p.h | 5 +++--
hw/9pfs/9p-xattr.h | 5 ++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
index 474c79d003f6..05b3ef357462 100644
--- a/fsdev/file-op-9p.h
+
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
fsdev/file-op-9p.h | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
index 05b3ef357462..32125100ce93 100644
--- a/fsdev/file-op-9p.h
+++
Signed-off-by: Greg Kurz
---
tests/virtio-9p-test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c
index ebd24b20f657..00f00f7246e9 100644
--- a/tests/virtio-9p-test.c
+++ b/tests/virtio-9p-test.c
@@ -75,6 +75,9 @@ static QVirtIO9P *qvirtio_
> +if (env->priv_ver >= PRIV_VERSION_1_10_0) {
> +if (get_field(env->satp, SATP_MODE) == VM_1_09_MBARE) {
> +mode = PRV_M;
> +}
> +} else {
> +if (get_field(env->mstatus, MSTATUS_VM) == VM_1_10_MBARE) {
> +mode = PRV_M;
> +}
> +}
This backend raise some concerns:
- doesn't support symlinks
- fails +100 tests in the PJD POSIX file system test suite [1]
- requires the QEMU process to run with the CAP_DAC_READ_SEARCH
capability, which isn't recommended for security reasons
This backend should not be used and wil be removed
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
Reviewed-by: Eric Blake
---
hw/9pfs/9p-handle.c | 2 +-
hw/9pfs/9p-local.c | 2 +-
hw/9pfs/9p-proxy.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
index 65b12de23
They're only used by the 9p core code.
Signed-off-by: Greg Kurz
Reviewed-by: Eric Blake
---
hw/9pfs/9p.c | 4 ++--
hw/9pfs/9p.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 558efb41defd..1e4ebbe57687 100644
--- a/hw/9pfs/9p.c
+++ b/hw/
And drop the now useless forward declaration of virtio_9p_transport.
Signed-off-by: Greg Kurz
---
hw/9pfs/virtio-9p-device.c | 60 ++
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.
Like other virtio tests, use the used ring APIs instead of assuming ISR
being set means the request has completed.
Signed-off-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
---
tests/virtio-9p-test.c | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git
If we receive an unsupported request id, we first decide to
return -ENOTSUPP to the client, but since the request id
causes is_read_only_op() to return false, we change the
error to be -EROFS if the fsdev is read-only. This doesn't
make sense since we don't know what the client asked for.
This pat
This patch changes some error messages in the backend opts parsing
code and convert backends to propagate QEMU Error objects instead
of calling error_report().
Signed-off-by: Greg Kurz
---
fsdev/file-op-9p.h | 2 +-
fsdev/qemu-fsdev.c | 4 +++-
hw/9pfs/9p-handle.c | 2 +-
hw/9pfs/9p-local.c
Aneesh has been working on other topics for some time now. Let's reflect
that in the MAINTAINERS file, so that people stop Cc'ing him.
Signed-off-by: Greg Kurz
Acked-by: Aneesh Kumar K.V
---
MAINTAINERS | 2 --
1 file changed, 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 73a
This patch changes some error messages in the backend init code and
convert backends to propagate QEMU Error objects instead of calling
error_report().
One notable improvement is that the local backend now provides a more
detailed error report when it fails to open the shared directory.
Signed-of
On Wed, Jan 03, 2018 at 01:44:15PM +1300, Michael Clark wrote:
> HTIF (Host Target Interface) provides console emulation for QEMU. HTIF
> allows identical copies of BBL (Berkeley Boot Loader) and linux to run
> on both Spike and QEMU. BBL provides HTIF console access via the
> SBI (Supervisor Binar
On Fri, Jan 05, 2018 at 12:55:41PM -0300, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 01/05/2018 12:31 PM, Stefan Hajnoczi wrote:
> > On Wed, Jan 03, 2018 at 06:49:25PM -0300, Philippe Mathieu-Daudé wrote:
> >> +static const char *machines[PROTO_COUNT] = {
> >> +[PROTO_SD] = "nuri",
> >>
Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben:
> Management and users are accustomed to "qemu-img info" to query status of
> images even when they are used by guests. Since image locking was added, the
> -U
> (--force-share) option is needed for that to work. The reason has been that
> due
> t
On Thu 21 Dec 2017 03:22:38 PM CET, Kevin Wolf wrote:
> Block jobs already paused themselves when their main BlockBackend
> entered a drained section. This is not good enough: We also want to
> pause a block job and may not submit new requests if, for example, the
> mirror target node should be dra
Am 26.12.2017 um 07:53 hat Fam Zheng geschrieben:
> We could hit lock failure if there is a signal that makes fcntl return
> -1 and errno set to EINTR. In this case we should retry.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Fam Zheng
Thanks, applied to the block branch.
Kevin
On 3 January 2018 at 22:42, Philippe Mathieu-Daudé wrote:
> since v1:
> - fixed qemu_log_mask() lines indentation (Alistair)
> - added Alistair's R-b
>
> tiny patches that allow to boot a Gumstix Connex board and use U-Boot.
Thanks, applied to target-arm.next. Patch 2 is missing
a #include "qemu/
On 01/08/2018 11:52 AM, Peter Maydell wrote:
> On 3 January 2018 at 22:42, Philippe Mathieu-Daudé wrote:
>> since v1:
>> - fixed qemu_log_mask() lines indentation (Alistair)
>> - added Alistair's R-b
>>
>> tiny patches that allow to boot a Gumstix Connex board and use U-Boot.
>
> Thanks, applied
On 01/08/2018 07:20 AM, Peter Lieven wrote:
> Am 08.01.2018 um 04:09 schrieb Fam Zheng:
>> After the out label there is a check on iTask.task but it is not
>> initialized yet.
>>
>> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8
>> Signed-off-by: Fam Zheng
>> ---
>> block/iscsi.c | 3 +--
>> 1
On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote:
> Applied, thanks.
>
> PS: just noticed, but "Ed Swierk via Qemu-devel "
> is a bit of an odd Author string to end up in git commit logs, so you
> and/or Ed might like to fix that up for any future patches.
>
>
> Thanks for pointing that o
On 22 December 2017 at 15:18, Kevin Wolf wrote:
> The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22
> 00:11:36 +)
>
> are available in the git repository
On Wed, Dec 20, 2017 at 19:15:55 +0100, Markus Armbruster wrote:
> "Daniel P. Berrange" writes:
>
> > On Fri, Dec 15, 2017 at 05:38:00PM +0100, Max Reitz wrote:
> >
> >> Image creation in qemu-system-* vs. qemu-img:
> >> In order to get proper introspection for qemu-img create, we need a
> >>
On Thu 21 Dec 2017 03:22:40 PM CET, Kevin Wolf wrote:
> Block jobs are already paused using the BdrvChildRole drain callbacks,
> so we don't need an additionall block_job_pause_all() call.
>
> Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Berto
On 01/08/2018 09:10 AM, Eric Blake wrote:
> On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote:
>
>> Applied, thanks.
>>
>> PS: just noticed, but "Ed Swierk via Qemu-devel "
>> is a bit of an odd Author string to end up in git commit logs, so you
>> and/or Ed might like to fix that up for any
On 8 January 2018 at 15:05, Philippe Mathieu-Daudé wrote:
> I'm adding a sticker to my monitor "build with
> --enable-trace-backends=simple" before sending a series with new trace
> events.
I think it would be better to try to harden the log backend
for trace and our log.h so that we get a compil
On Thu 21 Dec 2017 03:22:39 PM CET, Kevin Wolf wrote:
> Block jobs must be paused if any of the involved nodes are drained.
>
> Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Berto
On 01/08/2018 09:18 AM, Eric Blake wrote:
> Hmm - we probably ought to enhance checkpatch.pl to insist that patches
> attributed to qemu-devel@nongnu.org as the author should be flagged as
> invalid, since the list munging is a 1:M mapping rather than 1:1, and
> therefore not easily invertable.
S
in case of unaligned requests or on a target that does not support
block provisioning we leave iTask uninitialized and check iTask.task
for NULL later.
Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
---
block/iscsi.
Am 18.12.2017 um 06:00 hat Hikaru Nishida geschrieben:
> Pin-based interrupt of NVMe controller did not work properly
> because using an obsolated function pci_irq_pulse().
> To fix this, change to use pci_irq_assert() / pci_irq_deassert()
> instead of pci_irq_pulse().
>
> Signed-off-by: Hikaru Ni
If we are careful to handle 0-length read requests correctly,
we can optimize our sparse read to send the NBD_REPLY_FLAG_DONE
bit on our last OFFSET_DATA or OFFSET_HOLE chunk rather than
needing a separate chunk.
Signed-off-by: Eric Blake
Message-Id: <20171107030912.23930-3-ebl...@redhat.com>
Rev
The following changes since commit 799044b6a3a0fc63e1e020e4d9266786a2dc7a0b:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2018-01-08 13:44:01 +)
are available in the Git repository at:
git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-01-08
for you to f
From: Murilo Opsfelder Araujo
The find_desc_by_name() from util/qemu-option.c relies on the .name not being
NULL to call strcmp(). This check becomes unsafe when the list is not
NULL-terminated, which is the case of nbd_runtime_opts in block/nbd.c, and can
result in segmentation fault when strcmp
The reason that NBD added structured reply in the first place was
to allow for efficient reads of sparse files, by allowing the
reply to include chunks to quickly communicate holes to the client
without sending lots of zeroes over the wire. Time to implement
this in the server; our client can alre
Commit 881cfd17 added a new test binary, include it in .gitignore.
Reported-by: Eric Blake
Signed-off-by: Kevin Wolf
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index 74e55d7264..e5c744b7ed 100644
--- a/tests/.gitignore
+++ b/test
On 4 January 2018 at 17:39, Andreas Gustafsson wrote:
> Check for the presence of posix_memalign() in the configure script,
> not using "defined(_POSIX_C_SOURCE) && !defined(__sun__)". This
> lets qemu use posix_memalign() on NetBSD versions that have it,
> instead of falling back to valloc() whi
Since v4 ("SDHCI: add qtests and fix few issues"):
- spec_version default to v2 (current behaviour)
- addressed Alistair review (no v1, tell user about valid version)
- generic-sdhci is now abstract, added more sdhci device following Linux
Device Tree names:
- hw/arm/fsl-imx6: "fsl,imx6q-usdhc"
default to Spec v2.00
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci-internal.h | 4 ++--
include/hw/sd/sdhci.h | 3 +++
hw/sd/sdhci.c | 19 +--
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
inde
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci-internal.h | 1 -
include/hw/sd/sdhci.h | 1 +
hw/sd/sdhci.c | 38 +-
3 files changed, 14 insertions(+), 26 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index 6944fc
so this class can be inherited.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/sd/sdhci.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h
index 4a9c3e9175..a80b7c0424 100644
--- a/include/hw/sd/sdhci.h
+++ b/include/hw/sd/sdhc
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/sd/sdhci.h | 2 ++
hw/sd/sdhci.c | 52 +++
2 files changed, 34 insertions(+), 20 deletions(-)
diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h
index 2703da1d5a..c1602becd2 1006
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci-internal.h | 14 +++---
include/hw/sd/sdhci.h | 4
hw/sd/sdhci.c | 40 ++--
3 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-inter
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci-internal.h | 22 ++-
include/hw/sd/sdhci.h | 6 ++
hw/sd/sdhci.c | 58 --
3 files changed, 69 insertions(+), 17 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/dw-mshc.c | 64 +
hw/sd/Makefile.objs | 1 +
2 files changed, 65 insertions(+)
create mode 100644 hw/sd/dw-mshc.c
diff --git a/hw/sd/dw-mshc.c b/hw/sd/dw-mshc.c
new file mode 100644
index 00
On 30 December 2017 at 16:30, John Arbuckle wrote:
> When using a mouse's scroll wheel in a guest with the cocoa front-end, the
> mouse pointer moves up and down instead of scrolling the window. This patch
> fixes this problem.
Thanks for this patch. The code looks good to me, but
you can now a
From: Sai Pavan Boddu
The 64-bit ADMA address is not converted to the cpu endianes correctly.
This patch fixes the issue and uses a valid mask for the attribute data.
Signed-off-by: Sai Pavan Boddu
[AF: Re-write commit message]
Reviewed-by: Alistair Francis
---
hw/sd/sdhci.c | 4 ++--
1 file
1 - 100 of 278 matches
Mail list logo
