Re: [Qemu-devel] [PATCH] target-i386: add pcid to both Sandy Bridge and Ivy Bridge

❦ 8 janvier 2018 21:19 -0200, Eduardo Habkost  : >> > GET_SUPPORTED_CPUID seems to still return PCID as supported >> > without EPT, doesn't it? >> >> Indeed it is! It will also be useful for KPTI performance without >> INVPCID, but it won't be useful without EPT. > >

Re: [Qemu-devel] [PATCH] linux-user: MIPS set cpu to r6 CPU if binary is R6

Peter, Riku, what do you think of the idea of using the ELF header to select the CPU to emulate? Thanks, Laurent Le 19/12/2017 à 12:50, YunQiang Su a écrit : > MIPS r6 is not just simple super set for pre-R6, > it also drops some instruction and even changes encoding for some. > But r6 binary

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

Thank you for applying my patch. > I had to resolve conflicts with the tracing patches and chose to keep > the trace points from pci_irq_pulse() for pci_irq_assert(), but didn't > add them to pci_irq_deassert(). Please check if this makes sense to you. It makes sense for now. I will send another

[Qemu-devel] [RFC PATCH v2 8/9] hw/dma/xlnx_dpdma: add 'xlnx, axi-dpdma-1.0' FDT alias

Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/xlnx_dpdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/dma/xlnx_dpdma.c b/hw/dma/xlnx_dpdma.c index 8ceb21ddb3..d1b508cfe3 100644 --- a/hw/dma/xlnx_dpdma.c +++ b/hw/dma/xlnx_dpdma.c @@ -24,6 +24,7 @@ #include

[Qemu-devel] [RFC PATCH v2 9/9] hw/arm/xlnx-zynqmp: use Linux FDT names

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zynqmp.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 325642058b..fdcd6801b6 100644 --- a/hw/arm/xlnx-zynqmp.c +++

Re: [Qemu-devel] [PATCH v3 33/42] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3

> From: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] > Sent: Friday, 29 December 2017 09:49 > > Signed-off-by: Philippe Mathieu-Daudé > --- > > Note, the bcm2835 seems to have 1KB minimum blocksize, however the > current > model is implemented with 512B. >

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

On Tue, Jan 2, 2018 at 4:59 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster >> wrote: >>> Alistair Francis writes: >>> On Fri,

[Qemu-devel] [RFC PATCH v2 6/9] hw/usb/hcd-ehci: add 'xlnx, ps7-usb' FDT aliases

Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-ehci-sysbus.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index 3b83beb140..0c1a995c2f 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@

[Qemu-devel] [RFC PATCH v2 7/9] hw/ssi/xlnx-spips: add 'xlnx.zynq-qspi' FDT alias

Signed-off-by: Philippe Mathieu-Daudé --- hw/ssi/xilinx_spips.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index d8187fadd1..9f7edc7a14 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -24,6 +24,7 @@

[Qemu-devel] [RFC PATCH v2 2/9] hw/char/cadence_uart: add FDT aliases

Signed-off-by: Philippe Mathieu-Daudé --- hw/char/cadence_uart.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index 6143494060..f164cee61d 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

On Mon, Jan 08, 2018 at 09:14:41AM +, Peter Maydell wrote: > On 21 December 2017 at 23:43, Michael S. Tsirkin wrote: > >> you also need to drop "hw/pci: remove obsolete PCIDevice->init()" > >> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420) > >> else the

Re: [Qemu-devel] [PATCH] irq: fix memory leak

On Mon, Dec 25, 2017 at 10:47:04AM +0800, linzhecheng wrote: > entry is moved from list but is not freed. > > Signed-off-by: linzhecheng Makes sense. Reviewed-by: Michael S. Tsirkin > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Mon, 01/08 18:57, Kevin Wolf wrote: > I'm not sure if going back to the old behaviour for a while now would be > helpful, you'd just end up with an even more confusing set of qemu > versions, for example: > > <= 2.9 - works without a warning > 2.10 and 2.11 - errors out >

Re: [Qemu-devel] [PATCH] target-i386: add pcid to both Sandy Bridge and Ivy Bridge

❦ 8 janvier 2018 17:37 -0500, Paolo Bonzini  : >> One possible way to work around this problem is to declare that >> QEMU 2.12 with KVM will require Linux v3.6 and newer (because we >> need Linux kernel commit ad756a1603c5 "KVM: VMX: Implement >> PCID/INVPCID for guests

Re: [Qemu-devel] [PATCH] target-i386: add pcid to both Sandy Bridge and Ivy Bridge

❦ 8 janvier 2018 20:56 -0200, Eduardo Habkost  : > (BTW, is PCID useful for KPTI performance without INVPCID?) It seems it is: https://mail-archive.com/linux-kernel@vger.kernel.org/msg1576774.html -- Don't use conditional branches as a substitute for a logical

[Qemu-devel] [PATCH x86-next v2] target-i386: add PCID flag to Westmere, Sandy Bridge and Ivy Bridge

PCID has been introduced in Westmere and, since Linux 3.6 (ad756a1603c5), KVM exposes PCID flag if host has it. Update CPU model for Westmere, Sandy Bridge and Ivy Bridge accordingly. Ensure compat 2.11 keeps PCID disabled by default for those models and document the new requirement for host

Re: [Qemu-devel] What's needed to pass pciid cpu flag to guest?

> Am 08.01.2018 um 19:58 schrieb Stefan Priebe - Profihost AG > : > > Hello, > > for meltdown mitigation and performance it's important to have the pcid > flag passed down to the guest (f.e. > https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L9mHTbeQLNU). >

[Qemu-devel] [RFC PATCH v2 5/9] hw/dma/axidma: add 'xlnx, eth-dma' FDT alias

Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/xilinx_axidma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index 9b48103574..2359d5c114 100644 --- a/hw/dma/xilinx_axidma.c +++ b/hw/dma/xilinx_axidma.c @@ -24,6 +24,7 @@

Re: [Qemu-devel] [PATCH] MAINTAINERS: Drop Aneesh as 9pfs maintainer

Greg Kurz writes: > Aneesh has been working on other topics for some time now. Let's reflect > that in the MAINTAINERS file, so that people stop Cc'ing him. > > Signed-off-by: Greg Kurz Acked-by: Aneesh Kumar K.V > --- >

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

On 21 December 2017 at 23:43, Michael S. Tsirkin wrote: >> you also need to drop "hw/pci: remove obsolete PCIDevice->init()" >> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420) >> else the not-yet-QOM'ified NVME won't work anymore. > > Done that too, thanks a

Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure

Eric Blake writes: > On 01/05/2018 12:47 AM, Michael Clark wrote: > >>> +## +{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } } >>> >>> Should this be 'uint64' or other specific type, rather than the generic >>> 'int' (which happens to be 64 bits, but signed)?

Re: [Qemu-devel] virtio-9p: hot-plug/unplug about virtio-9p device

On Tue, 19 Dec 2017 13:41:12 +0800 sochin.jiang wrote: > Hi, guys. > > I'm looking for the hot-plug/unplug features of virtio-9p device > recently, and found there's a lack of support. > > I am wondering why ? Is there a reason. Actually, I write a qmp

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

On 03/01/18 11:09, David Gibson wrote: > On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: >> On 11/12/17 17:20, Alexey Kardashevskiy wrote: >>> On 09/11/17 17:38, David Gibson wrote: On Tue, Nov 07, 2017 at 06:14:04PM +1100, Alexey Kardashevskiy wrote: > On 20/10/17

Re: [Qemu-devel] [PATCH] linux-user: Fix sched_get/setaffinity conversion

Le 28/12/2017 à 20:34, Samuel Thibault a écrit : > sched_get/setaffinity linux-user syscalls were missing conversions for > little/big endian, which is hairy since longs may not be the same size > either. > > For simplicity, this just introduces loops to convert bit by bit like is > done for

Re: [Qemu-devel] [PULL 00/18] Net patches

On 22 December 2017 at 02:15, Jason Wang wrote: > The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b: > > hw/i386/vmport: fix missing definitions with non-log trace backends > (2017-12-21 22:52:28 +) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH] 9pfs: deprecate handle backend

Greg Kurz writes: > This backend raise some concerns: > > - doesn't support symlinks > - fails +100 tests in the PJD POSIX file system test suite [1] > - requires the QEMU process to run with the CAP_DAC_READ_SEARCH > capability, which isn't recommended for security reasons > >

Re: [Qemu-devel] [PATCH v3 1/2] 9pfs: allow PDU to complete without sending a reply

Stefano, ping ? On Wed, 20 Dec 2017 13:59:41 +0100 Greg Kurz wrote: > On Mon, 18 Dec 2017 11:41:23 +0100 > Greg Kurz wrote: > > > The 9p protocol mostly relies on a request/reply dialog between the > > client and the server. A notable exception to this rule is

Re: [Qemu-devel] Auto-install guests

On 8 January 2018 at 01:22, microsoft gaofei wrote: > https://www.virtualbox.org/ticket/5810 > > VirtualBox has a new feature to auto-install guest OSes. > Could you develop such a feature to improve QEMU ? I think this sort of feature is something we'd prefer to see in

Re: [Qemu-devel] [PATCH] 9pfs: drop v9fs_register_transport()

Stefano, can you ack/nack this one ? On Wed, 20 Dec 2017 20:42:54 +0100 Greg Kurz wrote: > No good reasons to do this outside of v9fs_device_realize_common(). > > Signed-off-by: Greg Kurz > --- > hw/9pfs/9p.c |6 +- > hw/9pfs/9p.h

Re: [Qemu-devel] [PATCH v9 07/12] migration: Create thread infrastructure for multifd recv side

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We make the locking and the transfer of information specific, even if we >> are still receiving things through the main thread. >> >> Signed-off-by: Juan Quintela >> >>

Re: [Qemu-devel] [PATCH v9 10/12] migration: Transfer pages over new channels

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We switch for sending the page number to send real pages. >> >> Signed-off-by: Juan Quintela > > I think this is OK if squashed with the 'test' patch to remove > the test

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

[...] chip EMC for early classification. It gives a fast path for those throughput sensitive(SLA) VNF to bypass the further table lookup. It co-exists other VNF whose SLA level is best effort but requires more functions(e.g. stateful conntrack, security check, even higher layer WAF support)

[Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings

Hi, A recent mail from Michael remembered me this pre-2.10 series eh :) I tagged the last patch 'RFC' because I find it ugly and hope there is a nicer way to write it. Regards, Phil. Philippe Mathieu-Daudé (12): slirp: remove QEMU_PACKED from structures with don't require it slirp: struct

Re: [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch

On 8 January 2018 at 17:29, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 17 + > 1 file changed, 17 insertions(+) This doesn't seem like the right approach to me. We want this sort of thing to be a

Re: [Qemu-devel] [Qemu-block] [PATCH v2 09/19] block: Nested drain_end must still call callbacks

Am 08.01.2018 um 16:41 hat Alberto Garcia geschrieben: > On Thu 21 Dec 2017 03:22:41 PM CET, Kevin Wolf wrote: > > bdrv_do_drained_begin() restricts the call of parent callbacks and > > aio_disable_external() to the outermost drain section, but the block > > driver callbacks are always called.

[Qemu-devel] [PATCH 4/7] net/rocker: move struct rocker_desc to C file

this is the only user. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker_hw.h | 13 - hw/net/rocker/rocker_desc.c | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/net/rocker/rocker_hw.h

[Qemu-devel] [PATCH 5/7] net/eepro100: use QEMU_ALIGNED() macro

Signed-off-by: Philippe Mathieu-Daudé --- hw/net/eepro100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index a07a63247e..61d767524f 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -266,7 +266,7 @@ typedef

Re: [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch

On 01/08/2018 02:32 PM, Peter Maydell wrote: > On 8 January 2018 at 17:29, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> configure | 17 + >> 1 file changed, 17 insertions(+) > > This doesn't seem like the

[Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

theses structures are not serialized and often store host pointers. slirp/ip_input.c:159:43: warning: taking address of packed member 'ip_link' of class or structure 'ipq' may result in an unaligned pointer value [-Waddress-of-packed-member] for (l =

[Qemu-devel] [PULL v2 00/16] target/xtensa updates

000) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20180108-xtensa for you to fetch changes up to 7ffb3123b24e42a3a94e865434b4180025b9f9ca: target/xtensa: implement disassembler (2018-01-08 09:37:32 -0

Re: [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

On 01/08/2018 03:10 PM, Paolo Bonzini wrote: > On 08/01/2018 19:02, Philippe Mathieu-Daudé wrote: >> /* Data in mem is always in the byte order of the controller (le). >> * It must be dword aligned to allow direct access to 32 bit values. */ >> -uint8_t mem[PCI_MEM_SIZE]

[Qemu-devel] [PATCH] MAINTAINERS: update Dmitry Fleytman email

gently asked by his automatic reply :) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 73a735..8050499ec5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1157,7

Re: [Qemu-devel] [PATCH v5 7/7] vhost: Merge and delete unused callbacks

* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 18 Dec 2017 20:13:40 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Now that the olf vhost_set_memory code is gone, the _nop and _add > > callbacks are

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

On 01/08/2018 02:10 PM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the

Re: [Qemu-devel] [PATCH v5 1/7] vhost: Build temporary section list and deref after commit

* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 18 Dec 2017 20:13:34 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Igor spotted that there's a race, where a region that's unref'd > > in a _del

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

On Tue, Dec 19, 2017 at 04:45:46PM +0800, Peter Xu wrote: > Originally QMP goes throw these steps: s/throw/through/ > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

On 01/08/2018 11:10 AM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the

[Qemu-devel] [PATCH 2/2] vhost-user: fix misaligned access to payload

We currently take a pointer to a misaligned field of a packed structure. clang reports this as a build warning. A fix is to keep payload in a separate structure, and access is it from there using a vectored write. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c |

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

Am 08.01.2018 um 18:07 hat Nir Soffer geschrieben: > On Mon, Jan 8, 2018 at 4:48 PM Kevin Wolf wrote: > > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > Management and users are accustomed to "qemu-img info" to query status of > > > images even when they are used by

Re: [Qemu-devel] [PATCH v5 4/7] vhost: Merge sections added to temporary list

* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 18 Dec 2017 20:13:37 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > As sections are reported by the listener to the _nop and _add > > methods, add them

[Qemu-devel] [PATCH v2] cocoa.m: Fix scroll wheel support

When using a mouse's scroll wheel in a guest with the cocoa front-end, the mouse pointer moves up and down instead of scrolling the window. This patch fixes this problem. Signed-off-by: John Arbuckle --- ui/cocoa.m | 27 +++ 1 file changed, 19

[Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

as suggested in the comment. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/eepro100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 61d767524f..abb44710d9 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

On Mon, Jan 8, 2018 at 4:48 PM Kevin Wolf wrote: > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > Management and users are accustomed to "qemu-img info" to query status of > > images even when they are used by guests. Since image locking was added, > the -U > >

[Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

In commit c97d6d2cdf97ed we accidentally added code to configure that uses '==' for string equality testing. This is a bashism -- the portable way to write this is '='. This fixes the "Unexpected operator error" complaint produced if the system /bin/sh is dash. Fixes: c97d6d2cdf97ed Reported-by:

[Qemu-devel] [PATCH 08/12] slirp: removed unused code

Signed-off-by: Philippe Mathieu-Daudé --- slirp/ip.h | 13 - 1 file changed, 13 deletions(-) diff --git a/slirp/ip.h b/slirp/ip.h index e29ccd3c9f..71c3642cfe 100644 --- a/slirp/ip.h +++ b/slirp/ip.h @@ -233,17 +233,4 @@ struct ipasfrag { #define ipf_next

[Qemu-devel] [PATCH 09/12] slirp: add in6_dhcp_multicast()

Signed-off-by: Philippe Mathieu-Daudé --- slirp/dhcpv6.h | 3 +++ slirp/udp6.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/slirp/dhcpv6.h b/slirp/dhcpv6.h index 9189cd3f2d..3373f6cb89 100644 --- a/slirp/dhcpv6.h +++ b/slirp/dhcpv6.h @@ -17,6 +17,9 @@

[Qemu-devel] [PATCH 07/12] slirp: remove unnecessary

Signed-off-by: Philippe Mathieu-Daudé --- slirp/libslirp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index f90f0f524c..540b3e5903 100644 --- a/slirp/libslirp.h +++ b/slirp/libslirp.h @@ -3,7 +3,6 @@ #include "qemu-common.h"

[Qemu-devel] [PATCH v3] target/xtensa: use libisa for instruction decoding

Replace manual opcode analysis with libisa-based code. This makes it possible to support variable-encoding instructions of the core ISA, like const16, and will allow to support advanced Xtensa features, like FLIX and TIE. Signed-off-by: Max Filippov --- Changes v2->v3: - drop

Re: [Qemu-devel] [PATCH v5 3/7] vhost: Simplify ring verification checks

* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 18 Dec 2017 20:13:36 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > vhost_verify_ring_mappings() were used to verify that > > rings are still accessible

[Qemu-devel] [PATCH 2/7] net/eth: use the QEMU_PACKED macro

--- include/net/eth.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/include/net/eth.h b/include/net/eth.h index 09054a506d..87c6499f18 100644 --- a/include/net/eth.h +++ b/include/net/eth.h @@ -36,12 +36,12 @@ struct eth_header { uint8_t

[Qemu-devel] [PATCH 3/7] net/rocker: use QEMU_PACKED and QEMU_ALIGNED() macros

Signed-off-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker_hw.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/rocker/rocker_hw.h b/hw/net/rocker/rocker_hw.h index 1786323fa4..8b4ce250d5 100644 --- a/hw/net/rocker/rocker_hw.h +++

[Qemu-devel] [PATCH 7/7] i386/pc: use the QEMU_ALIGNED() macro

Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 3fcf318a95..85d9454c71 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -93,12 +93,12 @@ struct e820_entry {

Re: [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)

On 08/01/2018 19:02, Philippe Mathieu-Daudé wrote: > /* Data in mem is always in the byte order of the controller (le). > * It must be dword aligned to allow direct access to 32 bit values. */ > -uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED(8); > +uint8_t mem[PCI_MEM_SIZE]

Re: [Qemu-devel] [PATCH v2 0/2] pxa2xx_timer: ignore incorrect registers access to use U-Boot

On 01/08/2018 11:52 AM, Peter Maydell wrote: > On 3 January 2018 at 22:42, Philippe Mathieu-Daudé wrote: >> since v1: >> - fixed qemu_log_mask() lines indentation (Alistair) >> - added Alistair's R-b >> >> tiny patches that allow to boot a Gumstix Connex board and use U-Boot. >

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

On 01/08/2018 07:20 AM, Peter Lieven wrote: > Am 08.01.2018 um 04:09 schrieb Fam Zheng: >> After the out label there is a check on iTask.task but it is not >> initialized yet. >> >> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 >> Signed-off-by: Fam Zheng >> --- >>  

Re: [Qemu-devel] [PULL v3 00/35] Block layer patches

On 22 December 2017 at 15:18, Kevin Wolf wrote: > The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 > 00:11:36 +) > > are available in

Re: [Qemu-devel] [PULL 00/18] Net patches

On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote: > Applied, thanks. > > PS: just noticed, but "Ed Swierk via Qemu-devel " > is a bit of an odd Author string to end up in git commit logs, so you > and/or Ed might like to fix that up for any future patches. > > >

Re: [Qemu-devel] [Qemu-block] Raw notes from a small block layer/QAPI/something pre-christmas meeting

On Wed, Dec 20, 2017 at 19:15:55 +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Dec 15, 2017 at 05:38:00PM +0100, Max Reitz wrote: > > > >> Image creation in qemu-system-* vs. qemu-img: > >> In order to get proper introspection for qemu-img

Re: [Qemu-devel] [Qemu-block] [PATCH v2 08/19] block: Don't block_job_pause_all() in bdrv_drain_all()

On Thu 21 Dec 2017 03:22:40 PM CET, Kevin Wolf wrote: > Block jobs are already paused using the BdrvChildRole drain callbacks, > so we don't need an additionall block_job_pause_all() call. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 0/2] pxa2xx_timer: ignore incorrect registers access to use U-Boot

On 8 January 2018 at 15:05, Philippe Mathieu-Daudé wrote: > I'm adding a sticker to my monitor "build with > --enable-trace-backends=simple" before sending a series with new trace > events. I think it would be better to try to harden the log backend for trace and our log.h so

Re: [Qemu-devel] [PULL 00/18] Net patches

On 01/08/2018 09:10 AM, Eric Blake wrote: > On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote: > >> Applied, thanks. >> >> PS: just noticed, but "Ed Swierk via Qemu-devel " >> is a bit of an odd Author string to end up in git commit logs, so you >> and/or Ed might like

Re: [Qemu-devel] [Qemu-block] [PATCH v2 07/19] test-bdrv-drain: Test drain vs. block jobs

On Thu 21 Dec 2017 03:22:39 PM CET, Kevin Wolf wrote: > Block jobs must be paused if any of the involved nodes are drained. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PULL 00/18] Net patches

On 01/08/2018 09:18 AM, Eric Blake wrote: > Hmm - we probably ought to enhance checkpatch.pl to insist that patches > attributed to qemu-devel@nongnu.org as the author should be flagged as > invalid, since the list munging is a 1:M mapping rather than 1:1, and > therefore not easily invertable.

[Qemu-devel] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

in case of unaligned requests or on a target that does not support block provisioning we leave iTask uninitialized and check iTask.task for NULL later. Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

Am 18.12.2017 um 06:00 hat Hikaru Nishida geschrieben: > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_pulse(). > > Signed-off-by: Hikaru

[Qemu-devel] [PULL 3/3] block/nbd: fix segmentation fault when .desc is not null-terminated

From: Murilo Opsfelder Araujo The find_desc_by_name() from util/qemu-option.c relies on the .name not being NULL to call strcmp(). This check becomes unsafe when the list is not NULL-terminated, which is the case of nbd_runtime_opts in block/nbd.c, and can result in

[Qemu-devel] [PULL 2/3] nbd/server: Optimize final chunk of sparse read

If we are careful to handle 0-length read requests correctly, we can optimize our sparse read to send the NBD_REPLY_FLAG_DONE bit on our last OFFSET_DATA or OFFSET_HOLE chunk rather than needing a separate chunk. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 0/3] NBD patches through 2018-01-08

The following changes since commit 799044b6a3a0fc63e1e020e4d9266786a2dc7a0b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2018-01-08 13:44:01 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-01-08 for you to

Re: [Qemu-devel] [PATCH 07/12] slirp: remove unnecessary

The subject is missing a word or two. Thomas

[Qemu-devel] [Bug 1721220] Re: qemu crashes with assertion error `!mr->container' failed

As per previous comments, this bug was fixed by commit https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d659d94013390238961fac741572306c95496bf5 (released in QEMU v2.11.0): commit d659d94013390238961fac741572306c95496bf5 Author: Aleksandr Bezzubikov Date: Mon Sep 25 02:21:58

Re: [Qemu-devel] [PATCH] MAINTAINERS: update Dmitry Fleytman email

Thanks Philippe, My patch is hanging on the list for some time already: http://lists.nongnu.org/archive/html/qemu-trivial/2017-12/msg00189.html ~Dmitry. > On 8 Jan 2018, at 20:34, Philippe Mathieu-Daudé wrote: > > gently asked by his automatic reply :) > > Signed-off-by:

[Qemu-devel] [Bug 1310714] Re: User mode networking SLIRP rapid memory leak

** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1310714 Title: User mode networking SLIRP rapid memory leak Status in QEMU: Triaged Bug

[Qemu-devel] how to pass pcid to guest?

Hello, for meltdown mitigation and performance it's important to have the pcid flag passed down to the guest (f.e. https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L9mHTbeQLNU). My host shows the flag: # grep ' pcid ' /proc/cpuinfo | wc -l 56 But the guest does not: # grep pcid

Re: [Qemu-devel] [PATCH 08/12] slirp: removed unused code

On 08.01.2018 18:29, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > slirp/ip.h | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/slirp/ip.h b/slirp/ip.h > index e29ccd3c9f..71c3642cfe 100644 > --- a/slirp/ip.h > +++

[Qemu-devel] [PULL] qemu-sparc updates

Hi Peter, Here is the first set of SPARC updates for 2.12. Please pull. ATB, Mark. The following changes since commit 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171229' into staging (2018-01-08 16:17:04 +) are available in

Re: [Qemu-devel] [PATCH] Remove MemoryRegionSection check code from sparc_cpu_get_phys_page_debug()

On 06/12/17 20:24, Jean-Christophe DUBOIS wrote: Le 04/12/2017 à 21:45, Mark Cave-Ayland a écrit : On 27/11/17 20:19, Jean-Christophe DUBOIS wrote: Hello Mark, Did you get any second opinion on this? Also do you need me to resend the patch with the SPARC keyword in the patch subject line?

Re: [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180108172904.8772-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

Hi Kevin. On 2017-12-22 05:52, Kevin Wolf wrote: Am 22.12.2017 um 01:11 hat Jack Schwartz geschrieben: BLOCK_IO_ERROR events currently contain a "reason" string which is strerror(errno) of the error. This enhancement provides those events with the numeric errno value as well, since it is

Re: [Qemu-devel] [PATCH 7/7] i386/pc: use the QEMU_ALIGNED() macro

On 08/01/2018 20:02, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 3fcf318a95..85d9454c71 100644 --- a/hw/i386/pc.c +++

Re: [Qemu-devel] Getting rid of phys_mem_set_alloc

On 08/01/2018 18:05, Cornelia Huck wrote: On Sun, 7 Jan 2018 14:32:21 +0200 Marcel Apfelbaum wrote: Looking at the churn below... Hi Cornelia, Thanks for looking at the patch. diff --git a/exec.c b/exec.c index 4722e521d4..247f8bd0c0 100644 --- a/exec.c +++ b/exec.c @@

Re: [Qemu-devel] [PATCH 06/12] slirp: remove unused header

On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > slirp/slirp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/slirp/slirp.h b/slirp/slirp.h > index 9a7287e7cc..447dc045a8 100644 > --- a/slirp/slirp.h > +++

Re: [Qemu-devel] [SPARC] question on LEON IRQMP interrupt controller.

On 02/01/18 11:13, Jean-Christophe DUBOIS wrote: Hi Mark, Artyom, I am wondering if the IRQMP code in hw/intc/grlib_irqmp.c is correct when it comes to acknowledging interrupts. With the actual code an interrupt can be lowered/acked only by an "ack" from the processor which means that the

[Qemu-devel] What's needed to pass pciid cpu flag to guest?

Hello, for meltdown mitigation and performance it's important to have the pcid flag passed down to the guest (f.e. https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L9mHTbeQLNU). My host shows the flag: # grep ' pcid ' /proc/cpuinfo | wc -l 56 But the guest does not: # grep pcid

[Qemu-devel] [PATCH v2 2/2] qemu-img: info: try -U automatically

The error message we had didn't have a hint about "-U" when locking the image failed, which is not friendly. Also it is imaginable that the reaction to that error by the user would be a retry with '-U'. So the reason we require "-U" for "qemu-img info" if the image is used is to raise the

[Qemu-devel] [PATCH v2 1/2] qemu-img: Move img_open error reporting to callers

In the next patch one caller will have a special error handling logic rather than reporting it. Add "Error **" parameters to functions and give control back to callers, to make that possible. Update iotests output accordingly. Reviewed-by: Eric Blake Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v2 0/2] qemu-img: Let "info" warn and go ahead without -U

v2: Add Eric's r-b lines after making suggested tweaks to commit logs and error messages. Management and users are accustomed to "qemu-img info" to query status of images even when they are used by guests. Since image locking was added, the -U (--force-share) option is needed for that to

Re: [Qemu-devel] [PATCH v7 09/20] parallels: Switch to .bdrv_co_block_status()

On Fri, 01/05 16:57, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the parallels driver accordingly. Note that > the internal function block_status() is still sector-based, because > it is still in use by other sector-based functions;

Re: [Qemu-devel] [PULL 00/12] 9p patches for 2.12 20170106

On Fri, 5 Jan 2018 17:22:31 -0800 (PST) no-re...@patchew.org wrote: > CC hw/acpi/bios-linker-loader.o > In file included from /tmp/qemu-test/src/fsdev/qemu-fsdev.h:17, > from /tmp/qemu-test/src/fsdev/qemu-fsdev-dummy.c:15: > /tmp/qemu-test/src/fsdev/file-op-9p.h:98: error:

Re: [Qemu-devel] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status()

On Fri, 01/05 16:57, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the iscsi driver accordingly. In this case, > it is handy to teach iscsi_co_block_status() to handle a NULL map > and file parameter, even though the block layer

Re: [Qemu-devel] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based

On Fri, 01/05 16:57, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert all uses of > the allocmap (no semantic change). Callers that already had bytes > available are simpler, and callers that now scale to

  1   2   3   >