Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: > > git-publish [1] is a convenient tool to send patches and has been > > popular among QEMU developers. Recently it has been made available in > >

[Qemu-devel] [PATCH v3 02/19] Clean up includes

Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the change to target/s390x/gen-features.c manually reverted, and blank lines around deletions collapsed. Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > explaining that share-rw=on can be used safely with format=raw if the > > guests are configured to

Re: [Qemu-devel] Savevm and loadvm not working

On Tuesday, January 30, 2018 5:25 PM, Peter Xu wrote: On Tue, Jan 30, 2018 at 10:34:31AM +, sridhar kulkarni via Qemu-devel wrote: > Hi, > I am new bee to snapshot feature and how to use it correctly. My requirement > is simple, in that I want to snapshot the

Re: [Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

On 31/01/2018 12:44, Cornelia Huck wrote: On Tue, 30 Jan 2018 10:47:15 +0100 Yi Min Zhao wrote: When registering ioat, pba should be comprised of leftmost 52 bits and rightmost 12 binary zeros, and pal should be comprised of leftmost 52 bits and right most 12 binary

[Qemu-devel] [PATCH v3 12/19] Include qapi/qmp/qdict.h exactly where needed

This cleanup makes the number of objects depending on qapi/qmp/qdict.h drop from 4550 (out of 4743) to 368 in my "build everything" tree. For qapi/qmp/qobject.h, the number drops from 4552 to 390. While there, separate #include from file comment with a blank line. Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v2 2/2] s390x/cpumodel: allow zpci features in qemu model

On 31.01.2018 19:17, Cornelia Huck wrote: > AEN can be provided unconditionally, ZPCI should be turned on > manually. > > With -cpu qemu,zpci=on, a 4.15 guest kernel can now successfully > detect virtio-pci devices under tcg. > > Signed-off-by: Cornelia Huck > --- >

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

On Thu, 1 Feb 2018 13:42:52 +0100 David Hildenbrand wrote: > On 31.01.2018 19:17, Cornelia Huck wrote: > > +#ifndef CONFIG_USER_ONLY > > +void HELPER(clp)(CPUS390XState *env, uint32_t r2) > > +{ > > +S390CPU *cpu = s390_env_get_cpu(env); > > +int r; > > + > > +

Re: [Qemu-devel] [PULL 00/13] Migration PULL request

On 30/01/2018 07:29, Juan Quintela wrote: > Peter Maydell wrote: >> On 29 January 2018 at 12:09, Juan Quintela wrote: >>> Hi >>> >>> - migrate_fd_connect cleanup (dave) >>> - use MAX_VM_PACKAGED_SIZE >>> have to change (1<<32) for UINT32_MAX to

[Qemu-devel] [PATCH] hw/audio/sb16.c: change dolog() to qemu_log_mask()

Changes all the occurrances of dolog() to qemu_log_mask(). Signed-off-by: John Arbuckle --- hw/audio/sb16.c | 105 1 file changed, 53 insertions(+), 52 deletions(-) diff --git a/hw/audio/sb16.c

Re: [Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues

On Mon, Jan 29, 2018 at 05:16:46AM +0100, Jon Emil Jahren wrote: > There are some issues with the argument parsing for ust. > The first issue is that the regex pattern matching arguments with PRI > types matched too much. This was fixed by using a non-greedy star, > instead of a greedy. > The

Re: [Qemu-devel] vhost-user question

that is what i really want to know,thanks very very much!!! from jack chen On 2/1/2018 18:30，[1]Dr. David Alan Gilbert wrote： * jack.chen (zhun...@gmail.com) wrote: > Thanks,But my question is how the fd belonging to qemu can be used in >

Re: [Qemu-devel] [PATCH] vnc: use stubs for CONFIG_VNC=n dummy functions

Gerd Hoffmann writes: > Cc: Markus Armbruster > Signed-off-by: Gerd Hoffmann Cool! Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v3 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h

Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- backends/cryptodev.c | 1 - backends/hostmem.c | 1 - hmp.h| 1 -

[Qemu-devel] [PATCH v3 15/19] Include qapi/qmp/qnum.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- tests/check-qlit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/check-qlit.c b/tests/check-qlit.c index f012885534..5d0f65b9c7

[Qemu-devel] [PATCH v3 00/19] Clean up includes to reduce compile time

We have awfully many "touch it, recompile the world" headers. Right now, I count about fifty that are prerequisites of more than half the objects in my "build everything" tree. Some of them are that way by necessity. Many of them are not. This series takes care of six I happen to touch,

[Qemu-devel] [PATCH v3 16/19] Include qapi/qmp/qnull.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- target/ppc/translate.c | 1 - target/ppc/translate_init.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 01/19] Use #include "..." for our own headers, <...> for others

System headers should be included with <...>, our own headers with "...". Offenders tracked down with an ugly, brittle and probably buggy Perl script. Previous iteration was commit a9c94277f0. Delete inclusions of "string.h" and "strings.h" instead of fixing them to and , because we always

[Qemu-devel] [PATCH v3 04/19] Include qapi/error.h exactly where needed

This cleanup makes the number of objects depending on qapi/error.h drop from 1910 (out of 4743) to 1612 in my "build everything" tree. While there, separate #include from file comment with a blank line, and drop a useless comment on why qemu/osdep.h is included first. Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

On 01/02/2018 12:28, Yi Min Zhao wrote: 在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4)

Re: [Qemu-devel] Savevm and loadvm not working

On 1 February 2018 at 12:19, sridhar kulkarni via Qemu-devel wrote: > I thought that RAM contents are not saved because of return value > RAM_SAVE_CONTROL_NOT_SUPP. Now that you clarified about this, I debugged this > further. After doing loadvm operation, I am getting

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

On Thu, Feb 01, 2018 at 11:48:31AM +0100, Christoffer Dall wrote: > On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > > > If you could use dirty page tracking

Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

On 02/01/2018 01:12 AM, Markus Armbruster wrote: >>> + >>> #include "qemu/osdep.h" >>> +#include >> >> is an obsolete spelling for the now-universal . We >> should NEVER need to include it; scripts/clean-includes should be taught >> to blacklist this one. > > "Programming today is a race

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

On 01/02/2018 08:47, Gonglei wrote: > As windows guest use rtc as the clock source device, > and access rtc frequently. Let's move the rtc memory > region outside BQL to decrease overhead for windows guests. > > strace -tt -p $1 -c -o result_$1.log & > sleep $2 > pid=$(pidof strace) > kill $pid >

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

On Thu, 1 Feb 2018 11:00:09 +0100 Pierre Morel wrote: > On 31/01/2018 19:17, Cornelia Huck wrote: > > On s390x, pci support is implemented via a set of instructions > > (no mmio). Unfortunately, none of them are documented in the > > PoP; the code is based upon the

Re: [Qemu-devel] [PATCH v3 18/39] qcow2: Refactor get_cluster_table()

On Wed 31 Jan 2018 09:11:48 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> After the previous patch we're now always using l2_load() in >> get_cluster_table() regardless of whether a new L2 table has to be >> allocated or not. >> >> This patch refactors that part of the

[Qemu-devel] [PATCH v2] vcpu: join vcpu thread after it exiting

As we create vcpu thread with QEMU_THREAD_JOINABLE mode, we should join it after it exiting to cleanup resources. Signed-off-by: linzhecheng diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f290f48..5cc1ba2 100644 --- a/accel/kvm/kvm-all.c +++

[Qemu-devel] [PULL 1/1] dump-guest-memory.py: skip vmcoreinfo section if not available

On some architectures, qemu doesn't support vmcoreinfo device, and dump-guest-memory fails: (gdb) dump-guest-memory /tmp/vmcore ppc64-le guest RAM blocks: target_start target_end host_addrmessage count --- -

[Qemu-devel] [PULL 0/1] Dump patches

The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/dump-pull-request for

[Qemu-devel] [PATCH] vl: fix possible int overflow for qemu_timedate_diff()

From: shenghualong When the Windows guest users set the time to year 2099, the return value of qemu_timedate_diff() will overflow with variable clock mode as below format: Let's change the return value of qemu_timedate_diff() from int to time_t to fix the possible

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is detected, the check list is cleared. If all the ungrab keys are detected the ungrab code is

[Qemu-devel] [PATCH v7 7/7] tests: use memfd in vhost-user-test

This will exercise the memfd memory backend and should generally be better for testing than memory-backend-file (thanks to anonymous files and sealing). If memfd is available, it is preferred. However, in order to check that file & memfd backends both work correctly, the read-guest-mem test is

[Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

As windows guest use rtc as the clock source device, and access rtc frequently. Let's move the rtc memory region outside BQL to decrease overhead for windows guests. strace -tt -p $1 -c -o result_$1.log & sleep $2 pid=$(pidof strace) kill $pid cat result_$1.log Before appling this change: %

[Qemu-devel] [PATCH] tests/test-filter-redirector: move close()

Since we have separate handler on POLLHUP, which drops data after closing the connection we need to fix this test, because it sends data and instantly close the socket creating race condition. In some cases on other end of socket client closes it faster than reads data. To prevent it I suggest to

[Qemu-devel] [PATCH] block: fix write with zero flag set and iovector provided

The normal bdrv_co_pwritev() use is either - BDRV_REQ_ZERO_WRITE reset and iovector provided - BDRV_REQ_ZERO_WRITE set and iovector == NULL while - the flag reset and iovector == NULL is an assertion failure in bdrv_co_do_zero_pwritev() - the flag set and iovector provided is in fact

Re: [Qemu-devel] [PATCH v2 5/6] block: Handle null backing link

On Sat 20 Jan 2018 04:44:11 PM CET, Max Reitz wrote: > Instead of converting all "backing": null instances into "backing": "", > handle a null value directly in bdrv_open_inherit(). > > This enables explicitly null backing links for json:{} filenames. > > Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

On Wed, 31 Jan 2018 19:17:41 +0100 Cornelia Huck wrote: > +void HELPER(sic)(CPUS390XState *env, uint64_t r1, uint64_t r3) > +{ > +int r; > + > +qemu_mutex_lock_iothread(); > +r = css_do_sic(env, r1 & 0x, (r3 >> 27) & 0x7); Here, the arguments have to be

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn

On 18/01/2018 15:19, Eric Blake wrote: > On 01/18/2018 06:43 AM, Paolo Bonzini wrote: >> It is called from qcow2_invalidate_cache in coroutine context (incoming > Why is a qcow2 function calling qed code? Definitely a copy-paste bug, > but I'm not sure of the right fix. This reference was of

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > wrote: > > > On 1 February 2018 at 09:17, Christoffer Dall > > >

Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

On Wed, Jan 31, 2018 at 03:31:27PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 14:56 hat Stefan Hajnoczi geschrieben: > > On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote: > > > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > > > > Commit

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

Hi Peter, On 01/02/2018 13:20, Peter Xu wrote: > In the past, we prioritized IOMMU migration so that we have such a > priority order: > > IOMMU > PCI Devices > > When migrating a guest with both vIOMMU and pcie-root-port, we'll always > migrate vIOMMU first, since pcie-root-port will be

Re: [Qemu-devel] [PATCH v3 12/18] s390x: fix size + content of STSI blocks

On Mon, 29 Jan 2018 13:56:17 +0100 David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 4:22, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: > >> On Wed, Jan 31, 2018 at 11:10:07PM +0200, Michael S. Tsirkin wrote: > >>> On Wed, Jan 31, 2018 at 06:40:59PM

[Qemu-devel] [PATCH v7 5/7] tests: keep compiling failing vhost-user tests

Let's protect the failing tests under a QTEST_VHOST_USER_FIXME environment variable, so we keep compiling the tests and we can easily run them. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 27 ++- 1 file changed, 14

[Qemu-devel] [PATCH v7 3/7] memfd: add hugetlbsize argument

Learn to specificy hugetlb size as qemu_memfd_create() argument. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 2 +- util/memfd.c | 22 ++ 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/include/qemu/memfd.h

[Qemu-devel] [PATCH v7 6/7] vhost-user-test: make read-guest-mem setup its own qemu

Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 713ff5c5c6..a22075ff26 100644 ---

Re: [Qemu-devel] [PATCH v2 2/2] s390x/cpumodel: allow zpci features in qemu model

On Thu, 1 Feb 2018 13:31:46 +0100 David Hildenbrand wrote: > On 31.01.2018 19:17, Cornelia Huck wrote: > > AEN can be provided unconditionally, ZPCI should be turned on > > manually. > > > > With -cpu qemu,zpci=on, a 4.15 guest kernel can now successfully > > detect virtio-pci

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

On Thu, Feb 01, 2018 at 02:29:25PM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 14:10, Eduardo Habkost wrote: > > On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > >> On 01/02/2018 4:22, Michael S. Tsirkin wrote: > >>> On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost

Re: [Qemu-devel] [PATCH] block: fix write with zero flag set and iovector provided

On 02/01/2018 08:16 AM, Anton Nefedov wrote: > The normal bdrv_co_pwritev() use is either > - BDRV_REQ_ZERO_WRITE reset and iovector provided s/reset/clear/ > - BDRV_REQ_ZERO_WRITE set and iovector == NULL > > while > - the flag reset and iovector == NULL is an assertion failure again >

Re: [Qemu-devel] [PATCH v2] vcpu: join vcpu thread after it exiting

On 01/02/2018 06:04, linzhecheng wrote: > As we create vcpu thread with QEMU_THREAD_JOINABLE mode, > we should join it after it exiting to cleanup resources. > > Signed-off-by: linzhecheng > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

This bug was fixed in the package libvirt - 4.0.0-1ubuntu1 --- libvirt (4.0.0-1ubuntu1) bionic; urgency=medium * Merged with Debian unstable (4.0) This closes several bugs: - Error generating apparmor profile when hostname contains spaces (LP: #77) - qemu 2.10

[Qemu-devel] [PATCH v3 08/19] Eliminate qapi/qmp/types.h

qapi/qmp/types.h is a convenience header to include a number of qapi/qmp/ headers. Since we rarely need all of the headers qapi/qmp/types.h includes, we bypass it most of the time. Most of the places that use it don't need all the headers, either. Include the necessary headers directly, and

Re: [Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

On Thu, 1 Feb 2018 12:33:01 +0100 Pierre Morel wrote: > On 31/01/2018 12:44, Cornelia Huck wrote: > > On Tue, 30 Jan 2018 10:47:15 +0100 > > Yi Min Zhao wrote: > > > >> When registering ioat, pba should be comprised of leftmost 52 bits and

Re: [Qemu-devel] MTTCG External Halt

Alistair Francis writes: > On Wed, Jan 31, 2018 at 12:32 PM, Alex Bennée wrote: >> >> Alistair Francis writes: >> >>> On Tue, Jan 30, 2018 at 8:26 PM, Paolo Bonzini wrote: On

Re: [Qemu-devel] [PATCH v6 10/23] sev: add command to initialize the memory encryption context

* Brijesh Singh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, KVM_SEV_INIT command is used to > initialize the platform. The command loads the SEV related persistent > data from non-volatile storage and initializes the platform context. > This command should be first issued

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

On 31.01.2018 19:17, Cornelia Huck wrote: > On s390x, pci support is implemented via a set of instructions > (no mmio). Unfortunately, none of them are documented in the > PoP; the code is based upon the existing implementation for KVM > and the Linux zpci driver. > > Signed-off-by: Cornelia Huck

[Qemu-devel] [PATCH v7 1/7] memfd: add error argument, instead of perror()

This will allow callers to silence error report when the call is allowed to failed. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 5 +++-- hw/virtio/vhost.c| 8 +++- util/memfd.c | 57

[Qemu-devel] [Bug 1703795] Re: Unable to release mouse in SDL2 mode

I'm also seeing this problem with -vga vmware in case that matters. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1703795 Title: Unable to release mouse in SDL2 mode Status in QEMU: New Bug

[Qemu-devel] [PATCH 4/6] cpus: tcg: unregister thread with RCU, fix exiting of loop on unplug

Keep running until cpu_can_run(cpu) becomes false, for consistency with other acceslerators. Signed-off-by: Paolo Bonzini --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 34c86192d1..9f48ccad9e 100644 ---

[Qemu-devel] [PATCH 6/6] cpus: join thread when removing a vCPU

If no one joins the thread, its associated memory is leaked. Reported-by: CheneyLin Signed-off-by: Paolo Bonzini --- cpus.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 03b4533b7d..e8c3ba064c

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > wrote: > > On 1 February 2018 at 09:17, Christoffer Dall > > wrote: > >> On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel >

[Qemu-devel] [PATCH v3 09/19] qdict qlist: Make most helper macros functions

The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h and qnum.h in the headers, but not qbool.h and qstring.h. Works, because we include those wherever the macros get used. Open-coding these helpers is of

[Qemu-devel] [PATCH v3 18/19] Drop superfluous includes of qapi/qmp/qjson.h

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- balloon.c | 1 - block/nbd.c | 1 - block/quorum.c | 1 - blockjob.c

[Qemu-devel] [PATCH v3 11/19] Include qapi/qmp/qlist.h exactly where needed

This cleanup makes the number of objects depending on qapi/qmp/qlist.h drop from 4551 (out of 4743) to 16 in my "build everything" tree. While there, separate #include from file comment with a blank line. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) format control

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Hi Michael, I am wondering whether this version is OK for you? Any comment will be appreciated, thanks. Regards, Jay > -Original Message- > From: Zhoujian (jay) > Sent: Sunday, January 21, 2018 8:55 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; Huangweidong

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

On Wed, 31 Jan 2018, David Gibson wrote: On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote: This matches what other files do for qemu includes Signed-off-by: BALATON Zoltan Applied, thanks. Thanks but Markus instead included this in his cleanup patches

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

On Thu, 1 Feb 2018 12:56:01 +0100 Pierre Morel wrote: > On 01/02/2018 12:28, Yi Min Zhao wrote: > > > > > > 在 2018/1/31 下午6:58, Cornelia Huck 写道: > >> On Tue, 30 Jan 2018 10:47:13 +0100 > >> Yi Min Zhao wrote: > >>> diff --git

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

On 01/02/2018 14:10, Eduardo Habkost wrote: > On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: >> On 01/02/2018 4:22, Michael S. Tsirkin wrote: >>> On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: > [...] BTW, what's the root cause for requiring HVAs in the

[Qemu-devel] [PATCH v3 14/19] Include qapi/qmp/qbool.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c| 1 - block/blkdebug.c | 1 - block/curl.c | 1 - block/qcow2.c

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

On 01.02.2018 13:48, Cornelia Huck wrote: > On Thu, 1 Feb 2018 13:42:52 +0100 > David Hildenbrand wrote: > >> On 31.01.2018 19:17, Cornelia Huck wrote: > >>> +#ifndef CONFIG_USER_ONLY >>> +void HELPER(clp)(CPUS390XState *env, uint32_t r2) >>> +{ >>> +S390CPU *cpu =

Re: [Qemu-devel] [PATCH 2/3] s390x/pci: fixup global refresh

On 31/01/2018 12:35, Cornelia Huck wrote: On Tue, 30 Jan 2018 10:47:14 +0100 Yi Min Zhao wrote: The VFIO common code doesn't provide the possibility to modify a previous mapping entry in another way than unmapping and mapping again with new properties. I'm

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

> On Feb 1, 2018, at 7:16 AM, BALATON Zoltan wrote: > > On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is

[Qemu-devel] [PATCH v7 2/7] memfd: add hugetlb support

Linux commit 749df87bd7bee5a79cef073f5d032ddb2b211de8 (v4.14-rc1) added a new flag MFD_HUGETLB to memfd_create() that specify the file to be created resides in the hugetlbfs filesystem. This is the generic hugetlbfs filesystem not associated with any specific mount point. hugetlbfs does not

[Qemu-devel] [PATCH v7 4/7] Add memfd based hostmem

Add a new memory backend, similar to hostmem-file, except that it doesn't need to create files. It also enforces memory sealing. This backend is mainly useful for sharing the memory with other processes. Note that Linux supports transparent huge-pages of shmem/memfd memory since 4.8. It is

[Qemu-devel] [PATCH v7 0/7] Add memfd memory backend

Hi, This series adds a new memory backend, similar to hostmem-file, except that it doesn't need to create files. It also enforces memory sealing. This backend is mainly useful for sharing the memory with other processes. Note that Linux supports transparent huge-pages of shmem/memfd memory

Re: [Qemu-devel] [PATCH v7 4/9] block: treat BDRV_REQ_ALLOCATE as serialising

On Wed 31 Jan 2018 06:11:27 PM CET, Anton Nefedov wrote: > On 31/1/2018 6:11 PM, Alberto Garcia wrote: >> On Thu 18 Jan 2018 06:49:02 PM CET, Anton Nefedov wrote: >> >>> -static bool coroutine_fn wait_serialising_requests(BdrvTrackedRequest >>> *self) >>> +static bool coroutine_fn

Re: [Qemu-devel] [PATCH] tests/test-filter-redirector: move close()

On 01/02/2018 08:48, Klim Kireev wrote: > Since we have separate handler on POLLHUP, which drops data > after closing the connection we need to fix this test, because > it sends data and instantly close the socket creating race condition. > In some cases on other end of socket client closes it

[Qemu-devel] [PATCH v3 13/19] Include qapi/qmp/qstring.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c | 1 + include/qapi/qmp/qjson.h| 2 -- monitor.c | 1 +

[Qemu-devel] [PATCH v3 07/19] Typedef the subtypes of QObject in qemu/typedefs.h, too

This renders many inclusions of qapi/qmp/q*.h superfluous. They'll be dropped in the next few commits. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- include/qapi/qmp/qbool.h | 4 ++--

[Qemu-devel] [PATCH v3 10/19] Include qapi/qmp/qobject.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- include/block/block.h | 1 - include/qapi/qmp/dispatch.h | 1 - include/qapi/qmp/qjson.h | 1 -

Re: [Qemu-devel] Windows balloon driver PFN issue

On Thu, Feb 01, 2018 at 10:33:50AM +0800, Peter Xu wrote: > On Thu, Feb 01, 2018 at 04:24:40AM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 01, 2018 at 10:18:53AM +0800, Peter Xu wrote: > > > On Wed, Jan 31, 2018 at 04:03:12PM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Jan 31, 2018 at

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

On 01/02/2018 13:15, Cornelia Huck wrote: On Thu, 1 Feb 2018 12:56:01 +0100 Pierre Morel wrote: On 01/02/2018 12:28, Yi Min Zhao wrote: 在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: diff

Re: [Qemu-devel] [PATCH v3 00/18] s390x: flic rework, tcg flic support and STSI

On Mon, 29 Jan 2018 13:56:05 +0100 David Hildenbrand wrote: > This patch series implements floating interrupt support for TCG and fixes > STSI so we can remove warnings related to s390x SMP and MTTCG. > > KVM code has to be touched in order to factor out the injection routines

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

On Thu, Feb 01, 2018 at 02:29:25PM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 14:10, Eduardo Habkost wrote: > > On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > >> On 01/02/2018 4:22, Michael S. Tsirkin wrote: > >>> On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost

Re: [Qemu-devel] [PATCH v2 6/6] block: Deprecate "backing": ""

On Sat 20 Jan 2018 04:44:12 PM CET, Max Reitz wrote: > We have a clear replacement, so let's deprecate it. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: change dolog() to qemu_log_mask()

On Thu, Feb 01, 2018 at 08:33:47AM -0500, John Arbuckle wrote: > Changes all the occurrances of dolog() to qemu_log_mask(). When looking over them it looks like we should not just switch them over the same way, but try to categorize them a bit better ... > +#include "qemu/log.h" > > #define

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix write with zero flag set and iovector provided

On 1/2/2018 5:29 PM, Alberto Garcia wrote: On Thu 01 Feb 2018 03:16:31 PM CET, Anton Nefedov wrote: The normal bdrv_co_pwritev() use is either - BDRV_REQ_ZERO_WRITE reset and iovector provided - BDRV_REQ_ZERO_WRITE set and iovector == NULL while - the flag reset and iovector == NULL

[Qemu-devel] [PATCH 1/6] cpus: hax: register/unregister thread with RCU, exit loop on unplug

Signed-off-by: Paolo Bonzini --- cpus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 1495ed5c36..231550a0d8 100644 --- a/cpus.c +++ b/cpus.c @@ -1474,6 +1474,7 @@ static void *qemu_hax_cpu_thread_fn(void *arg) CPUState

[Qemu-devel] [PATCH v2] vl: pause vcpus before stopping iothreads

Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all()

[Qemu-devel] [PATCH v3 19/19] Move include qemu/option.h from qemu-common.h to actual users

qemu-common.h includes qemu/option.h, but most places that include the former don't actually need the latter. Drop the include, and add it to the places that actually need it. While there, drop superfluous includes of both headers, and separate #include from file comment with a blank line. This

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 4:22, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: [...] > >> BTW, what's the root cause for requiring HVAs in the buffer? > > > > It's a side effect of the

Re: [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

On Wed 31 Jan 2018 09:07:48 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> This patch updates l2_allocate() to support the qcow2 cache returning >> L2 slices instead of full L2 tables. >> >> The old code simply gets an L2 table from the cache and initializes it >> with

Re: [Qemu-devel] [PATCH v7 3/9] block: introduce BDRV_REQ_ALLOCATE flag

On 31/1/2018 8:31 PM, Max Reitz wrote: On 2018-01-30 13:34, Anton Nefedov wrote: Offtop: does REQ_ZERO_WRITE override REQ_WRITE_COMPRESSED in this function? at least with !REQ_MAY_UNMAP it looks wrong Looks like zero detection will indeed override compression. I think that was intended, but

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix write with zero flag set and iovector provided

On Thu 01 Feb 2018 03:16:31 PM CET, Anton Nefedov wrote: > The normal bdrv_co_pwritev() use is either > - BDRV_REQ_ZERO_WRITE reset and iovector provided > - BDRV_REQ_ZERO_WRITE set and iovector == NULL > > while > - the flag reset and iovector == NULL is an assertion failure > in

Re: [Qemu-devel] [Qemu-block] [PATCH] block: fix write with zero flag set and iovector provided

On 02/01/2018 08:36 AM, Eric Blake wrote: > On 02/01/2018 08:16 AM, Anton Nefedov wrote: >> The normal bdrv_co_pwritev() use is either >> - BDRV_REQ_ZERO_WRITE reset and iovector provided > > s/reset/clear/ > >> - BDRV_REQ_ZERO_WRITE set and iovector == NULL >> >> while >> - the flag reset

Re: [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context

On 18/01/2018 07:43, Paolo Bonzini wrote: > Check and invalidate_cache share some parts of the implementation > with the regular I/O path. This is sometimes complicated because the > I/O path wants to use a CoMutex but that is not possible outside coroutine > context. By moving things to

[Qemu-devel] [PATCH 5/6] cpus: hvf: unregister thread with RCU

Signed-off-by: Paolo Bonzini --- cpus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpus.c b/cpus.c index 9f48ccad9e..03b4533b7d 100644 --- a/cpus.c +++ b/cpus.c @@ -1542,6 +1542,7 @@ static void *qemu_hvf_cpu_thread_fn(void *arg) cpu->created = false;

[Qemu-devel] [PATCH v3 06/19] Include qmp-commands.h exactly where needed

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c| 1 - blockjob.c | 1 - hw/acpi/acpi-stub.c| 1 - hw/ppc/spapr.c | 1 -

[Qemu-devel] [PATCH v3 05/19] Drop superfluous includes of qapi/qmp/qerror.h

Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- backends/tpm.c | 1 - block/qcow.c | 1 - block/qed.c| 1 - blockdev-nbd.c | 1 -

  1   2   3   4   >