From: Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with
error_report(). The functions were renamed with these commands and then
compiler issues where manually fixed.
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\))
On 02/02/2018 07:03 AM, Markus Armbruster wrote:
> Whenever qapi-schema.json changes, we run six programs eleven times to
> update eleven files. This is silly. Replace the six programs by a
> single program that spits out all eleven files.
Yay, about time!
One program, but still invoked multipl
On 02/02/2018 07:03 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-gen.py| 52 +++-
> scripts/qapi/common.py | 54
> --
> 2 files changed, 51 insertions(+), 55 de
I can confirm that the patch from comment #9 appears to fix the original
problem.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1703795
Title:
Unable to release mouse in SDL2 mode
Status in QEMU:
On 02/02/2018 12:37 PM, Markus Armbruster wrote:
> From: Alistair Francis
>
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
>
> Some lines where then manually tw
This should primarily go to the qemu devel list. I've Cc'd it, but
reposting would be safer, thanks.
2018-02-02 10:21+0530, P J P:
> From: Prasad J Pandit
>
> When updating message signalled interrupt(MSI) route in routine
> kvm_irqchip_update_msi_route, device parameter could be null.
> Add c
On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wang wrote:
> On 01/26/2018 10:44 PM, Stefan Hajnoczi wrote:
> > On Thu, Jan 25, 2018 at 06:19:13PM +0800, Wei Wang wrote:
> > > On 01/24/2018 07:40 PM, Stefan Hajnoczi wrote:
> > > > On Tue, Jan 23, 2018 at 09:06:49PM +0800, Wei Wang wrote:
> > > > > O
On 02/02/2018 07:03 AM, Markus Armbruster wrote:
> A massive number of objects depends on QAPI-generated headers. In my
> "build everything" tree, it's roughly 4500 out of 4800. This is
> particularly annoying when only some of the generated files change,
> say for a doc fix.
>
> Improve qapi-ge
Ensure that the post write hook is called during reset. This allows us
to rely on the post write functions instead of having to call them from
the reset() function.
Signed-off-by: Alistair Francis
---
hw/core/register.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/core/registe
On Fri, Feb 2, 2018 at 10:37 AM, Markus Armbruster wrote:
> This is my attempt to salvage a good part of Alistair's error
> reporting cleanup series
>
> [PATCH v6 00/29] Remove some of the fprintf(stderr, "*
>
> Continue on improving QEMUs logging/error messages by removing more
> fpr
Hi,
This series failed build test on ppc host. Please find the details below.
Subject: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code
Type: series
Message-id: 20180202130336.24719-1-arm...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the
On 02/02/2018 12:37 PM, Markus Armbruster wrote:
> From: Alistair Francis
>
> Convert fprintf(stderr, ...) to use qemu_log(). Double prints in
> target/ppc/translate.c were manually remove. A fprintf() in
> target/sh4/translate.c was kept as it's inside a #if 0. The #if 0 and
> fflush() was remov
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked und
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180202130336.24719-1-arm...@redhat.com
Subject: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under th
On 02/02/2018 03:37 PM, Markus Armbruster wrote:
> This is my attempt to salvage a good part of Alistair's error
> reporting cleanup series
>
> [PATCH v6 00/29] Remove some of the fprintf(stderr, "*
>
> Continue on improving QEMUs logging/error messages by removing more
> fprintf()'s
On 02/02/2018 07:03 AM, Markus Armbruster wrote:
> Error messages print absolute filenames of included files even gave a
s/even gave/even when given/
> relative one on the command line:
>
> PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py
> tests/qapi-schema/include-cycle.json
>
On 02/02/2018 03:37 PM, Markus Armbruster wrote:
> From: Alistair Francis
>
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
>
Hi Alistair,
On 02/02/2018 04:38 PM, Alistair Francis wrote:
> Ensure that the post write hook is called during reset. This allows us
> to rely on the post write functions instead of having to call them from
> the reset() function.
This makes sens. Can you add a comment about this new behavior in
Hi Thomas,
On 02/02/2018 05:15 AM, Thomas Huth wrote:
> When compiling with NVRAM_PRINTF enabled, gcc currently bails out with:
>
> CC hw/timer/m48t59.o
> CC hw/timer/m48t59-isa.o
> hw/timer/m48t59.c: In function ‘NVRAM_writeb’:
> hw/timer/m48t59.c:460:5: error: format ‘%x’ expects
Alistair Francis writes:
> On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis
> wrote:
>> On Thu, Feb 1, 2018 at 4:01 AM, Alex Bennée wrote:
>>>
>>> Alistair Francis writes:
>>>
On Wed, Jan 31, 2018 at 12:32 PM, Alex Bennée
wrote:
>
> Alistair Francis writes:
>
>> O
Hi,
This series failed docker-quick@centos6 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180202130336.24719-1-arm...@redhat.com
Subject: [Qemu-devel] [PATCH RFC 00/21] Modulari
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/1] respin
The IscsiAIOCB->buf field has not been used since commit
e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi
requirement to 1.9.0"). It used to be a linear buffer for old libiscsi
versions that didn't support scatter-gather. The minimum libiscsi
version supports scatter-gather s
Patches 1 & 2 are cleanups.
Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb is
cancelled and then completes twice. The second time around crashes QEMU.
Compile-tested only.
Felipe: Please let us know if this fixes the issue you are seeing. Thanks!
Stefan Hajnoczi
The ioctl request cancellation code assumes that requests do not
complete once TASK ABORT has been sent to the iSCSI target. The request
completion callback is unconditionally invoked when TASK ABORT finishes.
Therefore the request completion callback is invoked twice if the
request does happen to
Commit d045c466d9e62b4321fadf586d024d54ddfd8bd4 ("iscsi: do not use
aio_context_acquire/release") introduced iscsilun->mutex but appears to
have overlooked iscsi_timed_check_events() when introducing the mutex.
iscsi_service() and iscsi_set_events() must be called with
iscsilun->mutex held.
iscsi
Hi,
This series failed build test on ppc host. Please find the details below.
Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under
On Fri, Feb 2, 2018 at 12:37 PM, Alex Bennée wrote:
>
> Alistair Francis writes:
>
>> On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis
>> wrote:
>>> On Thu, Feb 1, 2018 at 4:01 AM, Alex Bennée wrote:
Alistair Francis writes:
> On Wed, Jan 31, 2018 at 12:32 PM, Alex Bennée
CCing qemu-block and Berto
On 02/02/2018 06:10 AM, Wolfgang Bumiller wrote:
> Summary:
> Rate limit is effectively halved when the size of written chunks adds up to
> exceeding the quota of a slice only slightly. This is surprisingly reliable.
>
> Explanation:
> The ratelimiting code in include/q
On Fri, Feb 2, 2018 at 10:16 PM, Stefan Hajnoczi wrote:
> The ioctl request cancellation code assumes that requests do not
> complete once TASK ABORT has been sent to the iSCSI target. The request
> completion callback is unconditionally invoked when TASK ABORT finishes.
> Therefore the request c
On Fri, Feb 2, 2018 at 1:49 PM, Alistair Francis
wrote:
> On Fri, Feb 2, 2018 at 12:37 PM, Alex Bennée wrote:
>>
>> Alistair Francis writes:
>>
>>> On Thu, Feb 1, 2018 at 9:13 AM, Alistair Francis
>>> wrote:
On Thu, Feb 1, 2018 at 4:01 AM, Alex Bennée wrote:
>
> Alistair Francis
On 02/02/2018 07:03 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/common.py | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virt
Hi,
This series failed docker-quick@centos6 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/1] respi
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180202143746.204851-1-borntrae...@de.ibm.com
Subject: [Qemu-devel] [PATCH v3 0/1] resp
On Fri, Feb 2, 2018 at 12:24 PM, Philippe Mathieu-Daudé wrote:
> Hi Alistair,
>
> On 02/02/2018 04:38 PM, Alistair Francis wrote:
>> Ensure that the post write hook is called during reset. This allows us
>> to rely on the post write functions instead of having to call them from
>> the reset() func
The patch works for me too. Thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1703795
Title:
Unable to release mouse in SDL2 mode
Status in QEMU:
New
Bug description:
Starting with commit
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180202130336.24719-1-arm...@redhat.com
Subject: [Qemu-devel] [PATCH RFC 00/21] Modular
Commit d045c466d9e62b4321fadf586d024d54ddfd8bd4 ("iscsi: do not use
aio_context_acquire/release") introduced iscsilun->mutex but appears to
have overlooked iscsi_timed_check_events() when introducing the mutex.
iscsi_service() and iscsi_set_events() must be called with
iscsilun->mutex held.
iscsi
iscsi_aio_cancel() does not increment the request's reference count,
causing a use-after-free when ABORT TASK finishes after the request has
already completed.
There are some additional issues with iscsi_aio_cancel():
1. Several ABORT TASKs may be sent for the same task if
iscsi_aio_cancel() is
v2:
* It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this
function already protects against duplicate calls internally [Stefan]
Patches 1 & 2 are cleanups.
Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb is
cancelled and then completes twice
The IscsiAIOCB->buf field has not been used since commit
e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi
requirement to 1.9.0"). It used to be a linear buffer for old libiscsi
versions that didn't support scatter-gather. The minimum libiscsi
version supports scatter-gather s
Eric Blake writes:
> On 02/02/2018 12:37 PM, Markus Armbruster wrote:
>> From: Alistair Francis
>>
>> Convert fprintf(stderr, ...) to use qemu_log(). Double prints in
>> target/ppc/translate.c were manually remove. A fprintf() in
>> target/sh4/translate.c was kept as it's inside a #if 0. The #i
Philippe Mathieu-Daudé writes:
> On 02/02/2018 03:37 PM, Markus Armbruster wrote:
>> From: Alistair Francis
>>
>> Replace a large number of the fprintf(stderr, "*\n" calls with
>> error_report(). The functions were renamed with these commands and then
>> compiler issues where manually fixed.
>>
201 - 243 of 243 matches
Mail list logo
