[Qemu-devel] [PULL 13/26] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-02-08 Thread Michael S. Tsirkin
From: Changpeng Liu Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, for multiple I/O queues scenario, all the I/O queues will share one interrupt vector, while here, enable multiple vectors according to the number of I/O queues. Signed-off-by: Changpeng Liu Reviewed-by: P

[Qemu-devel] [PULL 19/26] virtio-balloon: unref the memory region before continuing

2018-02-08 Thread Michael S. Tsirkin
From: Tiwei Bie Signed-off-by: Tiwei Bie Cc: qemu-sta...@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 14e08d2..f2104

[Qemu-devel] [PULL 12/26] pci/bus: let it has higher migration priority

2018-02-08 Thread Michael S. Tsirkin
From: Peter Xu In the past, we prioritized IOMMU migration so that we have such a priority order: IOMMU > PCI Devices When migrating a guest with both vIOMMU and a pcie-root-port, we'll always migrate vIOMMU first, since pci buses will be seen to have the same priority of general PCI device

[Qemu-devel] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Instead of passing the encryption format name and the QemuOpts down, use the QCryptoBlockCreateOptions contained in BlockdevCreateOptions. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qcow2.c | 62 +++ 1 file changed, 45 ins

[Qemu-devel] [PATCH 00/27] x-blockdev-create for protocols and qcow2

2018-02-08 Thread Kevin Wolf
This series implements a minimal QMP command that allows to create an image file on the protocol level or an image format on a given block node. Eventually, the interface is going to change to some kind of an async command (possibly a (non-)block job), but that will require more work on the job in

[Qemu-devel] [PULL 18/26] cryptodev-vhost-user: set the key length

2018-02-08 Thread Michael S. Tsirkin
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/cryptodev-vhost-user.h | 3 +++ backends/cryptodev-vhost-user.c | 4 2 files changed, 7 insertions(+) diff --git a/include/sysemu/cryptodev-vhost-user.h b/inc

[Qemu-devel] [PATCH 08/27] util: Add qemu_opts_to_qdict_filtered()

2018-02-08 Thread Kevin Wolf
This allows, given a QemuOpts for a QemuOptsList that was merged from multiple QemuOptsList, to only consider those options that exist in one specific list. Block drivers need this to separate format-layer create options from protocol-level options. Signed-off-by: Kevin Wolf --- include/qemu/opt

[Qemu-devel] [PATCH 04/27] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-02-08 Thread Kevin Wolf
All of the simple options are now passed to qcow2_create2() in a BlockdevCreateOptions object. Still missing: node-name and the encryption options. Signed-off-by: Kevin Wolf --- block/qcow2.c | 190 ++ 1 file changed, 152 insertions(+), 38

[Qemu-devel] [PATCH 02/27] block/qapi: Add qcow2 create options to schema

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qapi/block-core.json | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index b59b1430bb..aade602a04 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.jso

[Qemu-devel] [PULL 24/26] lpc: drop pcie host dependency

2018-02-08 Thread Michael S. Tsirkin
Doesn't look like that header is used. Signed-off-by: Michael S. Tsirkin --- hw/isa/lpc_ich9.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index adcf077..e692b9f 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -39,7 +39,6 @@ #include "hw/is

[Qemu-devel] [PATCH 09/27] qdict: Introduce qdict_rename_keys()

2018-02-08 Thread Kevin Wolf
A few block drivers will need to rename .bdrv_create options for their QAPIfication, so let's have a helper function for that. Signed-off-by: Kevin Wolf --- include/qapi/qmp/qdict.h | 6 ++ qobject/qdict.c | 30 ++ 2 files changed, 36 insertions(+) diff

[Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

2018-02-08 Thread Kevin Wolf
This creates a BlockdevCreateOptions union type that will contain all of the options for image creation. We'll start out with an empty struct type BlockdevCreateDummy for all drivers. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 61 1

[Qemu-devel] [PULL 23/26] tests: acpi: fix FADT not being compared to reference table

2018-02-08 Thread Michael S. Tsirkin
From: Igor Mammedov It turns out that FADT isn't actually tested for changes against reference table, since it happens to be the 1st table in RSDT which is currently ignored. Fix it by making sure that all tables from RSDT are added to test list. NOTE: FADT contains guest allocated pointers to F

[Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol layer

2018-02-08 Thread Kevin Wolf
Currently, qcow2_create() only parses the QemuOpts and then calls qcow2_create2() for the actual image creation, which includes both the creation of the actual file on the file system and writing a valid empty qcow2 image into that file. The plan is that qcow2_create2() becomes the function that i

[Qemu-devel] [PATCH 10/27] qcow2: Use visitor for options in qcow2_create()

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2.c | 219 - tests/qemu-iotests/049.out | 8 +- tests/qemu-iotests/112.out | 4 +- 3 files changed, 84 insertions(+), 147 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0316335614.

[Qemu-devel] [PATCH 05/27] qcow2: Use BlockdevRef in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Instead of passing a separate BlockDriverState* into qcow2_create2(), make use of the BlockdevRef that is included in BlockdevCreateOptions. Signed-off-by: Kevin Wolf --- include/block/block.h | 1 + block.c | 47 +++ block/qcow2.c

[Qemu-devel] [PULL 22/26] hw/pci-bridge: fix pcie root port's IO hints capability

2018-02-08 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The gen_pcie_root_port mem-reserve and pref32-reserve properties are defined as size (so uint64_t), but passed as uint32_t when building the 'IO hints' vendor specific capability. Passing 4G (or more) gets truncated and passed as a zero reservation. Is not a huge issue sinc

[Qemu-devel] [PATCH 13/27] file-win32: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to file-win32, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- block/file-win32.c | 45 + 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/block/file-win32.c b/block/file-

[Qemu-devel] [PATCH 11/27] block: x-blockdev-create QMP command

2018-02-08 Thread Kevin Wolf
This adds a synchronous x-blockdev-create QMP command that can create qcow2 images on a given node name. We don't want to block while creating an image, so this is not the final interface in all aspects, but BlockdevCreateOptionsQcow2 and .bdrv_co_create() are what they actually might look like in

[Qemu-devel] [PATCH 07/27] qcow2: Handle full/falloc preallocation in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Once qcow2_create2() can be called directly on an already existing node, we must provide the 'full' and 'falloc' preallocation modes outside of creating the image on the protocol layer. Fortunately, we have preallocated truncate now which can provide this functionality. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 26/26] virtio-balloon: include statistics of disk/file caches

2018-02-08 Thread Michael S. Tsirkin
From: Tomáš Golembiovský Signed-off-by: Tomáš Golembiovský Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/virtio_balloon.h | 3 ++- hw/virtio/virtio-balloon.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PATCH 17/27] nfs: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to nfs, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 16 +++- block/nfs.c | 74 +--- 2 files changed, 74 insertions(+), 16 deletions(-) d

[Qemu-devel] [PATCH 15/27] rbd: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to rbd, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 20 +++- block/rbd.c | 137 +-- 2 files changed, 108 insertions(+), 49 deletions(-) dif

[Qemu-devel] [PATCH 12/27] file-posix: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to file, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 20 +- block/file-posix.c | 77 +--- 2 files changed, 74 insertions(+), 23 deletions(-)

[Qemu-devel] [PATCH 19/27] sheepdog: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to sheepdog, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 24 +- block/sheepdog.c | 209 --- 2 files changed, 170 insertions(+), 63 deletions(-)

[Qemu-devel] [PATCH 24/27] file-posix: Fix no-op bdrv_truncate() with falloc preallocation

2018-02-08 Thread Kevin Wolf
If bdrv_truncate() is called, but the requested size is the same as before, don't call posix_fallocate(), which returns -EINVAL for length zero and would therefore make bdrv_truncate() fail. The problem can be triggered by creating a zero-sized raw image with 'falloc' preallocation mode. Signed-o

[Qemu-devel] [PATCH 18/27] sheepdog: QAPIfy "redundacy" create option

2018-02-08 Thread Kevin Wolf
The "redundacy" option for Sheepdog image creation is currently a string that can encode one or two integers depending on its format, which at the same time implicitly selects a mode. This patch turns it into a QAPI union and converts the string into such a QAPI object before interpreting the valu

[Qemu-devel] [PATCH 22/27] ssh: Pass BlockdevOptionsSsh to connect_to_ssh()

2018-02-08 Thread Kevin Wolf
Move the parsing of the QDict options up to the callers, in preparation for the .bdrv_co_create implementation that directly gets a QAPI type. Signed-off-by: Kevin Wolf --- block/ssh.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/block/

[Qemu-devel] [PATCH 23/27] ssh: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to ssh, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 16 - block/ssh.c | 92 +--- 2 files changed, 67 insertions(+), 41 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32] Add

[Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative size

2018-02-08 Thread Kevin Wolf
Most callers have their own checks, but something like this should also be checked centrally. As it happens, x-blockdev-create can pass negative image sizes to format drivers (because there is no QAPI type that would reject negative numbers) and triggers the check added by this patch. Signed-off-b

[Qemu-devel] [PATCH 21/27] ssh: QAPIfy host-key-check option

2018-02-08 Thread Kevin Wolf
This makes the host-key-check option available in blockdev-add. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 63 +++-- block/ssh.c | 88 +--- 2 files changed, 117 insertions(+), 34 deletions(-) diff

[Qemu-devel] [PATCH 27/27] qemu-iotests: Test ssh image creation over QMP

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/207 | 261 + tests/qemu-iotests/207.out | 75 + tests/qemu-iotests/group | 1 + 3 files changed, 337 insertions(+) create mode 100755 tests/qemu-iotests/207 create mode 100644 tests

[Qemu-devel] [PATCH 26/27] qemu-iotests: Test qcow2 over file image creation with QMP

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/206 | 436 + tests/qemu-iotests/206.out | 209 ++ tests/qemu-iotests/group | 1 + 3 files changed, 646 insertions(+) create mode 100755 tests/qemu-iotests/206 create mode 100

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2018-02-08 Thread Thomas Huth
Sounds this was not really a bug, but rather a file corruption problem by using qemu-img on a file that was opened by QEMU already? So could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH 14/27] gluster: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to gluster, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 18 ++- block/gluster.c | 149 +-- 2 files changed, 115 insertions(+), 52 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > The query-cpus command has an extremely serious side effect: > it always interrupt all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the information

[Qemu-devel] [Bug 1367365] Re: qemu-img fixed vhd issues

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? Otherwise, can you provide some test images or a description how to create such images? ** Changed in: qemu Status: New => Incomplete -- You received thi

[Qemu-devel] [PATCH 16/27] nfs: Use QAPI options in nfs_client_open()

2018-02-08 Thread Kevin Wolf
Using the QAPI visitor to turn all options into QAPI BlockdevOptionsNfs simplifies the code a lot. It will also be useful for implementing the QAPI based .bdrv_co_create callback. Signed-off-by: Kevin Wolf --- block/nfs.c | 176 ++-- 1 file

[Qemu-devel] [PATCH 02/14] libqtest: Use qemu_strtoul()

2018-02-08 Thread Thomas Huth
From: Eric Blake This will keep checkpatch happy when the next patch does code motion. Fix the include order to match HACKING when adding the needed header. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/libqtest.c

[Qemu-devel] [PATCH 10/14] tests/boot-sector: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Adjust the helper code to use explicit state instead, and update all callers. Fix some trailing whitespace while touching t

[Qemu-devel] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object

2018-02-08 Thread Kevin Wolf
Create a BlockdevOptionsSsh object in connect_to_ssh() and take the options from there. 'host_key_check' is still processed separately because it's not in the schema yet. Signed-off-by: Kevin Wolf --- block/ssh.c | 136 +++- 1 file changed,

[Qemu-devel] [PATCH 00/14] qtest patches

2018-02-08 Thread Thomas Huth
Here's a set of qtest patches that have been posted to the list before and are IMHO ready for inclusion. I've included the patches from Eric's "Preliminary libqtest cleanups" series that do not need major reworks (the rest needs some more love later), and some additional entries for the boot-serial

[Qemu-devel] [PATCH 12/14] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-08 Thread Thomas Huth
OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/boot-serial-test.c | 4 2 files cha

[Qemu-devel] [PATCH 04/14] libqos: Use explicit QTestState for fw_cfg operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all fw_cfg test functionality (invoked through alloc-pc) to pass in an explicit QTestState, adjusting all callers. In particular, fw_cfg-test had to reorder things to create the test state prior to creating the fw_cfg (and drop a

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32] Add

[Qemu-devel] [Bug 1379688] Re: qemu's monitor and parallel create huge window

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [PATCH 07/14] libqos: Use explicit QTestState for ahci operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all ahci test functionality to pass in an explicit QTestState. The state was already available, so no callers had to be adjusted. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Thomas Huth Signed-off-by: Thomas

[Qemu-devel] [PATCH 06/14] libqos: Use explicit QTestState for i2c operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all i2c test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/ds1338-test.c | 6 ++--- tests/libqos/i2c-imx.c

[Qemu-devel] [PATCH 01/14] tests: Clean up wait for event

2018-02-08 Thread Thomas Huth
From: Markus Armbruster We still use hacks like qmp("") to wait for an event, even though we have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref() since commit 7ffe312. Both commits neglected to convert all the existing hacks. Make up what they missed. Bonus: gets rid of empty for

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 9:45 AM, Michael S. Tsirkin wrote: > On Tue, Feb 06, 2018 at 08:24:34PM -0800, Andrey Smirnov wrote: >> Add code needed to get a functional PCI subsytem when using in >> conjunction with upstream Linux guest (4.13+). Tested to work against >> "e1000e" (network adapter, using

[Qemu-devel] [PATCH 08/14] libqos: Use explicit QTestState for remaining libqos operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all remaining libqos stragglers to pass in an explicit QTestState. Change the setting of global_qtest from being implicit in libqos' call to qtest_start() to instead be explicit in all clients that are still relying on global_qtes

[Qemu-devel] [PATCH 05/14] libqos: Use explicit QTestState for rtas operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all rtas test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth [thuth: Use nicer indentation in rtas.h] Signed-off-by: Thomas Huth --- tests/libqos/pci-

[Qemu-devel] [PATCH 03/14] libqos: Track QTestState with QPCIBus

2018-02-08 Thread Thomas Huth
From: Eric Blake When initializing a QPCIBus, track which QTestState the bus is associated with (so that a later patch can then explicitly use that test state for all communication on the bus, rather than blindly relying on global_qtest). Update the initialization functions to take another param

[Qemu-devel] [PATCH 09/14] qmp-test: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Although qmp-test does not maintain parallel qtest connections, it was the last test assigning to global_qtest. It's just a

Re: [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support

2018-02-08 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > This is the deivce part implementation to add a new feature, > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > receives the guest free page hints from the driver and clears the > corresponding bits in the dirty bitmap, so that th

[Qemu-devel] [PATCH 11/14] wdt_ib700-test: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Improve this test to be explicit about the state. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thoma

[Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-08 Thread Thomas Huth
OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/boot-serial-

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 >> >> + >> >> +#define PCIE_PHY_DEBUG_R1 0x72C >> >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) >> >>

[Qemu-devel] [PATCH 14/14] tests/boot-serial-test: Add support for the aarch64 virt machine

2018-02-08 Thread Thomas Huth
From: Wei Huang This patch adds a small binary kernel to test aarch64 virt machine's UART. Signed-off-by: Wei Huang [thuth: Fixed contextual conflict with the hppa patch] Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-serial-test.c | 9 + 2 files changed, 10

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: [...] > The "halted" field is somewhat controversial. On the one hand, > it offers a convenient way to know if a guest CPU is idle or > running. On the other hand, it's a field that can change many > times a second. In fact, the halte

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> + > >> +#define PCIE_PHY_DEBUG_R1 0x72C > >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) > >> + > >> +#define PCIE_LINK_WIDTH_SPEED_CONTROL 0x80C > >> +#defin

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> >> + > >> >> +#define PCIE_PHY_DEBUG_R1

Re: [Qemu-devel] [PATCH v2 07/32] arm/translate-a64: implement half-precision F(MIN|MAX)(V|NMV)

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This implements the half-precision variants of the across vector > reduction operations. This involves a re-factor of the reduction code > which more closely matches the ARM ARM order (and handles 8 element > reductions). > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v2 03/32] target/arm/cpu64: allow fp16 to be disabled

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > While for CONFIG_USER_ONLY it is policy for the "cpu" to be the most > capable is can be this does cause problems. For example legacy RISU > runs would fail as there are a bunch of implemented instructions which > would have caused failures that now trig

Re: [Qemu-devel] [PATCH v2 08/32] arm/translate-a64: handle_3same_64 comment fix

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > We do implement all the opcodes. > > Signed-off-by: Alex Bennée > --- > target/arm/translate-a64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 19:24, Alex Williamson wrote: > On Thu, 8 Feb 2018 12:10:02 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:26, Alex Williamson wrote: >>> Record data writes that come through the NVIDIA BAR0 quirk, if we get >>> enough in a row that we're only passing through,

Re: [Qemu-devel] [RFC PATCH 2/5] vfio/quirks: Add generic support for ioveventfds

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 19:33, Alex Williamson wrote: > On Thu, 8 Feb 2018 12:11:57 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:26, Alex Williamson wrote: >>> We might wish to handle some quirks via ioeventfds, add a list of >>> ioeventfds to the quirk. >> The commit title is a b

Re: [Qemu-devel] [PATCH v2 05/32] target/arm/cpu.h: add additional float_status flags

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -10750,15 +10751,22 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, > uint32_t val) > } > set_float_rounding_mode(i, &env->vfp.fp_status); > } > -if (changed & (1 << 24)) { > +if (changed & (1 << 19)) { /* FPCR:FZ16 */

Re: [Qemu-devel] [PATCH v2 07/32] arm/translate-a64: implement half-precision F(MIN|MAX)(V|NMV)

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +DEF_HELPER_3(advsimd_maxh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_minh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_maxnumh, f16, f16, f16, ptr) > +DEF_HELPER_3(advsimd_minnumh, f16, f16, f16, ptr) DEF_HELPER_FLAGS_3 with TCG_CALL_NO_RWG. r~

Re: [Qemu-devel] [PATCH v2 12/32] arm/translate-a64: add FP16 FMULA/X/S to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 24 > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 15 +++ > 3 files changed, 41 insertions(+) > > diff --git a/target/arm/helpe

Re: [Qemu-devel] [PATCH v2 06/32] target/arm/helper: pass explicit fpst to set_rmode

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > As the rounding mode is now split between FP16 and the rest of > floating point we need to be explicit when tweaking it. Instead of > passing the CPU env we now pass the appropriate fpst pointer directly. > > Signed-off-by: Alex Bennée > --- > target/

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Andrey Smirnov
On Thu, Feb 8, 2018 at 12:33 PM, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: >> On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: >> > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: >> >> >> +#define PCIE_PORT_LINK_CONTROL

Re: [Qemu-devel] [PATCH] g364fb: switch to using DirtyBitmapSnapshot

2018-02-08 Thread Hervé Poussineau
Le 08/02/2018 à 19:22, Paolo Bonzini a écrit : This removes the last user of memory_region_test_and_clear_dirty outside memory.c. Cc: Hervé Poussineau Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Paolo Bonzini Tested-by: Hervé Poussineau Tested with Windows NT 4.0 --- Unte

Re: [Qemu-devel] [PATCH v2] S390: Expose s390-specific CPU info

2018-02-08 Thread Eric Blake
On 02/08/2018 10:43 AM, Viktor Mihajlovski wrote: Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. W

Re: [Qemu-devel] [PATCH v2 09/32] arm/translate-a64: initial decode for simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This is the initial decode skeleton for the Advanced SIMD three same > instruction group. > > The fprintf is purely to aid debugging as the additional instructions > are added. It will be removed once the group is complete. > > Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH v2 10/32] arm/translate-a64: add FP16 FADD/FABD/FSUB/FMUL/FDIV to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > The fprintf is only there for debugging as the skeleton is added to, > it will be removed once the skeleton is complete. > > Signed-off-by: Alex Bennée > > --- > v2 > - add absh helper > - fix checkpatch violation > --- > target/arm/helper-a64.c

Re: [Qemu-devel] [PATCH v2 13/32] arm/translate-a64: add FP16 FR[ECP/SQRT]S to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 34 ++ > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 6 ++ > 3 files changed, 42 insertions(+) > > diff --git a/target/arm/help

Re: [Qemu-devel] [PATCH v2 11/32] arm/translate-a64: add FP16 F[A]C[EQ/GE/GT] to simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 49 > ++ > target/arm/helper-a64.h| 5 + > target/arm/translate-a64.c | 15 ++ > 3 files changed, 69 insertions(+) > > di

Re: [Qemu-devel] [PATCH V9 1/4] mem: add share parameter to memory-backend-ram

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 01, 2018 at 10:55:08PM +0200, Marcel Apfelbaum wrote: > Currently only file backed memory backend can > be created with a "share" flag in order to allow > sharing guest RAM with other processes in the host. > > Add the "share" flag also to RAM Memory Backend > in order to allow remappi

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eric Blake
On 02/08/2018 01:59 PM, Eduardo Habkost wrote: On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: The query-cpus command has an extremely serious side effect: it always interrupt all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for s

[Qemu-devel] [Bug 1748296] [NEW] TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
Public bug reported: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not equal 0x1f7,

Re: [Qemu-devel] "make check -j4" hangs (was: Re: chardev/char-socket: add POLLHUP handler)

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 19:13, Thomas Huth wrote: > I'm currently facing some issues with "make check -j4" (i.e. running the > tests in parallel). Git bisect blames this commit - though I'm not sure > whether this is really the right one ... Starting with this commit, I > saw hangs in test-filter-re

Re: [Qemu-devel] [PATCH v5 06/23] Softfloat support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread Michael Clark
On Fri, Feb 9, 2018 at 3:35 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/07/2018 05:28 PM, Michael Clark wrote: > > QEMU currently implements IEEE 754-2008 minNum/maxNum. This patch adds > > support for IEEE 754-201x minimumNumber/maximumNumber which is required > > by the

Re: [Qemu-devel] [PATCH v2 14/32] arm/translate-a64: add FP16 pairwise ops simd_three_reg_same_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This includes FMAXNMP, FADDP, FMAXP, FMINNMP, FMINP. > > Signed-off-by: Alex Bennée > > --- > v2 > - checkpatch fixes > --- > target/arm/translate-a64.c | 208 > + > 1 file changed, 133 insertions(+), 75

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 02:59:17PM -0600, Eric Blake wrote: > On 02/08/2018 01:59 PM, Eduardo Habkost wrote: > > On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > > > The query-cpus command has an extremely serious side effect: > > > it always interrupt all running vCPUs so that th

Re: [Qemu-devel] [PATCH v2 15/32] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > The helpers use the new re-factored muladd support in SoftFloat for the > float16 work. > > Signed-off-by: Alex Bennée --- > target/arm/translate-a64.c | 69 > -- 1 file changed, 54 > insertions(+), 15 del

Re: [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp

2018-02-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180204041136.17525-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] "make check -j4" hangs (was: Re: chardev/char-socket: add POLLHUP handler)

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 1:12 PM, Peter Maydell wrote: > On 8 February 2018 at 19:13, Thomas Huth wrote: >> I'm currently facing some issues with "make check -j4" (i.e. running the >> tests in parallel). Git bisect blames this commit - though I'm not sure >> whether this is really the right one ...

[Qemu-devel] [Bug 1748296] Re: TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
** Description changed: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not e

Re: [Qemu-devel] [PATCH v2 16/32] arm/translate-a64: add FP16 x2 ops for simd_indexed

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > A bunch of the vectorised bitwise operations just operate on larger > chunks at a time. We can do the same for the new half-precision > operations by introducing some TWOHALFOP helpers which work on each > half of a pair of half-precision operations at o

Re: [Qemu-devel] [PATCH v2 17/32] arm/translate-a64: initial decode for simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -11472,6 +11512,8 @@ static void disas_data_proc_simd(DisasContext *s, > uint32_t insn) > if (fn) { > fn(s, insn); > } else { > +/* fprintf(stderr, "%s: failed to find %#4x @ %#" PRIx64 "\n", */ > +/* __func

Re: [Qemu-devel] [PATCH v2 18/32] arm/translate-a64: add FP16 FPRINTx to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > @@ -10727,40 +10727,152 @@ static void disas_simd_two_reg_misc(DisasContext > *s, uint32_t insn) > /* AdvSIMD [scalar] two register miscellaneous (FP16) > * > * 31 30 29 28 27 24 23 22 21 17 1612 11 10 95 40 > - * +---+-

Re: [Qemu-devel] [PATCH v2 19/32] arm/translate-a64: add FCVTxx to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This covers all the floating point convert operations. > > Signed-off-by: Alex Bennée > --- > target/arm/helper-a64.c| 32 + > target/arm/helper-a64.h| 2 ++ > target/arm/translate-a64.c | 85 > +++

Re: [Qemu-devel] [PATCH v2 20/32] arm/translate-a64: add FP16 FCMxx (zero) to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +maxpasses = hp ? (is_q ? 8 : 4) : (is_q ? 4 : 2); (8 << is_q) >> size ? > +read_vec_element_i32(s, tcg_op, rn, pass, hp ? MO_16 : MO_32); You already have size. > +return; > +break; Unreachable break. r

Re: [Qemu-devel] [PATCH 12/14] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++

Re: [Qemu-devel] [PATCH 13/14] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3

Re: [Qemu-devel] [PATCH v2 21/32] arm/translate-a64: add FP16 SCVTF/UCVFT to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > I've re-factored the handle_simd_intfp_conv helper to properly handle > half-precision as well as call plain conversion helpers when we are > not doing fixed point conversion. > > Signed-off-by: Alex Bennée > --- > target/arm/helper.c| 4 ++

Re: [Qemu-devel] [PATCH v2 22/32] arm/translate-a64: add FP16 FNEG/FABS to simd_two_reg_misc_fp16

2018-02-08 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > +case 0x2f: /* FABS */ > +gen_helper_advsimd_absh(tcg_res, tcg_op); > +break; > +case 0x6f: /* FNEG */ > +tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000); > +break; Why is

Re: [Qemu-devel] [PATCH 14/14] tests/boot-serial-test: Add support for the aarch64 virt machine

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: From: Wei Huang This patch adds a small binary kernel to test aarch64 virt machine's UART. Signed-off-by: Wei Huang [thuth: Fixed contextual conflict with the hppa patch] Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-s

<    1   2   3   4   5   >