[Qemu-devel] [PATCH v2] vhost-user: fix memory leak

2018-02-12 Thread linzhecheng
g_free() was moved from vhost_net_cleanup in commit e6bcb1b, so we should free net after vhost_net_cleanup Signed-off-by: linzhecheng diff --git a/net/vhost-user.c b/net/vhost-user.c index cb45512506..d024573e45 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -109,6 +109,7 @@ static int

Re: [Qemu-devel] [PATCH v3] spapr: set vsmt to MAX(8, smp_threads)

2018-02-12 Thread David Gibson
On Mon, Feb 12, 2018 at 12:11:27PM +0100, Greg Kurz wrote: > On Sat, 10 Feb 2018 20:23:07 +1100 > David Gibson wrote: > > > On Fri, Feb 09, 2018 at 03:06:49PM +0100, Greg Kurz wrote: > > > On Fri, 9 Feb 2018 09:18:58 +0100 > > > Laurent Vivier wrote: > > > > > > > We ignore silently the valu

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-12 Thread David Gibson
On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote: > On 13/02/18 03:06, Alex Williamson wrote: > > On Mon, 12 Feb 2018 18:05:54 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 12/02/18 16:19, David Gibson wrote: > >>> On Fri, Feb 09, 2018 at 06:55:01PM +1100, Alexey Kardashev

Re: [Qemu-devel] [PATCH qemu v7 3/4] vfio-pci: Allow mmap of MSIX BAR

2018-02-12 Thread David Gibson
On Fri, Feb 09, 2018 at 06:55:02PM +1100, Alexey Kardashevskiy wrote: > At the moment we unconditionally avoid mapping MSIX data of a BAR and > emulate MSIX table in QEMU. However it is 1) not always necessary as > a platform may prodive a paravirt interface for MSIX configuration; > 2) can affect

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-12 Thread David Gibson
On Tue, Feb 13, 2018 at 04:36:30PM +1100, David Gibson wrote: > On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote: > > On 13/02/18 03:06, Alex Williamson wrote: > > > On Mon, 12 Feb 2018 18:05:54 +1100 > > > Alexey Kardashevskiy wrote: > > > > > >> On 12/02/18 16:19, David Gibs

Re: [Qemu-devel] [PATCH qemu v7 4/4] ppc/spapr, vfio: Turn off MSIX emulation for VFIO devices

2018-02-12 Thread David Gibson
On Fri, Feb 09, 2018 at 06:55:03PM +1100, Alexey Kardashevskiy wrote: > This adds a possibility for the platform to tell VFIO not to emulate MSIX > so MMIO memory regions do not get split into chunks in flatview and > the entire page can be registered as a KVM memory slot and make direct > MMIO acc

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-12 Thread Ciro Santilli
On Mon, Feb 12, 2018 at 5:47 AM, Pavel Dovgalyuk wrote: > I tested ARM only with –kernel and –initrd. > > Can you provide the full command line and the disk image? > > > The command I tried was: time ./buildroot/output.arm~/host/usr/bin/qemu-system-arm -M versatilepb -append 'root=/dev/sda noka

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-12 Thread Pavel Dovgalyuk
Your command line looks wrong, because you forgot –icount, but specified other replay options. I tried recording and replaying with your command line and the execution hangs at some moment of replay. The problem may be hidden in –dtb option, because it may add the devices without configuring r

[Qemu-devel] [PATCH] vnc: add qapi/error.h include to stubs

2018-02-12 Thread Gerd Hoffmann
Fixes --disable-vnc build failure. Signed-off-by: Gerd Hoffmann --- ui/vnc-stubs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c index f51280549a..06c4ac6296 100644 --- a/ui/vnc-stubs.c +++ b/ui/vnc-stubs.c @@ -1,5 +1,6 @@ #include "qemu/osdep.h" #include

[Qemu-devel] [PATCH v3] scripts: Add decodetree.py

2018-02-12 Thread Richard Henderson
To be used to decode ARM SVE, but could be used for any fixed-width ISA. Signed-off-by: Richard Henderson --- Changes since v2: * Fix tests/decode/err_init3.def. * Mark main decoder static by default. * Properly diagnose unspecified bits. * Remove output file on error. - I had been

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-02-12 Thread Cédric Le Goater
On 02/12/2018 03:40 PM, Benjamin Herrenschmidt wrote: > On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote: >> On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote: >>> On 12/02/18 09:55, Benjamin Herrenschmidt wrote: Well, we have a problem then. It looks like Qemu broken migr

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-02-12 Thread Paolo Bonzini
On 12/02/2018 18:30, Vladimir Sementsov-Ogievskiy wrote: > 18.01.2018 13:09, Paolo Bonzini wrote:>> We have three cases: >> >> 1) monitor creates and destroy bitmaps. >> >> 2) monitor also has to read the list.  We know it operates with BQL. >> >> 3) users such as mirror.c create a dirty bitmap in

<    1   2   3   4