Re: [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

2018-02-20 Thread Thomas Huth
On 20.02.2018 23:35, Eric Blake wrote: > On 02/20/2018 11:40 AM, Thomas Huth wrote: >> "-net dump" has been marked as deprecated since QEMU v2.10, since it >> only works with the deprecated 'vlan' parameter (or hubs). Network >> dumping should be done with "-object filter-dump" nowadays instead.

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

2018-02-20 Thread Dan Williams
On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov wrote: > On Sat, 17 Feb 2018 14:31:35 +0800 > Haozhong Zhang wrote: > >> ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity >> domain of a NVDIMM SPA range must match with corresponding

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 19:43, Peter Maydell wrote: > I just noticed that we seem to have acquired another git > submodule that isn't pointing to a qemu.org git url: > > [submodule "roms/seabios-hppa"] > path = roms/seabios-hppa > url = git://github.com/hdeller/seabios-hppa.git > > Jeff,

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Paolo Bonzini wrote: I don't mind either way and don't expect to change this u-boot source too much in the future so if you just copy it to the qemu repo without mirroring my repo that's fine as well. (If any change will be needed I can submit patches for it like for other

[Qemu-devel] [PATCH v4 1/5] usb-mtp: Add one more argument when building results

2018-02-20 Thread Bandan Das
The response to a SendObjectInfo consists of the storageid, parent obejct handle and the handle reserved for the new incoming object Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 50 +++--- 1 file changed, 27 insertions(+), 23

[Qemu-devel] [PATCH v4 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-20 Thread Bandan Das
Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a previous SendObjectInfo operation by the

[Qemu-devel] [PATCH v4 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

2018-02-20 Thread Bandan Das
Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 5 ++--- 1 file changed, 2

[Qemu-devel] [PATCH v4 0/5] Initial write support for MTP objects

2018-02-20 Thread Bandan Das
v4: 4/5: Remove getumask and set default permissions to 0644 5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1 Test compilation on freebsd v3: 3/5: Add a property that sets r/w to on/off (default:off) Restructure ifdefs 4/5: Sort the response codes 5/5: Use

[Qemu-devel] [PATCH v4 5/5] usb-mtp: Advertise SendObjectInfo for write support

2018-02-20 Thread Bandan Das
This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple function to get the filename

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-20 Thread Alistair Francis
On Tue, Feb 20, 2018 at 3:13 AM, Paolo Bonzini wrote: > On 20/02/2018 11:36, Stefan Hajnoczi wrote: >> === Multi-CPU cluster support for GDB server in QEMU === >> >> There are many examples in modern computing where multiple CPU >> clusters are grouped together in a single

[Qemu-devel] [PATCH v4 3/5] usb-mtp: Support delete of mtp objects

2018-02-20 Thread Bandan Das
Write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Also, add a "readonly" property which needs to be set to false for deletion to work. Signed-off-by: Bandan Das

Re: [Qemu-devel] [PATCH v2 8/8] qemu-doc: Make "-net" less prominent

2018-02-20 Thread Thomas Huth
On 20.02.2018 19:37, Paolo Bonzini wrote: > On 20/02/2018 18:40, Thomas Huth wrote: >> "-net" is clearly a legacy option. Yet we still use it in almost all >> examples in the qemu documentation, and many other spots in the network >> chapter. We should make it less prominent that users are not

[Qemu-devel] [PATCH] virtio-gpu-3d: add support for second capability set (v2)

2018-02-20 Thread Dave Airlie
From: Dave Airlie Due to a kernel bug we can never increase the size of capability set 1, so introduce a new capability set in parallel, old userspace will continue to use the old set, new userspace will start using the new one when it detects a fixed kernel. v2: don't use a

Re: [Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 01:40 PM, Eric Blake wrote: On 02/20/2018 11:01 AM, Alberto Garcia wrote: tl:dr; I think we need a v3 with even more clarification. I'm also making an additional observationn: Due to the pigeonhole principle and the fact that the compression stream adds metadata, we KNOW

[Qemu-devel] [PATCH 0/2] qcow2: minor compression improvements

2018-02-20 Thread Eric Blake
I noticed these while reviewing Berto's proposed change to the qcow2 spec on how compression works. Eric Blake (2): qcow2: Prefer byte-based calls into bs->file qcow2: Avoid memory over-allocation on compressed images block/qcow2-cluster.c | 17 + block/qcow2-refcount.c |

Re: [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

2018-02-20 Thread Eric Blake
On 02/20/2018 11:40 AM, Thomas Huth wrote: "-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter (or hubs). Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-02-20 Thread Alexey Kardashevskiy
On 19/01/18 16:09, Alexey Kardashevskiy wrote: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > > This adds a new

[Qemu-devel] intel-iommu and vhost: Do we need 'device-iotlb' and 'ats'?

2018-02-20 Thread Jintack Lim
Hi, I'm using vhost with the virtual intel-iommu, and this page[1] shows the QEMU command line example. qemu-system-x86_64 -M q35,accel=kvm,kernel-irqchip=split -m 2G \ -device intel-iommu,intremap=on,device-iotlb=on \ -device ioh3420,id=pcie.1,chassis=1 \

[Qemu-devel] [PATCH 1/2] qcow2: Prefer byte-based calls into bs->file

2018-02-20 Thread Eric Blake
We had only three sector-based stragglers left; convert them to use our preferred byte-based accesses. Signed-off-by: Eric Blake --- block/qcow2-cluster.c | 5 ++--- block/qcow2-refcount.c | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-20 Thread Eric Blake
When reading a compressed image, we were allocating s->cluster_data to 32*cluster_size + 512 (possibly over 64 megabytes, for an image with 2M clusters). Let's check out the history: Back when qcow2 was first written, we used s->cluster_data for everything, including copy_sectors() and

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Andrew Jeffery
On Tue, 20 Feb 2018, at 23:56, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-20 Thread Ciro Santilli
On Tue, Feb 20, 2018 at 9:46 AM, Pavel Dovgalyuk wrote: >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >> On Mon, Feb 19, 2018 at 8:02 AM, Pavel Dovgalyuk wrote: >> >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >> >> > From: Peter Maydell

[Qemu-devel] [PATCH] configure: fix sanitizers' test program to mend ASan detection

2018-02-20 Thread Emilio G. Cota
Commit 218bb57 ("build-sys: check static linking of UBSAN", 2018-02-13) adds a small test program to check whether ubsan works even when configuring with --static. This added program is used to detect all sanitizers, which breaks ASan's detection since the compilation fails with

Re: [Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 04:03 PM, Eric Blake wrote: boundary. Technically, it might be possible, but qemu does NOT do that (again, looking at qcow2_alloc_bytes() - we loop if free_in_cluster < size) - so we may want to be explicit about this point to prevent OTHER implementations from creating a

Re: [Qemu-devel] [PATCH v2 2/8] net: List available netdevs with "-netdev help"

2018-02-20 Thread Eric Blake
On 02/20/2018 11:40 AM, Thomas Huth wrote: Other options like "-chardev" or "-device" feature a nice help text with the available devices when being called with "help" or "?". Since it is quite useful, especially if you want to see which network backends have been compiled into the QEMU binary,

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-20 Thread Pavel Dovgalyuk
> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > On Tue, Feb 20, 2018 at 9:46 AM, Pavel Dovgalyuk wrote: > > > > Updated the branch on github. > > You may try it. > > At 8a482834780a131e7747c1c3c1931379ed0beedc ARM initrd record runs, > but replay is getting stuck at:

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Jeff Cody
On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: > I just noticed that we seem to have acquired another git > submodule that isn't pointing to a qemu.org git url: > > [submodule "roms/seabios-hppa"] > path = roms/seabios-hppa > url =

[Qemu-devel] [PULL 0/4] Linux user for 2.12 patches

2018-02-20 Thread Laurent Vivier
The following changes since commit f0fa81767555fe2c4b5f8c9e0725a80eac1d7f56: cuda.h: Fix multiple typedef (2018-02-16 18:38:21 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-2.12-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 4/4] linux-user: Remove THREAD macro

2018-02-20 Thread Laurent Vivier
From: Peter Maydell Back when we used to support compiling either with or without NPTL threading library support, we used a macro THREAD which would expand either to nothing (no thread support) or to __thread (threads supported). For a long time now we have required

[Qemu-devel] [PULL 3/4] linux-user: Fix sched_getaffinity mask size

2018-02-20 Thread Laurent Vivier
From: Samuel Thibault We properly computed the capped mask size to be put to the application buffer, but didn't actually used it. Also, we need to return the capped mask size instead of 0 on success. Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [PATCH] Remove the deprecated -tdf option

2018-02-20 Thread Kashyap Chamarthy
On Mon, Feb 19, 2018 at 09:23:40PM +0100, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a complete implementation yet with a lot of components still missing but enough for the U-Boot

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-20 Thread Howard Spoelstra
On Tue, Feb 20, 2018 at 10:52 AM, Gerd Hoffmann wrote: >> Hi, >> >> I went on to compile dgibson's rep which includes that commit. But the >> issue remains. >> I normally use -usb-mouse -usb-kbd in the command line, as these work >> for Mac OS 9.x up to 10.5. Using -usb-tablet

[Qemu-devel] [PATCH 2/3] egl-headless: cursor_dmabuf: handle NULL cursor

2018-02-20 Thread Gerd Hoffmann
The cursor dmabuf can be NULL, in case no cursor defined by the guest. Happens for example when linux guests show the framebuffer console. Signed-off-by: Gerd Hoffmann --- ui/egl-headless.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL 1/4] linux-user: Implement ioctl cmd TIOCGPTPEER

2018-02-20 Thread Laurent Vivier
From: Andreas Schwab With glibc 2.27 the openpty function prefers the TIOCGPTPEER ioctl. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier ---

[Qemu-devel] [PULL 2/4] linux-user: Fix register used for 6th and 7th syscall argument on aarch64

2018-02-20 Thread Laurent Vivier
From: Guido Günther This unbreaks the testcase from http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html Thanks to Laurent Vivier for spotting the 7th one. Signed-off-by: Guido Günther Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2018-02-20 Thread Yan Vugenfirer
I am constantly running Windows 10 and Windows Server 2016 and I don't experience specific slowdowns. QEMU command line is needed to understand the specific setup that might be problematic. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-20 Thread Gerd Hoffmann
On Mon, Feb 19, 2018 at 03:16:49PM -0700, Alex Williamson wrote: > On Mon, 19 Feb 2018 12:14:51 +0100 > Gerd Hoffmann wrote: > > > This series adds support for a vgpu display to the qemu vfio code. > > For now only regions are supported, dmabufs will follow later. > > > >

Re: [Qemu-devel] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Alexander Graf wrote: On 02/20/2018 11:09 AM, BALATON Zoltan wrote: On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a

Re: [Qemu-devel] [Bug 1750229] Re: virtio-blk-pci regression: softlock in guest kernel at module loading

2018-02-20 Thread Matwey V. Kornilov
Well, I've found that on qemu side VirtQueue for virtio_blk device infinitely calls virtio_blk_handle_vq() where virtio_blk_get_request() (virtqueue_pop() in essens) always returns NULL. 2018-02-18 15:26 GMT+03:00 Matwey V. Kornilov : > ** Attachment added:

Re: [Qemu-devel] [PATCH] Remove the deprecated -tdf option

2018-02-20 Thread Daniel P . Berrangé
On Mon, Feb 19, 2018 at 09:23:40PM +0100, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-20 Thread Pavel Dovgalyuk
> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > On Mon, Feb 19, 2018 at 8:02 AM, Pavel Dovgalyuk wrote: > >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > >> > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >> > On 13 February 2018 at 10:26, Pavel

Re: [Qemu-devel] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread Alexander Graf
On 02/20/2018 11:09 AM, BALATON Zoltan wrote: On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a complete implementation yet with a lot of

Re: [Qemu-devel] [PULL 0/4] Linux user for 2.12 patches

2018-02-20 Thread Peter Maydell
On 20 February 2018 at 09:16, Laurent Vivier wrote: > The following changes since commit f0fa81767555fe2c4b5f8c9e0725a80eac1d7f56: > > cuda.h: Fix multiple typedef (2018-02-16 18:38:21 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git

Re: [Qemu-devel] [PATCH] scsi: Remove automatic creation of SCSI controllers with -drive if=scsi

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 11:42, Thomas Huth wrote: > Automatic creation of SCSI controllers for "-drive if=scsi" for x86 > machines was quite a bad idea (see description of commit f778a82f0c179 > for details). This is marked as deprecated since QEMU v2.9.0, and as > far as I know, nobody complained that this

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 11:36, Stefan Hajnoczi wrote: > === Multi-CPU cluster support for GDB server in QEMU === > > There are many examples in modern computing where multiple CPU > clusters are grouped together in a single SoC. This is common in the > ARM world especially. There are numerous examples such

Re: [Qemu-devel] [PATCH v2] util/uri.c formating

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 09:14:16AM +, Peter Maydell wrote: > On 20 February 2018 at 08:02, Su Hang wrote: > > Formating the code with `clang-format -i util/uri.c`. > > My .clang-format file content is: > > ''' > > IndentWidth: 4 > > BreakBeforeBraces: Linux > >

[Qemu-devel] [PATCH] scsi: Remove automatic creation of SCSI controllers with -drive if=scsi

2018-02-20 Thread Thomas Huth
Automatic creation of SCSI controllers for "-drive if=scsi" for x86 machines was quite a bad idea (see description of commit f778a82f0c179 for details). This is marked as deprecated since QEMU v2.9.0, and as far as I know, nobody complained that this is still urgently required anymore. Time to

[Qemu-devel] [PULL 2/2] 9p: fix leak in synth_name_to_path()

2018-02-20 Thread Greg Kurz
From: Marc-André Lureau Leak found thanks to ASAN: Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x55995789ac90 in __interceptor_malloc (/home/elmarco/src/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x1510c90) #1 0x7f0a91190f0c in g_malloc

[Qemu-devel] [PULL 1/2] 9p: v9fs_path_copy() readability

2018-02-20 Thread Greg Kurz
From: Marc-André Lureau lhs/rhs doesn't tell much about how argument are handled, dst/src is and const arguments is clearer in my mind. Use g_memdup() while at it. Signed-off-by: Marc-André Lureau Signed-off-by: Greg Kurz

[Qemu-devel] [PULL 0/2] 9p patches for 2.12 20180220

2018-02-20 Thread Greg Kurz
The following changes since commit 299a2e6fac397be9b82c66583d53d1daaa3ffe6c: Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into staging (2018-02-19 12:51:11 +) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches

2018-02-20 Thread Tomáš Golembiovský
On Mon, 19 Feb 2018 21:11:27 -0800 Jonathan Helman wrote: > > On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský wrote: > > > > On Wed, 14 Feb 2018 00:07:53 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Tue, Feb 13, 2018 at

[Qemu-devel] [PATCH v2] util/uri.c formating

2018-02-20 Thread Su Hang
Formating the code with `clang-format -i util/uri.c`. My .clang-format file content is: ''' IndentWidth: 4 BreakBeforeBraces: Linux ''' Then use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c` to remove pattern like this: "return (1);" checkpatch.pl still rise these two kinds

Re: [Qemu-devel] [PATCH v2] util/uri.c formating

2018-02-20 Thread Thomas Huth
On 20.02.2018 09:02, Su Hang wrote: > Formating the code with `clang-format -i util/uri.c`. > My .clang-format file content is: > ''' > IndentWidth: 4 > BreakBeforeBraces: Linux > ''' > > Then use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c` > to remove pattern like this:

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-20 Thread Gerd Hoffmann
Hi, > > Including most recent ui pull request (commit > > 5e8d6a12d643a38b82a0a713a77d1192117dbdca) ? > > > > I'm wondering that you need Ctrl-Alt-G in the first place, sdl2 and gtk > > should have identical behavior here (i.e. no ctrl-alt-g needed in case a > > tablet or other absolute ptr

Re: [Qemu-devel] [PULL 0/8] Linux user for 2.12 patches

2018-02-20 Thread Laurent Vivier
Le 19/02/2018 à 20:50, Peter Maydell a écrit : > On 19 February 2018 at 17:10, Laurent Vivier wrote: >> The following changes since commit f0fa81767555fe2c4b5f8c9e0725a80eac1d7f56: >> >> cuda.h: Fix multiple typedef (2018-02-16 18:38:21 +) >> >> are available in the Git

Re: [Qemu-devel] [PATCH v7 06/12] s390-ccw: parse and set boot menu options

2018-02-20 Thread Viktor Mihajlovski
On 19.02.2018 21:39, Collin L. Walling wrote: > On 02/19/2018 10:52 AM, Viktor Mihajlovski wrote: >> On 16.02.2018 23:07, Collin L. Walling wrote: >> [...] >>> diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h >>> index 74469b1..f632c59 100644 >>> --- a/hw/s390x/ipl.h >>> +++ b/hw/s390x/ipl.h >>> @@

Re: [Qemu-devel] [PATCH] Remove the deprecated -tdf option

2018-02-20 Thread Paolo Bonzini
On 19/02/2018 21:23, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 0/3] opengl: some dmabuf support updates

2018-02-20 Thread Gerd Hoffmann
This series updates the UI interface for dmabug cursors. Splits the callback into two, so we have a separate call for cursor moves. Also adds hotspot information. Series also includes two small fixes in egl code. Gerd Hoffmann (3): console/opengl: split up dpy_gl_cursor ops egl-headless:

Re: [Qemu-devel] qemu warnings and errors

2018-02-20 Thread Gerd Hoffmann
Hi, > What version of QEMU? > > > unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org > > This part is the only part that urges you to report the error, but I > don't know much about what's going on here. > > Maybe Gerd knows? We had lots of keymap/keycode changes recently,

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-20 Thread Stefan Hajnoczi
On Wed, Feb 14, 2018 at 11:00:36AM -0800, Alistair Francis wrote: > On Mon, Jan 15, 2018 at 4:59 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 11, 2018 at 03:25:56PM -0800, Alistair Francis wrote: > >> On Wed, Jan 10, 2018 at 4:52 AM, Stefan Hajnoczi > >>

[Qemu-devel] [PATCH 1/3] console/opengl: split up dpy_gl_cursor ops

2018-02-20 Thread Gerd Hoffmann
Split the cursor callback into two, one for setting the dmabuf, one for setting the position. Also add hotspot information. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 13 - ui/console.c | 18 ++ ui/egl-headless.c| 17

[Qemu-devel] [PATCH 3/3] egl-helpers: add alpha channel to texture format

2018-02-20 Thread Gerd Hoffmann
Needed when rendering cursers which (unlike framebuffers) actually are transparent. Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 5fa60ef4e8..16dc3ded36 100644

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/20/2018 12:18 PM, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different

Re: [Qemu-devel] [PATCH v7] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-20 Thread Gerd Hoffmann
> >> case NSEventTypeKeyUp: > >> keycode = cocoa_keycode_to_qemu([event keyCode]); > >> > >> +if (are_sets_equal(ungrab_set, key_set)) { > >> +[self ungrabMouse]; > >> +clear_set(key_set); > >> +return; > >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread Thomas Huth
On 20.02.2018 12:16, BALATON Zoltan wrote: > On Tue, 20 Feb 2018, Alexander Graf wrote: >> On 02/20/2018 11:09 AM, BALATON Zoltan wrote: >>> On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c> Add emulation of aCube Sam460ex

Re: [Qemu-devel] [PATCH v2] util/uri.c formating

2018-02-20 Thread Peter Maydell
On 20 February 2018 at 08:02, Su Hang wrote: > Formating the code with `clang-format -i util/uri.c`. > My .clang-format file content is: > ''' > IndentWidth: 4 > BreakBeforeBraces: Linux > ''' > > Then use `perl -pi -e "s/return \((.*?)\);/return \1;/g"

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-20 Thread Gerd Hoffmann
> Hi, > > I went on to compile dgibson's rep which includes that commit. But the > issue remains. > I normally use -usb-mouse -usb-kbd in the command line, as these work > for Mac OS 9.x up to 10.5. Using -usb-tablet allows the mouse to > travel outside the GUI and seems to circumvent the issue

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
Given that we have trouble modeling this properly I somewhat like the idea. We should have never folded this into the common code memory hotplug infrastructure as it is different. Instead we really should have provided a different interface and we should have build it with migration support. If

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 12:18, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different

Re: [Qemu-devel] [PATCH 2/2] tests/migration: Add test for migration to bad destination

2018-02-20 Thread Thomas Huth
On 12.02.2018 17:03, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check the source survives. > > Signed-off-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 65 >

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/19/2018 06:42 PM, David Hildenbrand wrote: > From an architecture point of view, nothing can be mapped into the address > space on s390x. All there is is memory. Therefore there is also not really > an interface to communicate such information to the guest. All we can do is > specify the

Re: [Qemu-devel] [PATCHv5 0/5] add query-cpu-fast and related s390 changes

2018-02-20 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:36 +0100 Viktor Mihajlovski wrote: > v5 synopsis: Split out HMP changes from Patch 2 into Patch 5. Please >re-review, as I've removed the a-b/r-b from Patch 2 >as well. > > This series consolidates patches around a

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-20 Thread Corey Minyard
On 02/19/2018 09:25 AM, Peter Maydell wrote: On 19 February 2018 at 15:20, wrote: From: Corey Minyard Some devices need access to it. Signed-off-by: Corey Minyard --- hw/i2c/core.c| 17 -

[Qemu-devel] [PULL 06/12] egl-headless: use DisplayOptions

2018-02-20 Thread Gerd Hoffmann
Switch egl-headless ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-8-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +-

Re: [Qemu-devel] [RFC PATCH v0 1/2] pc-dimm: Make pc_dimm_built_list() global

2018-02-20 Thread Igor Mammedov
On Mon, 19 Feb 2018 12:12:53 +0530 Bharata B Rao wrote: > Making pc_dimm_built_list() global allows other parts of QEMU code > to build and walk through the DIMM list in address-sorted order. > > This is needed in the next patch for sPAPR code to create >

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 13:16:37 +0100 David Hildenbrand wrote: > On 20.02.2018 13:05, Christian Borntraeger wrote: > > > > > > On 02/19/2018 06:42 PM, David Hildenbrand wrote: > >> From an architecture point of view, nothing can be mapped into the address > >> space on s390x.

[Qemu-devel] [PATCH v2 1/5] keymap: make struct kbd_layout_t private to ui/keymaps.c

2018-02-20 Thread Gerd Hoffmann
Also use kbd_layout_t pointers instead of void pointers. Signed-off-by: Gerd Hoffmann --- ui/keymaps.h | 29 ++--- ui/keymaps.c | 32 +--- 2 files changed, 31 insertions(+), 30 deletions(-) diff --git a/ui/keymaps.h

[Qemu-devel] [PATCH v2 3/5] keymap: numpad keysyms and keycodes are fixed

2018-02-20 Thread Gerd Hoffmann
No need to figure them at runtime from the keymap. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c | 61 +--- 1 file changed, 9 insertions(+), 52 deletions(-) diff --git a/ui/keymaps.c b/ui/keymaps.c index

[Qemu-devel] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-20 Thread Halil Pasic
The 'bit' field of the 'S390FeatDef' structure is not applicable to all it's instances. Currently a this field is not applicable, and remains unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 specified for multiple such feature definition was a little confusing, as it's a

Re: [Qemu-devel] [PULL 09/23] gdbstub: Fix vCont behaviour

2018-02-20 Thread Jan Kiszka
On 2018-02-19 19:15, Claudio Imbrenda wrote: > On Sat, 17 Feb 2018 10:07:38 +0100 > Jan Kiszka wrote: > > [...] > >>> Seems like no one is doing guest debugging with kvm on x86 except >>> me, and I'm only doing it too infrequently now: This one broke that >>> use case for SMP

[Qemu-devel] [PATCH] vl: introduce vm_shutdown()

2018-02-20 Thread Stefan Hajnoczi
Commit 00d09fdbbae5f7864ce754913efc84c12fdf9f1a ("vl: pause vcpus before stopping iothreads") and commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") tried to work around the fact that emulation was still active during termination by stopping iothreads.

[Qemu-devel] [Bug 1187529] Re: Devices on PCI bridge stop working when live-migrated

2018-02-20 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Assignee: Don Koch (dkoch-r) => (unassigned) ** Changed in: qemu Status: New => Incomplete -- You received this bug

Re: [Qemu-devel] qemu warnings and errors

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 08:45:00AM -0600, Eric Blake wrote: > On 02/20/2018 02:38 AM, Gerd Hoffmann wrote: > >Hi, > > > > > What version of QEMU? > > > > > > > unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org > > > > > > This part is the only part that urges you to

[Qemu-devel] [PATCH] migration: do not transfer ram during bulk storage migration

2018-02-20 Thread Peter Lieven
this patch makes the bulk phase of a block migration to take place before we start transferring ram. As the bulk block migration can take a long time its pointless to transfer ram during that phase. Signed-off-by: Peter Lieven --- migration/ram.c | 8 1 file changed, 8

Re: [Qemu-devel] [PATCH] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 08:15 AM, Alberto Garcia wrote: The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. That can be easily seen in qcow2_decompress_cluster(), that

Re: [Qemu-devel] [PATCH v1 0/3] cpus: single-threaded TCG CPU creation improvements

2018-02-20 Thread Paolo Bonzini
On 09/02/2018 20:52, David Hildenbrand wrote: > While looking into CPU hotplug for s390x TCG, I noticed that > single-threaded TCG does not properly inititalize CPUs > 1. Fix this > and cleanup the code a bit. > > David Hildenbrand (3): > cpus: properly inititalize CPU > 1 under single-threaded

[Qemu-devel] [PULL 01/12] vl: deprecate -no-frame

2018-02-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180202111022.19269-2-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 4 qemu-doc.texi | 7 +++ 2 files changed, 11 insertions(+) diff --git a/vl.c b/vl.c index 81724f5f17..c1f763f3e1

[Qemu-devel] [PULL 00/12] Ui 20180220 patches

2018-02-20 Thread Gerd Hoffmann
The following changes since commit afd3397a8149d8b645004e459bf2002d78f5e267: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2018-02-19 16:44:12 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180220-pull-request

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
> I also gave it a test on an OpenBMC romulus image. Looks fine, but that's > an old custom U-Boot. Which defconfig did you use for U-Boot HEAD ? evb-ast2500_defconfig. FYI, these changes are necessary, but not sufficient to get u-boot HEAD (or for that matter u-boot 2017.11, another version

[Qemu-devel] [PATCH v2 2/5] keymap: use glib hash for kbd_layout_t

2018-02-20 Thread Gerd Hoffmann
Drop home-grown lookup code, which is a strange mix of a lookup table and a list. Use standard glib hash instead. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c| 79 +++-- ui/trace-events | 2 +- 2 files changed, 38

[Qemu-devel] [PATCH v2 4/5] keymap: record multiple keysym -> keycode mappings

2018-02-20 Thread Gerd Hoffmann
Sometimes the same keysym can be created using different key combinations. Record them all in the reverse keymap, not only the first one. Signed-off-by: Gerd Hoffmann --- ui/keymaps.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/5] keymap: support kbd layouts with multiple mappings for the same key.

2018-02-20 Thread Gerd Hoffmann
The reverse keymap (-k $map) code has problems dealing with keymaps where multiple key combinations can create the same keysym, because it can store a single keycode per keysym only. This series fixes it and does some cleanups along the way. v2: rebase, codestyle fixes. Gerd Hoffmann (5):

[Qemu-devel] [PATCH] sdl2: fix hotkey keyup

2018-02-20 Thread Gerd Hoffmann
After some hotkey was pressed sdl2 doesn't forward the first modifier keyup event to the guest, resulting in stuck modifier keys. Fix the logic in handle_keyup(). Also gui_key_modifier_pressed doesn't need to be a global variable. Reported-by: Howard Spoelstra Tested-by:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-20 Thread Alexander Graf
On 02/20/2018 12:31 PM, Thomas Huth wrote: On 20.02.2018 12:16, BALATON Zoltan wrote: On Tue, 20 Feb 2018, Alexander Graf wrote: On 02/20/2018 11:09 AM, BALATON Zoltan wrote: On Tue, 20 Feb 2018, David Gibson wrote: On Mon, Feb 19, 2018 at 11:34:25AM +0100, BALATON Zoltan wrote: 1;5002;0c>

[Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Hugo Landau
Some register blocks of the ast2500 are protected by protection key registers which require the right magic value to be written to those registers to allow those registers to be mutated. Register manuals indicate that writing the correct magic value to these registers should cause subsequent

[Qemu-devel] [PULL 11/12] vl: drop display_type variable

2018-02-20 Thread Gerd Hoffmann
Switch over all leftover users to qapi DisplayType. Then delete the unused display_type variable. Add 'default' DisplayType, which isn't an actual display type but a placeholder for "user didn't specify a display". It will be replaced by the DisplayType actually used, which in turn depends on

[Qemu-devel] [PULL 09/12] vl: drop full_screen variable

2018-02-20 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 20180202111022.19269-11-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c

[Qemu-devel] [PULL 05/12] vl: drop no_quit variable

2018-02-20 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann Message-id: 20180202111022.19269-7-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] [PATCH] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Alberto Garcia
The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. That can be easily seen in qcow2_decompress_cluster(), that adds one to the value stored in that field:

  1   2   3   >