[Qemu-devel] [PATCH V4 2/3] tests/migration: Add migration-test header file

2018-02-21 Thread Wei Huang
This patch moves the settings related migration-test from the migration-test.c file to a seperate header file. It also renames the x86-a-b-bootblock.s file extension from .s to .S, allowing gcc pre-processor to include the C-style header file correctly. Signed-off-by: Wei Huang

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-21 Thread Pavel Dovgalyuk
> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > On Wed, Feb 21, 2018 at 6:41 AM, Pavel Dovgalyuk wrote: > >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > >> On Tue, Feb 20, 2018 at 9:46 AM, Pavel Dovgalyuk > >> wrote: > >> > > >> >

[Qemu-devel] [PATCH v3 4/5] keymap: record multiple keysym -> keycode mappings

2018-02-21 Thread Gerd Hoffmann
Sometimes the same keysym can be created using different key combinations. Record them all in the reverse keymap, not only the first one. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/keymaps.c | 14 +++--- 1 file changed,

Re: [Qemu-devel] [PATCH 08/11] openpic: move OpenPIC state and related definitions to openpic.h

2018-02-21 Thread David Gibson
On Mon, Feb 19, 2018 at 06:19:19PM +, Mark Cave-Ayland wrote: > This is to faciliate access to OpenPICState when wiring up the PIC to the > macio > controller. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson > ---

Re: [Qemu-devel] [PATCH 09/11] mac_newworld: use object link to pass OpenPIC object to macio

2018-02-21 Thread David Gibson
On Mon, Feb 19, 2018 at 06:19:20PM +, Mark Cave-Ayland wrote: > Also switch macio_newworld_realize() over to use it rather than using the > pic_mem > memory region directly. > > Now that both Old World and New World macio devices no longer make use of the > pic_mem memory region directly, we

[Qemu-devel] [PATCH V4 3/3] tests: Add migration test for aarch64

2018-02-21 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 06/13] s390-ccw: parse and set boot menu options

2018-02-21 Thread Thomas Huth
On 21.02.2018 20:35, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X

Re: [Qemu-devel] [RFC PATCH v0 1/2] pc-dimm: Make pc_dimm_built_list() global

2018-02-21 Thread Bharata B Rao
On Tue, Feb 20, 2018 at 03:35:10PM +0100, Igor Mammedov wrote: > On Mon, 19 Feb 2018 12:12:53 +0530 > Bharata B Rao wrote: > > > Making pc_dimm_built_list() global allows other parts of QEMU code > > to build and walk through the DIMM list in address-sorted order. > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 13/13] s390-ccw: interactive boot menu for scsi

2018-02-21 Thread Thomas Huth
On 21.02.2018 20:35, Collin L. Walling wrote: > Interactive boot menu for scsi. This follows a similar procedure > as the interactive menu for eckd dasd. An example follows: > > s390x Enumerated Boot Menu. > > 3 entries detected. Select from index 0 to 2. > > Signed-off-by: Collin L.

[Qemu-devel] [PATCH v3 3/5] keymap: numpad keysyms and keycodes are fixed

2018-02-21 Thread Gerd Hoffmann
No need to figure them at runtime from the keymap. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/keymaps.c | 61 +--- 1 file changed, 9 insertions(+), 52 deletions(-) diff

[Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-02-21 Thread Gerd Hoffmann
Pass the modifier state to the keymap lookup function. In case multiple keysym -> keycode mappings exist look at the modifier state and prefer the mapping where the modifier state matches. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé ---

[Qemu-devel] [PATCH v3 0/5] keymap: support kbd layouts with multiple mappings for the same key.

2018-02-21 Thread Gerd Hoffmann
The reverse keymap (-k $map) code has problems dealing with keymaps where multiple key combinations can create the same keysym, because it can store a single keycode per keysym only. This series fixes it and does some cleanups along the way. v2: rebase, codestyle fixes. v3: use GINT_TO_POINTER

Re: [Qemu-devel] [PATCH 0/2] Firmware blob and git submodule for Sam460ex

2018-02-21 Thread David Gibson
On Wed, Feb 21, 2018 at 06:33:42PM +, Peter Maydell wrote: > On 21 February 2018 at 17:06, BALATON Zoltan wrote: > > It's not that upstream u-boot has abandoned board support (it only removed > > support for the PPC440 CPU it once had). The board itself never had support >

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-21 Thread Thomas Huth
On 21.02.2018 20:35, Collin L. Walling wrote: > The s390-ccw firmware needs some information in support of the > boot process which is not available on the native machine. > Examples are the netboot firmware load address and now the > boot menu parameters. > > While storing that data in unused

Re: [Qemu-devel] [PATCH] intel-iommu: Accept 64-bit writes to FEADDR

2018-02-21 Thread Peter Xu
On Sat, Feb 17, 2018 at 12:26:19PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Xen is doing this [1] and currently triggers an abort. > > [1] >

Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-21 Thread Zhenyu Wang
On 2018.02.20 18:04:17 +0100, Gerd Hoffmann wrote: > Hi, > > > Sneak preview at https://www.kraxel.org/cgit/qemu/log/?h=work/intel-vgpu > > Note: branch is a moving target ;) > > > > State: > > spice: Partly working (no mouse ptr yet). > > Working now, in case anyone wants play. > > Must

Re: [Qemu-devel] [PATCH v4 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-21 Thread Bandan Das
Daniel P. Berrangé writes: >> #define TYPE_USB_MTP "usb-mtp" >> @@ -804,6 +815,7 @@ static MTPData *usb_mtp_get_device_info(MTPState *s, >> MTPControl *c) >> CMD_GET_OBJECT_HANDLES, >> CMD_GET_OBJECT_INFO, >> CMD_DELETE_OBJECT, >> +

Re: [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:47PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index 60bcf67b3a..76137ba2a4 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -246,6 +246,21 @@ static inline bool monitor_is_qmp(const Monitor *mon) > return (mon->flags & MONITOR_USE_CONTROL); >

Re: [Qemu-devel] [PATCH v1 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-21 Thread Claudio Imbrenda
On Wed, 21 Feb 2018 16:34:59 +0100 Cornelia Huck wrote: > On Tue, 20 Feb 2018 19:45:02 +0100 > Claudio Imbrenda wrote: > > > Extend the SCLP event masks to 64 bits. This will make us future > > proof against future extensions of the architecture.

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-21 Thread Alberto Garcia
On Wed 21 Feb 2018 04:00:54 PM CET, Eric Blake wrote: >> - Solution b: the width of the 'compressed cluster size' field is >>(cluster_bits - 8), that's (cluster_size / 256) sectors. > > Not true. It is (cluster_bits - 9) or (cluster_size / 512). It's not, it's (cluster_bits - 8), the

Re: [Qemu-devel] [PATCH v1 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-21 Thread Cornelia Huck
On Tue, 20 Feb 2018 19:45:02 +0100 Claudio Imbrenda wrote: > Extend the SCLP event masks to 64 bits. This will make us future proof > against future extensions of the architecture. > > Notice that using any of the new bits results in a state that cannot be >

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-21 Thread Eric Blake
On 02/21/2018 09:00 AM, Eric Blake wrote: On 02/21/2018 04:04 AM, Alberto Garcia wrote: On Tue 20 Feb 2018 11:24:59 PM CET, Eric Blake wrote: I was also preparing a patch to change this, but you arrived first :-) So, it's time to cut back on the waste.  A compressed cluster will NEVER occupy

Re: [Qemu-devel] [PATCH v2 03/32] target/arm/cpu64: allow fp16 to be disabled

2018-02-21 Thread Alex Bennée
Peter Maydell writes: > On 8 February 2018 at 17:31, Alex Bennée wrote: >> While for CONFIG_USER_ONLY it is policy for the "cpu" to be the most >> capable is can be this does cause problems. For example legacy RISU >> runs would fail as there

Re: [Qemu-devel] [PATCH v3] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-21 Thread Alberto Garcia
On Wed 21 Feb 2018 05:10:30 PM CET, Eric Blake wrote: >> Compressed Clusters Descriptor (x = 62 - (cluster_bits - 8)): >> >> -Bit 0 - x:Host cluster offset. This is usually _not_ aligned to a >> -cluster boundary! >> +Bit 0 - x-1: Host cluster offset. This

Re: [Qemu-devel] [PATCH v1 2/3] s390x/sclp: clean up sclp masks

2018-02-21 Thread Claudio Imbrenda
On Wed, 21 Feb 2018 16:20:05 +0100 Cornelia Huck wrote: > On Tue, 20 Feb 2018 19:45:01 +0100 > Claudio Imbrenda wrote: > > > Clean up SCLP masks: introduce an sccb_mask_t to be used for SCLP > > event masks instead of just unsigned int or

Re: [Qemu-devel] [PATCH v3] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-21 Thread Eric Blake
CC: qemu-sta...@nongnu.org Incorrect docs make for difficult interoperability. On 02/21/2018 08:08 AM, Alberto Garcia wrote: This patch fixes several mistakes in the documentation of the compressed cluster descriptor: 1) the documentation claims that the cluster descriptor contains the

Re: [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:44PM +0800, Peter Xu wrote: > diff --git a/qapi-schema.json b/qapi-schema.json > index 5c06745c79..2490d5188e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -102,21 +102,47 @@ > # > # Enable QMP capabilities. > # > -# Arguments: None. > +# Arguments:

Re: [Qemu-devel] [PATCH 11/27] block: x-blockdev-create QMP command

2018-02-21 Thread Eric Blake
On 02/21/2018 04:29 AM, Kevin Wolf wrote: +++ b/include/block/block_int.h @@ -130,6 +130,8 @@ struct BlockDriver { int (*bdrv_file_open)(BlockDriverState *bs, QDict *options, int flags, Error **errp); void (*bdrv_close)(BlockDriverState *bs); +int

Re: [Qemu-devel] [PATCH v3 5/7] net: Remove the deprecated way of dumping network packets

2018-02-21 Thread Eric Blake
On 02/21/2018 04:18 AM, Thomas Huth wrote: "-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter (or hubs). Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the

Re: [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:46PM +0800, Peter Xu wrote: > Monitor code now can be run in more than one thread. Let it be thread > safe when accessing suspend_cnt counter. > > Reviewed-by: Eric Blake > Signed-off-by: Peter Xu > --- > monitor.c | 15

Re: [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe

2018-02-21 Thread Stefan Hajnoczi
Nevermind, I see the next patch adds QMP support. Stefan signature.asc Description: PGP signature

[Qemu-devel] [PATCH v2 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-21 Thread Halil Pasic
The 'bit' field of the 'S390FeatDef' structure is not applicable to all its instances. Currently this field is not applicable, and remains unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 specified for multiple such feature definition was a little confusing, as it's a

Re: [Qemu-devel] [PATCH v1 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-21 Thread Cornelia Huck
On Tue, 20 Feb 2018 19:45:00 +0100 Claudio Imbrenda wrote: > The architecture allows the guests to ask for masks up to 1021 bytes in > length. Part was fixed in 67915de9f0383ccf4ab8c42dd02aa18dcd79b411 > ("s390x/event-facility: variable-length event masks"), but some

Re: [Qemu-devel] [PATCH v1 2/3] s390x/sclp: clean up sclp masks

2018-02-21 Thread Cornelia Huck
On Tue, 20 Feb 2018 19:45:01 +0100 Claudio Imbrenda wrote: > Clean up SCLP masks: introduce an sccb_mask_t to be used for SCLP event > masks instead of just unsigned int or uint32_t. This will allow later > to extend the mask with more ease. Looks mostly sane. > >

Re: [Qemu-devel] [PATCH v1 0/3] s390x/sclp: 64 bit event masks

2018-02-21 Thread Cornelia Huck
On Tue, 20 Feb 2018 19:44:59 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to

Re: [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:43PM +0800, Peter Xu wrote: > @@ -4034,12 +4044,29 @@ static void sortcmdlist(void) > qsort((void *)info_cmds, array_num, elem_size, compare_mon_cmd); > } > > +static GMainContext *monitor_io_context_get(void) > +{ > +return

Re: [Qemu-devel] [PATCH v3] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-21 Thread Eric Blake
On 02/21/2018 08:08 AM, Alberto Garcia wrote: This patch fixes several mistakes in the documentation of the compressed cluster descriptor: 1) the documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually

Re: [Qemu-devel] [PATCH v1 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-21 Thread Claudio Imbrenda
On Wed, 21 Feb 2018 16:12:59 +0100 Cornelia Huck wrote: > On Tue, 20 Feb 2018 19:45:00 +0100 > Claudio Imbrenda wrote: > > > The architecture allows the guests to ask for masks up to 1021 > > bytes in length. Part was fixed in > >

Re: [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:46PM +0800, Peter Xu wrote: > @@ -3996,7 +3996,7 @@ int monitor_suspend(Monitor *mon) > { > if (!mon->rs) > return -ENOTTY; Does this mean that QMP monitors like -qmp unix:/tmp/foo,server,nowait will not use suspend_cnt? I thought the point was to use

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-21 Thread Kevin Wolf
Am 20.02.2018 um 23:24 hat Eric Blake geschrieben: > When reading a compressed image, we were allocating s->cluster_data > to 32*cluster_size + 512 (possibly over 64 megabytes, for an image > with 2M clusters). Let's check out the history: > > Back when qcow2 was first written, we used

[Qemu-devel] [Bug 1732959] Re: [regression] Clock jump on source VM after migration

2018-02-21 Thread Neil Skrypuch
As a further test, I disabled ntpd on the host and ran ntpdate via cron every 12 hours, so that the clock would be relatively accurate, but no clock skew would be involved. This also reproduced the failure as initially described. This is interesting as it means that a much simpler and faster

[Qemu-devel] [PATCH v3 4/7] net: Make net_client_init() static

2018-02-21 Thread Thomas Huth
The function is only used within net.c, so there's no need that this is a global function. While we're at it, also remove the unused prototype compute_mcast_idx() (the function has been removed in commit d9caeb09b107e91122d10ba4a08a). Reviewed-by: Paolo Bonzini

[Qemu-devel] [PATCH v3 7/7] net: Add a new convenience option "--nic" to configure default/on-board NICs

2018-02-21 Thread Thomas Huth
The legacy "-net" option can be quite confusing for the users since most people do not expect to get a "vlan" hub between their emulated guest hardware and the host backend. But so far, we are also not able to get rid of "-net" completely, since it is the only way to configure on-board NICs that

Re: [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net

2018-02-21 Thread Mark Cave-Ayland
On 21/02/18 10:18, Thomas Huth wrote: "-net" is a legacy option that often causes confusion and misconfigurations for the users, since most people are not aware of the underlying "vlan" (i.e. hub) concept that is used for this parameter. The prefered way of configuring your network stack is to

[Qemu-devel] [PULL 12/22] fpu/softfloat: re-factor add/sub

2018-02-21 Thread Alex Bennée
We can now add float16_add/sub and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 add and sub functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Philippe

[Qemu-devel] [PULL 13/22] fpu/softfloat: re-factor mul

2018-02-21 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH 05/12] egl-headless: switch over to new display registry

2018-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 --- ui/egl-headless.c| 20 +++- vl.c | 12 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index

[Qemu-devel] [PATCH v3 2/7] net: List available netdevs with "-netdev help"

2018-02-21 Thread Thomas Huth
Other options like "-chardev" or "-device" feature a nice help text with the available devices when being called with "help" or "?". Since it is quite useful, especially if you want to see which network backends have been compiled into the QEMU binary, let's provide such a help text for "-netdev",

Re: [Qemu-devel] [PATCH v4 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-21 Thread Gerd Hoffmann
> > +static void usb_mtp_write_data(MTPState *s) > > +{ > > +MTPData *d = s->data_out; > > +MTPObject *parent = > > +usb_mtp_object_lookup(s, s->dataset.parent_handle); > > +char *path = NULL; > > +int rc = -1; > > +mode_t mask = 0644; > > + > > +assert(d != NULL);

[Qemu-devel] [PULL 09/22] fpu/softfloat: improve comments on ARM NaN propagation

2018-02-21 Thread Alex Bennée
Mention the pseudo-code fragment from which this is based. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index de2c5d5702..4be0fb21ba 100644 ---

[Qemu-devel] [PULL 08/22] include/fpu/softfloat: add some float16 constants

2018-02-21 Thread Alex Bennée
This defines the same set of common constants for float 16 as defined for 32 and 64 bit floats. These are often used by target helper functions. I've also removed constants that are not used by anybody. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 17/22] fpu/softfloat: re-factor float to int/uint

2018-02-21 Thread Alex Bennée
We share the common int64/uint64_pack_decomposed function across all the helpers and simply limit the final result depending on the final size. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c

[Qemu-devel] QEMU & KVM are participating in Outreachy May-August 2018!

2018-02-21 Thread Stefan Hajnoczi
QEMU & KVM are participating in the Outreachy open source internship program that offers 12-week, paid, remote work internships for individuals from underrepresented groups in open source. The application period is from February 12 to March 22 2018. The internships themselves run May-August.

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-21 Thread Halil Pasic
On 02/20/2018 05:25 PM, Cornelia Huck wrote: > On Tue, 20 Feb 2018 17:08:52 +0100 > David Hildenbrand wrote: > >> On 20.02.2018 17:07, Cornelia Huck wrote: >>> On Tue, 20 Feb 2018 17:04:19 +0100 >>> Christian Borntraeger wrote: >>> On

[Qemu-devel] [PATCH 11/12] gtk: build as ui module

2018-02-21 Thread Gerd Hoffmann
Also drop gtk and vte libs from libs_softmmu, so the libs are not pulled in unless the gtk module actually gets loaded. Shared library dependencies dropped from qemu-system-*: libEGL.so.1 => /lib64/libEGL.so.1 libGL.so.1 => /lib64/libGL.so.1 libXcomposite.so.1 => /lib64/libXcomposite.so.1

[Qemu-devel] [PATCH 07/12] console: add ui module loading support

2018-02-21 Thread Gerd Hoffmann
If a requested user interface is not available, try loading it as module, simliar to block layer modules. Needed to keep things working when followup patches start to build user interfaces as modules. Signed-off-by: Gerd Hoffmann --- include/qemu/module.h | 1 + ui/console.c

Re: [Qemu-devel] [PATCH 19/19] mps2-an505: New board model: MPS2 with AN505 Cortex-M33 FPGA image

2018-02-21 Thread Igor Mammedov
On Tue, 20 Feb 2018 18:03:25 + Peter Maydell wrote: > Define a new board model for the MPS2 with an AN505 FPGA image > containing a Cortex-M33. Since the FPGA images for TrustZone > cores (AN505, and the similar AN519 for Cortex-M23) have a > significantly different

[Qemu-devel] [PULL 16/22] fpu/softfloat: re-factor round_to_int

2018-02-21 Thread Alex Bennée
We can now add float16_round_to_int and use the common round_decomposed and canonicalize functions to have a single implementation for float16/32/64 round_to_int functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 15/22] fpu/softfloat: re-factor muladd

2018-02-21 Thread Alex Bennée
We can now add float16_muladd and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 muladd functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH 12/12] curses: build as ui module

2018-02-21 Thread Gerd Hoffmann
Also drop curses libs from libs_softmmu. Add CURSES_{CFLAGS,LIBS} variables so we can use them for linking the curses module. Shared library dependencies dropped from qemu-system-*: libncursesw.so.5 => /lib64/libncursesw.so.5 libtinfo.so.5 => /lib64/libtinfo.so.5 Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 04/12] curses: switch over to new display registry

2018-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 ui/curses.c | 14 +- vl.c | 17 ++--- 3 files changed, 15 insertions(+), 28 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index

[Qemu-devel] [PATCH v3 1/7] net: Move error reporting from net_init_client/netdev to the calling site

2018-02-21 Thread Thomas Huth
It looks strange that net_init_client() and net_init_netdev() both take an "Error **errp" parameter, but then do the error reporting with "error_report_err(local_err)" on their own. Let's move the error reporting to the calling site instead to simplify this code a little bit. Reviewed-by: Eric

[Qemu-devel] [PATCH v3 5/7] net: Remove the deprecated way of dumping network packets

2018-02-21 Thread Thomas Huth
"-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter (or hubs). Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the deprecation message, let's finally get rid of "-net

Re: [Qemu-devel] [PATCH 11/27] block: x-blockdev-create QMP command

2018-02-21 Thread Kevin Wolf
Am 15.02.2018 um 20:58 hat Eric Blake geschrieben: > On 02/08/2018 01:23 PM, Kevin Wolf wrote: > > This adds a synchronous x-blockdev-create QMP command that can create > > qcow2 images on a given node name. > > > > We don't want to block while creating an image, so this is not the final > >

[Qemu-devel] [PULL 02/22] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-02-21 Thread Alex Bennée
It's not actively built and when enabled things fail to compile. I'm not sure the type-checking is really helping here. Seeing as we "own" our softfloat now lets remove the cruft. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 10/22] fpu/softfloat: move the extract functions to the top of the file

2018-02-21 Thread Alex Bennée
This is pure code-motion during re-factoring as the helpers will be needed earlier. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell diff --git a/fpu/softfloat.c

[Qemu-devel] [PULL 01/22] fpu/softfloat: implement float16_squash_input_denormal

2018-02-21 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell diff --git a/fpu/softfloat.c

[Qemu-devel] [PULL 05/22] include/fpu/softfloat: implement float16_abs helper

2018-02-21 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 11/22] fpu/softfloat: define decompose structures

2018-02-21 Thread Alex Bennée
These structures pave the way for generic softfloat helper routines that will operate on fully decomposed numbers. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé diff --git

[Qemu-devel] [PULL 21/22] fpu/softfloat: re-factor compare

2018-02-21 Thread Alex Bennée
The compare function was already expanded from a macro. I keep the macro expansion but move most of the logic into a compare_decomposed. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c

Re: [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net

2018-02-21 Thread Thomas Huth
On 21.02.2018 11:41, Mark Cave-Ayland wrote: > On 21/02/18 10:18, Thomas Huth wrote: > >> "-net" is a legacy option that often causes confusion and >> misconfigurations for the users, since most people are not aware >> of the underlying "vlan" (i.e. hub) concept that is used for this >>

[Qemu-devel] [PULL 19/22] fpu/softfloat: re-factor scalbn

2018-02-21 Thread Alex Bennée
This is one of the simpler manipulations you could make to a floating point number. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 4313d3a602..a07b8556b0 100644 ---

[Qemu-devel] [PULL 04/22] target/*/cpu.h: remove softfloat.h

2018-02-21 Thread Alex Bennée
As cpu.h is another typically widely included file which doesn't need full access to the softfloat API we can remove the includes from here as well. Where they do need types it's typically for float_status and the rounding modes so we move that to softfloat-types.h as well. As a result of not

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-21 Thread Stefan Hajnoczi
On Tue, Feb 20, 2018 at 11:13 AM, Paolo Bonzini wrote: > On 20/02/2018 11:36, Stefan Hajnoczi wrote: >> === Multi-CPU cluster support for GDB server in QEMU === >> >> There are many examples in modern computing where multiple CPU >> clusters are grouped together in a single

[Qemu-devel] [PULL 22/22] fpu/softfloat: re-factor sqrt

2018-02-21 Thread Alex Bennée
This is a little bit of a departure from softfloat's original approach as we skip the estimate step in favour of a straight iteration. There is a minor optimisation to avoid calculating more bits of precision than we need however this still brings a performance drop, especially for float64

[Qemu-devel] [PULL 14/22] fpu/softfloat: re-factor div

2018-02-21 Thread Alex Bennée
We can now add float16_div and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 20/22] fpu/softfloat: re-factor minmax

2018-02-21 Thread Alex Bennée
Let's do the same re-factor treatment for minmax functions. I still use the MACRO trick to expand but now all the checking code is common. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/fpu/softfloat.c

Re: [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net

2018-02-21 Thread Paolo Bonzini
On 21/02/2018 11:41, Mark Cave-Ayland wrote: > 1) Does the new -nic syntax support multiple on-board NICs? I remember > seeing this on some of the ARM boards I was studying when trying to > implement something similar for SPARC. Yes, but they will be in different subnets if you do "-nic user -nic

[Qemu-devel] [PATCH 00/12] ui: build sdl, gtk and curses as modules

2018-02-21 Thread Gerd Hoffmann
This patch series adds a registry for user interfaces (aka displays), adds support for user interface modules and allows to build sdl, gtk and curses as modules. Especially gtk cuts down the number of shared libraries qemu links against by a significant amount. Note one: Modules are disabled by

[Qemu-devel] [PATCH 01/12] console: add qemu display registry, add gtk

2018-02-21 Thread Gerd Hoffmann
Add a registry for user interfaces. Add qemu_display_init and qemu_display_early_init helper functions for display initialization. Hook up gtk ui as first user. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 32 ui/console.c

[Qemu-devel] [PATCH 09/12] configure: opengl doesn't depend on x11

2018-02-21 Thread Gerd Hoffmann
So remove x11 from pkg-config check and don't add x11 cflags/libs to opengl cflags/libs. Signed-off-by: Gerd Hoffmann --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 2934a4bcff..66c210026a 100755 ---

[Qemu-devel] [PATCH 10/12] sdl: build as ui module

2018-02-21 Thread Gerd Hoffmann
Shared library dependencies dropped from qemu-system-*: libSDL2-2.0.so.0 => /lib64/libSDL2-2.0.so.0 Signed-off-by: Gerd Hoffmann --- configure| 2 +- Makefile.objs| 1 + ui/Makefile.objs | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 08/12] configure: add X11 vars to config-host.mak

2018-02-21 Thread Gerd Hoffmann
Simplifies handling the X11 dependency, also makes ui/Makefile.objs more readable. Signed-off-by: Gerd Hoffmann --- configure| 10 -- ui/Makefile.objs | 5 - 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH v3] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-21 Thread Kevin Wolf
Am 21.02.2018 um 15:08 hat Alberto Garcia geschrieben: > This patch fixes several mistakes in the documentation of the > compressed cluster descriptor: > > 1) the documentation claims that the cluster descriptor contains the >number of sectors used to store the compressed data, but what it >

Re: [Qemu-devel] [PATCH v7 18/23] qmp: support out-of-band (oob) execution

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:52PM +0800, Peter Xu wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request:

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-21 Thread Eric Blake
On 02/21/2018 10:51 AM, Kevin Wolf wrote: Am 20.02.2018 um 23:24 hat Eric Blake geschrieben: When reading a compressed image, we were allocating s->cluster_data to 32*cluster_size + 512 (possibly over 64 megabytes, for an image with 2M clusters). Let's check out the history: Much later, in

Re: [Qemu-devel] [PATCH v1 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-21 Thread Cornelia Huck
On Wed, 21 Feb 2018 17:28:49 +0100 Claudio Imbrenda wrote: > On Wed, 21 Feb 2018 16:12:59 +0100 > Cornelia Huck wrote: > > > On Tue, 20 Feb 2018 19:45:00 +0100 > > Claudio Imbrenda wrote: > > > > > The

Re: [Qemu-devel] [PATCH 0/2] Firmware blob and git submodule for Sam460ex

2018-02-21 Thread BALATON Zoltan
On Wed, 21 Feb 2018, Peter Maydell wrote: On 20 February 2018 at 20:44, Emilio G. Cota wrote: On Tue, Feb 20, 2018 at 18:31:17 +, Peter Maydell wrote: On 20 February 2018 at 18:10, BALATON Zoltan wrote: I've created a git repo for the Sam460ex u-boot

[Qemu-devel] [RFC PATCH 2/5] kbd-state: add hotkey registry

2018-02-21 Thread Gerd Hoffmann
Add support to register hotkeys and to check whenever a given QKeyCode combined with the current modifier state is a hotkey. A hotkey can be any key combined with up to three modifier keys. Signed-off-by: Gerd Hoffmann --- include/ui/kbd-state.h | 27

[Qemu-devel] [RFC PATCH 1/5] kbd-state: add keyboard state tracker

2018-02-21 Thread Gerd Hoffmann
Now that most user interfaces are using QKeyCodes it is easier to have common keyboard code useable by all user interfaces. This patch adds helper code to track the state of all keyboard keys, using a bitmap indexed by QKeyCode. Modifier state is tracked too, as separate bitmap. That makes

Re: [Qemu-devel] [PATCH v7 14/23] monitor: separate QMP parser and dispatcher

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:48PM +0800, Peter Xu wrote: > Originally QMP goes through these steps: > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread + > > This

Re: [Qemu-devel] [PATCH v7 16/23] monitor: send event when command queue full

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:50PM +0800, Peter Xu wrote: > Set maximum QMP command queue length to 8. If queue full, instead of > queue the command, we directly return a "command-dropped" event, telling > client that specific command is dropped. > > Note that this flow control mechanism is only

Re: [Qemu-devel] [PATCH v1 2/3] s390x/sclp: clean up sclp masks

2018-02-21 Thread Cornelia Huck
On Wed, 21 Feb 2018 17:42:57 +0100 Claudio Imbrenda wrote: > On Wed, 21 Feb 2018 16:20:05 +0100 > Cornelia Huck wrote: > > > On Tue, 20 Feb 2018 19:45:01 +0100 > > Claudio Imbrenda wrote: > > > diff --git

Re: [Qemu-devel] [PATCH v2 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-21 Thread David Hildenbrand
On 21.02.2018 17:56, Halil Pasic wrote: > The 'bit' field of the 'S390FeatDef' structure is not applicable to all > its instances. Currently this field is not applicable, and remains > unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 > specified for multiple such feature

Re: [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:34PM +0800, Peter Xu wrote: > This version should have addressed all comments in previous one, also > fixed another race condition after I addressed all the comments (a new > race condition introduced by addressing the comments...). For some > more details of the

Re: [Qemu-devel] [PATCH v2 03/32] target/arm/cpu64: allow fp16 to be disabled

2018-02-21 Thread Richard Henderson
On 02/21/2018 08:35 AM, Alex Bennée wrote: >> Good news everybody -- this is an opportunity for a naming bikeshed >> discussion! ... >> * use the hwcaps names that Linux defines and prints in /proc/cpuinfo >>(in this case that would be a combination of "fphp" and "asimdhp", >>since hwcaps

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-21 Thread Eric Blake
On 02/21/2018 11:39 AM, Kevin Wolf wrote: See my commit message comment - we have other spots in the code base that blindly g_malloc(2 * s->cluster_size). Though is that a reason to do the same in new code or to phase out such allocations whenever you touch them? Touché. And I intended

[Qemu-devel] [RFC PATCH 5/5] sdl2: use only QKeyCode in sdl2_process_key()

2018-02-21 Thread Gerd Hoffmann
Small cleanup. Also drop the special backspace handling, kbd_put_qcode_console() learned to handle that meanwhile. And sdl2_process_key is never called with scon == NULL. Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 10 +++--- 1 file changed, 3 insertions(+), 7

Re: [Qemu-devel] [PATCH v7 15/23] qmp: add new event "command-dropped"

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:49PM +0800, Peter Xu wrote: > This event will be emitted if one QMP command is dropped. Along, > declare an enum for the reasons. > > Reviewed-by: Fam Zheng > Signed-off-by: Peter Xu > --- > qapi-schema.json | 37

Re: [Qemu-devel] [PATCH v1 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-21 Thread Cornelia Huck
On Wed, 21 Feb 2018 17:51:19 +0100 Claudio Imbrenda wrote: > On Wed, 21 Feb 2018 16:34:59 +0100 > Cornelia Huck wrote: > > > On Tue, 20 Feb 2018 19:45:02 +0100 > > Claudio Imbrenda wrote: > > > +static const

<    1   2   3   >