Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 10:11, Liu, Yi L wrote: >> Do you really need VTDDeviceNode? I think can you simply put the >> QLIST_ENTRY in VTDAddressSpace (named e.g. next_by_pasid), since >> VTDAddressSpace already includes a (bus, devfn). > Existing VTDAddressSpace is actaully per-device. While for PASID

Re: [Qemu-devel] [PATCH v3] iotests: Tweak 030 in order to trigger a race condition with parallel jobs

2018-03-06 Thread Alberto Garcia
On Mon 05 Mar 2018 05:59:47 PM CET, Max Reitz wrote: > Secondly, I've reverted 3d5d319e1221082 to test this, and I could > reproduce failure exactly once. Since then, no luck (in like 20 > attempts, I think)... Oh, I see. I was bisecting this and it seems that 1a63a907507fbbcf made this problem

Re: [Qemu-devel] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Kevin Wolf
Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben: > On 5 March 2018 at 17:51, Kevin Wolf wrote: > > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20180302' into

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 11:43, Peter Xu wrote: > On Mon, Mar 05, 2018 at 04:43:09PM +0800, Liu, Yi L wrote: >> On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote: >>> On 01/03/2018 11:33, Liu, Yi L wrote: +pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD); +

Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 09:42, Liu, Yi L wrote: >> In general I think it's better to change your names from "assigned_dev" >> to "sva_dev", because the point of the list is to only iterate over >> devices that might be interested in using SVA. > > For "assigned_dev", my purpose is to distinguish "assigned

Re: [Qemu-devel] [PATCH v3] numa: we don't implement NUMA for s390x

2018-03-06 Thread Cornelia Huck
On Tue, 27 Feb 2018 12:02:55 +0100 David Hildenbrand wrote: > Right now it is possible to crash QEMU for s390x by providing e.g. > -numa node,nodeid=0,cpus=0-1 > > Problem is, that numa.c uses mc->cpu_index_to_instance_props as an > indicator whether NUMA is supported by a

Re: [Qemu-devel] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 5 March 2018 at 17:51, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the

[Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

2018-03-06 Thread Nia Alarie
Allows a branch to be removed - this function always returns 0. Signed-off-by: Nia Alarie Reviewed-by: Christian Borntraeger --- hw/s390x/virtio-ccw.c | 6 +++--- hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers

2018-03-06 Thread Nia Alarie
The other event handlers (quiesce and cpu) do not define these handlers, and this one does nothing, so it can be removed. Signed-off-by: Nia Alarie Reviewed-by: Christian Borntraeger --- hw/char/sclpconsole-lm.c | 6 --

Re: [Qemu-devel] [Qemu-block] [PATCH] block: include original filename when reporting invalid URIs

2018-03-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 10:52:04AM +, Daniel P. Berrangé wrote: > Consider passing a JSON based block driver to "qemu-img commit" > > $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ > "volume":"gv0","path":"sn1.qcow2", >

Re: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-03-06 Thread David Hildenbrand
On 27.02.2018 16:44, Tony Krowiak wrote: > This patch series is the QEMU counterpart to the KVM/kernel support for > guest dedicated crypto adapters. The KVM/kernel model is built on the > VFIO mediated device framework and provides the infrastructure for > granting exclusive guest access to

[Qemu-devel] [PATCH v7 5/9] secondary-vga: properly close QemuConsole on unplug

2018-03-06 Thread Gerd Hoffmann
Using the new graphic_console_close() function. Signed-off-by: Gerd Hoffmann --- hw/display/vga-pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 1674bd3581..f312930664 100644 --- a/hw/display/vga-pci.c +++

[Qemu-devel] [PATCH v7 6/9] vfio/common: cleanup in vfio_region_finalize

2018-03-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vfio/common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index f895e3c335..6a8203a532 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -858,6 +858,13 @@ void

[Qemu-devel] [PATCH v7 9/9] vfio/display: adding dmabuf support

2018-03-06 Thread Gerd Hoffmann
Wire up dmabuf-based display. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 14 hw/vfio/display.c | 185 +- 2 files changed, 196 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v7 1/9] linux-headers: update to 4.16-rc1

2018-03-06 Thread Gerd Hoffmann
s390 has splitted syscall numbers into unistd_{32,64}.h files, so update scripts/update-linux-headers.sh accordingly. Also add a rewrite from __BITS_PER_LONG to HOST_LONG_BITS for linux/input.h Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PATCH v7 2/9] standard-headers: add drm/drm_fourcc.h

2018-03-06 Thread Gerd Hoffmann
So we can use the drm fourcc codes without a dependency on libdrm-devel. Signed-off-by: Gerd Hoffmann --- include/standard-headers/drm/drm_fourcc.h | 411 ++ scripts/update-linux-headers.sh | 5 + 2 files changed, 416 insertions(+)

[Qemu-devel] [PATCH v7 8/9] vfio/display: adding region support

2018-03-06 Thread Gerd Hoffmann
Wire up region-based display. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 1 + include/hw/vfio/vfio-common.h | 8 +++ hw/vfio/display.c | 116 +- 3 files changed, 123 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v7 3/9] ui/pixman: add qemu_drm_format_to_pixman()

2018-03-06 Thread Gerd Hoffmann
Map drm fourcc codes to pixman formats. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h | 5 + ui/qemu-pixman.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index

[Qemu-devel] [PATCH v7 7/9] vfio/display: core & wireup

2018-03-06 Thread Gerd Hoffmann
Infrastructure for display support. Must be enabled using 'display' property. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 4 hw/vfio/display.c | 56 +++ hw/vfio/pci.c | 10 +

[Qemu-devel] [PATCH v7 0/9] vfio: add display support

2018-03-06 Thread Gerd Hoffmann
This series adds support for a vgpu display to the qemu vfio code. v7: - rebase to latest master. - dmabuf: update cursor hotspot properly (Tina). - dmabuf: track whenever cursor hotspot + position changes. - codestryle fixes. v6: - add support for hotplugging QemuConsoles. - drop

[Qemu-devel] [PATCH v7 4/9] console: minimal hotplug suport

2018-03-06 Thread Gerd Hoffmann
This patch allows to unbind devices from QemuConsoles, using the new graphic_console_close() function. The QemuConsole will show a static display then, saying the device was unplugged. When re-plugging a display later on the QemuConsole will be reused. Eventually we will allocate and release

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-06 Thread Cornelia Huck
On Tue, 6 Mar 2018 09:23:23 +0100 Christian Borntraeger wrote: > On 03/05/2018 04:27 PM, Cornelia Huck wrote: > > On Fri, 2 Mar 2018 10:44:46 +0100 > > Christian Borntraeger wrote: > > > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: >

Re: [Qemu-devel] [PATCH] hw/s390x: Add the possibility to specify the netboot image on the command line

2018-03-06 Thread Cornelia Huck
On Tue, 27 Feb 2018 12:32:34 +0100 Thomas Huth wrote: > The file name of the netboot binary is currently hard-coded to > "s390-netboot.img", without a possibility for the user to select > an alternative firmware image here. That's unfortunate, especially > since the basics are

[Qemu-devel] [PATCH v2 2/6] ui/gtk: group gtk.mo declarations in Makefile

2018-03-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index d1203bb80a..b560ee12c3 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -38,6 +38,13 @@

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

2018-03-06 Thread Andrea Bolognani
On Tue, 2018-03-06 at 14:30 +1300, Michael Clark wrote: > I'm currently working on some changes locally to split the firmware from > the kernel image. Currently the kernel image is embedded in the firmware (r > iscv-pk/bbl). I was wondering about this just yesterday. Will this eventually lead to

[Qemu-devel] [PATCH v2 0/6] gtk: add support for dmabufs

2018-03-06 Thread Gerd Hoffmann
v2: rebase, add some makefile cleanups. Gerd Hoffmann (6): ui/gtk: make GtkGlArea usage a runtime option ui/gtk: group gtk.mo declarations in Makefile ui/opengl: Makefile cleanup ui/gtk: use GtkGlArea on wayland only ui/gtk-egl: add scanout_dmabuf support ui/gtk-egl: add cursor_dmabuf

[Qemu-devel] [PATCH v2 3/6] ui/opengl: Makefile cleanup

2018-03-06 Thread Gerd Hoffmann
With gtk.mo bits moved away we don't need the ifeq any more. Also add missing opengl libs for some objects. Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs

[Qemu-devel] [PATCH v2 4/6] ui/gtk: use GtkGlArea on wayland only

2018-03-06 Thread Gerd Hoffmann
For dma-buf support we need a egl context. The gtk x11 backend uses glx contexts though. We can't use the GtkGlArea widget on x11 because of that, so use our own gtk-egl code instead. wayland continues to use the GtkGlArea widget. Signed-off-by: Gerd Hoffmann --- ui/gtk.c

[Qemu-devel] [PATCH v2 1/6] ui/gtk: make GtkGlArea usage a runtime option

2018-03-06 Thread Gerd Hoffmann
Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime instead of compile time which opengl variant we want use. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 2 ++ ui/gtk.c | 53 +

[Qemu-devel] [PATCH v2 5/6] ui/gtk-egl: add scanout_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for dmabuf scanouts to gtk-egl. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 4 ui/gtk-egl.c | 23 +++ ui/gtk.c | 2 ++ 3 files changed, 29 insertions(+) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index

[Qemu-devel] [PATCH v2 6/6] ui/gtk-egl: add cursor_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for cursor dmabufs to gtk-egl. Just blend in the cursor (if we have one) when rendering the dmabuf. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 8 ui/gtk-egl.c | 40 +++- ui/gtk.c | 2 ++ 3 files

Re: [Qemu-devel] [PATCH v3 03/12] hw/core: introduce IOMMUSVAContext for virt-SVA

2018-03-06 Thread Liu, Yi L
On Mon, Mar 05, 2018 at 02:25:09PM +1100, David Gibson wrote: > On Thu, Mar 01, 2018 at 06:31:53PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > This patch adds IOMMUSVAContext as an abstract for virt-SVA in > > Qemu. > > > > IOMMUSVAContext is per-PASID(Process Address

Re: [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled

2018-03-06 Thread Richard Henderson
On 03/05/2018 09:56 PM, Mark Cave-Ayland wrote: > Thanks for reviewing the patch Richard. Do you want me to take this one via my > qemu-sparc branch? Yes, please. r~

Re: [Qemu-devel] [PATCH v2 26/30] hw/smbios: use the BYTE-based definitions

2018-03-06 Thread Igor Mammedov
On Mon, 5 Mar 2018 08:27:28 -0300 Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump

2018-03-06 Thread Thomas Huth
On 05.03.2018 17:50, Eric Blake wrote: > On 03/05/2018 10:37 AM, Thomas Huth wrote: >> QEMU's screendump command can only take dumps from the primary display. >> When using multiple VGA cards, there is no way to get a dump from a >> secondary card or other display heads yet. So let's add an

Re: [Qemu-devel] [PATCH v8 03/23] RISC-V CPU Core Definition

2018-03-06 Thread Igor Mammedov
On Tue, 6 Mar 2018 11:24:02 +1300 Michael Clark wrote: > On Mon, Mar 5, 2018 at 10:44 PM, Igor Mammedov wrote: > > > On Sat, 3 Mar 2018 02:51:31 +1300 > > Michael Clark wrote: > > > > > Add CPU state header, CPU definitions and

Re: [Qemu-devel] [PATCH] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-06 Thread Liran Alon
Gentle ping. (http://patchwork.ozlabs.org/patch/878657/) - liran.a...@oracle.com wrote: > This MSR returns the number of #SMIs that occurred on > CPU since boot. > > KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT") > introduced support for emulating this MSR. > > This

Re: [Qemu-devel] [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-06 Thread Laszlo Ersek
On 03/06/18 01:45, Brian J. Johnson wrote: > On 03/05/2018 12:22 PM, Laszlo Ersek wrote: >> PEIMs generally "execute in place" (XIP), i.e. they run from flash, not >> RAM. In this status they use "temporary RAM" (e.g. CPU caches configured >> like RAM) for stack & heap; whatever HOBs they produce

[Qemu-devel] [PATCH v2 2/3] spice: add scanout_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for scanout dmabufs. Just pass them through to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index f3ae6beb3d..a494db1196 100644 ---

[Qemu-devel] [PATCH v2 3/3] spice: add cursor_dmabuf support

2018-03-06 Thread Gerd Hoffmann
Add support for cursor dmabufs. qemu has to render the cursor for that, so in case a cursor is present qemu allocates a new dmabuf, blits the scanout, blends in the pointer and passes on the new dmabuf to spice-server. Without cursor qemu continues to simply pass on the scanout dmabuf as-is.

[Qemu-devel] [PATCH v2 0/3] spice: add support for dmabufs

2018-03-06 Thread Gerd Hoffmann
v2: rebase, fix codestyle issues. Gerd Hoffmann (3): spice: drop dprint() debug logging spice: add scanout_dmabuf support spice: add cursor_dmabuf support include/ui/spice-display.h | 9 +++ ui/spice-display.c | 194 - ui/trace-events

[Qemu-devel] [PATCH v2 1/3] spice: drop dprint() debug logging

2018-03-06 Thread Gerd Hoffmann
Some calls are deleted, some are converted into tracepoints. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 75 -- ui/trace-events| 9 +++ 2 files changed, 31 insertions(+), 53 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

2018-03-06 Thread Cornelia Huck
On Tue, 6 Mar 2018 09:13:33 +0100 Christian Borntraeger wrote: > On 03/05/2018 06:49 PM, Nia Alarie wrote: > > The other event handlers (quiesce and cpu) do not define these > > handlers, and this one does nothing, so it can be removed. > > > > virtio_ccw_exit always

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-06 Thread Christian Borntraeger
On 03/05/2018 04:27 PM, Cornelia Huck wrote: > On Fri, 2 Mar 2018 10:44:46 +0100 > Christian Borntraeger wrote: > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: >>> Extend the SCLP event masks to 64 bits. >>> >>> Notice that using any of the new bits results in a

Re: [Qemu-devel] [PATCH] tap: delete tap(net client) if net_init_tap_one failed

2018-03-06 Thread Jason Wang
On 2018年03月06日 13:11, linzhecheng wrote: If net_init_tap_one failed but net_tap_fd_init succeeded, we should delete the TAPState *s without vhostforce and has_vhostforce flag. Signed-off-by: linzhecheng Applied and queued for stable. Thanks diff --git

Re: [Qemu-devel] [PATCH 0/7] memory: address_space_to_flatview needs RCU lock

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 08:47, Alexey Kardashevskiy wrote: > On 05/03/18 19:36, Paolo Bonzini wrote: >> I noticed that the introduction of flatview_{read,write} placed >> address_space_to_flatview outside the RCU lock. This is wrong and has >> to be fixed, because address_space_to_flatview does an

Re: [Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

2018-03-06 Thread Christian Borntraeger
On 03/05/2018 06:49 PM, Nia Alarie wrote: > The other event handlers (quiesce and cpu) do not define these > handlers, and this one does nothing, so it can be removed. > > virtio_ccw_exit always returns 0, so change its return type to > void. > > Signed-off-by: Nia Alarie

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

2018-03-06 Thread Christian Borntraeger
On 03/06/2018 07:18 AM, Thomas Huth wrote: > bootmap.h can currently only be included once - otherwise the linker > complains about multiple definitions of the "magic" strings. It's a > bad style to define string arrays in header files, so let's better > move these to the bootmap.c file instead

Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier

2018-03-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, March 6, 2018 2:45 PM > Subject: Re: [PATCH v3 07/12] vfio/pci: register sva notifier > > On Thu, Mar 01, 2018 at 06:33:30PM +0800, Liu, Yi L wrote: > > This patch shows how sva notifier is registered. And provided an > > example by

<    1   2   3   4   5