Re: [Qemu-devel] [PATCH v9 03/14] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-03-08 Thread Peter Maydell
On 8 March 2018 at 18:56, Auger Eric wrote: > Hi Peter, > On 07/03/18 17:35, Peter Maydell wrote: >> On 7 March 2018 at 16:23, Auger Eric wrote: >>> Hi Peter, >>> >>> On 06/03/18 20:43, Peter Maydell wrote: On 17 February 2018 at 18:46, Eric Auger wrote: > +#define is_permission_fault(a

[Qemu-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post

2018-03-08 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread Ian Jackson
This just-amended series provides necessary support for running qemu as a Xen device model without power equivalent to root. In particular, it makes -xen-domid-restrict effective. Compared to v6, it fixes some minor checkpatch, style and portability issues. Sorry for the earlier troubled submiss

[Qemu-devel] [PATCH 02/12] xen: link against xentoolcore

2018-03-08 Thread Ian Jackson
From: Anthony PERARD Xen libraries in 4.10 include a new xentoolcore library. This contains the xentoolcore_restrict_all function which we are about to want to use. Signed-off-by: Ian Jackson Acked-by: Stefano Stabellini --- v5: More truthful commit message. --- configure | 8 +--- 1 fil

[Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2018-03-08 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD

[Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash

2018-03-08 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

Re: [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
08.03.2018 21:56, Emilio G. Cota wrote: On Thu, Mar 08, 2018 at 14:42:29 +0300, Vladimir Sementsov-Ogievskiy wrote: Hi Emilio! Looked through qdist, if I understand correctly, it saves each added (with different value) element. It is not effective for disk io timing - we'll have too much elemen

[Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file

2018-03-08 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers w

[Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable

2018-03-08 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index

[Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file

2018-03-08 Thread Ian Jackson
If you pass scripts/get_maintainer.pl the name of a FIFO or other exciting object (/dev/stdin, for example), it would falsely print "file not found". Instead: stat the object rather than using -f so that we do not mind if the object is not a file; and print the errno value in the error message. S

[Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types

2018-03-08 Thread Ian Jackson
This avoids checkpatch misparsing (as statements) long function definitions or declarations, which sometimes start with constructs like this: static inline int xendevicemodel_relocate_memory( xendevicemodel_handle *dmod, domid_t domid, ... CC: Eric Blake CC: Paolo Bonzini CC: Daniel P.

[Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-03-08 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

Re: [Qemu-devel] [edk2] [PATCH v2 7/8] ovmf: link with Tcg2Dxe module

2018-03-08 Thread Laszlo Ersek
On 03/07/18 16:57, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This module measures and log the boot environment. It also produces > the Tcg2 protocol, which allows for example to read the log from OS. > > The linux kernel doesn't yet read the EFI_TCG2_EVENT_LOG_FORMAT_TCG_2

Re: [Qemu-devel] [PATCH v9 10/14] hw/arm/smmuv3: Abort on vfio or vhost case

2018-03-08 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > At the moment, the SMMUv3 does not support notification on > TLB invalidation. So let's abort as soon as such notifier gets > enabled. > > Signed-off-by: Eric Auger > --- > hw/arm/smmuv3.c | 11 +++ > 1 file changed, 11 insertions(+) > >

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-08 Thread Guenter Roeck
On Thu, Mar 08, 2018 at 10:28:39AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Guenter Roeck had to > walk into mine at 09:12 on Thursday 08 March 2018 and say: > > > On Thu, Mar 08, 2018 at 02:51:04PM +, Peter Maydell wrote: > > > On 8 March 2018 at 14:

Re: [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize

2018-03-08 Thread nee
On Thu, Mar 8, 2018 at 4:13 PM, Stefan Hajnoczi wrote: > On Wed, Mar 07, 2018 at 04:29:58PM +, Nia Alarie wrote: >> @@ -760,12 +760,12 @@ static int virtio_ccw_exit(VirtioCcwDevice *dev) >> if (sch) { >> css_subch_assign(sch->cssid, sch->ssid, sch->schid, sch->devno, >> NULL); >

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-08 Thread Palmer Dabbelt
On Thu, 08 Mar 2018 03:41:33 PST (-0800), Michael Clark wrote: On Fri, 9 Mar 2018 at 12:18 AM, Michael Clark wrote: On Fri, 9 Mar 2018 at 12:10 AM, Michael Clark wrote: On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell wrote: On 6 March 2018 at 19:46, Michael Clark wrote: You are making this

Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1520530757-4477-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 2/2 v2] slirp: Add classless static routes support to DHCP server

2018-03-08 Thread Eric Blake
On 03/08/2018 12:57 PM, Benjamin Drung wrote: This patch will allow the user to specify classless static routes for the replies from the built-in DHCP server. Signed-off-by: Benjamin Drung --- For future patches, when sending a v2, it's best to document here (after the --- separator) what ch

Re: [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Eric Blake
On 03/08/2018 12:58 PM, Vladimir Sementsov-Ogievskiy wrote: Hm. these numbers are actually boundary points of histogram intervals, not intervals itself. And, wiki says "The bins are usually specified as consecutive, non-overlapping intervals of a variable.", so, intervals are bins. So, what a

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-08 Thread Michael Clark
On Fri, Mar 9, 2018 at 8:29 AM, Palmer Dabbelt wrote: > On Thu, 08 Mar 2018 03:41:33 PST (-0800), Michael Clark wrote: > >> On Fri, 9 Mar 2018 at 12:18 AM, Michael Clark wrote: >> >>> On Fri, 9 Mar 2018 at 12:10 AM, Michael Clark wrote: >>> On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell >>>

<    1   2   3   4   5