Re: [Qemu-devel] [PATCH v1 1/4] .travis.yml: drop setting default log output

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:07PM +, Alex Bennée wrote: > The log backend is the default one, we don't need to explicitly set it. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 79

Re: [Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:09PM +, Alex Bennée wrote: > As all the disabled features only affect system emulation we might as > well disable user mode to save compile time. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Qemu-devel] [PATCH v1 2/4] .travis.yml: split default config into system and user

2018-03-13 Thread Alex Bennée
As the build times have risen we keep timing out. Split the default config into system and user builds. Signed-off-by: Alex Bennée --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 92c343a1ef..75e5b408d0 100644 --- a/.travis.yml

[Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

2018-03-13 Thread Alex Bennée
The tools are already built elsewhere so we might as well not build it here as we just need to test the modules build of QEMU itself. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c1e99237b2..373181c

[Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

2018-03-13 Thread Alex Bennée
As all the disabled features only affect system emulation we might as well disable user mode to save compile time. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 75e5b408d0..c1e99237b2 100644 --- a/.t

[Qemu-devel] [PATCH v1 0/4] Travis Build Speed-ups

2018-03-13 Thread Alex Bennée
Hi, As QEMU has grown it has started to hit the Travis timeouts a lot more. These patches try and address that by selectively adding --disable-user and --disable-system to the place (and adding a new matrix entry). : patch 0001/.travis.yml drop setting default log output.patch needs review : patc

Re: [Qemu-devel] [PULL 0/3] x86 queue, 2018-03-12

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 20:00, Eduardo Habkost wrote: > The following changes since commit b16a54da0696efc5d91b6c3597a37a317abb5de7: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180312-pull-request' > into staging (2018-03-12 14:06:23 +) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread nee
On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > On Mon, 12 Mar 2018 13:08:29 + > Daniel P. Berrangé wrote: > >> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >> > On Mon, 12 Mar 2018 07:12:52 -0500 >> > Eric Blake wrote: >> > >> > > On 03/11/2018 03:12 PM, Nia Alarie wrote:

Re: [Qemu-devel] [PATCH v3 1/2] block: Fix flags in reopen queue

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 15:20 hat Fam Zheng geschrieben: > Reopen flags are not synchronized according to the > bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a > bit too late: we already check the consistency in bdrv_check_perm before > that. > > This fixes the bug that when bdrv_re

Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-13 Thread Peter Xu
On Tue, Mar 13, 2018 at 09:17:36AM -0500, Eric Blake wrote: > On 03/13/2018 09:02 AM, Peter Maydell wrote: > > On 12 March 2018 at 18:35, Eric Blake wrote: > > > The following changes since commit > > > 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > > >Merge remote-tracking branch > > >

Re: [Qemu-devel] [PATCH v2 0/8] block: .bdrv_co_create for format drivers

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 15:47 hat Kevin Wolf geschrieben: > This series adds a .bdrv_co_create implementation to almost all format > drivers that support creating images where its still missing. The only > exception is VMDK because its support for extents will make the QAPI > design a bit more complicated

Re: [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 20:03, Ian Jackson wrote: > If you pass scripts/get_maintainer.pl the name of a FIFO or other > exciting object (/dev/stdin, for example), it would falsely print > "file not found". Instead: stat the object rather than using -f so > that we do not mind if the object is not a file; an

Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 20:02, Ian Jackson wrote: > This avoids checkpatch misparsing (as statements) long function > definitions or declarations, which sometimes start with constructs > like this: > > static inline int xendevicemodel_relocate_memory( > xendevicemodel_handle *dmod, domid_t domid, ..

Re: [Qemu-devel] [PATCH v2 8/8] vpc: Require aligned size in .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > Perform the rounding to match a CHS geometry only in the legacy code > path in .bdrv_co_create_opts. QMP now requires that the user already > passes a CHS aligned image size, unless force-size=true is given. > > CHS alignment is required to make the image c

[Qemu-devel] [PATCH 0/2] Give the refcount cache the minimum possible size by default

2018-03-13 Thread Alberto Garcia
Hi, we talked about this the other day, so here are the patches to change the default cache sizes in qcow2. Without this patch: * refcount-cache-size = l2-cache-size / 4 unless otherwise specified by the user. This is wasteful, the refcount cache is accessed sequentially during normal I/O, so

[Qemu-devel] [PATCH 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-03-13 Thread Alberto Garcia
The L2 and refcount caches have default sizes that can be overriden using the l2-cache-size and refcount-cache-size (an additional parameter named cache-size sets the combined size of both caches). Unless forced by one of the aforementioned parameters, QEMU will set the unspecified sizes so that t

[Qemu-devel] [PATCH 2/2] docs: Document the new default sizes of the qcow2 caches

2018-03-13 Thread Alberto Garcia
We have just reduced the refcount cache size to the minimum unless the user explicitly requests a larger one, so we have to update the documentation to reflect this change. Signed-off-by: Alberto Garcia --- docs/qcow2-cache.txt | 31 ++- 1 file changed, 14 insertions(

[Qemu-devel] [PATCH v1 6/6] migration: add postcopy total blocktime into query-migrate

2018-03-13 Thread Alexey Perevalov
Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migrate command will show fol

Re: [Qemu-devel] [PATCH v2 6/8] vhdx: Support .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vhdx, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 40 +- > block/vhdx.c | 216 > ++

Re: [Qemu-devel] [PATCH v2 7/8] vpc: Support .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vpc, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 33 ++- > block/vpc.c | 152 > ++

[Qemu-devel] [PATCH v1 4/6] migration: postcopy_blocktime documentation

2018-03-13 Thread Alexey Perevalov
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- docs/devel/migration.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 9d1b765..18cd95

[Qemu-devel] [PATCH v1 3/6] migration: calculate vCPU blocktime on dst side

2018-03-13 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted pa

[Qemu-devel] [PATCH v1 1/6] migration: introduce postcopy-blocktime capability

2018-03-13 Thread Alexey Perevalov
Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey P

[Qemu-devel] [PATCH v1 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-03-13 Thread Alexey Perevalov
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case this feature is provided by kernel. PostcopyBlocktimeContext is encapsulated inside postcopy-ram.c, due to it being a postcopy-only feature. Also it defines PostcopyBlocktimeContext's instance live time. Information from P

[Qemu-devel] [PATCH v1 5/6] migration: add blocktime calculation into migration-test

2018-03-13 Thread Alexey Perevalov
This patch just requests blocktime calculation, and check it in case when UFFD_FEATURE_THREAD_ID feature is set on the host. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- tests/migration-test.c | 16

Re: [Qemu-devel] [PATCH v2 5/8] vdi: Make comments consistent with other drivers

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > This makes the .bdrv_co_create(_opts) implementation of vdi look more > like the other recently converted block drivers. > > Signed-off-by: Kevin Wolf > --- > block/vdi.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: M

[Qemu-devel] [PATCH v2 6/8] vhdx: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vhdx, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 40 +- block/vhdx.c | 216 ++- 2 files changed, 203 insertions(+), 53 deletions(-)

[Qemu-devel] [PATCH v2 4/8] qed: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qed, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 25 ++- block/qed.c | 204 ++- 2 files changed, 162 insertions(+

[Qemu-devel] [PATCH v1 0/6] postcopy block time calculation + ppc32 build fix

2018-03-13 Thread Alexey Perevalov
This patch set includes patches which were reverted by commit ee86981bd, due to build problem on 32 powerpc/arm architecture. Also it includes patch to fix build ([PATCH v4] migration: change blocktime type to uint32_t), but that patch was merged into: migration: add postcopy blocktime ctx into Mig

Re: [Qemu-devel] [PATCH v3 0/2] block: Fix permission during reopen

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 15:20 hat Fam Zheng geschrieben: > v3: Fix test case. [Max] > > v2: Use update_flags_from_options. [Kevin] > > We write open the whole backing chain during reopen. It is not necessary and > will cause image locking problems if the backing image is shared. Thanks, applied to the

[Qemu-devel] [PATCH v2 1/8] parallels: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to parallels, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 18 - block/parallels.c| 199 ++- 2 fil

[Qemu-devel] [PATCH v2 3/8] qcow: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qcow, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 21 +- block/qcow.c | 196 ++- 2 files c

[Qemu-devel] [PATCH v2 8/8] vpc: Require aligned size in .bdrv_co_create

2018-03-13 Thread Kevin Wolf
Perform the rounding to match a CHS geometry only in the legacy code path in .bdrv_co_create_opts. QMP now requires that the user already passes a CHS aligned image size, unless force-size=true is given. CHS alignment is required to make the image compatible with Virtual PC, but not for use with n

[Qemu-devel] [PATCH v2 7/8] vpc: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vpc, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 33 ++- block/vpc.c | 152 ++- 2 files changed, 147 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH v2 0/8] block: .bdrv_co_create for format drivers

2018-03-13 Thread Kevin Wolf
This series adds a .bdrv_co_create implementation to almost all format drivers that support creating images where its still missing. The only exception is VMDK because its support for extents will make the QAPI design a bit more complicated. The other format driver not covered in this series are q

[Qemu-devel] [PATCH v2 2/8] qemu-iotests: Enable write tests for parallels

2018-03-13 Thread Kevin Wolf
Originally we added parallels as a read-only format to qemu-iotests where we did just some tests with a binary image. Since then, write and image creation support has been added to the driver, so we can now enable it in _supported_fmt generic. The driver doesn't support migration yet, though, so w

[Qemu-devel] [PATCH v2 5/8] vdi: Make comments consistent with other drivers

2018-03-13 Thread Kevin Wolf
This makes the .bdrv_co_create(_opts) implementation of vdi look more like the other recently converted block drivers. Signed-off-by: Kevin Wolf --- block/vdi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 8132e3adfe..d939b034c4

Re: [Qemu-devel] [PATCH 0/5] vfio/quirks: ioeventfd support

2018-03-13 Thread Auger Eric
Hi Alex, On 28/02/18 21:45, Alex Williamson wrote: > This is the QEMU counterpart to https://lkml.org/lkml/2018/2/28/1222 > > As described in the third patch, we have a use case for taking > advantage of existing KVM ioeventfd support for accelerating the > MSI-ACK behavior of NVIDIA GPUs. This s

Re: [Qemu-devel] [PATCH 1/1] hw/scsi: support SCSI-2 passthrough without PI

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 15:26, Daniel Henrique Barboza wrote: > QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK > works in the protocol, denying support for PI (Protection > Information) in case the guest OS requests it. However, in SCSI versions 2 > and older, there is no PI concept in the

[Qemu-devel] [PATCH 1/1] hw/scsi: support SCSI-2 passthrough without PI

2018-03-13 Thread Daniel Henrique Barboza
QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK works in the protocol, denying support for PI (Protection Information) in case the guest OS requests it. However, in SCSI versions 2 and older, there is no PI concept in the protocol. This means that when dealing with such devices:

Re: [Qemu-devel] [PATCH v3 0/2] block: Fix permission during reopen

2018-03-13 Thread Max Reitz
On 2018-03-13 15:20, Fam Zheng wrote: > v3: Fix test case. [Max] > > v2: Use update_flags_from_options. [Kevin] > > We write open the whole backing chain during reopen. It is not necessary and > will cause image locking problems if the backing image is shared. > > Fam Zheng (2): > block: Fix f

[Qemu-devel] [PATCH v3 2/2] iotests: Add regression test for commit base locking

2018-03-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 12 tests/qemu-iotests/153.out | 5 + 2 files changed, 17 insertions(+) diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 index adfd02695b..a0fd815483 100755 --- a/tests/qemu-iotests/153 +++ b/tests/qemu-iotes

[Qemu-devel] [PATCH v3 1/2] block: Fix flags in reopen queue

2018-03-13 Thread Fam Zheng
Reopen flags are not synchronized according to the bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a bit too late: we already check the consistency in bdrv_check_perm before that. This fixes the bug that when bdrv_reopen a RO node as RW, the flags for backing child are wrong. B

[Qemu-devel] [PATCH v3 0/2] block: Fix permission during reopen

2018-03-13 Thread Fam Zheng
v3: Fix test case. [Max] v2: Use update_flags_from_options. [Kevin] We write open the whole backing chain during reopen. It is not necessary and will cause image locking problems if the backing image is shared. Fam Zheng (2): block: Fix flags in reopen queue iotests: Add regression test for

Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-13 Thread Eric Blake
On 03/13/2018 09:02 AM, Peter Maydell wrote: On 12 March 2018 at 18:35, Eric Blake wrote: The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +) a

Re: [Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comment about search strategy

2018-03-13 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > Signed-off-by: Luke Shumaker > --- > linux-user/elfload.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index 1b7583d659..7736ea2c3a 100644 > --- a/linux-user/e

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 02:02:54PM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Fri, Feb 09, 2018 at 02:15:14PM +, Alex Bennée wrote: > >> The modules and co-routine builds are only really relevant to softmmu > >> builds and regularly timeout on Travis. Let's disable lin

Re: [Qemu-devel] [PATCH 08/10] linux-user: init_guest_space: Don't try to align if we'll reject it

2018-03-13 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > If the ensure-alignment code gets triggered, then the > "if (host_start && real_start != current_start)" check will always trigger, > so save 2 syscalls and put that check first. > > Note that we can't just switch to using

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

2018-03-13 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Feb 09, 2018 at 02:15:14PM +, Alex Bennée wrote: >> The modules and co-routine builds are only really relevant to softmmu >> builds and regularly timeout on Travis. Let's disable linux-user >> builds here for more headroom. >> >> Signed-off-by: Alex Benné

Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 18:35, Eric Blake wrote: > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 > 16:14:37 +) > > are available in the Git repository at

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Laurent Vivier
Le 13/03/2018 à 14:54, Peter Maydell a écrit : > On 13 March 2018 at 13:30, Laurent Vivier wrote: >> Le 09/03/2018 à 21:37, Laurent Vivier a écrit : >>> Le 28/12/2017 à 19:08, Luke Shumaker a écrit : --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1906,24 +1906,28 @@ unsig

Re: [Qemu-devel] [PATCH v2 3/8] nbd: BLOCK_STATUS for standard get_block_status function: server part

2018-03-13 Thread Eric Blake
On 03/13/2018 08:47 AM, Eric Blake wrote: On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy --- +/* nbd_negotiate_meta_queries + * Handle NBD_OPT_LIST_META_CONTEXT and

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Peter Maydell
On 13 March 2018 at 13:30, Laurent Vivier wrote: > Le 09/03/2018 à 21:37, Laurent Vivier a écrit : >> Le 28/12/2017 à 19:08, Luke Shumaker a écrit : >>> --- a/linux-user/elfload.c >>> +++ b/linux-user/elfload.c >>> @@ -1906,24 +1906,28 @@ unsigned long init_guest_space(unsigned long >>> host_star

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 02:49:42PM +0100, Paolo Bonzini wrote: > On 13/03/2018 14:40, Daniel P. Berrangé wrote: > >> @@ -52,9 +52,9 @@ env: > >> - CONFIG="" > >> - CONFIG="--enable-debug --enable-debug-tcg > >> --enable-trace-backends=log" > >> - CONFIG="--disable-linux-aio --disabl

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 14:40, Daniel P. Berrangé wrote: >> @@ -52,9 +52,9 @@ env: >> - CONFIG="" >> - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log" >> - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr >> --disable-brlapi --disable-uuid --disable-libusb" >

Re: [Qemu-devel] [PATCH v2 3/8] nbd: BLOCK_STATUS for standard get_block_status function: server part

2018-03-13 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: - constants and type defs were splitted out by Eric, except for NBD_META_ID_BASE_ALLOCATION The constant fo

[Qemu-devel] [Bug 1755479] [NEW] Cortex M:qemu abort with optimized code and icount

2018-03-13 Thread Antoine
Public bug reported: A basic program runs fine if compiled with flag -O0 with gcc, but triggers a qemu abort when compiled with -O1 and run with icount: "qemu: fatal: IO on conditional branch instruction" I also noticed the problem on C source like this with -O0: "int foo = *bar; bar++;" : OK "i

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

2018-03-13 Thread Daniel P . Berrangé
On Fri, Feb 09, 2018 at 02:15:14PM +, Alex Bennée wrote: > The modules and co-routine builds are only really relevant to softmmu > builds and regularly timeout on Travis. Let's disable linux-user > builds here for more headroom. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-D

Re: [Qemu-devel] [PATCH v9 11/14] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2018-03-13 Thread Paolo Bonzini
On 12/03/2018 16:16, Auger Eric wrote: >> It is still unclear to me if we need to register an IOMMUNotifier >> to handle any change in the MSI doorbell which would occur behind >> the scene and would not lead to any call to kvm_arch_fixup_msi_route(). > > Paolo, do you know the answer to this ques

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2018 16:11, Vladimir Sementsov-Ogievskiy wrote: 13.03.2018 13:30, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 12.03.2018 18:30, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: There would b

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Laurent Vivier
Le 09/03/2018 à 21:37, Laurent Vivier a écrit : > Le 28/12/2017 à 19:08, Luke Shumaker a écrit : >> From: Luke Shumaker >> >> Instead of doing >> >> if (check1) { >> if (check2) { >>success; >> } >> } >> >> retry; >> >> Do a clearer >

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

2018-03-13 Thread Auger Eric
Hi Alex, On 28/02/18 21:15, Alex Williamson wrote: > The ioeventfd here is actually irqfd handling of an ioeventfd such as > supported in KVM. A user is able to pre-program a device write to > occur when the eventfd triggers. This is yet another instance of > eventfd-irqfd triggering between KVM

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2018 13:30, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 12.03.2018 18:30, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: There would be savevm states (dirty-bitmap) which can migrate only i

[Qemu-devel] [PULL 18/22] cpu/i386: populate CPUID 0x8000_001F when SEV is active

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When SEV is enabled, CPUID 0x8000_001F should provide additional information regarding the feature (such as which page table bit is used to mark the pages as encrypted etc). The details for memory encryption CPUID is available in AMD APM (https://support.amd.com/TechDocs/2459

[Qemu-devel] [PULL 16/22] sev/i386: finalize the SEV guest launch flow

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV launch flow requires us to issue LAUNCH_FINISH command before guest is ready to run. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- target/i386/sev.c| 29 +

[Qemu-devel] [PULL 15/22] sev/i386: add support to LAUNCH_MEASURE command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be used to retrieve the measurement of the encrypted memory region. This measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the m

Re: [Qemu-devel] [PATCH v2 1/2] block: Fix flags in reopen queue

2018-03-13 Thread Max Reitz
On 2018-03-13 12:58, Fam Zheng wrote: > Reopen flags are not synchronized according to the > bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a > bit too late: we already check the consistency in bdrv_check_perm before > that. > > This fixes the bug that when bdrv_reopen a RO no

[Qemu-devel] [PULL 14/22] target/i386: encrypt bios rom

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV requires that guest bios must be encrypted before booting the guest. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- hw/i386/pc_sysfw.c | 13 + 1 file cha

[Qemu-devel] [PULL 22/22] sev/i386: add sev_get_capabilities()

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The function can be used to get the current SEV capabilities. The capabilities include platform diffie-hellman key (pdh) and certificate chain. The key can be provided to the external entities which wants to establish a trusted channel between SEV firmware and guest owner. Cc

[Qemu-devel] [PULL 12/22] sev/i386: add command to create launch memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK). The encryption key created with the command will be used for encrypting the bootstrap images (such as guest bios). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Sin

[Qemu-devel] [PULL 20/22] sev/i386: qmp: add query-sev-launch-measure command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used by libvirt to retrieve the measurement of SEV guest. This measurement is a signature of the memory contents that was encrypted through the LAUNCH_UPDATE_DATA. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: E

[Qemu-devel] [PULL 19/22] sev/i386: hmp: add 'info sev' command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used to show the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: "Dr. David Alan Gilbert" Signed-off-by: Brijesh Singh Signed-of

[Qemu-devel] [PULL 07/22] target/i386: add Secure Encrypted Virtualization (SEV) object

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Add a new memory encryption object 'sev-guest'. The object will be used to create encrypted VMs on AMD EPYC CPU. The object provides the properties to pass guest owner's public Diffie-hellman key, guest policy and session information required to create the memory encryption co

Re: [Qemu-devel] [PATCH v2 2/2] iotests: Add regression test for commit base locking

2018-03-13 Thread Max Reitz
On 2018-03-13 12:58, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/153 | 8 > tests/qemu-iotests/153.out | 4 > 2 files changed, 12 insertions(+) > > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 > index adfd02695b..a7875e6899 100755 > --

[Qemu-devel] [PULL 17/22] sev/i386: add migration blocker

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- target/i386/sev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index b

[Qemu-devel] [PULL 21/22] sev/i386: qmp: add query-sev-capabilities command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used by libvirt to query the SEV capabilities. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- monitor.c | 7 +++ qapi/misc.json| 42 +++

[Qemu-devel] [PULL 08/22] sev/i386: qmp: add query-sev command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The QMP query command can used to retrieve the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Brijesh Singh Signed-off-b

[Qemu-devel] [PULL 10/22] sev/i386: add command to initialize the memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When memory encryption is enabled, KVM_SEV_INIT command is used to initialize the platform. The command loads the SEV related persistent data from non-volatile storage and initializes the platform context. This command should be first issued before invoking any other guest com

[Qemu-devel] [PULL 11/22] sev/i386: register the guest memory range which may contain encrypted data

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When SEV is enabled, the hardware encryption engine uses a tweak such that the two identical plaintext at different location will have a different ciphertexts. So swapping or moving a ciphertexts of two guest pages will not result in plaintexts being swapped. Hence relocating

[Qemu-devel] [PULL 13/22] sev/i386: add command to encrypt guest memory region

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory region using the VM Encryption Key created using LAUNCH_START. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- target/i386/

[Qemu-devel] [PULL 09/22] include: add psp-sev.h header file

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The header file provide the ioctl command and structure to communicate with /dev/sev device. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Brijesh Singh --- linux-headers/linux/psp-sev.h | 142

[Qemu-devel] [PULL 06/22] kvm: introduce memory encryption APIs

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Inorder to integerate the Secure Encryption Virtualization (SEV) support add few high-level memory encryption APIs which can be used for encrypting the guest memory region. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 05/22] kvm: add memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Split from a patch by Brijesh Singh (brijesh.si...@amd.com). Signed-off-by: Paolo Bonzini Signed-off-by: Brijesh Singh --- accel/Makefile.objs | 2 +- accel/kvm/Makefile.objs | 3 ++- accel/kvm/kvm-all.c | 25 + accel/kvm/sev-stub.c| 2

[Qemu-devel] [PULL 01/22] update Linux headers to 4.16-rc5

2018-03-13 Thread Paolo Bonzini
Note that VIRTIO_GPU_CAPSET_VIRGL2 was added manually so it has to be added manually after re-running scripts/update-linux-headers.sh. Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/input.h | 11 + include/

[Qemu-devel] [PULL 00/22] KVM patches for QEMU 2.12 soft freeze

2018-03-13 Thread Paolo Bonzini
The following changes since commit fb5fff15881ba7a002924b967eb211c002897983: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180312-pull-request' into staging (2018-03-12 18:35:37 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream-sev

[Qemu-devel] [PULL 03/22] machine: add memory-encryption option

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When CPU supports memory encryption feature, the property can be used to specify the encryption object to use when launching an encrypted guest. Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Stefan Hajnoczi Signed-off-by: Brijesh Singh Signed-off-by: Pao

[Qemu-devel] [PULL 04/22] docs: add AMD Secure Encrypted Virtualization (SEV)

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Create a documentation entry to describe the AMD Secure Encrypted Virtualization (SEV) feature. Cc: Paolo Bonzini Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- docs/amd-memory-encryption.txt | 92 ++ 1 file changed,

[Qemu-devel] [PULL 02/22] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-13 Thread Paolo Bonzini
From: Liran Alon This MSR returns the number of #SMIs that occurred on CPU since boot. KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT") introduced support for emulating this MSR. This commit adds support for QEMU to save/load this MSR for migration purposes. Signed-off-by:

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-13 Thread 858585 jemmy
Ping. On Sat, Mar 10, 2018 at 10:32 PM, Lidong Chen wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen > --- > migration/qemu-file.

Re: [Qemu-devel] [PULL 0/1] Docker patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 17:26, Fam Zheng wrote: > The following changes since commit b16a54da0696efc5d91b6c3597a37a317abb5de7: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180312-pull-request' > into staging (2018-03-12 14:06:23 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-03-13 Thread Auger Eric
Hi, On 08/02/18 02:22, Alexey Kardashevskiy wrote: > On 08/02/18 01:12, Alex Williamson wrote: >> On Wed, 7 Feb 2018 15:48:26 +1100 >> Alexey Kardashevskiy wrote: >> >>> On 07/02/18 15:25, Alex Williamson wrote: On Wed, 7 Feb 2018 15:09:22 +1100 Alexey Kardashevskiy wrote: > On 0

Re: [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-03-13 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 28, 2018 at 08:14:19PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Wed, Feb 14, 2018 at 06:56:59PM +, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On Tue, Feb

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-13 Thread Fam Zheng
On Tue, 03/13 13:05, Paolo Bonzini wrote: > Install optional dependencies of QEMU to get better coverage. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/tests/docker/dockerfi

[Qemu-devel] [PATCH v2] update Linux headers to 4.16-rc5

2018-03-13 Thread Paolo Bonzini
Note that VIRTIO_GPU_CAPSET_VIRGL2 was added manually so it has to be added manually after re-running scripts/update-linux-headers.sh. Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/input.h | 11 + include/

[Qemu-devel] [PULL 1/1] block: include original filename when reporting invalid URIs

2018-03-13 Thread Jeff Cody
From: Daniel P. Berrangé Consider passing a JSON based block driver to "qemu-img commit" $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ "volume":"gv0","path":"sn1.qcow2", "server":[{"type":\ "tcp","host":"10.73.199.197

[Qemu-devel] [PULL 0/1] Block patches

2018-03-13 Thread Jeff Cody
The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-13 10:49:02 +) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-r

Re: [Qemu-devel] [PATCH 7/7] vpc: Support .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 12:32, Kevin Wolf wrote: > Am 12.03.2018 um 22:49 hat Max Reitz geschrieben: >> On 2018-03-09 22:46, Kevin Wolf wrote: >>> This adds the .bdrv_co_create driver callback to vpc, which >>> enables image creation over QMP. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> qapi/block-core.j

Re: [Qemu-devel] [PATCH 1/3] vfio/pci: Pull BAR mapping setup from read-write path

2018-03-13 Thread Auger Eric
Hi Alex, On 28/02/18 21:14, Alex Williamson wrote: > This creates a common helper that we'll use for ioeventfd setup. > > Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Thanks Eric > --- > drivers/vfio/pci/vfio_pci_rdwr.c | 39 > ++ > 1 file cha

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 03/12/2018 11:30 AM, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > >> There would be savevm states (dirty-bitmap) which can migrate only in > >> postcopy stage. The corresponding pending is intro

[Qemu-devel] [PATCH v3 1/1] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-13 Thread Jeff Cody
From: Liang Li When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. Libvirt depends on the curr

<    1   2   3   4   5   6   >