Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

On Thu, Mar 22, 2018 at 08:03:53PM +0800, Xiao Guangrong wrote: > > > On 03/21/2018 06:00 PM, Peter Xu wrote: > > On Tue, Mar 13, 2018 at 03:57:34PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > Currently the page being compressed is

Re: [Qemu-devel] [PATCH v1 01/14] tests: add fp-bench, a collection of simple floating-point microbenchmarks

Emilio G. Cota writes: > This will allow us to measure the performance impact of FP > emulation optimizations. > > Signed-off-by: Emilio G. Cota > --- > tests/fp-bench.c | 290 > + > tests/.gitignore

Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

Hi Emilio, On 03/27/2018 07:33 AM, Emilio G. Cota wrote: > v1: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg05908.html > [...] > > Perf numbers are in the last patch. They are a little different than > last week; I cannot replicate last week's performance (even with > the very

Re: [Qemu-devel] [RFC for-2.13 03/12] target/ppc: Pass cpu instead of env to ppc_create_page_sizes_prop()

On Tue, 27 Mar 2018 15:37:32 +1100 David Gibson wrote: > As a rule we prefer to pass PowerPCCPU instead of CPUPPCState, and this > change will make some things simpler later on. > > Signed-off-by: David Gibson > --- Reviewed-by: Greg

Re: [Qemu-devel] [PATCH 0/5] dma/i82374: avoid double creation of i82374 device

On 26/03/2018 - 12:34:36, Philippe Mathieu-Daudé wrote: > Hi, > > This series intend to fix: https://bugs.launchpad.net/qemu/+bug/1721224 > > Patch #1 is the fix for 2.12, following patches are just refactors for 2.13. > > The 8257 only has 4 DMA channels. To have 8 channels, the IBM PC/AT >

[Qemu-devel] [PATCH] virtio-serial: fix heap-over-flow

Check device having the feature of VIRTIO_CONSOLE_F_EMERG_WRITE before get config->emerg_wr. It is neccessary because sizeof(virtio_console_config) is 8 byte if VirtIOSerial doesn't have the feature of VIRTIO_CONSOLE_F_EMERG_WRITE(see virtio_serial_device_realize), read/write emerg_wr will lead to

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

On Thu, Mar 22, 2018 at 07:57:54PM +0800, Xiao Guangrong wrote: > > > On 03/21/2018 05:06 PM, Peter Xu wrote: > > On Tue, Mar 13, 2018 at 03:57:33PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > Current code uses

Re: [Qemu-devel] [RFC for-2.13 04/12] target/ppc: Avoid taking "env" parameter to mmu-hash64 functions

On Tue, 27 Mar 2018 15:37:33 +1100 David Gibson wrote: > In most cases we prefer to pass a PowerPCCPU rather than the (embedded) > CPUPPCState. > > For ppc_hash64_update_{rmls,vrma}() change to take "cpu" instead of "env". > For ppc_hash64_set_{dsi,isi}() remove the

Re: [Qemu-devel] [RFC for-2.13 03/12] target/ppc: Pass cpu instead of env to ppc_create_page_sizes_prop()

On 03/27/2018 06:37 AM, David Gibson wrote: > As a rule we prefer to pass PowerPCCPU instead of CPUPPCState, and this > change will make some things simpler later on. > > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater > --- >

Re: [Qemu-devel] [patches] Re: [PATCH v6 00/26] RISC-V: Fixes and cleanups for QEMU 2.12

On 26 March 2018 at 19:07, Michael Clark wrote: > On Sun, Mar 25, 2018 at 8:03 AM, Peter Maydell > wrote: >> Hi. It looks to me like a fair number of these patches >> are already reviewed, so we don't need to wait on the >> rest being reviewed to get

Re: [Qemu-devel] [PATCH v2] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

On Tue, Mar 13, 2018 at 11:14:54PM +, Igor Druzhinin wrote: > This should help to avoid problems with accessing the device after > migration/resume without PV drivers by migrating its PCI configuration > space state. Without an explicitly defined state record it resets > every time a VM

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

On 03/27/2018 03:22 PM, Peter Xu wrote: On Thu, Mar 22, 2018 at 08:03:53PM +0800, Xiao Guangrong wrote: On 03/21/2018 06:00 PM, Peter Xu wrote: On Tue, Mar 13, 2018 at 03:57:34PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Currently the page

Re: [Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

On Thu, Mar 15, 2018 at 11:37:59AM +, Dr. David Alan Gilbert wrote: > * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > > From: Xiao Guangrong > > > > Abstract the common function control_save_page() to cleanup the code, > > no logic is changed > > >

Re: [Qemu-devel] [PATCH for 2.13 v2 09/20] linux-user: move s390x signal.c parts to s390x directory

On Fri, 23 Mar 2018 23:57:28 +0100 Laurent Vivier wrote: > No code change, only move code from signal.c to > s390x/signal.c, except adding includes and > exporting setup_frame() and setup_rt_frame(). > > Signed-off-by: Laurent Vivier > --- >

Re: [Qemu-devel] [RFC for-2.13 05/12] target/ppc: Remove fallback 64k pagesize information

On 03/27/2018 06:37 AM, David Gibson wrote: > CPU definitions for cpus with the 64-bit hash MMU can include a table of > available pagesizes. If this isn't supplied ppc_cpu_instance_init() will > fill it in a fallback table based on the POWERPC_MMU_64K bit in mmu_model. > > However, it turns out

Re: [Qemu-devel] [RFC for-2.13 01/12] target/ppc: Standardize instance_init and realize function names

On Tue, 27 Mar 2018 15:37:30 +1100 David Gibson wrote: > Because of the various hooks called some variant on "init" - and the rather > greater number that used to exist, I'm always wondering when a function > called simply "*_init" or "*_initfn" will be called. > >

Re: [Qemu-devel] [RFC for-2.13 02/12] target/ppc: Simplify cpu valid check in ppc_cpu_realize

On Tue, 27 Mar 2018 15:37:31 +1100 David Gibson wrote: > The #if isn't necessary, because there's a suitable one inside > ppc_cpu_is_valid(). We've already filtered for suitable cpu models in the > functions that search and register them. So by the time we get to

Re: [Qemu-devel] [RFC for-2.13 04/12] target/ppc: Avoid taking "env" parameter to mmu-hash64 functions

On 03/27/2018 06:37 AM, David Gibson wrote: > In most cases we prefer to pass a PowerPCCPU rather than the (embedded) > CPUPPCState. > > For ppc_hash64_update_{rmls,vrma}() change to take "cpu" instead of "env". > For ppc_hash64_set_{dsi,isi}() remove the redundant "env" parameter. > > In theory

Re: [Qemu-devel] [PATCH for 2.13 v2 09/20] linux-user: move s390x signal.c parts to s390x directory

Le 27/03/2018 à 10:47, Cornelia Huck a écrit : > On Fri, 23 Mar 2018 23:57:28 +0100 > Laurent Vivier wrote: > >> No code change, only move code from signal.c to >> s390x/signal.c, except adding includes and >> exporting setup_frame() and setup_rt_frame(). >> >> Signed-off-by:

Re: [Qemu-devel] [PULL 00/19] Block layer patches

On 26 March 2018 at 15:35, Kevin Wolf wrote: > The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25 > 13:51:33 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so qemu-stable in CC. However I doubt that someone

Re: [Qemu-devel] [PULL 00/16] Misc fixes for QEMU 2.12.0-rc1

On 26 March 2018 at 14:36, Paolo Bonzini wrote: > The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25 > 13:51:33 +0100) > > are available

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

On Mon, Mar 26, 2018 at 11:43:33PM +0800, Xiao Guangrong wrote: > > > On 03/26/2018 05:02 PM, Peter Xu wrote: > > On Thu, Mar 22, 2018 at 07:38:07PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 03/21/2018 04:19 PM, Peter Xu wrote: > > > > On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao

Re: [Qemu-devel] [PATCH for 2.13 15/19] linux-user: move s390x cpu loop to s390x directory

On Mon, 26 Mar 2018 21:15:59 +0200 Laurent Vivier wrote: > No code change, only move code from main.c to > s390x/cpu_loop.c. > > Signed-off-by: Laurent Vivier > --- > linux-user/main.c | 146 > >

Re: [Qemu-devel] [PATCH v2 0/4] Monitor: OOB related patches

On 03/27/2018 03:36 AM, Eric Blake wrote: > This is patches 2, 3, 7, and 8 (with 7 rewritten) from Peter Xu's > series. I've pushed them to git://repo.or.cz/qemu/ericb.git qapi-next that branch seems to work fine. (no make check or iotest regression on s390) > (on top of the other pending

Re: [Qemu-devel] [PATCH for 2.13 v2 09/20] linux-user: move s390x signal.c parts to s390x directory

On Tue, 27 Mar 2018 11:13:37 +0200 Laurent Vivier wrote: > Le 27/03/2018 à 10:47, Cornelia Huck a écrit : > > On Fri, 23 Mar 2018 23:57:28 +0100 > > Laurent Vivier wrote: > > > >> No code change, only move code from signal.c to > >> s390x/signal.c,

Re: [Qemu-devel] [PATCH for-2.12 1/5] hw/dma/i82374: Avoid double creation of the 82374 controller

On 26.03.2018 17:34, Philippe Mathieu-Daudé wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. > >

Re: [Qemu-devel] [RFC for-2.13 06/12] target/ppc: Move page size setup to helper function

On 03/27/2018 06:37 AM, David Gibson wrote: > Initialization of the env->sps structure at the end of instance_init is > specific to the 64-bit hash MMU, so move the code into a helper function > in mmu-hash64.c. > > We also create a corresponding function to be called at finalize time - > it's

Re: [Qemu-devel] [PATCH v2 for-2.12] gdbstub: send a termination packet instead of crashing gdb

Peter, can this be cherry-picked in 2.12-rc1? Thanks, Fred On 03/20/2018 10:39 AM, KONRAD Frederic wrote: Since the commit: commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 Author: Stefan Hajnoczi Date: Wed Mar 7 14:42:05 2018 + vl: introduce vm_shutdown() GDB

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

27.03.2018 12:28, Vladimir Sementsov-Ogievskiy wrote: 26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps

Re: [Qemu-devel] [Qemu-ppc] [RFC for-2.13 02/12] target/ppc: Simplify cpu valid check in ppc_cpu_realize

On 27.03.2018 06:37, David Gibson wrote: > The #if isn't necessary, because there's a suitable one inside > ppc_cpu_is_valid(). We've already filtered for suitable cpu models in the > functions that search and register them. So by the time we get to realize > having an invalid one indicates a

Re: [Qemu-devel] [PATCH for-2.12] tests: Silence false positive warning on generated test name

On Fri, Mar 23, 2018 at 9:43 PM, Eric Blake wrote: > Running 'make check' on rawhide with gcc 8.0.1 fails: > > tests/test-visitor-serialization.c: In function 'main': > tests/test-visitor-serialization.c:1127:34: error: '/primitives/' directive > writing 12 bytes into a region

Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

On 03/27/2018 11:56 AM, Bastian Koppelmann wrote: > Hi Emilio, > > On 03/27/2018 07:33 AM, Emilio G. Cota wrote: >> v1: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg05908.html >> > [...] >> >> Perf numbers are in the last patch. They are a little different than >> last week; I

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

On Tue, Mar 13, 2018 at 03:57:36PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > The function is called by both ram_save_page and ram_save_target_page, > so move it to the common caller to cleanup the code > > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH 6/8] migration: move calling save_zero_page to the common place

On Tue, Mar 13, 2018 at 03:57:37PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > save_zero_page() is always our first approach to try, move it to > the common place before calling ram_save_compressed_page > and ram_save_page > > Signed-off-by: Xiao

Re: [Qemu-devel] [PATCH 8/8] migration: remove ram_save_compressed_page()

On Tue, Mar 13, 2018 at 03:57:39PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Now, we can reuse the path in ram_save_page() to post the page out > as normal, then the only thing remained in ram_save_compressed_page() > is compression that we can

Re: [Qemu-devel] [PULL 0/1] decodetree: fix 16-bit insns

On 26 March 2018 at 15:47, Richard Henderson wrote: > It's a bug, so logically 2.12 material. > But no sense requiring risc-v to hold an extra local patch. > > > r~ > > > The following changes since commit 2ffd221d07a671f72354a063d3080f244ec80b20: > > Merge

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

On Tue, Mar 27, 2018 at 03:42:32AM +0800, Xiao Guangrong wrote: [...] > > It'll be understandable to me if the problem is that the compress() > > API does not allow the input buffer to be changed during the whole > > period of the call. If that is a must, this patch for sure helps. > > Yes,

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

Emilio G. Cota writes: > On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: > (snip) >> Another thought re all of the soft_is_normal || soft_is_zero checks that >> you're >> performing. I think it would be nice if we could work with >> float*_unpack_canonical so

Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format

On Tue, Mar 27, 2018 at 06:08:00PM +0530, sathn...@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > This commit 137b5cb6ab565cb3781d5337591e155932b4230e > refactors info cpus output and changes output format from > 'thread_id' to 'thread-id', this would break

Re: [Qemu-devel] [PATCH v3] qemu-doc: Rework the network options chapter to make "-net" less prominent

On 2018年03月27日 00:42, Thomas Huth wrote: Ping! Any chance that we could still update the documentation for QEMU 2.12? Thomas Sorry for the late. Replied in another thread. It will be in 2.12 for sure . Thanks

[Qemu-devel] [Bug 1759264] [NEW] fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

Public bug reported: After the refactor from ab52f973a504f8de0c5df64631ba4caea70a7d9e the bahaviour of int32_to_float32() was altered. helper_ftoi() in target/tricore/fpu_helper.c relied on int32_to_float32 to raise the invalid flag if the input was NaN to properly return 0. Likewise if the

Re: [Qemu-devel] [PULL for-2.12 0/1] target/hppa: Fix for glibc 2.27

-26 11:02:50 +0100) > > are available in the Git repository at: > > git://github.com/rth7680/qemu.git tags/pull-hppa-20180327 > > for you to fetch changes up to ebd0e151149a6280ea9f4cd9638aea517bb3238b: > > target/hppa: Include priv level in us

Re: [Qemu-devel] [PATCH v3 00/38] RFC: monitor: add asynchronous command type

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180326150916.9602-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/38]

Re: [Qemu-devel] [PATCH v1 02/14] tests: add fp-test, a floating point test suite

Emilio G. Cota writes: > This will allow us to run correctness tests against our > FP implementation. The test can be run in two modes (called > "testers"): host and soft. With the former we check the results > and FP flags on the host machine against the model. > With the

Re: [Qemu-devel] [PATCH v1 03/14] softfloat: fix {min, max}nummag for same-abs-value inputs

Emilio G. Cota writes: > Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21), > we used to return +Zero for maxnummag(-Zero,+Zero); after that > commit, we return -Zero. > > Fix it by making {min,max}nummag consistent with {min,max}num, > deferring to the latter when

Re: [Qemu-devel] [patches] Re: [PATCH v6 00/26] RISC-V: Fixes and cleanups for QEMU 2.12

On Mon, Mar 26, 2018 at 04:45:34PM -0700, Michael Clark wrote: > I've made a tag for the series including the fixes from my own review > during the weekend (one logic fix and 2 comment of commit log typos, and a > patch hunk in the wrong commit): > > -

Re: [Qemu-devel] [PATCH v2 3/4] tests: Add parameter to qtest_init_without_qmp_handshake

On Tue, Mar 27, 2018 at 3:36 AM, Eric Blake wrote: > Allow callers to choose whether to allow OOB support during a test; > for now, all existing callers pass false, but the next patch will > add a new caller. Also, rewrite the monitor setup to be generic > (using the -qmp

Re: [Qemu-devel] [PATCH 0/3] e1000 migration changes for 2.12

On 2018年03月27日 19:34, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Hi Ed, Jason, This set of patches change the e1000 migration code to make it easier to keep with compatibility with older versions in backwards migration; but I do need some

Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format

On Tue, Mar 27, 2018 at 01:40:00PM +0100, Daniel P. Berrangé wrote: > On Tue, Mar 27, 2018 at 06:08:00PM +0530, sathn...@linux.vnet.ibm.com wrote: > > From: Satheesh Rajendran > > > > This commit 137b5cb6ab565cb3781d5337591e155932b4230e > > refactors info cpus output

[Qemu-devel] [PATCH for 2.12 1/1] block: allow recursive calling of bdrv_set_aio_context

We have received the following assert on QEMU 2.9: (gdb) bt 0 0x7f6f67d281f7 in __GI_raise () 1 0x7f6f67d298e8 in __GI_abort () 2 0x7f6f67d21266 in __assert_fail_base () 3 0x7f6f67d21312 in __GI___assert_fail () 4 0x55a8faf76f9f in bdrv_detach_aio_context () 5

Re: [Qemu-devel] [PATCH v1 03/14] softfloat: fix {min, max}nummag for same-abs-value inputs

Emilio G. Cota writes: > Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21), > we used to return +Zero for maxnummag(-Zero,+Zero); after that > commit, we return -Zero. > > Fix it by making {min,max}nummag consistent with {min,max}num, > deferring to the latter when

Re: [Qemu-devel] [PATCH v2 6/6] vhost-user: add VFIO based accelerators support

On Thu, Mar 22, 2018 at 06:19:44PM +0200, Michael S. Tsirkin wrote: > On Mon, Mar 19, 2018 at 03:15:37PM +0800, Tiwei Bie wrote: [...] > > diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt > > index cb3a7595aa..264a58a800 100644 > > --- a/docs/interop/vhost-user.txt > > +++

Re: [Qemu-devel] [PATCH v1 04/14] fp-test: add muladd variants

Emilio G. Cota writes: > These are a few muladd-related operations that the original IBM syntax > does not specify; model files for these are in muladd.fptest. > > Signed-off-by: Emilio G. Cota > --- > tests/fp-test/fp-test.c | 24 + >

[Qemu-devel] [PATCH 3/3] e1000: Old machine types, turn new subsection off

From: "Dr. David Alan Gilbert" Turn the newly added subsection off for old machine types Signed-off-by: Dr. David Alan Gilbert --- include/hw/compat.h | 4 1 file changed, 4 insertions(+) diff --git a/include/hw/compat.h b/include/hw/compat.h

Re: [Qemu-devel] [PATCH v1 07/14] fpu: introduce hostfloat

Emilio G. Cota writes: > The appended paves the way for leveraging the host FPU for a subset > of guest FP operations. For most guest workloads (e.g. FP flags > aren't ever cleared, inexact occurs often and rounding is set to the > default [to nearest]) this will yield sizable

Re: [Qemu-devel] [PATCH 0/3] coroutine: avoid co_queue_wakeup recursion

On Thu, Mar 22, 2018 at 03:28:31PM +, Stefan Hajnoczi wrote: > co_queue_wakeup is currently implemented in a recursive fashion. Pathological > patterns of aio_co_enter() between coroutines can cause stack exhaustion. > > This patch series implements co_queue_wakeup iteratively and avoids

[Qemu-devel] [Bug 1726733] Re: ‘qemu-img info replication:’ causes segfault

** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1726733 Title: ‘qemu-img info replication:’ causes segfault Status in QEMU: Fix

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

On Fri, 23 Mar 2018 17:42:18 -0300 Eduardo Habkost wrote: > On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > > it will allow to reuse parse_NumaOptions() for parsing > > configuration commands received via QMP interface > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v3] qemu-doc: Rework the network options chapter to make "-net" less prominent

On 27.03.2018 15:01, Jason Wang wrote: > > > On 2018年03月12日 20:20, Thomas Huth wrote: >> "-net" is clearly a legacy option. Yet we still use it in almost all >> examples in the qemu documentation, and many other spots in the network >> chapter. We should make it less prominent that users are not

Re: [Qemu-devel] [PATCH v1] RISC-V: RISC-V TCG backend work in progress

On 03/25/2018 05:24 AM, Michael Clark wrote: > Running with `-d in_asm,op,op_opt,out_asm` is very helpful > for debugging. Note: due to a limitation in QEMU, the backend > disassembler is not compiled, unless the backend matches > the front-end, so `scripts/disas-objdump.pl` is required > to

[Qemu-devel] [PATCH 1/3] e1000: Convert v3 fields to subsection

From: "Dr. David Alan Gilbert" A bunch of new TSO fields were introduced by d62644b4 and this bumped the VMState version; however it's easier for those trying to keep backwards migration compatibility if these fields are added in a subsection instead. Move the new fields to

Re: [Qemu-devel] [PATCH v1 06/14] softfloat: add float32_is_denormal and float64_is_denormal

Emilio G. Cota writes: > This paves the way for upcoming work. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/fpu/softfloat.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

[Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format

From: Satheesh Rajendran This commit 137b5cb6ab565cb3781d5337591e155932b4230e refactors info cpus output and changes output format from 'thread_id' to 'thread-id', this would break parsing of output in above layers like libvirt, test framework etc. This patch just

Re: [Qemu-devel] [PATCH 7/8] migration: introduce save_normal_page()

On Tue, Mar 13, 2018 at 03:57:38PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > It directly sends the page to the stream neither checking zero nor > using xbzrle or compression > > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h

On Thu, Mar 22, 2018 at 05:15:30PM +0200, Michael S. Tsirkin wrote: > On Mon, Mar 19, 2018 at 03:15:36PM +0800, Tiwei Bie wrote: > > This macro isn't used by any VFIO code. And its name is > > too generic. The vfio-common.h (in include/hw/vfio) can > > be included by other modules in QEMU. It can

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

27.03.2018 12:53, Vladimir Sementsov-Ogievskiy wrote: 27.03.2018 12:28, Vladimir Sementsov-Ogievskiy wrote: 26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The

[Qemu-devel] [qemu-devel][PATCH v1 2/2] xilinx_spi: use qdev_init_gpio_out for gpio init

From: Sai Pavan Boddu useful to connect gpio with qdev_connect_gpio_out Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- hw/ssi/xilinx_spi.c

[Qemu-devel] [qemu-devel][PATCH v1 1/2] ssi.c: Check if slave already attached to a parent bus

From: Sai Pavan Boddu Skip auto-connect if already connected to a bus Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- hw/ssi/ssi.c | 2 +-

Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format

Re-adding qemu-devel address - please don't drop the mailing list from CC's when replying to messages on the list. On Tue, Mar 27, 2018 at 06:46:19PM +0530, satheesh rajendran wrote: > On Tue, Mar 27, 2018 at 01:40:00PM +0100, Daniel P. Berrangé wrote: > > On Tue, Mar 27, 2018 at 06:08:00PM

[Qemu-devel] [PATCH 2/3] e1000: wire new subsection to property

From: "Dr. David Alan Gilbert" Wire the new subsection from the previous commit to a property so we can turn it off easily. Signed-off-by: Dr. David Alan Gilbert --- hw/net/e1000.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v1 05/14] softfloat: add float32_is_normal and float64_is_normal

Emilio G. Cota writes: > This paves the way for upcoming work. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/fpu/softfloat.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

[Qemu-devel] [PATCH 0/3] e1000 migration changes for 2.12

From: "Dr. David Alan Gilbert" Hi Ed, Jason, This set of patches change the e1000 migration code to make it easier to keep with compatibility with older versions in backwards migration; but I do need some advice whether I need to do more as well. I think the first and

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On Fri, 16 Mar 2018 14:22:52 +0100 Halil Pasic wrote: > On 03/16/2018 11:42 AM, Pierre Morel wrote: > > On 16/03/2018 00:24, Tony Krowiak wrote: > >> Introduces a VFIO based AP device. The device is defined via > >> the QEMU command line by specifying: > >> > >>

Re: [Qemu-devel] [PATCH v3] qemu-doc: Rework the network options chapter to make "-net" less prominent

On 2018年03月12日 20:20, Thomas Huth wrote: "-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it less prominent that users are not lured into using it so often anymore. So instead of

[Qemu-devel] [PATCH 1/1] block-backend: simplify blk_get_aio_context

blk_get_aio_context verifies if BlockDriverState bs is not NULL, return bdrv_get_aio_context(bs) if true or qemu_get_aio_context() otherwise. However, bdrv_get_aio_context from block.c already does this verification itself, also returning qemu_get_aio_context() if bs is NULL: AioContext

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

On 03/27/2018 07:17 PM, Peter Xu wrote: On Tue, Mar 27, 2018 at 03:42:32AM +0800, Xiao Guangrong wrote: [...] It'll be understandable to me if the problem is that the compress() API does not allow the input buffer to be changed during the whole period of the call. If that is a must, this

Re: [Qemu-devel] [PATCH v2 4/4] tests: qmp-test: add test for new "x-oob"

On Tue, Mar 27, 2018 at 3:36 AM, Eric Blake wrote: > From: Peter Xu > > Test the new OOB capability. It's mostly the reverted OOB test > (see commit 4fd78ad7), but differs in that: > > - It uses the new qtest_init_without_qmp_handshake() parameter to >

Re: [Qemu-devel] [PATCH 1/1] block-backend: simplify blk_get_aio_context

On Tue, Mar 27, 2018 at 10:08:46AM -0300, Daniel Henrique Barboza wrote: blk_get_aio_context verifies if BlockDriverState bs is not NULL, return bdrv_get_aio_context(bs) if true or qemu_get_aio_context() otherwise. However, bdrv_get_aio_context from block.c already does this verification itself,

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 2/6] vhost-user: introduce shared vhost-user state

On Thu, Mar 22, 2018 at 05:13:41PM +0200, Michael S. Tsirkin wrote: > On Mon, Mar 19, 2018 at 03:15:33PM +0800, Tiwei Bie wrote: > > @@ -22,7 +23,7 @@ > > > > typedef struct VhostUserState { > > NetClientState nc; > > -CharBackend chr; /* only queue index 0 */ > > +VhostUser

Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format

On Tue, Mar 27, 2018 at 02:20:11PM +0100, Daniel P. Berrangé wrote: > Re-adding qemu-devel address - please don't drop the mailing list from > CC's when replying to messages on the list. Sorry, Missed intially, had resent it but was too late :-(. > > On Tue, Mar 27, 2018 at 06:46:19PM +0530,

Re: [Qemu-devel] [PATCH for 2.13 07/19] linux-user: move mips/mips64 cpu loop to mips directory

On 03/26/2018 04:15 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > mips/cpu_loop.c. > > Include mips/cpu_loop.c in mips64/cpu_loop.c > to avoid to duplicate code. > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH for 2.13 14/19] linux-user: move alpha cpu loop to alpha directory

On 03/26/2018 04:15 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > alpha/cpu_loop.c. > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/alpha/cpu_loop.c | 199

[Qemu-devel] [PATCH v2 1/1] RISC-V: Workaround for critical mstatus.FS bug

This change is a workaround for a bug where mstatus.FS is not correctly reporting dirty after operations that modify floating point registers. This a critical bug or RISC-V in QEMU as it results in floating point register file corruption when running SMP Linux due to task migration and possibly

[Qemu-devel] [PATCH v2 0/1] RISC-V: Critical fixes for QEMU 2.12

This series includes changes that are considered release critical, such as floating point register file corruption under SMP Linux. v2 - reverted to Richard W.M. Jone's original, more conservative fix - reworded comment to be more concise and more general Michael Clark (1): RISC-V: Workaround

Re: [Qemu-devel] [PATCH v3 1/1] hw/scsi: support SCSI-2 passthrough without PI

On Tue, 03/27 18:14, Daniel Henrique Barboza wrote: > QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK > works in the protocol, denying support for PI (Protection > Information) in case the guest OS requests it. However, in SCSI versions 2 > and older, there is no PI concept in

Re: [Qemu-devel] [PATCH 3/8] migration: support todetectcompression and decompression errors

> > On Tue, Mar 27, 2018 at 10:35:29PM +0800, Xiao Guangrong wrote: > >> > > No, we can't make the assumption that "error _must_ be caused by page >> > > update". >> > > No document/ABI about compress/decompress promised it. :) > > Indeed, I found no good documents about below errors that

Re: [Qemu-devel] [PATCH v1 2/2] RISC-V: Fix incorrect disassembly for addiw

On 03/28/2018 03:55 AM, Michael Clark wrote: > This fixes a bug in the disassembler constraints used > to lift instructions into pseudo-instructions, whereby > addiw instructions are always lifted to sext.w instead > of just lifting addiw with a zero immediate. > > An associated fix has been made

[Qemu-devel] [PULL 1/1] tcg: Mark muluh_i64 and mulsh_i64 as 64-bit ops

Failure to do so results in the tcg optimizer sign-extending any constant fold from 32-bits. This turns out to be visible in the RISC-V testsuite using a host that emits these opcodes (e.g. any non-x86_64). Reported-by: Michael Clark Reviewed-by: Emilio G. Cota

[Qemu-devel] [PULL for-2.12 0/1] tcg mul[us]h fix

This is material for stable as well. r~ The following changes since commit fa3704d87720d7049d483ff669b9e2ff991e7658: Update version for v2.12.0-rc1 release (2018-03-27 22:04:23 +0100) are available in the Git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20180328 for

Re: [Qemu-devel] [PATCH for 2.13 00/19] linux-user: move arch specific parts from main.c to arch directories

On 03/27/2018 03:15 AM, Laurent Vivier wrote: > This series moves from main.c the architecture specific parts > to the architecture directory. > > This is the continuation of my series > "linux-user: move arch specific parts to arch directories" > that includes since the v2 only the signal.c

Re: [Qemu-devel] [PATCH 2/2] target/riscv: Mark MSTATUS_FS dirty

On 03/28/2018 10:22 AM, Richard Henderson wrote: > +/* Mark fp status as dirty. */ > +env->mstatus = MSTATUS_FS; Bah. This should of course be |=. r~

Re: [Qemu-devel] [PATCH v1] RISC-V: RISC-V TCG backend work in progress

On Tue, Mar 27, 2018 at 5:35 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 03/28/2018 01:43 AM, Michael Clark wrote: > > > +if ((ct & TCG_CT_CONST_N12) && val >= -2047 && val <= 2047) { > > > > +2048? > Yes of course, you're right. It's safe. I just hadn't thought

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Mar 26, 2018 at 11:08 AM, Peter Xu wrote: > > On Mon, Mar 26, 2018 at 10:33:27AM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, Mar 26, 2018 at 10:07 AM, Peter Xu

Re: [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty

Hi Richard, Thanks! I'll test this tomorrow morning and we can choose whether to include your proper fix or the workaround. I think we have time assuming we send out PRs tomorrow. Given our important fixes have review including either this fix by tomorrow or the workaround, and Philippe has

Re: [Qemu-devel] [PATCH v2 1/1] RISC-V: Workaround for critical mstatus.FS MTTCG bug

On 03/28/2018 08:42 AM, Michael Clark wrote: > This change is a workaround for a bug where mstatus.FS > is not correctly reporting dirty after operations that > modify floating point registers. This a critical bug > or RISC-V in QEMU as it results in floating point > register file corruption when

Re: [Qemu-devel] [PATCH 3/8] migration: support todetectcompression and decompression errors

On Wed, Mar 28, 2018 at 12:08:19PM +0800, jiang.bi...@zte.com.cn wrote: > > > > On Tue, Mar 27, 2018 at 10:35:29PM +0800, Xiao Guangrong wrote: > > > >> > > No, we can't make the assumption that "error _must_ be caused by page > >> > > update". > >> > > No document/ABI about compress/decompress

Re: [Qemu-devel] [PATCH v1 1/2] RISC-V: Convert cpu definition to future model

On 03/28/2018 03:55 AM, Michael Clark wrote: > - Model borrowed from target/sh4/cpu.c > - Rewrote riscv_cpu_list to use object_class_get_list > - Dropped 'struct RISCVCPUInfo' and used TypeInfo array > - Replaced riscv_cpu_register_types with DEFINE_TYPES > - Marked base class as abstract > -

Re: [Qemu-devel] [PATCH v2] scsi-disk: Don't enlarge min_io_size to max_io_size

On Wed, Mar 28, 2018 at 12:41:41AM +0800, Fam Zheng wrote: > Some backends report big max_io_sectors. Making min_io_size the same > value in this case will make it impossible for guest to align memory, > therefore the disk may not be usable at all. > > Do not enlarge them when they are zero. > >

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

On 2018/3/27 22:15, Eric Auger wrote: > With KVM acceleration and if KVM VGICV3 supports to set multiple > redistributor regions, we now allow up to 512 vcpus. > > Signed-off-by: Eric Auger > --- > hw/arm/virt.c | 17 - > include/hw/arm/virt.h |

  1   2   3   >