[Qemu-devel] [PULL for-2.12 1/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-04-03 Thread Cornelia Huck
From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. Fixes: 3c4e9baacf4d9 Signed-off-by: Greg Kurz Message-Id: <152231460685.69730.14860451936216690693.st...@bahia.lan> Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck ---

Re: [Qemu-devel] [PATCH for-2.12] monitor: bind dispatch bh to iohandler context

2018-04-03 Thread Fam Zheng
On Tue, 04/03 13:01, Peter Xu wrote: > Eric Auger reported the problem days ago that OOB broke ARM when running > with libvirt: > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > This patch fixes the problem. > > It's not really needed now since we have turned OOB off now

[Qemu-devel] [Bug 1481272] Re: main-loop: WARNING: I/O thread spun for 1000 iterations

2018-04-03 Thread ChristianEhrhardt
Nice, thanks for the update. I checked a few recent logs and agree that the message is gone since 2.9 Some might still encounter slow guests (for other reasons) and trigger the message, but the most common TCG emulation case is solved by this since Artful and later. I think we don't want to backp

[Qemu-devel] [Bug 1481272] Re: main-loop: WARNING: I/O thread spun for 1000 iterations

2018-04-03 Thread ChristianEhrhardt
Updated the Ubuntu tasks on this bug, leaving the qemu state to a triager of the project. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1481272 Title: main-loop: WARNING: I/O thread spun for 1000 i

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 02/67] target/arm: Introduce translate-a64.h

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > Move some stuff that will be common to both translate-a64.c > and translate-sve.c. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.h | 110 > + > target/arm/translate-a64.

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 06/67] target/arm: Implement SVE predicate test

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 21 + > target/arm/helper.h| 1 + > target/arm/sve_helper.c| 77 > ++ > target/arm/translate-sve.c | 62 ++

Re: [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 132 > + > target/arm/sve.decode | 22 +++- > 2 files changed, 153 insertions(+), 1 deletion(-) > > diff --git a/target/arm/translate-sve.c b

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-03 Thread Cornelia Huck
On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak wrote: > On 03/26/2018 05:03 AM, Pierre Morel wrote: > > On 26/03/2018 10:32, David Hildenbrand wrote: > >> On 16.03.2018 00:24, Tony Krowiak wrote: > >>> +/* > >>> + * The Query Configuration Information (QCI) function (fc == 4) > >>>

[Qemu-devel] [Bug 1740219] Re: static linux-user ARM emulation has several-second startup time

2018-04-03 Thread ChristianEhrhardt
Back again, my question was more about if we are able to JUST take 2a53535af471f4bee9d6cb5b363746b8d5ed21dd without the rest. We are already in Feature Freeze for Ubuntu 18.04, so we can either a) wait for the next release and pick it up in full by the new qemu version (well we will do that anyw

[Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only

2018-04-03 Thread Michal Privoznik
When trying to build with latest libcacard-2.5.1, I hit the following error: In file included from hw/usb/ccid-card-passthru.c:12:0: /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only can be included directly" [-Werror=cpp] #warning "Only can be included directly" While it was fi

[Qemu-devel] [PULL 3/3] linux-user: fix TARGET___O_TMPFILE for sparc

2018-04-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Message-Id: <20180402102453.9883-3-laur...@vivier.eu> --- linux-user/syscall_defs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 7473be518b..23f5bccf0e 100644 --- a/linux-user/syscall_defs.h +++ b/lin

[Qemu-devel] [PULL 0/3] linux-user fixes for -rc2

2018-04-03 Thread Laurent Vivier
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-fo

[Qemu-devel] [PULL 1/3] linux-user: fix alpha signal emulation

2018-04-03 Thread Laurent Vivier
setup_frame() doesn't set correctly the address of the trampoline code. The offset of retcode array must be added to the stack frame address. Signed-off-by: Laurent Vivier Message-Id: <20180401204653.14211-1-laur...@vivier.eu> --- linux-user/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PULL 2/3] linux-user: define TARGET_ARCH_HAS_KA_RESTORER

2018-04-03 Thread Laurent Vivier
Sparc as an extended sigaction structure containing the field ka_restorer used in place of sa_restorer. Define TARGET_ARCH_HAS_KA_RESTORER and use it with sparc. Signed-off-by: Laurent Vivier Message-Id: <20180402102453.9883-2-laur...@vivier.eu> --- linux-user/signal.c | 4 ++-- linux-use

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Peter Krempa
On Thu, Mar 29, 2018 at 13:57:54 -0300, Eduardo Habkost wrote: > On Thu, Mar 29, 2018 at 03:01:12PM +0200, Igor Mammedov wrote: > > On Wed, 28 Mar 2018 16:17:32 -0300 > > Eduardo Habkost wrote: > > > On Tue, Mar 27, 2018 at 05:05:41PM +0200, Igor Mammedov wrote: > > > > On Fri, 23 Mar 2018 18:25:0

[Qemu-devel] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Kevin Wolf
The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax. https://bugzilla.re

Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only

2018-04-03 Thread Marc-André Lureau
Hi On Tue, Apr 3, 2018 at 12:34 PM, Michal Privoznik wrote: > When trying to build with latest libcacard-2.5.1, I hit the > following error: > > In file included from hw/usb/ccid-card-passthru.c:12:0: > /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only > can be included directly"

Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only

2018-04-03 Thread Michal Privoznik
On 04/03/2018 01:38 PM, Marc-André Lureau wrote: > Hi > > On Tue, Apr 3, 2018 at 12:34 PM, Michal Privoznik wrote: >> When trying to build with latest libcacard-2.5.1, I hit the >> following error: >> >> In file included from hw/usb/ccid-card-passthru.c:12:0: >> /usr/include/cacard/vscard_common.

Re: [Qemu-devel] [PATCH v2 1/1] qemu-iotests: Use ppc64 qemu_arch on ppc64le host

2018-04-03 Thread Kevin Wolf
Am 29.03.2018 um 16:31 hat Max Reitz geschrieben: > On 2018-03-29 13:20, Lukáš Doktor wrote: > > The qemu target does not always correspond to the host machine type. For > > example ppc64le machine target is ppc64. Let's introduce "qemu_arch" > > variable to store the matching qemu architecture rel

Re: [Qemu-devel] Some thoughts about per-queue iothreads in VirtIOBlock

2018-04-03 Thread Stefan Hajnoczi
On Tue, Mar 20, 2018 at 07:30:04PM +0300, Edgar Kaziakhmedov wrote: > > On 3/20/18 6:34 PM, Paolo Bonzini wrote: > > On 20/03/2018 15:45, Edgar Kaziakhmedov wrote: > > > > > As I understood from > > > Stefan description, it is expected to change significantly > > > the approach we use to interact

Re: [Qemu-devel] snapshot:create snapshot for rbd disk failed.

2018-04-03 Thread Stefan Hajnoczi
On Thu, Mar 22, 2018 at 03:44:00AM +, Zhangzijian wrote: > Hello, CCing Sheepdog block driver maintainers. You can find maintainers for a source file using: $ scripts/get_maintainers -f block/sheepdog.c > > In 'bdrv_all_create_snapshot', each block will create snapshot in a for loop. >

Re: [Qemu-devel] Regarding qemu console?

2018-04-03 Thread Stefan Hajnoczi
On Sun, Mar 25, 2018 at 06:46:50PM +0530, Arun raj wrote: > I'm new to qemu.i'm using qemu 2.11 version in my laptop.In qemu system i > have two serial port.If i type the any information on the minicom serial > port, this message are redirected into QEMU console. How you are > redirecting all messa

Re: [Qemu-devel] [Qemu-block] [PATCH] block: remove bdrv_dirty_bitmap_make_anon

2018-04-03 Thread Stefan Hajnoczi
On Fri, Mar 23, 2018 at 05:42:53PM +0100, Paolo Bonzini wrote: > All this function is doing will be repeated by > bdrv_do_release_matching_dirty_bitmap_locked, except > resetting bm->persistent. But even that does not matter > because the bitmap will be freed. > > Signed-off-by: Paolo Bonzini >

Re: [Qemu-devel] Some thoughts about per-queue iothreads in VirtIOBlock

2018-04-03 Thread Edgar Kaziakhmedov
On 4/3/18 3:27 PM, Stefan Hajnoczi wrote: On Tue, Mar 20, 2018 at 07:30:04PM +0300, Edgar Kaziakhmedov wrote: On 3/20/18 6:34 PM, Paolo Bonzini wrote: On 20/03/2018 15:45, Edgar Kaziakhmedov wrote: As I understood from Stefan description, it is expected to change significantly the approach w

Re: [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully

2018-04-03 Thread Eric Blake
On 04/02/2018 11:37 PM, Jeff Cody wrote: > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > workaround in the gluster driver to handle invalid values returned for > SEEK_DATA or SEEK_HOLE. > > In some instances, these same invalid values can be seen in the posix > file handle

Re: [Qemu-devel] [PATCH] iotests: fix wait_until_completed()

2018-04-03 Thread Stefan Hajnoczi
On Tue, Mar 27, 2018 at 10:21:55AM +0800, Peter Xu wrote: > On Mon, Mar 26, 2018 at 12:47:39PM +0200, Kevin Wolf wrote: > > Am 26.03.2018 um 08:11 hat Peter Xu geschrieben: > > > If there are more than one events, wait_until_completed() might return > > > the 2nd event even if the 1st event is JOB_

Re: [Qemu-devel] [PATCH for-2.12] monitor: bind dispatch bh to iohandler context

2018-04-03 Thread Eric Blake
On 04/03/2018 12:01 AM, Peter Xu wrote: > Eric Auger reported the problem days ago that OOB broke ARM when running > with libvirt: > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > This patch fixes the problem. > > It's not really needed now since we have turned OOB off

Re: [Qemu-devel] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Eric Blake
On 04/03/2018 06:08 AM, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket' and 'path', with > '

[Qemu-devel] [PATCH 1/2] qemu-pr-helper: Daemonize before dropping privileges

2018-04-03 Thread Michal Privoznik
After we've dropped privileges it might be not possible to write pidfile. For instance, if this binary is run as root (because user wants it to write pidfile to some privileged location) writing pidfile fails because privileges are dropped before we even get to that. Signed-off-by: Michal Privozni

[Qemu-devel] [PATCH 2/2] qemu-pr-helper: Write pidfile more often

2018-04-03 Thread Michal Privoznik
Let's write pidfile even if user did not request --daemon but they requested just --pidfile. Libvirt will use exactly this. Signed-off-by: Michal Privoznik --- scsi/qemu-pr-helper.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-help

[Qemu-devel] [PATCH 0/2] Couple of qemu-pr-helper fixes

2018-04-03 Thread Michal Privoznik
The first one is trivial. The second is slightly trickier. Libvirt has this virCommand subsystem (found under src/util/vircommand.c) which it uses to spawn commands. The subsystem allows libvirt to both daemonize a process and learn its PID. The latter of course does not work if command daemonizes

Re: [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully

2018-04-03 Thread Kevin Wolf
Am 03.04.2018 um 06:37 hat Jeff Cody geschrieben: > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > workaround in the gluster driver to handle invalid values returned for > SEEK_DATA or SEEK_HOLE. > > In some instances, these same invalid values can be seen in the posix > fi

Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

2018-04-03 Thread Kevin Wolf
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Blacklist these formats, as they don't support image creation, as they > say: > > ./qemu-img create -f bochs x 1m > qemu-img: x: Format driver 'bochs' does not support image creation > > > ./qemu-img create -f cloop

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Igor Mammedov
On Thu, 29 Mar 2018 13:57:54 -0300 Eduardo Habkost wrote: [...] > > As for the future, I agree it would be much more flexible > > to allow both -preconfig and -incoming at the same time, > > so we could start target with empty CLI, and then feed it > > options from source. It would require audit/

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Eduardo Habkost
On Tue, Apr 03, 2018 at 03:49:07PM +0200, Igor Mammedov wrote: > On Thu, 29 Mar 2018 13:57:54 -0300 > Eduardo Habkost wrote: > > [...] > > > As for the future, I agree it would be much more flexible > > > to allow both -preconfig and -incoming at the same time, > > > so we could start target with

Re: [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully

2018-04-03 Thread Jeff Cody
On Tue, Apr 03, 2018 at 07:57:14AM -0500, Eric Blake wrote: > On 04/02/2018 11:37 PM, Jeff Cody wrote: > > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > > workaround in the gluster driver to handle invalid values returned for > > SEEK_DATA or SEEK_HOLE. > > > > In some ins

Re: [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper

2018-04-03 Thread Kevin Wolf
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add an assert (we don't want set both arguments) and remove > duplication. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

2018-04-03 Thread Igor Mammedov
On Thu, 29 Mar 2018 13:31:13 -0300 Eduardo Habkost wrote: > On Thu, Mar 29, 2018 at 03:05:09PM +0200, Igor Mammedov wrote: > > On Wed, 28 Mar 2018 15:54:28 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Mar 27, 2018 at 03:08:27PM +0200, Igor Mammedov wrote: > > > > On Fri, 23 Mar 2018 1

Re: [Qemu-devel] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Jeff Cody
On Tue, Apr 03, 2018 at 01:08:10PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket' an

Re: [Qemu-devel] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Jeff Cody
On Tue, Apr 03, 2018 at 01:08:10PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket' an

[Qemu-devel] [PULL 1/2] exec: fix memory leak in find_max_supported_pagesize()

2018-04-03 Thread Eduardo Habkost
From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. Signed-off-by: Greg Kurz Message-Id: <152231458624.69730.1752893648612848392.st...@bahia.lan> Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Eduardo Habkost --- exec.c | 1 + 1 fil

[Qemu-devel] [PULL 0/2] Fix memory leaks when using object_property_get_str()

2018-04-03 Thread Eduardo Habkost
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-next-pu

[Qemu-devel] [PULL 2/2] sev/i386: fix memory leak in sev_guest_init()

2018-04-03 Thread Eduardo Habkost
From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. Fixes: d8575c6c0242b Signed-off-by: Greg Kurz Message-Id: <152231462116.69730.14119625999092384450.st...@bahia.lan> Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Eduardo Habkost --

[Qemu-devel] [PATCH] qemu-iotests: update 185 output

2018-04-03 Thread Stefan Hajnoczi
Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the drain operation the block job iterates one more time than before. The 185 output no longer matches and the test is failing now. It may be possible to avoid the s

Re: [Qemu-devel] [PATCH for-2.13] s390x: introduce 2.13 compat machine

2018-04-03 Thread Cornelia Huck
On Thu, 29 Mar 2018 13:33:20 +0200 Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > Yes, it's that time again :) > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(-) Queued to s390-next (

Re: [Qemu-devel] [PATCH] qemu-iotests: update 185 output

2018-04-03 Thread Kevin Wolf
Am 03.04.2018 um 16:03 hat Stefan Hajnoczi geschrieben: > Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce > vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the > drain operation the block job iterates one more time than before. The > 185 output no longer matches

Re: [Qemu-devel] [PATCH v2 1/1] iotests: fix test case 185

2018-04-03 Thread Stefan Hajnoczi
On Tue, Mar 27, 2018 at 11:32:00AM +0800, QingFeng Hao wrote: > > 在 2018/3/23 18:04, Stefan Hajnoczi 写道: > > On Fri, Mar 23, 2018 at 3:43 AM, QingFeng Hao > > wrote: > > > Test case 185 failed since commit 4486e89c219 --- "vl: introduce > > > vm_shutdown()". > > > It's because of the newly intr

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Igor Mammedov
On Thu, 29 Mar 2018 13:24:09 -0300 Eduardo Habkost wrote: > On Thu, Mar 29, 2018 at 01:43:03PM +0200, Igor Mammedov wrote: > > On Wed, 28 Mar 2018 16:21:48 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, Mar 28, 2018 at 01:48:35PM +0200, Igor Mammedov wrote: > > > > On Tue, 27 Mar 2018 1

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-03 Thread Kevin Wolf
Am 28.03.2018 um 19:02 hat Dr. David Alan Gilbert (git) geschrieben: > From: "Dr. David Alan Gilbert" > > Activating the block devices causes the locks to be taken on > the backing file. If we're running with -S and the destination libvirt > hasn't started the destination with 'cont', it's expec

Re: [Qemu-devel] [PULL 0/1] RISC-V: Critical fixes for QEMU 2.12

2018-04-03 Thread Peter Maydell
On 3 April 2018 at 03:43, Michael Clark wrote: > I submitted the pull request for your's/Stefan's workaround so that QEMU > 2.12 has working FP context switching under Linux (always returning dirty or > off is valid implementation choice according to the specification), given > Richard Henderson h

Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only

2018-04-03 Thread Marc-André Lureau
Hi On Tue, Apr 3, 2018 at 1:48 PM, Michal Privoznik wrote: > On 04/03/2018 01:38 PM, Marc-André Lureau wrote: >> Hi >> >> On Tue, Apr 3, 2018 at 12:34 PM, Michal Privoznik >> wrote: >>> When trying to build with latest libcacard-2.5.1, I hit the >>> following error: >>> >>> In file included fro

Re: [Qemu-devel] [PULL 0/1] RISC-V: Critical fixes for QEMU 2.12

2018-04-03 Thread Peter Maydell
On 29 March 2018 at 18:26, Michael Clark wrote: > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 22:13:38 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PULL] Net patches

2018-04-03 Thread Peter Maydell
On 30 March 2018 at 04:53, Jason Wang wrote: > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 22:13:38 +0100) > > are available in the git repository

Re: [Qemu-devel] [PULL v1 0/4] Merge tpm 2018/03/29 v1

2018-04-03 Thread Peter Maydell
On 30 March 2018 at 01:12, Stefan Berger wrote: > The following patches fix the handling of some more flags of the TPM CRB > interface and extend the existing TPM CRB test program with tests of more > flags. > > Stefan > > The following changes since commit 043289bef4d9c0d277c45695c676a6cc9fca

Re: [Qemu-devel] [PULL 0/2] migration queue

2018-04-03 Thread Peter Maydell
On 29 March 2018 at 14:57, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 2

[Qemu-devel] [PATCH 2/2] Add QTest testcase for the Hex File Loader

2018-04-03 Thread Su Hang
'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Signed-off-by: Su

[Qemu-devel] [PATCH 1/2] Implement .hex file loader

2018-04-03 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Arduino, ARM, STM32, etc. Sugges

Re: [Qemu-devel] [PATCH 0/2] pvpanic: implement abort_on_panic option

2018-04-03 Thread Sergio Lopez
On Fri, Jan 12, 2018 at 05:31:58PM +0100, Sergio Lopez wrote: > On Fri, Dec 29, 2017 at 10:42 AM, Sergio Lopez wrote: > > Extend pvpanic and qemu_system_guest_panicked so it's possible to > > configure the first to induce an abort() when the Guest panics. > > > > This is specially useful (and main

Re: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1522767657.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. Su Hang (2): Implement .hex file loader Add QTest testcase for the Intel Hexadecimal Object File Loader. hw/arm/boot.c | 9 +- hw/core/loader.c | 280

[Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-04-03 Thread Su Hang
checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ One things need to be mentioned: Becasue `if`, `while` and `for` check have been done in this `if` block(Line: 2356), and this block contains following statement: """ Line: 2379 $suppres

Re: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1522767657.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH 0/4] target-i386: Enha

[Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread Jan Kiszka
These patches allow to run Jailhouse in emulated x86-64 mode under QEMU. AMD IOMMU only works with one additional hack, but that's a different story, and we can test these changes without it. Jan Jan Kiszka (4): target-i386: Add NMI interception to SVM target-i386: Allow interrupt injection a

[Qemu-devel] [PATCH 1/4] target-i386: Add NMI interception to SVM

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka Check for SVM interception prior to injecting an NMI. Tested via the Jailhouse hypervisor. Signed-off-by: Jan Kiszka --- target/i386/seg_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c index 600a4d7586..00301a0c0

[Qemu-devel] [PATCH 2/4] target-i386: Allow interrupt injection after STGI

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka We need to terminate the translation block after STGI so that pending interrupts can be injected. This fixes pending NMI injection for Jailhouse which uses "stgi; clgi" to open a brief injection window. Signed-off-by: Jan Kiszka --- target/i386/translate.c | 3 ++- 1 file cha

[Qemu-devel] [PATCH 4/4] target-i386: Add NPT support

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka This implements NPT suport for SVM by hooking into x86_cpu_handle_mmu_fault where it reads the stage-1 page table. Whether we need to perform this 2nd stage translation, and how, is decided during vmrun and stored in hflags as well as nested_cr3 and nested_pg_mode. As get_hphys

[Qemu-devel] [PATCH 3/4] target-i386: Mark cpu_vmexit noreturn

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka It calls cpu_loop_exit in system emulation mode (and should never be called in user emulation mode). Signed-off-by: Jan Kiszka --- target/i386/cpu.h| 4 ++-- target/i386/svm_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.

Re: [Qemu-devel] [PATCH for-2.12 v4 0/2] Update output of some iotests

2018-04-03 Thread Kevin Wolf
Am 22.03.2018 um 15:45 hat Alberto Garcia geschrieben: > I sent a patch a few days ago correction the output of iotests 051 and > 186. I wanted to resend it again but I noticed that 186 needs now more > changes due to commit ac64273c66ab136c44043259162, so I'm including > those changes too. [ Cc:

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-04-03 Thread Su Hang
Please ignore this email, this patch was accidentally sent. "Su Hang" wrote: > checkpatch.pl stops complaining about following pattern: > """ > do { > //do somethins; > } while (conditions); > """ > > One things need to be mentioned: > Becasue `if`, `while` and `for` check have been done in t

[Qemu-devel] [PATCH 2/2] Add QTest testcase for the Hex File Loader

2018-04-03 Thread Su Hang
'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Signed-off-by: Su

[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. Su Hang (2): Implement .hex file loader Add QTest testcase for the Intel Hexadecimal Object File Loader. hw/arm/boot.c | 9 +- hw/core/loader.c | 280

[Qemu-devel] [PATCH 1/2] Implement .hex file loader

2018-04-03 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Arduino, ARM, STM32, etc. Sugges

Re: [Qemu-devel] [PATCH for 2.12] iotests: fix 208 for luks format

2018-04-03 Thread Kevin Wolf
Am 30.03.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Support luks images creatins like in 205 > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Eduardo Habkost
On Tue, Apr 03, 2018 at 04:32:53PM +0200, Igor Mammedov wrote: > On Thu, 29 Mar 2018 13:24:09 -0300 > Eduardo Habkost wrote: > > > On Thu, Mar 29, 2018 at 01:43:03PM +0200, Igor Mammedov wrote: > > > On Wed, 28 Mar 2018 16:21:48 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Mar 28,

[Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support

2018-04-03 Thread Jan Kiszka
These patches allow to run Jailhouse in emulated x86-64 mode under QEMU. AMD IOMMU only works with one additional hack, but that's a different story, and we can test these changes without it. Change in v2: - build fix for 32-bit hosts - replaces NPT exitinfo magics with symbolic constants Jan

[Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka This implements NPT suport for SVM by hooking into x86_cpu_handle_mmu_fault where it reads the stage-1 page table. Whether we need to perform this 2nd stage translation, and how, is decided during vmrun and stored in hflags as well as nested_cr3 and nested_pg_mode. As get_hphys

[Qemu-devel] [PATCH v2 1/4] target-i386: Add NMI interception to SVM

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka Check for SVM interception prior to injecting an NMI. Tested via the Jailhouse hypervisor. Signed-off-by: Jan Kiszka --- target/i386/seg_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c index 600a4d7586..00301a0c0

[Qemu-devel] [PATCH v2 2/4] target-i386: Allow interrupt injection after STGI

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka We need to terminate the translation block after STGI so that pending interrupts can be injected. This fixes pending NMI injection for Jailhouse which uses "stgi; clgi" to open a brief injection window. Signed-off-by: Jan Kiszka --- target/i386/translate.c | 3 ++- 1 file cha

Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522769426-6056-1-git-send-email-suhan...@mails.ucas.ac.cn Subject: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH v2 3/4] target-i386: Mark cpu_vmexit noreturn

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka It calls cpu_loop_exit in system emulation mode (and should never be called in user emulation mode). Signed-off-by: Jan Kiszka --- target/i386/cpu.h| 4 ++-- target/i386/svm_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/67] target/arm: Scalable Vector Extension

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > This is 99% of the instruction set. There are a few things missing, > notably first-fault and non-fault loads (even these are decoded, but > simply treated as normal loads for now). I've finished my quick pass, apart from the individual comments I think it looks pre

Re: [Qemu-devel] [PATCH] tcg: fix 16-byte vector operations detection

2018-04-03 Thread Laurent Vivier
On 29/03/2018 18:54, Laurent Vivier wrote: > Hi, > > I think it would be good to have this fix (or something similar) in -rc2. So no one agrees with that? Thanks, Laurent

Re: [Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1522769774.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-04-03 Thread Max Reitz
On 2018-03-30 17:32, Vladimir Sementsov-Ogievskiy wrote: > 30.03.2018 16:31, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2018 18:09, Vladimir Sementsov-Ogievskiy wrote: >>> 29.03.2018 17:03, Max Reitz wrote: On 2018-03-29 10:08, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2018 17:53, Max

[Qemu-devel] [PULL 0/3] Block patches for 2.12-rc2

2018-04-03 Thread Jeff Cody
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/bl

[Qemu-devel] [PULL 2/3] blockjob: use qapi enum helpers

2018-04-03 Thread Jeff Cody
From: Marc-André Lureau QAPI generator provide #define helpers for looking up enum string. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Message-id: 20180327153011.29569-1-marcandre.lur...@redhat.com Signed-off-by: Jeff Cody --- blockjob.c | 14 +- 1 file changed, 5 ins

[Qemu-devel] [PULL 3/3] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Jeff Cody
From: Kevin Wolf The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax.

[Qemu-devel] [PULL 1/3] blockjob: leak fix, remove from txn when failing early

2018-04-03 Thread Jeff Cody
From: Marc-André Lureau This fixes leaks found by ASAN such as: GTESTER tests/test-blockjob = ==31442==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f88483cba38 in _

Re: [Qemu-devel] [PATCH] iotests: fix 169

2018-04-03 Thread Max Reitz
On 2018-03-30 18:10, Vladimir Sementsov-Ogievskiy wrote: > Use MIGRATION events instead of RESUME. Also, make a TODO: enable > dirty-bitmaps capability for offline case. > > This (likely) fixes racy faults at least of the following types: > > - timeout on waiting for RESUME event > - sha2

Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock

2018-04-03 Thread Alex Bennée
Max Filippov writes: > cpu_copy adds newly created CPU object to container/machine/unattached, > but does it w/o proper locking. As a result when multiple threads are > created rapidly QEMU may abort with the following message: > > GLib-CRITICAL **: g_hash_table_iter_next: assertion > 'ri->v

[Qemu-devel] [PULL 1/9] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Kevin Wolf
The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax. https://bugzilla.re

[Qemu-devel] [PULL 3/9] iotests: Update 051 and 186 after commit 1454509726719e0933c

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Cc: Thomas Huth Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051.pc.out | 20 -

[Qemu-devel] [PULL 2/9] block: handle invalid lseek returns gracefully

2018-04-03 Thread Kevin Wolf
From: Jeff Cody In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a workaround in the gluster driver to handle invalid values returned for SEEK_DATA or SEEK_HOLE. In some instances, these same invalid values can be seen in the posix file handler as well - for example, it has bee

[Qemu-devel] [PULL 5/9] iotests: fix 208 for luks format

2018-04-03 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Support luks images creatins like in 205 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- tests/qemu-iotests/208 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208 inde

[Qemu-devel] [PULL 8/9] qemu-iotests: Use ppc64 qemu_arch on ppc64le host

2018-04-03 Thread Kevin Wolf
From: Lukáš Doktor The qemu target does not always correspond to the host machine type. For example ppc64le machine target is ppc64. Let's introduce "qemu_arch" variable to store the matching qemu architecture related to the current architecture and use it when auto-detecting the default qemu bin

[Qemu-devel] [PULL 7/9] iotests: Test preallocated truncate of 2G image

2018-04-03 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Message-id: 20180228131315.30194-3-mre...@redhat.com Reviewed-by: Daniel P. Berrangé Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/106 | 24 tests/qemu-iotests/106.out | 10 ++ 2 files cha

[Qemu-devel] [PULL 9/9] iotests: Test abnormally large size in compressed cluster descriptor

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a m

[Qemu-devel] [PULL 4/9] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia Commit ac64273c66ab136c44 modified the output of iotest 186, changing the QOM path of floppy drives from /machine/unattached/device[17] to /machine/unattached/device[13]. Instead of updating the test output to reflect this change, this patch adds a new filter that hides all

[Qemu-devel] [PULL 0/9] Block layer patches for 2.12.0-rc2

2018-04-03 Thread Kevin Wolf
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PULL 6/9] block/file-posix: Fix fully preallocated truncate

2018-04-03 Thread Kevin Wolf
From: Max Reitz Storing the lseek() result in an int results in it overflowing when the file is at least 2 GB big. Then, we have a 50 % chance of the result being "negative" and thus thinking an error occurred when actually everything went just fine. So we should use the correct type for storin

  1   2   >